From 004bcc43c31ffd5ff531c319f00b818f09dd4c2d Mon Sep 17 00:00:00 2001 From: Johann Hoffmann Date: Fri, 29 May 2026 09:50:37 +0200 Subject: [PATCH] merged stv saveProjektarbeit/saveBetreuer buttons; benoten button for betreuer is now a table action button; remove viewData.uid and call student_uid via authinfo endpoint; digital signature info links in student abgabetool; show projektarbeit note in overview inside the accordions content aswell as flex-end in the header; smaller vertical padding on all abgabetool modals from 3rem to 1.5 rem aka py-5 to py-4; --- application/config/abgabe.php | 3 + .../controllers/api/frontend/v1/Abgabe.php | 8 +- public/js/apps/Abgabetool/Abgabetool.js | 11 +-- .../Cis/Abgabetool/AbgabeMitarbeiterDetail.js | 7 +- .../Cis/Abgabetool/AbgabeStudentDetail.js | 38 ++++++-- .../Cis/Abgabetool/AbgabetoolAssistenz.js | 28 +++--- .../Cis/Abgabetool/AbgabetoolMitarbeiter.js | 89 ++++++++++++++++--- .../Cis/Abgabetool/AbgabetoolStudent.js | 36 +++++--- .../Details/Projektarbeit/Projektarbeit.js | 5 +- .../Details/Projektarbeit/Projektbetreuer.js | 25 +++--- system/phrasesupdate.php | 20 +++++ 11 files changed, 197 insertions(+), 73 deletions(-) diff --git a/application/config/abgabe.php b/application/config/abgabe.php index 3427046cd..e1cdfbfa7 100644 --- a/application/config/abgabe.php +++ b/application/config/abgabe.php @@ -38,6 +38,9 @@ $config['SIGNATUR_CHECK_PAABGABETYPEN'] = ['end']; // to be used as "https://moodle.technikum-wien.at/course/view.php?idnumber=dl{$stg_kz}" for stg specific moodle routing $config['STG_MOODLE_LINK'] = 'https://moodle.technikum-wien.at/course/view.php?idnumber=dl'; +// TODO: check if these links change if the file changes and how to better retrieve the link? +$config['SIGNATUR_INFO_LINK_GERMAN'] = 'https://cis.technikum-wien.at/cms/dms.php?id=214779'; +$config['SIGNATUR_INFO_LINK_ENGLISH'] = 'https://cis.technikum-wien.at/cms/dms.php?id=264256'; $config['ASSISTENZ_SAMMELMAIL_BUTTON_STUDENT'] = true; $config['ASSISTENZ_SAMMELMAIL_BUTTON_BETREUER'] = true; diff --git a/application/controllers/api/frontend/v1/Abgabe.php b/application/controllers/api/frontend/v1/Abgabe.php index 5ba0ef172..e6e395aec 100644 --- a/application/controllers/api/frontend/v1/Abgabe.php +++ b/application/controllers/api/frontend/v1/Abgabe.php @@ -114,11 +114,15 @@ class Abgabe extends FHCAPI_Controller $moodle_link = $this->config->item('STG_MOODLE_LINK'); $title_edit_allowed = $this->config->item('STUDENT_EDIT_PROJEKTARBEIT_TITLE'); $confetti_on_endupload = $this->config->item('CONFETTI_ON_ENDUPLOAD'); - + $siginfolink_german = $this->config->item('SIGNATUR_INFO_LINK_GERMAN'); + $siginfolink_english = $this->config->item('SIGNATUR_INFO_LINK_ENGLISH'); + $ret = array( 'moodle_link' => $moodle_link, 'title_edit_allowed' => $title_edit_allowed, - 'confetti_on_endupload' => $confetti_on_endupload + 'confetti_on_endupload' => $confetti_on_endupload, + 'siginfolink_german' => $siginfolink_german, + 'siginfolink_english' => $siginfolink_english ); $this->terminateWithSuccess($ret); diff --git a/public/js/apps/Abgabetool/Abgabetool.js b/public/js/apps/Abgabetool/Abgabetool.js index 83233ba22..748f10159 100644 --- a/public/js/apps/Abgabetool/Abgabetool.js +++ b/public/js/apps/Abgabetool/Abgabetool.js @@ -25,9 +25,6 @@ const app = Vue.createApp({ }, computed: { - viewData() { - return { uid: this.uid} - }, student_uid_computed() { return this.student_uid ?? this.uid }, @@ -55,10 +52,10 @@ const app = Vue.createApp({ }, template: ` ` }); diff --git a/public/js/components/Cis/Abgabetool/AbgabeMitarbeiterDetail.js b/public/js/components/Cis/Abgabetool/AbgabeMitarbeiterDetail.js index abd647af2..fb564ad98 100644 --- a/public/js/components/Cis/Abgabetool/AbgabeMitarbeiterDetail.js +++ b/public/js/components/Cis/Abgabetool/AbgabeMitarbeiterDetail.js @@ -625,6 +625,7 @@ export const AbgabeMitarbeiterDetail = { dialogClass="bordered-modal modal-lg" :backdrop="true" @hideBsModal="showAutomagicModalPhrase=false;" + bodyClass="px-4 py-4" > @@ -947,7 +945,8 @@ export const AbgabeMitarbeiterDetail = { + dialogClass="bordered-modal modal-lg" + bodyClass="px-4 py-4">