From 0509a26b1ebdad533505e5b046771a619fac4198 Mon Sep 17 00:00:00 2001 From: Paolo Date: Fri, 23 Nov 2018 11:36:22 +0100 Subject: [PATCH] Removed not useful code --- application/libraries/FiltersLib.php | 11 +++++------ application/libraries/PhrasesLib.php | 1 - 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/application/libraries/FiltersLib.php b/application/libraries/FiltersLib.php index 51c399f29..5d9fb5b26 100644 --- a/application/libraries/FiltersLib.php +++ b/application/libraries/FiltersLib.php @@ -263,7 +263,6 @@ class FiltersLib public function generateDatasetQuery($query, $filters) { $datasetQuery = 'SELECT * FROM ('.$query.') '.self::DATASET_TABLE_ALIAS; - $trimedval = trim($query); // If the given query is valid and the parameter filters is an array if (!isEmptyString($query) && $filters != null && is_array($filters)) @@ -366,7 +365,7 @@ class FiltersLib public function removeSelectedField($selectedField) { $removeSelectedField = false; - $trimedval = (isset($selectedField)?trim($selectedField):''); + // Checks the parameter selectedField if (!isEmptyString($selectedField)) { @@ -400,7 +399,7 @@ class FiltersLib public function addSelectedField($selectedField) { $removeSelectedField = false; - $trimedval = (isset($selectedField)?trim($selectedField):''); + // Checks the parameter selectedField if (!isEmptyString($selectedField)) { @@ -429,7 +428,7 @@ class FiltersLib public function removeAppliedFilter($appliedFilter) { $removeAppliedFilter = false; - $trimedval = (isset($appliedFilter)?trim($appliedFilter):''); + // Checks the parameter appliedFilter if (!isEmptyString($appliedFilter)) { @@ -517,7 +516,7 @@ class FiltersLib public function addFilter($filter) { $addFilter = false; - $trimedval = (isset($filter)?trim($filter):''); + // Checks the parameter filter if (!isEmptyString($filter)) { @@ -560,7 +559,7 @@ class FiltersLib public function saveCustomFilter($customFilterDescription) { $saveCustomFilter = false; // by default returns a failure - $trimedval = (isset($customFilterDescription)?trim($customFilterDescription):''); + // Checks parameter customFilterDescription if not valid stop the execution if (isEmptyString($customFilterDescription)) { diff --git a/application/libraries/PhrasesLib.php b/application/libraries/PhrasesLib.php index 88e79b467..6793f38e0 100644 --- a/application/libraries/PhrasesLib.php +++ b/application/libraries/PhrasesLib.php @@ -194,7 +194,6 @@ class PhrasesLib { $_phrase = $this->_phrases[$i]; // single phrase - $trimedval = trim($_phrase->text); // If the single phrase match the given parameters and is not an empty string if ($_phrase->category == $category && $_phrase->phrase == $phrase