From d38641e31287f2fcf0966c73d66daedae82cbf88 Mon Sep 17 00:00:00 2001 From: adisposkofh Date: Wed, 6 May 2026 13:22:38 +0200 Subject: [PATCH 1/6] displaying student personal identity number and matriculation number --- application/config/searchcis.php | 3 ++- public/js/components/Cis/Profil/StudentProfil.js | 4 ++++ public/js/components/Cis/Profil/StudentViewProfil.js | 4 ++++ public/js/components/searchbar/result/student.js | 10 ++++++++-- 4 files changed, 18 insertions(+), 3 deletions(-) diff --git a/application/config/searchcis.php b/application/config/searchcis.php index 12bad025d..6d513c499 100644 --- a/application/config/searchcis.php +++ b/application/config/searchcis.php @@ -22,8 +22,9 @@ unset($config['student']['searchfields']['email']); unset($config['student']['searchfields']['tel']); $config['student']['resultfields'] = [ "s.student_uid AS uid", - "s.matrikelnr", + "s.matrikelnr AS personenkennzeichen", "p.person_id", + "p.matr_nr AS matrikelnummer", "(p.vorname || ' ' || p.nachname) AS name", "ARRAY[s.student_uid || '@' || '" . DOMAIN . "'] AS email", "CASE diff --git a/public/js/components/Cis/Profil/StudentProfil.js b/public/js/components/Cis/Profil/StudentProfil.js index fbf893b27..9b0367f84 100644 --- a/public/js/components/Cis/Profil/StudentProfil.js +++ b/public/js/components/Cis/Profil/StudentProfil.js @@ -230,6 +230,10 @@ export default { label: `${this.$p.t('person','personenkennzeichen')}`, value: this.data.personenkennzeichen }, + matrikelnummer: { + label: this.$p.t('person/matrikelnummer'), + value: this.data.matrikelnummer + }, studiengang: { label: `${this.$p.t('lehre','studiengang')}`, value: this.data.studiengang diff --git a/public/js/components/Cis/Profil/StudentViewProfil.js b/public/js/components/Cis/Profil/StudentViewProfil.js index 0f7a196f4..426bb9df3 100644 --- a/public/js/components/Cis/Profil/StudentViewProfil.js +++ b/public/js/components/Cis/Profil/StudentViewProfil.js @@ -64,6 +64,10 @@ export default { label: `${this.$p.t("person", "personenkennzeichen")}`, value: this.data.personenkennzeichen, }, + matrikelnummer: { + label: this.$p.t('person/matrikelnummer'), + value: this.data.matrikelnummer + }, studiengang: { label: `${this.$p.t("lehre", "studiengang")}`, value: this.data.studiengang, diff --git a/public/js/components/searchbar/result/student.js b/public/js/components/searchbar/result/student.js index db31bb689..d6f7bc238 100644 --- a/public/js/components/searchbar/result/student.js +++ b/public/js/components/searchbar/result/student.js @@ -25,7 +25,7 @@ export default { return new Set(this.res.email); } }, - template: ` + template: /*html*/ ` +
+
{{ $p.t('abschlusspruefung/personenkennzeichen') }}
+
+ {{ res.personenkennzeichen }} +
+
{{ $p.t('person/matrikelnummer') }}
- {{ res.matrikelnr }} + {{ res.matrikelnummer }}
From 57e901be27a6d66bd3609d5abb50702c7a4196a2 Mon Sep 17 00:00:00 2001 From: adisposkofh Date: Wed, 6 May 2026 13:41:16 +0200 Subject: [PATCH 2/6] other_lv_plan permission on reservations --- application/controllers/api/frontend/v1/LvPlan.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/application/controllers/api/frontend/v1/LvPlan.php b/application/controllers/api/frontend/v1/LvPlan.php index dc87732b9..2e8ac52d4 100644 --- a/application/controllers/api/frontend/v1/LvPlan.php +++ b/application/controllers/api/frontend/v1/LvPlan.php @@ -99,7 +99,7 @@ class LvPlan extends FHCAPI_Controller $end_date = $this->input->post('end_date', true); $uid = $this->input->post('uid', true); - // disallow accessing other user's lv plan if missing permission + // disallow accessing other user's events if missing permission if ($uid && $uid !== getAuthUID() && !$this->permissionlib->isBerechtigt('basis/other_lv_plan')) { $this->terminateWithError("Missing permission to view other users' timetables!"); } @@ -288,6 +288,11 @@ class LvPlan extends FHCAPI_Controller $end_date = $this->input->post('end_date', true); $uid = $this->input->post('uid', true); + // disallow accessing other user's reservierungen if missing permission + if ($uid && $uid !== getAuthUID() && !$this->permissionlib->isBerechtigt('basis/other_lv_plan')) { + $this->terminateWithError("Missing permission to view other users' timetables!"); + } + // get data $this->load->library('StundenplanLib'); From adba14f6e77270e0b6d702fed7cc8d5a7672d200 Mon Sep 17 00:00:00 2001 From: adisposkofh Date: Wed, 6 May 2026 13:49:43 +0200 Subject: [PATCH 3/6] avoiding search when search string is empty --- public/js/components/searchbar/searchbar.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/public/js/components/searchbar/searchbar.js b/public/js/components/searchbar/searchbar.js index 868a355cd..e865d525e 100644 --- a/public/js/components/searchbar/searchbar.js +++ b/public/js/components/searchbar/searchbar.js @@ -364,6 +364,9 @@ export default { } if (this.abortController) this.abortController.abort(); + + if (!this.searchsettings.searchstr?.length) return; + this.abortController = new AbortController(); this.searchfunction(this.searchsettings, { From 80306dadf7bbe47621c4e7060beadded7bf6900b Mon Sep 17 00:00:00 2001 From: adisposkofh Date: Wed, 6 May 2026 15:29:33 +0200 Subject: [PATCH 4/6] fixed issue with missing nullsafe operators --- .../StudiengangInformation.js | 80 +++++++++---------- .../StudiengangPerson.js | 2 +- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/public/js/components/Cis/Cms/StudiengangInformation/StudiengangInformation.js b/public/js/components/Cis/Cms/StudiengangInformation/StudiengangInformation.js index aa2438044..a44ea5227 100644 --- a/public/js/components/Cis/Cms/StudiengangInformation/StudiengangInformation.js +++ b/public/js/components/Cis/Cms/StudiengangInformation/StudiengangInformation.js @@ -29,51 +29,51 @@ components:{ }, template:/*html*/`
- -