blackicedbear/FHC-Core
1
0
Fork 0
mirror of https://github.com/FH-Complete/FHC-Core.git synced 2026-06-01 12:19:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed check of size functions in loop statements in CS

Browse Source
This commit is contained in:
Paolo
2017-08-22 10:32:11 +02:00
parent 17acfa3945
commit 1afe6c00a1
2 changed files with 1 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/codesniffer/FHComplete/Sniffs/NamingConventions/ValidFunctionNameSniff.php
-19
View File
@@ -105,25 +105,6 @@ class FHComplete_Sniffs_NamingConventions_ValidFunctionNameSniff extends PHP_Cod
return; return;
} }
} }
//elseif ($isPrivate === true) {
// if (substr($methodName, 0, 2) !== '__') {
// $error = 'Private method name "%s" must be prefixed with 2 underscores';
// $phpcsFile->addError($error, $stackPtr, 'PrivateNoUnderscore', $errorData);
// return;
// } else {
// $filename = $phpcsFile->getFilename();
// if (strpos($filename, '/lib/Cake/') === true) {
// $warning = 'Private method name "%s" in FHComplete core is discouraged';
// $phpcsFile->addWarning($warning, $stackPtr, 'PrivateMethodInCore', $errorData);
// }
// }
//} else {
// if ($methodName[0] !== '_' || substr($methodName, 0, 2) === '__') {
// $error = 'Protected method name "%s" must be prefixed with one underscore';
// $phpcsFile->addError($error, $stackPtr, 'ProtectedNoUnderscore', $errorData);
// return;
// }
//}
} }
/** /**
tests/codesniffer/FHComplete/ruleset.xml
+1 -25
View File
@@ -14,6 +14,7 @@
<exclude name="Squiz.ControlStructures.ControlSignature" /> <exclude name="Squiz.ControlStructures.ControlSignature" />
<exclude name="Squiz.Classes.ValidClassName" /> <exclude name="Squiz.Classes.ValidClassName" />
<exclude name="Generic.ControlStructures.InlineControlStructure" /> <exclude name="Generic.ControlStructures.InlineControlStructure" />
<exclude name="Squiz.PHP.DisallowSizeFunctionsInLoops" />
</rule> </rule>
<rule ref="Generic.Files.LineLength"> <rule ref="Generic.Files.LineLength">
@@ -22,31 +23,6 @@
<property name="absoluteLineLimit" value="150"/> <property name="absoluteLineLimit" value="150"/>
</properties> </properties>
</rule> </rule>
<!--
<rule ref="Squiz.Classes.ValidClassName">
<type>warning</type>
</rule>
Temporarily ignore until API docblock formatting and line length issues in core code are fixed.
<rule ref="FHComplete.Commenting.FunctionComment.ParamCommentNotCapital">
<severity>0</severity>
</rule>
<rule ref="FHComplete.Commenting.FunctionComment.ParamCommentFullStop">
<severity>0</severity>
</rule>
<rule ref="FHComplete.Commenting.FunctionComment.ThrowsNotCapital">
<severity>0</severity>
</rule>
<rule ref="FHComplete.Commenting.FunctionComment.ThrowsNoFullStop">
<severity>0</severity>
</rule>
<rule ref="FHComplete.Commenting.FunctionComment.EmptyThrows">
<severity>0</severity>
</rule>
-->
<rule ref="Squiz.Arrays.ArrayBracketSpacing"/> <rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
<rule ref="Squiz.Classes.LowercaseClassKeywords"/> <rule ref="Squiz.Classes.LowercaseClassKeywords"/>