Issues: Geburtsnation fehlt, Falscher Incoming Zweck: added person Id, added issue checker component to Studierendenverwaltung header, added comments to issues, set some issues to self-resolving, Plausicheck GUI: issues from core, dvuh and bis are displayed

application/libraries/issues/plausichecks/AbschlussstatusFehlt.php

@@ -57,6 +57,7 @@ class AbschlussstatusFehlt extends PlausiChecker
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/AktSemesterNull.php

@@ -57,6 +57,7 @@ class AktSemesterNull extends PlausiChecker
 	 * @param studiensemester_kurzbz string check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/AktiverStudentOhneStatus.php

@@ -49,6 +49,7 @@ class AktiverStudentOhneStatus extends PlausiChecker
 	 * Students with active Benutzer should have a status in the current semester.
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/AktiverStudentstatusOhneKontobuchung.php

@@ -63,6 +63,7 @@ class AktiverStudentstatusOhneKontobuchung extends PlausiChecker
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/AusbildungssemPrestudentUngleichAusbildungssemStatus.php

@@ -66,6 +66,7 @@ class AusbildungssemPrestudentUngleichAusbildungssemStatus extends PlausiChecker
 	 * @param studiensemester_kurzbz string check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/BewerberNichtZumRtAngetreten.php

@@ -60,6 +60,7 @@ class BewerberNichtZumRtAngetreten extends PlausiChecker
 	 * @param studiensemester_kurzbz string check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/DatumAbschlusspruefungFehlt.php

@@ -60,6 +60,7 @@ class DatumAbschlusspruefungFehlt extends PlausiChecker
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param abschlusspruefung_id int if check is to be executed for a certain Abschlussprüfung
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/DatumSponsionFehlt.php

@@ -60,6 +60,7 @@ class DatumSponsionFehlt extends PlausiChecker
 	 * @param studiensemester_kurzbz string check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param abschlusspruefung_id int if check is to be executed only for a certain Abschlussprüfung
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/DatumStudiensemesterFalscheReihenfolge.php

@@ -51,6 +51,7 @@ class DatumStudiensemesterFalscheReihenfolge extends PlausiChecker
 	 * Status Dates and status studysemester dates should be in correct order.
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if check is to be executed only for certain Studiengaenge
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/DualesStudiumOhneMarkierung.php

@@ -63,6 +63,7 @@ class DualesStudiumOhneMarkierung extends PlausiChecker
 	 * @param studiensemester_kurzbz string check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/FalscheAnzahlAbschlusspruefungen.php

@@ -57,6 +57,7 @@ class FalscheAnzahlAbschlusspruefungen extends PlausiChecker
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/FalscherIncomingZweckPlausi.php

@@ -20,12 +20,14 @@ class FalscherIncomingZweckPlausi extends PlausiChecker
 		$studiensemester_kurzbz = isset($params['studiensemester_kurzbz']) ? $params['studiensemester_kurzbz'] : null;
 		$studiengang_kz = isset($params['studiengang_kz']) ? $params['studiengang_kz'] : null;
 		$bisio_id = isset($params['bisio_id']) ? $params['bisio_id'] : null;
+		$person_id = isset($params['person_id']) ? $params['person_id'] : null;
 
 		// get all students failing the plausicheck
 		$prestudentRes = $this->_getFalscherIncomingZweck(
 			$studiensemester_kurzbz,
 			$studiengang_kz,
 			$bisio_id,
+			$person_id,
 			$exkludierte_studiengang_kz
 		);
 
@@ -52,10 +54,11 @@ class FalscherIncomingZweckPlausi extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * Incomings should have the correct Zweck.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param bisio_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */
@@ -63,6 +66,7 @@ class FalscherIncomingZweckPlausi extends PlausiChecker
 		$studiensemester_kurzbz = null,
 		$studiengang_kz = null,
 		$bisio_id = null,
+		$person_id = null,
 		$exkludierte_studiengang_kz = null
 	) {
 
@@ -110,6 +114,12 @@ class FalscherIncomingZweckPlausi extends PlausiChecker
 			$params[] = $bisio_id;
 		}
 
+		if (isset($person_id))
+		{
+			$qry .= " AND zwecke.person_id = ?";
+			$params[] = $person_id;
+		}
+
 		if (isset($exkludierte_studiengang_kz) && !isEmptyArray($exkludierte_studiengang_kz))
 		{
 			$qry .= " AND zwecke.studiengang_kz NOT IN ?";

application/libraries/issues/plausichecks/GeburtsnationFehlt.php

@@ -51,17 +51,17 @@ class GeburtsnationFehlt extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * Geburtsnation is missing.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
-	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */
 	private function _getGeburtsnationFehlt(
 		$studiensemester_kurzbz = null,
 		$studiengang_kz = null,
-		$prestudent_id = null,
+		$person_id = null,
 		$exkludierte_studiengang_kz = null
 	) {
 		$params = array();
@@ -91,10 +91,10 @@ class GeburtsnationFehlt extends PlausiChecker
 			$params[] = $studiengang_kz;
 		}
 
-		if (isset($prestudent_id))
+		if (isset($person_id))
 		{
-			$qry .= " AND pre.prestudent_id = ?";
-			$params[] = $prestudent_id;
+			$qry .= " AND pre.person_id = ?";
+			$params[] = $person_id;
 		}
 
 		if (isset($exkludierte_studiengang_kz) && !isEmptyArray($exkludierte_studiengang_kz))

application/libraries/issues/plausichecks/InaktiverStudentAktiverStatus.php

@@ -60,6 +60,7 @@ class InaktiverStudentAktiverStatus extends PlausiChecker
 	 * @param studiensemester_kurzbz string check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/IncomingOhneIoDatensatz.php

@@ -49,6 +49,7 @@ class IncomingOhneIoDatensatz extends PlausiChecker
 	 * Incoming should have IN/OUT data.
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/IncomingOrGsFoerderrelevant.php

@@ -57,6 +57,7 @@ class IncomingOrGsFoerderrelevant extends PlausiChecker
 	 * @param studiensemester_kurzbz string check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return object success or error
 	 */

application/libraries/issues/plausichecks/InskriptionVorLetzerBismeldung.php

@@ -61,7 +61,7 @@ class InskriptionVorLetzerBismeldung extends PlausiChecker
 
 	/**
 	 * Students of a semester shouldn't start studies before the date of Bismeldung.
-	 * e.g. If student studies in WS2022 datum of status shouldn't be before 15.4.2020
+	 * e.g. If student studies in WS2022 datum of status shouldn't be before 15.4.2022
 	 * e.g. If student studies in SS2022 datum of status shouldn't be before 15.11.2022
 	 * @param studiensemester_kurzbz string check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
@@ -79,6 +79,8 @@ class InskriptionVorLetzerBismeldung extends PlausiChecker
 		// get Bismeldedatum
 		$datumBis = $this->_getBisdateFromSemester($studiensemester_kurzbz);
 
+		if (!$datumBis) return success([]);
+
 		$params = array($datumBis, $studiensemester_kurzbz, $datumBis);
 
 		// get active students
@@ -141,17 +143,16 @@ class InskriptionVorLetzerBismeldung extends PlausiChecker
 	 */
 	private function _getBisdateFromSemester($studiensemester_kurzbz)
 	{
-		$semesterYear = substr($studiensemester_kurzbz, 2, 6);
-		$semesterType = substr($studiensemester_kurzbz, 0, 2);
+		$bisdate = null;
 
-		if ($semesterType == 'SS')
-		{
-			return date_format(date_create(($semesterYear - 1)."-11-15"), 'Y-m-d');
-		}
+		$this->_ci->load->model('organisation/Studiensemester_model', 'StudiensemesterModel');
+		$prevSemester = $this->_ci->StudiensemesterModel->getPreviousFrom($studiensemester_kurzbz);
+		if (!hasData($prevSemester)) return null;
+		$prevSemester = getData($prevSemester)[0]->studiensemester_kurzbz;
 
-		if ($semesterType == 'WS')
-		{
-			return date_format(date_create($semesterYear."-04-15"), 'Y-m-d');
-		}
+		$this->_ci->load->model('codex/Bismeldestichtag_model', 'BismeldestichtagModel');
+		$bisDate = $this->_ci->BismeldestichtagModel->getLastReachedMeldestichtag($prevSemester);
+		if (!hasData($bisDate)) return null;
+		return getData($bisDate)[0]->meldestichtag;
 	}
 }

application/libraries/issues/plausichecks/KeinAufenthaltszweckPlausi.php

@@ -54,7 +54,7 @@ class KeinAufenthaltszweckPlausi extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * Students with mobility should have Aufenthaltszweck.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param bisio_id int if check is to be executed only for one prestudent

application/libraries/issues/plausichecks/OutgoingAngerechneteEctsFehlenPlausi.php

@@ -54,10 +54,11 @@ class OutgoingAngerechneteEctsFehlenPlausi extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * Outgoing should have angerechnete ECTS.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param bisio_id int if check is to be executed only for one prestudent
+	 * @param person_id int if check is to be executed only for one person
 	 * @param exkludierte_studiengang_kz array if certain Studiengänge have to be excluded from check
 	 * @return success with prestudents or error
 	 */

application/libraries/issues/plausichecks/OutgoingAufenthaltfoerderungfehltPlausi.php

@@ -54,7 +54,7 @@ class OutgoingAufenthaltfoerderungfehltPlausi extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * Student with mobility should have Aufenthaltsfoerderung.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param bisio_id int if check is to be executed only for one prestudent

application/libraries/issues/plausichecks/OutgoingErworbeneEctsFehlenPlausi.php

@@ -54,7 +54,7 @@ class OutgoingErworbeneEctsFehlenPlausi extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * Outgoing should have erworbene ECTS.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param bisio_id int if check is to be executed only for one prestudent

application/libraries/issues/plausichecks/UhstatPersonkennungFehltCore.php

@@ -53,7 +53,7 @@ class UhstatPersonkennungFehltCore extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * Student should have Personenkennung for UHSTAT reporting.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent

application/libraries/issues/plausichecks/ZgvDatumInZukunft.php

@@ -54,7 +54,7 @@ class ZgvDatumInZukunft extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * ZGV date should be in the past.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent

application/libraries/issues/plausichecks/ZgvDatumVorGeburtsdatum.php

@@ -54,7 +54,7 @@ class ZgvDatumVorGeburtsdatum extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * Zgv date should be after birthdate.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent

application/libraries/issues/plausichecks/ZgvMasterDatumInZukunft.php

@@ -54,7 +54,7 @@ class ZgvMasterDatumInZukunft extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * ZGV master date should be in the past.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent

application/libraries/issues/plausichecks/ZgvMasterDatumVorGeburtsdatum.php

@@ -54,7 +54,7 @@ class ZgvMasterDatumVorGeburtsdatum extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * ZGV master date should be after birthdate.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent

application/libraries/issues/plausichecks/ZgvMasterDatumVorZgvdatum.php

@@ -54,7 +54,7 @@ class ZgvMasterDatumVorZgvdatum extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * ZGV master date should be before ZGV date.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param prestudent_id int if check is to be executed only for one prestudent

application/libraries/issues/plausichecks/ZuVieleZweckeIncomingPlausi.php

@@ -54,7 +54,7 @@ class ZuVieleZweckeIncomingPlausi extends PlausiChecker
 	}
 
 	/**
-	 * Prestudent should have a final status.
+	 * There should be exactly one Incoming Zweck.
 	 * @param studiensemester_kurzbz string if check is to be executed for certain Studiensemester
 	 * @param studiengang_kz int if check is to be executed for certain Studiengang
 	 * @param bisio_id int if check is to be executed only for one prestudent

application/libraries/issues/resolvers/CORE_PERSON_0005.php

@@ -1,36 +0,0 @@
-<?php
-
-if (! defined('BASEPATH')) exit('No direct script access allowed');
-
-/**
- * Geburtsnation missing
- */
-class CORE_PERSON_0005 implements IIssueResolvedChecker
-{
-	public function checkIfIssueIsResolved($params)
-	{
-		if (!isset($params['issue_person_id']) || !is_numeric($params['issue_person_id']))
-			return error('Person Id missing, issue_id: '.$params['issue_id']);
-
-		$this->_ci =& get_instance(); // get code igniter instance
-
-		$this->_ci->load->model('person/Person_model', 'PersonModel');
-
-		// load geburtsnation for the given person
-		$this->_ci->PersonModel->addSelect('geburtsnation');
-		$personRes = $this->_ci->PersonModel->load($params['issue_person_id']);
-
-		if (isError($personRes)) return $personRes;
-
-		if (hasData($personRes))
-		{
-			// get person data
-			$personData = getData($personRes)[0];
-
-			// if geburtsnation present, issue is resolved
-			return success(!isEmptyString($personData->geburtsnation));
-		}
-		else
-			return success(false); // if no person found, not resolved
-	}
-}