From 287b9616978af5f934ec76354a952fe1b5a2a8bf Mon Sep 17 00:00:00 2001
From: Cris <hainberg@technikum-wien.at>
Date: Mon, 29 Mar 2021 17:55:50 +0200
Subject: [PATCH] Fixed: Added serversite check on required form fields

After refactoring code to apply via AJAX call, required fields
have to be direclty validated in JS or on serversite. Now fixed by
checking on serversite.

Signed-off-by: cris-technikum <hainberg@technikum-wien.at>
---
 .../lehre/anrechnung/requestAnrechnung.php    | 14 +++----
 system/phrasesupdate.php                      | 40 +++++++++++++++++++
 2 files changed, 47 insertions(+), 7 deletions(-)

diff --git a/application/views/lehre/anrechnung/requestAnrechnung.php b/application/views/lehre/anrechnung/requestAnrechnung.php
index af10ef891..749b0f1d5 100644
--- a/application/views/lehre/anrechnung/requestAnrechnung.php
+++ b/application/views/lehre/anrechnung/requestAnrechnung.php
@@ -133,10 +133,10 @@ $this->load->view(
                                                 <div class="checkbox">
                                                     <label>
                                                         <input type="radio" name="begruendung" value="1" required
-                                                            <?php echo $anrechnungData->begruendung_id == '1' ? 'checked' : ''; ?>>
+                                                            <?php echo $anrechnungData->begruendung_id == '1' ? 'checked' : ''; ?> />
                                                         <?php echo $this->p->t('anrechnung', 'antragStellenWegenZeugnis'); ?>&emsp;
                                                         <span id="requestAnrechnung-anrechnungGrundZeugnisTooltip" data-toggle="tooltip" data-placement="right"
-                                                              title="<?php echo $this->p->t('anrechnung', 'anrechnungGrundZeugnisTooltipText'); ?>">
+                                                              title="<?php echo $this->p->t('anrechnung', 'anrechnungGrundZeugnisTooltipText'); ?>" />
                                                         <i class="fa fa-lg fa-info-circle" aria-hidden="true"></i>
                                                     </span>
                                                     </label>
@@ -176,11 +176,11 @@ $this->load->view(
                                                        title="<?php echo $this->p->t('ui', 'uploadTooltipText'); ?>">
                                                         <i class="fa fa-lg fa-question-circle-o" aria-hidden="true"></i>
                                                     </span>
-                                                    <?php if (!empty($anrechnungData->dms_id)): ?>
-                                                        <a class="pull-right"
-                                                           href="<?php echo current_url() . '/download?dms_id=' . $anrechnungData->dms_id; ?>"
-                                                           target="_blank"><?php echo htmlentities($anrechnungData->dokumentname) ?></a>
-                                                    <?php endif; ?>
+                                                    <a class="pull-right <?php echo !empty($anrechnungData->dms_id) ? '' : 'hidden' ?>"
+                                                       id="requestAnrechnung-downloadDocLink"
+                                                       href="<?php echo current_url() . '/download?dms_id=' . $anrechnungData->dms_id; ?>"
+                                                       target="_blank"><?php echo htmlentities($anrechnungData->dokumentname) ?>
+                                                    </a>
                                                 </div>
                                             </div>
                                         </div>
diff --git a/system/phrasesupdate.php b/system/phrasesupdate.php
index 6d8651603..effc3127f 100644
--- a/system/phrasesupdate.php
+++ b/system/phrasesupdate.php
@@ -10450,6 +10450,46 @@ array(
 			)
 		)
 	),
+	array(
+		'app' => 'core',
+		'category' => 'ui',
+		'phrase' => 'errorFelderFehlen',
+		'insertvon' => 'system',
+		'phrases' => array(
+			array(
+				'sprache' => 'German',
+				'text' => "Daten fehlen.<br>Bitte f&uuml;llen Sie alle Formularfelder aus",
+				'description' => '',
+				'insertvon' => 'system'
+			),
+			array(
+				'sprache' => 'English',
+				'text' => "Missing data.<br>Please fill in all form fields",
+				'description' => '',
+				'insertvon' => 'system'
+			)
+		)
+	),
+	array(
+		'app' => 'core',
+		'category' => 'ui',
+		'phrase' => 'errorUploadFehlt',
+		'insertvon' => 'system',
+		'phrases' => array(
+			array(
+				'sprache' => 'German',
+				'text' => "Dokument fehlt.<br>Bitte laden Sie noch die entsprechenden Dokumente hoch.",
+				'description' => '',
+				'insertvon' => 'system'
+			),
+			array(
+				'sprache' => 'English',
+				'text' => "Missing document.<br>Please upload the required documents.",
+				'description' => '',
+				'insertvon' => 'system'
+			)
+		)
+	),
 	
 );