blackicedbear/FHC-Core
1
0
Fork 0
mirror of https://github.com/FH-Complete/FHC-Core.git synced 2026-07-20 16:32:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimized Reihungstest-chronjob code

Browse Source 
. Optimized code by retreiving data directly via model.
. Extended SQL query: study courses are now checked for active = true
This commit is contained in:
Cris
2018-12-06 12:37:22 +01:00
parent 1f6f56f71c
commit 38b195beeb
3 changed files with 17 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
application/controllers/jobs/ReihungstestJob.php
+5 -5
View File
@@ -40,8 +40,8 @@ class ReihungstestJob extends FHC_Controller
$this->VILESCI_RT_VERWALTUNGS_URL = site_url(). "/organisation/Reihungstest";
// Load libraries
$this->load->library('ReihungstestLib');
// Load models
$this->load->model('crm/Reihungstest_model', 'ReihungstestModel');
// Load helpers
$this->load->helper('hlp_sancho_helper');
@@ -63,7 +63,7 @@ class ReihungstestJob extends FHC_Controller
public function runReihungstestJob()
{
// Get study plans that have no assigned placement tests yet
$result = $this->reihungstestlib->checkMissingReihungstest();
$result = $this->ReihungstestModel->checkMissingReihungstest();
$missing_rt_arr = array();
if (hasData($result))
@@ -76,7 +76,7 @@ class ReihungstestJob extends FHC_Controller
}
// Get free places
$result = $this->reihungstestlib->getFreePlaces();
$result = $this->ReihungstestModel->getFreePlaces();
$free_places_arr = array();
if (hasData($result))
@@ -108,7 +108,7 @@ class ReihungstestJob extends FHC_Controller
* Returns associative array with data as needed in the reihungstest job template.
* @param array $missing_rt_arr Array with studienpläne, which have no assigned placement tests.
* @param array $free_places_arr Array with info and amount of free placement test places.
* @return array
* @return array
*/
private function _getContentData($missing_rt_arr, $free_places_arr)
{