From 479feea8aa154e200cac71789fe910d6f1779976 Mon Sep 17 00:00:00 2001
From: Cris <hainberg@technikum-wien.at>
Date: Mon, 6 Mar 2023 15:26:12 +0100
Subject: [PATCH] =?UTF-8?q?Changed=20way=20of=20check=C3=ADng=20Anrechnung?=
 =?UTF-8?q?szeitraum?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Changed function isExpired to check Anrechnungszeitraeume of tbl_anrechnungszeitraum instead of using config entries.
---
 .../lehre/anrechnung/RequestAnrechnung.php    | 46 ++++++++-----------
 1 file changed, 20 insertions(+), 26 deletions(-)

diff --git a/application/controllers/lehre/anrechnung/RequestAnrechnung.php b/application/controllers/lehre/anrechnung/RequestAnrechnung.php
index fbaac9b3e..7a8ef3eb6 100644
--- a/application/controllers/lehre/anrechnung/RequestAnrechnung.php
+++ b/application/controllers/lehre/anrechnung/RequestAnrechnung.php
@@ -80,11 +80,7 @@ class requestAnrechnung extends Auth_Controller
 		$prestudent_id = getData($result)[0]->prestudent_id;
 		
 		// Check if application deadline is expired
-		$is_expired = self::_isExpired(
-			$this->config->item('submit_application_start'),
-			$this->config->item('submit_application_end'),
-			$studiensemester_kurzbz
-		);
+		$is_expired = $this->_isExpired($studiensemester_kurzbz);
 		
 		// Check if Lehrveranstaltung was already graded with application blocking grades
 		$is_blocked = self::_LVhasBlockingGrades($studiensemester_kurzbz, $lehrveranstaltung_id);
@@ -234,32 +230,30 @@ class requestAnrechnung extends Auth_Controller
 	 * @return bool True if deadline is expired
 	 * @throws Exception
 	 */
-	private function _isExpired($start, $ende, $studiensemester_kurzbz)
+	private function _isExpired($studiensemester_kurzbz)
 	{
-		$this->load->model('organisation/Studiensemester_model', 'StudiensemesterModel');
+        $today = new DateTime('today midnight');
 
-		// If start is not given, set to Semesterstart.
-		if (!isset($start) || isEmptyString($start))
-		{
-			$this->StudiensemesterModel->addSelect('start');
-			$result = $this->StudiensemesterModel->load($studiensemester_kurzbz);
-			$start = getData($result)[0]->start;
-		}
+        // Load all Anrechnungszeitfenster for this Studiensemester
+        $this->load->model('education/Anrechnungszeitraum_model', 'AnrechnungszeitraumModel');
+        $result = $this->AnrechnungszeitraumModel->loadWhere(array('studiensemester_kurzbz' => $studiensemester_kurzbz));
 
-		// If ende is not given, set to Semesterende.
-		if (!isset($ende) || isEmptyString($ende))
-		{
-			$this->StudiensemesterModel->addSelect('ende');
-			$result = $this->StudiensemesterModel->load($studiensemester_kurzbz);
-			$ende = getData($result)[0]->ende;
-		}
+        if (hasData($result))
+        {
+            // Loop through Anrechnungszeitfenster
+            foreach (getData($result) as $azrObj)
+            {
+                $start = new DateTime($azrObj->anrechnungstart);
+                $ende = new DateTime($azrObj->anrechnungende);
 
-		$today = new DateTime('today midnight');
-		$start = new DateTime($start);
-		$ende = new DateTime($ende);
+                // Return false if today is at least within one Anrechnungszeitraum
+                if (($today >= $start && $today <= $ende)) return false;
 
-		// True if expired
-		return ($today < $start || $today > $ende);
+            }
+        }
+
+        // Return true if today is in none Anrechnungszeitraum
+        return true;
 	}
 
 	/**