From 4b8b3c90fbadea3895c6f96a3d2ddd7e9e361476 Mon Sep 17 00:00:00 2001 From: Alexei Karpenko Date: Wed, 14 Jan 2026 16:15:33 +0100 Subject: [PATCH] plausicheck resolver: by default, all issues for fehlercodes provided in constructor are resolved --- application/core/IssueResolver_Controller.php | 11 +++------- .../issues/PlausicheckResolverLib.php | 20 +++++++++++++++++-- 2 files changed, 21 insertions(+), 10 deletions(-) diff --git a/application/core/IssueResolver_Controller.php b/application/core/IssueResolver_Controller.php index 0ddf31fbd..74a4eb451 100755 --- a/application/core/IssueResolver_Controller.php +++ b/application/core/IssueResolver_Controller.php @@ -21,6 +21,7 @@ abstract class IssueResolver_Controller extends JOB_Controller */ public function run() { + // initialize librariy with provided fehlercodes $this->load->library( 'issues/PlausicheckResolverLib', [ @@ -30,14 +31,8 @@ abstract class IssueResolver_Controller extends JOB_Controller $this->logInfo("Issue resolve job started"); - // load open issues with given errorcodes - $openIssuesRes = $this->IssueModel->getOpenIssues( - $this->_fehlercodes - ); - - $openIssues = hasData($openIssuesRes) ? getData($openIssuesRes) : []; - - $result = $this->plausicheckresolverlib->resolvePlausicheckIssues($openIssues); + // resolve the issues + $result = $this->plausicheckresolverlib->resolvePlausicheckIssues(); // log if error, or log info if inserted new issue foreach ($result->errors as $error) $this->logError($error); diff --git a/application/libraries/issues/PlausicheckResolverLib.php b/application/libraries/issues/PlausicheckResolverLib.php index bbbd79203..4d9faefcf 100644 --- a/application/libraries/issues/PlausicheckResolverLib.php +++ b/application/libraries/issues/PlausicheckResolverLib.php @@ -109,11 +109,27 @@ class PlausicheckResolverLib /** * Reseolves multiple plausicheck issues at once. - * @param array $openIssues passed issues to resolve + * @param array $openIssues passed issues to resolve. If null, issues with fehlercodes in _fehlercodes property are loaded * @return result object with occured error and info */ - public function resolvePlausicheckIssues($openIssues) + public function resolvePlausicheckIssues($openIssues = null) { + if (!isset($openIssues)) + { + if (!isEmptyArray($this->_fehlercodes)) + { + $this->_ci->load->model('system/Issue_model', 'IssueModel'); + + // load open issues with given errorcodes + $openIssuesRes = $this->_ci->IssueModel->getOpenIssues( + $this->_fehlercodes + ); + + $openIssues = hasData($openIssuesRes) ? getData($openIssuesRes) : []; + } + } + + $result = new StdClass(); $result->errors = []; $result->infos = [];