From 537ce0940ca1200ec46335dd255f4da45ac84fc6 Mon Sep 17 00:00:00 2001 From: Paolo Date: Wed, 31 Aug 2022 15:48:35 +0200 Subject: [PATCH] Code quality check improvements --- application/config/routes.php | 28 ++- .../controllers/person/Gruppenmanagement.php | 8 +- application/helpers/hlp_common_helper.php | 120 +++++----- application/helpers/hlp_header_helper.php | 12 +- application/libraries/ExtensionsLib.php | 60 +++-- application/libraries/FilterCmptLib.php | 35 +-- application/libraries/NavigationLib.php | 21 +- application/libraries/SearchBarLib.php | 4 +- .../lehre/anrechnung/createAnrechnung.php | 4 +- .../lehre/lehrauftrag/acceptLehrauftrag.php | 1 + .../lehre/lehrauftrag/approveLehrauftrag.php | 1 + .../lehre/lehrauftrag/orderLehrauftrag.php | 7 +- .../lvplanung/adminZeitverfuegbarkeit.php | 4 +- .../views/lehre/pruefungsprotokoll.php | 3 +- .../lehre/pruefungsprotokollUebersicht.php | 14 +- application/views/person/bpk/bpkData.php | 1 - application/views/person/bpk/bpkDetails.php | 26 +-- .../views/person/gradelist/gradelist.php | 25 +- .../gruppenmanagementData.php | 2 +- application/views/system/fas_udf.php | 220 +++++++++--------- .../infocenter/infocenterZgvDetails.php | 8 +- .../system/infocenter/studiengangZgvInfo.php | 7 +- .../system/messages/htmlWriteTemplate.php | 5 +- 23 files changed, 347 insertions(+), 269 deletions(-) diff --git a/application/config/routes.php b/application/config/routes.php index b139c6fa3..15da5698f 100644 --- a/application/config/routes.php +++ b/application/config/routes.php @@ -67,21 +67,19 @@ $dirlist = scandir($subdir); if ($dirlist) { - $files = array_diff($dirlist, array('.','..')); + $files = array_diff($dirlist, array('.','..')); - foreach ($files as &$item) - { + foreach ($files as &$item) + { + if (is_dir($subdir . DIRECTORY_SEPARATOR . $item)) + { + $routes_file = $subdir . DIRECTORY_SEPARATOR . $item . DIRECTORY_SEPARATOR . 'routes.php'; - if (is_dir($subdir . DIRECTORY_SEPARATOR . $item)) - { - $routes_file = $subdir . DIRECTORY_SEPARATOR . $item . DIRECTORY_SEPARATOR . 'routes.php'; - - if (file_exists($routes_file)) - { - require($routes_file); - } - - } - - } + if (file_exists($routes_file)) + { + require($routes_file); + } + } + } } + diff --git a/application/controllers/person/Gruppenmanagement.php b/application/controllers/person/Gruppenmanagement.php index 4bc80c760..acf32b00b 100644 --- a/application/controllers/person/Gruppenmanagement.php +++ b/application/controllers/person/Gruppenmanagement.php @@ -77,8 +77,8 @@ class Gruppenmanagement extends Auth_Controller } /** - * Gets Benutzer assigned to a Gruppe - */ + * Gets Benutzer assigned to a Gruppe + */ public function getBenutzer() { $gruppe_kurzbz = $this->input->get('gruppe_kurzbz'); @@ -92,8 +92,8 @@ class Gruppenmanagement extends Auth_Controller } /** - * Gets all Benutzer for assignment to Gruppe - */ + * Gets all Benutzer for assignment to Gruppe + */ public function getAllBenutzer() { $this->BenutzerModel->addSelect('uid, vorname, nachname'); diff --git a/application/helpers/hlp_common_helper.php b/application/helpers/hlp_common_helper.php index ab67d70a1..913d29b54 100644 --- a/application/helpers/hlp_common_helper.php +++ b/application/helpers/hlp_common_helper.php @@ -1,20 +1,19 @@ . */ if (! defined('BASEPATH')) exit('No direct script access allowed'); @@ -42,15 +41,19 @@ function generateToken($length = 64) { $firstGeneratedToken = random_bytes($length); // try to generates cryptographically secure pseudo-random bytes... } - catch (Exception $e) { $firstGeneratedToken = null; } // if fails $firstGeneratedToken is set to null + catch (Exception $e) + { + // If fails $firstGeneratedToken is set to null + $firstGeneratedToken = null; + } } // For PHP >= 5.3 and < 7 and openssl is available elseif (function_exists('openssl_random_pseudo_bytes')) { $firstGeneratedToken = openssl_random_pseudo_bytes($length, $strong); // If the token generation ended with errors OR the generated token is NOT strong enough - if ($firstGeneratedToken == false || $strong == false) $firstGeneratedToken = null; // $firstGeneratedToken is set to null - } + if ($firstGeneratedToken == false || $strong == false) $firstGeneratedToken = null; // $firstGeneratedToken is set to null + } if ($firstGeneratedToken != null) // If everything was fine { @@ -107,10 +110,7 @@ function var_dump_to_error_log($parameter) function loadResource($path, $resources = null, $subdir = false) { // Place a / character at the and of the string if not present - if (strrpos($path, '/') < strlen($path) - 1) - { - $path .= '/'; - } + if (strrpos($path, '/') < strlen($path) - 1) $path .= '/'; // Loads in $tmpResources all the given resources $tmpResources = $resources; @@ -125,28 +125,36 @@ function loadResource($path, $resources = null, $subdir = false) // Loads in $tmpPaths path and eventually the subdirectories $tmpPaths = array($path); - // NOTE: Used @ to prevent ugly error messages - if (is_dir($path) && ($dirHandler = @opendir($path)) !== false) + + // If path is a directory + if (is_dir($path)) { - // Reads all file system entries present in path - while (($entry = readdir($dirHandler)) !== false) + // NOTE: Used @ to prevent ugly error messages + $dirHandler = @opendir($path); + + // Successfully opened + if ($dirHandler !== false) { - // If entry is a directory but not the current and subdirectories should be loaded - if ($subdir === true && $entry != '.' && $entry != '..' && is_dir($path.$entry)) + // Reads all file system entries present in path + while (($entry = readdir($dirHandler)) !== false) { - $tmpPaths[] = $path.$entry.'/'; - } - // If no resources are specified and the current file system entry is a file - if ($resources == null && is_file($path.$entry)) - { - // If the current entry is a php file store the name without extension - if ($entry != ($tmpName = str_replace('.php', '', $entry))) + // If entry is a directory but not the current and subdirectories should be loaded + if ($subdir === true && $entry != '.' && $entry != '..' && is_dir($path.$entry)) { - $tmpResources[] = $tmpName; + $tmpPaths[] = $path.$entry.'/'; + } + // If no resources are specified and the current file system entry is a file + if ($resources == null && is_file($path.$entry)) + { + // Name without php extension + $tmpName = str_replace('.php', '', $entry); + + // If the current entry is a php file store the name without extension + if ($entry != $tmpName) $tmpResources[] = $tmpName; } } + closedir($dirHandler); } - closedir($dirHandler); } // Loops through the resources @@ -156,10 +164,7 @@ function loadResource($path, $resources = null, $subdir = false) foreach ($tmpPaths as $tmpPath) { $fileName = $tmpPath.$tmpResource.'.php'; // Php extension - if (file_exists($fileName)) - { - include_once($fileName); - } + if (file_exists($fileName)) include_once($fileName); } } } @@ -362,36 +367,39 @@ function findResource($path, $resource, $subdir = false, $extraDir = null) // Loads in $tmpPaths path and eventually the subdirectories $tmpPaths = array($path); - // NOTE: Used @ to prevent ugly error messages - if (is_dir($path) && ($dirHandler = @opendir($path)) !== false) + if (is_dir($path)) { - // Reads all file system entries present in path - while (($entry = readdir($dirHandler)) !== false) + // NOTE: Used @ to prevent ugly error messages + $dirHandler = @opendir($path); + + // Successfully opened + if ($dirHandler !== false) { - // If entry is a directory but not the current and subdirectories should be loaded - if ($subdir === true && $entry != '.' && $entry != '..' && is_dir($path.$entry)) + // Reads all file system entries present in path + while (($entry = readdir($dirHandler)) !== false) { - if ($extraDir == null) + // If entry is a directory but not the current and subdirectories should be loaded + if ($subdir === true && $entry != '.' && $entry != '..' && is_dir($path.$entry)) { - $tmpPaths[] = $path.$entry.'/'; - } - else - { - $tmpPaths[] = $path.$entry.'/'.$extraDir.'/'; + if ($extraDir == null) + { + $tmpPaths[] = $path.$entry.'/'; + } + else + { + $tmpPaths[] = $path.$entry.'/'.$extraDir.'/'; + } } } + closedir($dirHandler); } - closedir($dirHandler); } // Loops through the paths foreach ($tmpPaths as $tmpPath) { $fileName = $tmpPath.$resource.'.php'; // Php extension - if (file_exists($fileName)) - { - return $fileName; - } + if (file_exists($fileName)) return $fileName; } return null; diff --git a/application/helpers/hlp_header_helper.php b/application/helpers/hlp_header_helper.php index 5d197e3be..05bba48c4 100644 --- a/application/helpers/hlp_header_helper.php +++ b/application/helpers/hlp_header_helper.php @@ -181,16 +181,26 @@ function generateAddonsJSsInclude($calledFrom) { $aktive_addons = array_filter(explode(";", ACTIVE_ADDONS)); + // For each active addon foreach ($aktive_addons as $addon) { + // Build the path to the hook file $hookfile = DOC_ROOT.'addons/'.$addon.'/hooks.config.inc.php'; + + // If the hook file exists if (file_exists($hookfile)) { - include($hookfile); + $js_hooks = array(); // default value + + include($hookfile); // include the hook file where the array js_hooks should be setup + + // If it contains the provided key calledFrom if (key_exists($calledFrom, $js_hooks)) { foreach ($js_hooks[$calledFrom] as $js_file) + { generateJSsInclude('addons/'.$addon.'/'.$js_file); + } } } } diff --git a/application/libraries/ExtensionsLib.php b/application/libraries/ExtensionsLib.php index f338c942b..77085b182 100644 --- a/application/libraries/ExtensionsLib.php +++ b/application/libraries/ExtensionsLib.php @@ -1,7 +1,25 @@ . + */ if (! defined('BASEPATH')) exit('No direct script access allowed'); +use \stdClass as stdClass; + /** * Library to manage core extensions */ @@ -181,17 +199,15 @@ class ExtensionsLib // Select all the version of this extension $this->_ci->ExtensionsModel->addSelect('extension_id'); $result = $this->_ci->ExtensionsModel->loadWhere(array('name' => $extensionName)); - if (hasData($result)) // if something was found + // If something was found + if (hasData($result)) { - $extsArray = array(); - foreach ($result->retval as $key => $extension) // loops on them + // Loops on them + foreach ($result->retval as $extension) { // Remove them all $result = $this->_ci->ExtensionsModel->delete($extension->extension_id); - if (isSuccess($result)) - { - $delExtension = true; - } + if (isSuccess($result)) $delExtension = true; } } } @@ -432,7 +448,11 @@ class ExtensionsLib // If no errors occurred if ($extensionJson != null) { + // Default value + $fhcomplete_version = 0; + require_once('version.php'); // get the core version + // Checks if the required core version of the extension is the same of this system if (isset($extensionJson->core_version) && $extensionJson->core_version == $fhcomplete_version) { @@ -587,18 +607,22 @@ class ExtensionsLib for ($sqlDir = $startVersion; $sqlDir <= $extensionJson->version; $sqlDir++) { // If a directory with the same value of the version is present in the sql scripts directory - if (($files = glob($pkgSQLsPath.'/'.$sqlDir.'/*'.ExtensionsLib::SQL_FILE_EXTENSION)) != false) - { + $files = glob($pkgSQLsPath.'/'.$sqlDir.'/*'.ExtensionsLib::SQL_FILE_EXTENSION); + if ($files != false) + { // Loads every sql files - foreach ($files as $file) - { - $sql = file_get_contents($file); // gets the entire content of the file + foreach ($files as $file) + { + $sql = file_get_contents($file); // gets the entire content of the file $this->_printMessage('Executing query:'); $this->_printMessage($sql); // Try to execute that - if (!isSuccess($result = @$this->_ci->ExtensionsModel->executeQuery($sql))) + $resultQuery = @$this->_ci->ExtensionsModel->executeQuery($sql); + + // If _not_ a success + if (!isSuccess($resultQuery)) { $this->_errorOccurred = true; $this->_printFailure(' error occurred while executing the query'); @@ -608,11 +632,11 @@ class ExtensionsLib else { $this->_printMessage('Query result:'); - var_dump($result->retval); // KEEP IT!!! + var_dump(getData($resultQuery)); // KEEP IT!!! $this->_ci->eprintflib->printEOL(); } - } - } + } + } } $this->_printSuccess(!$this->_errorOccurred); @@ -673,7 +697,7 @@ class ExtensionsLib foreach ($this->SOFTLINK_TARGET_DIRECTORIES as $rootPath => $targetDirectories) { - foreach ($targetDirectories as $key => $targetDirectory) + foreach ($targetDirectories as $targetDirectory) { if (file_exists($rootPath.$targetDirectory.'/'.ExtensionsLib::EXTENSIONS_DIR_NAME.'/'.$extensionName)) { @@ -727,7 +751,7 @@ class ExtensionsLib // For every target directory foreach ($this->SOFTLINK_TARGET_DIRECTORIES as $rootPath => $targetDirectories) { - foreach ($targetDirectories as $key => $targetDirectory) + foreach ($targetDirectories as $targetDirectory) { // If destination of the symlink does not exist if (!file_exists($rootPath.$targetDirectory.'/'.ExtensionsLib::EXTENSIONS_DIR_NAME.'/'.$extensionName)) diff --git a/application/libraries/FilterCmptLib.php b/application/libraries/FilterCmptLib.php index fc7bb036d..429bc1b3b 100644 --- a/application/libraries/FilterCmptLib.php +++ b/application/libraries/FilterCmptLib.php @@ -18,6 +18,8 @@ if (! defined('BASEPATH')) exit('No direct script access allowed'); +use \stdClass as stdClass; + /** * Filter component logic */ @@ -92,8 +94,8 @@ class FilterCmptLib private $_ci; // Code igniter instance private $_filterUniqueId; // Unique id for this filter component - private $_filterType; // - private $_filterId; // + private $_filterType; // + private $_filterId; // private $_app; private $_datasetName; @@ -133,6 +135,8 @@ class FilterCmptLib // if (!$this->_checkJSParameters()) return; + $filterCmptArray = array(); // default value + // $filePath = findResource(APPPATH.'components/filters/', $this->_filterType, true); if (!isEmptyString($filePath)) @@ -147,7 +151,7 @@ class FilterCmptLib } // - if (!isset($filterCmptArray)) + if (!isset($filterCmptArray) && isEmptyArray($filterCmptArray)) { $this->_setSession(error('Component definition file '.$this->_filterType.' not found')); return; @@ -156,7 +160,7 @@ class FilterCmptLib // if (!$this->_checkPHPParameters($filterCmptArray)) return; - // + // $this->_initFilterCmpt($filterCmptArray); // @@ -340,7 +344,8 @@ class FilterCmptLib if (in_array($selectedField, $fields)) { // If the selected field is present in the list of the selected fields by the current filter - if (($pos = array_search($selectedField, $selectedFields)) !== false) + $pos = array_search($selectedField, $selectedFields); + if ($pos !== false) { // Then remove it and shift the rest of elements by one if needed array_splice($selectedFields, $pos, 1); @@ -453,7 +458,7 @@ class FilterCmptLib // If not an empty array if ($filterField != null) { - // + // if (isset($filterField->name) && isset($filterField->operation) && isset($filterField->condition) && !isEmptyString($filterField->name) && !isEmptyString($filterField->operation) && !isEmptyString($filterField->condition)) @@ -479,14 +484,14 @@ class FilterCmptLib break; } } - else // + else // { $fine = false; break; } } - // + // if ($fine) { // Write changes into the session @@ -640,9 +645,6 @@ class FilterCmptLib // If filters were loaded if (hasData($filters)) { - $childrenArray = array(); // contains all the children elements in a menu entry - $childrenPersonalArray = array(); // contains all the children elements in menu enty for personal filters - // Loops through loaded filters foreach (getData($filters) as $filter) { @@ -977,12 +979,11 @@ class FilterCmptLib { $columnsNames = array(); - foreach ($columns as $key => $obj) + // For each column + foreach ($columns as $obj) { - if (isset($obj->name)) - { - $columnsNames[] = $obj->name; - } + // If it is set the property name of the column + if (isset($obj->name)) $columnsNames[] = $obj->name; } return $columnsNames; @@ -1209,7 +1210,7 @@ class FilterCmptLib private function _getFilterName($filterJson) { $filterName = $filterJson->name; // always present, used as default - $trimedname = (isset($filterJson->namePhrase)?trim($filterJson->namePhrase):''); + // Filter name from phrases system if (isset($filterJson->namePhrase) && !isEmptyString($filterJson->namePhrase)) { diff --git a/application/libraries/NavigationLib.php b/application/libraries/NavigationLib.php index e2e71c4f1..95ce67610 100644 --- a/application/libraries/NavigationLib.php +++ b/application/libraries/NavigationLib.php @@ -83,9 +83,19 @@ class NavigationLib * Returns the structure for one level of the menu */ public function oneLevel( - $description, $link = '#', $children = null, $icon = '', $expand = false, - $subscriptDescription = null, $subscriptLinkClass = null, $subscriptLinkValue = null, $target = '', - $sort = null, $requiredPermissions = null, $subscriptLinkHref = '#') + $description, + $link = '#', + $children = null, + $icon = '', + $expand = false, + $subscriptDescription = null, + $subscriptLinkClass = null, + $subscriptLinkValue = null, + $target = '', + $sort = null, + $requiredPermissions = null, + $subscriptLinkHref = '#' + ) { return array( 'description' => $description, @@ -239,7 +249,8 @@ class NavigationLib $filename = APPPATH.'config/'.ExtensionsLib::EXTENSIONS_DIR_NAME.'/'.$ext->name.'/'.self::CONFIG_NAVIGATION_FILENAME; if (file_exists($filename)) { - unset($config); + $config = array(); // default value + include($filename); if (isset($config[$configName]) && is_array($config[$configName])) @@ -294,7 +305,7 @@ class NavigationLib } else { - foreach ($navigationArray as $key=>$row) + foreach ($navigationArray as $key => $row) { // Search for * Entries if (mb_strpos($key, '*') === 0 || mb_strpos($key, '*') === mb_strlen($key) - 1) diff --git a/application/libraries/SearchBarLib.php b/application/libraries/SearchBarLib.php index 3599f2a73..ff2ae8934 100644 --- a/application/libraries/SearchBarLib.php +++ b/application/libraries/SearchBarLib.php @@ -18,12 +18,14 @@ if (! defined('BASEPATH')) exit('No direct script access allowed'); +use \stdClass as stdClass; + /** * */ class SearchBarLib { - // + // Error constats const ERROR_WRONG_JSON = 'ERR001'; const ERROR_WRONG_SEARCHSTR = 'ERR002'; const ERROR_NO_TYPES = 'ERR003'; diff --git a/application/views/lehre/anrechnung/createAnrechnung.php b/application/views/lehre/anrechnung/createAnrechnung.php index 5bd9f015f..e3cc9cad1 100644 --- a/application/views/lehre/anrechnung/createAnrechnung.php +++ b/application/views/lehre/anrechnung/createAnrechnung.php @@ -101,7 +101,7 @@ $this->load->view( p->t('lehre', 'lehrveranstaltung'); ?> * @@ -112,7 +112,7 @@ $this->load->view( p->t('global', 'begruendung'); ?> * - + diff --git a/application/views/person/gradelist/gradelist.php b/application/views/person/gradelist/gradelist.php index daf66708b..06d499ded 100644 --- a/application/views/person/gradelist/gradelist.php +++ b/application/views/person/gradelist/gradelist.php @@ -31,14 +31,26 @@
- p->t('lehre', 'notendurchschnitt'); ?> - : + + p->t('lehre', 'notendurchschnitt'); ?> + : +
- p->t('lehre', 'gewichteternotendurchschnitt'); ?> - : + + p->t('lehre', 'gewichteternotendurchschnitt'); ?> + : +
- p->t('lehre', 'ects'); ?> - : + + p->t('lehre', 'ects'); ?> + : +

load->view('templates/FHC-Footer'); ?> + diff --git a/application/views/person/gruppenmanagement/gruppenmanagementData.php b/application/views/person/gruppenmanagement/gruppenmanagementData.php index 4eef0acec..6aa339ce7 100644 --- a/application/views/person/gruppenmanagement/gruppenmanagementData.php +++ b/application/views/person/gruppenmanagement/gruppenmanagementData.php @@ -63,4 +63,4 @@ $filterWidgetArray['filter_id'] = $this->input->get('filter_id'); echo $this->widgetlib->widget('FilterWidget', $filterWidgetArray); -?> + diff --git a/application/views/system/fas_udf.php b/application/views/system/fas_udf.php index bd314b4a8..5ee8c9bfe 100644 --- a/application/views/system/fas_udf.php +++ b/application/views/system/fas_udf.php @@ -1,110 +1,110 @@ -load->view( - 'templates/FHC-Header', - array( - 'title' => 'InfocenterDetails', - 'jquery3' => true, - 'bootstrap3' => true, - 'fontawesome4' => true, - 'jqueryui1' => true, - 'dialoglib' => true, - 'ajaxlib' => true, - 'udfs' => true, - 'widgets' => true, - 'sbadmintemplate3' => true, - 'customCSSs' => array( - 'public/css/sbadmin2/admintemplate.css' - ), - 'customJSs' => array( - 'public/js/bootstrapper.js' - ) - ) - ); -?> - - - -
-
-
- Zusatzfelder -
-
-
-
-   -
-
-
- -
- udflib->UDFWidget( - array( - UDFLib::UDF_UNIQUE_ID => 'fasPersonUDFs', - UDFLib::SCHEMA_ARG_NAME => 'public', - UDFLib::TABLE_ARG_NAME => 'tbl_person', - UDFLib::PRIMARY_KEY_NAME => 'person_id', - UDFLib::PRIMARY_KEY_VALUE => $person_id, - UDFLib::UDFS_ARG_NAME => $personUdfs - ) - ); - ?> -
-
-   -
- - -
- udflib->UDFWidget( - array( - UDFLib::UDF_UNIQUE_ID => 'fasPrestudentUDFs', - UDFLib::SCHEMA_ARG_NAME => 'public', - UDFLib::TABLE_ARG_NAME => 'tbl_prestudent', - UDFLib::PRIMARY_KEY_NAME => 'prestudent_id', - UDFLib::PRIMARY_KEY_VALUE => $prestudent_id, - UDFLib::UDFS_ARG_NAME => $prestudentUdfs - ) - ); - ?> -
- -
-
-
-   -
-
-
- -
-   -
-
-   -
- -
-
- - - -load->view("templates/footer"); ?> - +load->view( + 'templates/FHC-Header', + array( + 'title' => 'InfocenterDetails', + 'jquery3' => true, + 'bootstrap3' => true, + 'fontawesome4' => true, + 'jqueryui1' => true, + 'dialoglib' => true, + 'ajaxlib' => true, + 'udfs' => true, + 'widgets' => true, + 'sbadmintemplate3' => true, + 'customCSSs' => array( + 'public/css/sbadmin2/admintemplate.css' + ), + 'customJSs' => array( + 'public/js/bootstrapper.js' + ) + ) + ); +?> + + + +
+
+
+ Zusatzfelder +
+
+
+
+   +
+
+
+ +
+ udflib->UDFWidget( + array( + UDFLib::UDF_UNIQUE_ID => 'fasPersonUDFs', + UDFLib::SCHEMA_ARG_NAME => 'public', + UDFLib::TABLE_ARG_NAME => 'tbl_person', + UDFLib::PRIMARY_KEY_NAME => 'person_id', + UDFLib::PRIMARY_KEY_VALUE => $person_id, + UDFLib::UDFS_ARG_NAME => $personUdfs + ) + ); + ?> +
+
+   +
+ + +
+ udflib->UDFWidget( + array( + UDFLib::UDF_UNIQUE_ID => 'fasPrestudentUDFs', + UDFLib::SCHEMA_ARG_NAME => 'public', + UDFLib::TABLE_ARG_NAME => 'tbl_prestudent', + UDFLib::PRIMARY_KEY_NAME => 'prestudent_id', + UDFLib::PRIMARY_KEY_VALUE => $prestudent_id, + UDFLib::UDFS_ARG_NAME => $prestudentUdfs + ) + ); + ?> +
+ +
+
+
+   +
+
+
+ +
+   +
+
+   +
+ +
+
+ + + +load->view("templates/footer"); ?> + diff --git a/application/views/system/infocenter/infocenterZgvDetails.php b/application/views/system/infocenter/infocenterZgvDetails.php index 8faa5aa63..cf3ffad8b 100644 --- a/application/views/system/infocenter/infocenterZgvDetails.php +++ b/application/views/system/infocenter/infocenterZgvDetails.php @@ -129,15 +129,11 @@ - + - +
diff --git a/application/views/system/infocenter/studiengangZgvInfo.php b/application/views/system/infocenter/studiengangZgvInfo.php index e508bd505..8b6d1a636 100644 --- a/application/views/system/infocenter/studiengangZgvInfo.php +++ b/application/views/system/infocenter/studiengangZgvInfo.php @@ -17,7 +17,11 @@ $this->load->view(
-

p->t('infocenter', 'zugangsvoraussetzungen'); ?> -

+

+ p->t('infocenter', 'zugangsvoraussetzungen'); ?> + - + +

@@ -35,3 +39,4 @@ $this->load->view( load->view('templates/FHC-Footer'); ?> + diff --git a/application/views/system/messages/htmlWriteTemplate.php b/application/views/system/messages/htmlWriteTemplate.php index 4c0c0baba..761e05f96 100644 --- a/application/views/system/messages/htmlWriteTemplate.php +++ b/application/views/system/messages/htmlWriteTemplate.php @@ -160,7 +160,10 @@ widgetlib->widget( 'Dropdown_widget', - array('elements' => success($recipientsArray), 'emptyElement' => ucfirst($this->p->t('global', 'empfaenger')).'...'), + array( + 'elements' => success($recipientsArray), + 'emptyElement' => ucfirst($this->p->t('global', 'empfaenger')).'...' + ), array( 'name' => 'recipients[]', 'id' => 'recipients'