Merge branch 'master' into feature-68598/Rollup_lets_try_it_again

application/libraries/PrestudentLib.php

@@ -68,7 +68,8 @@ class PrestudentLib
 		$this->_ci->PrestudentModel->addOrder('zgv_code', 'DESC');
 		$this->_ci->PrestudentModel->addLimit(1);
 		$result = $this->_ci->PrestudentModel->loadWhere([
-			'person_id' => $person_id
+			'person_id' => $person_id,
+			'zgv_code IS NOT NULL' => null
 		]);
 
 		if (isError($result)) return $result;
@@ -686,9 +687,6 @@ class PrestudentLib
 		$now = date('c');
 		$today = date('Y-m-d');
 
-		$jahr = mb_substr($studiensemester_kurzbz, 4, 2);
-
-
 		// Genererate Personenkennzeichen
 		$personenkennzeichen = $this->_ci->StudentModel->generateMatrikelnummer2(
 			$student_data->studiengang_kz,
@@ -698,8 +696,9 @@ class PrestudentLib
 		if (isError($personenkennzeichen))
 			return $personenkennzeichen;
 		$personenkennzeichen = getData($personenkennzeichen);
-		
-		
+
+		$jahr = mb_substr($personenkennzeichen, 0, 2);
+
 		// Generate UID
 		$uid = $this->_ci->StudentModel->generateUID(
 			$student_data->kurzbz,
@@ -724,7 +723,7 @@ class PrestudentLib
 
 
 		// Generate Alias
-		$alias = '';
+		$alias = null;
 		if (!defined('GENERATE_ALIAS_STUDENT')
 			|| GENERATE_ALIAS_STUDENT === true
 		) {