From e215e9e948a5df80866d6a5f702e349001f6fd40 Mon Sep 17 00:00:00 2001
From: SimonGschnell <simongschnell@gmail.com>
Date: Wed, 11 Dec 2024 12:44:06 +0100
Subject: [PATCH 1/5] refactor(News-Paginator@Bottom):also adds the pagination
 at the bottom of the news, so that the user doesn't have to scroll up if he
 reaches the end

---
 public/js/components/Cis/Cms/News.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/public/js/components/Cis/Cms/News.js b/public/js/components/Cis/Cms/News.js
index 6633ef237..9b46981be 100644
--- a/public/js/components/Cis/Cms/News.js
+++ b/public/js/components/Cis/Cms/News.js
@@ -38,7 +38,7 @@ export default {
   template: /*html*/ `
   	<h2 >News</h2>
 	<hr/>
-	<pagination  :page_size="page_size"  @page="loadNewPageContent" :maxPageCount="maxPageCount">
+	<pagination v-show="content?true:false" :page_size="page_size"  @page="loadNewPageContent" :maxPageCount="maxPageCount">
 	</pagination>
 	<div class="container-fluid">
 		<div class="row">
@@ -51,5 +51,7 @@ export default {
 			</div>
 		</div>
 	</div>
+	<pagination v-show="content?true:false" :page_size="page_size"  @page="loadNewPageContent" :maxPageCount="maxPageCount">
+	</pagination>
     `,
 };

From 4321a2325bff48b1eccac8ff6b587ecdcb9df07d Mon Sep 17 00:00:00 2001
From: SimonGschnell <simongschnell@gmail.com>
Date: Thu, 12 Dec 2024 11:35:16 +0100
Subject: [PATCH 2/5] update(StudiengangInformation.js): adds the general
 moodle link for the Studiengang informations to the component using a static
 link

---
 public/js/components/Cis/Cms/News.js          |  1 +
 .../StudiengangInformation.js                 | 23 ++++++++++++++-----
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/public/js/components/Cis/Cms/News.js b/public/js/components/Cis/Cms/News.js
index 9b46981be..d032cd44f 100644
--- a/public/js/components/Cis/Cms/News.js
+++ b/public/js/components/Cis/Cms/News.js
@@ -4,6 +4,7 @@ import StudiengangInformation from "./StudiengangInformation/StudiengangInformat
 export default {
   components: {
     Pagination,
+	StudiengangInformation,
   },
   data() {
     return {
diff --git a/public/js/components/Cis/Cms/StudiengangInformation/StudiengangInformation.js b/public/js/components/Cis/Cms/StudiengangInformation/StudiengangInformation.js
index 82d8f6382..8ae4f597a 100644
--- a/public/js/components/Cis/Cms/StudiengangInformation/StudiengangInformation.js
+++ b/public/js/components/Cis/Cms/StudiengangInformation/StudiengangInformation.js
@@ -26,15 +26,20 @@ components:{
 	StudiengangVertretung,
 },
 template:/*html*/`
+
 		<template v-if="studiengang?.bezeichnung && semester">
 			<div class="card card-body mb-3">
-				<div class="mb-3">
-					<h2 >Studiengang:</h2>
-					{{studiengang.bezeichnung}}
+				<div class="mb-1">
+					<h2 class="mb-1 pb-0">Studiengang:</h2>
+					<span class="mb-1">{{studiengang.bezeichnung}}</span>
 				</div>
-				<div :class="{'mb-3':studiengang?.zusatzinfo_html}">
-					<h2 >Semester: </h2>
-					{{semester}}
+				<div class="mb-1">
+					<h2 class="mb-1 pb-0">Moodle:</h2>
+					<a class="mb-1" target="_blank" :href="moodleLink">{{studiengang.kurzbzlang}}</a>
+				</div>
+				<div :class="{'mb-1':studiengang?.zusatzinfo_html}">
+					<h2 class="mb-1 pb-0">Semester: </h2>
+					<span class="mb-1">{{semester}}</span>
 				</div>
 				<div v-if="studiengang?.zusatzinfo_html" v-html="studiengang?.zusatzinfo_html"></div>
 			</div>
@@ -96,6 +101,12 @@ computed:{
 
 		return returnData;
 	},
+	moodleLink: function(){
+		// early return if the studiengang information is not available
+		if(!this.studiengang || !this.studiengang.studiengang_kz) return;
+
+		return `https://moodle.technikum-wien.at/course/view.php?idnumber=dl` + this.studiengang.studiengang_kz;
+	},
 },
 mounted(){
 	this.$fhcApi.factory.studiengang.studiengangInformation()

From 24ff474caddb7b47eee90b1411e4da3a044ed41f Mon Sep 17 00:00:00 2001
From: SimonGschnell <simongschnell@gmail.com>
Date: Thu, 12 Dec 2024 13:31:06 +0100
Subject: [PATCH 3/5] update(MyLv/Lv.js):the user can only click on the grade
 of an lv if the lv had multiple pruefungen otherwise the grade is not
 clickable

---
 .../controllers/api/frontend/v1/Lehre.php     | 18 +++++++
 public/js/api/lehre.js                        |  6 +++
 .../Cis/Mylv/Semester/Studiengang/Lv.js       | 50 ++++++++++++-------
 .../Semester/Studiengang/Lv/Pruefungen.js     | 17 ++-----
 4 files changed, 59 insertions(+), 32 deletions(-)

diff --git a/application/controllers/api/frontend/v1/Lehre.php b/application/controllers/api/frontend/v1/Lehre.php
index c25dc1986..f079a5b37 100644
--- a/application/controllers/api/frontend/v1/Lehre.php
+++ b/application/controllers/api/frontend/v1/Lehre.php
@@ -30,6 +30,7 @@ class Lehre extends FHCAPI_Controller
 		parent::__construct([
 			'lvStudentenMail' => self::PERM_LOGGED,
 			'LV' => self::PERM_LOGGED,
+			'Pruefungen' => self::PERM_LOGGED,
 		]);
 
 		
@@ -76,6 +77,23 @@ class Lehre extends FHCAPI_Controller
 		
 		$this->terminateWithSuccess($result);
 	}
+
+	/**
+	 * fetches all Pruefungen of a student for a specific lehrveranstaltung
+	 * if the student passed the Pruefung on the first attempt, no information about the Pruefungen is stored in the database 
+	 * @param mixed $lehrveranstaltung_id
+	 * @return void
+	 */
+	public function Pruefungen($lehrveranstaltung_id)
+	{
+		$this->load->model('education/Pruefung_model', 'PruefungModel');
+
+		$result = $this->PruefungModel->getByStudentAndLv(getAuthUID(), $lehrveranstaltung_id, getUserLanguage());
+
+		$result = $this->getDataOrTerminateWithError($result);
+
+		$this->terminateWithSuccess($result);
+	}
 	
 
 	
diff --git a/public/js/api/lehre.js b/public/js/api/lehre.js
index 743439722..cd7129d61 100644
--- a/public/js/api/lehre.js
+++ b/public/js/api/lehre.js
@@ -13,4 +13,10 @@ export default {
 			, {}
 		);
 	},
+	getStudentPruefungen(lehrveranstaltung_id){
+		return this.$fhcApi.get(
+			`/api/frontend/v1/Lehre/Pruefungen/${lehrveranstaltung_id}`
+			, {}
+		);
+	}
   }
\ No newline at end of file
diff --git a/public/js/components/Cis/Mylv/Semester/Studiengang/Lv.js b/public/js/components/Cis/Mylv/Semester/Studiengang/Lv.js
index dcc18bbb0..36dcda331 100644
--- a/public/js/components/Cis/Mylv/Semester/Studiengang/Lv.js
+++ b/public/js/components/Cis/Mylv/Semester/Studiengang/Lv.js
@@ -32,7 +32,7 @@ export default {
 	},
 	data: () => {
 		return {
-			pruefungen: null,
+			pruefungenData: null,
 			info: null,
 			menu: null,
 			preselectedMenuItem: null,
@@ -47,7 +47,10 @@ export default {
 		},
 		grade() {
 			return this.benotung ? this.znote || this.lvnote || null : null;
-		}
+		},
+		LvHasPruefungenInformation(){
+			return this.pruefungenData && this.pruefungenData.length > 0;
+		},
 	},
 	methods: {
 		c4_link(menuItem) {
@@ -72,13 +75,13 @@ export default {
 			}
 		},
 		openPruefungen() {
-			if (!this.pruefungen) {
-				this.pruefungen = true;
-				LvPruefungen.popup({
-					lehrveranstaltung_id: this.lehrveranstaltung_id, 
-					bezeichnung: this.bezeichnung
-				}).then(() => this.pruefungen = false).catch(() => this.pruefungen = false);
-			}
+			// early return if the pruefungenData is empty or not set
+			if (!this.LvHasPruefungenInformation) return;
+
+			LvPruefungen.popup({
+				pruefungenData: this.pruefungenData, 
+				bezeichnung: this.bezeichnung
+			});
 		},
 		openInfos() {
 			if (!this.info) {
@@ -107,6 +110,14 @@ export default {
 				.catch((error) => this.$fhcAlert.handleSystemError);	
 		}
 	},
+	created(){
+		this.$fhcApi.factory.lehre.getStudentPruefungen(this.lehrveranstaltung_id)
+		.then(res => res.data)
+		.then(pruefungen =>{
+			this.pruefungenData = pruefungen;
+		}); 
+		
+	},
 	mounted() {
 		this.$fhcApi.factory.addons.getLvMenu(this.lehrveranstaltung_id, this.studien_semester)
 			.then(res => {
@@ -153,17 +164,18 @@ export default {
 		</div>
 		<div class="card-footer">
 			<div class="row">
-				<a href="#" class="col-auto text-start text-decoration-none" @click.prevent="openPruefungen">
-					<i class="fa fa-check text-success" v-if="positiv"></i>
-					{{ grade || p.t('lehre/noGrades') }}
-				</a>
-				<!--
-				Not used anymore because the lehrveranstaltungs informationen is available as a menu point in the lehrveranstaltungs optionen
-				<div v-if="lvinfo" class="col text-end">
-					<a class="card-link" href="#" @click.prevent="openInfos">
-						<i class="fa fa-info-circle" aria-hidden="true"></i>
+				<template v-if="LvHasPruefungenInformation">
+					<a href="#" class="col-auto text-start text-decoration-none" @click.prevent="openPruefungen">
+						<i class="fa fa-check text-success" v-if="positiv"></i>
+						{{ grade || p.t('lehre/noGrades') }}
 					</a>
-				</div>-->
+				</template>
+				<template v-else>
+					<span  class="col-auto text-start text-decoration-none" >
+						<i class="fa fa-check text-success" v-if="positiv"></i>
+						{{ grade || p.t('lehre/noGrades') }}
+					</span>
+				</template>
 			</div>
 		</div>
 	</div>`
diff --git a/public/js/components/Cis/Mylv/Semester/Studiengang/Lv/Pruefungen.js b/public/js/components/Cis/Mylv/Semester/Studiengang/Lv/Pruefungen.js
index b41b58664..d2d1a240a 100644
--- a/public/js/components/Cis/Mylv/Semester/Studiengang/Lv/Pruefungen.js
+++ b/public/js/components/Cis/Mylv/Semester/Studiengang/Lv/Pruefungen.js
@@ -10,7 +10,7 @@ export default {
 		BsModal
 	],
 	props: {
-		lehrveranstaltung_id: Number,
+		pruefungenData: Array|null,
 		bezeichnung: String,
 		/*
 		 * NOTE(chris): 
@@ -26,16 +26,7 @@ export default {
 	},
 	data: () => ({
 		result: true,
-		pruefungen: null
 	}),
-	created() {
-		if (pruefungen[this.lehrveranstaltung_id])
-			this.pruefungen = pruefungen[this.lehrveranstaltung_id];
-		else
-			axios.get(FHC_JS_DATA_STORAGE_OBJECT.app_root + FHC_JS_DATA_STORAGE_OBJECT.ci_router + '/components/Cis/Mylv/Pruefungen/' + this.lehrveranstaltung_id).then(res => {
-				this.pruefungen = pruefungen[this.lehrveranstaltung_id] = res.data.retval || [];
-			});
-	},
 	mounted() {
 		this.modal = this.$refs.modalContainer.modal;
 	},
@@ -47,10 +38,10 @@ export default {
 			Prüfungen: {{bezeichnung}}
 		</template>
 		<template v-slot:default>
-			<div v-if="!pruefungen" class="text-center">
+			<div v-if="!pruefungenData" class="text-center">
 				<i class="fa-solid fa-spinner fa-pulse fa-3x"></i>
 			</div>
-			<p v-else-if="!pruefungen.length" class="alert alert-info mb-0">
+			<p v-else-if="!pruefungenData.length" class="alert alert-info mb-0">
 				Keine Prüfungen vorhanden!
 			</p>
 			<table v-else class="table table-hover">
@@ -60,7 +51,7 @@ export default {
 					<td class="text-end">Note</td>
 				</thead>
 				<tbody>
-					<tr v-for="pruefung in pruefungen" :key="pruefung.pruefung_id">
+					<tr v-for="pruefung in pruefungenData" :key="pruefung.pruefung_id">
 						<th>{{pruefung.pruefungstyp_kurzbz}}</th>
 						<td>{{pruefung.datum}}</td>
 						<td class="text-end">{{pruefung.note}}</td>

From 7bd9129056e7947dd5cfaec7867ff986aeb50d9f Mon Sep 17 00:00:00 2001
From: SimonGschnell <simongschnell@gmail.com>
Date: Thu, 12 Dec 2024 13:47:15 +0100
Subject: [PATCH 4/5] fix(LvMenu/Lv.js): removes the list-item styling from the
 spinner when the data for the lvMenu is not yet ready and aligns the spinner
 in the center of the card

---
 .../Cis/Mylv/Semester/Studiengang/Lv.js          | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/public/js/components/Cis/Mylv/Semester/Studiengang/Lv.js b/public/js/components/Cis/Mylv/Semester/Studiengang/Lv.js
index 36dcda331..832b0c0e7 100644
--- a/public/js/components/Cis/Mylv/Semester/Studiengang/Lv.js
+++ b/public/js/components/Cis/Mylv/Semester/Studiengang/Lv.js
@@ -141,8 +141,8 @@ export default {
 			<h6 class="card-title">{{bezeichnung}}</h6>
 		</div>
 		<div class="card-body " :style="bodyStyle">
-			<ul class="list-group border-top-0 border-bottom-0 rounded-0">
-				<template v-if="menu">
+			<template v-if="menu">
+				<ul class="list-group border-top-0 border-bottom-0 rounded-0">
 					<li :type="menuItem.c4_link ? 'button' : null" v-for="menuItem in menu" class="list-group-item border-0 " >
 						<div class="d-flex flex-row"  :data-bs-toggle="menuItem.c4_moodle_links?.length ? 'dropdown' : null">
 							<div class="mx-4">
@@ -156,11 +156,13 @@ export default {
 								<li v-for="item in menuItem.c4_moodle_links"><a class="dropdown-item border-bottom" :href="item.url">{{item.lehrform}}</a></li>
 							</ul>
 					</li>
-				</template>
-				<template v-else>
-					<li class="text-center"><i class="fa-solid fa-spinner fa-pulse fa-3x"></i></li>
-				</template>
-			</ul>
+				</ul>
+			</template>
+			<template v-else>
+				<div class="text-center d-flex justify-content-center align-items-center h-100" >
+					<i class="fa-solid fa-spinner fa-pulse fa-3x"></i>
+				</div>
+			</template>
 		</div>
 		<div class="card-footer">
 			<div class="row">

From 8f07bd6b4dab33c0f1669032eb7d8b1739b27126 Mon Sep 17 00:00:00 2001
From: SimonGschnell <simongschnell@gmail.com>
Date: Thu, 12 Dec 2024 14:46:32 +0100
Subject: [PATCH 5/5] update(Sprachen.js): shows the sprachen in the component
 always using their bezeichnung

---
 .../controllers/api/frontend/v1/Phrasen.php       | 15 +++++++++++++--
 public/js/components/Cis/Sprachen.js              | 10 ++++++++--
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/application/controllers/api/frontend/v1/Phrasen.php b/application/controllers/api/frontend/v1/Phrasen.php
index 3509e6630..7cc652c71 100644
--- a/application/controllers/api/frontend/v1/Phrasen.php
+++ b/application/controllers/api/frontend/v1/Phrasen.php
@@ -73,11 +73,22 @@ class Phrasen extends FHCAPI_Controller
 	// gets all languages that are set as active in the database
 	public function getAllLanguages()
 	{
-		$langs = getDBActiveLanguages();
+		$this->load->model('system/Sprache_model', 'SprachenModel');
+
+		// Add order clause by index and select the sprache,bezeichnung and index column
+		$this->SprachenModel->addOrder('index');
+		$this->SprachenModel->addSelect('sprache, bezeichnung, index');
+
+		// Retrieves from public.tbl_sprache
+		$langs = $this->SprachenModel->loadWhere(array('content' => true));
 		$langs = $this->getDataOrTerminateWithError($langs);
 		$langs = array_map(function($lang){
-			return $lang->sprache;
+			$data = new stdClass();
+			$data->sprache = $lang->sprache;
+			$data->bezeichnung = $lang->bezeichnung[($lang->index-1)]; 
+			return $data;
 		}, $langs);
+
 		$this->terminateWithSuccess($langs);
 	}
 
diff --git a/public/js/components/Cis/Sprachen.js b/public/js/components/Cis/Sprachen.js
index bd63b9741..72768e9f2 100644
--- a/public/js/components/Cis/Sprachen.js
+++ b/public/js/components/Cis/Sprachen.js
@@ -2,6 +2,7 @@ export default {
 	data(){
 		return {
 			allActiveLanguages: null,
+			sprachenTranslation:null,
 		}
 	}, 
 	methods:{
@@ -11,20 +12,25 @@ export default {
 				this.$p.setLanguage(lang, this.$fhcApi);
 			}
 		},
+		getSprachenBezeichnung: function(lang){
+			if (!Array.isArray(this.sprachenTranslation) || this.sprachenTranslation.length == 0) return;
+			return this.sprachenTranslation.find(s=>s.sprache == lang)?.bezeichnung;
+		},
 	},
 	mounted(){
 		this.$fhcApi.factory.phrasen.getActiveDbLanguages()
 			.then(res => res.data)
 			.then(
 				(langs) => {
-					this.allActiveLanguages = langs;
+					this.allActiveLanguages = langs.map(l=>l.sprache);
+					this.sprachenTranslation = langs;
 				}
 		);
 	},
 	template:/*html*/`
 	<div class="container">
 		<div class="row justify-content-center align-items-center flex-nowrap overflow-hidden">
-			<button v-for="lang in allActiveLanguages" @click.prevent="changeLanguage(lang)" class="col text-white fhc-entry btn text-center w-100" :selected="$p.user_language.value==lang?'':null">{{lang}}</button>
+			<button v-for="lang in allActiveLanguages" @click.prevent="changeLanguage(lang)" class="col text-white fhc-entry btn text-center w-100" :selected="$p.user_language.value==lang?'':null">{{getSprachenBezeichnung(lang)}}</button>
 		</div>
 	</div>
 	`,