blackicedbear/FHC-Core
1
0
Fork 0
mirror of https://github.com/FH-Complete/FHC-Core.git synced 2026-06-01 12:19:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

"hasContent" guardrail in abgabetoolJob to avoid sending empty email templates when every possible relevant change has been filtered by the job;

Browse Source
This commit is contained in:
Johann Hoffmann
2026-05-29 10:21:44 +02:00
parent 004bcc43c3
commit 9f462fe3d6
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
application/controllers/jobs/AbgabetoolJob.php
+9 -2
View File
@@ -358,7 +358,8 @@ class AbgabetoolJob extends JOB_Controller
foreach($assistenzMap as $assistenz_person_id => $tupelArr) { foreach($assistenzMap as $assistenz_person_id => $tupelArr) {
$abgabenString = '<div style="font-family: Arial, sans-serif; color: #333;">'; $abgabenString = '<div style="font-family: Arial, sans-serif; color: #333;">';
$hasContent = false;
foreach($tupelArr as $tupel) { foreach($tupelArr as $tupel) {
$projektarbeit_id = $tupel[0]; $projektarbeit_id = $tupel[0];
$assistenzRow = $tupel[1]; $assistenzRow = $tupel[1];
@@ -377,6 +378,7 @@ class AbgabetoolJob extends JOB_Controller
if(count($relevantAbgaben) == 0) { if(count($relevantAbgaben) == 0) {
continue; continue;
} }
$hasContent = true;
// Format the Student Name // Format the Student Name
$s = $relevantAbgaben[0]; $s = $relevantAbgaben[0];
@@ -447,7 +449,12 @@ class AbgabetoolJob extends JOB_Controller
} }
$abgabenString .= '</div>'; $abgabenString .= '</div>';
// skip send entirely
if (!$hasContent) {
continue;
}
// done with building the change list, now send it // done with building the change list, now send it
$assistenzRow = $tupelArr[0][1]; $assistenzRow = $tupelArr[0][1];
$anrede = $assistenzRow->anrede; $anrede = $assistenzRow->anrede;