Merge remote-tracking branch 'origin/feature-29529/infocenter_anpassungen' into infocenter_2023_08_24

# Conflicts:
#	system/dbupdate_3.4.php

application/controllers/system/infocenter/InfoCenter.php

@@ -326,7 +326,7 @@ class InfoCenter extends Auth_Controller
 			show_error('Person does not exist!');
 
 		$origin_page = $this->input->get(self::ORIGIN_PAGE);
-		if ($origin_page == self::INDEX_PAGE)
+		if (in_array($origin_page, array(self::INDEX_PAGE, self::ABGEWIESEN_PAGE)))
 		{
 			// mark person as locked for editing
 			$result = $this->PersonLockModel->lockPerson($person_id, $this->_uid, self::APP);
@@ -371,7 +371,14 @@ class InfoCenter extends Auth_Controller
 
 		if (isError($result)) show_error(getError($result));
 
-		$redirectLink = '/'.self::INFOCENTER_URI.'?'.self::FHC_CONTROLLER_ID.'='.$this->getControllerId();
+		$origin_page = $this->input->get(self::ORIGIN_PAGE);
+
+		if ($origin_page === self::ABGEWIESEN_PAGE)
+			$redirectLink = self::INFOCENTER_URI. '/' .self::ABGEWIESEN_PAGE;
+		else
+			$redirectLink = '/'.self::INFOCENTER_URI;
+
+		$redirectLink .= '?'.self::FHC_CONTROLLER_ID.'='.$this->getControllerId();
 
 		// Force reload of Dataset after Unlock
 		$redirectLink .= '&'.self::KEEP_TABLESORTER_FILTER.'=true';

application/models/person/Person_model.php

@@ -326,10 +326,12 @@ class Person_model extends DB_Model
 
 				SELECT p2.person_id
 				FROM tbl_person p1
+				JOIN tbl_prestudent ps ON p1.person_id = ps.person_id
 				INNER JOIN (
-					SELECT vorname, nachname, gebdatum, person_id
-					FROM tbl_person
-					) p2
+					SELECT vorname, nachname, gebdatum, person.person_id
+					FROM tbl_person person
+					JOIN tbl_prestudent sps ON person.person_id = sps.person_id
+				) p2
 					ON (lower(p1.vorname) = lower(p2.vorname) AND lower(p1.nachname) = lower(p2.nachname) AND p1.gebdatum = p2.gebdatum)
 				WHERE p1.person_id != p2.person_id AND (p1.person_id = ?)";
 

application/views/system/infocenter/infocenterAbgewiesenData.php

@@ -1,6 +1,7 @@
 <?php
 
 	$this->config->load('infocenter');
+	$APP = '\'infocenter\'';
 	$ABGEWIESENEN_STATUS = '\'Abgewiesener\'';
 	$STUDIENGANG_TYP = '\''.$this->variablelib->getVar('infocenter_studiensgangtyp').'\'';
 	$ADDITIONAL_STG = $this->config->item('infocenter_studiengang_kz');
@@ -17,6 +18,8 @@ $query = '
 			p.nachname AS "Nachname",
 			so.studiengangkurzbzlang as "Studiengang",
 			pss.insertamum AS "AbgewiesenAm",
+			pl.zeitpunkt AS "LockDate",
+			pl.lockuser AS "LockUser",
 			(
 				SELECT l.zeitpunkt
 				FROM system.tbl_log l
@@ -54,6 +57,15 @@ $query = '
 			JOIN public.tbl_studiengang sg USING(studiengang_kz)
 			JOIN lehre.tbl_studienplan sp USING(studienplan_id)
 			JOIN lehre.tbl_studienordnung so USING(studienordnung_id)
+			LEFT JOIN (
+				SELECT tpl.person_id,
+					   tpl.zeitpunkt,
+					   sp.nachname AS lockuser
+				  FROM system.tbl_person_lock tpl
+				  JOIN public.tbl_benutzer sb USING (uid)
+				  JOIN public.tbl_person sp ON sb.person_id = sp.person_id
+				 WHERE tpl.app = '.$APP.'
+			 ) pl USING(person_id)
 		WHERE pss.status_kurzbz = '. $ABGEWIESENEN_STATUS .'
 		AND pss.studiensemester_kurzbz = '. $STUDIENSEMESTER .'
 		AND (sg.typ IN ('. $STUDIENGANG_TYP .') 
@@ -70,6 +82,7 @@ $query = '
 		'requiredPermissions' => 'infocenter',
 		'datasetRepresentation' => 'tablesorter',
 		'checkboxes' => 'PersonId',
+		'additionalColumns' => array('Details'),
 		'columnsAliases' => array(
 			'PersonId',
 			'PreStudentID',
@@ -77,11 +90,23 @@ $query = '
 			ucfirst($this->p->t('person', 'nachname')),
 			ucfirst($this->p->t('lehre', 'studiengang')),
 			ucfirst($this->p->t('infocenter', 'abgewiesenam')),
+			ucfirst($this->p->t('global', 'sperrdatum')),
+			ucfirst($this->p->t('global', 'gesperrtVon')),
 			ucfirst($this->p->t('global', 'nachricht')),
 			ucfirst($this->p->t('infocenter', 'kaution'))
 		),
 
 		'formatRow' => function($datasetRaw) {
+			/* NOTE: Dont use $this here for PHP Version compatibility */
+			$datasetRaw->{'Details'} = sprintf(
+				'<a href="%s?person_id=%s&origin_page=%s&fhc_controller_id=%s&prev_filter_id=%s">Details</a>',
+				site_url('system/infocenter/InfoCenter/showDetails'),
+				$datasetRaw->{'PersonId'},
+				'abgewiesen',
+				(isset($_GET['fhc_controller_id']) ? $_GET['fhc_controller_id'] : ''),
+				(isset($_GET['filter_id']) ? $_GET['filter_id'] : '')
+			);
+
 			if ($datasetRaw->{'Nachricht'} === null)
 			{
 				$datasetRaw->{'Nachricht'} = 'Nein';
@@ -103,10 +128,29 @@ $query = '
 			{
 				$datasetRaw->{'Kaution'} = 'Offen';
 			}
+			
+			if ($datasetRaw->{'LockDate'} == null)
+			{
+				$datasetRaw->{'LockDate'} = '-';
+			}
+			
+			if ($datasetRaw->{'LockUser'} == null)
+			{
+				$datasetRaw->{'LockUser'} = '-';
+			}
 
 			$datasetRaw->{'AbgewiesenAm'} = date_format(date_create($datasetRaw->{'AbgewiesenAm'}),'Y-m-d H:i');
 			return $datasetRaw;
+		},
+		
+		'markRow' => function($datasetRaw) {
+			
+			if ($datasetRaw->LockDate != null)
+			{
+				return FilterWidget::DEFAULT_MARK_ROW_CLASS;
+			}
 		}
+		
 	);
 
 	echo $this->widgetlib->widget('FilterWidget', $filterWidgetArray);

application/views/system/infocenter/infocenterDetails.php

@@ -57,10 +57,11 @@
 							if (isset($lockedby)):
 								echo $this->p->t('global', 'wirdBearbeitetVon').': ';
 								echo $lockedby;
-								if ($origin_page == 'index'):
+								if (in_array($origin_page, array('index', 'abgewiesen'))):
 									$unlockpath = 'unlockPerson/'.$stammdaten->person_id;
 									$unlockpath .= '?fhc_controller_id='.$fhc_controller_id;
 									$unlockpath .= '&filter_id='.$prev_filter_id;
+									$unlockpath .= '&origin_page='.$origin_page;
 							?>
 									  
 									<a href="<?php echo $unlockpath; ?>">