From ab36d567b81f582b875ccdebe807b8b81a2de759 Mon Sep 17 00:00:00 2001
From: SimonGschnell <simongschnell@gmail.com>
Date: Tue, 25 Mar 2025 12:47:58 +0100
Subject: [PATCH] refactor(Url Widget): fixes add link button inside the widget

---
 public/js/components/Dashboard/Item.js          | 17 ++---------------
 .../js/components/DashboardWidget/Abstract.js   |  3 ---
 public/js/components/DashboardWidget/Url.js     | 12 +++---------
 3 files changed, 5 insertions(+), 27 deletions(-)

diff --git a/public/js/components/Dashboard/Item.js b/public/js/components/Dashboard/Item.js
index 1ff6a4516..59f33b711 100644
--- a/public/js/components/Dashboard/Item.js
+++ b/public/js/components/Dashboard/Item.js
@@ -45,15 +45,6 @@ export default {
 		ready() {
 			return this.component && this.arguments !== null;
 		},
-		widget_action_identifier(){
-			return `${this.widget.widget_kurzbz}-${this.index}-action-section`;
-		},
-		widgetInformation(){
-			return { 
-				action_section_identifier: this.widget_action_identifier,
-				widget_kurzbz: this.widget.widget_kurzbz,
-			}
-		}
 	},
 	methods: {
 		getWidgetC4Link(widget) {
@@ -138,10 +129,6 @@ export default {
 			<a v-if="widget.setup.cis4link" :href="getWidgetC4Link(widget)" class="col-auto ms-auto ">
           		<i class="fa fa-arrow-up-right-from-square me-1"></i>
           	</a>
-
-			<!-- container for widget specific actions -->
-			<div :id="widget_action_identifier"></div>
-
 			<a v-if="hasConfig" class="col-auto px-1" href="#" @click.prevent="openConfig"><i class="fa-solid fa-gear"></i></a>
 			<a v-if="custom && editMode" class="col-auto px-1" href="#" @click.prevent="$emit('remove')">
 				<i class="fa-solid fa-trash"></i>
@@ -153,7 +140,7 @@ export default {
 			</Transition>
 		</div>
 		<div v-if="ready" class="card-body overflow-hidden" style="padding: 0px;">
-			<component :is="component" v-model:shared-data="sharedData" :widgetInfo="widgetInformation" :config="arguments" :width="width" :height="height" @setConfig="setConfig" @change="changeConfigManually"></component>
+			<component :is="component" v-model:shared-data="sharedData" :config="arguments" :width="width" :height="height" @setConfig="setConfig" @change="changeConfigManually"></component>
 		</div>
 		<div v-else class="card-body overflow-hidden text-center d-flex flex-column justify-content-center"><i class="fa-solid fa-spinner fa-pulse fa-3x"></i></div>
 		<bs-modal v-if="hasConfig" ref="config" @hideBsModal="handleHideBsModal" @showBsModal="handleShowBsModal">
@@ -161,7 +148,7 @@ export default {
 				{{ widget ? 'Config for ' + widget.setup.name : '' }}
 			</template>
 			<template v-slot:default>
-				<component v-if="ready && !isLoading" :is="component" v-model:shared-data="sharedData" :widgetInfo="widgetInformation" :config="tmpConfig" @change="changeConfig" :configMode="true"></component>
+				<component v-if="ready && !isLoading" :is="component" v-model:shared-data="sharedData" :config="tmpConfig" @change="changeConfig" :configMode="true"></component>
 				<div v-else class="text-center"><i class="fa-solid fa-spinner fa-pulse fa-3x"></i></div>
 			</template>
 			<template v-if="!widget?.setup?.hideFooter" v-slot:footer>
diff --git a/public/js/components/DashboardWidget/Abstract.js b/public/js/components/DashboardWidget/Abstract.js
index 50f63cf74..e9f87490d 100644
--- a/public/js/components/DashboardWidget/Abstract.js
+++ b/public/js/components/DashboardWidget/Abstract.js
@@ -26,9 +26,6 @@ export default {
 				this.$emit('update:sharedData', value);
 			}
 		},
-		widget_action_css_identifier(){
-			return `#${this.widgetInfo.action_section_identifier}`;
-		}
 	},
 	methods: {
 		formatDateTime: function(dateTime) {
diff --git a/public/js/components/DashboardWidget/Url.js b/public/js/components/DashboardWidget/Url.js
index c0f05257e..8123852d0 100644
--- a/public/js/components/DashboardWidget/Url.js
+++ b/public/js/components/DashboardWidget/Url.js
@@ -160,17 +160,11 @@ export default {
     <div class="widgets-url w-100 h-100 overflow-scroll" style="padding: 1rem 1rem;">
         <div class="d-flex flex-column justify-content-between">
 
-			<Teleport :to="widget_action_css_identifier">
-				<Transition>
-					<button v-if="!editModeIsActive" class="btn btn-outline-secondary btn-sm" @click="openCreateModal" type="button">
-						<i class="fa-solid fa-plus"></i>
-					</button>
-				</Transition>
-			</Teleport>
-
 			<template v-if="shared">
-
                 <template v-if="!emptyBookmarks">
+					<button class="btn btn-outline-secondary btn-sm" @click="openCreateModal" type="button">
+						{{$p.t('bookmark','newLink')}}
+					</button>
 					<div v-for="link in shared" :key="link.id" class="d-flex mt-2">
 						<a target="_blank" :href="link.url">
 							<i class="fa fa-solid fa-arrow-up-right-from-square me-1"></i>{{ link.title }}