From b65d17e7ae35c9465e44b5cae23e37442f097648 Mon Sep 17 00:00:00 2001
From: SimonGschnell <simongschnell@gmail.com>
Date: Thu, 7 Nov 2024 13:14:40 +0100
Subject: [PATCH] refactor(LvModal): uses the right format for the date and
 adds padding to date numbers which are single digits

---
 public/js/components/Cis/Mylv/LvModal.js | 25 ++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/public/js/components/Cis/Mylv/LvModal.js b/public/js/components/Cis/Mylv/LvModal.js
index 809e8a57d..573472910 100644
--- a/public/js/components/Cis/Mylv/LvModal.js
+++ b/public/js/components/Cis/Mylv/LvModal.js
@@ -47,11 +47,28 @@ export default {
 			if (!this.event.end instanceof Date) {
 				return this.event.end;
 			}
-			return this.event.end.getHours() + ":" + this.event.end.getMinutes();
+			return this.event.end.getHours() + ":" + 
+			// returns the string '00' if the function getMinutes returns 0
+			(this.event.end.getMinutes() || typeof this.event.end.getMinutes() === 'number' && this.event.end.getMinutes().toString() + '0');
 		}
 	},
 	methods:{
-		onModalShow: function(){
+		add_padding_to_date_number: function(number)
+		{
+			return number.toString().length == 1 ? '0' + number.toString() : number.toString();
+		},
+		format_date: function(d)
+		{
+			let date = new Date(d);
+			// if the date is an invalid string then creating a date from the string will fail and N/A is returned
+			if (isNaN(date.valueOf()))
+			{
+				return 'N/A';
+			}
+			return `${this.add_padding_to_date_number(date.getDate())}.${this.add_padding_to_date_number(date.getMonth() + 1)}.${this.add_padding_to_date_number(date.getFullYear())}`;
+		},
+		onModalShow: function()
+		{
 			if (this.event.type == 'lehreinheit') {
 				this.$fhcApi.factory.stundenplan.getLehreinheitStudiensemester(this.event.lehreinheit_id[0]).then(
 					res=>res.data
@@ -80,7 +97,7 @@ export default {
 			<template v-else>{{ event.lehrfach_bez + ' [' + event.ort_kurzbz+']'}}</template>
 		</template>
 		<template v-slot:default>
-			
+
 				<h3>{{$p.t('lvinfo','lehrveranstaltungsinformationen')}}</h3>
 				<table class="table table-hover mb-4">
 					<tbody>
@@ -90,7 +107,7 @@ export default {
 								$p.t('global','datum')+':'
 								:''
 							}}</th>
-							<td>{{event.datum}}</td>
+							<td>{{format_date(event.datum)}}</td>
 						</tr>
 						<tr>
 							<th>{{