From bc4bebb39f33668024f0e3452a9e273a53b082c8 Mon Sep 17 00:00:00 2001 From: Cris Date: Tue, 26 Nov 2019 14:46:28 +0100 Subject: [PATCH] Minor changes in job MailLehrauftragToApprove Optimized code, added logInfo. --- application/controllers/jobs/LehrauftragJob.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/application/controllers/jobs/LehrauftragJob.php b/application/controllers/jobs/LehrauftragJob.php index b265bdc6c..e0a5fad27 100644 --- a/application/controllers/jobs/LehrauftragJob.php +++ b/application/controllers/jobs/LehrauftragJob.php @@ -162,7 +162,7 @@ class LehrauftragJob extends JOB_Controller else { // Increase amount +1 - $data_arr[$ss_index][$oe_index][$stg_index]['amount'] = $data_arr[$ss_index][$oe_index][$stg_index]['amount'] + 1; + $data_arr[$ss_index][$oe_index][$stg_index]['amount']++; } } } @@ -188,9 +188,13 @@ class LehrauftragJob extends JOB_Controller $data_arr = $this->_clusterData_byReceiver($data_arr); // Send email - if(!$this->_sendMail($data_arr)) + if(!$this->_sendMail_toApprove($data_arr)) { - $this->logError('Fehler beim Mailversand in Job MailLehrauftragToApprove'); + $this->logInfo('SUCCEDED: Sending emails about yesterdays ordered lehrauftraege succeded.'); + } + else + { + $this->logError('Error when sending emails in job MailLehrauftragToApprove'); } } @@ -298,7 +302,7 @@ class LehrauftragJob extends JOB_Controller * Send Sancho eMail about ordered Lehrauftraege. * @param $data_arr */ - private function _sendMail($data_arr) + private function _sendMail_toApprove($data_arr) { // Loop through 'container' of mail recipients foreach($data_arr as $data)