From c6232f7959b3dd52ffa3bc8b9a4ee2432ba94b5f Mon Sep 17 00:00:00 2001 From: Alexei Karpenko Date: Thu, 15 Jan 2026 17:08:05 +0100 Subject: [PATCH] plausicheckresolver bugfixes, removed CONFIG_FEHLER_FILENAME constants --- application/core/IssueResolver_Controller.php | 2 +- application/libraries/issues/PlausicheckProducerLib.php | 8 ++++---- application/libraries/issues/PlausicheckResolverLib.php | 3 +-- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/application/core/IssueResolver_Controller.php b/application/core/IssueResolver_Controller.php index 74a4eb451..6d7a8a197 100755 --- a/application/core/IssueResolver_Controller.php +++ b/application/core/IssueResolver_Controller.php @@ -6,7 +6,7 @@ abstract class IssueResolver_Controller extends JOB_Controller { // codes of fehler to be resolved - protected $fehlercodes = []; + protected $_fehlercodes = []; public function __construct() { diff --git a/application/libraries/issues/PlausicheckProducerLib.php b/application/libraries/issues/PlausicheckProducerLib.php index 61012e303..85ecd3577 100644 --- a/application/libraries/issues/PlausicheckProducerLib.php +++ b/application/libraries/issues/PlausicheckProducerLib.php @@ -8,8 +8,8 @@ class PlausicheckProducerLib const CI_LIBRARY_FOLDER = 'libraries'; const PLAUSI_ISSUES_FOLDER = 'issues/plausichecks'; const EXECUTE_PLAUSI_CHECK_METHOD_NAME = 'executePlausiCheck'; - const CONFIG_FEHLER_FILENAME = 'fehler.php'; const CONFIG_FEHLER_NAME = 'fehler'; + const CONFIG_FEHLER_INDEX = 'fehler'; const FEHLER_KURZBZ_NAME = 'fehler_kurzbz'; const PRODUCER_LIB_NAME = 'producerLibName'; const EXTENSION_NAME = 'extensionName'; @@ -74,7 +74,7 @@ class PlausicheckProducerLib // get producer file paths for the fehler // Load Fehler Entries of Core - $configArray = $this->_ci->config->item(self::CONFIG_FEHLER_NAME); + $configArray = $this->_ci->config->item(self::CONFIG_FEHLER_INDEX); foreach ($configArray as $coreEntry) { @@ -99,14 +99,14 @@ class PlausicheckProducerLib foreach ($extensionsData as $ext) { - $configFilePath = ExtensionsLib::EXTENSIONS_DIR_NAME.'/'.$ext->name.'/'.self::CONFIG_FEHLER_FILENAME; + $configFilePath = ExtensionsLib::EXTENSIONS_DIR_NAME.'/'.$ext->name.'/'.self::CONFIG_FEHLER_NAME.'.php'; $configFilename = APPPATH.'config/'.$configFilePath; if (file_exists($configFilename)) { $this->_ci->load->config($configFilePath); - $extensionEntries = $this->_ci->config->item(self::CONFIG_FEHLER_NAME); + $extensionEntries = $this->_ci->config->item(self::CONFIG_FEHLER_INDEX); if (isset($extensionEntries) && is_array($extensionEntries)) { diff --git a/application/libraries/issues/PlausicheckResolverLib.php b/application/libraries/issues/PlausicheckResolverLib.php index 4d9faefcf..89b68a7b8 100644 --- a/application/libraries/issues/PlausicheckResolverLib.php +++ b/application/libraries/issues/PlausicheckResolverLib.php @@ -9,7 +9,6 @@ class PlausicheckResolverLib const EXTENSIONS_FOLDER = 'extensions'; const ISSUE_RESOLVERS_FOLDER = 'issues/resolvers'; const CHECK_ISSUE_RESOLVED_METHOD_NAME = 'checkIfIssueIsResolved'; - const CONFIG_FEHLER_FILENAME = 'fehler.php'; const CONFIG_FEHLER_NAME = 'fehler'; const FEHLERCODE_NAME = 'fehlercode'; const FEHLER_KURZBZ_NAME = 'fehler_kurzbz'; @@ -70,7 +69,7 @@ class PlausicheckResolverLib foreach ($extensionsData as $ext) { - $configFilename = APPPATH.'config/'.ExtensionsLib::EXTENSIONS_DIR_NAME.'/'.$ext->name.'/'.self::CONFIG_FEHLER_FILENAME; + $configFilename = APPPATH.'config/'.ExtensionsLib::EXTENSIONS_DIR_NAME.'/'.$ext->name.'/'.self::CONFIG_FEHLER_NAME.'.php'; if (file_exists($configFilename)) {