- application/core/* -> CS compliant

- application/libraries/* -> CS compliant
- FHC_Model isEntitled method now return error() or success()
- Updated all code that uses isEntitled method from FHC_Model
- Removed Squiz.PHP.DisallowSizeFunctionsInLoops from CS ruleset
- Removed depracated method replace from DB_Model
- Removed unused method pgArrayPhp from DB_Model
- Renamed method arrayMergeIndex to _arrayCombine in DB_Model and set as private
- Added method _manageUDFs to DB_Model (a wrapper for UDFLib->manageUDFs)

tests/codesniffer/FHComplete/ruleset.xml

@@ -23,18 +23,19 @@
    		<property name="absoluteLineLimit" value="150"/>
   	</properties>
   </rule>
+  
   <rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
 
   <rule ref="Squiz.Classes.LowercaseClassKeywords"/>
 
-  <rule ref="Generic.CodeAnalysis.ForLoopShouldBeWhileLoop"/>
-  <rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall"/>
   <rule ref="Generic.CodeAnalysis.JumbledIncrementer"/>
-  <rule ref="Generic.CodeAnalysis.UnconditionalIfStatement"/>
+  <rule ref="Generic.CodeAnalysis.ForLoopShouldBeWhileLoop"/>
   <rule ref="Generic.CodeAnalysis.UnnecessaryFinalModifier"/>
+  <rule ref="Generic.CodeAnalysis.UnconditionalIfStatement"/>
+  <rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall"/>
 
-  <rule ref="Squiz.Commenting.DocCommentAlignment"/>
   <rule ref="Generic.Commenting.Todo"/>
+  <rule ref="Squiz.Commenting.DocCommentAlignment"/>
 
   <!--
   We allow EOL after closing braces
@@ -47,20 +48,19 @@
 
   <rule ref="Squiz.Operators.ValidLogicalOperators"/>
 
-  <rule ref="Generic.PHP.DeprecatedFunctions"/>
-  <rule ref="Squiz.PHP.DisallowSizeFunctionsInLoops"/>
   <rule ref="Squiz.PHP.Eval"/>
-  <rule ref="Generic.PHP.ForbiddenFunctions"/>
   <rule ref="Squiz.PHP.NonExecutableCode"/>
   <rule ref="Generic.PHP.NoSilencedErrors"/>
+  <rule ref="Generic.PHP.ForbiddenFunctions"/>
+  <rule ref="Generic.PHP.DeprecatedFunctions"/>
 
   <rule ref="Squiz.Scope.MemberVarScope"/>
   <rule ref="Squiz.Scope.StaticThisUsage"/>
 
   <rule ref="Squiz.WhiteSpace.CastSpacing"/>
-  <rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing"/>
   <rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
   <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace"/>
+  <rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing"/>
 
   <!-- Relax some src/* and tests/* rules -->
   <rule ref="Squiz.Classes.ValidClassName">