blackicedbear/FHC-Core
1
0
Fork 0
mirror of https://github.com/FH-Complete/FHC-Core.git synced 2026-07-23 01:42:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Plausichecks: added comments, fixed bug for studiengang parameter in GbDatumWeitZurueck check

Browse Source
This commit is contained in:
KarpAlex
2022-10-08 01:40:14 +02:00
parent fb5656833a
commit f2f960fd43
5 changed files with 94 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
application/controllers/jobs/PlausiIssueProducer.php
+3 -1
View File
@@ -15,6 +15,8 @@ class PlausiIssueProducer extends JOB_Controller
/**
* Runs issue production job.
* @param studiensemester_kurzbz string job is run for students of a certain semester.
* @param studiengang_kz int job is run for students of certain Studiengang.
*/
public function run($studiensemester_kurzbz = null, $studiengang_kz = null)
{
@@ -27,7 +29,7 @@ class PlausiIssueProducer extends JOB_Controller
{
// execute the check
$this->logInfo("Checking " . $fehler_kurzbz . "...");
$plausicheckRes = $this->plausicheckproducerlib->producePlausicheck($fehler_kurzbz, $studiensemester_kurzbz, $studiengang_kz);
$plausicheckRes = $this->plausicheckproducerlib->producePlausicheckIssue($fehler_kurzbz, $studiensemester_kurzbz, $studiengang_kz);
if (isError($plausicheckRes)) $this->logError(getError($plausicheckRes));
application/controllers/system/issues/Plausichecks.php
+10 -15
View File
@@ -4,8 +4,6 @@ if (! defined('BASEPATH')) exit('No direct script access allowed');
class Plausichecks extends Auth_Controller
{
private $_uid;
public function __construct()
{
parent::__construct(
@@ -24,16 +22,20 @@ class Plausichecks extends Auth_Controller
$this->load->model('system/Fehler_model', 'FehlerModel');
$this->load->model('organisation/Studiensemester_model', 'StudiensemesterModel');
$this->load->model('organisation/Studiengang_model', 'StudiengangModel');
$this->_setAuthUID(); // sets property uid
}
/*
* Get data for filtering the plausichecks and load the view.
*/
public function index()
{
$filterData = $this->_getFilterData();
$this->load->view('system/issues/plausichecks', $filterData);
}
/**
* Initiate plausichecks run.
*/
public function runChecks()
{
$studiensemester_kurzbz = $this->input->get('studiensemester_kurzbz');
@@ -52,7 +54,7 @@ class Plausichecks extends Auth_Controller
{
// execute the check
$issueTexts[$fehler_kurzbz] = array();
$plausicheckRes = $this->plausicheckproducerlib->producePlausicheck($fehler_kurzbz, $studiensemester_kurzbz, $studiengang_kz);
$plausicheckRes = $this->plausicheckproducerlib->producePlausicheckIssue($fehler_kurzbz, $studiensemester_kurzbz, $studiengang_kz);
if (isError($plausicheckRes)) $this->terminateWithJsonError(getError($plausicheckRes));
@@ -98,6 +100,9 @@ class Plausichecks extends Auth_Controller
$this->outputJsonSuccess($issueTexts);
}
/**
* Get the data needed for filtering for limiting checks.
*/
private function _getFilterData()
{
$this->StudiensemesterModel->addOrder('start', 'DESC');
@@ -126,14 +131,4 @@ class Plausichecks extends Auth_Controller
'fehler' => $fehlerKurzbz
);
}
/**
* Retrieve the UID of the logged user and checks if it is valid
*/
private function _setAuthUID()
{
$this->_uid = getAuthUID();
if (!$this->_uid) show_error('User authentification failed');
}
}