Merge branch 'feature-28886/Filter_Component_vs_Table_Component' into feature-28089/plausichecks_in_extension_hinzufuegen

application/libraries/DocsboxLib.php

@@ -0,0 +1,304 @@
+<?php
+/* Copyright (C) 2022 fhcomplete.net
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
+ *
+ */
+
+require_once(dirname(__FILE__).'/../../vendor/nategood/httpful/bootstrap.php');
+
+use \ZipArchive as ZipArchive;
+
+/**
+ * Simple client to convert documents using Docsbox
+ */
+class DocsboxLib
+{
+	const ERROR = 1;
+	const SUCCESS = 0;
+	const STATUS_FINISHED = 'finished'; // Docsbox status when a document conversion ended
+	const STATUS_QUEUED = 'queued'; // Docsbox status when a file has been queued for the conversion
+	const STATUS_STARTED = 'started'; // Docsbox status when a file has started being worked
+	const STATUS_WORKING = 'working'; // Docsbox status when a file is being converted
+	const OUTPUT_FILENAME = 'out.zip.pdf'; // File name used by docsbox to save a converted document
+
+	const DEFAULT_FORMAT = 'pdf'; // Default supported format
+
+	// -------------------------------------------------------------------------------------------------
+	// Public static methods
+
+	/**
+	 * Static method used to convert a document using a Docsbox installation (local/remote) over the network
+	 * It return 0 on success and any other integer on error
+	 * NOTE: currently format is not supported
+	 */
+	public static function convert($inputFileName, $outputFileName, $format)
+	{
+		// If a format has not been given
+		if (($format == null) || ($format != null && ctype_space($format) === true)) $format = self::DEFAULT_FORMAT;
+
+		// Posts the file to docsbox
+		$queueId = self::_postFile($inputFileName);
+		// If an error occurred
+		if ($queueId == null) return self::ERROR;
+
+		// Checks and waits if the file has been converted
+		$resultUrl = self::_checkConvertion($queueId);
+		// If an error occurred
+		if ($resultUrl == null) return self::ERROR;
+
+		// Download and rename the converted file
+		$downloaded = self::_downloadFile($resultUrl, $outputFileName);
+		// If an error occurred
+		if (!$downloaded) return self::ERROR;
+
+		return self::SUCCESS;
+	}
+
+	// -------------------------------------------------------------------------------------------------
+	// Private static methods
+
+	/**
+	 * Posts the given file to a Docsboxserver and checks the response to return a valid queue id
+	 * On failure it returns a null value
+	 */
+	private static function _postFile($inputFileName)
+	{
+		$queueId = null;
+
+		try
+		{
+			// Posts the given file and expects a response in JSON format
+			$postFileResponse = \Httpful\Request::post(DOCSBOX_SERVER.DOCSBOX_PATH_API)
+				->attach(array('file' => $inputFileName))
+				->expectsJson()
+				->send();
+
+			// Checks that:
+			// - the response is not empty
+			// - the reponse body has the property id
+			// - the property id is a valid string
+			// - the reponse body has the property status
+			// - docsbox queued the conversion of the posted file
+			if (is_object($postFileResponse)
+				&& isset($postFileResponse->body)
+				&& isset($postFileResponse->body->id)
+				&& $postFileResponse->body->id != '' && $postFileResponse->body->id != null
+				&& isset($postFileResponse->body->status)
+				&& $postFileResponse->body->status == self::STATUS_QUEUED)
+			{
+				$queueId = $postFileResponse->body->id;
+			}
+			else
+			{
+				// If docsbox refused to convert the posted file
+				if (isset($postFileResponse->body->status)
+					&& $postFileResponse->body->status != self::STATUS_QUEUED)
+				{
+					error_log(
+						'Docsbox did not queue the posted file. Returned status: '.
+						$postFileResponse->body->status
+					);
+				}
+				else // any other generic error
+				{
+					error_log(
+						'An error occurred while posting to docsbox. Response: '.
+						print_r($postFileResponse, 1)
+					);
+				}
+			}
+		}
+		catch(\Httpful\Exception\ConnectionErrorException $cee) // Httpful exception
+		{
+			error_log($cee->getMessage());
+		}
+		catch (Exception $e) // any other exception
+		{
+			error_log($e->getMessage());
+		}
+
+		return $queueId;
+	}
+
+	/**
+	 * Check the status of the file convertion identified by the given queue element id
+	 * A URL is returned with the path where it is possible to download the converted file
+	 * If an error occurred then a null value is returned
+	 */
+	private static function _checkConvertion($queueId)
+	{
+		$resultUrl = null;
+		$startConvertionsTime = time(); // time when the file conversion has started
+
+		// Until a timeout has occurred
+		while (time() - $startConvertionsTime <= DOCSBOX_CONVERSION_TIMEOUT)
+		{
+			sleep(DOCSBOX_WAITING_SLEEP_TIME); // takes a nap on every round
+
+			try
+			{
+				// Calls the docsbox server to check the status of the
+				// file conversion using the provided queue id
+				// it expects a response in JSON format
+				$getStatusResponse = \Httpful\Request::get(DOCSBOX_SERVER.DOCSBOX_PATH_API.$queueId)
+					->expectsJson()
+					->send();
+
+				// Checks that:
+				// - the response is not empty
+				// - the reponse body has the property id
+				// - the property id is a valid string
+				// - the reponse body has the property status
+				// - docsbox is working the conversion of the posted file
+				if (is_object($getStatusResponse)
+					&& isset($getStatusResponse->body->id)
+					&& $getStatusResponse->body->id != '' && $getStatusResponse->body->id != null
+					&& isset($getStatusResponse->body->status))
+				{
+					// Checks that docsbox has finished working on the file conversion
+					// and that there is a valid resultUrl property
+					if ($getStatusResponse->body->status == self::STATUS_FINISHED
+						&& isset($getStatusResponse->body->result_url)
+						&& $getStatusResponse->body->result_url != ''
+						&& $getStatusResponse->body->result_url != null)
+					{
+						$resultUrl = $getStatusResponse->body->result_url;
+						break;
+					}
+					// Just started or still working on it
+					elseif ($getStatusResponse->body->status == self::STATUS_WORKING
+						|| $getStatusResponse->body->status == self::STATUS_STARTED)
+					{
+						// go on!
+					}
+					else // any other status is abnormal
+					{
+						error_log(
+							'Not valid status for queue element: '.$queueId.'. Response: '.
+							print_r($getStatusResponse, 1)
+						);
+						break; // interrupt the loop on error
+					}
+				}
+				else // if the response from the docsbox server is not valid
+				{
+					error_log(
+						'An error occurred while checking the docsbox activity. Response: '.
+						print_r($getStatusResponse, 1)
+					);
+					break; // interrupt the loop on error
+				}
+			}
+			catch(\Httpful\Exception\ConnectionErrorException $cee) // Httpful exception
+			{
+				error_log($cee->getMessage());
+				break; // interrupt the loop on error
+			}
+			catch (Exception $e) // any other exception
+			{
+				error_log($e->getMessage());
+				break; // interrupt the loop on error
+			}
+		}
+
+		return $resultUrl;
+	}
+
+	/**
+	 * Download the converted file using the provided URL, unzip it, and renames it into the provided file name
+	 */
+	private static function _downloadFile($resultUrl, $outputFileName)
+	{
+		$downloaded = false; // pessimistic assumption
+
+		try
+		{
+			// Download the file
+			$getFileResponse = \Httpful\Request::get(DOCSBOX_SERVER.$resultUrl)->send();
+
+			// If the downloaded file content is valid and not empty
+			if (isset($getFileResponse->body)
+				&& $getFileResponse->body != null
+				&& $getFileResponse->body != '')
+			{
+				// Output directory where to unzip the downloaded zip file
+				$outputDirectory = dirname($outputFileName);
+				// The path and name of the downloaded zip file
+				$temporaryDownloadedZip = sys_get_temp_dir().'/'.basename($resultUrl);
+
+				// Write the file content into a temporary directory and file
+				if (file_put_contents($temporaryDownloadedZip, $getFileResponse->body) != false)
+				{
+					$zipArchive = new ZipArchive;
+
+					// Open and extract the dowloaded zip file into the directory of the output file
+					if ($zipArchive->open($temporaryDownloadedZip) === true
+						&& $zipArchive->extractTo($outputDirectory) === true
+						&& $zipArchive->close() === true)
+					{
+						// Opened, extracted and closed!
+
+						// Rename the extracted file to the given output file name
+						if (rename($outputDirectory.'/'.self::OUTPUT_FILENAME, $outputFileName))
+						{
+							$downloaded = true;
+						}
+						else
+						{
+							error_log(
+								'An error occurred while renaming the extracted file: '.
+								$outputDirectory.'/'.self::OUTPUT_FILENAME.' into: '.
+								$outputFileName
+							);
+						}
+					}
+					else
+					{
+						error_log(
+							'An error occurred while working the dowloaded zip file: '.
+							$temporaryDownloadedZip
+						);
+					}
+				}
+				else // if an error occurred while writing
+				{
+					error_log(
+						'An error occurred while writing the file content to: '.
+						$temporaryDownloadedZip
+					);
+				}
+			}
+			else // if the downloaded file is not valid
+			{
+				error_log(
+					'An error occurred while downloading the file from the docsbox server: '.
+					print_r($getFileResponse, 1)
+				);
+			}
+		}
+		catch(\Httpful\Exception\ConnectionErrorException $cee)
+		{
+			error_log($cee->getMessage());
+		}
+		catch (Exception $e)
+		{
+			error_log($e->getMessage());
+		}
+
+		return $downloaded;
+	}
+}
+

application/libraries/DocumentLib.php

@@ -14,20 +14,28 @@ class DocumentLib
 		// Gets CI instance
 		$this->ci =& get_instance();
 
-		exec('unoconv --version', $ret_arr);
-
-		if(isset($ret_arr[0]))
+		// Which document converter has to be used
+		if (defined('DOCSBOX_ENABLED') && DOCSBOX_ENABLED === true)
 		{
-			$hlp = explode(' ', $ret_arr[0]);
-			if(isset($hlp[1]))
-			{
-				$this->unoconv_version = $hlp[1];
-			}
-			else
-				show_error('Could not get Unoconv Version');
+			// Use docsbox!!
 		}
 		else
-			show_error('Unoconv not found - Please install Unoconv');
+		{
+			exec('unoconv --version', $ret_arr);
+
+			if(isset($ret_arr[0]))
+			{
+				$hlp = explode(' ', $ret_arr[0]);
+				if(isset($hlp[1]))
+				{
+					$this->unoconv_version = $hlp[1];
+				}
+				else
+					show_error('Could not get Unoconv Version');
+			}
+			else
+				show_error('Unoconv not found - Please install Unoconv');
+		}
 	}
 
 	/**
@@ -57,9 +65,16 @@ class DocumentLib
 			case 'application/vnd.ms-word':
 			case 'application/vnd.oasis.opendocument.text':
 			case 'text/plain':
-				// Unoconv Version 0.6 seems to fail on converting TXT Files
-				if ($this->unoconv_version == '0.6')
-					return error();
+				if (defined('DOCSBOX_ENABLED') && DOCSBOX_ENABLED === true)
+				{
+					// Use docsbox
+				}
+				else
+				{
+					// Unoconv Version 0.6 seems to fail on converting TXT Files
+					if ($this->unoconv_version == '0.6')
+						return error();
+				}
 
 				$ret = $this->convert($filename, $outFile, 'pdf');
 				if(isSuccess($ret))
@@ -105,6 +120,7 @@ class DocumentLib
 
 		finfo_close($finfo);
 
+		$out = null;
 		exec($cmd, $out, $ret);
 		if ($ret != 0)
 		{
@@ -123,13 +139,26 @@ class DocumentLib
 	 */
 	public function convert($inFile, $outFile, $format)
 	{
-		if ($this->unoconv_version == '0.6')
-			$command = 'unoconv -f %1$s  %3$s > %2$s';
-		else
-			$command = 'unoconv -f %s --output %s %s 2>&1';
-		$command = sprintf($command, $format, $outFile, $inFile);
+		$ret = 0;
 
-		exec($command, $out, $ret);
+		// If it is set to use docsbox
+		if (defined('DOCSBOX_ENABLED') && DOCSBOX_ENABLED === true)
+		{
+			require_once(dirname(__FILE__).'/../application/libraries/DocsboxLib.php');
+
+			$ret = DocsboxLib::convert($inFile, $outFile, $format);
+		}
+		else // otherwise use unoconv
+		{
+			if ($this->unoconv_version == '0.6')
+				$command = 'unoconv -f %1$s  %3$s > %2$s';
+			else
+				$command = 'unoconv -f %s --output %s %s 2>&1';
+			$command = sprintf($command, $format, $outFile, $inFile);
+
+			$out = null;
+			exec($command, $out, $ret);
+		}
 
 		if ($ret != 0)
 		{
@@ -191,6 +220,7 @@ class DocumentLib
 		$cmd .= '/countspaces {  [ exch { dup 32 ne { pop } if  } forall ] length } bind def  >> ';
 		$cmd .= 'setpagedevice viewJPEG"';
 
+		$out = null;
 		exec($cmd, $out, $ret);
 		if ($ret != 0)
 		{

application/models/CL/Messages_model.php

@@ -128,8 +128,8 @@ class Messages_model extends CI_Model
 			{
 				$ouOptions .= sprintf(
 					"\n".'<option value="%s">%s</option>',
-					is_numeric($ou->prestudent_id) ? $ou->oe_kurzbz : self::ALT_OE,
-					$ou->bezeichnung . (is_numeric($ou->prestudent_id) ? '' : ' *')
+					($ou->typ === 'l' ? $ou->oe_kurzbz : (is_numeric($ou->prestudent_id) ? $ou->oe_kurzbz : self::ALT_OE)),
+					$ou->bezeichnung . ((is_numeric($ou->prestudent_id) || $ou->typ === 'l' ) ? '' : ' *')
 				);
 			}
 		}

application/models/crm/Prestudent_model.php

@@ -586,9 +586,10 @@ class Prestudent_model extends DB_Model
 						o.bezeichnung,
 						(CASE
 							WHEN sg.typ = \'b\' THEN ps.prestudent_id
-							WHEN sg.typ = \'m\' THEN ps.prestudent_id
+							WHEN sg.typ = \'m\' THEN mps.prestudent_id
             				ELSE NULL
-       					END) AS prestudent_id
+       					END) AS prestudent_id,
+       					sg.typ
 					FROM public.tbl_prestudent p
 			  		JOIN public.tbl_studiengang sg USING(studiengang_kz)
 					JOIN public.tbl_organisationseinheit o USING(oe_kurzbz)
@@ -597,11 +598,17 @@ class Prestudent_model extends DB_Model
 							  FROM public.tbl_prestudentstatus
 							 WHERE status_kurzbz = \'Bewerber\'
 						) ps USING(prestudent_id)
+				LEFT JOIN (
+					SELECT prestudent_id
+					FROM public.tbl_prestudentstatus
+					WHERE status_kurzbz = \'Interessent\' AND bestaetigtam IS NOT NULL
+				) mps ON p.prestudent_id = mps.prestudent_id
 				   WHERE p.person_id = ?
 				GROUP BY o.oe_kurzbz,
 						o.bezeichnung,
 						sg.typ,
 						ps.prestudent_id,
+						mps.prestudent_id,
 						p.prestudent_id
 				ORDER BY o.bezeichnung';
 

application/models/education/Paabgabe_model.php

@@ -1,7 +1,6 @@
 <?php
 class Paabgabe_model extends DB_Model
 {
-
 	/**
 	 * Constructor
 	 */
@@ -11,4 +10,24 @@ class Paabgabe_model extends DB_Model
 		$this->dbTable = 'campus.tbl_paabgabe';
 		$this->pk = 'paabgabe_id';
 	}
+
+	/**
+	 * Gets last Endabgabe of a Projektarbeit, including filename.
+	 * @param int $projektarbeit_id
+	 * @return object
+	 */
+	public function getEndabgabe($projektarbeit_id)
+	{
+		$qry = "SELECT paabgabe_id, student_uid, paabg.datum, paabg.abgabedatum, projekttyp_kurzbz, titel, titel_english,
+					paabgabe_id || '_' || student_uid || '.pdf' AS filename
+				FROM campus.tbl_paabgabe paabg
+				JOIN lehre.tbl_projektarbeit USING (projektarbeit_id)
+				WHERE projektarbeit_id = ?
+				AND paabgabetyp_kurzbz = 'end'
+				AND paabg.abgabedatum IS NOT NULL
+				ORDER BY paabg.abgabedatum, paabg.datum DESC
+				LIMIT 1";
+
+		return $this->execQuery($qry, array($projektarbeit_id));
+	}
 }

application/models/education/Projektbetreuer_model.php

@@ -54,18 +54,28 @@ class Projektbetreuer_model extends DB_Model
 		$qry = "SELECT DISTINCT ON (pers.person_id) pers.person_id, betreuerart_kurzbz, vorname, nachname,
 				trim(COALESCE(titelpre,'')||' '||COALESCE(vorname,'')||' '||COALESCE(nachname,'')||' '||COALESCE(titelpost,'')) as voller_name,
 				anrede, titelpre, titelpost, gebdatum, geschlecht, pa.projekttyp_kurzbz,
-				ben.uid, ben.alias, ma.personalnummer, mitarbeiter_uid, student_uid
-			FROM lehre.tbl_projektarbeit pa
-			JOIN lehre.tbl_projektbetreuer USING (projektarbeit_id)
-			JOIN public.tbl_person pers USING (person_id)
-			LEFT JOIN public.tbl_benutzer ben USING (person_id)
-			LEFT JOIN public.tbl_mitarbeiter ma ON ben.uid =  ma.mitarbeiter_uid
-			WHERE ben.aktiv
-			AND projektarbeit_id = ?
-			AND betreuerart_kurzbz = ?
-			ORDER BY pers.person_id, CASE WHEN ma.mitarbeiter_uid IS NULL THEN 1 ELSE 0 END, /*Mitarbeiter account first*/
-					CASE WHEN ben.uid IS NULL THEN 1 ELSE 0 END, /*user with account first*/
-         			ben.insertamum";
+				ben.uid, ben.alias, ma.personalnummer, mitarbeiter_uid, student_uid,
+				(
+					SELECT kontakt
+					FROM public.tbl_kontakt
+					WHERE kontakttyp = 'email'
+					AND person_id = pers.person_id
+					ORDER BY
+						CASE WHEN zustellung THEN 0 ELSE 1 END,
+						insertamum DESC NULLS LAST
+					LIMIT 1
+				) AS private_email
+				FROM lehre.tbl_projektarbeit pa
+				JOIN lehre.tbl_projektbetreuer USING (projektarbeit_id)
+				JOIN public.tbl_person pers USING (person_id)
+				LEFT JOIN public.tbl_benutzer ben USING (person_id)
+				LEFT JOIN public.tbl_mitarbeiter ma ON ben.uid = ma.mitarbeiter_uid
+				WHERE (ben.aktiv OR ben.aktiv IS NULL)
+				AND projektarbeit_id = ?
+				AND betreuerart_kurzbz = ?
+				ORDER BY pers.person_id, CASE WHEN ma.mitarbeiter_uid IS NULL THEN 1 ELSE 0 END, /*Mitarbeiter account first*/
+						CASE WHEN ben.uid IS NULL THEN 1 ELSE 0 END, /*user with account first*/
+						ben.insertamum";
 
 		return $this->execQuery($qry, array($projektarbeit_id, $betreuerart_kurzbz));
 	}
@@ -77,14 +87,14 @@ class Projektbetreuer_model extends DB_Model
 	 */
     public function getBetreuerByToken($zugangstoken)
 	{
-		$qry = '
+		$qry = "
 			SELECT tbl_projektbetreuer.person_id, tbl_projektbetreuer.projektarbeit_id, student_uid
 			FROM lehre.tbl_projektbetreuer
 			JOIN lehre.tbl_projektarbeit USING (projektarbeit_id)
 			WHERE zugangstoken = ? AND zugangstoken_gueltigbis >= NOW()
 			ORDER BY tbl_projektbetreuer.insertamum DESC, projektarbeit_id DESC
 			LIMIT 1
-		';
+		";
 
 		return $this->execQuery($qry, array($zugangstoken));
 	}
@@ -96,31 +106,60 @@ class Projektbetreuer_model extends DB_Model
 	 * @param $student_uid string uid des Studenten der Arbeit abgibt
 	 * @return object | bool
 	 */
-	public function getZweitbegutachterWithToken($erstbegutachter_person_id, $projektarbeit_id, $student_uid)
+	public function getZweitbegutachterWithToken($erstbegutachter_person_id, $projektarbeit_id, $student_uid, $zweitbegutachter_person_id = null)
 	{
-		$qry_betr = "SELECT betr.person_id, betr.projektarbeit_id, pers.anrede, betr.zugangstoken, betr.zugangstoken_gueltigbis, tbl_benutzer.uid, kontakt,
-				trim(COALESCE(titelpre,'')||' '||COALESCE(vorname,'')||' '||COALESCE(nachname,'')||' '||COALESCE(titelpost,'')) as voller_name,
-				CASE WHEN tbl_benutzer.uid IS NULL THEN kontakt ELSE tbl_benutzer.uid || '@".DOMAIN."' END AS email, abg.abgabedatum
-				FROM lehre.tbl_projektbetreuer betr
-				JOIN lehre.tbl_projektarbeit parb ON betr.projektarbeit_id = parb.projektarbeit_id 
-				JOIN public.tbl_person pers ON betr.person_id = pers.person_id
-				LEFT JOIN public.tbl_kontakt ON pers.person_id = tbl_kontakt.person_id AND kontakttyp = 'email' AND zustellung = true
-				LEFT JOIN public.tbl_benutzer ON pers.person_id = tbl_benutzer.person_id
-				LEFT JOIN campus.tbl_paabgabe abg ON betr.projektarbeit_id = abg.projektarbeit_id AND abg.paabgabetyp_kurzbz = 'end'
-				WHERE betr.betreuerart_kurzbz = 'Zweitbegutachter'
-				AND betr.projektarbeit_id = ?
-				AND parb.student_uid = ?
-				AND EXISTS (
-					SELECT 1 FROM lehre.tbl_projektbetreuer
-					WHERE person_id = ?
-					AND betreuerart_kurzbz = 'Erstbegutachter'
-					AND projektarbeit_id = betr.projektarbeit_id
-				)
-				AND (tbl_benutzer.aktiv OR tbl_benutzer.aktiv IS NULL)
-				ORDER BY betr.insertamum DESC
-				LIMIT 1";
+		$params = array($erstbegutachter_person_id, $erstbegutachter_person_id, $projektarbeit_id, $student_uid);
 
-		return $this->execQuery($qry_betr, array($projektarbeit_id, $student_uid, $erstbegutachter_person_id));
+		$qry_betr = "SELECT betr.person_id, betr.projektarbeit_id, pers.anrede, betr.zugangstoken, betr.zugangstoken_gueltigbis, tbl_benutzer.uid,
+					trim(COALESCE(titelpre,'')||' '||COALESCE(vorname,'')||' '||COALESCE(nachname,'')||' '||COALESCE(titelpost,'')) as voller_name,
+					CASE WHEN tbl_benutzer.uid IS NULL THEN kontakt ELSE tbl_benutzer.uid || '@".DOMAIN."' END AS email, kontakt,
+					abg.abgabedatum, betr.betreuerart_kurzbz
+					FROM lehre.tbl_projektbetreuer betr
+					JOIN lehre.tbl_projektarbeit parb ON betr.projektarbeit_id = parb.projektarbeit_id
+					JOIN public.tbl_person pers ON betr.person_id = pers.person_id
+					LEFT JOIN public.tbl_kontakt ON pers.person_id = tbl_kontakt.person_id AND kontakttyp = 'email' AND zustellung = true
+					LEFT JOIN public.tbl_benutzer ON pers.person_id = tbl_benutzer.person_id
+					LEFT JOIN campus.tbl_paabgabe abg ON betr.projektarbeit_id = abg.projektarbeit_id AND abg.paabgabetyp_kurzbz = 'end'
+					WHERE
+					(
+						(
+							betr.betreuerart_kurzbz  = 'Zweitbegutachter'
+							AND EXISTS (
+								SELECT 1 FROM lehre.tbl_projektbetreuer
+								WHERE person_id = ?
+								AND betreuerart_kurzbz = 'Erstbegutachter'
+								AND projektarbeit_id = betr.projektarbeit_id
+							)
+						)
+						OR /* either Zweitbegutachter of masterarbeit, or Kommissionsprüfer if Kommission */
+						(
+							betr.betreuerart_kurzbz  = 'Senatsmitglied'
+							AND EXISTS (
+								SELECT 1 FROM lehre.tbl_projektbetreuer
+								WHERE person_id = ?
+								AND betreuerart_kurzbz = 'Senatsvorsitz'
+								AND projektarbeit_id = betr.projektarbeit_id
+							)
+						)
+					)
+					AND betr.projektarbeit_id = ?
+					AND parb.student_uid = ?
+					AND (tbl_benutzer.aktiv OR tbl_benutzer.aktiv IS NULL)";
+
+					if (isset($zweitbegutachter_person_id))
+					{
+						$qry_betr .= " AND betr.person_id = ?";
+						$params[] = $zweitbegutachter_person_id;
+					}
+
+					$qry_betr .= " ORDER BY betr.person_id DESC,
+					(CASE WHEN EXISTS ( /* if multiple accounts, prioritize mitarbeiter */
+						SELECT 1 FROM public.tbl_mitarbeiter ma
+						WHERE ma.mitarbeiter_uid = tbl_benutzer.uid
+					) THEN 0 ELSE 1 END), betr.insertamum DESC
+					LIMIT 1";
+
+		return $this->execQuery($qry_betr, $params);
 	}
 
 	/**
@@ -131,23 +170,23 @@ class Projektbetreuer_model extends DB_Model
 	 */
 	public function generateZweitbegutachterToken($zweitbegutachter_person_id, $projektarbeit_id)
 	{
-		$betreuerUidQry = "SELECT uid, zugangstoken, zugangstoken_gueltigbis, tbl_projektbetreuer.person_id
+		$betreuerUidQry = "SELECT uid, zugangstoken, zugangstoken_gueltigbis, tbl_projektbetreuer.person_id, betreuerart_kurzbz
 							FROM lehre.tbl_projektbetreuer
 							JOIN public.tbl_person USING(person_id)
 							LEFT JOIN public.tbl_benutzer USING(person_id)
 							WHERE projektarbeit_id = ?
 							AND tbl_projektbetreuer.person_id = ?
-							AND betreuerart_kurzbz = 'Zweitbegutachter'
+							AND betreuerart_kurzbz IN ('Zweitbegutachter', 'Senatsmitglied')
 							LIMIT 1";
 
-		$betreueruidres = $this->execQuery($betreuerUidQry, array($projektarbeit_id, $zweitbegutachter_person_id));
+		$betreueruidRes = $this->execQuery($betreuerUidQry, array($projektarbeit_id, $zweitbegutachter_person_id));
 
-		if (!hasData($betreueruidres))
+		if (!hasData($betreueruidRes))
 			return error('Zweitbegutachter nicht gefunden');
 
-		$row_betr = getData($betreueruidres)[0];
+		$zweitbetreuer = getData($betreueruidRes)[0];
 
-		if (!isset($row_betr->uid))
+		if (!isset($zweitbetreuer->uid))
 		{
 			do {
 				$token = generateToken(16);
@@ -156,8 +195,8 @@ class Projektbetreuer_model extends DB_Model
 
 			$result = $this->update(
 				array('projektarbeit_id' => $projektarbeit_id,
-					'person_id' => $row_betr->person_id,
-					'betreuerart_kurzbz' => 'Zweitbegutachter'),
+					'person_id' => $zweitbetreuer->person_id,
+					'betreuerart_kurzbz' => $zweitbetreuer->betreuerart_kurzbz),
 				array('zugangstoken' => $token,
 					'zugangstoken_gueltigbis' => date('Y-m-d', strtotime('+1 year')))
 			);
@@ -167,4 +206,29 @@ class Projektbetreuer_model extends DB_Model
 		else
 			return success("Account vorhanden, kein Token benötigt");
 	}
+
+	/**
+	 * Gets betreuerart of a Betreuer for a Projektarbeit.
+	 * Main Betreuer are prioritized (normally one Betreuer should be assigned to a Projektarbeit another time with a different Betreuerart).
+	 * @param int projektarbeit_id
+	 * @param int betreuer_person_id
+	 * @return object success or error
+	 */
+	public function getBetreuerart($projektarbeit_id, $betreuer_person_id)
+	{
+		$qry = "SELECT betreuerart_kurzbz
+				FROM lehre.tbl_projektbetreuer
+				WHERE projektarbeit_id = ?
+				AND person_id = ?
+				ORDER BY CASE WHEN betreuerart_kurzbz = 'Senatsvorsitz' THEN 1 /*Senatsvorsitz has priority*/
+					WHEN betreuerart_kurzbz = 'Begutachter' THEN 2
+					WHEN betreuerart_kurzbz = 'Erstbegutachter' THEN 3
+					WHEN betreuerart_kurzbz = 'Zweitbegutachter' THEN 4
+					WHEN betreuerart_kurzbz = 'Senatsmitglied' THEN 5
+					ELSE 5
+				END, insertamum DESC
+				LIMIT 1";
+
+		return $this->execQuery($qry, array($projektarbeit_id, $betreuer_person_id));
+	}
 }