After moving javascript code from the view to an external js file, the
usage of global variable has_inkludierteLehre was causing css issues.
Now the check if lector has inkludierte lehre is an extra method in the
controller which is called by AJAX in the tabulators render-callback
function.
Because of recently commited extra check of stunden/vertragstunden to
determine geaenderte Lehrauftraege correctly, the row update callback
function needed also extra information to format status icon correctly.
This is fixed now.
Before the organisational unit of the lv was sent via AJAX to the server
and used for checking the permissions on that organisational unit.
This was insecure (post data manipulation) and organisational units were
wrong (prepared string instead of oe_kurzbz).
This is fixed now by serverside check of organisational unit.
(based on given vertrag_id)
. getLehreinheitID(): Gets Lehreinheit ID corresponding to the contract.
. getLehreinheitData(): Gets (table) data of lehreinheit_id
corresponding to the contract.
Up to now changes were identified only by comparing betrag with
vertrag_betrag.
Problem is: when a new Lehrauftrag betrag is set with 0 or NULL and only
hours are set, a later change of hours cannot be identified (as the betrag
and vertrag_betrag do not change). This is fixed now.
Up to now changes were identified only by comparing betrag with
vertrag_betrag.
Problem is: when a new Lehrauftrag betrag is set with 0 or NULL and only
hours are set, a later change of hours cannot be identified (as the betrag
and vertrag_betrag do not change). This is fixed now.
Before the number of params was overflowing POST param limitation of 1000.
Now data is json stringified on clientside to pack all data in only one
string. Adaptations were done also on serverside.
The new line in concatinated groups was causing extra lines in
excel file and messing the structure.
Also adapted download status title to enable correct data import of
csv text file.
Some selections/filters were not selecting/filtering correctly out the
dummy lectors OR filtering out Betreuung.
It needs: personalnummer >= 0
. > to ensure no dummies
. = to retrieve also Betreuungen
(where personalnummer is provided with NULL)
New:
. tabulator footer with
- buttons Alle auswählen/abwählen
- display number of selected rows
- CSV download
. filter buttons
- accept-button now initially activated and focused, toggle on click
- now as buttongroup in extra row
New:
. tabulator footer with
- buttons Alle auswählen/abwählen
- display number of selected rows
- CSV download
. filter buttons
- approve-button now initially activated and focused, toggle on click
- now as buttongroup in extra row
. Lehrauftrag erteilen - button disabled when filter on dummies
New:
. tabulator footer with
- buttons Alle auswählen/abwählen
- display number of selected rows
- CSV download
. filter buttons
- order-button now initially activated and focused, toggle on click
- now as buttongroup in extra row
. Lehrauftrag bestellen - button disabled when filter on dummies
Now header filter parses the given filterstring.
If it starts with a comparison operator it will be used for comparison.
Otherwise just compare the stringnumbers to be equal.
Setting png icons is a workaround to use font-awsome 5.9.0 icons
until system can be updated to newer font awsome version.
Changed for filter/status buttons:
. ordered
. approved
. changed
. added tooltips on bestellt-, erteilt- and akzeptiert-column with
insertvon information
. adapted tooltips on status column
. added columns to all tabulator queries and to the filters
Cris