From 4f8f88d8804cce6b7e1fdbf9a61e44da74065df4 Mon Sep 17 00:00:00 2001
From: Nicolas <nicolas@gruber.info>
Date: Tue, 28 Apr 2026 14:52:16 +0200
Subject: [PATCH] domain fix

---
 Setup-ByteTrail-AD.ps1 | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/Setup-ByteTrail-AD.ps1 b/Setup-ByteTrail-AD.ps1
index 9a19f02..efa537e 100644
--- a/Setup-ByteTrail-AD.ps1
+++ b/Setup-ByteTrail-AD.ps1
@@ -10,6 +10,7 @@ $Domain     = "bytetrail.local"
 $DomainDN   = "DC=bytetrail,DC=local"
 $MailDomain = "byte.trail"
 $DefaultPW  = ConvertTo-SecureString "ByteTrail2026!" -AsPlainText -Force
+$DC         = $env:COMPUTERNAME   # Script laeuft direkt auf dem DC
 #endregion
 
 Write-Host "`n=== ByteTrail AD Setup gestartet ===" -ForegroundColor Cyan
@@ -31,11 +32,11 @@ $OUs = @(
 foreach ($OU in $OUs) {
     $OUName = ($OU -split ",")[0] -replace "OU=", ""
     try {
-        $existing = Get-ADOrganizationalUnit -Identity $OU -Server $Domain -ErrorAction Stop
+        $existing = Get-ADOrganizationalUnit -Identity $OU -Server $DC -ErrorAction Stop
         Write-Host "  [~] OU existiert bereits: $OUName" -ForegroundColor Gray
     } catch [Microsoft.ActiveDirectory.Management.ADIdentityNotFoundException] {
         try {
-            New-ADOrganizationalUnit -Name $OUName -Path $DomainDN -ProtectedFromAccidentalDeletion $true -Server $Domain -ErrorAction Stop
+            New-ADOrganizationalUnit -Name $OUName -Path $DomainDN -ProtectedFromAccidentalDeletion $true -Server $DC -ErrorAction Stop
             Write-Host "  [+] OU erstellt: $OUName" -ForegroundColor Green
         } catch {
             Write-Host "  [!] FEHLER beim Erstellen von OU '$OUName': $_" -ForegroundColor Red
@@ -43,7 +44,7 @@ foreach ($OU in $OUs) {
     } catch {
         # Anderer Fehler beim Pruefen - versuche trotzdem zu erstellen
         try {
-            New-ADOrganizationalUnit -Name $OUName -Path $DomainDN -ProtectedFromAccidentalDeletion $true -Server $Domain -ErrorAction Stop
+            New-ADOrganizationalUnit -Name $OUName -Path $DomainDN -ProtectedFromAccidentalDeletion $true -Server $DC -ErrorAction Stop
             Write-Host "  [+] OU erstellt: $OUName" -ForegroundColor Green
         } catch {
             Write-Host "  [!] FEHLER beim Erstellen von OU '$OUName': $_" -ForegroundColor Red
@@ -72,7 +73,7 @@ $Groups = @(
 
 foreach ($Group in $Groups) {
     try {
-        $existing = Get-ADGroup -Identity $Group.Name -Server $Domain -ErrorAction Stop
+        $existing = Get-ADGroup -Identity $Group.Name -Server $DC -ErrorAction Stop
         Write-Host "  [~] Gruppe existiert bereits: $($Group.Name)" -ForegroundColor Gray
     } catch [Microsoft.ActiveDirectory.Management.ADIdentityNotFoundException] {
         try {
@@ -206,7 +207,7 @@ foreach ($User in $Users) {
     $UserCreated = $false
 
     try {
-        $existing = Get-ADUser -Identity $Sam -Server $Domain -ErrorAction Stop
+        $existing = Get-ADUser -Identity $Sam -Server $DC -ErrorAction Stop
         Write-Host "  [~] User existiert bereits: $Sam" -ForegroundColor Gray
         $UserExistsCount++
         $UserCreated = $true  # User existiert, Gruppen trotzdem zuweisen
@@ -246,7 +247,7 @@ foreach ($User in $Users) {
     if ($UserCreated) {
         foreach ($Gruppe in $User.Gruppen) {
             try {
-                Add-ADGroupMember -Identity $Gruppe -Members $Sam -Server $Domain -ErrorAction Stop
+                Add-ADGroupMember -Identity $Gruppe -Members $Sam -Server $DC -ErrorAction Stop
             } catch {
                 if ($_.Exception.Message -like "*already a member*" -or $_.Exception.Message -like "*ist bereits Mitglied*") {
                     # Stille Warnung - User ist schon in der Gruppe
@@ -268,7 +269,7 @@ $SvcUPN = "$SvcSam@$Domain"
 $SvcPW  = ConvertTo-SecureString 'Mail$3rv!ceAcc2026' -AsPlainText -Force
 
 try {
-    $existing = Get-ADUser -Identity $SvcSam -Server $Domain -ErrorAction Stop
+    $existing = Get-ADUser -Identity $SvcSam -Server $DC -ErrorAction Stop
     Write-Host "  [~] Service-Account existiert bereits: $SvcSam" -ForegroundColor Gray
 } catch [Microsoft.ActiveDirectory.Management.ADIdentityNotFoundException] {
     try {