Cleanup & existing phrases

application/controllers/api/frontend/v1/stv/Config.php

@@ -269,7 +269,7 @@ class Config extends FHCAPI_Controller
 			"&lvid={lehrveranstaltung_id}";
 
 		$archive_url = "api/frontend/v1/documents/archiveSigned";
-		$archive_response = $this->p->t("stv", "document_signed_and_archived");
+		$archive_response = $this->p->t("stv", "document_signed_and_archived"); // TODO(chris): phrase
 		$archive_post_ff = [
 			"xml" => "zertifikat.rdf.php",
 			"xsl" => "Zertifikat",

public/js/components/Stv/Studentenverwaltung/Details/Noten/Zeugnis.js

@@ -175,7 +175,7 @@ export default {
 							deleteButton.append(icon);
 							deleteButton.addEventListener('click', evt => {
 								evt.stopPropagation();
-								this.deleteGrade(data);// TODO(chris): test with new data object
+								this.deleteGrade(data);
 							});
 							container.append(deleteButton);
 						}
@@ -225,6 +225,7 @@ export default {
 				.catch(this.$fhcAlert.handleFormValidation);
 		},
 		deleteGrade(data) {
+			// NOTE(chris): There is no check if there is an entry to be deleted, but it works anyway
 			return this.$fhcAlert
 				.confirmDelete()
 				.then(result => result ? data : Promise.reject({handled:true}))
@@ -234,10 +235,9 @@ export default {
 				.catch(this.$fhcAlert.handleSystemError);
 		}
 	},
-	// TODO(chris): phrasen
+	// TODO(chris): phrasen (title)
 	template: `
 	<div class="stv-details-noten-zeugnis h-100 d-flex flex-column">
-		<!-- TODO(chris): phrase -->
 		<core-filter-cmpt
 			ref="table"
 			title="Certificate"

public/js/components/Stv/Studentenverwaltung/Details/Noten/Zeugnis/Actions.js

@@ -91,7 +91,7 @@ export default {
 			})
 			.catch(this.$fhcAlert.handleSystemError);
 	},
-	// TODO(chris): phrases
+	// TODO(chris): phrases (option"")
 	template: `
 	<div class="stv-details-noten-zeugnis-actions d-flex gap-2">
 		<template v-if="['both', 'header'].includes(config.edit)">

public/js/components/Stv/Studentenverwaltung/Details/Noten/Zeugnis/Documents.js

@@ -62,7 +62,7 @@ export default {
 									);
 							this.$fhcApi
 								.post(this.addParamsToString(part.action.url), post)
-								.then(() => part.action.response || 'TODO(chris): phrase default')
+								.then(() => part.action.response || this.$p.t('ui/successSave'))
 								.then(this.$fhcAlert.alertSuccess)
 								.catch(this.$fhcAlert.handleSystemError);
 						};