try/catch around moodle event & proper error message

This commit is contained in:
Johann Hoffmann
2025-12-17 14:29:05 +01:00
parent 43925e3088
commit 2cee36d7b5
2 changed files with 16 additions and 15 deletions
@@ -130,21 +130,21 @@ class Noten extends FHCAPI_Controller
}
// send $grades reference to moodle addon
// TODO: DONT LET FAULTY MOODLE TOKEN BREAK THE STARTUP
// Events::trigger(
// 'getExternalGrades',
// function & () use (&$grades)
// {
// return $grades;
// },
// [
// 'lvid' => $lv_id,
// 'stsem' => $sem_kurzbz
// ]
// );
try {
Events::trigger(
'getExternalGrades',
function & () use (&$grades)
{
return $grades;
},
[
'lvid' => $lv_id,
'stsem' => $sem_kurzbz
]
);
} catch (Throwable $t) {
$this->addMeta('getExternalGradesError', $t->getMessage());
}
// calculate notenvorschläge from teilnoten
foreach($studentenData as $student) {
@@ -1105,6 +1105,7 @@ export const Benotungstool = {
this.$api.call(ApiNoten.getStudentenNoten(lv_id, sem_kurzbz))
.then(res => {
if(res?.data) this.setupData(res.data)
if(res?.meta?.getExternalGradesError) this.$fhcAlert.alertError(res.meta.getExternalGradesError)
}).finally(()=> {
this.loading = false
})