blackicedbear/FHC-Core
1
0
Fork 0
mirror of https://github.com/FH-Complete/FHC-Core.git synced 2026-07-20 00:12:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Corrected STGL permission check to check against UID

Browse Source 
Signed-off-by: cris-technikum <hainberg@technikum-wien.at>
This commit is contained in:
Cris
2021-02-08 18:01:06 +01:00
committed by cris-technikum
parent 00799f2f64
commit 77774e8cec
2 changed files with 30 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
application/controllers/lehre/anrechnung/ApproveAnrechnungDetail.php
+20 -9
View File
@@ -37,6 +37,7 @@ class approveAnrechnungDetail extends Auth_Controller
$this->load->model('crm/Prestudent_model', 'PrestudentModel');
$this->load->model('person/Notiz_model', 'NotizModel');
$this->load->model('person/Person_model', 'PersonModel');
$this->load->model('organisation/Studiengang_model', 'StudiengangModel');
// Load libraries
$this->load->library('WidgetLib');
@@ -309,23 +310,28 @@ class approveAnrechnungDetail extends Auth_Controller
*/
private function _checkIfEntitledToReadAnrechnung($anrechnung_id)
{
// Retrieve studiengaenge the user is entitled for
$studiengang_kz_arr = $this->permissionlib->getSTG_isEntitledFor(self::BERECHTIGUNG_ANRECHNUNG_GENEHMIGEN);
$result = $this->AnrechnungModel->load($anrechnung_id);
if(!$result = getData($result)[0])
{
show_error('Failed retrieving Anrechnung');
show_error('Failed loading Anrechnung');
}
$result = $this->LehrveranstaltungModel->loadWhere(array(
'lehrveranstaltung_id' => $result->lehrveranstaltung_id
));
if(!$result = getData($result)[0])
{
show_error('Failed loading Lehrveranstaltung');
}
// Get STGL
$result = $this->StudiengangModel->getLeitung($result->studiengang_kz);
if($result = getData($result)[0])
{
if (in_array($result->studiengang_kz, $studiengang_kz_arr))
if ($result->uid == $this->_uid)
{
return;
}
@@ -340,9 +346,6 @@ class approveAnrechnungDetail extends Auth_Controller
*/
private function _checkIfEntitledToReadDMSDoc($dms_id)
{
// Retrieve studiengaenge the user is entitled for
$studiengang_kz_arr = $this->permissionlib->getSTG_isEntitledFor(self::BERECHTIGUNG_ANRECHNUNG_GENEHMIGEN);
$result = $this->AnrechnungModel->loadWhere(array('dms_id' => $dms_id));
if(!$result = getData($result)[0])
@@ -354,9 +357,17 @@ class approveAnrechnungDetail extends Auth_Controller
'lehrveranstaltung_id' => $result->lehrveranstaltung_id
));
if(!$result = getData($result)[0])
{
show_error('Failed loading Lehrveranstaltung');
}
// Get STGL
$result = $this->StudiengangModel->getLeitung($result->studiengang_kz);
if($result = getData($result)[0])
{
if (in_array($result->studiengang_kz, $studiengang_kz_arr))
if ($result->uid == $this->_uid)
{
return;
}
application/controllers/lehre/anrechnung/ApproveAnrechnungUebersicht.php
+10 -5
View File
@@ -276,10 +276,6 @@ class approveAnrechnungUebersicht extends Auth_Controller
*/
private function _checkIfEntitledToReadDMSDoc($dms_id)
{
// Retrieve studiengaenge the user is entitled for
$studiengang_kz_arr = $this->permissionlib->getSTG_isEntitledFor(self::BERECHTIGUNG_ANRECHNUNG_GENEHMIGEN);
$result = $this->AnrechnungModel->loadWhere(array('dms_id' => $dms_id));
if(!$result = getData($result)[0])
@@ -291,9 +287,18 @@ class approveAnrechnungUebersicht extends Auth_Controller
'lehrveranstaltung_id' => $result->lehrveranstaltung_id
));
if(!$result = getData($result)[0])
{
show_error('Failed loading Lehrveranstaltung');
}
// Get STGL
$result = $this->StudiengangModel->getLeitung($result->studiengang_kz);
if($result = getData($result)[0])
{
if (in_array($result->studiengang_kz, $studiengang_kz_arr))
if ($result->uid == $this->_uid)
{
return;
}