blackicedbear/FHC-Core
1
0
Fork 0
mirror of https://github.com/FH-Complete/FHC-Core.git synced 2026-06-12 17:49:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed: Added check before DB insert

Browse Source 
A check was missing if the contract already had that status. Error
was given. This is fixed now.
This commit is contained in:
Cris
2019-09-19 13:23:12 +02:00
committed by hainberg
parent 62cd1b6317
commit 8566039cc4
1 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
application/models/accounting/Vertrag_model.php
+18 -3
View File
@@ -115,7 +115,7 @@ class Vertrag_model extends DB_Model
// If updating vertrag_id was successfully, set Status to 'bestellt'
if (isSuccess($result))
{
$result = $this->setStatus($vertrag_id, 'bestellt', $mitarbeiter_uid);
$result = $this->setStatus($vertrag_id, $mitarbeiter_uid,'bestellt');
}
// Transaction complete!
@@ -142,10 +142,25 @@ class Vertrag_model extends DB_Model
* @param $vertrag_id
* @param $vertragsstatus_kurzbz
* @param $mitarbeiter_uid
* @return array|null On success object. On failure null.
* @return array|null On success object, retval is true. Null if status already exist for this vertrag.
*/
public function setStatus($vertrag_id, $vertragsstatus_kurzbz, $mitarbeiter_uid){
public function setStatus($vertrag_id, $mitarbeiter_uid, $vertragsstatus_kurzbz){
// First check if vertrag has already this status
$this->addJoin('lehre.tbl_vertrag_vertragsstatus', 'vertrag_id');
$result = $this->loadWhere(array(
'vertrag_id' => $vertrag_id,
'uid' => $mitarbeiter_uid,
'vertragsstatus_kurzbz' => $vertragsstatus_kurzbz
));
if (!isEmptyArray($result->retval))
{
return success(null); // return null if status already set
}
// Set new status
$query = '
INSERT INTO lehre.tbl_vertrag_vertragsstatus(
vertragsstatus_kurzbz,