blackicedbear/FHC-Core
1
0
Fork 0
mirror of https://github.com/FH-Complete/FHC-Core.git synced 2026-07-21 08:52:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

issues auto-resolve: added checks if library forissue exists and has method for resolving

Browse Source
This commit is contained in:
KarpAlex
2022-02-08 21:47:33 +01:00
parent b145e341b8
commit a6771df4dd
1 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
application/core/IssueResolver_Controller.php
+25 -5
View File
@@ -6,6 +6,7 @@
abstract class IssueResolver_Controller extends JOB_Controller
{
const ISSUES_FOLDER = 'issues';
const CHECK_ISSUE_RESOLVED_METHOD_NAME = 'checkIfIssueIsResolved';
protected $_codeLibMappings;
@@ -57,17 +58,36 @@ abstract class IssueResolver_Controller extends JOB_Controller
isset($issue->behebung_parameter) ? json_decode($issue->behebung_parameter, true) : array()
);
// if called from extension (extension name set), path includes extension names, otherwiese it is the core library folder
$libPath = isset($this->_extensionName) ? 'extensions/'.$this->_extensionName.'/'.self::ISSUES_FOLDER.'/' : self::ISSUES_FOLDER.'/';
// if called from extension (extension name set), path includes extension names, otherwise it is the core library folder
$libRootPath = isset($this->_extensionName) ? 'extensions/'.$this->_extensionName.'/' : '';
$issuesLibPath = $libRootPath.self::ISSUES_FOLDER.'/';
$issuesLibFilePath = DOC_ROOT.'application/' . $libRootPath.'libraries/'.self::ISSUES_FOLDER.'/'.$libName.'.php';
// check if library file exists
if (!file_exists($issuesLibFilePath))
{
// log error and continue with next issue if not
$this->logError("Issue library file ".$issuesLibFilePath." does not exist");
continue;
}
// load library connected to fehlercode
$this->load->library(
$libPath.$libName
$issuesLibPath.$libName
);
$lowercaseLibName = mb_strtolower($libName);
// call the function for checking if issue is resolved
$issueResolvedRes = $this->{$lowercaseLibName}->checkIfIssueIsResolved($params);
// check if method is defined in libary class
if (!is_callable(array($this->{$lowercaseLibName}, self::CHECK_ISSUE_RESOLVED_METHOD_NAME)))
{
// log error and continue with next issue if not
$this->logError("Method " . self::CHECK_ISSUE_RESOLVED_METHOD_NAME . " is not defined in library $lowercaseLibName");
continue;
}
// call the function for checking for issue resolution
$issueResolvedRes = $this->{$lowercaseLibName}->{self::CHECK_ISSUE_RESOLVED_METHOD_NAME}($params);
if (isError($issueResolvedRes))
{