blackicedbear/FHC-Core
1
0
Fork 0
mirror of https://github.com/FH-Complete/FHC-Core.git synced 2026-07-22 17:32:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

automatic issue resolving:

Browse Source 
- removed comments
- automatically added issue_id to params, output the id in error messages
This commit is contained in:
KarpAlex
2022-01-17 21:46:19 +01:00
parent 82dbe27112
commit de60770e74
13 changed files with 13 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
application/core/IssueResolver_Controller.php
+1 -1
View File
@@ -51,7 +51,7 @@ abstract class IssueResolver_Controller extends JOB_Controller
// add person id and oe kurzbz automatically as params, merge it with additional params
// decode bewerbung_parameter into assoc array
$params = array_merge(
array('issue_person_id' => $issue->person_id, 'issue_oe_kurzbz' => $issue->oe_kurzbz),
array('issue_id' => $issue->issue_id, 'issue_person_id' => $issue->person_id, 'issue_oe_kurzbz' => $issue->oe_kurzbz),
isset($issue->behebung_parameter) ? json_decode($issue->behebung_parameter, true) : array()
);
application/libraries/IssuesLib.php
+1 -6
View File
@@ -85,7 +85,7 @@ class IssuesLib
* @param bool $force_predefined if true, only predefined (with entry in fehler table) external issues are added
* @return object success or error
*/
public function addExternalIssue($fehlercode_extern, $inhalt_extern, $person_id = null, $oe_kurzbz = null, $fehlertext_params = null/* $resolve_params = null*//*, $force_predefined = false*/)
public function addExternalIssue($fehlercode_extern, $inhalt_extern, $person_id = null, $oe_kurzbz = null, $fehlertext_params = null)
{
if (isEmptyString($fehlercode_extern))
return error("fehlercode_extern missing");
@@ -109,11 +109,6 @@ class IssuesLib
// if found, use the code
$fehlercode = $fehlerData->fehlercode;
}
/*elseif ($force_predefined === true)
{
// only added if predefined
return success("Keine Definition gefunden - Issue nicht hinzugefügt");
}*/
else
{
// if predefined error is not found, insert with fallback code
application/libraries/issues/CORE_INOUT_0001.php
+1 -1
View File
@@ -10,7 +10,7 @@ class CORE_INOUT_0001 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['bisio_id']) || !is_numeric($params['bisio_id']))
return error('Bisio Id missing');
return error('Bisio Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance
application/libraries/issues/CORE_INOUT_0002.php
+1 -1
View File
@@ -8,7 +8,7 @@ class CORE_INOUT_0002 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['bisio_id']) || !is_numeric($params['bisio_id']))
return error('Bisio Id missing');
return error('Bisio Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance
application/libraries/issues/CORE_INOUT_0003.php
+1 -1
View File
@@ -10,7 +10,7 @@ class CORE_INOUT_0003 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['bisio_id']) || !is_numeric($params['bisio_id']))
return error('Bisio Id missing');
return error('Bisio Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance
application/libraries/issues/CORE_INOUT_0004.php
+1 -1
View File
@@ -10,7 +10,7 @@ class CORE_INOUT_0004 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['bisio_id']) || !is_numeric($params['bisio_id']))
return error('Bisio Id missing');
return error('Bisio Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance
application/libraries/issues/CORE_INOUT_0005.php
+1 -1
View File
@@ -10,7 +10,7 @@ class CORE_INOUT_0005 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['bisio_id']) || !is_numeric($params['bisio_id']))
return error('Bisio Id missing');
return error('Bisio Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance
application/libraries/issues/CORE_INOUT_0006.php
+1 -1
View File
@@ -10,7 +10,7 @@ class CORE_INOUT_0006 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['bisio_id']) || !is_numeric($params['bisio_id']))
return error('Bisio Id missing');
return error('Bisio Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance
application/libraries/issues/CORE_ZGV_0001.php
+1 -1
View File
@@ -10,7 +10,7 @@ class CORE_ZGV_0001 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['prestudent_id']) || !is_numeric($params['prestudent_id']))
return error('Prestudent Id missing');
return error('Prestudent Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance
application/libraries/issues/CORE_ZGV_0002.php
+1 -1
View File
@@ -10,7 +10,7 @@ class CORE_ZGV_0002 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['prestudent_id']) || !is_numeric($params['prestudent_id']))
return error('Prestudent Id missing');
return error('Prestudent Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance
application/libraries/issues/CORE_ZGV_0003.php
+1 -1
View File
@@ -10,7 +10,7 @@ class CORE_ZGV_0003 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['prestudent_id']) || !is_numeric($params['prestudent_id']))
return error('Prestudent Id missing');
return error('Prestudent Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance
application/libraries/issues/CORE_ZGV_0004.php
+1 -1
View File
@@ -10,7 +10,7 @@ class CORE_ZGV_0004 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['prestudent_id']) || !is_numeric($params['prestudent_id']))
return error('Prestudent Id missing');
return error('Prestudent Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance
application/libraries/issues/CORE_ZGV_0005.php
+1 -1
View File
@@ -10,7 +10,7 @@ class CORE_ZGV_0005 implements IIssueResolvedChecker
public function checkIfIssueIsResolved($params)
{
if (!isset($params['prestudent_id']) || !is_numeric($params['prestudent_id']))
return error('Prestudent Id missing');
return error('Prestudent Id missing, issue_id: '.$params['issue_id']);
$this->_ci =& get_instance(); // get code igniter instance