- Bugfix: fixed method generateFilterMenu of FiltersLib to generate the correct link for menu entries

- Bugfix: system/Filters_model is loaded in every methods of FiltersLib and FilterWidget where it is used
This commit is contained in:
Paolo
2018-12-10 12:24:28 +01:00
parent 6716ce5e2a
commit e0b1c78eef
2 changed files with 9 additions and 1 deletions
+5 -1
View File
@@ -313,6 +313,8 @@ class FiltersLib
if ($datasetQuery != null)
{
$this->_ci->load->model('system/Filters_model', 'FiltersModel');
// Execute the given SQL statement suppressing error messages
$dataset = @$this->_ci->FiltersModel->execReadOnlyQuery($datasetQuery);
}
@@ -715,7 +717,7 @@ class FiltersLib
$filter->description[0], // description
sprintf(
'%s?%s=%s',
site_url($this->_ci->router->directory.$this->_ci->router->class.'/'.$this->_ci->router->method),
site_url($navigationPage),
self::FILTER_ID,
$filter->filter_id
) // link
@@ -816,6 +818,8 @@ class FiltersLib
{
$condition = ''; // starts building the condition
$this->_ci->load->model('system/Filters_model', 'FiltersModel');
// "operation" is a required property for the applied filter definition
if (!isEmptyString($filterDefinition->operation))
{
+4
View File
@@ -312,6 +312,8 @@ class FilterWidget extends Widget
{
$this->_formatDataset($dataset); // marks rows using markRow and format rowns using formatRow
$this->load->model('system/Filters_model', 'FiltersModel');
// Set the new dataset and its attributes in the session
$this->filterslib->setElementSession(FiltersLib::SESSION_METADATA, $this->FiltersModel->getExecutedQueryMetaData());
$this->filterslib->setElementSession(FiltersLib::SESSION_ROW_NUMBER, count($dataset->retval));
@@ -350,6 +352,8 @@ class FilterWidget extends Widget
{
$this->_formatDataset($dataset); // marks rows using markRow and format rowns using formatRow
$this->load->model('system/Filters_model', 'FiltersModel');
// Stores an array that contains all the data useful for
$this->filterslib->setSession(
array(