Merge branch 'master' into feature-63428/Infomail_Foto

- expand InputComponent for dynamic adding of actionButton to Form Upload Image
- add Phrases for Infomail

application/config/navigation.php

@@ -336,24 +336,3 @@ $config['navigation_menu']['system/issues/Issues/*'] = array(
 		'requiredPermissions' => array('admin:rw')
 	),
 );
-
-$config['navigation_menu']['apps'] = [
-	'stv' => [
-		'link' => site_url('studentenverwaltung'),
-		'description' => 'Studierendenverwaltung',
-		#'icon' => 'users',
-		'requiredPermissions' => array('admin:r', 'assistenz:r')
-	],
-	'lvv' => [
-		'link' => site_url('lVVerwaltung'),
-		'description' => 'LV Verwaltung',
-		#'icon' => 'person-chalkboard',
-		'requiredPermissions' => array('admin:r', 'assistenz:r')
-	],
-	'lav' => [
-		'link' => site_url('lehre/lehrauftrag/Lehrauftrag/Dashboard'),
-		'description' => 'Lehraufträge',
-		#'icon' => 'person-chalkboard',
-		'requiredPermissions' => array('lehre/lehrauftrag_bestellen:r', 'lehre/lehrauftrag_erteilen:r')
-	]
-];

application/config/routes.php

@@ -1,6 +1,6 @@
 <?php
 
-if (! defined('BASEPATH')) exit('No direct script access allowed');
+defined('BASEPATH') OR exit('No direct script access allowed');
 
 /*
 | -------------------------------------------------------------------------
@@ -51,7 +51,7 @@ if (! defined('BASEPATH')) exit('No direct script access allowed');
 |   my-controller/my-method -> my_controller/my_method
 */
 $route['default_controller'] = defined('CIS4') && CIS4 ? 'Cis4' : 'Vilesci';
-$route['translate_uri_dashes'] = false;
+$route['translate_uri_dashes'] = FALSE;
 
 // Class name conflicts
 $route['api/v1/organisation/[S|s]tudiengang/(:any)'] = 'api/v1/organisation/studiengang2/$1';
@@ -71,9 +71,9 @@ $route['api/frontend/v1/stv/[sS]tudents/([WS]S[0-9]{4})'] = 'api/frontend/v1/stv
 
 // (studiensemester_kurzbz)/inout[/(incoming|outgoing|gemeinsamestudien)]
 $route['api/frontend/v1/stv/[sS]tudents/([WS]S[0-9]{4})/inout'] = 'api/frontend/v1/stv/Students/index';
-$route['api/frontend/v1/stv/[sS]tudents/([WS]S[0-9]{4})/inout/incoming'] = 'api/frontend/v1/stv/Students/getIncoming/$1';
-$route['api/frontend/v1/stv/[sS]tudents/([WS]S[0-9]{4})/inout/outgoing'] = 'api/frontend/v1/stv/Students/getOutgoing/$1';
-$route['api/frontend/v1/stv/[sS]tudents/([WS]S[0-9]{4})/inout/gemeinsamestudien'] = 'api/frontend/v1/stv/Students/getGemeinsamestudien/$1';
+$route['api/frontend/v1/stv/[sS]tudents/([WS]S[0-9]{4})/inout/incoming'] = 'api/frontend/v1/stv/Students/getIncoming';
+$route['api/frontend/v1/stv/[sS]tudents/([WS]S[0-9]{4})/inout/outgoing'] = 'api/frontend/v1/stv/Students/getOutgoing';
+$route['api/frontend/v1/stv/[sS]tudents/([WS]S[0-9]{4})/inout/gemeinsamestudien'] = 'api/frontend/v1/stv/Students/getGemeinsamestudien';
 
 // (studiengang_kz)/prestudent[/(studiensemester_kurzbz)[/(filter)[/(otherfilter)]]]
 $route['api/frontend/v1/stv/[sS]tudents/(-?[0-9]+)/prestudent'] = 'api/frontend/v1/stv/Students/getPrestudents/$1';

application/config/searchfunctions.php

@@ -29,7 +29,7 @@ $config['similar'] = [
 
 $config['vector'] = [
 	'priority' => 1,
-	'rank' => "ts_rank({field}, plainto_tsquery('simple', {word}))",
-	'compare' => "plainto_tsquery('simple', {word}) @@ {field}"
+	'rank' => "ts_rank({field}, to_tsquery('simple', {word}))",
+	'compare' => "to_tsquery('simple', {word}) @@ {field}"
 ];
 

application/config/searchstv.php

@@ -7,43 +7,5 @@ $CI =& get_instance();
 
 
 $config['student'] = $CI->config->item('student', 'search');
-$config['student']['searchfields']['pkz'] = [
-	'alias' => ['personenkennzeichen', 'personalid'],
-	'comparison' => 'equals',
-	'field' => 'matrikelnr'
-];
-$config['student']['searchfields']['matrnr'] = [
-	'alias' => ['matrikelnr', 'matrikelnummer', 'matrno', 'matriculationno', 'matriculationnumber', 'studno', 'studentno', 'studentnumber'],
-	'comparison' => 'equals',
-	'field' => 'matr_nr',
-	'join' => [
-		[
-			'table' => "public.tbl_prestudent",
-			'using' => "prestudent_id"
-		],
-		[
-			'table' => "public.tbl_person",
-			'using' => "person_id"
-		]
-	]
-];
 
 $config['prestudent'] = $CI->config->item('prestudent', 'search');
-$config['prestudent']['searchfields']['pkz'] = [
-	'alias' => ['personenkennzeichen', 'personalid'],
-	'comparison' => 'equals',
-	'field' => 'matrikelnr',
-	'join' => [
-		'table' => "public.tbl_student",
-		'using' => "prestudent_id"
-	]
-];
-$config['prestudent']['searchfields']['matrnr'] = [
-	'alias' => ['matrikelnr', 'matrikelnummer', 'matrno', 'matriculationno', 'matriculationnumber', 'studno', 'studentno', 'studentnumber'],
-	'comparison' => 'equals',
-	'field' => 'matr_nr',
-	'join' => [
-		'table' => "public.tbl_person",
-		'using' => "person_id"
-	]
-];

application/config/stv.php

@@ -61,13 +61,9 @@ $config['tabs'] =
 		'notes' => [
 			//if true, the count of Messages will be shown in the header of the Tab Messages
 			'showCountNotes' => true
-		],
-		'combinePeople' => [
-			//multitab should only be shown with this length of selection
-			'validCountMulti' => 2,
-		],
+		]
 	];
-
+	
 // List of fields to show when ZGV_DOKTOR_ANZEIGEN is defined
 $fieldsZgvDoktor = ['zgvdoktorort', 'zgvdoktordatum', 'zgvdoktornation', 'zgvdoktor_erfuellt', 'zgvdoktor_code'];
 
@@ -88,11 +84,6 @@ if (!defined('ZGV_DOKTOR_ANZEIGEN') || !ZGV_DOKTOR_ANZEIGEN) {
 	);
 }
 
-$config['tabs']['projektarbeit']['defaultProjektbetreuerStunden'] = '4.0';
-$config['tabs']['projektarbeit']['defaultProjektbetreuerStundenDiplom'] = '5.0';
-$config['tabs']['projektarbeit']['lvLektroinnenzuteilungFixangestelltStundensatz'] = true;
-$config['tabs']['projektarbeit']['defaultProjektbetreuerStundensatz'] = '80.0';
-
 $config['student_tab_order'] = [
 	'details',
 	'notes',
@@ -106,7 +97,6 @@ $config['student_tab_order'] = [
 	'grades',
 	'exam',
 	'exemptions',
-	'projektarbeit',
 	'finalexam',
 	'mobility',
 	'jointstudies',
@@ -121,6 +111,5 @@ $config['students_tab_order'] = [
 	'status',
 	'groups',
 	'finalexam',
-	'combinePeople',
 	'archive',
 ];

application/controllers/Cis/Documents.php

@@ -72,7 +72,7 @@ class Documents extends Auth_Controller
 
 		$stgs = [];
 		$stsemArray = [];
-		$buchungstypen = defined("CIS_DOKUMENTE_STUDIENBEITRAG_TYPEN") ? unserialize(CIS_DOKUMENTE_STUDIENBEITRAG_TYPEN) : [];
+		$buchungstypen = implode('\',\'', defined("CIS_DOKUMENTE_STUDIENBEITRAG_TYPEN") ? unserialize(CIS_DOKUMENTE_STUDIENBEITRAG_TYPEN) : []);
 		$person_ids = [];
 		foreach ($stati as $status) {
 			$person_ids[] = $status->person_id;

application/controllers/Cis/ProfilUpdate.php

@@ -13,7 +13,7 @@ class ProfilUpdate extends Auth_Controller
 	{
 		parent::__construct([
 			'index' => ['student/stammdaten:r', 'mitarbeiter/stammdaten:r'],
-			'show' => ['student/stammdaten:r', 'mitarbeiter/stammdaten:r', 'basis/cis:r'],
+			'show' => ['basis/cis:r'],
 			'id' => ['student/stammdaten:r', 'mitarbeiter/stammdaten:r']
 		]);
 

application/controllers/Cis/Pub.php

@@ -14,7 +14,7 @@ class Pub extends Auth_Controller
 	{
 		parent::__construct(
 		    array(
-			'bild' => ['basis/cis:r', 'assistenz:r']
+			'bild' => ['basis/cis:r']
 		    )
 		);
 	}

application/controllers/api/frontend/v1/Lehrveranstaltung.php

@@ -119,19 +119,7 @@ class Lehrveranstaltung extends FHCAPI_Controller
 			if (hasData($lehreinheiten_data))
 			{
 				$lehreinheiten = getData($lehreinheiten_data);
-
-				if (!isset($row->_children))
-				{
-					$row->_children = $lehreinheiten;
-				}
-				else
-				{
-					if (!is_array($row->_children))
-					{
-						$row->_children = [$row->_children];
-					}
-					$row->_children = array_merge($row->_children, $lehreinheiten);
-				}
+				$rowData->_children = $lehreinheiten;
 			}
 
 			if (!isEmptyString($row->studienplan_lehrveranstaltung_id_parent))

application/controllers/api/frontend/v1/ProfilUpdate.php

@@ -637,7 +637,7 @@ class ProfilUpdate extends FHCAPI_Controller
 				//? Send email to the Studiengangsassistentinnen
 				$this->StudentModel->addSelect(["public.tbl_studiengang.email"]);
 				$this->StudentModel->addJoin("public.tbl_benutzer", "public.tbl_benutzer.uid = public.tbl_student.student_uid");
-				$this->StudentModel->addJoin("public.tbl_prestudent", "public.tbl_benutzer.person_id = public.tbl_prestudent.person_id and public.tbl_student.studiengang_kz = public.tbl_prestudent.studiengang_kz");
+				$this->StudentModel->addJoin("public.tbl_prestudent", "public.tbl_benutzer.person_id = public.tbl_prestudent.person_id");
 				$this->StudentModel->addJoin("public.tbl_prestudentstatus", "public.tbl_prestudentstatus.prestudent_id = public.tbl_prestudent.prestudent_id");
 				$this->StudentModel->addJoin("public.tbl_studiengang", "public.tbl_studiengang.studiengang_kz = public.tbl_prestudent.studiengang_kz");
 				$this->StudentModel->addGroupBy(["public.tbl_studiengang.email"]);
@@ -706,13 +706,7 @@ class ProfilUpdate extends FHCAPI_Controller
 
 	private function setStatusOnUpdateRequest($id, $status, $status_message)
 	{
-		return $this->ProfilUpdateModel->update([$id], [
-			"status" => $status,
-			"status_timestamp" => "NOW()",
-			"status_message" => $status_message,
-			"updateamum" => "NOW()",
-			"updatevon" => getAuthUID()
-		]);
+		return $this->ProfilUpdateModel->update([$id], ["status" => $status, "status_timestamp" => "NOW()", "status_message" => $status_message]);
 	}
 	
 	private function updateRequestedChange($id, $requested_change)
@@ -722,12 +716,13 @@ class ProfilUpdate extends FHCAPI_Controller
 	
 	private function deleteOldVersionFile($dms_id)
 	{
-		if (!isset($dms_id)) {
-			return true;
-		}
-
 		// starting the transaction
 		$this->db->trans_start();
+		
+		
+		if (!isset($dms_id)) {
+			return;
+		}
 
 		//? delete the file from the profilUpdate first
 		$profilUpdateFileDelete = $this->ProfilUpdateModel->removeFileFromProfilUpdate($dms_id);
@@ -782,8 +777,13 @@ class ProfilUpdate extends FHCAPI_Controller
 
 		$res = $this->StudentModel->execReadOnlyQuery($query, [$student_uid]);
 		$res = $this->getDataOrTerminateWithError($res, $this->p->t('profilUpdate', 'profilUpdate_loadingOE_error'));	
-		$oe = ($res[0])->oe_kurzbz;
-		return $oe;
+		$res = array_map(
+			function ($item) {
+				return $item->oe_kurzbz;
+			},
+			$res
+		);
+		return $res;
 	}
 
 	private function handleAdresse($requested_change, $personID)
@@ -813,7 +813,7 @@ class ProfilUpdate extends FHCAPI_Controller
 			$insert_adresse_id = $insertID;
 			$insert_adresse_id = $this->getDataOrTerminateWithError($insert_adresse_id, $this->p->t('profilUpdate', 'profilUpdate_insertAdresse_error'));
 			if ($insert_adresse_id) {
-				$this->handleDupplicateZustellAdressen($requested_change['zustelladresse'], $insert_adresse_id, $personID);
+				$this->handleDupplicateZustellAdressen($requested_change['zustelladresse'], $insert_adresse_id);
 			}
 		}
 		//! DELETE
@@ -825,33 +825,12 @@ class ProfilUpdate extends FHCAPI_Controller
 		}
 		//! UPDATE
 		else {
-			$curadresse_res = $this->AdresseModel->load($adresse_id);
-			$curadresse = ($this->getDataOrTerminateWithError($curadresse_res))[0];
+			$requested_change['updateamum'] = "NOW()";
+			$requested_change['updatevon'] = getAuthUID();
+			$update_adresse_id = $this->AdresseModel->update($adresse_id, $requested_change);
+			$update_adresse_id = $this->getDataOrTerminateWithError($update_adresse_id, $this->p->t('profilUpdate', 'profilUpdate_updateAdresse_error'));
+			$this->handleDupplicateZustellAdressen($requested_change['zustelladresse'], $update_adresse_id);
 
-			if($curadresse->heimatadresse)
-			{
-				$tmpadresse = array_merge((array) $curadresse, $requested_change);
-				unset($tmpadresse["adresse_id"]);
-				$tmpadresse['insertamum'] = "NOW()";
-				$tmpadresse['insertvon'] = getAuthUID();
-				$tmpadresse['person_id'] = $personID;
-				unset($tmpadresse["heimatadresse"]);
-				unset($tmpadresse["updateamum"]);
-				unset($tmpadresse["updatevon"]);
-
-				$tmpadresse_res = $this->AdresseModel->insert($tmpadresse);
-				$tmpadresse_id = $this->getDataOrTerminateWithError($tmpadresse_res, $this->p->t('profilUpdate', 'profilUpdate_insertAdresse_error'));
-				$this->handleDupplicateZustellAdressen($requested_change['zustelladresse'], $tmpadresse_id, $personID);
-			}
-			else
-			{
-				$requested_change['updateamum'] = "NOW()";
-				$requested_change['updatevon'] = getAuthUID();
-
-				$update_adresse_id = $this->AdresseModel->update($adresse_id, $requested_change);
-				$update_adresse_id = $this->getDataOrTerminateWithError($update_adresse_id, $this->p->t('profilUpdate', 'profilUpdate_updateAdresse_error'));
-				$this->handleDupplicateZustellAdressen($requested_change['zustelladresse'], $update_adresse_id, $personID);
-			}
 		}
 		return $insertID ?? null;
 	}
@@ -873,7 +852,7 @@ class ProfilUpdate extends FHCAPI_Controller
 			$insert_kontakt_id = $insertID;
 			$insert_kontakt_id = $this->getDataOrTerminateWithError($insert_kontakt_id, $this->p->t('profilUpdate', 'profilUpdate_insertKontakt_error'));
 			if ($insert_kontakt_id) {
-				$this->handleDupplicateZustellKontakte($requested_change['zustellung'], $insert_kontakt_id, $requested_change['kontakttyp'], $personID);
+				$this->handleDupplicateZustellKontakte($requested_change['zustellung'], $insert_kontakt_id);
 			}
 		}
 		//! DELETE
@@ -890,18 +869,18 @@ class ProfilUpdate extends FHCAPI_Controller
 			$update_kontakt_id = $this->KontaktModel->update($kontakt_id, $requested_change);
 			$update_kontakt_id = $this->getDataOrTerminateWithError($update_kontakt_id, $this->p->t('profilUpdate', 'profilUpdate_updateKontakt_error'));
 			if ($update_kontakt_id) {
-				$this->handleDupplicateZustellKontakte($requested_change['zustellung'], $update_kontakt_id, $requested_change['kontakttyp'], $personID);
+				$this->handleDupplicateZustellKontakte($requested_change['zustellung'], $update_kontakt_id);
 			}
 		}
 		return isset($insertID) ? $insertID : null;
 	}
 
-	private function handleDupplicateZustellAdressen($zustellung, $adresse_id, $person_id)
+	private function handleDupplicateZustellAdressen($zustellung, $adresse_id)
 	{
 		if ($zustellung) {
 			$this->PersonModel->addSelect("public.tbl_adresse.adresse_id");
 			$this->PersonModel->addJoin("public.tbl_adresse", "public.tbl_adresse.person_id = public.tbl_person.person_id");
-			$zustellAdressenArray = $this->PersonModel->loadWhere(["public.tbl_person.person_id" => $person_id, "zustelladresse" => TRUE]);
+			$zustellAdressenArray = $this->PersonModel->loadWhere(["public.tbl_person.person_id" => $this->pid, "zustelladresse" => TRUE]);
 			if (isError($zustellAdressenArray)) {
 				$this->terminateWithError($this->p->t('profilUpdate', 'profilUpdate_loadingZustellAdressen_error'));
 			}
@@ -914,8 +893,6 @@ class ProfilUpdate extends FHCAPI_Controller
 					return $adresse->adresse_id != $adresse_id;
 				});
 	
-				$this->addMeta('bhzustelladressen', $zustellAdressenArray);
-
 				// remove the zustelladresse from all other zustelladressen
 				foreach ($zustellAdressenArray as $adresse) {
 					$this->AdresseModel->update($adresse->adresse_id, ["zustelladresse" => FALSE]);
@@ -925,16 +902,12 @@ class ProfilUpdate extends FHCAPI_Controller
 		}
 	}
 
-	private function handleDupplicateZustellKontakte($zustellung, $kontakt_id, $kontakttyp, $person_id)
+	private function handleDupplicateZustellKontakte($zustellung, $kontakt_id)
 	{
 		if ($zustellung) {
 			$this->PersonModel->addSelect("public.tbl_kontakt.kontakt_id");
 			$this->PersonModel->addJoin("public.tbl_kontakt", "public.tbl_kontakt.person_id = public.tbl_person.person_id");
-			$zustellKontakteArray = $this->PersonModel->loadWhere([
-				"public.tbl_person.person_id" => $person_id,
-				"zustellung" => TRUE,
-				"kontakttyp" => $kontakttyp
-			]);
+			$zustellKontakteArray = $this->PersonModel->loadWhere(["public.tbl_person.person_id" => $this->pid, "zustellung" => TRUE]);
 			if (!isSuccess($zustellKontakteArray)) {
 				return error($this->p->t('profilUpdate', 'profilUpdate_loadingZustellkontakte_error'));
 			}

application/controllers/api/frontend/v1/lv/Gruppe.php

@@ -12,8 +12,8 @@ class Gruppe extends FHCAPI_Controller
 			'add' => ['admin:rw', 'assistenz:rw'],
 			'delete' => ['admin:rw', 'assistenz:rw'],
 			'deleteFromLVPlan' => ['admin:rw', 'assistenz:rw'],
-			'getBenutzerSearch' => ['admin:r', 'assistenz:r'],
-			'getAllSearch' => ['admin:r', 'assistenz:r'],
+			'getBenutzer' => ['admin:r', 'assistenz:r'],
+			'getAll' => ['admin:r', 'assistenz:r'],
 			'getByLehreinheit' => ['admin:r', 'assistenz:r'],
 		]);
 
@@ -22,8 +22,7 @@ class Gruppe extends FHCAPI_Controller
 		$this->_ci->load->library('PhrasesLib');
 		$this->loadPhrases(
 			array(
-				'ui',
-				'lehre'
+				'ui'
 			)
 		);
 
@@ -92,11 +91,11 @@ class Gruppe extends FHCAPI_Controller
 		$lehreinheitgruppe_id = $this->input->post('lehreinheitgruppe_id');
 
 		if (is_null($lehreinheit_id) || !ctype_digit((string)$lehreinheit_id) || is_null($lehreinheitgruppe_id) || !ctype_digit((string)$lehreinheitgruppe_id))
-			$this->terminateWithError($this->p->t('ui', 'ungueltigeParameter'), self::ERROR_TYPE_GENERAL);
+			$this->terminateWithError( $this->p->t('ui', 'ungueltigeParameter'), self::ERROR_TYPE_GENERAL);
 
 		$lehreinheitgruppe_result = $this->_ci->LehreinheitgruppeModel->loadWhere(array('lehreinheitgruppe_id' => $lehreinheitgruppe_id));
 		if (!hasData($lehreinheitgruppe_result) || isError($lehreinheitgruppe_result))
-			$this->terminateWithError($this->p->t('ui', 'ungueltigeParameter'), self::ERROR_TYPE_GENERAL);
+			$this->terminateWithError( $this->p->t('ui', 'ungueltigeParameter'), self::ERROR_TYPE_GENERAL);
 
 		$this->checkPermission($lehreinheit_id);
 
@@ -109,33 +108,15 @@ class Gruppe extends FHCAPI_Controller
 	}
 
 
-	public function getAllSearch()
+	public function getAll()
 	{
-		$query = $this->input->get('query');
-
-		if (is_null($query))
-			$this->terminateWithError($this->p->t('ui', 'ungueltigeParameter'), self::ERROR_TYPE_GENERAL);
-
-		$query_words = explode(' ', $query);
-
 		$this->_ci->GruppeModel->addSelect('gruppe_kurzbz,
 											studiengang_kz,
 											semester,
 											bezeichnung,
 											gid,
 											\'false\' as lehrverband');
-		$this->_ci->GruppeModel->db->where(array('sichtbar' => true, 'aktiv' => true, 'lehre' => true, 'direktinskription' => false, 'semester IS NOT NULL' => null));
-		$this->_ci->GruppeModel->db->group_start();
-		foreach ($query_words as $word)
-		{
-			$this->_ci->GruppeModel->db->group_start();
-			$this->_ci->GruppeModel->db->where('gruppe_kurzbz ILIKE', "%" . $word . "%");
-			$this->_ci->GruppeModel->db->or_where('bezeichnung ILIKE', "%" . $word . "%");
-			$this->_ci->GruppeModel->db->group_end();
-		}
-		$this->_ci->GruppeModel->db->group_end();
-
-		$gruppen_result = $this->_ci->GruppeModel->load();
+		$gruppen_result = $this->_ci->GruppeModel->loadWhere(array('sichtbar' => true, 'aktiv' => true, 'lehre' => true, 'direktinskription' => false, 'semester IS NOT NULL' => null));
 
 		$gruppen_array = array();
 
@@ -154,18 +135,7 @@ class Gruppe extends FHCAPI_Controller
 		$this->_ci->LehrverbandModel->addJoin('public.tbl_studiengang', 'studiengang_kz');
 		$this->_ci->LehrverbandModel->addOrder('verband');
 		$this->_ci->LehrverbandModel->addOrder('gruppe');
-		$this->_ci->LehrverbandModel->db->where(array('tbl_lehrverband.aktiv' => true));
-
-		$this->_ci->LehrverbandModel->db->group_start();
-		foreach ($query_words as $word)
-		{
-			$this->_ci->LehrverbandModel->db->group_start();
-			$this->_ci->LehrverbandModel->db->where('CONCAT(CONCAT(typ, kurzbz), \'\', semester, verband, COALESCE(gruppe,\'\')) ILIKE', "%" . $word . "%");
-			$this->_ci->LehrverbandModel->db->or_where('tbl_lehrverband.bezeichnung ILIKE', "%" . $word . "%");
-			$this->_ci->LehrverbandModel->db->group_end();
-		}
-		$this->_ci->LehrverbandModel->db->group_end();
-		$lehrverband_result = $this->_ci->LehrverbandModel->load();
+		$lehrverband_result = $this->_ci->LehrverbandModel->loadWhere(array('tbl_lehrverband.aktiv' => true));
 
 		$lehrverband_array = array();
 
@@ -180,40 +150,15 @@ class Gruppe extends FHCAPI_Controller
 		$this->terminateWithSuccess($all_gruppen);
 	}
 
-	public function getBenutzerSearch()
+	public function getBenutzer()
 	{
-		$query = $this->input->get('query');
-
-		if (is_null($query))
-			$this->terminateWithError($this->p->t('ui', 'ungueltigeParameter'), self::ERROR_TYPE_GENERAL);
-
-		$query_words = explode(' ', $query);
-
 		$this->_ci->PersonModel->addSelect('vorname, nachname, uid, semester, UPPER(CONCAT(tbl_studiengang.typ, tbl_studiengang.kurzbz)) as studiengang');
 		$this->_ci->PersonModel->addJoin('public.tbl_benutzer', 'person_id');
 		$this->_ci->PersonModel->addJoin('public.tbl_mitarbeiter', 'uid = mitarbeiter_uid', 'LEFT');
 		$this->_ci->PersonModel->addJoin('public.tbl_student', 'uid = student_uid', 'LEFT');
 		$this->_ci->PersonModel->addJoin('public.tbl_studiengang', 'studiengang_kz', 'LEFT');
 
-		$this->_ci->PersonModel->db->where(array('tbl_benutzer.aktiv' => true));
-
-		$this->_ci->PersonModel->db->group_start();
-		foreach ($query_words as $word)
-		{
-			$this->_ci->PersonModel->db->group_start();
-			$this->_ci->PersonModel->db->where('tbl_person.vorname ILIKE', "%" . $word . "%");
-			$this->_ci->PersonModel->db->or_where('tbl_person.nachname ILIKE', "%" . $word . "%");
-			$this->_ci->PersonModel->db->or_where('uid ILIKE', "%" . $word . "%");
-			$this->_ci->PersonModel->db->or_where('CONCAT(tbl_studiengang.typ, tbl_studiengang.kurzbz) ILIKE', "%" . $word . "%");
-
-			if (is_numeric($word))
-			{
-				$this->_ci->PersonModel->db->or_where('semester', $word);
-			}
-			$this->_ci->PersonModel->db->group_end();
-		}
-		$this->_ci->PersonModel->db->group_end();
-		$personen = $this->_ci->PersonModel->load();
+		$personen = $this->_ci->PersonModel->loadWhere(array('tbl_benutzer.aktiv' => true));
 		$this->terminateWithSuccess(hasData($personen) ? getData($personen) : array());
 	}
 

application/controllers/api/frontend/v1/lv/Lehreinheit.php

@@ -169,10 +169,6 @@ class Lehreinheit extends FHCAPI_Controller
 		{
 			$value = $this->input->post($field);
 
-			if ($field === 'lehre')
-			{
-				$value = (bool)$value;
-			}
 			if ($value !== null)
 			{
 				$updateData[$field] = $value;
@@ -285,43 +281,15 @@ class Lehreinheit extends FHCAPI_Controller
 	public function delete()
 	{
 		$lehreinheit_id = $this->input->post('lehreinheit_id');
+		$lehreinheit = $this->checkLehreinheit($lehreinheit_id);
+		$this->checkPermission($lehreinheit->lehreinheit_id);
 
-		$errors = array();
-		if (is_array($lehreinheit_id))
-		{
-			foreach ($lehreinheit_id as $le_id)
-			{
-				$lehreinheit = $this->checkLehreinheit($le_id);
-				$this->checkPermission($lehreinheit->lehreinheit_id);
+		$result = $this->_ci->LehreinheitModel->deleteLehreinheit($lehreinheit->lehreinheit_id);
 
-				$result = $this->_ci->LehreinheitModel->deleteLehreinheit($lehreinheit->lehreinheit_id);
+		if (isError($result))
+			$this->terminateWithValidationErrors(getError($result));
 
-				if (isError($result))
-				{
-					$errors[] = getError($result);
-				}
-			}
-		}
-		else
-		{
-			$lehreinheit = $this->checkLehreinheit($lehreinheit_id);
-			$this->checkPermission($lehreinheit->lehreinheit_id);
-
-			$result = $this->_ci->LehreinheitModel->deleteLehreinheit($lehreinheit->lehreinheit_id);
-
-			if (isError($result))
-				$this->terminateWithError(getError($result));
-		}
-
-		if (!isEmptyArray($errors))
-		{
-			if (count($errors) !== count($lehreinheit_id))
-				$this->terminateWithSuccess(array('errors' => $errors));
-			else
-				$this->terminateWithError($errors);
-		}
-		else
-			$this->terminateWithSuccess('Erfolgreich geloescht');
+		$this->terminateWithSuccess('Erfolgreich geloescht');
 	}
 
 	public function update()

application/controllers/api/frontend/v1/lv/Lektor.php

@@ -15,7 +15,7 @@ class Lektor extends FHCAPI_Controller
 			'deleteLVPlan' => ['admin:rw', 'assistenz:rw'],
 			'deletePerson' => ['admin:rw', 'assistenz:rw'],
 			'getLehrfunktionen' => ['admin:r', 'assistenz:r'],
-			'getLektorenSearch' => ['admin:r', 'assistenz:r'],
+			'getLektoren' => ['admin:r', 'assistenz:r'],
 			'getLektorenByLE' => ['admin:r', 'assistenz:r'],
 			'getLektorDaten' => ['admin:r', 'assistenz:r'],
 			'getLektorVertrag' => ['admin:r', 'assistenz:r'],
@@ -208,35 +208,12 @@ class Lektor extends FHCAPI_Controller
 		$this->terminateWithSuccess(getData($this->_ci->LehrfunktionModel->load()));
 	}
 
-	public function getLektorenSearch()
+	public function getLektoren()
 	{
-		$query = $this->input->get('query');
-
-		if (is_null($query))
-			$this->terminateWithError($this->p->t('ui', 'ungueltigeParameter'), self::ERROR_TYPE_GENERAL);
-
-		$query_words = explode(' ', $query);
-
 		$this->_ci->MitarbeiterModel->addSelect('uid, person_id, vorname, nachname');
 		$this->_ci->MitarbeiterModel->addJoin('public.tbl_benutzer', 'uid = mitarbeiter_uid');
 		$this->_ci->MitarbeiterModel->addJoin('public.tbl_person', 'person_id');
-
-		$this->_ci->MitarbeiterModel->db->where('public.tbl_benutzer.aktiv', true);
-
-		$this->_ci->MitarbeiterModel->db->group_start();
-		foreach ($query_words as $word)
-		{
-			$this->_ci->MitarbeiterModel->db->group_start();
-			$this->_ci->MitarbeiterModel->db->where('tbl_person.vorname ILIKE', "%" . $word . "%");
-			$this->_ci->MitarbeiterModel->db->or_where('tbl_person.nachname ILIKE', "%" . $word . "%");
-			$this->_ci->MitarbeiterModel->db->or_where('uid ILIKE', "%" . $word . "%");
-			$this->_ci->MitarbeiterModel->db->group_end();
-		}
-		$this->_ci->MitarbeiterModel->db->group_end();
-		$this->_ci->MitarbeiterModel->addOrder('nachname');
-		$this->_ci->MitarbeiterModel->addOrder('vorname');
-		$result = $this->_ci->MitarbeiterModel->load();
-		$this->terminateWithSuccess(hasData($result) ? getData($result) : array());
+		$this->terminateWithSuccess(getData($this->_ci->MitarbeiterModel->loadWhere(array('public.tbl_benutzer.aktiv' => true))));
 	}
 
 	private function checkLehreinheit($lehreinheit_id)

application/controllers/api/frontend/v1/lv/Tags.php

@@ -5,7 +5,7 @@ if (!defined('BASEPATH'))
 
 class Tags extends Tag_Controller
 {
-	const BERECHTIGUNG_KURZBZ = ['admin:rw', 'assistenz:r'];
+	const BERECHTIGUNG_KURZBZ = ['admin:rw', 'assistenz:rw'];
 
 	public function __construct()
 	{

application/controllers/api/frontend/v1/messages/Messages.php

@@ -16,13 +16,11 @@ class Messages extends FHCAPI_Controller
 			'getNameOfDefaultRecipient' => ['admin:r', 'assistenz:r'],
 			'sendMessage' => ['admin:r', 'assistenz:r'],
 			'deleteMessage' => ['admin:r', 'assistenz:r'],
-			'getDataVorlage' => ['admin:r', 'assistenz:r'],
+			'getVorlagentext' => ['admin:r', 'assistenz:r'],
 			'getPreviewText' => ['admin:r', 'assistenz:r'],
 			'getReplyData' => ['admin:r', 'assistenz:r'],
 			'getPersonId' => ['admin:r', 'assistenz:r'],
 			'getUid' => ['admin:r', 'assistenz:r'],
-			'getStudiengang' => ['admin:r', 'assistenz:r'],
-
 		]);
 
 		//Load Models
@@ -54,14 +52,11 @@ class Messages extends FHCAPI_Controller
 
 		$result = $this->MessageModel->getMessagesForTable($id, $offset, $limit);
 
-		if (hasData($result))
-		{
-			$data = getData($result);
-			$this->addMeta('count', $data['count']);
-			$this->terminateWithSuccess($data['data']);
-		}
+		$data = $this->getDataOrTerminateWithError($result);
 
-		$this->terminateWithSuccess(array());
+		$this->addMeta('count', $data['count']);
+
+		$this->terminateWithSuccess($data['data']);
 	}
 
 	public function getVorlagen()
@@ -71,32 +66,50 @@ class Messages extends FHCAPI_Controller
 		$this->load->model('person/Benutzerfunktion_model', 'BenutzerfunktionModel');
 		$result = $this->BenutzerfunktionModel->getBenutzerfunktionByUid($uid, 'oezuordnung');
 
-		if (hasData($result))
-		{
-			$this->load->model('system/Vorlage_model', 'VorlageModel');
+		$data = $this->getDataOrTerminateWithError($result);
+		$oe_kurzbz = current($data);
 
-			$data = getData($result);
+		$this->load->model('system/Vorlage_model', 'VorlageModel');
 
-			$oe_kurzbz = array_column($data, 'oe_kurzbz');
-			$result = $this->VorlageModel->getAllVorlagenByOe($oe_kurzbz);
+		$result = $this->VorlageModel->getAllVorlagenByOe($oe_kurzbz->oe_kurzbz);
+		$data = $this->getDataOrTerminateWithError($result);
 
-			$this->terminateWithSuccess(hasData($result) ? getData($result) : array());
-		}
+		$this->terminateWithSuccess($data);
 
-		$this->terminateWithSuccess(array());
-	}
+		//If admin
+		$this->VorlageModel->addOrder('vorlage_kurzbz', 'ASC');
+		$result = $this->VorlageModel->loadWhere(
+			array(
+				'mimetype' => 'text/html'
+			));
 
-	public function getDataVorlage($vorlage_kurzbz, $studiengang_kz)
-	{
-		if(!$studiengang_kz)
-			$this->terminateWithSuccess(null);
-
-		$this->load->model('system/Vorlagestudiengang_model', 'VorlagestudiengangModel');
-
-		$result = $this->VorlagestudiengangModel->getCurrent($vorlage_kurzbz, $studiengang_kz);
 
 		$data = $this->getDataOrTerminateWithError($result);
-		$this->terminateWithSuccess(current($data));
+
+		$this->terminateWithSuccess($data);
+	}
+
+	public function getVorlagentext($vorlage_kurzbz)
+	{
+		//$this->terminateWithError("vor " . $vorlage_kurzbz, self::ERROR_TYPE_GENERAL);
+		//$studiengang_kz = 227; //TODO(Manu) dynamisieren NULL
+		$studiengang_kz = 0;
+		$this->load->model('system/Vorlagestudiengang_model', 'VorlagestudiengangModel');
+		$this->VorlagestudiengangModel->addOrder('version', 'DESC');
+
+		$result = $this->VorlagestudiengangModel->loadWhere(
+			[
+				'vorlage_kurzbz' =>$vorlage_kurzbz,
+				'studiengang_kz' => $studiengang_kz
+			]);
+
+		$data = $this->getDataOrTerminateWithError($result);
+
+		//not correct with Vorlage
+		$vorlage = current($data);
+
+		//$this->terminateWithSuccess($data);
+		$this->terminateWithSuccess($vorlage->text);
 	}
 
 	public function getMessageVarsPerson($id, $typeId)
@@ -141,6 +154,8 @@ class Messages extends FHCAPI_Controller
 	public function sendMessage($recipient_id)
 	{
 		//has to be uid
+	//	$this->terminateWithError("uid", $recipient_id, self::ERROR_TYPE_GENERAL);
+
 		//default setting
 		$receiversPersonId = $this->_getPersonId($recipient_id, 'uid');
 
@@ -208,6 +223,8 @@ class Messages extends FHCAPI_Controller
 		}
 		elseif($typeId == 'prestudent_id')
 		{
+		//	$this->terminateWithError("prestudent_id ", self::ERROR_TYPE_GENERAL);
+
 			$result = $this->MessagesModel->parseMessageTextPrestudent($id, $body);
 			$bodyParsed = $this->getDataOrTerminateWithError($result);
 		}
@@ -383,21 +400,6 @@ class Messages extends FHCAPI_Controller
 		$this->terminateWithSuccess($benutzer->uid);
 	}
 
-	public function getStudiengang($id, $typeId)
-	{
-		if($typeId!= "prestudent_id" && $typeId!="uid" )
-			$this->terminateWithSuccess(null);
-
-		$prestudent_id = ($typeId == 'uid') ? $this->_getPrestudentIdFromUid($id) : $id;
-
-		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
-		$result = $this->PrestudentModel->load($prestudent_id);
-		$data = $this->getDataOrTerminateWithError($result);
-		$studiengang_kz = current($data)->studiengang_kz;
-
-		return $this->terminateWithSuccess($studiengang_kz);
-	}
-
 	private function _getPersonId($id, $typeId)
 	{
 		if ($typeId == 'uid' || $typeId == 'mitarbeiter_uid')
@@ -427,6 +429,7 @@ class Messages extends FHCAPI_Controller
 
 	private function _getPrestudentIdFromUid($uid)
 	{
+	//	$this->terminateWithError($uid, self::ERROR_TYPE_GENERAL);
 		$this->load->model('crm/Student_model', 'StudentModel');
 		$result = $this->StudentModel->loadWhere(
 			['student_uid' => $uid]
@@ -460,4 +463,4 @@ class Messages extends FHCAPI_Controller
 			date_format(date_create($sentDate), 'd.m.Y H:i'), $receiverName, $receiverSurname, $body
 		);
 	}
-}
+}

application/controllers/api/frontend/v1/stv/Abschlusspruefung.php

@@ -20,6 +20,8 @@ class Abschlusspruefung extends FHCAPI_Controller
 			'getBeurteilungen' => ['admin:rw', 'assistenz:rw'],
 			'getAkadGrade' => ['admin:rw', 'assistenz:rw'],
 			'getMitarbeiter' => ['admin:rw', 'assistenz:rw'],
+			'getAllMitarbeiter' => ['admin:rw', 'assistenz:rw'],
+			'getAllPersons' => ['admin:rw', 'assistenz:rw'],
 			'getPruefer' => ['admin:rw', 'assistenz:rw'],
 			'getTypStudiengang' => ['admin:rw', 'assistenz:rw'],
 			'checkForExistingExams' => ['admin:rw', 'assistenz:rw'],
@@ -100,45 +102,35 @@ class Abschlusspruefung extends FHCAPI_Controller
 	{
 		$abschlusspruefung_id = $this->input->post('id');
 
-		$this->AbschlusspruefungModel->addSelect(
-			'lehre.tbl_abschlusspruefung.*,
-			p1.person_id AS p1_person_id, p1.vorname AS p1_vorname, p1.nachname AS p1_nachname,
-			p1.titelpre AS p1_titelpre, p1.titelpost AS p1_titelpost,
-			p2.person_id AS p2_person_id, p2.vorname AS p2_vorname, p2.nachname AS p2_nachname,
-			p2.titelpre AS p2_titelpre, p2.titelpost AS p2_titelpost,
-			p3.person_id AS p3_person_id, p3.vorname AS p3_vorname, p3.nachname AS p3_nachname,
-			p3.titelpre AS p3_titelpre, p3.titelpost AS p3_titelpost,
-			pv.person_id AS pv_person_id, pv.vorname AS pv_vorname, pv.nachname AS pv_nachname,
-			pv.titelpre AS pv_titelpre, pv.titelpost AS pv_titelpost, ben.uid AS pv_uid'
-		);
-		//~ $this->AbschlusspruefungModel->addSelect("
-			//~ CASE
-				//~ WHEN pruefer1 IS NOT NULL
-				//~ THEN CONCAT(p1.nachname, ' ', p1.vorname, COALESCE(' ' || p1.titelpre, ''))
-				//~ ELSE NULL
-   			 //~ END AS p1
-   		//~ ");
-		//~ $this->AbschlusspruefungModel->addSelect("
-			//~ CASE
-				//~ WHEN pruefer2 IS NOT NULL
-				//~ THEN CONCAT(p2.nachname, ' ', p2.vorname, COALESCE(' ' || p2.titelpre, ''))
-				//~ ELSE NULL
-   			 //~ END AS p2
-		//~ ");
-		//~ $this->AbschlusspruefungModel->addSelect("
-			//~ CASE
-				//~ WHEN pruefer3 IS NOT NULL
-				//~ THEN CONCAT(p3.nachname, ' ', p3.vorname, COALESCE(' ' || p3.titelpre, ''))
-				//~ ELSE NULL
-   			 //~ END AS p3
-		//~ ");
-		//~ $this->AbschlusspruefungModel->addSelect("
-			//~ CASE
-				//~ WHEN vorsitz IS NOT NULL
-				//~ THEN CONCAT(pv.nachname, ' ', pv.vorname, COALESCE(' ' || pv.titelpre, ''), ' (', ben.uid , ')' )
-				//~ ELSE NULL
-   			 //~ END AS pv
-		//~ ");
+		$this->AbschlusspruefungModel->addSelect('lehre.tbl_abschlusspruefung.*');
+		$this->AbschlusspruefungModel->addSelect("
+			CASE
+				WHEN pruefer1 IS NOT NULL
+				THEN CONCAT(p1.nachname, ' ', p1.vorname, COALESCE(' ' || p1.titelpre, ''))
+				ELSE NULL
+   			 END AS p1
+   		");
+		$this->AbschlusspruefungModel->addSelect("
+			CASE
+				WHEN pruefer2 IS NOT NULL
+				THEN CONCAT(p2.nachname, ' ', p2.vorname, COALESCE(' ' || p2.titelpre, ''))
+				ELSE NULL
+   			 END AS p2
+		");
+		$this->AbschlusspruefungModel->addSelect("
+			CASE
+				WHEN pruefer3 IS NOT NULL
+				THEN CONCAT(p3.nachname, ' ', p3.vorname, COALESCE(' ' || p3.titelpre, ''))
+				ELSE NULL
+   			 END AS p3
+		");
+		$this->AbschlusspruefungModel->addSelect("
+			CASE
+				WHEN vorsitz IS NOT NULL
+				THEN CONCAT(pv.nachname, ' ', pv.vorname, COALESCE(' ' || pv.titelpre, ''), ' (', ben.uid , ')' )
+				ELSE NULL
+   			 END AS pv
+		");
 		$this->AbschlusspruefungModel->addJoin('public.tbl_benutzer ben', 'ON (ben.uid = lehre.tbl_abschlusspruefung.vorsitz)', 'LEFT');
 		$this->AbschlusspruefungModel->addJoin('public.tbl_person pv', 'ON (pv.person_id = ben.person_id)', 'LEFT');
 		$this->AbschlusspruefungModel->addJoin('public.tbl_person p1', 'ON (p1.person_id = lehre.tbl_abschlusspruefung.pruefer1)', 'LEFT');
@@ -228,10 +220,8 @@ class Abschlusspruefung extends FHCAPI_Controller
 		$this->terminateWithSuccess($typStudiengang);
 	}
 
-	public function getMitarbeiter()
+	public function getMitarbeiter($searchString)
 	{
-		$searchString = $this->input->get('searchString') ?? '';
-
 		$this->load->model('ressource/Mitarbeiter_model', 'MitarbeiterModel');
 
 		$result = $this->MitarbeiterModel->searchMitarbeiter($searchString, 'mitAkadGrad');
@@ -242,10 +232,8 @@ class Abschlusspruefung extends FHCAPI_Controller
 		$this->terminateWithSuccess($result ?: []);
 	}
 
-	public function getPruefer()
+	public function getPruefer($searchString)
 	{
-		$searchString = $this->input->get('searchString') ?? '';
-
 		$this->load->model('ressource/Mitarbeiter_model', 'MitarbeiterModel');
 
 		$result = $this->MitarbeiterModel->searchMitarbeiter($searchString, 'ohneMaUid');
@@ -456,4 +444,58 @@ class Abschlusspruefung extends FHCAPI_Controller
 		}
 		$this->terminateWithSuccess('step3');
 	}
+
+	/*
+	* returns list of all Mitarbeiter
+	* as key value list to be used in select or autocomplete
+	*/
+	public function getAllMitarbeiter()
+	{
+		$this->load->model('ressource/Mitarbeiter_model', 'MitarbeiterModel');
+
+		$sql = "
+			SELECT
+			    ma.mitarbeiter_uid as mitarbeiter_uid,
+				CONCAT(p.nachname, ' ', p.vorname, ' (', ma.mitarbeiter_uid, ')') as label
+			FROM
+			  public.tbl_mitarbeiter ma
+			  JOIN public.tbl_benutzer bn ON (bn.uid = ma.mitarbeiter_uid)
+			  JOIN public.tbl_person p ON (p.person_id = bn.person_id)
+			ORDER BY
+			p.nachname ASC
+			";
+
+		$result = $this->MitarbeiterModel->execReadOnlyQuery($sql);
+		$data = $this->getDataOrTerminateWithError($result);
+
+		$this->terminateWithSuccess($data);
+	}
+
+	/*
+	* returns list of all Persons
+	* as key value list to be used in select or autocomplete
+	*/
+	public function getAllPersons()
+	{
+		$this->load->model('person/Person_model', 'PersonModel');
+
+		$sql = "
+			SELECT
+			    p.vorname, p.nachname, p.person_id,
+				CONCAT(p.nachname, ' ', p.vorname) as label
+			FROM
+			  public.tbl_person p
+			 -- JOIN public.tbl_benutzer bn ON (p.person_id = bn.person_id)
+			  -- and bn.aktiv = 'true'
+			ORDER BY
+			p.nachname ASC
+			";
+
+		//TODO(manu) check if filter active benutzer
+
+		$result = $this->PersonModel->execReadOnlyQuery($sql);
+		$data = $this->getDataOrTerminateWithError($result);
+
+		$this->terminateWithSuccess($data);
+	}
 }

application/controllers/api/frontend/v1/stv/Archiv.php

@@ -39,7 +39,7 @@ class Archiv extends FHCAPI_Controller
 			'archive' => ['admin:w', 'assistenz:w'],
 			'download' => ['admin:w', 'assistenz:w'],
 			'update' => ['admin:w'],
-			'delete' => ['admin:w', 'assistenz:w'],
+			'delete' => ['admin:w', 'assistenz:w']
 		]);
 
 		// Load models
@@ -107,9 +107,13 @@ class Archiv extends FHCAPI_Controller
 
 		$result = $this->AkteModel->load($akte_id);
 
+
 		if (!hasData($result)) $this->terminateWithError('Akte not found');
 
+		$data = $this->getDataOrTerminateWithError($result);
+
 		$data = getData($result)[0];
+		//$this->addMeta("daa", $data->inhalt);
 
 		$fileObj = new stdClass();
 		if (isset($data->inhalt) && $data->inhalt != '')
@@ -129,7 +133,12 @@ class Archiv extends FHCAPI_Controller
 			//header("Content-type: $data->mimetype");
 			header('Content-Disposition: attachment; filename="'.$data->titel.'"');
 			readfile($filename);
+			//echo base64_decode($data->inhalt);
 			die();
+			//~ $fileObj->file = $data->inhalt;
+			//~ $fileObj->name = $data->titel;
+			//~ $fileObj->mimetype = $data->mimetype;
+			//~ $fileObj->disposition = 'attachment';
 		}
 		else
 		{
@@ -137,6 +146,12 @@ class Archiv extends FHCAPI_Controller
 
 			$result = $this->aktelib->get($akte_id);
 		}
+
+	/*	$fileObj->filename
+	 * 	$fileObj->file
+	 * 	$fileObj->name
+	 * 	$fileObj->mimetype
+	 * 	$fileObj->disposition*/
 	}
 
 	/**

application/controllers/api/frontend/v1/stv/Aufnahmetermine.php

@@ -298,7 +298,7 @@ class Aufnahmetermine extends FHCAPI_Controller
 		$reihungstestangetreten =
 			(isset($formData['reihungstestangetreten']) && !empty($formData['reihungstestangetreten']))
 				? $formData['reihungstestangetreten']
-				: false;
+				: null;
 		$aufnahmegruppe_kurzbz =
 			(isset($formData['aufnahmegruppe_kurzbz']) && !empty($formData['aufnahmegruppe_kurzbz']))
 				? $formData['aufnahmegruppe_kurzbz']

application/controllers/api/frontend/v1/stv/Config.php

@@ -33,9 +33,6 @@ class Config extends FHCAPI_Controller
 	{
 		// TODO(chris): permissions
 		parent::__construct([
-			'get' => ['admin:r', 'assistenz:r'],
-			'set' => ['admin:r', 'assistenz:r'],
-			'filter' => ['admin:r', 'assistenz:r'],
 			'student' => ['admin:r', 'assistenz:r'],
 			'students' => ['admin:r', 'assistenz:r']
 		]);
@@ -48,255 +45,13 @@ class Config extends FHCAPI_Controller
 			'lehre',
 			'stv',
 			'konto',
-			'abschlusspruefung',
-			'projektarbeit'
+			'abschlusspruefung'
 		]);
 
 		// Load Config
 		$this->load->config('stv');
 	}
 
-	/**
-	 * get App config
-	 */
-	public function get()
-	{
-		$this->load->model('system/Variable_model', 'VariableModel');
-		$this->load->config('stv');
-
-		$config = [];
-
-		#number_displayed_past_studiensemester
-		$result = $this->VariableModel->getVariables(getAuthUID(), ['number_displayed_past_studiensemester']);
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$number_displayed_past_studiensemester_default = $this->config->item('number_displayed_past_studiensemester_default');
-
-		$config['number_displayed_past_studiensemester'] = [
-			"type" => "number",
-			"label" => $this->p->t('stv', 'settings_no_displayed_past_sem'),
-			"value" => $data['number_displayed_past_studiensemester']
-				?? $number_displayed_past_studiensemester_default
-		];
-
-		#font_size
-		$result = $this->VariableModel->getVariables(getAuthUID(), ['stv_font_size']);
-		$data = $this->getDataOrTerminateWithError($result);
-		$config['font_size'] = [
-			"type" => "select",
-			"label" => $this->p->t('stv', 'settings_fontsize'),
-			"value" => $data['stv_font_size'] ?? "fs_normal",
-			"options" => [
-				"fs_xx-small" => $this->p->t('stv', 'settings_fontsize_xx-small'),
-				"fs_x-small" => $this->p->t('stv', 'settings_fontsize_x-small'),
-				"fs_small" => $this->p->t('stv', 'settings_fontsize_small'),
-				"fs_normal" => $this->p->t('stv', 'settings_fontsize_normal'),
-				"fs_big" => $this->p->t('stv', 'settings_fontsize_big'),
-				"fs_huge" => $this->p->t('stv', 'settings_fontsize_huge')
-			]
-		];
-
-		#others
-		Events::trigger('stv_config_get', function & () use (&$config) {
-			return $config;
-		});
-
-		$this->terminateWithSuccess($config);
-	}
-
-	/**
-	 * set App config
-	 */
-	public function set()
-	{
-		$this->load->model('system/Variable_model', 'VariableModel');
-		$this->load->library('form_validation');
-
-		$this->form_validation->set_rules(
-			'number_displayed_past_studiensemester',
-			$this->p->t('stv', 'settings_no_displayed_past_sem'),
-			'required|integer'
-		);
-		$this->form_validation->set_rules(
-			'font_size',
-			$this->p->t('stv', 'settings_fontsize'),
-			'required|in_list[fs_xx-small,fs_x-small,fs_small,fs_normal,fs_big,fs_huge]'
-		);
-
-		Events::trigger('stv_config_validation', $this->form_validation);
-
-		if (!$this->form_validation->run())
-			$this->terminateWithValidationErrors($this->form_validation->error_array());
-
-
-		$this->VariableModel->setVariable(
-			getAuthUID(),
-			'number_displayed_past_studiensemester',
-			$this->input->post('number_displayed_past_studiensemester')
-		);
-		$this->VariableModel->setVariable(
-			getAuthUID(),
-			'stv_font_size',
-			$this->input->post('font_size')
-		);
-
-		Events::trigger('stv_config_set', $this->input);
-
-		$this->terminateWithSuccess();
-	}
-	
-	/*
-	 * Get the config for the student filters
-	 *
-	 * @return void
-	 */
-	public function filter()
-	{
-		$this->load->library('VariableLib', ['uid' => getAuthUID()]);
-
-		$this->load->model('crm/Buchungstyp_model', 'BuchungstypModel');
-
-		$this->BuchungstypModel->addOrder('beschreibung');
-		
-		$result = $this->BuchungstypModel->load();
-
-		$buchungstyp_kurzbz = $this->getDataOrTerminateWithError($result);
-		$buchungstyp_kurzbz_plus_all = array_merge([[
-			'buchungstyp_kurzbz' => 'all',
-			'beschreibung' => $this->p->t('stv', 'konto_all_types')
-		]], $buchungstyp_kurzbz);
-
-		$this->load->model('crm/Statusgrund_model', 'StatusgrundModel');
-
-		$result = $this->StatusgrundModel->getAktiveGruende();
-		
-		$statusgruende = $this->getDataOrTerminateWithError($result);
-
-		$result = [];
-
-		$result[] = [
-			'id' => 'filter_konto_count_0',
-			'label' => $this->p->t('stv', 'filter_konto_count_0'),
-			'type' => 'konto',
-			'fixed' => [
-				'missing' => true,
-				'usestdsem' => true
-			],
-			'dynamic' => [
-				'buchungstyp_kurzbz' => [
-					'type' => 'select',
-					'values' => $buchungstyp_kurzbz,
-					'value_key' => 'buchungstyp_kurzbz',
-					'label_key' => 'beschreibung'
-				]
-			]
-		];
-		$result[] = [
-			'id' => 'filter_konto_missing_counter',
-			'label' => $this->p->t('stv', 'filter_konto_missing_counter'),
-			'type' => 'konto_counter',
-			'dynamic' => [
-				'buchungstyp_kurzbz' => [
-					'type' => 'select',
-					'values' => $buchungstyp_kurzbz_plus_all,
-					'value_key' => 'buchungstyp_kurzbz',
-					'label_key' => 'beschreibung'
-				],
-				'samestg' => [
-					'type' => 'bool',
-					'label' => $this->p->t('stv', 'filter_konto_samestg'),
-					'default' => $this->variablelib->getVar('kontofilterstg') == 'true'
-				]
-			]
-		];
-		$result[] = [
-			'id' => 'filter_documents',
-			'label' => $this->p->t('stv', 'filter_documents'),
-			'type' => 'documents'
-		];
-		$result[] = [
-			'id' => 'filter_konto_missing_counter_past',
-			'label' => $this->p->t('stv', 'filter_konto_missing_counter_past'),
-			'type' => 'konto_counter',
-			'fixed' => [
-				'past' => true
-			],
-			'dynamic' => [
-				'buchungstyp_kurzbz' => [
-					'type' => 'select',
-					'values' => $buchungstyp_kurzbz_plus_all,
-					'value_key' => 'buchungstyp_kurzbz',
-					'label_key' => 'beschreibung'
-				],
-				'samestg' => [
-					'type' => 'bool',
-					'label' => $this->p->t('stv', 'filter_konto_samestg'),
-					'default' => $this->variablelib->getVar('kontofilterstg') == 'true'
-				]
-			]
-		];
-		$result[] = [
-			'id' => 'filter_konto_missing_studiengebuehr',
-			'label' => $this->p->t('stv', 'filter_konto_missing_studiengebuehr'),
-			'type' => 'konto',
-			'fixed' => [
-				'missing' => true,
-				'usestdsem' => true
-			],
-			'dynamic' => [
-				'buchungstyp_kurzbz' => [
-					'type' => 'select',
-					'values' => $buchungstyp_kurzbz,
-					'value_key' => 'buchungstyp_kurzbz',
-					'label_key' => 'beschreibung'
-				]
-			]
-		];
-		$result[] = [
-			'id' => 'filter_konto_studiengebuehrerhoeht',
-			'label' => $this->p->t('stv', 'filter_konto_studiengebuehrerhoeht'),
-			'type' => 'konto',
-			'fixed' => [
-				'usestdsem' => true
-			],
-			'dynamic' => [
-				'buchungstyp_kurzbz' => [
-					'type' => 'select',
-					'values' => $buchungstyp_kurzbz,
-					'value_key' => 'buchungstyp_kurzbz',
-					'label_key' => 'beschreibung'
-				]
-			]
-		];
-		$result[] = [
-			'id' => 'filter_zgv_without_date',
-			'label' => $this->p->t('stv', 'filter_zgv_without_date'),
-			'type' => 'zgv'
-		];
-		$result[] = [
-			'id' => 'filter_statusgrund',
-			'label' => $this->p->t('stv', 'filter_statusgrund'),
-			'type' => 'statusgrund',
-			'fixed' => [
-				'usestdsem' => true
-			],
-			'dynamic' => [
-				'statusgrund_id' => [
-					'type' => 'select',
-					'values' => $statusgruende,
-					'value_key' => 'statusgrund_id',
-					'label_key' => 'bezeichnung'
-				]
-			]
-		];
-
-		Events::trigger('stv_conf_filter', function & () use (&$result) {
-			return $result;
-		});
-
-		$this->terminateWithSuccess($result);
-	}
-
 	public function student()
 	{
 		$result = [];
@@ -304,21 +59,21 @@ class Config extends FHCAPI_Controller
 
 		$result['details'] = [
 			'title' => $this->p->t('stv', 'tab_details'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Details.js'),
+			'component' => './Stv/Studentenverwaltung/Details/Details.js',
 			'config' => $config['details']
 		];
 
 		$result['notes'] = [
 			'title' => $this->p->t('stv', 'tab_notes'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Notizen.js'),
+			'component' => './Stv/Studentenverwaltung/Details/Notizen.js',
 			'config'	=> $config['notes'],
 			'showSuffix' => ($config['notes']['showCountNotes'] ?? false),
-			'suffixhelper' => absoluteJsImportUrl('public/js/helpers/Stv/Studentenverwaltung/Details/Notizen/NotizenSuffixHelper.js')
+			'suffixhelper' => APP_ROOT . 'public/js/helpers/Stv/Studentenverwaltung/Details/Notizen/NotizenSuffixHelper.js'
 		];
 
 		$result['contact'] = [
 			'title' => $this->p->t('stv', 'tab_contact'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Kontakt.js'),
+			'component' => './Stv/Studentenverwaltung/Details/Kontakt.js',
 			'config' => [
 				'showBankaccount' => $this->permissionlib->isBerechtigt('mitarbeiter/bankdaten')
 					|| $this->permissionlib->isBerechtigt('student/bankdaten')
@@ -326,20 +81,20 @@ class Config extends FHCAPI_Controller
 		];
 		$result['prestudent'] = [
 			'title' => $this->p->t('stv', 'tab_prestudent'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Prestudent.js'),
+			'component' => './Stv/Studentenverwaltung/Details/Prestudent.js',
 			'config' => $config['prestudent']
 		];
 		$result['status'] = [
 			'title' => 'Status',
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/MultiStatus.js')
+			'component' => './Stv/Studentenverwaltung/Details/MultiStatus.js'
 		];
 		$result['documents'] = [
 			'title' => $this->p->t('stv', 'tab_documents'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Dokumente.js')
+			'component' => './Stv/Studentenverwaltung/Details/Dokumente.js'
 		];
 		$result['banking'] = [
 			'title' => $this->p->t('stv', 'tab_banking'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Konto.js'),
+			'component' => './Stv/Studentenverwaltung/Details/Konto.js',
 			'config' => [
 				'showZahlungsbestaetigung' => (defined('ZAHLUNGSBESTAETIGUNG_ANZEIGEN') && ZAHLUNGSBESTAETIGUNG_ANZEIGEN),
 				'showBuchungsnr' => $this->permissionlib->isBerechtigt('admin'),
@@ -351,23 +106,20 @@ class Config extends FHCAPI_Controller
 		];
 		$result['resources'] = [
 			'title' => $this->p->t('stv', 'tab_resources'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Betriebsmittel.js'),
-			'showOnlyWithUid' => true
+			'component' => './Stv/Studentenverwaltung/Details/Betriebsmittel.js'
 		];
 		$result['groups'] = [
 			'title' => $this->p->t('stv', 'tab_groups'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Groups.js'),
-			'showOnlyWithUid' => true
+			'component' => './Stv/Studentenverwaltung/Details/Gruppen.js'
 		];
 		$result['messages'] = [
 			'title' => $this->p->t('stv', 'tab_messages'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Messages.js'),
-			'showOnlyWithUid' => true
+			'component' => './Stv/Studentenverwaltung/Details/Messages.js'
 		];
 
 		$result['grades'] = [
 			'title' => $this->p->t('stv', 'tab_grades'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Noten.js'),
+			'component' => './Stv/Studentenverwaltung/Details/Noten.js',
 			'showOnlyWithUid' => true,
 			'config' => [
 				'usePoints' => defined('CIS_GESAMTNOTE_PUNKTE') && CIS_GESAMTNOTE_PUNKTE,
@@ -380,42 +132,29 @@ class Config extends FHCAPI_Controller
 
 		$result['exam'] = [
 			'title' => $this->p->t('stv', 'tab_exam'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Pruefung.js'),
-			'showOnlyWithUid' => true
+			'component' => './Stv/Studentenverwaltung/Details/Pruefung.js'
 		];
 
 		$result['exemptions'] = [
 			'title' => $this->p->t('lehre', 'anrechnungen'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Anrechnungen.js'),
+			'component' => './Stv/Studentenverwaltung/Details/Anrechnungen.js',
 			'config' => $config['exemptions']
 		];
 
 		$result['finalexam'] = [
 			'title' => $this->p->t('stv', 'tab_finalexam'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Abschlusspruefung.js'),
-			'showOnlyWithUid' => true,
+			'component' => './Stv/Studentenverwaltung/Details/Abschlusspruefung.js',
 			'config' => $config['finalexam']
 		];
 
-		$result['projektarbeit'] = [
-			'title' => $this->p->t('stv', 'tab_projektarbeit'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Projektarbeit.js'),
-			'config' => array_merge(
-				$config['projektarbeit'],
-				['showVertragsdetails' =>
-					defined('FAS_STUDIERENDE_PROJEKTARBEIT_VERTRAGSDETAILS_ANZEIGEN') && FAS_STUDIERENDE_PROJEKTARBEIT_VERTRAGSDETAILS_ANZEIGEN]
-			)
-		];
-
 		$result['mobility'] = [
 			'title' => $this->p->t('stv', 'tab_mobility'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Mobility.js'),
-			'showOnlyWithUid' => true
+			'component' => './Stv/Studentenverwaltung/Details/Mobility.js'
 		];
 
 		$result['archive'] = [
 			'title' => $this->p->t('stv', 'tab_archive'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Archiv.js'),
+			'component' => './Stv/Studentenverwaltung/Details/Archiv.js',
 			'config' => [
 				'showEdit' => $this->permissionlib->isBerechtigt('admin')
 			]
@@ -423,24 +162,22 @@ class Config extends FHCAPI_Controller
 
 		$result['jointstudies'] = [
 			'title' => $this->p->t('stv', 'tab_jointstudies'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/JointStudies.js'),
-			'showOnlyWithUid' => true
+			'component' => './Stv/Studentenverwaltung/Details/JointStudies.js'
 		];
 
 		$result['coursedates'] = [
 			'title' => $this->p->t('stv', 'tab_courseDates'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Lehrveranstaltungstermine.js')
+			'component' => './Stv/Studentenverwaltung/Details/Lehrveranstaltungstermine.js'
 		];
 
 		$result['admissionDates'] = [
 			'title' => $this->p->t('stv', 'tab_admissionDates'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Aufnahmetermine.js')
+			'component' => './Stv/Studentenverwaltung/Details/Aufnahmetermine.js'
 		];
 
 		$result['functions'] = [
 			'title' => $this->p->t('stv', 'tab_functions'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Funktionen.js'),
-			'showOnlyWithUid' => true
+			'component' => './Stv/Studentenverwaltung/Details/Funktionen.js'
 		];
 
 		Events::trigger('stv_conf_student', function & () use (&$result) {
@@ -458,7 +195,7 @@ class Config extends FHCAPI_Controller
 		$config = $this->config->item('tabs');
 		$result['banking'] = [
 			'title' => $this->p->t('stv', 'tab_banking'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Konto.js'),
+			'component' => './Stv/Studentenverwaltung/Details/Konto.js',
 			'config' => [
 				'showZahlungsbestaetigung' => (defined('ZAHLUNGSBESTAETIGUNG_ANZEIGEN') && ZAHLUNGSBESTAETIGUNG_ANZEIGEN),
 				'showBuchungsnr' => $this->permissionlib->isBerechtigt('admin'),
@@ -468,14 +205,9 @@ class Config extends FHCAPI_Controller
 				'additionalCols' => []
 			]
 		];
-		$result['groups'] = [
-			'title' => $this->p->t('stv', 'tab_groups'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Groups.js'),
-			'showOnlyWithUid' => true
-		];
 		$result['status'] = [
 			'title' => 'Status',
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/MultiStatus.js'),
+			'component' => './Stv/Studentenverwaltung/Details/MultiStatus.js',
 			'config' => [
 				'changeStatusToAbbrecherStgl' => $this->permissionlib->isBerechtigt('admin'),
 				'changeStatusToAbbrecherStud' => $this->permissionlib->isBerechtigt('admin'),
@@ -486,32 +218,17 @@ class Config extends FHCAPI_Controller
 		];
 		$result['finalexam'] = [
 			'title' => $this->p->t('stv', 'tab_finalexam'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Abschlusspruefung.js'),
-			'showOnlyWithUid' => true,
+			'component' => './Stv/Studentenverwaltung/Details/Abschlusspruefung.js',
 			'config' => $config['finalexam']
 		];
 		$result['archive'] = [
 			'title' => $this->p->t('stv', 'tab_archive'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Archiv.js'),
+			'component' => './Stv/Studentenverwaltung/Details/Archiv.js',
 			'config' => [
 				'showEdit' => $this->permissionlib->isBerechtigt('admin')
 			]
 		];
 
-		if($this->permissionlib->isBerechtigt('basis/person'))
-		{
-			$result['combinePeople'] = [
-				'title' => $this->p->t('stv', 'tab_combine_people'),
-				'component' => './Stv/Studentenverwaltung/Details/CombinePeople.js',
-				'config' => $config['combinePeople']
-			];
-		}
-
-		$result['kontaktieren'] = [
-			'title' => $this->p->t('stv', 'tab_kontaktieren'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Kontaktieren.js'),
-		];
-
 		Events::trigger('stv_conf_students', function & () use (&$result) {
 			return $result;
 		});

application/controllers/api/frontend/v1/stv/Dokumente.php

@@ -2,7 +2,6 @@
 
 if (! defined('BASEPATH')) exit('No direct script access allowed');
 
-use \CI3_Events as Events;
 use \DateTime as DateTime;
 
 class Dokumente extends FHCAPI_Controller
@@ -20,8 +19,6 @@ class Dokumente extends FHCAPI_Controller
 			'getDoktypen' => ['admin:r', 'assistenz:r'],
 			'uploadDokument' => ['admin:rw', 'assistenz:rw'],
 			'download' => ['admin:rw', 'assistenz:rw'],
-			'getDocumentDropDown' => ['admin:rw', 'assistenz:rw'],
-			'getDocumentDropDownMulti' => ['admin:rw', 'assistenz:rw'],
 		]);
 
 		// Load Libraries
@@ -569,422 +566,4 @@ class Dokumente extends FHCAPI_Controller
 			return false;
 		}
 	}
-
-	public function getDocumentDropDown($prestudent_id, $studiensemester_kurzbz, $studiengang_kz)
-	{
-		$this->load->helper('hlp_common');
-		//permission to create also odt, and doc outputs of certain documents(menu abschlusspruefung)
-		$hasPermissionOutputformat = $this->permissionlib->isBerechtigt('system/change_outputformat', 's');
-
-		if (!$prestudent_id)
-			$this->terminateWithError($this->p->t('ui', 'errorMissingValue', ['value' => 'Prestudent_id']), self::ERROR_TYPE_GENERAL);
-		if (!$studiensemester_kurzbz)
-			$this->terminateWithError($this->p->t('ui', 'errorMissingValue', ['value' => 'Studiensemester']), self::ERROR_TYPE_GENERAL);
-		if(!$studiengang_kz)
-			$this->terminateWithError($this->p->t('ui', 'errorMissingValue', ['value' => 'Studiengang_kz']), self::ERROR_TYPE_GENERAL);
-
-
-		$uid = $this->_loadUIDFromPrestudent($prestudent_id);
-		$semArray = $this->_getEntriesStudiensemester();
-		$stgTyp = $this->_getStudiengangstyp($studiengang_kz);
-
-		$documents = [
-			buildDropdownEntryPrintArray("accountinfo", "Accountinfoblatt", "xml=accountinfoblatt.xml.php&xsl=AccountInfo&output=pdf", $uid, 10, null),
-			buildDropdownEntryPrintArray("ausbildungsvertrag", "Ausbildungsvertrag", "xml=ausbildungsvertrag.xml.php&xsl=Ausbildungsver&output=pdf", $uid, 20, null),
-			buildDropdownEntryPrintArray("ausbildungsvertrag_en", "Ausbildungsvertrag Zweisprachig", "xml=ausbildungsvertrag.xml.php&xsl=AusbVerEng&output=pdf", $uid, 21, null),
-
-			buildDropdownEntryPrintArray("bescheid", "Bescheid (nur Voransicht)", "xml=abschlusspruefung.rdf.php&xsl_stg_kz=$studiengang_kz&xsl=Bescheid&output=pdf", $uid, 25, null),
-			buildDropdownEntryPrintArray("diplomasupp", "Diploma Supplement (nur Voransicht)", "xml=diplomasupplement.xml.php&xsl_stg_kz=$studiengang_kz&xsl=DiplSupplement&output=pdf", $uid, 26, null),
-
-			buildDropdownEntryPrintArray("studienbestaetigung", "Studienbestätigung", "xml=student.rdf.php&xsl=Inskription&output=pdf", $uid, 50, null),
-			buildDropdownEntryPrintArray("studienbestaetigung_en", "Studienbestätigung Englisch", "xml=student.rdf.php&xsl=InskriptionEng&output=pdf", $uid, 51, null),
-			buildDropdownEntryPrintArray("zutrittskarte", "Zutrittskarte", "xsl=ZutrittskarteStud&output=pdf&data=$uid", $uid,200, "zutrittskarte.php"),
-			buildDropdownEntryPrintArray("studienblatt", "Studienblatt", "xml=studienblatt.xml.php&xsl=Studienblatt&output=pdf&ss=$studiensemester_kurzbz", $uid, 60, null),
-			buildDropdownEntryPrintArray("studienblatt_eng", "Studienblatt Englisch", "xml=studienblatt.xml.php&xsl=StudienblattEng&output=pdf&ss=$studiensemester_kurzbz", $uid, 61, null),
-
-			$this->buildStudienerfolgSubmenu("de", $uid, $semArray, $studiensemester_kurzbz),
-			$this->buildStudienerfolgSubmenu("en", $uid, $semArray, $studiensemester_kurzbz),
-			$this->buildStudienerfolgSubmenu("de", $uid, $semArray, $studiensemester_kurzbz, true),
-			$this->buildStudienerfolgSubmenu("en", $uid, $semArray, $studiensemester_kurzbz, true),
-
-			[
-				"id" => "submenu_studstatus",
-				"type" => "submenu",
-				"name" => "Verwaltung des StudierendenStatus",
-				"order" => 110,
-				"data" => [
-					buildDropdownEntryPrintArray("Abmeldung", "Abmeldung", "xml=AntragAbmeldung.xml.php&xsl=AntragAbmeldung&prestudent_id=$prestudent_id&output=pdf", $uid, null, null),
-					buildDropdownEntryPrintArray("Abmeldung durch Stgl", "AntragAbmeldungStgl", "xml=AntragAbmeldungStgl.xml.php&xsl=AntragAbmeldungStgl&prestudent_id=$prestudent_id&output=pdf", $uid, null, null),
-					buildDropdownEntryPrintArray("Unterbrechung", "Unterbrechung", "xml=AntragUnterbrechung.xml.php&xsl=AntragUnterbrechung&prestudent_id=$prestudent_id&output=pdf", $uid, null, null),
-					buildDropdownEntryPrintArray("Wiederholung", "Abmeldung durch Ablauf der Wiederholungsfrist", "xml=AntragWiederholung.xml.php&xsl=AntragWiederholung&prestudent_id=$prestudent_id&output=pdf", $uid, null, null),
-				]
-			],
-
-			//Bakkzeugnis bzw. Diplomzeugnis is just shown in tab final_exam
-			buildDropdownEntryPrintArray("zeugnis", "Zeugnis", "xml=zeugnis.rdf.php&xsl=Zeugnis&output=pdf&xsl_stg_kz=$studiengang_kz&ss=$studiensemester_kurzbz", $uid, 121, null),
-			buildDropdownEntryPrintArray("zeugnis_en", "Zeugnis Englisch", "xml=zeugnis.rdf.php&xsl=ZeugnisEng&output=pdf&xsl_stg_kz=$studiengang_kz&ss=$studiensemester_kurzbz", $uid, 122, null),
-
-
-		];
-
-		Events::trigger('DocumentGenerationDropDown',
-			// passing $menu per reference
-			function & () use (&$documents) {
-				return $documents;
-			},
-			$prestudent_id,
-			$studiensemester_kurzbz,
-			$studiengang_kz
-		);
-
-		$extraEntries = $this->loadDropDownEntriesBakkOrDipl($stgTyp, $uid);
-
-		$documents = array_merge($documents, $extraEntries);
-
-		usort($documents, function ($a, $b) {
-			$orderA = isset($a['order']) ? (int)$a['order'] : PHP_INT_MAX;
-			$orderB = isset($b['order']) ? (int)$b['order'] : PHP_INT_MAX;
-			return $orderA <=> $orderB;
-		});
-
-		$this->terminateWithSuccess($documents);
-		//return $documents || null;
-	}
-
-	public function getDocumentDropDownMulti($studiensemester_kurzbz,$studiengang_kz)
-	{
-		//permission to create also odt, and doc outputs of certain documents (menu abschlusspruefung)
-		$hasPermissionOutputformat = $this->permissionlib->isBerechtigt('system/change_outputformat', 's');
-
-		$studentUids = $this->input->get('studentUids');
-		$prestudentIds = [];
-
-		if (is_array($studentUids) && !empty($studentUids)) {
-			foreach ($studentUids as $uid) {
-				$prestudent_id = $this-> _loadPrestudentFromUid($uid);
-				$prestudentIds[] = $prestudent_id;
-			}
-		}
-		else
-		{
-			$this->terminateWithError($this->p->t('ui', 'errorMissingValue', ['value' => 'Array StudentUIDs']), self::ERROR_TYPE_GENERAL);
-		}
-
-		if (!$studiensemester_kurzbz)
-			$this->terminateWithError($this->p->t('ui', 'errorMissingValue', ['value' => 'Studiensemester']), self::ERROR_TYPE_GENERAL);
-		if(!$studiengang_kz)
-			$this->terminateWithError($this->p->t('ui', 'errorMissingValue', ['value' => 'Studiengang_kz']), self::ERROR_TYPE_GENERAL);
-
-
-		$uidString = implode(";", $studentUids);
-		$prestudentIdsString = implode(";", $prestudentIds);
-
-		$semArray = $this->_getEntriesStudiensemester();
-		$stgTyp = $this->_getStudiengangstyp($studiengang_kz);
-
-		$documents = [
-			buildDropdownEntryPrintArray("accountinfo", "Accountinfoblatt", "xml=accountinfoblatt.xml.php&xsl=AccountInfo&output=pdf", $uidString, 10, null),
-			buildDropdownEntryPrintArray("ausbildungsvertrag", "Ausbildungsvertrag", "xml=ausbildungsvertrag.xml.php&xsl=Ausbildungsver&output=pdf", $uidString, 20, null),
-			buildDropdownEntryPrintArray("ausbildungsvertrag_en", "Ausbildungsvertrag Englisch", "xml=ausbildungsvertrag.xml.php&xsl=AusbVerEng&output=pdf", $uidString, 21, null),
-			buildDropdownEntryPrintArray("studienbestaetigung", "Studienbestätigung", "xml=student.rdf.php&xsl=Inskription&output=pdf", $uidString, 50, null),
-			buildDropdownEntryPrintArray("studienbestaetigung_en", "Studienbestätigung Englisch", "xml=student.rdf.php&xsl=InskriptionEng&output=pdf", $uidString, 51, null),
-			buildDropdownEntryPrintArray("zutrittskarte", "Zutrittskarte", "xsl=ZutrittskarteStud&output=pdf&data=$uidString", $uidString,200, "zutrittskarte.php"),
-			buildDropdownEntryPrintArray("studienblatt", "Studienblatt", "xml=studienblatt.xml.php&xsl=Studienblatt&output=pdf&ss=$studiensemester_kurzbz", $uidString, 60, null),
-			buildDropdownEntryPrintArray("studienblatt_eng", "Studienblatt Englisch", "xml=studienblatt.xml.php&xsl=StudienblattEng&output=pdf&ss=$studiensemester_kurzbz", $uidString, 61, null),
-
-			// Studienerfolg Menüs automatisch
-			$this->buildStudienerfolgSubmenu("de", $uidString, $semArray, $studiensemester_kurzbz),
-			$this->buildStudienerfolgSubmenu("en", $uidString, $semArray, $studiensemester_kurzbz),
-			$this->buildStudienerfolgSubmenu("de", $uidString, $semArray, $studiensemester_kurzbz, true),
-			$this->buildStudienerfolgSubmenu("en", $uidString, $semArray, $studiensemester_kurzbz, true),
-
-			[
-				"id" => "submenu_studstatus",
-				"type" => "submenu",
-				"name" => "Verwaltung des StudierendenStatus",
-				"order" => 110,
-				"data" => [
-					buildDropdownEntryPrintArray("Abmeldung", "Abmeldung", "xml=AntragAbmeldung.xml.php&xsl=AntragAbmeldung&prestudent_id=$prestudentIdsString&output=pdf", $uidString, null, null),
-					buildDropdownEntryPrintArray("Abmeldung durch Stgl", "AntragAbmeldungStgl", "xml=AntragAbmeldungStgl.xml.php&xsl=AntragAbmeldungStgl&prestudent_id=$prestudentIdsString&output=pdf", $uidString, null, null),
-					buildDropdownEntryPrintArray("Unterbrechung", "Unterbrechung", "xml=AntragUnterbrechung.xml.php&xsl=AntragUnterbrechung&prestudent_id=$prestudentIdsString&output=pdf", $uidString, null, null),
-					buildDropdownEntryPrintArray("Wiederholung", "Abmeldung durch Ablauf der Wiederholungsfrist", "xml=AntragWiederholung.xml.php&xsl=AntragWiederholung&prestudent_id=$prestudentIdsString&output=pdf", $uidString, null, null),
-				]
-			],
-
-			buildDropdownEntryPrintArray("diplomasupp", "Diploma Supplement (nur Voransicht)", "xml=diplomasupplement.xml.php&xsl_stg_kz=$studiengang_kz&xsl=DiplSupplement&output=pdf", $uidString, 35, null),
-			buildDropdownEntryPrintArray("zeugnis", "Zeugnis", "xml=zeugnis.rdf.php&xsl=Zeugnis&output=pdf&xsl_stg_kz=$studiengang_kz&ss=$studiensemester_kurzbz", $uidString, 121, null),
-			buildDropdownEntryPrintArray("zeugnis_en", "Zeugnis Englisch", "xml=zeugnis.rdf.php&xsl=ZeugnisEng&output=pdf&xsl_stg_kz=$studiengang_kz&ss=$studiensemester_kurzbz", $uidString, 122, null),
-		];
-
-		Events::trigger('DocumentGenerationDropDownMulti',
-			// passing $menu per reference
-			function & () use (&$documents) {
-				return $documents;
-			},
-			$studentUids,
-			$studiensemester_kurzbz,
-			$studiengang_kz
-		);
-
-		$extraEntries = $this->loadDropDownEntriesBakkOrDipl($stgTyp, $uidString);
-
-		$documents = array_merge($documents, $extraEntries);
-
-		usort($documents, function ($a, $b) {
-			$orderA = isset($a['order']) ? (int)$a['order'] : PHP_INT_MAX;
-			$orderB = isset($b['order']) ? (int)$b['order'] : PHP_INT_MAX;
-			return $orderA <=> $orderB;
-		});
-
-
-		$this->terminateWithSuccess($documents);
-
-		return $documents || null;
-	}
-
-	private function _loadUIDFromPrestudent($prestudent_id)
-	{
-		if(!$prestudent_id){
-			return $this->terminateWithError("no prestudent ID received.");
-		}
-		$this->load->model('crm/Student_model', 'StudentModel');
-		$result = $this->StudentModel->loadWhere(
-			['prestudent_id' => $prestudent_id]
-		);
-
-		$data = $this->getDataOrTerminateWithError($result);
-		$student = current($data);
-
-		return $student->student_uid;
-	}
-
-	private function _loadPrestudentFromUid($studentUid)
-	{
-
-		$this->load->model('crm/Student_model', 'StudentModel');
-		$result = $this->StudentModel->loadWhere(
-			['student_uid' => $studentUid]
-		);
-
-		$data = $this->getDataOrTerminateWithError($result);
-		$student = current($data);
-
-
-		return $student->prestudent_id;
-	}
-
-	/**
-	 * is building an array with studiensemesterkurzb
-	 * actual studiensemester plus the 5 studiensemester in the past
-
-	 * @return Array Studiensemester_kurzbz
-	 */
-	private function _getEntriesStudiensemester(){
-		$this->load->model('organisation/Studiensemester_model', 'StudiensemesterModel');
-
-		$this->StudiensemesterModel->addPlusMinus(1, 5);
-		$this->StudiensemesterModel->addOrder('ende', 'DESC');
-		$result = $this->StudiensemesterModel->load();
-		$data = $this->getDataOrTerminateWithError($result);
-
-		foreach($data as $sem)
-		{
-			$semArray[] = $sem->studiensemester_kurzbz;
-		}
-
-		array_shift($semArray);
-
-		return $semArray;
-	}
-	/**
-	 * is returning the typ of Studiengang (Bakk oder Master)
-
-	 * @return character  eg. 'b' or 'm'
-	 */
-	private function _getStudiengangstyp($studiengang_kz)
-	{
-		$this->load->model('organisation/Studiengang_model', 'StudiengangModel');
-
-		$result = $this->StudiengangModel->loadWhere(
-			array('studiengang_kz' => $studiengang_kz)
-		);
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$typStudiengang = current($data)->typ;
-
-		return $typStudiengang;
-	}
-
-	/**
-	 * helper function to create ArrayStructure
-	 * actual studiensemester plus the 5 studiensemester in the past
-
-	 * @return Array Studiensemester_kurzbz
-	 */
-	private function buildStudienerfolgSubmenu($lang, $uid, $semArray, $studiensemester_kurzbz, $fa = false)
-	{
-		$entries = [];
-
-		$xsl = $lang === "de" ? "Studienerfolg" : "StudienerfolgEng";
-		$idPrefix = "submenu_studienerfolg_" . $lang . ($fa ? "_fa" : "");
-
-		$entries[] = buildDropdownEntryPrintArray(
-			$idPrefix . "_aktuell",
-			"ausgewähltes Semester",
-			"xml=studienerfolg.rdf.php&xsl=$xsl&ss=$studiensemester_kurzbz" . ($fa ? "&typ=finanzamt" : ""),
-			$uid
-		);
-
-		//all semester
-		$entries[] = buildDropdownEntryPrintArray(
-			$idPrefix . "_all",
-			"alle Semester",
-			"xml=studienerfolg.rdf.php&xsl=$xsl&ss=$studiensemester_kurzbz&all=true" . ($fa ? "&typ=finanzamt" : ""),
-			$uid
-		);
-
-		//sem from array
-		foreach ($semArray as $i => $sem) {
-			$entries[] = buildDropdownEntryPrintArray(
-				$idPrefix . ($i === 0 ? "_akt" : "_minus" . $i),
-				$sem,
-				"xml=studienerfolg.rdf.php&xsl=$xsl&ss=$sem" . ($fa ? "&typ=finanzamt" : ""),
-				$uid
-			);
-
-		}
-		$order = 0;
-		if ($lang === "de" && !$fa) $order = 75; // Studienerfolg
-		if ($lang === "en" && !$fa) $order = 76; // Studienerfolg Englisch
-		if ($lang === "de" &&  $fa) $order = 77; // Studienerfolg Finanzamt
-		if ($lang === "en" &&  $fa) $order = 78; // Studienerfolg Finanzamt Englisch
-
-		return [
-			"id"   => $idPrefix,
-			"type" => "submenu",
-			"name" => "Studienerfolg " . ($fa ? " Finanzamt" : "") . ($lang === "de" ? "" : "Englisch") ,
-			"order" => $order,
-			"data" => $entries,
-		];
-	}
-
-	private function loadDropDownEntriesFinalExam($hasPermissionOutputformat, $stgTyp, $uid)
-	{
-		if ($stgTyp == 'b')
-			$postfix = 'Bakk';
-		else if ($stgTyp == 'm' || $stgTyp == 'd')
-			$postfix = 'Master';
-		else
-			return [];
-
-		$arrayFinalExam = [
-			'pruefungsprotokoll' => [
-				'de' => [
-					'Bakk' => 'PrProtBA',
-					'Master' => 'PrProtMA',
-				],
-				'en' => [
-					'Bakk' => 'PrProtBAEng',
-					'Master' => 'PrProtMAEng',
-				],
-			],
-			'pruefungszeugnis' => [
-				'de' => [
-					'Bakk' => 'Bakkzeugnis',
-					'Master' => 'Diplomzeugnis',
-				],
-				'en' => [
-					'Bakk' => 'BakkzeugnisEng',
-					'Master' => 'DiplomzeugnisEng',
-				],
-			],
-			'urkunde' => [
-				'de' => [
-					'Bakk' => 'Bakkurkunde',
-					'Master' => 'Diplomurkunde',
-				],
-				'en' => [
-					'Bakk' => 'BakkurkundeEng',
-					'Master' => 'DiplomurkundeEng',
-				],
-			],
-		];
-
-		$langLabels = [
-			"de" => "Deutsch",
-			"en" => "Englisch"
-		];
-
-		$docLabels = [
-			"pruefungsprotokoll" => "Prüfungsprotokoll",
-			"pruefungszeugnis" => "Zeugnis",
-			"urkunde" => "Urkunde"
-		];
-
-		$submenuData = [];
-		if ($hasPermissionOutputformat) {
-			foreach ($arrayFinalExam as $docType => $langs) {
-				foreach ($langs as $lang => $types) {
-					$xsl = $types[$postfix];
-					$idPrefix = $docType . "_" . $lang;
-
-					$baseName = $docLabels[$docType] . " " . $langLabels[$lang];
-					$baseUrl = "xml=abschlusspruefung.rdf.php&xsl={$xsl}";
-
-					//3 outputformates
-					foreach (["pdf", "odt", "docx"] as $format) {
-						$submenuData[] = buildDropdownEntryPrintArray(
-							$idPrefix . "_" . $format,
-							$baseName . " (" . strtoupper($format) . ")",
-							$baseUrl . "&output=" . $format,
-							$uid
-						);
-					}
-				}
-			}
-		}
-		else
-		{
-			foreach ($arrayFinalExam as $docType => $langs) {
-				foreach ($langs as $lang => $types) {
-					$xsl = $types[$postfix]; // Auswahl Bakk/Master für jeweilige Sprache
-					$id = $docType . "_" . $lang;
-
-					$name = $docLabels[$docType] . " " . $langLabels[$lang];
-
-					$url = "xml=abschlusspruefung.rdf.php&xsl=" . $xsl . "&output=pdf";
-
-					$submenuData[] = buildDropdownEntryPrintArray($id, $name, $url, $uid);
-				}
-			}
-		}
-		return [
-			"id" => "submenu_finalexam",
-			"type" => "submenu",
-			"name" => "Abschlussprüfung",
-			"data" => $submenuData,
-			"order" => null,
-			"order" => 80,
-		];
-	}
-
-	private function loadDropDownEntriesBakkOrDipl($stgTyp, $uid)
-	{
-		$entries = [];
-
-		if ($stgTyp == 'b')
-		{
-			$entries[] = buildDropdownEntryPrintArray("bakkurkunde", "Bakkurkunde", "xml=abschlusspruefung.rdf.php&xsl=Bakkurkunde&output=pdf", $uid, 22, null);
-			$entries[] = buildDropdownEntryPrintArray("bakkurkundeEng", "Bakkurkunde Englisch", "xml=abschlusspruefung.rdf.php&xsl=BakkurkundeEng&output=pdf", $uid, 23, null);
-		}
-
-		if ($stgTyp == 'm' || $stgTyp == 'd')
-		{
-			$entries[] = buildDropdownEntryPrintArray("diplomurkunde", "Diplomurkunde", "xml=abschlusspruefung.rdf.php&xsl=Diplomurkunde&output=pdf", $uid, 27, null);
-			$entries[] = buildDropdownEntryPrintArray("diplomurkundeEng", "Diplomurkunde Englisch", "xml=abschlusspruefung.rdf.php&xsl=DiplomurkundeEng&output=pdf", $uid, 28, null);
-		}
-
-		return $entries;
-	}
-
 }

application/controllers/api/frontend/v1/stv/Favorites.php

@@ -60,6 +60,17 @@ class Favorites extends FHCAPI_Controller
 
 		$favorites = $this->input->post('favorites');
 
+		$removed = [];
+		while (strlen($favorites) > 64) {
+			$favObj = json_decode($favorites);
+			if (!$favObj->list)
+				break;
+			$removed[] = array_shift($favObj->list);
+			$favorites = json_encode($favObj);
+		}
+		if ($removed)
+			$this->addMeta('removed', $removed);
+
 		$result = $this->VariableModel->setVariable(getAuthUID(), 'stv_favorites', $favorites);
 
 		$this->getDataOrTerminateWithError($result);

application/controllers/api/frontend/v1/stv/GemeinsameStudien.php

@@ -83,7 +83,7 @@ class GemeinsameStudien extends FHCAPI_Controller
 	{
 		$this->load->model('organisation/Studiensemester_model', 'StudiensemesterModel');
 
-		$this->StudiensemesterModel->addOrder('start', 'DESC');
+		$this->StudiensemesterModel->addOrder('studienjahr_kurzbz', 'DESC');
 		$result = $this->StudiensemesterModel->load();
 		$data = $this->getDataOrTerminateWithError($result);
 		$this->terminateWithSuccess($data);

application/controllers/api/frontend/v1/stv/Gruppen.php

@@ -9,8 +9,6 @@ class Gruppen extends FHCAPI_Controller
 	public function __construct()
 	{
 		parent::__construct([
-			'add' => ['admin:rw', 'assistenz:rw'],
-			'search' => ['admin:r', 'assistenz:r'],
 			'getGruppen' => ['admin:r', 'assistenz:r'],
 			'deleteGruppe' => ['admin:rw', 'assistenz:rw'],
 		]);
@@ -20,9 +18,7 @@ class Gruppen extends FHCAPI_Controller
 
 		// Load language phrases
 		$this->loadPhrases([
-			'ui',
-			'gruppenmanagement',
-			'lehre'
+			'ui', 'gruppenmanagement'
 		]);
 
 		// Load models
@@ -30,141 +26,15 @@ class Gruppen extends FHCAPI_Controller
 		$this->load->model('organisation/Gruppe_model', 'GruppeModel');
 	}
 
-	public function add()
-	{
-		$this->load->library("form_validation");
-
-		$this->form_validation->set_rules(
-			'gruppe_kurzbz',
-			$this->p->t('gruppenmanagement', 'gruppe'),
-			'required|is_in_db[organisation/Gruppe_model]',
-			[
-				'required' => $this->p->t('ui', 'error_fieldRequired'),
-				'is_in_db' => $this->p->t('ui', 'error_fieldNotFound')
-			]
-		);
-		$this->form_validation->set_rules(
-			'uid',
-			$this->p->t('ui', 'student_uid'),
-			'required|is_in_db[crm/Student_model:student_uid]',
-			[
-				'required' => $this->p->t('ui', 'error_fieldRequired'),
-				'is_in_db' => $this->p->t('ui', 'error_fieldNotFound')
-			]
-		);
-		$this->form_validation->set_rules(
-			'studiensemester_kurzbz',
-			$this->p->t('lehre', 'studiensemester'),
-			'required|is_in_db[organisation/Studiensemester_model]',
-			[
-				'required' => $this->p->t('ui', 'error_fieldRequired'),
-				'is_in_db' => $this->p->t('ui', 'error_fieldNotFound')
-			]
-		);
-
-		if (!$this->form_validation->run())
-			$this->terminateWithValidationErrors($this->form_validation->error_array());
-
-		$gruppe_kurzbz = $this->input->post('gruppe_kurzbz');
-		$uid = $this->input->post('uid');
-		$studiensemester_kurzbz = $this->input->post('studiensemester_kurzbz');
-
-		$result = $this->BenutzergruppeModel->load([
-			$gruppe_kurzbz,
-			$uid
-		]);
-		$benutzergruppe = $this->getDataOrTerminateWithError($result);
-
-		if ($benutzergruppe) {
-			$this->terminateWithError(
-				$this->p->t('gruppenmanagement', 'error_alreadyInGroup', [
-					'uid' => $uid,
-					'studiensemester_kurzbz' => current($benutzergruppe)->studiensemester_kurzbz
-				]),
-				self::ERROR_TYPE_GENERAL
-			);
-		}
-
-		$result = $this->BenutzergruppeModel->insert([
-			'uid' => $uid,
-			'gruppe_kurzbz' => $gruppe_kurzbz,
-			'studiensemester_kurzbz' => $studiensemester_kurzbz,
-			'insertamum' => date('c'),
-			'insertvon' => getAuthUID()
-		]);
-
-		$this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess();
-	}
-
-	public function search()
-	{
-		$query = $this->input->post('query');
-		if (!$query)
-			$this->terminateWithSuccess([]);
-
-		// add query to where clause
-		$query = strtoupper($query);
-		$query = $this->GruppeModel->db->escape_like_str($query);
-		$query = '%' . str_replace(' ', '%', $query) . '%';
-
-		$this->GruppeModel->db->group_start();
-		$this->GruppeModel->db->or_like('UPPER(gruppe_kurzbz)', $query, 'none', false);
-		$this->GruppeModel->db->or_like('UPPER(bezeichnung)', $query, 'none', false);
-		$this->GruppeModel->db->or_like('UPPER(beschreibung)', $query, 'none', false);
-		$this->GruppeModel->db->group_end();
-		
-		// add stg sorting 1
-		$studiengang_kz = $this->input->post('studiengang_kz');
-		$sort_stg = $studiengang_kz ? "WHEN studiengang_kz = " . $this->GruppeModel->escape($studiengang_kz) . " THEN 0" : "";
-
-		// add stg sorting 2
-		$studiengang_kzs = [];
-		$result = $this->permissionlib->getSTG_isEntitledFor('admin');
-		if ($result)
-			$studiengang_kzs = array_merge($studiengang_kzs, $result);
-		$result = $this->permissionlib->getSTG_isEntitledFor('assistenz');
-		if ($result)
-			$studiengang_kzs = array_merge($studiengang_kzs, $result);
-
-		// selects
-		$this->GruppeModel->addSelect("*");
-		$this->GruppeModel->addSelect("CASE
-			" . $sort_stg . "
-			WHEN studiengang_kz IN (" . implode(",", $this->GruppeModel->db->escape($studiengang_kzs)) . ")
-			THEN 1
-			ELSE 2
-		END AS sort_stg");
-
-		// ordering
-		$this->GruppeModel->addOrder("sort_stg");
-		$this->GruppeModel->addOrder("sort");
-		$this->GruppeModel->addOrder("gruppe_kurzbz");
-
-		// default where clause & execute
-		$result = $this->GruppeModel->loadWhere([
-			'lehre' => true,
-			'sichtbar' => true,
-			'aktiv' => true,
-			'direktinskription' => false,
-			'generiert' => false
-		]);
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
-	}
-
 	public function getGruppen($student_uid)
 	{
-		$this->BenutzergruppeModel->addSelect('gruppe_kurzbz');
-		$this->BenutzergruppeModel->addSelect('bezeichnung');
-		$this->BenutzergruppeModel->addSelect('generiert');
-		$this->BenutzergruppeModel->addSelect('uid');
-		$this->BenutzergruppeModel->addSelect('studiensemester_kurzbz');
-		$this->BenutzergruppeModel->addJoin('public.tbl_gruppe', 'gruppe_kurzbz');
-		$this->BenutzergruppeModel->addOrder('bezeichnung', 'ASC');
+		$this->BenutzergruppeModel ->addSelect('gruppe_kurzbz');
+		$this->BenutzergruppeModel ->addSelect('bezeichnung');
+		$this->BenutzergruppeModel ->addSelect('generiert');
+		$this->BenutzergruppeModel ->addSelect('uid');
+		$this->BenutzergruppeModel ->addSelect('studiensemester_kurzbz');
+		$this->BenutzergruppeModel ->addJoin('public.tbl_gruppe', 'gruppe_kurzbz');
+		$this->BenutzergruppeModel-> addOrder('bezeichnung', 'ASC');
 
 		$result = $this->BenutzergruppeModel->loadWhere(
 			array(
@@ -179,48 +49,29 @@ class Gruppen extends FHCAPI_Controller
 
 	public function deleteGruppe()
 	{
-		$this->load->library("form_validation");
-
-		$this->form_validation->set_rules(
-			'uid',
-			$this->p->t('person', 'UID'),
-			'required',
-			[
-				'required' => $this->p->t('ui', 'error_fieldRequired')
-			]
-		);
-
-		$this->form_validation->set_rules(
-			'gruppe_kurzbz',
-			$this->p->t('gruppenmanagement', 'gruppe'),
-			'required',
-			[
-				'required' => $this->p->t('ui', 'error_fieldRequired')
-			]
-		);
-
-		if (!$this->form_validation->run())
-			$this->terminateWithValidationErrors($this->form_validation->error_array());
-
-		$uid = $this->input->post('uid');
+		$student_uid = $this->input->post('id');
 		$gruppe_kurzbz = $this->input->post('gruppe_kurzbz');
 
-		// Validate if automatic group generation
-		$result = $this->GruppeModel->loadWhere([
-			'gruppe_kurzbz' => $gruppe_kurzbz
-		]);
+		//Validate if automatic group generation
+		$result = $this->GruppeModel-> loadWhere(
+			array(
+				'gruppe_kurzbz' => $gruppe_kurzbz
+			)
+		);
 		$data = $this->getDataOrTerminateWithError($result);
 		$generation = current($data);
 
-		if ($generation->generiert)
+		if($generation->generiert)
 		{
 			$this->terminateWithError($this->p->t('gruppenmanagement', 'error_deleteGeneratedGroups'), self::ERROR_TYPE_GENERAL);
 		}
 
-		$result = $this->BenutzergruppeModel->delete([
-			'gruppe_kurzbz' => $gruppe_kurzbz,
-			'uid' => $uid
-		]);
+		$result = $this->BenutzergruppeModel->delete(
+			array(
+				'gruppe_kurzbz' => $gruppe_kurzbz,
+				'uid' => $student_uid
+				)
+		);
 
 		$data = $this->getDataOrTerminateWithError($result);
 

application/controllers/api/frontend/v1/stv/Kontakt.php

@@ -52,7 +52,6 @@ class Kontakt extends FHCAPI_Controller
 		// Extra Permissionchecks
 		$permsMa = [];
 		$permsStud = [];
-		$permsDefault = null;
 		switch ($this->router->method) {
 			case 'getBankverbindung':
 			case 'loadBankverbindung':
@@ -69,7 +68,7 @@ class Kontakt extends FHCAPI_Controller
 			case 'getKontakte':
 			case 'loadAddress':
 			case 'loadContact':
-				$permsMa = $permsStud = $permsDefault = ['admin:r', 'assistenz:r'];
+				$permsMa = $permsStud = ['admin:r', 'assistenz:r'];
 				break;
 			case 'addNewAddress':
 			case 'addNewContact':
@@ -77,7 +76,7 @@ class Kontakt extends FHCAPI_Controller
 			case 'updateContact':
 			case 'deleteAddress':
 			case 'deleteContact':
-				$permsMa = $permsStud = $permsDefault = ['admin:rw', 'assistenz:rw'];
+				$permsMa = $permsStud = ['admin:rw', 'assistenz:rw'];
 				break;
 		}
 		if ($this->router->method == 'getAdressen'
@@ -92,7 +91,7 @@ class Kontakt extends FHCAPI_Controller
 			if (is_null($person_id) || !ctype_digit((string)$person_id))
 				$this->terminateWithError( $this->p->t('ui', 'ungueltigeParameter'), self::ERROR_TYPE_GENERAL);
 
-			$this->checkPermissionsForPerson($person_id, $permsMa, $permsStud, $permsDefault);
+			$this->checkPermissionsForPerson($person_id, $permsMa, $permsStud);
 		} elseif ($this->router->method == 'loadAddress'
 			|| $this->router->method == 'loadContact'
 			|| $this->router->method == 'loadBankverbindung'
@@ -136,7 +135,7 @@ class Kontakt extends FHCAPI_Controller
 
 			$person_id = current($data)->person_id;
 			
-			$this->checkPermissionsForPerson($person_id, $permsMa, $permsStud, $permsDefault);
+			$this->checkPermissionsForPerson($person_id, $permsMa, $permsStud);
 		}
 	}
 	public function getAdressen($person_id)

application/controllers/api/frontend/v1/stv/Konto.php

@@ -352,7 +352,7 @@ class Konto extends FHCAPI_Controller
 				continue;
 			}
 
-			
+
 			$result = $this->KontoModel->insert([
 				'person_id' => $buchung['person_id'],
 				'studiengang_kz' => $buchung['studiengang_kz'],
@@ -361,7 +361,7 @@ class Konto extends FHCAPI_Controller
 				'buchungstyp_kurzbz' => $buchung['buchungstyp_kurzbz'],
 				'credit_points' => $buchung['credit_points'],
 				'zahlungsreferenz' => $buchung['zahlungsreferenz'],
-				'betrag' => number_format($betrag, 2, '.', ''),
+				'betrag' => $betrag,
 				'buchungsdatum' => $buchungsdatum,
 				'mahnspanne' => '0',
 				'buchungsnr_verweis' => $buchung['buchungsnr'],

application/controllers/api/frontend/v1/stv/Lehrverband.php

@@ -1,63 +0,0 @@
-<?php
-
-if (! defined('BASEPATH')) exit('No direct script access allowed');
-
-
-class Lehrverband extends FHCAPI_Controller
-{
-	public function __construct()
-	{
-		parent::__construct([
-			'hasOrgforms' => ['admin:r', 'assistenz:r'],
-			'getTree' => ['admin:r', 'assistenz:r'],
-			'getSpecialgroups' => ['admin:r', 'assistenz:r']
-		]);
-	}
-
-	public function hasOrgforms($studiengang_kz)
-	{
-		$this->load->model('organisation/Studiengang_model', 'StudiengangModel');
-		
-		$result = $this->StudiengangModel->load($studiengang_kz);
-		
-		$data = $this->getDataOrTerminateWithError($result);
-		if ($data) {
-			$data = current($data)->mischform;
-		}
-		
-		$this->terminateWithSuccess($data);
-	}
-
-	public function getTree($studiengang_kz)
-	{
-		$this->load->model('organisation/Lehrverband_model', 'LehrverbandModel');
-
-		$result = $this->LehrverbandModel->loadWhere([
-			'studiengang_kz' => $studiengang_kz,
-			'aktiv' => true
-		]);
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
-	}
-
-	public function getSpecialgroups($studiengang_kz)
-	{
-		$this->load->model('organisation/Gruppe_model', 'GruppeModel');
-
-		$where = [
-			'studiengang_kz' => $studiengang_kz,
-			'lehre' => true,
-			'sichtbar' => true,
-			'aktiv' => true,
-			'direktinskription' => false
-		];
-
-		$result = $this->GruppeModel->loadWhere($where);
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
-	}
-}

application/controllers/api/frontend/v1/stv/Projektarbeit.php

@@ -1,364 +0,0 @@
-<?php
-
-if (! defined('BASEPATH')) exit('No direct script access allowed');
-
-use \DateTime as DateTime;
-
-class Projektarbeit extends FHCAPI_Controller
-{
-	public function __construct()
-	{
-		parent::__construct([
-			'getProjektarbeit' => ['admin:r', 'assistenz:r'],
-			'loadProjektarbeit' => ['admin:r', 'assistenz:r'],
-			'insertProjektarbeit' => ['admin:rw', 'assistenz:rw'],
-			'updateProjektarbeit' => ['admin:rw', 'assistenz:rw'],
-			'deleteProjektarbeit' => ['admin:rw', 'assistenz:rw'],
-			'getTypenProjektarbeit' => ['admin:r', 'assistenz:r'],
-			'getFirmen' => ['admin:r', 'assistenz:r'],
-			'getLehrveranstaltungen' => ['admin:r', 'assistenz:r'],
-			'getNoten' => ['admin:r', 'assistenz:r']
-		]);
-
-		// Load Libraries
-		$this->load->library('form_validation');
-
-		// Load language phrases
-		$this->loadPhrases([
-			'ui',
-			'person',
-			'projektarbeit'
-		]);
-
-		// Load models
-		$this->load->model('education/Projektarbeit_model', 'ProjektarbeitModel');
-		$this->load->model('education/Projekttyp_model', 'ProjekttypModel');
-		$this->load->model('education/Paabgabe_model', 'PaabgabeModel');
-		$this->load->model('ressource/Firma_model', 'FirmaModel');
-		$this->load->model('education/Lehrveranstaltung_model', 'LehrveranstaltungModel');
-		$this->load->model('education/Lehreinheit_model', 'LehreinheitModel');
-		$this->load->model('ressource/Mitarbeiter_model', 'MitarbeiterModel');
-		$this->load->model('education/Note_model', 'NoteModel');
-		$this->load->model('education/Projektbetreuer_model', 'BetreuerModel');
-
-		// load libraries
-		$this->load->library('PermissionLib');
-	}
-
-	public function getProjektarbeit()
-	{
-		$student_uid = $this->input->get('uid');
-
-		if (!isset($student_uid)) $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Student UID']), self::ERROR_TYPE_GENERAL);
-
-		$result = $this->ProjektarbeitModel->getProjektarbeit($student_uid);
-
-		if (isError($result))
-		{
-			$this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-		}
-
-		if (!hasData($result)) $this->terminateWithSuccess([]);
-
-		$projektarbeiten = getData($result);
-
-		foreach ($projektarbeiten as $projektarbeit)
-		{
-			$projektarbeit_id = $projektarbeit->projektarbeit_id;
-			$abgabeRes = $this->PaabgabeModel->getEndabgabe($projektarbeit_id);
-
-			if (isError($abgabeRes)) $this->terminateWithError(getError($abgabeRes), self::ERROR_TYPE_GENERAL);
-
-			if (hasData($abgabeRes))
-			{
-				$paabgabe = getData($abgabeRes)[0];
-				$projektarbeit->abgabedatum = $paabgabe->abgabedatum;
-			}
-		}
-
-		$this->terminateWithSuccess($projektarbeiten);
-	}
-
-	public function loadProjektarbeit()
-	{
-		$projektarbeit_id = $this->input->get('projektarbeit_id');
-
-		if (!isset($projektarbeit_id) || !is_numeric($projektarbeit_id)) return $this->terminateWithError('Projektarbeit Id missing', self::ERROR_TYPE_GENERAL);
-
-		$this->ProjektarbeitModel->addSelect(
-			'lehre.tbl_projektarbeit.projektarbeit_id, titel, titel_english, themenbereich, projekttyp_kurzbz, lehrveranstaltung_id, lehreinheit_id, 
-			firma_id, beginn, ende, gesperrtbis, note, final, freigegeben, tbl_projektarbeit.anmerkung, fa.name AS firma_name'
-		);
-		$this->ProjektarbeitModel->addJoin('lehre.tbl_lehreinheit le', 'lehreinheit_id');
-		$this->ProjektarbeitModel->addJoin('lehre.tbl_lehrveranstaltung lv', 'lehrveranstaltung_id');
-		$this->ProjektarbeitModel->addJoin('public.tbl_firma fa', 'firma_id', 'LEFT');
-		$result = $this->ProjektarbeitModel->loadWhere(
-			array('projektarbeit_id' => $projektarbeit_id)
-		);
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess(current($data));
-	}
-
-	public function insertProjektarbeit()
-	{
-		$student_uid = $this->input->post('uid');
-
-		if (!$student_uid) return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Student UID']), self::ERROR_TYPE_GENERAL);
-
-		if (!$this->_hasBerechtigungForStudent($student_uid))
-			return $this->_outputAuthError([$this->router->method => ['admin:rw', 'assistenz:rw']]);
-
-		$formData = $this->input->post('formData');
-
-		if ($this->_validate($formData) == false)
-		{
-			$this->terminateWithValidationErrors($this->form_validation->error_array());
-		}
-
-		$projektarbeit = $this->_getProjektarbeitArr($formData);
-
-		$result = $this->ProjektarbeitModel->insert(
-			array_merge($projektarbeit, ['insertamum' => date('c'), 'insertvon' => getAuthUID(), 'student_uid' => $student_uid])
-		);
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
-	}
-
-	public function updateProjektarbeit()
-	{
-		$projektarbeit_id = $this->input->post('projektarbeit_id');
-
-		if (!$projektarbeit_id || !is_numeric($projektarbeit_id))
-			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Projektarbeit ID']), self::ERROR_TYPE_GENERAL);
-
-		if (!$this->ProjektarbeitModel->hasBerechtigungForProjektarbeit($projektarbeit_id))
-			return $this->_outputAuthError([$this->router->method => ['admin:rw', 'assistenz:rw']]);
-
-		$formData = $this->input->post('formData');
-
-		if ($this->_validate($formData) == false)
-		{
-			$this->terminateWithValidationErrors($this->form_validation->error_array());
-		}
-
-		$projektarbeit = $this->_getProjektarbeitArr($formData);
-
-		$result = $this->ProjektarbeitModel->update(
-			$projektarbeit_id,
-			array_merge($projektarbeit, ['updateamum' => date('c'), 'updatevon' => getAuthUID()])
-		);
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
-	}
-
-	public function deleteProjektarbeit()
-	{
-		$projektarbeit_id = $this->input->post('projektarbeit_id');
-
-		if (!isset($projektarbeit_id) || !is_numeric($projektarbeit_id))
-			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Projektarbeit ID'], self::ERROR_TYPE_GENERAL));
-
-		if (!$this->ProjektarbeitModel->hasBerechtigungForProjektarbeit($projektarbeit_id))
-			return $this->_outputAuthError([$this->router->method => ['admin:rw', 'assistenz:rw']]);
-
-		$validate = $this->_validateDelete($projektarbeit_id);
-
-		if (isError($validate)) return $this->terminateWithError(getError($validate), self::ERROR_TYPE_GENERAL);
-
-		$result = $this->ProjektarbeitModel->delete(
-			['projektarbeit_id' => $projektarbeit_id]
-		);
-
-		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		if (!hasData($result))
-		{
-			$this->outputJson($result);
-		}
-
-		return $this->terminateWithSuccess(current(getData($result)) ? : null);
-	}
-
-	public function getTypenProjektarbeit()
-	{
-		$result = $this->ProjekttypModel->loadWhere(['aktiv' => true]);
-
-		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		return $this->terminateWithSuccess(hasData($result) ? getData($result) : []);
-	}
-
-	public function getFirmen()
-	{
-		$searchString = $this->input->get('searchString');
-
-		if (!isset($searchString))
-			$this->terminateWithError($this->p->t('ui', 'error_fieldRequired', ['field' => 'Search term']), self::ERROR_TYPE_GENERAL);
-
-		$result = $this->FirmaModel->searchFirmen($searchString, $aktiv = true);
-
-		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		return $this->terminateWithSuccess(hasData($result) ? getData($result) : []);
-	}
-
-	public function getLehrveranstaltungen()
-	{
-		$student_uid = $this->input->get('student_uid');
-		$studiengang_kz = $this->input->get('studiengang_kz');
-		$studiensemester_kurzbz = $this->input->get('studiensemester_kurzbz');
-		$additional_lehrveranstaltung_id = $this->input->get('additional_lehrveranstaltung_id');
-
-		if (!isset($student_uid)) $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Student UID']), self::ERROR_TYPE_GENERAL);
-		if (!isset($studiensemester_kurzbz)) $this->terminateWithError('Studiensemster missing', self::ERROR_TYPE_GENERAL);
-
-		$lvsResult = $this->LehrveranstaltungModel->getLvsForProjektarbeit($student_uid, $studiengang_kz, $additional_lehrveranstaltung_id);
-
-		if (isError($lvsResult)) return $this->terminateWithError($lvsResult, self::ERROR_TYPE_GENERAL);
-
-		$lvs = hasData($lvsResult) ? getData($lvsResult) : [];
-
-		foreach ($lvs as $lv)
-		{
-			$lehreinheiten = $this->LehreinheitModel->getLesForLv(
-				$lv->lehrveranstaltung_id, $studiensemester_kurzbz
-			);
-
-			foreach ($lehreinheiten as $lehreinheit)
-			{
-				if (!isEmptyArray($lehreinheit->lektoren))
-				{
-					$this->MitarbeiterModel->addSelect('kurzbz');
-					$this->MitarbeiterModel->db->where_in('tbl_mitarbeiter.mitarbeiter_uid', $lehreinheit->lektoren);
-					$maResult = $this->MitarbeiterModel->load();
-
-					if (isError($maResult)) return $this->terminateWithError($lvsResult, self::ERROR_TYPE_GENERAL);
-
-					$lehreinheit->lektoren = array_column(getData($maResult), 'kurzbz');
-				}
-			}
-
-			$lv->lehreinheiten = $lehreinheiten;
-		}
-
-		return $this->terminateWithSuccess($lvs);
-	}
-
-	public function getNoten()
-	{
-		$result = $this->NoteModel->load();
-
-		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		return $this->terminateWithSuccess(hasData($result) ? getData($result) : []);
-	}
-
-	/**
-	 *
-	 * @param
-	 * @return object success or error
-	 */
-	private function _validate($formData)
-	{
-		$this->form_validation->set_data($formData);
-
-		$this->form_validation->set_rules('projekttyp_kurzbz', 'Projekttyp', 'required', [
-			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => 'Projekttyp'])
-		]);
-
-		$this->form_validation->set_rules('lehreinheit_id', 'Lehreinheit', 'required|is_natural', [
-			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => 'Lehreinheit']),
-			'is_natural' =>  $this->p->t('ui', 'error_fieldNotNumeric', ['field' => 'Lehreinheit'])
-		]);
-
-		$this->form_validation->set_rules('beginn', 'Beginn', 'is_valid_date', [
-			'is_valid_date' => $this->p->t('ui', 'error_notValidDate', ['field' => 'Beginn'])
-		]);
-
-		$this->form_validation->set_rules('ende', 'Ende', 'is_valid_date', [
-			'is_valid_date' => $this->p->t('ui', 'error_notValidDate', ['field' => 'Ende'])
-		]);
-
-		$this->form_validation->set_rules('gesperrtbis', 'Ende', 'is_valid_date', [
-			'is_valid_date' => $this->p->t('ui', 'error_notValidDate', ['field' => 'Gesperrt bis'])
-		]);
-
-		return $this->form_validation->run();
-	}
-
-	/**
-	 * 
-	 * @param
-	 * @return object success or error
-	 */
-	private function _getProjektarbeitArr($formData)
-	{
-		return [
-			'titel' => $formData['titel'],
-			'titel_english' => $formData['titel_english'] ?? null,
-			'themenbereich' => $formData['themenbereich'] ?? null,
-			'projekttyp_kurzbz' => $formData['projekttyp_kurzbz'],
-			'firma_id' => $formData['firma_id'] ?? null,
-			'lehreinheit_id' => $formData['lehreinheit_id'],
-			'beginn' => isset($formData['beginn']) && !isEmptyString($formData['beginn']) ? $formData['beginn'] : null,
-			'ende' => isset($formData['ende']) && !isEmptyString($formData['ende']) ? $formData['ende'] : null,
-			'note' => $formData['note'] ?? null,
-			'final' => $formData['final'] ?? null,
-			'freigegeben' => $formData['freigegeben'] ?? null,
-			'anmerkung' => $formData['anmerkung'] ?? null,
-			'gesperrtbis' => isset($formData['gesperrtbis']) && !isEmptyString($formData['gesperrtbis']) ? $formData['gesperrtbis'] : null
-		];
-	}
-
-	/**
-	 *
-	 * @param
-	 * @return object success or error
-	 */
-	private function _validateDelete($projektarbeit_id)
-	{
-		$this->BetreuerModel->addSelect('1');
-		$result = $this->BetreuerModel->loadWhere(['projektarbeit_id' => $projektarbeit_id]);
-
-		if (isError($result)) return $result;
-
-		if (hasData($result)) return error($this->p->t('projektarbeit', 'error_betreuerNichtGeloescht'));
-
-		$this->PaabgabeModel->addSelect('1');
-		$result = $this->PaabgabeModel->loadWhere(['projektarbeit_id' => $projektarbeit_id]);
-
-		if (isError($result)) return $result;
-
-		if (hasData($result)) return error($this->p->t('projektarbeit', 'error_paabgabeNichtGeloescht'));
-
-		return success();
-	}
-
-	private function _hasBerechtigungForStudent($student_uid)
-	{
-		if (!$student_uid)
-			return false;
-
-		$this->load->model('crm/Student_model', 'StudentModel');
-
-		$this->StudentModel->addSelect('studiengang_kz');
-		$result = $this->StudentModel->load([$student_uid]);
-		if (isError($result) || !hasData($result))
-			return false;
-
-		$studiengang_kz = getData($result)[0]->studiengang_kz;
-
-		if ($this->permissionlib->isBerechtigt('admin', 'suid', $studiengang_kz))
-			return true;
-		if ($this->permissionlib->isBerechtigt('assistenz', 'suid', $studiengang_kz))
-			return true;
-
-		return false;
-	}
-}

application/controllers/api/frontend/v1/stv/Projektbetreuer.php

@@ -1,341 +0,0 @@
-<?php
-
-if (! defined('BASEPATH')) exit('No direct script access allowed');
-
-use \DateTime as DateTime;
-use CI3_Events as Events;
-
-class Projektbetreuer extends FHCAPI_Controller
-{
-	public function __construct()
-	{
-		parent::__construct([
-			'getProjektbetreuer' => ['admin:r', 'assistenz:r'],
-			'saveProjektbetreuer' => ['admin:rw', 'assistenz:rw'],
-			'deleteProjektbetreuer' => ['admin:rw', 'assistenz:rw'],
-			'getBetreuerarten' => ['admin:r', 'assistenz:r'],
-			'getNoten' => ['admin:r', 'assistenz:r'],
-			'getDefaultStundensaetze' => ['admin:r', 'assistenz:r'],
-			'getProjektbetreuerBySearchQuery' => ['admin:r', 'assistenz:r'],
-			'getPerson' => ['admin:r', 'assistenz:r'],
-			'validateProjektbetreuer' => ['admin:r', 'assistenz:r']
-		]);
-
-		// Load Libraries
-		$this->load->library('form_validation');
-
-		// Load language phrases
-		$this->loadPhrases([
-			'ui',
-			'person',
-			'projektarbeit'
-		]);
-
-		// Load models
-		$this->load->model('education/Projektbetreuer_model', 'ProjektbetreuerModel');
-		$this->load->model('education/Betreuerart_model', 'BetreuerartModel');
-		$this->load->model('ressource/Stundensatz_model', 'StundensatzModel');
-		$this->load->model('education/Projektarbeit_model', 'ProjektarbeitModel');
-		$this->load->model('education/Note_model', 'NoteModel');
-		$this->load->model('person/Person_model', 'PersonModel');
-
-		// load libraries
-		$this->load->library('PermissionLib');
-	}
-
-	public function getProjektbetreuer()
-	{
-		$projektarbeit_id = $this->input->get('projektarbeit_id');
-
-		if (!isset($projektarbeit_id))
-			$this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Projektarbeit ID']), self::ERROR_TYPE_GENERAL);
-
-		$this->ProjektbetreuerModel->addSelect(
-			'projektarbeit_id, person_id, nachname, vorname, note, punkte, round(stunden, 1) AS stunden,
-			stundensatz, betreuerart_kurzbz, vertrag_id, titelpre, titelpost'
-		);
-		$this->ProjektbetreuerModel->addSelect("CASE
-				WHEN EXISTS
-					(SELECT 1 FROM public.tbl_benutzer JOIN public.tbl_mitarbeiter ON(uid=mitarbeiter_uid) WHERE person_id=pers.person_id)
-				THEN 'Mitarbeiter'
-				WHEN EXISTS
-					(SELECT 1 FROM public.tbl_benutzer JOIN public.tbl_student ON(uid=student_uid) WHERE person_id=pers.person_id)
-				THEN 'Student'
-				ELSE 'Person'
-			END AS status");
-		$this->ProjektbetreuerModel->addJoin('public.tbl_person pers', 'person_id');
-		$result = $this->ProjektbetreuerModel->loadWhere(['projektarbeit_id' => $projektarbeit_id]);
-
-		if (isError($result)) $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		if (!hasData($result)) $this->terminateWithSuccess([]);
-
-		$projektbetreuer = getData($result);
-
-		//~ foreach ($projektbetreuer as $projektarbeit)
-		//~ {
-			//~ $projektarbeit_id = $projektarbeit->projektarbeit_id;
-			//~ $abgabeRes = $this->PaabgabeModel->getEndabgabe($projektarbeit_id);
-
-			//~ if (isError($abgabeRes)) $this->terminateWithError(getError($abgabeRes), self::ERROR_TYPE_GENERAL);
-
-			//~ if (hasData($abgabeRes))
-			//~ {
-				//~ $paabgabe = getData($abgabeRes)[0];
-				//~ $projektarbeit->abgabedatum = $paabgabe->abgabedatum;
-			//~ }
-		//~ }
-
-		foreach ($projektbetreuer as $pb)
-		{
-			$downloadLink = null;
-			Events::trigger(
-				'projektbeurteilung_download_link',
-				$pb->projektarbeit_id,
-				$pb->betreuerart_kurzbz,
-				$pb->person_id,
-				function ($value) use (&$downloadLink) {
-					$downloadLink = $value;
-				}
-			);
-			$pb->beurteilungDownloadLink = $downloadLink;
-		}
-
-		$this->terminateWithSuccess($this->_addFullNameToBetreuer($projektbetreuer));
-	}
-
-	public function saveProjektbetreuer()
-	{
-		$projektarbeit_id = $this->input->post('projektarbeit_id');
-
-		if (!isset($projektarbeit_id) || !is_numeric($projektarbeit_id))
-			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Projektarbeit ID']), self::ERROR_TYPE_GENERAL);
-
-		if (!$this->ProjektarbeitModel->hasBerechtigungForProjektarbeit($projektarbeit_id))
-			return $this->_outputAuthError([$this->router->method => ['admin:rw', 'assistenz:rw']]);
-
-		$projektbetreuer = $this->input->post('projektbetreuer');
-
-		if ($this->_validate($projektbetreuer) == false) $this->terminateWithValidationErrors($this->form_validation->error_array());
-
-		$result = null;
-
-		$betreuer = [
-			'projektarbeit_id' => $projektarbeit_id,
-			'person_id' => $projektbetreuer['person_id'],
-			'note' => $projektbetreuer['note'],
-			'stunden' => $projektbetreuer['stunden'],
-			'stundensatz' => $projektbetreuer['stundensatz'],
-			'betreuerart_kurzbz' => $projektbetreuer['betreuerart_kurzbz']
-		];
-
-		if (isset($projektbetreuer['person_id_old']) && isset($projektbetreuer['betreuerart_kurzbz_old']))
-		{
-			$result = $this->ProjektbetreuerModel->update(
-				[
-					'projektarbeit_id' => $projektarbeit_id,
-					'person_id' => $projektbetreuer['person_id_old'],
-					'betreuerart_kurzbz' => $projektbetreuer['betreuerart_kurzbz_old']
-				],
-				array_merge($betreuer, ['updateamum' => date('c'), 'updatevon' => getAuthUID()])
-			);
-		}
-		else
-		{
-			$result = $this->ProjektbetreuerModel->insert(
-				array_merge($betreuer, ['insertamum' => date('c'), 'insertvon' => getAuthUID()])
-			);
-		}
-
-		if (isError($result)) $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		$this->terminateWithSuccess(hasData($result) ? getData($result) : []);
-	}
-
-	public function deleteProjektbetreuer()
-	{
-		$projektarbeit_id = $this->input->post('projektarbeit_id');
-		$person_id = $this->input->post('person_id');
-		$betreuerart_kurzbz = $this->input->post('betreuerart_kurzbz');
-
-		if (!isset($projektarbeit_id) || !is_numeric($projektarbeit_id))
-			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> $this->p->t('projektarbeit', 'projektarbeit').' ID'], self::ERROR_TYPE_GENERAL));
-
-		if (!isset($person_id) || !is_numeric($person_id))
-			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Person ID'], self::ERROR_TYPE_GENERAL));
-
-		if (!isset($betreuerart_kurzbz))
-			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> $this->p->t('projektarbeit', 'betreuerart')], self::ERROR_TYPE_GENERAL));
-
-		if (!$this->ProjektarbeitModel->hasBerechtigungForProjektarbeit($projektarbeit_id))
-			return $this->_outputAuthError([$this->router->method => ['admin:rw', 'assistenz:rw']]);
-
-		$validate = $this->_validateDelete($projektarbeit_id, $person_id);
-
-		if (isError($validate)) return $this->terminateWithError(getError($validate), self::ERROR_TYPE_GENERAL);
-
-		$result = $this->ProjektbetreuerModel->delete(
-			['projektarbeit_id' => $projektarbeit_id, 'person_id' => $person_id, 'betreuerart_kurzbz' => $betreuerart_kurzbz]
-		);
-
-		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		if (!hasData($result))
-		{
-			$this->outputJson($result);
-		}
-
-		return $this->terminateWithSuccess(current(getData($result)) ? : null);
-	}
-
-	public function getBetreuerarten()
-	{
-		$result = $this->BetreuerartModel->loadWhere(['aktiv' => true]);
-
-		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		return $this->terminateWithSuccess(hasData($result) ? getData($result) : []);
-	}
-
-	public function getNoten()
-	{
-		$result = $this->NoteModel->load();
-
-		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		return $this->terminateWithSuccess(hasData($result) ? getData($result) : []);
-	}
-
-	public function getDefaultStundensaetze()
-	{
-		$person_id = $this->input->get('person_id');
-		$studiensemester_kurzbz = $this->input->get('studiensemester_kurzbz');
-
-		$result = $this->StundensatzModel->getStundensatzForMitarbeiter($person_id, $studiensemester_kurzbz);
-
-		return $this->terminateWithSuccess($result);
-	}
-
-	public function getProjektbetreuerBySearchQuery()
-	{
-		$searchString = $this->input->get('searchString');
-
-		if (!isset($searchString))
-			$this->terminateWithError($this->p->t('ui', 'error_fieldRequired', ['field' => 'Search term']), self::ERROR_TYPE_GENERAL);
-
-		$result = $this->PersonModel->searchPerson($searchString);
-
-		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		return $this->terminateWithSuccess(hasData($result) ? $this->_addFullNameToBetreuer(getData($result)) : []);
-	}
-
-	public function getPerson()
-	{
-		$person_id = $this->input->get('person_id');
-
-		if (!isset($person_id))
-			$this->terminateWithError($this->p->t('ui', 'error_fieldRequired', ['field' => 'Person']), self::ERROR_TYPE_GENERAL);
-
-		$this->PersonModel->addSelect("CASE
-				WHEN EXISTS
-					(SELECT 1 FROM public.tbl_benutzer JOIN public.tbl_mitarbeiter ON(uid=mitarbeiter_uid) WHERE person_id=tbl_person.person_id)
-				THEN 'Mitarbeiter'
-				WHEN EXISTS
-					(SELECT 1 FROM public.tbl_benutzer JOIN public.tbl_student ON(uid=student_uid) WHERE person_id=tbl_person.person_id)
-				THEN 'Student'
-				ELSE 'Person'
-			END AS status");
-		$result = $this->PersonModel->addSelect('titelpre, titelpost, vorname, nachname, person_id');
-		$result = $this->PersonModel->load($person_id);
-
-		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		return $this->terminateWithSuccess(hasData($result) ? $this->_addFullNameToBetreuer(getData($result))[0] : []);
-	}
-
-	/**
-	 *
-	 * @param
-	 * @return object success or error
-	 */
-	public function validateProjektbetreuer()
-	{
-		$projektbetreuerArr = $this->input->post('projektbetreuer');
-
-		if (!is_array($projektbetreuerArr)) $projektbetreuerArr = [$projektbetreuerArr];
-
-		foreach ($projektbetreuerArr as $pb)
-		{
-			if ($this->_validate($pb) == false)
-			{
-				$this->terminateWithValidationErrors($this->form_validation->error_array());
-			}
-		}
-
-		$this->terminateWithSuccess([]);
-	}
-
-	/**
-	 *
-	 * @param
-	 * @return object success or error
-	 */
-	private function _validate($formData)
-	{
-		$this->form_validation->set_data($formData);
-
-		$this->form_validation->set_rules('betreuerart_kurzbz', 'Betreuerart', 'required', [
-			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('projektarbeit', 'betreuerart')])
-		]);
-
-		$this->form_validation->set_rules('person_id', 'Person', 'required', [
-			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('projektarbeit', 'betreuer')])
-		]);
-
-		$this->form_validation->set_rules('stunden', 'Stunden', 'numeric', [
-			'numeric' => $this->p->t('ui', 'error_fieldNotNumeric', ['field' => $this->p->t('projektarbeit', 'stunden')])
-		]);
-
-		$this->form_validation->set_rules('stundensatz', 'Stundensatz', 'numeric', [
-			'numeric' => $this->p->t('ui', 'error_fieldNotNumeric', ['field' =>  $this->p->t('projektarbeit', 'stundensatz')])
-		]);
-
-
-		return $this->form_validation->run();
-	}
-
-	/**
-	 *
-	 * @param
-	 * @return object success or error
-	 */
-	private function _validateDelete($projektarbeit_id, $person_id)
-	{
-		$this->ProjektbetreuerModel->addSelect('vertrag_id');
-		$result = $this->ProjektbetreuerModel->loadWhere(['projektarbeit_id' => $projektarbeit_id, 'person_id' => $person_id]);
-
-		if (isError($result)) return $result;
-
-		if (hasData($result) && getData($result)[0]->vertrag_id != null) return error($this->p->t('projektarbeit', 'error_betreuerHatVertrag'));
-
-		return success();
-	}
-
-	/**
-	 *
-	 * @param
-	 * @return object success or error
-	 */
-	private function _addFullNameToBetreuer($betreuerArr)
-	{
-		foreach ($betreuerArr as $betreuer)
-		{
-			$betreuer->name = ($betreuer->titelpre ? $betreuer->titelpre . ' ' : '') .
-				$betreuer->nachname . ' ' . $betreuer->vorname . ($betreuer->titelpost ? ' ' . $betreuer->titelpre : '').
-				' (' . $betreuer->status . ')';
-		}
-
-		return $betreuerArr;
-	}
-}

application/controllers/api/frontend/v1/stv/Pruefung.php

@@ -18,8 +18,6 @@
 
 if (! defined('BASEPATH')) exit('No direct script access allowed');
 
-use \DateTime as DateTime;
-
 /**
  * This controller operates between (interface) the JS (GUI) and the back-end
  * Provides data to the ajax get calls about addresses
@@ -113,7 +111,7 @@ class Pruefung extends FHCAPI_Controller
 
 		// Load language phrases
 		$this->loadPhrases([
-			'global', 'ui', 'lehre', 'exam'
+			'global', 'ui','lehre'
 		]);
 	}
 
@@ -174,11 +172,174 @@ class Pruefung extends FHCAPI_Controller
 	 *
 	 * @param lehrveranstaltung_id, student_uid, lehreinheit_id
 	 *
-	 * @return void
+	 * @return values on success
+	 * 			retval 0: pruefung inserted
+	 * 			reval 1: pruefung and zeugnisnote inserted
+	 * 			retval 2: pruefung inserted, no insert Zeugnisnote
+	 * 					(change after date of examination)
+	 * 			retval 3: pruefung of type Termin2 inserted
+	 * 						and pruefung of type Termin1 as well
+	 *			retval 5: prueufungen Termin 2 and 1 inserted
+	 * 						and no insert Zeugnisnote (change after date of examination)
 	 */
 	public function insertPruefung()
 	{
-		$this->insertOrUpdatePruefung();
+		$authUID = getAuthUID();
+
+		$this->load->library('form_validation');
+
+		$this->form_validation->set_rules('lehrveranstaltung_id', $this->p->t('lehre', 'lehrveranstaltung'), 'required', [
+			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'lehrveranstaltung')]),
+		]);
+		$this->form_validation->set_rules('lehreinheit_id', $this->p->t('lehre', 'lehreinheit'), 'required', [
+			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'lehreinheit')]),
+		]);
+		$this->form_validation->set_rules('pruefungstyp_kurzbz', $this->p->t('lehre', 'pruefung'), 'required', [
+			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('global', 'typ')]),
+		]);
+		$this->form_validation->set_rules(
+			'datum',
+			$this->p->t('global', 'datum'),
+			['is_valid_date']
+		);
+
+		if ($this->form_validation->run() == false)
+		{
+			$this->terminateWithValidationErrors($this->form_validation->error_array());
+		}
+
+		//calculate studiensemester_kurzbz this from lehreinheit (case newPruefung)
+		$studiensemester_kurzbz = $this->input->post('studiensemester_kurzbz');
+		if (!$studiensemester_kurzbz)
+		{
+			$this->load->model('education/Lehreinheit_model', 'LehreinheitModel');
+
+			$result = $this->LehreinheitModel->load($this->input->post('lehreinheit_id'));
+
+			$lehreinheit = $this->getDataOrTerminateWithError($result);
+			$studiensemester_kurzbz = current($lehreinheit)->studiensemester_kurzbz;
+
+			if (isError($result))
+			{
+				$this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
+			}
+		}
+
+		$result = $this->PruefungModel->insert([
+			'lehreinheit_id' => $this->input->post('lehreinheit_id'),
+			'student_uid' => $this->input->post('student_uid'),
+			'mitarbeiter_uid' => $this->input->post('mitarbeiter_uid'),
+			'datum' => $this->input->post('datum'),
+			'pruefungstyp_kurzbz' => $this->input->post('pruefungstyp_kurzbz'),
+			'note' => $this->input->post('note'),
+			'anmerkung' => $this->input->post('anmerkung'),
+			'insertamum' => date('c'),
+			'insertvon' => $authUID,
+		]);
+
+		$this->getDataOrTerminateWithError($result);
+
+		//check if existing zeugnisnote
+		$this->load->model('education/Zeugnisnote_model', 'ZeugnisnoteModel');
+
+		$result = $this->ZeugnisnoteModel->loadWhere(array(
+			'lehrveranstaltung_id' => $this->input->post('lehrveranstaltung_id'),
+			'student_uid' => $this->input->post('student_uid'),
+			'studiensemester_kurzbz' => $studiensemester_kurzbz));
+
+		if (isError($result))
+		{
+			$this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
+		}
+
+		if (!hasData($result))
+		{
+			//insert zeugnisnote, if not existing
+			$result = $this->ZeugnisnoteModel->insert(array(
+				'lehrveranstaltung_id' => $this->input->post('lehrveranstaltung_id'),
+				'student_uid' => $this->input->post('student_uid'),
+				'studiensemester_kurzbz' => $studiensemester_kurzbz,
+				'note' => $this->input->post('note'),
+				'uebernahmedatum' => date('c'),
+				'benotungsdatum' => $this->input->post('datum'),
+				'insertamum' => date('c'),
+				'insertvon' =>  $authUID
+			));
+
+			if (isError($result))
+			{
+				$this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
+			}
+			$this->terminateWithSuccess(1);
+		}
+
+		$return_code = 0;
+
+		//handling Termin1 if not existing
+		if($this->input->post('pruefungstyp_kurzbz') == "Termin2")
+		{
+			$resultP = $this->PruefungModel->loadWhere(array(
+				'lehreinheit_id' => $this->input->post('lehreinheit_id'),
+				'student_uid' => $this->input->post('student_uid'),
+				'pruefungstyp_kurzbz' => 'Termin1'));
+
+			if (isError($resultP))
+			{
+				$this->terminateWithError(getError($resultP), self::ERROR_TYPE_GENERAL);
+			}
+			if(!hasData($resultP))
+			{
+				//check if existing Zeugnisnote
+				$this->load->model('education/Zeugnisnote_model', 'ZeugnisnoteModel');
+				$this->ZeugnisnoteModel->addJoin('lehre.tbl_lehreinheit', 'lehrveranstaltung_id');
+
+				$resultP = $this->ZeugnisnoteModel->loadWhere(array(
+					'lehrveranstaltung_id' => $this->input->post('lehrveranstaltung_id'),
+					'student_uid' => $this->input->input->post('student_uid'),
+					'lehre.tbl_zeugnisnote.studiensemester_kurzbz' => $studiensemester_kurzbz));
+				if (isError($resultP))
+				{
+					$this->terminateWithError(getError($resultP), self::ERROR_TYPE_GENERAL);
+				}
+				if (!hasData($resultP))
+				{
+					$this->terminateWithError("Zeugnisnote existiert nicht", self::ERROR_TYPE_GENERAL);
+				}
+				$dataNote = current(getData($resultP));
+
+				$resultN = $this->PruefungModel->insert([
+					'lehreinheit_id' => $this->input->post('lehreinheit_id'),
+					'student_uid' => $this->input->post('student_uid'),
+					'mitarbeiter_uid' => $this->input->post('mitarbeiter_uid'),
+					'datum' => $dataNote->benotungsdatum,
+					'pruefungstyp_kurzbz' => 'Termin1',
+					'note' => $dataNote->note,
+					'punkte' => $dataNote->punkte,
+					'anmerkung' => 'automatisiert aus Zeugnisnote erstellt',
+					'insertamum' => date('c'),
+					'insertvon' => $authUID,
+				]);
+
+				if (isError($resultN)) {
+					$this->terminateWithError(getError($resultN), self::ERROR_TYPE_GENERAL);
+				}
+				$return_code = 3;
+			}
+		}
+
+		$note = current(getData($result));
+		$uebernahmedatum = new DateTime($note->uebernahmedatum);
+		$benotungsdatum = new DateTime($note->benotungsdatum);
+
+		$checkDate = $uebernahmedatum  === '' || $benotungsdatum  > $uebernahmedatum
+			? $benotungsdatum
+			: $uebernahmedatum;
+
+		if ($checkDate >= $this->input->post('datum') && $note !== $note->note)
+		{
+			$this->terminateWithSuccess($return_code + 2);
+		}
+		$this->terminateWithSuccess($return_code + 2);
 	}
 
 	/**
@@ -187,6 +348,8 @@ class Pruefung extends FHCAPI_Controller
 	 * @param pruefung_id
 	 *
 	 * @return success or error
+	 *
+	 * no impact on lehre.tbl_zeugnisnote
 	 */
 	public function updatePruefung($pruefung_id)
 	{
@@ -196,7 +359,48 @@ class Pruefung extends FHCAPI_Controller
 		if (!$oldpruefung)
 			show_404(); // Pruefung that should be updated does not exist
 
-		$this->insertOrUpdatePruefung($pruefung_id);
+		$authUID = getAuthUID();
+
+		$this->load->library('form_validation');
+
+		$this->form_validation->set_rules('lehrveranstaltung_id', $this->p->t('lehre', 'lehrveranstaltung'), 'required', [
+			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'lehrveranstaltung')]),
+		]);
+		$this->form_validation->set_rules('lehreinheit_id', $this->p->t('lehre', 'lehreinheit'), 'required', [
+			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'lehreinheit')]),
+		]);
+		$this->form_validation->set_rules('pruefungstyp_kurzbz', $this->p->t('lehre', 'pruefung'), 'required', [
+			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('global', 'typ')]),
+		]);
+		$this->form_validation->set_rules(
+			'datum',
+			$this->p->t('global', 'datum'),
+			['is_valid_date']
+		);
+
+		if ($this->form_validation->run() == false)
+		{
+			$this->terminateWithValidationErrors($this->form_validation->error_array());
+		}
+
+		$result = $this->PruefungModel->update(
+			[
+				'pruefung_id' => $pruefung_id
+			],
+			[	'lehreinheit_id' => $this->input->post('lehreinheit_id'),
+				'student_uid' =>  $this->input->post('student_uid'),
+				'mitarbeiter_uid' =>  $this->input->post('mitarbeiter_uid'),
+				'note' => $this->input->post('note'),
+				'pruefungstyp_kurzbz' => $this->input->post('pruefungstyp_kurzbz'),
+				'datum' => $this->input->post('datum'),
+				'anmerkung' => $this->input->post('anmerkung'),
+				'updatevon' => $authUID,
+				'updateamum' => date('c'),
+			]
+		);
+		$this->getDataOrTerminateWithError($result);
+
+		return $this->outputJsonSuccess(true);
 	}
 
 	/**
@@ -370,198 +574,4 @@ class Pruefung extends FHCAPI_Controller
 
 		return $this->terminateWithSuccess($data);
 	}
-
-	protected function insertOrUpdatePruefung($pruefung_id=null)
-	{
-		$authUID = getAuthUID();
-
-		$this->load->library('form_validation');
-
-		$this->form_validation->set_rules('lehreinheit_id', $this->p->t('lehre', 'lehreinheit'), 'required', [
-			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'lehreinheit')]),
-		]);
-		$this->form_validation->set_rules('pruefungstyp_kurzbz', $this->p->t('lehre', 'pruefung'), 'required', [
-			'required' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('global', 'typ')]),
-		]);
-		$this->form_validation->set_rules(
-			'datum',
-			$this->p->t('global', 'datum'),
-			['is_valid_date']
-		);
-
-		if ($this->form_validation->run() == false)
-		{
-			$this->terminateWithValidationErrors($this->form_validation->error_array());
-		}
-
-		$this->load->model('education/Zeugnisnote_model', 'ZeugnisnoteModel');
-
-		$this->PruefungModel->db->trans_start();
-
-		if ($this->input->post('pruefungstyp_kurzbz') == "Termin2")
-		{
-			//Wenn ein 2. Termin angelegt wird, und kein 1. Termin vorhanden ist,
-			//dann wird auch ein 1. Termin angelegt mit der derzeitigen Zeugnisnote
-			$resultP = $this->PruefungModel->loadWhere(array(
-				'lehreinheit_id' => $this->input->post('lehreinheit_id'),
-				'student_uid' => $this->input->post('student_uid'),
-				'pruefungstyp_kurzbz' => 'Termin1'));
-
-			$termin1 = $this->getDataOrTerminateWithError($resultP);
-			if (!$termin1)
-			{
-				//check if existing Zeugnisnote
-				$this->ZeugnisnoteModel->addJoin('lehre.tbl_lehreinheit', 'lehrveranstaltung_id');
-
-				$this->ZeugnisnoteModel->db->where(
-					'lehre.tbl_zeugnisnote.studiensemester_kurzbz',
-					'lehre.tbl_lehreinheit.studiensemester_kurzbz',
-					false
-				);
-				$resultP = $this->ZeugnisnoteModel->loadWhere(array(
-					'lehrveranstaltung_id' => $this->input->post('lehrveranstaltung_id'),
-					'student_uid' => $this->input->post('student_uid')
-				));
-
-				$zeugnisnoten = $this->getDataOrTerminateWithError($resultP);
-				if ($zeugnisnoten)
-				{
-					$zeugnisnote = current($zeugnisnoten);
-
-					$resultN = $this->PruefungModel->insert([
-						'lehreinheit_id' => $this->input->post('lehreinheit_id'),
-						'student_uid' => $this->input->post('student_uid'),
-						'mitarbeiter_uid' => $this->input->post('mitarbeiter_uid'),
-						'datum' => $zeugnisnote->benotungsdatum,
-						'pruefungstyp_kurzbz' => 'Termin1',
-						'note' => $zeugnisnote->note,
-						'punkte' => $zeugnisnote->punkte,
-						'anmerkung' => 'automatisiert aus Zeugnisnote erstellt',
-						'insertamum' => date('c'),
-						'insertvon' => $authUID,
-					]);
-
-					$this->getDataOrTerminateWithError($resultN);
-				}
-				//Wenn keine Zeugnisnote vorhanden ist, dann wird kein
-				//1.Termin angelegt
-			}
-		}
-
-		if(intval($pruefung_id) > 0)
-		{
-			$result = $this->PruefungModel->update(
-				[
-					'pruefung_id' => $pruefung_id
-				],
-				[	'lehreinheit_id' => $this->input->post('lehreinheit_id'),
-					'student_uid' =>  $this->input->post('student_uid'),
-					'mitarbeiter_uid' =>  $this->input->post('mitarbeiter_uid'),
-					'note' => $this->input->post('note'),
-					'pruefungstyp_kurzbz' => $this->input->post('pruefungstyp_kurzbz'),
-					'datum' => $this->input->post('datum'),
-					'anmerkung' => $this->input->post('anmerkung'),
-					'updatevon' => $authUID,
-					'updateamum' => date('c'),
-				]
-			);
-		}
-		else
-		{
-			$result = $this->PruefungModel->insert([
-				'lehreinheit_id' => $this->input->post('lehreinheit_id'),
-				'student_uid' => $this->input->post('student_uid'),
-				'mitarbeiter_uid' => $this->input->post('mitarbeiter_uid'),
-				'datum' => $this->input->post('datum'),
-				'pruefungstyp_kurzbz' => $this->input->post('pruefungstyp_kurzbz'),
-				'note' => $this->input->post('note'),
-				'anmerkung' => $this->input->post('anmerkung'),
-				'insertamum' => date('c'),
-				'insertvon' => $authUID,
-				'punkte' => $this->input->post('punkte') ? str_replace(',', '.', $this->input->post('punkte')) : null
-			]);
-		}
-
-		$this->getDataOrTerminateWithError($result);
-
-		//get studiensemester_kurzbz and lehreveranstaltung_id from lehreinheit
-		$this->load->model('education/Lehreinheit_model', 'LehreinheitModel');
-
-		$result = $this->LehreinheitModel->load($this->input->post('lehreinheit_id'));
-
-		$lehreinheiten = $this->getDataOrTerminateWithError($result);
-
-		if (!$lehreinheiten) {
-			$this->terminateWithValidationErrors([
-				'lehreinheit_id' => $this->p->t('ui', 'error_fieldNotFound', [
-					'field' => $this->p->t('lehre', 'lehreinheit')
-				])
-			]);
-		}
-		$lehreinheit = current($lehreinheiten);
-		$studiensemester_kurzbz = $lehreinheit->studiensemester_kurzbz;
-		$lehrveranstaltung_id = $lehreinheit->lehrveranstaltung_id;
-
-		//check if existing zeugnisnote
-		$result = $this->ZeugnisnoteModel->loadWhere(array(
-			'lehrveranstaltung_id' => $lehrveranstaltung_id,
-			'student_uid' => $this->input->post('student_uid'),
-			'studiensemester_kurzbz' => $studiensemester_kurzbz
-		));
-
-		$zeugnisnoten = $this->getDataOrTerminateWithError($result);
-
-		if (!$zeugnisnoten)
-		{
-			//insert zeugnisnote, if not existing
-			$result = $this->ZeugnisnoteModel->insert(array(
-				'lehrveranstaltung_id' => $lehrveranstaltung_id,
-				'student_uid' => $this->input->post('student_uid'),
-				'studiensemester_kurzbz' => $studiensemester_kurzbz,
-				'note' => $this->input->post('note'),
-				'uebernahmedatum' => date('c'),
-				'benotungsdatum' => $this->input->post('datum'),
-				'insertamum' => date('c'),
-				'insertvon' =>  $authUID,
-				'punkte' => $this->input->post('punkte') ? str_replace(',', '.', $this->input->post('punkte')) : null
-			));
-
-			$this->getDataOrTerminateWithError($result);
-
-			$this->PruefungModel->db->trans_complete();
-			$this->terminateWithSuccess();
-		}
-
-		$note = current($zeugnisnoten);
-		$uebernahmedatum = new DateTime($note->uebernahmedatum);
-		$benotungsdatum = new DateTime($note->benotungsdatum);
-		$pruefungsdatum = new DateTime($this->input->post('datum'));
-
-		$checkDate = $note->uebernahmedatum === '' || $benotungsdatum > $uebernahmedatum
-			? $benotungsdatum
-			: $uebernahmedatum;
-
-		if ($checkDate > $pruefungsdatum && $this->input->post('note') !== $note->note)
-		{
-			$this->PruefungModel->db->trans_complete();
-			$this->terminateWithSuccess($this->p->t('exam', 'hinweis_changeAfterExamDate'));
-		}
-
-		//update zeugnisnote, if existing and valid datum
-		$result = $this->ZeugnisnoteModel->update([
-			'lehrveranstaltung_id' => $lehrveranstaltung_id,
-			'student_uid' => $this->input->post('student_uid'),
-			'studiensemester_kurzbz' => $studiensemester_kurzbz
-		], [
-			'note' => $this->input->post('note'),
-			'uebernahmedatum' => date('c'),
-			'benotungsdatum' => $this->input->post('datum'),
-			'updateamum' => date('c'),
-			'updatevon' =>  $authUID,
-			'punkte' => $this->input->post('punkte') ? str_replace(',', '.', $this->input->post('punkte')) : null
-		]);
-
-		$this->PruefungModel->db->trans_complete();
-		$this->terminateWithSuccess();
-	}
 }

application/controllers/api/frontend/v1/stv/Status.php

@@ -114,8 +114,9 @@ class Status extends FHCAPI_Controller
 		$this->load->model('codex/Bismeldestichtag_model', 'BismeldestichtagModel');
 
 		$result = $this->BismeldestichtagModel->getLastReachedMeldestichtag();
+		$data = $this->getDataOrTerminateWithError($result);
 
-		$this->terminateWithSuccess(hasData($result) ? getData($result) : array());
+		$this->terminateWithSuccess($data);
 	}
 
 	public function isLastStatus($prestudent_id)
@@ -295,7 +296,7 @@ class Status extends FHCAPI_Controller
 			}],
 			//Check if Rolle already exists
 			['rolle_doesnt_exist', function () use ($prestudent_id, $status_kurzbz, $studiensemester_kurzbz, $ausbildungssemester) {
-				if (!$status_kurzbz || !$studiensemester_kurzbz || !isset($ausbildungssemester) || $ausbildungssemester === '')
+				if (!$status_kurzbz || !$studiensemester_kurzbz || !$ausbildungssemester)
 					return true; // Error will be handled by the required statements above
 
 				$result = $this->PrestudentstatusModel->load([$ausbildungssemester, $studiensemester_kurzbz, $status_kurzbz, $prestudent_id]);
@@ -902,7 +903,7 @@ class Status extends FHCAPI_Controller
 
 		$this->form_validation->set_rules('_default', '', [
 			['rolle_doesnt_exist', function () use ($prestudent_id, $status_kurzbz, $studiensemester_kurzbz, $ausbildungssemester) {
-				if (!$status_kurzbz || !$studiensemester_kurzbz || !isset($ausbildungssemester) || $ausbildungssemester === '')
+				if (!$status_kurzbz || !$studiensemester_kurzbz || !$ausbildungssemester)
 					return true; // Error will be handled by the required statements above
 
 				$result = $this->PrestudentstatusModel->load([$ausbildungssemester, $studiensemester_kurzbz, $status_kurzbz, $prestudent_id]);
@@ -919,7 +920,7 @@ class Status extends FHCAPI_Controller
 			) {
 				if ($isBerechtigtNoStudstatusCheck)
 					return true; // Skip if access right says so
-				if (!$status_kurzbz || !$datum || !$studiensemester_kurzbz || !isset($ausbildungssemester) || $ausbildungssemester === '')
+				if (!$status_kurzbz || !$datum || !$studiensemester_kurzbz || !$ausbildungssemester)
 					return true; // Error will be handled by the required statements above
 
 				$result = $this->prestudentstatuschecklib->checkStatusHistoryTimesequence(
@@ -944,7 +945,7 @@ class Status extends FHCAPI_Controller
 			) {
 				if ($isBerechtigtNoStudstatusCheck)
 					return true; // Skip if access right says so
-				if (!$status_kurzbz || !$datum || !$studiensemester_kurzbz || !isset($ausbildungssemester) || $ausbildungssemester === '')
+				if (!$status_kurzbz || !$datum || !$studiensemester_kurzbz || !$ausbildungssemester)
 					return true; // Error will be handled by the required statements above
 
 				$result = $this->prestudentstatuschecklib->checkStatusHistoryLaststatus(
@@ -969,7 +970,7 @@ class Status extends FHCAPI_Controller
 			) {
 				if ($isBerechtigtNoStudstatusCheck)
 					return true; // Skip if access right says so
-				if (!$status_kurzbz || !$datum || !$studiensemester_kurzbz || !isset($ausbildungssemester) || $ausbildungssemester === '')
+				if (!$status_kurzbz || !$datum || !$studiensemester_kurzbz || !$ausbildungssemester)
 					return true; // Error will be handled by the required statements above
 
 				$result = $this->prestudentstatuschecklib->checkStatusHistoryUnterbrechersemester(
@@ -994,7 +995,7 @@ class Status extends FHCAPI_Controller
 			) {
 				if ($isBerechtigtNoStudstatusCheck)
 					return true; // Skip if access right says so
-				if (!$status_kurzbz || !$datum || !$studiensemester_kurzbz || !isset($ausbildungssemester) || $ausbildungssemester === '')
+				if (!$status_kurzbz || !$datum || !$studiensemester_kurzbz || !$ausbildungssemester)
 					return true; // Error will be handled by the required statements above
 
 				$result = $this->prestudentstatuschecklib->checkStatusHistoryAbbrechersemester(
@@ -1019,7 +1020,7 @@ class Status extends FHCAPI_Controller
 			) {
 				if ($isBerechtigtNoStudstatusCheck)
 					return true; // Skip if access right says so
-				if (!$status_kurzbz || !$datum || !$studiensemester_kurzbz || !isset($ausbildungssemester) || $ausbildungssemester === '')
+				if (!$status_kurzbz || !$datum || !$studiensemester_kurzbz || !$ausbildungssemester)
 					return true; // Error will be handled by the required statements above
 
 				$result = $this->prestudentstatuschecklib->checkStatusHistoryDiplomant(

application/controllers/api/frontend/v1/stv/Student.php

@@ -36,7 +36,6 @@ class Student extends FHCAPI_Controller
 		parent::__construct([
 			'get' => ['admin:r', 'assistenz:r'],
 			'save' => ['admin:rw', 'assistenz:rw'],
-			'saveStudent' => ['admin:rw', 'assistenz:rw'],
 			'check' => ['admin:rw', 'assistenz:rw'],
 			'add' => ['admin:rw', 'assistenz:rw'] // TODO(chris): extra permissions
 		]);
@@ -56,7 +55,7 @@ class Student extends FHCAPI_Controller
 
 		// Load language phrases
 		$this->loadPhrases([
-			'ui', 'lehre', 'person'
+			'ui', 'lehre'
 		]);
 	}
 
@@ -112,28 +111,16 @@ class Student extends FHCAPI_Controller
 		if (defined('ACTIVE_ADDONS') && strpos(ACTIVE_ADDONS, 'bewerbung') !== false) {
 			$this->PrestudentModel->addSelect(
 				"(
-					SELECT kontakt
-					FROM public.tbl_kontakt
-					WHERE kontakttyp='email'
-					AND person_id=p.person_id
-					AND zustellung
-					ORDER BY kontakt_id DESC
+					SELECT kontakt 
+					FROM public.tbl_kontakt 
+					WHERE kontakttyp='email' 
+					AND person_id=p.person_id 
+					AND zustellung 
+					ORDER BY kontakt_id 
 					LIMIT 1
 				) AS email_privat",
 				false
 			);
-			$this->PrestudentModel->addSelect(
-				"(
-					SELECT kontakt
-					FROM public.tbl_kontakt
-					WHERE kontakttyp='email_unverifiziert'
-					AND person_id=p.person_id
-					AND zustellung
-					ORDER BY kontakt_id DESC
-					LIMIT 1
-				) AS email_privat_unverified",
-				false
-			);
 		}
 		$this->PrestudentModel->addSelect(
 			"(
@@ -437,31 +424,6 @@ class Student extends FHCAPI_Controller
 		), ''));
 	}
 
-	/**
-	 * Saves data to a prestudent using their student_uid
-	 *
-	 * @param string			$student_uid
-	 * @param string			$studiensemester_kurzbz
-	 * @return void
-	 */
-	public function saveStudent($student_uid, $studiensemester_kurzbz)
-	{
-		$this->load->model('crm/Student_model', 'StudentModel');
-
-		$result = $this->StudentModel->load([$student_uid]);
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		if (!$data)
-			show_404(); // No Student with that ID
-
-		$student = current($data);
-
-		$this->checkPermissionsForPrestudent($student->prestudent_id, ['admin:rw', 'assistenz:rw']);
-
-		return $this->save($student->prestudent_id, $studiensemester_kurzbz);
-	}
-
 	public function check()
 	{
 		$this->load->library('form_validation');
@@ -503,6 +465,7 @@ class Student extends FHCAPI_Controller
 		if (!$this->input->post('person_id')) {
 			if (!isset($_POST['address']) || !is_array($_POST['address']))
 				$_POST['address'] = [];
+			$_POST['address']['func'] = 1;
 		}
 		if ($this->input->post('incoming')) {
 			$_POST['ausbildungssemester'] = 0;
@@ -511,37 +474,31 @@ class Student extends FHCAPI_Controller
 		$this->load->library('form_validation');
 
 		$this->form_validation->set_rules('nachname', 'Nachname', 'callback_requiredIfNotPersonId', [
-			'requiredIfNotPersonId' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'nachname')])
+			'requiredIfNotPersonId' => $this->p->t('ui', 'error_required')
 		]);
 		$this->form_validation->set_rules('geschlecht', 'Geschlecht', 'callback_requiredIfNotPersonId', [
-			'requiredIfNotPersonId' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'geschlecht')])
+			'requiredIfNotPersonId' => $this->p->t('ui', 'error_required')
 		]);
-		$this->form_validation->set_rules('gebdatum', 'Geburtsdatum', ['isValidDate', function($value) { return isValidDate($value); }], [
+		$this->form_validation->set_rules('gebdatum', 'Geburtsdatum', 'callback_isValidDate', [
 			'isValidDate' => $this->p->t('ui', 'error_invalid_date')
 		]);
 		$this->form_validation->set_rules('address[func]', 'Address', 'required|integer|less_than[2]|greater_than[-2]');
 		$this->form_validation->set_rules('address[plz]', 'PLZ', 'callback_requiredIfAddressFunc', [
-			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'plz')])
+			'requiredIfAddressFunc' => $this->p->t('ui', 'error_required')
 		]);
 		$this->form_validation->set_rules('address[gemeinde]', 'Gemeinde', 'callback_requiredIfAddressFunc', [
-			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'gemeinde')])
+			'requiredIfAddressFunc' => $this->p->t('ui', 'error_required')
 		]);
 		$this->form_validation->set_rules('address[ort]', 'Ort', 'callback_requiredIfAddressFunc', [
-			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'ort')])
+			'requiredIfAddressFunc' => $this->p->t('ui', 'error_required')
 		]);
 		$this->form_validation->set_rules('address[address]', 'Adresse', 'callback_requiredIfAddressFunc', [
-			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'adresse')])
+			'requiredIfAddressFunc' => $this->p->t('ui', 'error_required')
 		]);
 		$this->form_validation->set_rules('email', 'E-Mail', 'valid_email');
-		$this->form_validation->set_rules('studiengang_kz', 'Studiengang', 'callback_requiredIfStudentFunc', [
-			'requiredIfStudentFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'studiengang')])
-		]);
-		$this->form_validation->set_rules('studiensemester_kurzbz', 'Studiensemester', 'callback_requiredIfStudentFunc', [
-			'requiredIfStudentFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'studiensemester')])
-		]);
-		$this->form_validation->set_rules('ausbildungssemester', 'Ausbildungssemester', 'callback_requiredIfStudentFunc|integer|less_than[9]|greater_than[-1]', [
-			'requiredIfStudentFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'ausbildungssemester')])
-		]);
+		$this->form_validation->set_rules('studiengang_kz', 'Studiengang', 'required');
+		$this->form_validation->set_rules('studiensemester_kurzbz', 'Studiensemester', 'required');
+		$this->form_validation->set_rules('ausbildungssemester', 'Ausbildungssemester', 'required|integer|less_than[9]|greater_than[-1]');
 		// TODO(chris): validate studienplan with studiengang, semester and orgform?
 		// TODO(chris): validate person_id, studiengang_kz, studiensemester_kurzbz, orgform_kurzbz, nation, gemeinde, ort, geschlecht?
 
@@ -561,9 +518,7 @@ class Student extends FHCAPI_Controller
 		if ($this->db->trans_status() === FALSE)
 			$this->terminateWithError('TODO(chris): TEXT', self::ERROR_TYPE_GENERAL);
 
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
+		$this->terminateWithSuccess($result);
 	}
 
 	protected function addInteressent()
@@ -620,8 +575,6 @@ class Student extends FHCAPI_Controller
 				'zustelladresse' => true,
 			];
 			if ($anlegen < 0) { // Überschreiben
-				$this->AdresseModel->addSelect('adresse_id');
-				$this->AdresseModel->addJoin('public.tbl_adressentyp', 'typ = adressentyp_kurzbz');
 				$this->AdresseModel->addOrder('zustelladresse', 'DESC');
 				$this->AdresseModel->addOrder('sort');
 				$result = $this->AdresseModel->loadWhere([
@@ -678,74 +631,70 @@ class Student extends FHCAPI_Controller
 			}
 		}
 
-		$personOnly = $anlegen = $this->input->post('personOnly');
+		// Prestudent anlegen
+		$data = [
+			'aufmerksamdurch_kurzbz' => 'k.A.',
+			'person_id' => $person_id,
+			'studiengang_kz' => $this->input->post('studiengang_kz'),
+			'ausbildungcode' => $this->input->post('letzteausbildung'),
+			'anmerkung' => $this->input->post('anmerkungen'),
+			'reihungstestangetreten' => false,
+			'bismelden' => true
+		];
+		$ausbildungsart = $this->input->post('ausbildungsart');
+		if ($ausbildungsart)
+			$data['anmerkung'] .= ' Ausbildungsart:' . $ausbildungsart;
+		// Incomings und ausserordentliche sind bei Meldung nicht förderrelevant
+		$incoming = $this->input->post('incoming');
+		if ($incoming || substr($data['studiengang_kz'], 0, 1) == '9')
+			$data['foerderrelevant'] = false;
+		// Wenn die Person schon im System erfasst ist, dann die ZGV des Datensatzes uebernehmen
+		$this->PrestudentModel->addOrder('zgvmas_code');
+		$this->PrestudentModel->addOrder('zgv_code', 'DESC');
+		$this->PrestudentModel->addLimit(1);
+		$result = $this->PrestudentModel->loadWhere([
+			'person_id' => $person_id
+		]);
+		$prestudent = $this->getDataOrTerminateWithError($result);
+		if ($prestudent) {
+			$prestudent = current($prestudent);
+			if ($prestudent->zgv_code) {
+				$data['zgv_code'] = $prestudent->zgv_code;
+				$data['zgvort'] = $prestudent->zgvort;
+				$data['zgvdatum'] = $prestudent->zgvdatum;
 
-		if (!$personOnly)
-		{
-			// Prestudent anlegen
-			$data = [
-				'aufmerksamdurch_kurzbz' => 'k.A.',
-				'person_id' => $person_id,
-				'studiengang_kz' => $this->input->post('studiengang_kz'),
-				'ausbildungcode' => $this->input->post('letzteausbildung'),
-				'anmerkung' => $this->input->post('anmerkungen'),
-				'reihungstestangetreten' => false,
-				'bismelden' => true
-			];
-			$ausbildungsart = $this->input->post('ausbildungsart');
-			if ($ausbildungsart)
-				$data['anmerkung'] .= ' Ausbildungsart:' . $ausbildungsart;
-			// Incomings und ausserordentliche sind bei Meldung nicht förderrelevant
-			$incoming = $this->input->post('incoming');
-			if ($incoming || substr($data['studiengang_kz'], 0, 1) == '9')
-				$data['foerderrelevant'] = false;
-			// Wenn die Person schon im System erfasst ist, dann die ZGV des Datensatzes uebernehmen
-			$this->PrestudentModel->addOrder('zgvmas_code');
-			$this->PrestudentModel->addOrder('zgv_code', 'DESC');
-			$this->PrestudentModel->addLimit(1);
-			$result = $this->PrestudentModel->loadWhere([
-				'person_id' => $person_id
-			]);
-			$prestudent = $this->getDataOrTerminateWithError($result);
-			if ($prestudent) {
-				$prestudent = current($prestudent);
-				if ($prestudent->zgv_code) {
-					$data['zgv_code'] = $prestudent->zgv_code;
-					$data['zgvort'] = $prestudent->zgvort;
-					$data['zgvdatum'] = $prestudent->zgvdatum;
-
-					$data['zgvmas_code'] = $prestudent->zgvmas_code;
-					$data['zgvmaort'] = $prestudent->zgvmaort;
-					$data['zgvmadatum'] = $prestudent->zgvmadatum;
-				}
-			}
-			// Prestudent speichern
-			$result = $this->PrestudentModel->insert($data);
-			$prestudent_id = $this->getDataOrTerminateWithError($result);
-
-			// Prestudent Rolle Anlegen
-			$data = [
-				'prestudent_id' => $prestudent_id,
-				'status_kurzbz' => $incoming ? 'Incoming' : 'Interessent',
-				'studiensemester_kurzbz' => $this->input->post('studiensemester_kurzbz'),
-				'ausbildungssemester' => $this->input->post('ausbildungssemester') ?: 0,
-				'orgform_kurzbz' => $this->input->post('orgform_kurzbz') ?: null,
-				'studienplan_id' => $this->input->post('studienplan_id') ?: null,
-				'datum' => date('Y-m-d'),
-				'insertamum' => date('c'),
-				'insertvon' => getAuthUID()
-			];
-			$result = $this->PrestudentstatusModel->insert($data);
-			$this->getDataOrTerminateWithError($result);
-
-			if ($incoming) {
-				// TODO(chris): IMPLEMENT!
-				//Matrikelnummer und UID generieren
-				//Benutzerdatensatz anlegen
-				//Studentendatensatz anlegen
-				//StudentLehrverband anlegen
+				$data['zgvmas_code'] = $prestudent->zgvmas_code;
+				$data['zgvmaort'] = $prestudent->zgvmaort;
+				$data['zgvmadatum'] = $prestudent->zgvmadatum;
 			}
 		}
+		// Prestudent speichern
+		$result = $this->PrestudentModel->insert($data);
+		$prestudent_id = $this->getDataOrTerminateWithError($result);
+
+		// Prestudent Rolle Anlegen
+		$data = [
+			'prestudent_id' => $prestudent_id,
+			'status_kurzbz' => $incoming ? 'Incoming' : 'Interessent',
+			'studiensemester_kurzbz' => $this->input->post('studiensemester_kurzbz'),
+			'ausbildungssemester' => $this->input->post('ausbildungssemester') ?: 0,
+			'orgform_kurzbz' => $this->input->post('orgform_kurzbz') ?: null,
+			'studienplan_id' => $this->input->post('studienplan_id') ?: null,
+			'datum' => date('Y-m-d'),
+			'insertamum' => date('c'),
+			'insertvon' => getAuthUID()
+		];
+		$result = $this->PrestudentstatusModel->insert($data);
+		$this->getDataOrTerminateWithError($result);
+
+		if ($incoming) {
+			// TODO(chris): IMPLEMENT!
+			//Matrikelnummer und UID generieren
+			//Benutzerdatensatz anlegen
+			//Studentendatensatz anlegen
+			//StudentLehrverband anlegen
+		}
+
 		// TODO(chris): DEBUG
 		/*$result = $this->PrestudentModel->loadWhere([
 			'pestudent_id' => 1
@@ -754,7 +703,7 @@ class Student extends FHCAPI_Controller
 			return $result;
 		}*/
 
-		return success($person_id);
+		return success(true);
 	}
 
 	public function requiredIfNotPersonId($value)
@@ -766,14 +715,7 @@ class Student extends FHCAPI_Controller
 	
 	public function requiredIfAddressFunc($value)
 	{
-		if (!$_POST['address']['func'] || $_POST['address']['func'] == 0)
-			return true;
-		return !!$value;
-	}
-
-	public function requiredIfStudentFunc($value)
-	{
-		if ($_POST['personOnly'])
+		if (!$_POST['address']['func'])
 			return true;
 		return !!$value;
 	}

application/controllers/api/frontend/v1/stv/Students.php

@@ -44,12 +44,14 @@ class Students extends FHCAPI_Controller
 		}
 
 		// Load Libraries
+		$this->load->library('VariableLib', ['uid' => getAuthUID()]);
 		$this->load->library('PhrasesLib');
 		$this->loadPhrases(
 			array(
 				'lehre'
 			)
 		);
+
 	}
 
 	/**
@@ -73,7 +75,7 @@ class Students extends FHCAPI_Controller
 	 * /(studiengang_kz)/(orgform)/prestudent/(studiensemester_kurzbz)/(filter)					=> getPrestudentsOrgform
 	 * /(studiengang_kz)/(orgform)/prestudent/(studiensemester_kurzbz)/(filter)/(otherfilter)	=> getPrestudentsOrgform
 	 *
-	 * /(studiensemester_kurzbz)/(studiengang_kz)/(semester)/grp/(gruppe)	=> getStudentsSpezialgruppe
+	 * /(studiensemester_kurzbz)/(studiengang_kz)/(semester)/grp/(gruppe)	=> getStudentsSpezialguppe
 	 *
 	 * /(studiensemester_kurzbz)/(studiengang_kz)								=> getStudents
 	 * /(studiensemester_kurzbz)/(studiengang_kz)/(semester)					=> getStudents
@@ -99,183 +101,39 @@ class Students extends FHCAPI_Controller
 	}
 
 	/**
-	 * @param string		$studiensemester_kurzbz
-	 *
 	 * @return void
 	 */
-	public function getIncoming($studiensemester_kurzbz)
+	public function getIncoming()
 	{
 		$this->addMeta('ci_method', __FUNCTION__);
-		$this->addMeta('ci_params', [
-			'studiensemester_kurzbz' => $studiensemester_kurzbz
-		]);
-		
-
-		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
-
-
-		$this->PrestudentModel->addJoin(
-			"(
-				SELECT prestudent_id 
-				FROM public.tbl_prestudentstatus
-				WHERE status_kurzbz = 'Incoming'
-				AND studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
-			) test",
-			"prestudent_id"
-		);
-
-
-		$this->prepareQuery($studiensemester_kurzbz);
-
-		$this->PrestudentModel->addSelect("COALESCE(
-			v.semester::text, 
-			CASE 
-				WHEN pls.status_kurzbz IN ('Aufgenommener', 'Bewerber', 'Wartender', 'interessent') 
-				THEN pls.ausbildungssemester::text 
-				ELSE ''::text 
-			END
-		) AS semester", false);
-		$this->PrestudentModel->addSelect("COALESCE(v.verband::text, ''::text)");
-		$this->PrestudentModel->addSelect("COALESCE(v.gruppe::text, ''::text)");
-		
-		$this->addSelectPrioRel();
-
-		$this->addFilter($studiensemester_kurzbz);
-
-
-		$result = $this->PrestudentModel->load();
-		
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
+		// TODO(chris): IMPLEMENT!
+		$this->terminateWithSuccess([]);
 	}
 
 	/**
-	 * @param string		$studiensemester_kurzbz
-	 *
 	 * @return void
 	 */
-	public function getOutgoing($studiensemester_kurzbz)
+	public function getOutgoing()
 	{
 		$this->addMeta('ci_method', __FUNCTION__);
-		$this->addMeta('ci_params', [
-			'studiensemester_kurzbz' => $studiensemester_kurzbz
-		]);
-		
-
-		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
-
-
-		$this->PrestudentModel->addJoin(
-			"(
-				SELECT prestudent_id 
-				FROM bis.tbl_bisio bis 
-				JOIN public.tbl_student USING (student_uid)
-				JOIN public.tbl_studiensemester stdsem ON (
-					(bis.von >= stdsem.start AND bis.von <= stdsem.ende) 
-					OR 
-					(bis.bis >= stdsem.start AND bis.bis <= stdsem.ende) 
-					OR 
-					(bis.von <= stdsem.start AND bis.bis >= stdsem.ende)
-				)
-				WHERE NOT EXISTS (
-					SELECT 1 
-					FROM public.tbl_prestudentstatus 
-					WHERE status_kurzbz = 'Incoming'
-					AND prestudent_id = tbl_student.prestudent_id
-				) AND stdsem.studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
-				GROUP BY prestudent_id
-			) test",
-			"prestudent_id"
-		);
-
-
-		$this->prepareQuery($studiensemester_kurzbz);
-
-
-		$this->PrestudentModel->addSelect("COALESCE(
-			v.semester::text, 
-			CASE 
-				WHEN pls.status_kurzbz IN ('Aufgenommener', 'Bewerber', 'Wartender', 'interessent') 
-				THEN pls.ausbildungssemester::text 
-				ELSE ''::text 
-			END
-		) AS semester", false);
-		$this->PrestudentModel->addSelect("COALESCE(v.verband::text, ''::text)");
-		$this->PrestudentModel->addSelect("COALESCE(v.gruppe::text, ''::text)");
-		
-		$this->addSelectPrioRel();
-
-		$this->addFilter($studiensemester_kurzbz);
-
-
-		$result = $this->PrestudentModel->load();
-		
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
+		// TODO(chris): IMPLEMENT!
+		$this->terminateWithSuccess([]);
 	}
 
 	/**
-	 * @param string		$studiensemester_kurzbz
-	 *
 	 * @return void
 	 */
-	public function getGemeinsamestudien($studiensemester_kurzbz)
+	public function getGemeinsamestudien()
 	{
 		$this->addMeta('ci_method', __FUNCTION__);
-		$this->addMeta('ci_params', [
-			'studiensemester_kurzbz' => $studiensemester_kurzbz
-		]);
-		
-
-		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
-
-
-		$this->PrestudentModel->addJoin(
-			"(
-				SELECT prestudent_id
-				FROM bis.tbl_mobilitaet 
-				WHERE studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
-			) bis",
-			"prestudent_id"
-		);
-
-
-		$this->prepareQuery($studiensemester_kurzbz);
-
-
-		$this->PrestudentModel->addSelect("COALESCE(
-			v.semester::text, 
-			CASE 
-				WHEN pls.status_kurzbz IN ('Aufgenommener', 'Bewerber', 'Wartender', 'interessent') 
-				THEN pls.ausbildungssemester::text 
-				ELSE ''::text 
-			END
-		) AS semester", false);
-		$this->PrestudentModel->addSelect("COALESCE(v.verband::text, ''::text)");
-		$this->PrestudentModel->addSelect("COALESCE(v.gruppe::text, ''::text)");
-		
-		$this->addSelectPrioRel();
-
-		$this->addFilter($studiensemester_kurzbz);
-
-
-		$result = $this->PrestudentModel->load();
-		
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
+		// TODO(chris): IMPLEMENT!
+		$this->terminateWithSuccess([]);
 	}
 
-	public function getPrestudents(
-		$studiengang_kz,
-		$studiensemester_kurzbz = null,
-		$filter = null
-	) {
+	public function getPrestudents($studiengang_kz,
+		$studiensemester_kurzbz = null, $filter = null
+	)
+	{
 		$this->addMeta('ci_method', __FUNCTION__);
 		$this->addMeta('ci_params', array(
 			'studiengang_kz' => $studiengang_kz,
@@ -286,12 +144,10 @@ class Students extends FHCAPI_Controller
 		$this->fetchPrestudents($studiengang_kz, $studiensemester_kurzbz, $filter);
 	}
 
-	public function getPrestudentsOrgform(
-		$studiengang_kz,
-		$orgform_kurzbz,
-		$studiensemester_kurzbz = null,
-		$filter = null
-	) {
+	public function getPrestudentsOrgform($studiengang_kz, $orgform_kurzbz,
+		$studiensemester_kurzbz = null, $filter = null
+	)
+	{
 		$this->addMeta('ci_method', __FUNCTION__);
 		$this->addMeta('ci_params', array(
 			'studiengang_kz' => $studiengang_kz,
@@ -371,7 +227,7 @@ class Students extends FHCAPI_Controller
 
 				$stg = $this->getDataOrTerminateWithError($result);
 				if (!$stg)
-					$this->terminateWithSuccess([]);
+					$this->terminateWithValidationErrors(['' => 'Studiengang does not exist']); // TODO(chris): phrase
 				$stg = current($stg);
 
 				$where['ps.status_kurzbz'] = 'Interessent';
@@ -440,10 +296,7 @@ class Students extends FHCAPI_Controller
 				break;
 			default:
 				if (!$studiensemester_kurzbz) {
-					/** NOTE(chris):
-					 * show all prestudents in this stg who don't have a status
-					 * $orgform_kurzbz does not change the results since orgform is stored in the status table
-					 */
+					// TODO(chris): this does not work with $orgform_kurzbz != null
 					$where['ps.status_kurzbz'] = null;
 				} else {
 					$this->PrestudentModel->db->where_in('ps.status_kurzbz', [
@@ -457,18 +310,42 @@ class Students extends FHCAPI_Controller
 				break;
 		}
 
+		/*
+			$this->PrestudentModel->addJoin('public.tbl_studiengang stg', 'studiengang_kz', 'LEFT');
+			$this->PrestudentModel->addJoin('public.tbl_person p', 'person_id');
+			$this->PrestudentModel->addJoin('public.tbl_prestudentstatus pls', '
+				pls.status_kurzbz=public.get_rolle_prestudent(tbl_prestudent.prestudent_id, NULL) 
+				AND pls.prestudent_id=tbl_prestudent.prestudent_id 
+				AND pls.studiensemester_kurzbz=public.get_stdsem_prestudent(tbl_prestudent.prestudent_id, NULL) 
+				AND pls.ausbildungssemester=public.get_absem_prestudent(tbl_prestudent.prestudent_id, NULL)', 'LEFT');
+			$this->PrestudentModel->addJoin('lehre.tbl_studienplan sp', 'studienplan_id', 'LEFT');
+			$this->PrestudentModel->addJoin('public.tbl_prestudentstatus ps', '
+				ps.status_kurzbz=public.get_rolle_prestudent(tbl_prestudent.prestudent_id, ' . $stdsemEsc . ') 
+				AND ps.prestudent_id=tbl_prestudent.prestudent_id 
+				AND ps.studiensemester_kurzbz=public.get_stdsem_prestudent(tbl_prestudent.prestudent_id, ' . $stdsemEsc . ') 
+				AND ps.ausbildungssemester=public.get_absem_prestudent(tbl_prestudent.prestudent_id, ' . $stdsemEsc . ')', 'LEFT');*/
 		$this->prepareQuery($studiensemester_kurzbz);
 		
 		$this->PrestudentModel->addSelect("
-			CASE 
-				WHEN pls.status_kurzbz IN ('Aufgenommener', 'Bewerber', 'Wartender', 'interessent') 
-				THEN ps.ausbildungssemester::text 
-				ELSE ''::text 
-			END AS semester", false);
+			CASE WHEN ps.status_kurzbz IN ('Aufgenommener', 'Bewerber', 'Wartender', 'interessent') 
+			THEN ps.ausbildungssemester::text 
+			ELSE ''::text END AS semester", false);
 		$this->PrestudentModel->addSelect("'' AS verband");
 		$this->PrestudentModel->addSelect("'' AS gruppe");
 		$this->addSelectPrioRel();
 
+		//add status per semester
+		$this->PrestudentModel->addSelect(
+			"(
+				SELECT status_kurzbz
+				FROM public.tbl_prestudentstatus pss
+				WHERE pss.prestudent_id = public.tbl_prestudent.prestudent_id
+				  AND pss.studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
+				ORDER BY GREATEST(pss.datum, '0001-01-01') DESC
+				LIMIT 1
+				) AS statusofsemester"
+		);
+
 		$this->addFilter($studiensemester_kurzbz);
 
 		$result = $this->PrestudentModel->loadWhere($where);
@@ -478,13 +355,10 @@ class Students extends FHCAPI_Controller
 		$this->terminateWithSuccess($data);
 	}
 
-	public function getStudents(
-		$studiensemester_kurzbz,
-		$studiengang_kz,
-		$semester = null,
-		$verband = null,
-		$gruppe = null
-	) {
+	public function getStudents($studiensemester_kurzbz,
+		$studiengang_kz, $semester = null, $verband = null, $gruppe = null
+	)
+	{
 		$this->addMeta('ci_method', __FUNCTION__);
 		$this->addMeta('ci_params', array(
 			'studiensemester_kurzbz' => $studiensemester_kurzbz,
@@ -497,14 +371,10 @@ class Students extends FHCAPI_Controller
 		$this->fetchStudents($studiensemester_kurzbz, $studiengang_kz, $semester, $verband, $gruppe, null, null);
 	}
 
-	public function getStudentsOrgform(
-		$studiensemester_kurzbz,
-		$studiengang_kz,
-		$orgform_kurzbz,
-		$semester = null,
-		$verband = null,
-		$gruppe = null
-	) {
+	public function getStudentsOrgform($studiensemester_kurzbz,
+		$studiengang_kz, $orgform_kurzbz, $semester = null, $verband = null, $gruppe = null
+	)
+	{
 		$this->addMeta('ci_method', __FUNCTION__);
 		$this->addMeta('ci_params', array(
 			'studiensemester_kurzbz' => $studiensemester_kurzbz,
@@ -518,12 +388,10 @@ class Students extends FHCAPI_Controller
 		$this->fetchStudents($studiensemester_kurzbz, $studiengang_kz, $semester, $verband, $gruppe, null, $orgform_kurzbz);
 	}
 
-	public function getStudentsSpezialgruppe(
-		$studiensemester_kurzbz,
-		$studiengang_kz,
-		$semester,
-		$gruppe_kurzbz
-	) {
+	public function getStudentsSpezialgruppe($studiensemester_kurzbz,
+		$studiengang_kz, $semester, $gruppe_kurzbz,
+		$orgform_kurzbz = null)
+	{
 		$this->addMeta('ci_method', __FUNCTION__);
 		$this->addMeta('ci_params', array(
 			'studiensemester_kurzbz' => $studiensemester_kurzbz,
@@ -535,13 +403,10 @@ class Students extends FHCAPI_Controller
 		$this->fetchStudents($studiensemester_kurzbz, $studiengang_kz, $semester, null, null, $gruppe_kurzbz, null);
 	}
 
-	public function getStudentsOrgformSpezialgruppe(
-		$studiensemester_kurzbz,
-		$orgform_kurzbz,
-		$studiengang_kz,
-		$semester,
-		$gruppe_kurzbz
-	) {
+	public function getStudentsOrgformSpezialgruppe($studiensemester_kurzbz,
+		$orgform_kurzbz, $studiengang_kz, $semester, $gruppe_kurzbz
+	)
+	{
 		$this->addMeta('ci_method', __FUNCTION__);
 		$this->addMeta('ci_params', array(
 			'studiensemester_kurzbz' => $studiensemester_kurzbz,
@@ -565,15 +430,8 @@ class Students extends FHCAPI_Controller
 	 *
 	 * @return void
 	 */
-	protected function fetchStudents(
-		$studiensemester_kurzbz,
-		$studiengang_kz,
-		$semester = null,
-		$verband = null,
-		$gruppe = null,
-		$gruppe_kurzbz = null,
-		$orgform_kurzbz = null
-	) {
+	protected function fetchStudents($studiensemester_kurzbz, $studiengang_kz, $semester = null, $verband = null, $gruppe = null, $gruppe_kurzbz = null, $orgform_kurzbz = null)
+	{
 		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
 		$this->load->model('organisation/Studiensemester_model', 'StudiensemesterModel');
 
@@ -582,6 +440,21 @@ class Students extends FHCAPI_Controller
 			$this->terminateWithError($studiensemester_kurzbz . ' - ' . $this->p->t('lehre', 'error_noStudiensemester'));
 		}
 
+		/*
+			$this->PrestudentModel->addJoin('public.tbl_studiengang stg', 'studiengang_kz', 'LEFT');
+			$this->PrestudentModel->addJoin('public.tbl_person p', 'person_id');
+			$this->PrestudentModel->addJoin('public.tbl_student s', 'prestudent_id');
+			$this->PrestudentModel->addJoin('public.tbl_prestudentstatus pls', '
+				pls.status_kurzbz=public.get_rolle_prestudent(tbl_prestudent.prestudent_id, NULL) 
+				AND pls.prestudent_id=tbl_prestudent.prestudent_id 
+				AND pls.studiensemester_kurzbz=public.get_stdsem_prestudent(tbl_prestudent.prestudent_id, NULL) 
+				AND pls.ausbildungssemester=public.get_absem_prestudent(tbl_prestudent.prestudent_id, NULL)', 'LEFT');
+			$this->PrestudentModel->addJoin('lehre.tbl_studienplan sp', 'studienplan_id', 'LEFT');
+			$this->PrestudentModel->addJoin('public.tbl_benutzer b', 's.student_uid=b.uid');
+			$this->PrestudentModel->addJoin(
+				'public.tbl_studentlehrverband v',
+				'v.student_uid=s.student_uid AND v.studiensemester_kurzbz=' . $this->PrestudentModel->escape($studiensemester_kurzbz)
+			);*/
 		$this->prepareQuery($studiensemester_kurzbz, '');
 
 		$this->PrestudentModel->addSelect('v.semester');
@@ -589,6 +462,18 @@ class Students extends FHCAPI_Controller
 		$this->PrestudentModel->addSelect('v.gruppe');
 		$this->PrestudentModel->addSelect("'' AS priorisierung_relativ");
 
+		//add status per semester
+		$this->PrestudentModel->addSelect(
+			"(
+				SELECT status_kurzbz
+				FROM public.tbl_prestudentstatus pss
+				WHERE pss.prestudent_id = public.tbl_prestudent.prestudent_id
+				  AND pss.studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
+				ORDER BY GREATEST(pss.datum, '0001-01-01') DESC
+				LIMIT 1
+				) AS statusofsemester"
+		);
+
 
 		$where = [];
 
@@ -621,6 +506,7 @@ class Students extends FHCAPI_Controller
 					false
 				);
 			}
+
 		}
 
 		$this->addFilter($studiensemester_kurzbz);
@@ -654,18 +540,39 @@ class Students extends FHCAPI_Controller
 
 		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
 
+		/*
+			$this->PrestudentModel->addJoin('public.tbl_studiengang stg', 'studiengang_kz', 'LEFT');
+			$this->PrestudentModel->addJoin('public.tbl_person p', 'person_id');
+			$this->PrestudentModel->addJoin('public.tbl_student s', 'prestudent_id', 'LEFT');
+			$this->PrestudentModel->addJoin('public.tbl_prestudentstatus pls', '
+				pls.status_kurzbz=public.get_rolle_prestudent(tbl_prestudent.prestudent_id, NULL) 
+				AND pls.prestudent_id=tbl_prestudent.prestudent_id 
+				AND pls.studiensemester_kurzbz=public.get_stdsem_prestudent(tbl_prestudent.prestudent_id, NULL) 
+				AND pls.ausbildungssemester=public.get_absem_prestudent(tbl_prestudent.prestudent_id, NULL)', 'LEFT');
+			$this->PrestudentModel->addJoin('lehre.tbl_studienplan sp', 'studienplan_id', 'LEFT');
+			$this->PrestudentModel->addJoin('public.tbl_benutzer b', 's.student_uid=b.uid', 'LEFT');
+			$this->PrestudentModel->addJoin(
+				'public.tbl_studentlehrverband v',
+				'v.student_uid=s.student_uid AND v.studiensemester_kurzbz=' . $this->PrestudentModel->escape($studiensemester_kurzbz),
+				'LEFT'
+			);*/
 		$this->prepareQuery($studiensemester_kurzbz);
 
-		$this->PrestudentModel->addSelect("COALESCE(
-			v.semester::text, 
-			CASE 
-				WHEN pls.status_kurzbz IN ('Aufgenommener', 'Bewerber', 'Wartender', 'interessent') 
-				THEN pls.ausbildungssemester::text 
-				ELSE ''::text 
-			END
-		) AS semester", false);
-		$this->PrestudentModel->addSelect("COALESCE(v.verband::text, ''::text)");
-		$this->PrestudentModel->addSelect("COALESCE(v.gruppe::text, ''::text)");
+		$this->PrestudentModel->addSelect("COALESCE(v.semester::text, CASE WHEN public.get_rolle_prestudent(tbl_prestudent.prestudent_id, NULL) IN ('Aufgenommener', 'Bewerber', 'Wartender', 'interessent') THEN public.get_absem_prestudent(tbl_prestudent.prestudent_id, NULL)::text ELSE ''::text END) AS semester", false);
+		$this->PrestudentModel->addSelect('v.verband');
+		$this->PrestudentModel->addSelect('v.gruppe');
+
+		//add status per semester
+		$this->PrestudentModel->addSelect(
+			"(
+				SELECT status_kurzbz
+				FROM public.tbl_prestudentstatus pss
+				WHERE pss.prestudent_id = public.tbl_prestudent.prestudent_id
+				  AND pss.studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
+				ORDER BY GREATEST(pss.datum, '0001-01-01') DESC
+				LIMIT 1
+				) AS statusofsemester"
+		);
 
 		$this->addSelectPrioRel();
 
@@ -702,12 +609,40 @@ class Students extends FHCAPI_Controller
 
 		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
 
+		/*
+			$this->PrestudentModel->addJoin('public.tbl_studiengang stg', 'studiengang_kz', 'LEFT');
+			$this->PrestudentModel->addJoin('public.tbl_person p', 'person_id');
+			$this->PrestudentModel->addJoin('public.tbl_student s', 'prestudent_id');
+			$this->PrestudentModel->addJoin('public.tbl_prestudentstatus pls', '
+				pls.status_kurzbz=public.get_rolle_prestudent(tbl_prestudent.prestudent_id, NULL) 
+				AND pls.prestudent_id=tbl_prestudent.prestudent_id 
+				AND pls.studiensemester_kurzbz=public.get_stdsem_prestudent(tbl_prestudent.prestudent_id, NULL) 
+				AND pls.ausbildungssemester=public.get_absem_prestudent(tbl_prestudent.prestudent_id, NULL)', 'LEFT');
+			$this->PrestudentModel->addJoin('lehre.tbl_studienplan sp', 'studienplan_id', 'LEFT');
+			$this->PrestudentModel->addJoin('public.tbl_benutzer b', 's.student_uid=b.uid');
+			$this->PrestudentModel->addJoin(
+				'public.tbl_studentlehrverband v',
+				'v.student_uid=s.student_uid AND v.studiensemester_kurzbz=' . $this->PrestudentModel->escape($studiensemester_kurzbz),
+				'LEFT'
+			);*/
 		$this->prepareQuery($studiensemester_kurzbz);
 
 		$this->PrestudentModel->addSelect('v.semester');
 		$this->PrestudentModel->addSelect('v.verband');
 		$this->PrestudentModel->addSelect('v.gruppe');
 
+		//add status per semester
+		$this->PrestudentModel->addSelect(
+			"(
+				SELECT status_kurzbz
+				FROM public.tbl_prestudentstatus pss
+				WHERE pss.prestudent_id = public.tbl_prestudent.prestudent_id
+				  AND pss.studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
+				ORDER BY GREATEST(pss.datum, '0001-01-01') DESC
+				LIMIT 1
+				) AS statusofsemester"
+		);
+
 		$this->addSelectPrioRel();
 
 
@@ -746,59 +681,21 @@ class Students extends FHCAPI_Controller
 
 		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
 
+		/*
+			$this->PrestudentModel->addJoin('public.tbl_person p', 'person_id');
+			$this->PrestudentModel->addJoin('public.tbl_student s', 'prestudent_id');
+			$this->PrestudentModel->addJoin('public.tbl_benutzer b', 's.student_uid=b.uid');
+			$this->PrestudentModel->addJoin(
+				'public.tbl_studentlehrverband v',
+				'v.student_uid=s.student_uid AND v.studiensemester_kurzbz=' . $this->PrestudentModel->escape($studiensemester_kurzbz),
+				'LEFT'
+			);*/
 		$this->prepareQuery($studiensemester_kurzbz);
 
 		$this->PrestudentModel->addSelect('v.semester');
 		$this->PrestudentModel->addSelect('v.verband');
 		$this->PrestudentModel->addSelect('v.gruppe');
 
-		$this->addSelectPrioRel();
-
-		$this->addFilter($studiensemester_kurzbz);
-
-		$result = $this->PrestudentModel->loadWhere([
-			'p.person_id' => $person_id
-		]);
-		
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
-	}
-
-	/**
-	 * @param string		$studiensemester_kurzbz
-	 *
-	 * @return void
-	 */
-	public function search($studiensemester_kurzbz)
-	{
-		$this->addMeta('ci_method', __FUNCTION__);
-		$this->addMeta('ci_params', array(
-			'studiensemester_kurzbz' => $studiensemester_kurzbz
-		));
-
-		$this->load->library('SearchLib', [ 'config' => 'searchstv' ]);
-		$this->load->library('form_validation');
-
-		$this->form_validation->set_rules('searchstr', 'searchstr', 'required');
-		$this->form_validation->set_rules('types[]', 'types', 'required');
-
-		if (!$this->form_validation->run())
-			$this->terminateWithValidationErrors($this->form_validation->error_array());
-
-		$result = $this->searchlib->search($this->input->post('searchstr'), $this->input->post('types'));
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-
-		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
-
-		$this->prepareQuery($studiensemester_kurzbz);
-
-		$this->PrestudentModel->addSelect("COALESCE(v.semester::text, CASE WHEN public.get_rolle_prestudent(tbl_prestudent.prestudent_id, NULL) IN ('Aufgenommener', 'Bewerber', 'Wartender', 'interessent') THEN public.get_absem_prestudent(tbl_prestudent.prestudent_id, NULL)::text ELSE ''::text END) AS semester", false);
-		$this->PrestudentModel->addSelect('v.verband');
-		$this->PrestudentModel->addSelect('v.gruppe');
-
 		//add status per semester
 		$this->PrestudentModel->addSelect(
 			"(
@@ -815,31 +712,10 @@ class Students extends FHCAPI_Controller
 
 		$this->addFilter($studiensemester_kurzbz);
 
-		$prestudent_ids = [];
-		$student_uids = [];
-			$this->addMeta('data', $data);
-		foreach ($data as $row) {
-			$dataset = json_decode($row->data);
-			if ($row->type == 'prestudent') {
-				$prestudent_ids[] = $dataset->prestudent_id;
-			} elseif ($row->type == 'student') {
-				$student_uids[] = $dataset->uid;
-			}
-		}
-
-		if ($prestudent_ids && $student_uids) {
-			$this->PrestudentModel->db->where_in('tbl_prestudent.prestudent_id', $prestudent_ids);
-			$this->PrestudentModel->db->or_where_in('s.student_uid', $student_uids);
-		} elseif ($prestudent_ids) {
-			$this->PrestudentModel->db->where_in('tbl_prestudent.prestudent_id', $prestudent_ids);
-		} elseif ($student_uids) {
-			$this->PrestudentModel->db->where_in('s.student_uid', $student_uids);
-		} else {
-			$this->terminateWithSuccess([]);
-		}
-
-		$result = $this->PrestudentModel->load();
-
+		$result = $this->PrestudentModel->loadWhere([
+			'p.person_id' => $person_id
+		]);
+		
 		$data = $this->getDataOrTerminateWithError($result);
 
 		$this->terminateWithSuccess($data);
@@ -895,18 +771,6 @@ class Students extends FHCAPI_Controller
 		// verband
 		// gruppe
 
-		//add status per semester
-		$this->PrestudentModel->addSelect(
-			"(
-				SELECT status_kurzbz
-				FROM public.tbl_prestudentstatus pss
-				WHERE pss.prestudent_id = public.tbl_prestudent.prestudent_id
-				  AND pss.studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
-				ORDER BY GREATEST(pss.datum, '0001-01-01') DESC
-				LIMIT 1
-				) AS statusofsemester"
-		);
-
 		$this->PrestudentModel->addSelect('UPPER(stg.typ || stg.kurzbz) AS studiengang');
 		$this->PrestudentModel->addSelect('tbl_prestudent.studiengang_kz');
 		$this->PrestudentModel->addSelect('stg.bezeichnung AS stg_bezeichnung');
@@ -942,6 +806,13 @@ class Students extends FHCAPI_Controller
 		$this->PrestudentModel->addSelect('mentor');
 		$this->PrestudentModel->addSelect('b.aktiv AS bnaktiv');
 
+		/*$this->PrestudentModel->addSelect('tbl_prestudent.reihungstest_id');
+		$this->PrestudentModel->addSelect('tbl_prestudent.anmeldungreihungstest');
+		$this->PrestudentModel->addSelect('tbl_prestudent.gsstudientyp_kurzbz');
+		$this->PrestudentModel->addSelect('tbl_prestudent.priorisierung');
+		$this->PrestudentModel->addSelect('p.zugangscode');
+		$this->PrestudentModel->addSelect('p.bpk');*/
+
 		$this->PrestudentModel->db->where_in('tbl_prestudent.studiengang_kz', $this->allowedStgs);
 
 		$this->PrestudentModel->addOrder('nachname');
@@ -956,13 +827,13 @@ class Students extends FHCAPI_Controller
 		$this->PrestudentModel->addSelect("(
 			SELECT count(*)
 			FROM (
-				SELECT *, public.get_rolle_prestudent(pss.prestudent_id, NULL) AS laststatus
-				FROM public.tbl_prestudent pss
-				JOIN public.tbl_prestudentstatus USING (prestudent_id)
+				SELECT *, public.get_rolle_prestudent(tbl_prestudent.prestudent_id, NULL) AS laststatus
+				FROM PUBLIC.tbl_prestudent pss
+				JOIN PUBLIC.tbl_prestudentstatus USING (prestudent_id)
 				WHERE person_id = p.person_id
 				AND studiensemester_kurzbz = (
 					SELECT studiensemester_kurzbz
-					FROM public.tbl_prestudentstatus
+					FROM PUBLIC.tbl_prestudentstatus
 					WHERE prestudent_id = tbl_prestudent.prestudent_id
 					AND status_kurzbz = 'Interessent'
 					LIMIT 1
@@ -971,7 +842,7 @@ class Students extends FHCAPI_Controller
 			) prest
 			WHERE laststatus NOT IN ('Abbrecher', 'Abgewiesener', 'Absolvent')
 			AND priorisierung <= tbl_prestudent.priorisierung
-		) || ' (' || COALESCE(tbl_prestudent.priorisierung::text, ' '::text) || ')' AS priorisierung_relativ", false);
+		) || ' (' || tbl_prestudent.priorisierung || ')' AS priorisierung_relativ", false);
 	}
 
 	/**
@@ -983,20 +854,40 @@ class Students extends FHCAPI_Controller
 	 */
 	protected function addFilter($studiensemester_kurzbz)
 	{
-		$filter = $this->input->post('filter');
-		
+		$filter = json_decode($this->input->get('filter'), true);
 		if (!is_array($filter))
 		{
-			$this->addMeta('addfilter', 'invalid filter: ' . json_encode($this->input->post('filter')));
+			$this->addMeta('addfilter', 'invalid filter: ' . $this->input->get('filter'));
 			return;
 		}
-		foreach ($filter as $item) {
-			if (isset($item['usestdsem']) && $item['usestdsem'])
-				$item['studiensemester_kurzbz'] = $studiensemester_kurzbz;
-			if (!$this->PrestudentModel->addFilter($item)) {
-				$this->addMeta('addfilter', 'invalid filter: ' . json_encode($item));
-				return;
-			}
+		if (isset($filter['konto_count_0'])) {
+			$bt = $this->PrestudentModel->escape($filter['konto_count_0']);
+			$stdsem = $this->PrestudentModel->escape($studiensemester_kurzbz);
+
+			$this->PrestudentModel->db->where('(
+				SELECT count(*) 
+				FROM public.tbl_konto 
+				WHERE person_id=tbl_prestudent.person_id 
+				AND buchungstyp_kurzbz=' . $bt . ' 
+				AND studiensemester_kurzbz=' . $stdsem . '
+			) =', 0);
+			$this->PrestudentModel->db->where('get_rolle_prestudent(tbl_prestudent.prestudent_id, NULL) !=', 'Incoming');
+		}
+		if (isset($filter['konto_missing_counter'])) {
+			$bt = $this->PrestudentModel->escape($filter['konto_missing_counter']);
+			$stg = '';
+			if ($this->variablelib->getVar('kontofilterstg') == 'true')
+				$stg = ' AND studiengang_kz=tbl_prestudent.studiengang_kz';
+
+			$bt = $bt == 'alle' ? '' : ' AND buchungstyp_kurzbz=' . $bt;
+
+			$this->PrestudentModel->db->where('(
+				SELECT sum(betrag) 
+				FROM public.tbl_konto 
+				WHERE person_id=tbl_prestudent.person_id' .
+				$bt .
+				$stg . '
+			) !=', 0);
 		}
 	}
 }

application/controllers/api/frontend/v1/stv/Verband.php

@@ -165,17 +165,7 @@ class Verband extends FHCAPI_Controller
 		
 		$this->StudiengangModel->addDistinct();
 		$this->StudiengangModel->addSelect("CONCAT(" . $this->StudiengangModel->escape($link) . ", semester) AS link", false);
-		$this->StudiengangModel->addSelect("CONCAT(
-			UPPER(CONCAT(typ, kurzbz)), 
-			'-', 
-			semester, 
-			(
-				SELECT CASE WHEN bezeichnung IS NULL OR bezeichnung='' THEN ''::TEXT ELSE CONCAT(' (', bezeichnung, ')') END 
-				FROM public.tbl_lehrverband 
-				WHERE studiengang_kz=v.studiengang_kz AND semester=v.semester 
-				ORDER BY verband, gruppe LIMIT 1
-			)
-		) AS name", false);
+		$this->StudiengangModel->addSelect("CONCAT(UPPER(CONCAT(typ, kurzbz)), '-', semester, (SELECT CASE WHEN bezeichnung IS NULL OR bezeichnung='' THEN ''::TEXT ELSE CONCAT(' (', bezeichnung, ')') END FROM public.tbl_lehrverband WHERE studiengang_kz=v.studiengang_kz AND semester=v.semester ORDER BY verband, gruppe LIMIT 1)) AS name", false);
 
 		$this->StudiengangModel->addSelect('semester');
 		$this->StudiengangModel->addSelect($this->StudiengangModel->escape($studiengang_kz) . '::integer AS stg_kz', false);
@@ -183,7 +173,6 @@ class Verband extends FHCAPI_Controller
 		$this->StudiengangModel->addOrder('semester');
 
 		if ($org_form !== null) {
-			$this->StudiengangModel->addSelect("v.orgform_kurzbz");
 			$this->StudiengangModel->db->group_start();
 			$this->StudiengangModel->db->where('v.semester', 0);
 			$this->StudiengangModel->db->or_where('v.orgform_kurzbz', $org_form);
@@ -199,7 +188,6 @@ class Verband extends FHCAPI_Controller
 		array_unshift($list, [
 			'name' => 'PreStudent',
 			'link' => $link . 'prestudent',
-			'no_sem_reload' => true,
 			'stg_kz' => (int)$studiengang_kz,
 			'children' => $this->getStdSem($link . 'prestudent/', $studiengang_kz)
 		]);
@@ -228,6 +216,7 @@ class Verband extends FHCAPI_Controller
 					$list = array_merge($list, $result);
 				}
 			}
+
 		}
 		$this->terminateWithSuccess($list);
 	}
@@ -283,7 +272,6 @@ class Verband extends FHCAPI_Controller
 		$this->StudiengangModel->addSelect("CONCAT(UPPER(CONCAT(typ, kurzbz)), '-', semester, verband, (SELECT CASE WHEN bezeichnung IS NULL OR bezeichnung='' THEN ''::TEXT ELSE CONCAT(' (', bezeichnung, ')') END FROM public.tbl_lehrverband WHERE studiengang_kz=v.studiengang_kz AND semester=v.semester AND verband=v.verband ORDER BY gruppe LIMIT 1)) AS name", false);
 		$this->StudiengangModel->addSelect("CASE WHEN MAX(gruppe)='' OR MAX(gruppe)=' ' THEN TRUE ELSE FALSE END AS leaf");
 
-		$this->StudiengangModel->addSelect($this->StudiengangModel->escape($semester) . ' AS semester');
 		$this->StudiengangModel->addSelect('verband');
 		$this->StudiengangModel->addSelect($this->StudiengangModel->escape($studiengang_kz) . '::integer AS stg_kz', false);
 		
@@ -332,8 +320,6 @@ class Verband extends FHCAPI_Controller
 		$this->StudiengangModel->addSelect("CONCAT(UPPER(CONCAT(typ, kurzbz)), '-', semester, verband, gruppe, (SELECT CASE WHEN bezeichnung IS NULL OR bezeichnung='' THEN ''::TEXT ELSE CONCAT(' (', bezeichnung, ')') END FROM public.tbl_lehrverband WHERE studiengang_kz=v.studiengang_kz AND semester=v.semester AND verband=v.verband AND gruppe=v.gruppe ORDER BY gruppe LIMIT 1)) AS name", false);
 		$this->StudiengangModel->addSelect("TRUE AS leaf", false);
 
-		$this->StudiengangModel->addSelect('v.semester');
-		$this->StudiengangModel->addSelect('v.verband');
 		$this->StudiengangModel->addSelect('gruppe');
 		$this->StudiengangModel->addSelect($this->StudiengangModel->escape($studiengang_kz) . '::integer AS stg_kz', false);
 		

application/controllers/api/frontend/v1/stv/Vertrag.php

@@ -1,104 +0,0 @@
-<?php
-
-if (! defined('BASEPATH')) exit('No direct script access allowed');
-
-class Vertrag extends FHCAPI_Controller
-{
-	public function __construct()
-	{
-		parent::__construct([
-			'getVertrag' => ['admin:r', 'assistenz:r'],
-			'cancelVertrag' => ['admin:r', 'assistenz:r']
-		]);
-
-		// Load Libraries
-		$this->load->library('form_validation');
-
-		// Load language phrases
-		$this->loadPhrases([
-			'ui',
-			'person',
-			'projektarbeit'
-		]);
-
-		// Load models
-		$this->load->model('accounting/Vertrag_model', 'VertragModel');
-		$this->load->model('education/Lehrveranstaltung_model', 'LehrveranstaltungModel');
-		$this->load->model('person/Benutzer_model', 'BenutzerModel');
-
-		// load libraries
-		$this->load->library('PermissionLib');
-	}
-
-	public function getVertrag()
-	{
-		$vertrag_id = $this->input->get('vertrag_id');
-
-		if (!isset($vertrag_id) || !is_numeric($vertrag_id))
-			$this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Vertrag ID']), self::ERROR_TYPE_GENERAL);
-
-		$result = $this->VertragModel->getVertragById($vertrag_id);
-
-		if (isError($result))
-		{
-			$this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-		}
-
-		if (!hasData($result)) $this->terminateWithSuccess([]);
-
-		$vertrag = getData($result)[0];
-
-		$this->terminateWithSuccess($vertrag);
-	}
-
-	public function cancelVertrag()
-	{
-		$vertrag_id = $this->input->post('vertrag_id');
-		$person_id = $this->input->post('person_id');
-
-		if (!isset($vertrag_id) || !is_numeric($vertrag_id))
-			$this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Vertrag ID']), self::ERROR_TYPE_GENERAL);
-		if (!isset($person_id) || !is_numeric($person_id))
-			$this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Person ID']), self::ERROR_TYPE_GENERAL);
-
-		// * first find lehrveranstaltung_id of the contracts lehrveranstaltung
-		$this->VertragModel->addSelect('lehrveranstaltung_id');
-		$this->VertragModel->addJoin('lehre.tbl_lehrveranstaltung', 'lehrveranstaltung_id', 'LEFT');
-		$result = $this->VertragModel->loadWhere(['vertrag_id' => $vertrag_id]);
-
-		if (isError($result)) $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		if (!hasData($result)) $this->terminateWithSuccess([]);
-
-		$lehrveranstaltung_id = getData($result)[0]->lehrveranstaltung_id;
-
-		$allOe = $this->LehrveranstaltungModel->getAllOe($lehrveranstaltung_id);
-
-		if (isError($allOe)) $this->terminateWithError(getError($allOe), self::ERROR_TYPE_GENERAL);
-
-		$allOe = hasData($allOe) ? getData($allOe) : [];
-
-		$this->addMeta('oe', $allOe);
-
-		// * then check if the user has permissions to cancel the corresponding lv-organisational units
-		if (!$this->permissionlib->isBerechtigtMultipleOe('admin', $allOe, 'suid') &&
-			!$this->permissionlib->isBerechtigtMultipleOe('lehre/lehrauftrag_bestellen', $allOe, 'suid'))
-		{
-			return $this->_outputAuthError([$this->router->method => ['admin:rw', 'lehrauftrag_bestellen:rw']]);
-		}
-
-		$uidResult = $this->BenutzerModel->getFromPersonId($person_id);
-
-		if (isError($uidResult)) $this->terminateWithError(getError($uidResult), self::ERROR_TYPE_GENERAL);
-
-		if (!hasData($uidResult)) $this->terminateWithError("no user found", self::ERROR_TYPE_GENERAL);
-
-		$mitarbeiter_uid = getData($uidResult)[0]->uid;
-
-		$result = $this->VertragModel->cancelVertrag($vertrag_id, $mitarbeiter_uid);
-
-		$data = $this->getDataOrTerminateWithError($result);
-
-		$this->terminateWithSuccess($data);
-	}
-}

application/controllers/api/frontend/v1/vorlagen/Vorlagen.php

@@ -51,17 +51,13 @@ class Vorlagen extends FHCAPI_Controller
 		$this->load->model('person/Benutzerfunktion_model', 'BenutzerfunktionModel');
 		$result = $this->BenutzerfunktionModel->getBenutzerfunktionByUid($uid, 'oezuordnung');
 
-		if (hasData($result))
-		{
-			$data = getData($result);
+		$data = $this->getDataOrTerminateWithError($result);
+		$oe_kurzbz = current($data);
 
-			$oe_kurzbz = array_column($data, 'oe_kurzbz');
-			$result = $this->VorlageModel->getAllVorlagenByOe($oe_kurzbz);
-
-			$this->terminateWithSuccess(hasData($result) ? getData($result) : array());
-		}
-		$this->terminateWithSuccess(array());
+		$result = $this->VorlageModel->getAllVorlagenByOe($oe_kurzbz->oe_kurzbz);
+		$data = $this->getDataOrTerminateWithError($result);
 
+		$this->terminateWithSuccess($data);
 	}
 
 }

application/controllers/api/v1/person/Person.php

@@ -233,10 +233,10 @@ class Person extends API_Controller
 				//Quersumme bilden
 				for ($i = 0; $i < 10; $i++)
 				{
-					$erg += $gewichtung[$i] * $tmpSvnr[$i];
+					$erg += $gewichtung[$i] * $tmpSvnr{$i};
 				}
 
-				if ($tmpSvnr[3] != ($erg % 11)) //Vergleichen der Pruefziffer mit Quersumme Modulo 11
+				if ($tmpSvnr{3} != ($erg % 11)) //Vergleichen der Pruefziffer mit Quersumme Modulo 11
 				{
 					return error('SVNR ist ungueltig');
 				}
@@ -244,7 +244,7 @@ class Person extends API_Controller
 				if (mb_strlen($person['svnr']) == 12)
 				{
 					$last = substr($person['svnr'], 10, 12);
-					if ($last[0] != 'v' || !is_numeric($last[1]))
+					if ($last{0} != 'v' || !is_numeric($last{1}))
 					{
 						return error('SVNR ist ungueltig');
 					}

application/controllers/jobs/MeldezettelJob.php

@@ -1,86 +0,0 @@
-<?php
-
-if (!defined('BASEPATH')) exit('No direct script access allowed');
-
-class MeldezettelJob extends JOB_Controller
-{
-	const INSERT_VON = 'meldezetteljob';
-	const DOKUMENT_KURZBZ = 'Meldezet';
-
-	private $_ci; // Code igniter instance
-
-	public function __construct()
-	{
-		parent::__construct();
-
-		$this->_ci =& get_instance();
-
-		$this->_ci->load->model('crm/Dokumentprestudent_model', 'DokumentprestudentModel');
-	}
-
-	/**
-	 * Sets Meldezettel to "accepted" for all students with Meldeadresse.
-	 */
-	public function acceptMeldezettel()
-	{
-		$this->logInfo('Start Meldezettel Job');
-
-		$params = array(self::DOKUMENT_KURZBZ);
-
-		$qry = "
-			-- get all prestudents with meldeadresse, but no accepted Meldezettel
-			SELECT
-				DISTINCT prestudent_id
-			FROM
-				public.tbl_adresse
-				JOIN public.tbl_person USING (person_id)
-				JOIN public.tbl_prestudent ps USING (person_id)
-			WHERE
-				typ = 'm'
-				AND NOT EXISTS (
-					SELECT
-						1
-					FROM
-						public.tbl_dokumentprestudent
-					WHERE
-						prestudent_id = ps.prestudent_id
-						AND dokument_kurzbz = ?
-				)";
-
-		// get all prestudents with Meldeadresse and no accpeted Meldezettel
-		$result = $this->_ci->DokumentprestudentModel->execReadOnlyQuery($qry, $params);
-
-		if (isError($result))
-		{
-			$this->logError(getError($result));
-		}
-
-		$count = 0;
-
-		if (hasData($result))
-		{
-			$prestudents = getData($result);
-
-			foreach ($prestudents as $prestudent)
-			{
-				// set Meldezettel to accepted
-				$result = $this->_ci->DokumentprestudentModel->insert(
-					array(
-						'prestudent_id' => $prestudent->prestudent_id,
-						'dokument_kurzbz' => self::DOKUMENT_KURZBZ,
-						'datum' => date('Y-m-d'),
-						'insertamum' => strftime('%Y-%m-%d %H:%M'),
-						'insertvon' => self::INSERT_VON
-					)
-				);
-
-				if (isError($result))
-					$this->logError(getError($result));
-				else
-					$count++;
-			}
-		}
-
-		$this->logInfo('End Meldezettel Job', array('Number of changes ' => $count));
-	}
-}

application/controllers/system/infocenter/InfoCenter.php

@@ -22,7 +22,6 @@ class InfoCenter extends Auth_Controller
 	const REIHUNGSTESTABSOLVIERT_PAGE = 'reihungstestAbsolviert';
 	const ABGEWIESEN_PAGE = 'abgewiesen';
 	const AUFGENOMMEN_PAGE = 'aufgenommen';
-	const ONBOARDING_PAGE = 'onboarding';
 	const SHOW_DETAILS_PAGE = 'showDetails';
 	const SHOW_ZGV_DETAILS_PAGE = 'showZGVDetails';
 	const ZGV_UBERPRUEFUNG_PAGE = 'ZGVUeberpruefung';
@@ -117,7 +116,6 @@ class InfoCenter extends Auth_Controller
 				'index' => 'infocenter:r',
 				'freigegeben' => 'infocenter:r',
 				'abgewiesen' => 'infocenter:r',
-				'onboarding' => 'infocenter:r',
 				'aufgenommen' => 'infocenter:r',
 				'reihungstestAbsolviert' => 'infocenter:r',
 				'showDetails' => 'infocenter:r',
@@ -232,13 +230,6 @@ class InfoCenter extends Auth_Controller
 
 		$this->load->view('system/infocenter/infocenterAbgewiesen.php');
 	}
-
-	public function onboarding()
-	{
-		$this->_setNavigationMenu(self::ONBOARDING_PAGE); // define the navigation menu for this page
-
-		$this->load->view('system/infocenter/onboarding.php');
-	}
 	
 	/**
 	 * Aufgenommene page of the InfoCenter tool
@@ -1562,7 +1553,6 @@ class InfoCenter extends Auth_Controller
 		$reihungstestAbsolviertLink = site_url(self::INFOCENTER_URI.'/'.self::REIHUNGSTESTABSOLVIERT_PAGE);
 		$abgewiesenLink = site_url(self::INFOCENTER_URI.'/'.self::ABGEWIESEN_PAGE);
 		$aufgenommenLink = site_url(self::INFOCENTER_URI.'/'.self::AUFGENOMMEN_PAGE);
-		$onboardingLink = site_url(self::INFOCENTER_URI.'/'.self::ONBOARDING_PAGE);
 
 		$currentFilterId = $this->input->get(self::FILTER_ID);
 		if (isset($currentFilterId))
@@ -1571,7 +1561,6 @@ class InfoCenter extends Auth_Controller
 			$reihungstestAbsolviertLink .= '?'.self::PREV_FILTER_ID.'='.$currentFilterId;
 			$abgewiesenLink .= '?'.self::PREV_FILTER_ID.'='.$currentFilterId;
 			$aufgenommenLink .= '?'.self::PREV_FILTER_ID.'='.$currentFilterId;
-			$onboardingLink .= '?'.self::PREV_FILTER_ID.'='.$currentFilterId;
 		}
 
 		$this->navigationlib->setSessionMenu(
@@ -1635,18 +1624,6 @@ class InfoCenter extends Auth_Controller
 					'', 				// target
 					40   				// sort
 				),
-				'ohnePrestudent' => $this->navigationlib->oneLevel(
-					'Electronic Onboarding',		// description
-					$onboardingLink,	// link
-					null,				// children
-					'users',		// icon
-					null,				// subscriptDescription
-					false,				// expand
-					null,				// subscriptLinkClass
-					null, 				// subscriptLinkValue
-					'', 				// target
-					50   				// sort
-				),
 			)
 		);
 	}
@@ -1673,8 +1650,6 @@ class InfoCenter extends Auth_Controller
 			$link = site_url(self::ZGV_UEBERPRUEFUNG_URI);
 		if ($origin_page === self::ABGEWIESEN_PAGE)
 			$link = site_url(self::INFOCENTER_URI.'/'.self::ABGEWIESEN_PAGE);
-		if ($origin_page === self::ONBOARDING_PAGE)
-			$link = site_url(self::INFOCENTER_URI.'/'.self::ONBOARDING_PAGE);
 
 		if ($origin_page === self::AUFGENOMMEN_PAGE)
 			$link = site_url(self::INFOCENTER_URI.'/'.self::AUFGENOMMEN_PAGE);
@@ -1716,7 +1691,6 @@ class InfoCenter extends Auth_Controller
 		$freigegebenLink = site_url(self::INFOCENTER_URI.'/'.self::FREIGEGEBEN_PAGE);
 		$absolviertLink = site_url(self::INFOCENTER_URI.'/'.self::REIHUNGSTESTABSOLVIERT_PAGE);
 		$abgewiesenLink = site_url(self::INFOCENTER_URI.'/'.self::ABGEWIESEN_PAGE);
-		$onboardingLink = site_url(self::INFOCENTER_URI.'/'.self::ONBOARDING_PAGE);
 		$prevFilterId = $this->input->get(self::PREV_FILTER_ID);
 		if (isset($prevFilterId))
 		{
@@ -1793,24 +1767,6 @@ class InfoCenter extends Auth_Controller
 				)
 			);
 		}
-		if($page == self::ONBOARDING_PAGE)
-		{
-			$this->navigationlib->setSessionElementMenu(
-				'onboarding',
-				$this->navigationlib->oneLevel(
-					'Electronic Onboarding',		// description
-					$onboardingLink,	// link
-					null,				// children
-					'users',			// icon
-					null,				// subscriptDescription
-					false,				// expand
-					null,				// subscriptLinkClass
-					null, 				// subscriptLinkValue
-					'', 				// target
-					50   				// sort
-				)
-			);
-		}
 	}
 
 	/**

application/core/Auth_Controller.php

@@ -70,22 +70,20 @@ abstract class Auth_Controller extends FHC_Controller
 	/**
 	 * Checks for Permissions depending if the given person is a
 	 * Mitarbeiter and/or Student
-	 * If neither Student nor Mitarbeiter, default permissions are checked
 	 * and exits/outputs an error if they are not met.
 	 *
 	 * @param integer 				$person_id
 	 * @param array 				$permMa		Perms if the person is a Mitarbeiter
 	 * @param array 				$permStud	Perms if the person is a Student
-	 * @param array 				$permDefault	Perms if the person is neither a Student nor a Mitarbeiter
 	 *
 	 * @return void
 	 */
-	protected function checkPermissionsForPerson($person_id, $permMa, $permStud, $permDefault = null)
+	protected function checkPermissionsForPerson($person_id, $permMa, $permStud)
 	{
-		$res = $this->hasPermissionsForPerson($person_id, $permMa, $permStud, $permDefault);
-
+		$res = $this->hasPermissionsForPerson($person_id, $permMa, $permStud);
+		
 		if ($res) {
-			$perm = array_keys(array_flip(array_merge($res&1 ? $permMa : [], $res&2 ? $permStud : [], $res&4 ? $permDefault : [])));
+			$perm = array_keys(array_flip(array_merge($res|1 ? $permMa : [], $res|2 ? $permStud : [])));
 			$this->_outputAuthError([$this->router->method => $perm]);
 		}
 	}
@@ -110,19 +108,16 @@ abstract class Auth_Controller extends FHC_Controller
 	 * Checks for Permissions depending if the given person is a
 	 * Mitarbeiter and/or Student
 	 * and returns the result.
-	 * If neither Student nor Mitarbeiter, default permissions are checked
-	 * 
+	 *
 	 * @param integer 				$person_id
 	 * @param array 				$permMa		Perms if the person is a Mitarbeiter
 	 * @param array 				$permStud	Perms if the person is a Student
-	 * @param array 				$permDefault	Perms if the person is neither a Student nor a Mitarbeiter
+	 *
 	 * @return integer				0 if permission is granted
 	 */
-	protected function hasPermissionsForPerson($person_id, $permMa, $permStud, $permDefault)
+	protected function hasPermissionsForPerson($person_id, $permMa, $permStud)
 	{
-		$res = 8;
-		$isMitarbeiter = false;
-		$isStudent = false;
+		$res = 3;
 		$this->load->model('person/Person_model', 'PersonModel');
 		$this->PersonModel->addJoin('public.tbl_benutzer', 'person_id');
 		$this->PersonModel->addJoin('public.tbl_mitarbeiter', 'uid = mitarbeiter_uid');
@@ -130,8 +125,7 @@ abstract class Auth_Controller extends FHC_Controller
 		if (hasData($result)) {
 			if ($this->permissionlib->isEntitled(['a' => $permMa], 'a'))
 				return 0;
-			$isMitarbeiter = true;
-			$res += 1;
+			$res = 1;
 		}
 		$this->PersonModel->addJoin('public.tbl_prestudent', 'person_id');
 		$result = $this->PersonModel->load($person_id);
@@ -146,15 +140,8 @@ abstract class Auth_Controller extends FHC_Controller
 						return 0;
 				}
 			}
-			$isStudent = true;
 			$res += 2;
 		}
-		if (isset($permDefault) && !$isMitarbeiter && !$isStudent)
-		{
-			if ($this->permissionlib->isEntitled(['a' => $permDefault], 'a'))
-				return 0;
-			$res += 4;
-		}
 		return $res;
 	}
 

application/helpers/hlp_common_helper.php

@@ -515,73 +515,3 @@ function has_permissions_for_stg($studiengang_kz, $permissions = '')
 
 	return false;
 }
-
-/**
- * check if an entry exists in the database
- */
-function is_in_db($key, $model = '')
-{
-	if (!$model)
-		return false;
-
-	$field = strstr($model, ":");
-	if ($field) {
-		$model = strstr($model, ":", true);
-		$field = substr($field, 1);
-	}
-
-	$CI =& get_instance();
-	$CI->load->model($model, $model);
-
-	if ($field) {
-		$result = $CI->$model->loadWhere([
-			$field => $key
-		]);
-	} else {
-		$result = $CI->$model->load($key);
-	}
-
-	return (isSuccess($result) && hasData($result));
-}
-
-/**
- * is building an array for Dropdown Entry in Print Dropdown
- * @param $id id for the Document to add to the Document Array
- * @param $name title of the dropdownEntry
- * @param $parameterUrl url of parameters xml, xsl, format etc as needed
- * 	WITHOUT BASEURL eg. "xml=abschlusspruefung.rdf.php&xsl_stg_kz=$studiengang_kz&xsl=Bescheid&output=pdf"
- * @param $uid default parameter, if null only parameterurl will be added
- * 	additional needed parameter: put in the parameterUrl
- * @param $alternativeBaseUrl: if baseUrl not pdfExport.php, put here alternative without ? char, eg. "zutrittskarte.php"
- *
- * @return Array
- */
-function buildDropdownEntryPrintArray($id, $name, $parameterurl, $uid=null, $order=null, $alternativeBaseUrl=null)
-{
-	//DEFAULT BASEURL
-	$baseurl = "pdfExport.php?";
-
-	$uidString = $uid ? "&uid=" . $uid : "";
-
-
-
-	if($alternativeBaseUrl)
-	{
-		return [
-			"id"    => $id,
-			"type"  => "documenturl",
-			"name"  => $name,
-			"url"   => $alternativeBaseUrl . "?" . $parameterurl . $uidString,
-			"order" => $order
-		];
-	}
-	else
-		return [
-			"id"    => $id,
-			"type"  => "documenturl",
-			"name"  => $name,
-			"url"   => $baseurl . $parameterurl . "&uid=" . $uid,
-			"order" => $order
-		];
-
-}

application/helpers/hlp_header_helper.php

@@ -246,10 +246,3 @@ function generateSkipLink($skipID)
 	$toPrint.='" class="fhcSkipLink" aria-label="Skip to main content"></a>';
 	echo $toPrint;
 }
-
-function absoluteJsImportUrl($relurl)
-{
-	$ci =& get_instance();
-	$url = base_url($relurl) . '?'. $ci->config->item('fhcomplete_build_version');
-	return $url;
-}

application/language/english/form_validation_lang.php

@@ -41,4 +41,3 @@ if (!defined('BASEPATH')) exit('No direct script access allowed');
 $lang['form_validation_has_write_permissions']	= 'You have no rights to edit {field} field.';
 $lang['form_validation_is_valid_date']	= 'The date format is invalid or out of range.';
 $lang['form_validation_has_permissions_for_stg']	= 'You have no rights for stg {field}.';
-$lang['form_validation_is_in_db']	= '{field} does not exist.';

application/libraries/FilterCmptLib.php

@@ -1,7 +1,7 @@
 <?php
 
 /**
- * Copyright (C) 2025 fhcomplete.org
+ * Copyright (C) 2022 fhcomplete.org
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -177,7 +177,7 @@ class FilterCmptLib
 		$session = $this->getSession();
 
 		// If session is NOT empty -> a filter was already loaded
-		if (!isError($session) && $session != null)
+		if ($session != null)
 		{
 			// Retrieve the filterId stored in the session
 			$sessionFilterId = $this->_getSessionElement(FilterCmptLib::FILTER_ID);
@@ -219,7 +219,9 @@ class FilterCmptLib
 				}
 			}
 		}
-		else
+
+		// If the session is empty -> first time that this filter is loaded
+		if ($session == null)
 		{
 			// Load filter definition data from DB
 			$definition = $this->_loadDefinition(
@@ -600,7 +602,7 @@ class FilterCmptLib
 	{
 		$session = getSessionElement(self::SESSION_NAME, $this->_filterUniqueId);
 
-		if (!isError($session) && isset($session[$name]))
+		if (isset($session[$name]))
 		{
 			return $session[$name];
 		}
@@ -621,7 +623,7 @@ class FilterCmptLib
 
 		if (!$this->_ci->permissionlib->hasAtLeastOne($this->_requiredPermissions, self::PERMISSION_FILTER_METHOD, self::PERMISSION_TYPE))
 		{
-			$this->_setSession(error('The required permission is not held by the logged user'));
+			$this->_setSession(error('The required permission is not help by the logged user'));
 			return false;
 		}
 
@@ -902,7 +904,7 @@ class FilterCmptLib
 		$filterCmptsSession = getSession(self::SESSION_NAME);
 
 		// If something is present in session
-		if (!isError($filterCmptsSession) && $filterCmptsSession != null)
+		if ($filterCmptsSession != null)
 		{
 			// Loops in the session for all the filter components
 			foreach ($filterCmptsSession as $filterCmpt => $filterCmptData)
@@ -949,11 +951,9 @@ class FilterCmptLib
 	{
 		$session = getSessionElement(self::SESSION_NAME, $this->_filterUniqueId);
 
-		if (!isError($session) && $session != null)
-		{
-			$session[$name] = $value;
-			setSessionElement(self::SESSION_NAME, $this->_filterUniqueId, $session); // stores the single value
-		}
+		$session[$name] = $value;
+
+		setSessionElement(self::SESSION_NAME, $this->_filterUniqueId, $session); // stores the single value
 	}
 
 	/**
@@ -965,7 +965,7 @@ class FilterCmptLib
 		$filterCmptsSession = getSession(self::SESSION_NAME);
 
 		// If something is present in session
-		if (!isError($filterCmptsSession) && $filterCmptsSession != null)
+		if ($filterCmptsSession != null)
 		{
 			// Loops in the session for all the filter components
 			foreach ($filterCmptsSession as $filterCmpt => $filterCmptData)
@@ -1174,4 +1174,3 @@ class FilterCmptLib
 		return $filterName;
 	}
 }
-

application/libraries/LektorLib.php

@@ -17,7 +17,6 @@ class LektorLib
 		$this->_ci->load->model('organisation/Organisationseinheit_model', 'OrganisationseinheitModel');
 		$this->_ci->load->model('ressource/mitarbeiter_model', 'MitarbeiterModel');
 		$this->_ci->load->model('person/Benutzer_model', 'BenutzerModel');
-		$this->_ci->load->library('PhrasesLib', array('lehre'));
 	}
 
 	public function addLektorToLehreinheit($lehreinheit_id, $mitarbeiter_uid)
@@ -36,7 +35,7 @@ class LektorLib
 
 		if (isError($already_assigned)) return $already_assigned;
 
-		if (hasData($already_assigned)) return error($this->_ci->phraseslib->t("lehre", "bereitzugeteilt"));
+		if (hasData($already_assigned)) return error('Lektor already assigned');
 
 		$studiensemester_result = $this->_ci->StudiensemesterModel->loadWhere(array('studiensemester_kurzbz' => $lehreinheit->studiensemester_kurzbz));
 		if (isError($studiensemester_result)) return $studiensemester_result;
@@ -89,7 +88,6 @@ class LektorLib
 
 		$lehreinheit = getData($lehreinheit_result)[0];
 
-
 		//TODO kollision check, wird vorerst nicht implementiert -> nur über das FAS möglich
 		if (isset($new_data['mitarbeiter_uid']) && $new_data['mitarbeiter_uid'] !== $mitarbeiter_uid)
 		{
@@ -100,13 +98,7 @@ class LektorLib
 			$verplant = $this->_ci->StundenplandevModel->loadWhere(array('lehreinheit_id' => $lehreinheit_id, 'mitarbeiter_uid' => $mitarbeiter_uid));
 
 			if (hasData($verplant))
-				return error($this->_ci->phraseslib->t("lehre", "lektorbereitsverplant"));
-
-			$lehreinheit_data = $this->_ci->LehreinheitmitarbeiterModel->loadWhere(array('mitarbeiter_uid' => $new_data['mitarbeiter_uid'], 'lehreinheit_id' => $lehreinheit_id));
-
-			if (hasData($lehreinheit_data))
-				return error($this->_ci->phraseslib->t("lehre", "bereitzugeteilt"));
-
+				return error('Wechsel vom Mitarbeiter nicht möglich da er bereits verplant ist!');
 		}
 		$warning = '';
 		if (isset($new_data['semesterstunden']))

application/libraries/ProfilLib.php

@@ -183,10 +183,7 @@ class ProfilLib{
 		$zutrittskarte_ausgegebenam = $zutrittskarte_ausgegebenam ? current($zutrittskarte_ausgegebenam)->ausgegebenam : null;
 		
 		//? formats date from 01-01-2000 to 01.01.2000
-		if ($zutrittskarte_ausgegebenam !== NULL)
-		{
-			$zutrittskarte_ausgegebenam = (new DateTime($zutrittskarte_ausgegebenam))->format('d.m.Y');
-		}
+		$zutrittskarte_ausgegebenam = str_replace("-", ".", $zutrittskarte_ausgegebenam);
 		return $zutrittskarte_ausgegebenam;
 	}
 
@@ -199,7 +196,7 @@ class ProfilLib{
 	private function getAdressenInfo($pid)
 	{
 		$this->ci->load->model("person/Adresse_model","AdresseModel");
-		$adresse_res = $this->ci->AdresseModel->addSelect(["adresse_id", "strasse", "tbl_adressentyp.bezeichnung as typ", "plz", "ort", "heimatadresse", "zustelladresse", "gemeinde", "nation"]);
+		$adresse_res = $this->ci->AdresseModel->addSelect(["adresse_id", "strasse", "tbl_adressentyp.bezeichnung as typ", "plz", "ort", "zustelladresse", "gemeinde", "nation"]);
 		$adresse_res = $this->ci->AdresseModel->addOrder("zustelladresse", "DESC");
 		$adresse_res = $this->ci->AdresseModel->addJoin("tbl_adressentyp", "typ=adressentyp_kurzbz");
 

application/libraries/StundenplanLib.php

@@ -229,10 +229,9 @@ class StundenplanLib
 		$this->_ci->load->model('ressource/Stundenplan_model', 'StundenplanModel');
 
 		$is_mitarbeiter = getData($this->_ci->MitarbeiterModel->isMitarbeiter(getAuthUID()));
-
-		if ($is_mitarbeiter && empty($ort_kurzbz)) {
-			// request for personal lvplan show only reservations of logged in user
-			$reservierungen = $this->_ci->ReservierungModel->getReservierungenMitarbeiter($start_date, $end_date);
+		
+		if ($is_mitarbeiter) {
+			$reservierungen = $this->_ci->ReservierungModel->getReservierungenMitarbeiter($start_date, $end_date, $ort_kurzbz);
 		} else {
 			// querying the reservierungen
 			$reservierungen = $this->_ci->ReservierungModel->getReservierungen($start_date, $end_date, $ort_kurzbz);

application/models/accounting/Vertrag_model.php

@@ -402,26 +402,6 @@ class Vertrag_model extends DB_Model
 		return $this->loadWhere(array('mitarbeiter_uid' => $mitarbeiter_uid, 'lehreinheit_id' => $lehreinheit_id));
 	}
 
-	public function getVertragById($vertrag_id)
-	{
-		$this->addSelect(
-			'tbl_vertrag.vertrag_id, vertragstyp_kurzbz, vertragsstunden, vertragsstunden_studiensemester_kurzbz, status.vertragsstatus_kurzbz,
-			status.bezeichnung AS vertragsstatus, tbl_vertrag.betrag, lema.semesterstunden, lema.stundensatz'
-		);
-		$this->addJoin('lehre.tbl_lehreinheitmitarbeiter lema', 'tbl_vertrag.vertrag_id = lema.vertrag_id', 'LEFT');
-		$this->addJoin('
-			(
-				SELECT DISTINCT ON(vst.vertrag_id) vst.vertrag_id,
-					bezeichnung,
-					tbl_vertragsstatus.vertragsstatus_kurzbz
-				FROM lehre.tbl_vertrag_vertragsstatus vst
-					JOIN lehre.tbl_vertragsstatus USING(vertragsstatus_kurzbz)
-				ORDER BY vst.vertrag_id, datum DESC
-			) as status', 'status.vertrag_id = lehre.tbl_vertrag.vertrag_id', 'LEFT');
-
-		return $this->loadWhere(['tbl_vertrag.vertrag_id' => $vertrag_id]);
-	}
-
 	public function cancelVertrag($vertrag_id, $mitarbeiter_uid)
 	{
 		$vertrag = $this->load($vertrag_id);

application/models/crm/Prestudent_model.php

@@ -1,7 +1,5 @@
 <?php
 
-use CI3_Events as Events;
-
 class Prestudent_model extends DB_Model
 {
 	/**
@@ -784,118 +782,4 @@ class Prestudent_model extends DB_Model
 
 		return $this->execQuery($query, array($person_id));
 	}
-
-	/**
-	 * Adds a filter to the query builder
-	 *
-	 * @param array			$filter
-	 * @return boolean
-	 */
-	public function addFilter($filter)
-	{
-		if (!isset($filter['type']))
-			return false;
-
-		switch ($filter['type']) {
-			case 'konto':
-				$bt = '';
-				$stdsem = '';
-				$comp = '!=';
-
-				if (isset($filter['buchungstyp_kurzbz']) && $filter['buchungstyp_kurzbz'] != 'all')
-					$bt = ' AND buchungstyp_kurzbz=' . $this->escape($filter['buchungstyp_kurzbz']);
-				
-				if (isset($filter['studiensemester_kurzbz']))
-					$stdsem = ' AND studiensemester_kurzbz=' . $this->escape($filter['studiensemester_kurzbz']);
-
-				if (isset($filter['missing']) && $filter['missing']) {
-					$comp = '=';
-					$this->db->where('get_rolle_prestudent(tbl_prestudent.prestudent_id, NULL) !=', 'Incoming');
-				}
-
-				$this->db->where('(
-					SELECT count(*) 
-					FROM public.tbl_konto 
-					WHERE person_id=tbl_prestudent.person_id 
-					' . $bt . ' 
-					' . $stdsem . '
-				) ' . $comp, 0);
-				break;
-			
-			case 'konto_counter':
-				$bt = '';
-				$samestg = '';
-				$past = '';
-
-				if (isset($filter['buchungstyp_kurzbz']) && $filter['buchungstyp_kurzbz'] != 'all')
-					$bt = ' AND buchungstyp_kurzbz = ' . $this->escape($filter['buchungstyp_kurzbz']);
-				
-				if (isset($filter['samestg']) && $filter['samestg'])
-					$samestg = ' AND studiengang_kz = tbl_prestudent.studiengang_kz';
-
-				if (isset($filter['past']) && $filter['past'])
-					$past = ' AND buchungsdatum < NOW()';
-
-				$this->db->where('(
-					SELECT sum(betrag) 
-					FROM public.tbl_konto 
-					WHERE person_id = tbl_prestudent.person_id 
-					' . $bt . ' 
-					' . $samestg . '
-					' . $past . '
-				) !=', 0);
-				break;
-			
-			case 'zgv':
-				$this->db
-					->group_start()
-						->group_start()
-							->where('zgv_code IS NOT NULL')
-							->where('zgvdatum IS NULL')
-						->group_end()
-						->or_group_start()
-							->where('zgvmas_code IS NOT NULL')
-							->where('zgvmadatum IS NULL')
-						->group_end()
-						->or_group_start()
-							->where('zgvdoktor_code IS NOT NULL')
-							->where('zgvdoktordatum IS NULL')
-						->group_end()
-					->group_end();
-				break;
-			
-			case 'documents':
-				$this->db->where('(
-					SELECT count(*) 
-					FROM public.tbl_dokumentstudiengang 
-					WHERE dokument_kurzbz NOT IN (
-						SELECT dokument_kurzbz 
-						FROM tbl_dokumentprestudent 
-						WHERE prestudent_id=tbl_prestudent.prestudent_id
-					)
-					AND studiengang_kz=tbl_prestudent.studiengang_kz
-				) !=', 0);
-				break;
-
-			case 'statusgrund':
-				if (!isset($filter['statusgrund_id']))
-					return false;
-
-				if (isset($filter['studiensemester_kurzbz']))
-					$stdsem = ' AND studiensemester_kurzbz=' . $this->escape($filter['studiensemester_kurzbz']);
-
-				$this->db->where('(
-					SELECT count(*) 
-					FROM public.tbl_prestudentstatus 
-					WHERE prestudent_id = tbl_prestudent.prestudent_id 
-					AND statusgrund_id = ' . $this->escape($filter['statusgrund_id']) . '
-					' . $stdsem . '
-				) !=', 0);
-				break;
-		}
-
-		Events::trigger('prestudent_add_filter', $filter);
-
-		return true;
-	}
 }

application/models/education/Lehreinheit_model.php

@@ -651,13 +651,7 @@ EOSQL;
 											 ELSE NULL
 											 END
 									 END,
-								 ' ' 
-									ORDER BY
-										UPPER(tbl_studiengang.typ::varchar(1) || tbl_studiengang.kurzbz),
-										COALESCE(TRIM(tbl_lehreinheitgruppe.semester::text), ''),
-										COALESCE(TRIM(tbl_lehreinheitgruppe.verband), ''),
-										COALESCE(TRIM(tbl_lehreinheitgruppe.gruppe), ''),
-										COALESCE(tbl_lehreinheitgruppe.gruppe_kurzbz, '')
+								 ' '
 						 ) AS gruppen
 					 FROM lehre.tbl_lehreinheitgruppe
 						LEFT JOIN public.tbl_studiengang USING (studiengang_kz)

application/models/education/Lehreinheitgruppe_model.php

@@ -374,7 +374,7 @@ class Lehreinheitgruppe_model extends DB_Model
 			return success('Group assigned successfully to Lehreinheit');
 		}
 		else
-			return error($this->p->t('lehre', 'grpbereitszugeteilt'));
+			return error('Group already assigned');
 	}
 
 	public function deleteGroup($lehreinheit_id, $lehreinheitgruppe_id)
@@ -401,7 +401,7 @@ class Lehreinheitgruppe_model extends DB_Model
 		$stundenplan_result = $this->loadWhere(array('tbl_lehreinheitgruppe.lehreinheitgruppe_id' => $lehreinheitgruppe_id));
 
 		if (hasData($stundenplan_result))
-			return error($this->p->t('lehre', 'grpbereitsverplant'));
+			return error('Gruppe already verplant');
 
 		$delete_result = $this->delete($lehreinheitgruppe_id);
 

application/models/education/Lehrveranstaltung_model.php

@@ -1255,61 +1255,4 @@ class Lehrveranstaltung_model extends DB_Model
 
 		return $this->execReadOnlyQuery($qry, $params);
 	}
-
-	/**
-	 * Gets Lehrveranstaltungen for a student, as needed for a Projektarbeit.
-	 * @param student_uid
-	 * @param studiengang_kz optional, all Lvs of this Studiengang will be included 
-	 * @param additional_lehrveranstaltung_id optional, this lv will be added to result
-	 * @return object success or error
-	 */
-	public function getLvsForProjektarbeit($student_uid, $studiengang_kz = null, $additional_lehrveranstaltung_id = null)
-	{
-		$params = array($student_uid, $student_uid);
-
-		$qry = "
-			SELECT *
-			FROM
-				lehre.tbl_lehrveranstaltung
-			WHERE
-				(
-					lehrveranstaltung_id IN (
-
-						SELECT
-							lehrveranstaltung_id
-						FROM
-							campus.vw_student_lehrveranstaltung
-						WHERE
-							uid=?
-
-						UNION
-
-						SELECT
-							lehrveranstaltung_id
-						FROM
-							lehre.tbl_zeugnisnote
-						WHERE
-							student_uid=?
-					)";
-
-		if (isset($studiengang_kz))
-		{
-			$params[] = $studiengang_kz;
-			$qry .= " OR (studiengang_kz = ? AND semester IS NOT NULL)";
-		}
-
-		if (isset($additional_lehrveranstaltung_id))
-		{
-			$params[] = $additional_lehrveranstaltung_id;
-			$qry .= " OR lehrveranstaltung_id = ?";
-		}
-
-		$qry .= "
-				)
-				AND projektarbeit = TRUE
-			ORDER BY
-				semester, bezeichnung";
-
-		return $this->execQuery($qry, $params);
-	}
 }

application/models/education/Projektarbeit_model.php

@@ -24,16 +24,15 @@ class Projektarbeit_model extends DB_Model
 	public function getProjektarbeit($student_uid, $studiengang_kz = null, $studiensemester_kurzbz = null, $projekttyp = null, $final = null)
 	{
 		$qry = "SELECT
-					tbl_projektarbeit.*, tbl_projekttyp.bezeichnung,
-					tbl_lehreinheit.studiensemester_kurzbz, tbl_lehrveranstaltung.lehrveranstaltung_id,
-					tbl_firma.name AS firma_name
+					tbl_projektarbeit.* , tbl_projekttyp.bezeichnung
 				FROM
 					lehre.tbl_projektarbeit
-					JOIN lehre.tbl_projekttyp USING (projekttyp_kurzbz)
-					JOIN lehre.tbl_lehreinheit USING (lehreinheit_id)
-					JOIN lehre.tbl_lehrveranstaltung USING (lehrveranstaltung_id)
-					LEFT JOIN public.tbl_firma USING (firma_id)
+				JOIN
+					lehre.tbl_projekttyp USING (projekttyp_kurzbz), lehre.tbl_lehreinheit, lehre.tbl_lehrveranstaltung
+
 				WHERE
+					tbl_projektarbeit.lehreinheit_id=tbl_lehreinheit.lehreinheit_id AND
+					tbl_lehreinheit.lehrveranstaltung_id = tbl_lehrveranstaltung.lehrveranstaltung_id AND
 					tbl_projektarbeit.student_uid = ?";
 
 		$params = array($student_uid);
@@ -262,30 +261,4 @@ class Projektarbeit_model extends DB_Model
 		
 		return $this->execReadOnlyQuery($qry, array($projektarbeit_id));
 	}
-
-	/**
-	 *
-	 * @param
-	 * @return object success or error
-	 */
-	public function hasBerechtigungForProjektarbeit($projektarbeit_id)
-	{
-		if (!$projektarbeit_id || !is_numeric($projektarbeit_id))
-			return false;
-
-		$this->ProjektarbeitModel->addSelect('studiengang_kz');
-		$this->ProjektarbeitModel->addJoin('public.tbl_student', 'student_uid');
-		$result = $this->ProjektarbeitModel->load($projektarbeit_id);
-		if (isError($result) || !hasData($result))
-			return false;
-
-		$studiengang_kz = getData($result)[0]->studiengang_kz;
-
-		if ($this->permissionlib->isBerechtigt('admin', 'suid', $studiengang_kz))
-			return true;
-		if ($this->permissionlib->isBerechtigt('assistenz', 'suid', $studiengang_kz))
-			return true;
-
-		return false;
-	}
 }

application/models/education/Projektbetreuer_model.php

@@ -10,7 +10,6 @@ class Projektbetreuer_model extends DB_Model
 		parent::__construct();
 		$this->dbTable = 'lehre.tbl_projektbetreuer';
 		$this->pk = array('betreuerart_kurzbz', 'projektarbeit_id', 'person_id');
-		$this->hasSequence = false;
 	}
 
     /**

application/models/organisation/Studienplan_model.php

@@ -157,6 +157,7 @@ class Studienplan_model extends DB_Model
 		return $this->execReadOnlyQuery($qry, array($lv_id));
 	}
 
+
 	public function getStudienplaeneForPerson($person_id)
 	{
 		$this->addDistinct();

application/models/person/Kontaktverifikation_model.php

@@ -1,42 +0,0 @@
-<?php
-class Kontaktverifikation_model extends DB_Model
-{
-
-	/**
-	 * Constructor
-	 */
-	public function __construct()
-	{
-		parent::__construct();
-		$this->dbTable = 'public.tbl_kontakt_verifikation';
-		$this->pk = 'kontakt_verifikation_id';
-	}
-
-	/**
-	 * Gets contact verification for a person and a verification code
-	 * @param person_id
-	 * @param kontakttyp
-	 * @param verifikation_code
-	 * @param expiration_days number of days after which verifikation code expires
-	 * @return object success or error
-	 */
-	public function getKontaktVerifikation($person_id, $kontakttyp, $verifikation_code, $expiration_days = 1)
-	{
-		$qry = "
-			SELECT
-				kt.kontakt_id,
-				kv.verifikation_code
-			FROM
-				public.tbl_kontakt_verifikation kv
-				JOIN public.tbl_kontakt kt USING(kontakt_id)
-			WHERE kt.person_id = ?
-				AND kt.kontakttyp = ?
-				AND kv.verifikation_code = ?
-				AND kv.erstelldatum >= NOW() - INTERVAL '".$this->escape($expiration_days)." days'
-			ORDER BY
-				kt.kontakt_id DESC
-			LIMIT 1";
-
-		return $this->execQuery($qry, array($person_id, $kontakttyp, $verifikation_code));
-	}
-}

application/models/person/Notiz_model.php

@@ -207,6 +207,7 @@ class Notiz_model extends DB_Model
 			";
 
 		return $this->execQuery($qry, array($type, $id));
+
 	}
 
 

application/models/person/Person_model.php

@@ -151,21 +151,12 @@ class Person_model extends DB_Model
 	 */
 	public function searchPerson($filter)
 	{
-		$this->addSelect('vorname, nachname, gebdatum, person_id, titelpre, titelpost');
-		$this->addSelect("CASE
-				WHEN EXISTS
-					(SELECT 1 FROM public.tbl_benutzer JOIN public.tbl_mitarbeiter ON(uid=mitarbeiter_uid) WHERE person_id=tbl_person.person_id)
-				THEN 'Mitarbeiter'
-				WHEN EXISTS
-					(SELECT 1 FROM public.tbl_benutzer JOIN public.tbl_student ON(uid=student_uid) WHERE person_id=tbl_person.person_id)
-				THEN 'Student'
-				ELSE 'Person'
-			END AS status");
+		$this->addSelect('vorname, nachname, gebdatum, person_id');
 		$result = $this->loadWhere(
-			'lower(nachname) like '.$this->db->escape('%'.mb_strtolower($filter).'%')."
+			'lower(nachname) like '.$this->db->escape('%'.$filter.'%')."
 			OR lower(vorname) like ".$this->db->escape('%'.$filter.'%')."
-			OR lower(nachname || ' ' || vorname) like ".$this->db->escape('%'.mb_strtolower($filter).'%')."
-			OR lower(vorname || ' ' || nachname) like ".$this->db->escape('%'.mb_strtolower($filter).'%')
+			OR lower(nachname || ' ' || vorname) like ".$this->db->escape('%'.$filter.'%')."
+			OR lower(vorname || ' ' || nachname) like ".$this->db->escape('%'.$filter.'%')
 		);
 
 		return $result;
@@ -420,4 +411,4 @@ class Person_model extends DB_Model
 			return success($result);
 		}
 	}
-}
+}

application/models/person/Profil_update_model.php

@@ -63,7 +63,6 @@ class Profil_update_model extends DB_Model
 		$this->addSelect(["public.tbl_profil_update.*", "public.tbl_person.vorname"]);
 		$this->addJoin("public.tbl_benutzer", "public.tbl_benutzer.uid = public.tbl_profil_update.uid");
 		$this->addJoin("public.tbl_person", "public.tbl_person.person_id = public.tbl_benutzer.person_id");
-		$this->db->order_by('COALESCE(public.tbl_profil_update.updateamum, public.tbl_profil_update.insertamum)', 'DESC', false);
 		$res = $this->loadWhere($whereClause);
 		if (isError($res)) {
 			return $res;
@@ -119,47 +118,13 @@ class Profil_update_model extends DB_Model
 			$parameters = [];
 			$query = "
 			SELECT
-				profil_update_id,
-				tbl_profil_update.uid,
-				(tbl_person.vorname || ' ' || tbl_person.nachname) AS name ,
-				topic,
-				requested_change,
-				tbl_profil_update.updateamum,
-				tbl_profil_update.updatevon,
-				tbl_profil_update.insertamum,
-				tbl_profil_update.insertvon,
-				status,
-				public.tbl_profil_update_status.bezeichnung_mehrsprachig[(" . $lang . ")] as status_translated,
-				status_timestamp,
-				status_message,
-				attachment_id,
-				UPPER(public.tbl_studiengang.typ || public.tbl_studiengang.kurzbz) AS studiengang,
-				COALESCE(of.orgform_kurzbz, public.tbl_studiengang.orgform_kurzbz) AS orgform,
-				NULL as oezuordnung
+			profil_update_id, tbl_profil_update.uid, (tbl_person.vorname || ' ' || tbl_person.nachname) AS name , topic, requested_change, tbl_profil_update.updateamum, tbl_profil_update.updatevon, tbl_profil_update.insertamum, tbl_profil_update.insertvon, status, public.tbl_profil_update_status.bezeichnung_mehrsprachig[(" . $lang . ")] as status_translated, status_timestamp, status_message, attachment_id 
 			FROM public.tbl_profil_update
 			JOIN public.tbl_profil_update_status ON public.tbl_profil_update_status.status_kurzbz = public.tbl_profil_update.status 
 			JOIN public.tbl_student ON public.tbl_student.student_uid=public.tbl_profil_update.uid
 			JOIN public.tbl_benutzer ON public.tbl_benutzer.uid = public.tbl_student.student_uid
 			JOIN public.tbl_person ON public.tbl_benutzer.person_id=public.tbl_person.person_id
 			JOIN public.tbl_studiengang ON public.tbl_studiengang.studiengang_kz=public.tbl_student.studiengang_kz
-			LEFT JOIN (
-				select
-					pss.prestudent_id, COALESCE(sp.orgform_kurzbz, pss.orgform_kurzbz) as orgform_kurzbz
-				from (
-					select
-						prestudent_id, max(insertamum) as insertamum
-					from
-						public.tbl_prestudentstatus
-					where
-						datum <= NOW()
-					group by
-						prestudent_id
-				) mpss
-				join
-					public.tbl_prestudentstatus pss on pss.prestudent_id  = mpss.prestudent_id and pss.insertamum = mpss.insertamum
-				left join
-					lehre.tbl_studienplan sp on pss.studienplan_id = sp.studienplan_id
-			) of ON of.prestudent_id = public.tbl_student.prestudent_id
 			Where public.tbl_studiengang.oe_kurzbz IN ? ";
 			$parameters[] = $oe_berechtigung;
 			if ($whereClause) {
@@ -179,33 +144,12 @@ class Profil_update_model extends DB_Model
 			}
 		}
 		if ($mitarbeiterBerechtigung) {
-			$this->addSelect([
-				"profil_update_id",
-				"tbl_profil_update.uid",
-				"(tbl_person.vorname || ' ' || tbl_person.nachname) AS name",
-				"topic",
-				"requested_change",
-				"tbl_profil_update.updateamum",
-				"tbl_profil_update.updatevon",
-				"tbl_profil_update.insertamum",
-				"tbl_profil_update.insertvon",
-				"status",
-				"public.tbl_profil_update_status.bezeichnung_mehrsprachig[(" . $lang . ")] AS status_translated",
-				"status_timestamp",
-				"status_message",
-				"attachment_id",
-				"COALESCE(NULL) as studiengang",
-				"COALESCE(NULL) as orgform",
-				"oe.bezeichnung as oezuordnung"
-			]);
+			$this->addSelect(["profil_update_id", "tbl_profil_update.uid", "(tbl_person.vorname || ' ' || tbl_person.nachname) AS name", "topic", "requested_change", "tbl_profil_update.updateamum", "tbl_profil_update.updatevon", "tbl_profil_update.insertamum", "tbl_profil_update.insertvon", "status", "public.tbl_profil_update_status.bezeichnung_mehrsprachig[(" . $lang . ")] AS status_translated", "status_timestamp", "status_message", "attachment_id"]);
 			$this->addJoin('tbl_profil_update_status', 'tbl_profil_update_status.status_kurzbz=tbl_profil_update.status');
 			$this->addJoin('tbl_mitarbeiter', 'tbl_mitarbeiter.mitarbeiter_uid=tbl_profil_update.uid');
 			$this->addJoin('tbl_benutzer', 'tbl_benutzer.uid=tbl_profil_update.uid');
 			$this->addJoin('tbl_person', 'tbl_benutzer.person_id=tbl_person.person_id');
-			$this->addJoin('tbl_benutzerfunktion bf', 'bf.uid = tbl_benutzer.uid AND bf.funktion_kurzbz = \'oezuordnung\' AND NOW() >= COALESCE(bf.datum_von, \'1970-01-01\'::date) AND NOW() <= COALESCE(bf.datum_bis, \'2170-12-31\'::date)', 'LEFT');
-			$this->addJoin('tbl_organisationseinheit oe', 'oe.oe_kurzbz = bf.oe_kurzbz', 'LEFT');
 			$mitarbeiterRequests = $this->loadWhere($whereClause);
-
 			if (isError($mitarbeiterRequests))
 				return error("db error: " . getData($mitarbeiterRequests));
 			$mitarbeiterRequests = getData($mitarbeiterRequests) ?: [];
@@ -235,11 +179,8 @@ class Profil_update_model extends DB_Model
 	private function formatProfilRequest($request)
 	{
 		$request->requested_change = json_decode($request->requested_change);
-		$request->insertamum_iso = !is_null($request->insertamum) ? date_create($request->insertamum)->format('Y-m-d') : null;
 		$request->insertamum = !is_null($request->insertamum) ? date_create($request->insertamum)->format('d.m.Y') : null;
-		$request->updateamum_iso = !is_null($request->updateamum) ? date_create($request->updateamum)->format('Y-m-d') : null;
 		$request->updateamum = !is_null($request->updateamum) ? date_create($request->updateamum)->format('d.m.Y') : null;
-		$request->status_timestamp_iso = !is_null($request->status_timestamp) ? date_create($request->status_timestamp)->format('Y-m-d') : null;
 		$request->status_timestamp = !is_null($request->status_timestamp) ? date_create($request->status_timestamp)->format('d.m.Y') : null;
 	}
 

application/models/ressource/Firma_model.php

@@ -12,24 +12,17 @@ class Firma_model extends DB_Model
 		$this->pk = 'firma_id';
 	}
 
-	public function searchFirmen($filter, $aktiv = null)
+	public function searchFirmen($filter)
 	{
-		$params = [];
 		$filter = strtoLower($filter);
 		$qry = "
-			SELECT
+			SELECT 
 				f.name, f.firma_id
-			FROM
-				public.tbl_firma f
-			WHERE
-				lower (f.name) LIKE '%". $this->db->escape_like_str($filter)."%'";
+			FROM 
+			    public.tbl_firma f
+			WHERE 
+			    lower (f.name) LIKE '%". $this->db->escape_like_str($filter)."%'";
 
-			if (isset($aktiv) && is_bool($aktiv))
-			{
-				$params[] = $aktiv;
-				$qry .= " AND aktiv = ?";
-			}
-
-		return $this->execQuery($qry, $params);
+		return $this->execQuery($qry);
 	}
 }

application/models/ressource/Mitarbeiter_model.php

@@ -353,14 +353,12 @@ class Mitarbeiter_model extends DB_Model
 	{
 		$filter = strtoLower($filter);
 
-		$returnwert = "p.person_id, p.nachname, p.vorname, p.titelpost,  p.titelpre";
-
 		if ($mode == "mitAkadGrad")
-			$returnwert .= ", ma.mitarbeiter_uid, CONCAT(p.nachname, ' ', p.vorname, ' ', p.titelpost, ' ', p.titelpre, ' (', ma.mitarbeiter_uid , ')') as mitarbeiter";
+			$returnwert = "ma.mitarbeiter_uid, CONCAT(p.nachname, ' ', p.vorname, ' ', p.titelpost, ' ', p.titelpre, ' (', ma.mitarbeiter_uid , ')') as mitarbeiter";
 		elseif ($mode == "ohneMaUid")
-			$returnwert .= ", CONCAT(p.nachname, ' ', p.vorname, ' ', p.titelpost, ' ', p.titelpre) as mitarbeiter";
+			$returnwert = "p.person_id, CONCAT(p.nachname, ' ', p.vorname, ' ', p.titelpost, ' ', p.titelpre) as mitarbeiter";
 		else
-			$returnwert .= ", ma.mitarbeiter_uid, CONCAT(p.nachname, ' ', p.vorname, ' (', ma.mitarbeiter_uid , ')') as mitarbeiter";
+			$returnwert = "ma.mitarbeiter_uid, CONCAT(p.nachname, ' ', p.vorname, ' (', ma.mitarbeiter_uid , ')') as mitarbeiter";
 
 		$qry = "
 			SELECT " . $returnwert . "  
@@ -375,11 +373,7 @@ class Mitarbeiter_model extends DB_Model
 			OR
 				lower (p.vorname) LIKE '%". $this->db->escape_like_str($filter)."%'
 			OR
-				(ma.mitarbeiter_uid) LIKE '%". $this->db->escape_like_str($filter)."%'
-			OR
-				lower(vorname || ' ' || nachname || ' ' || vorname) like ".$this->db->escape('%'.mb_strtolower($filter).'%')."
-			ORDER BY
-				p.nachname, p.vorname, b.uid, p.person_id";
+				(ma.mitarbeiter_uid) LIKE '%". $this->db->escape_like_str($filter)."%'";
 
 		return $this->execQuery($qry);
 	}

application/models/ressource/Reservierung_model.php

@@ -76,7 +76,7 @@ class Reservierung_model extends DB_Model
 	 *
 	 * @return stdClass
 	 */
-	public function getReservierungenMitarbeiter($start_date, $end_date)
+	public function getReservierungenMitarbeiter($start_date, $end_date, $ort_kurzbz = null)
 	{
 
 		$raum_reservierungen_query = "SELECT res.*, beginn, ende,
@@ -89,6 +89,7 @@ class Reservierung_model extends DB_Model
 			JOIN lehre.tbl_stunde ON lehre.tbl_stunde.stunde = res.stunde
 			WHERE res.uid = ? AND datum >= ? AND datum <= ?";
 
+//		$subquery = is_null($ort_kurzbz)? $lvplan_reservierungen_query:$raum_reservierungen_query;
 		$subquery = $raum_reservierungen_query;
 
 		

application/models/ressource/Stundensatz_model.php

@@ -2,7 +2,7 @@
 
 class Stundensatz_model extends DB_Model
 {
-
+	
 	/**
 	 * Constructor
 	 */
@@ -43,97 +43,6 @@ class Stundensatz_model extends DB_Model
 		return $this->execQuery($qry, $params);
 	}
 
-	public function getStundensatzForMitarbeiter($person_id, $studiensemester_kurzbz)
-	{
-		$this->load->config('stv');
-
-		$useFixangestelltStundensatz = $this->config->item('tabs')['projektarbeit']['lvLektroinnenzuteilungFixangestelltStundensatz'];
-		$defaultStundensatz = $this->config->item('tabs')['projektarbeit']['defaultProjektbetreuerStundensatz'];
-
-		$stundensatz = '';
-
-		if(isset($person_id) && isset($studiensemester_kurzbz))
-		{
-			$this->load->model('organisation/Studiensemester_model', 'StudiensemesterModel');
-
-			$this->StudiensemesterModel->addSelect('start, ende');
-			$result = $this->StudiensemesterModel->load($studiensemester_kurzbz);
-
-			if (hasData($result))
-			{
-				$studiensemester = getData($result)[0];
-
-				if (isset($useFixangestelltStundensatz) && !$useFixangestelltStundensatz)
-				{
-					// load Mitarbeiter
-					$params = [$person_id];
-					$qry = "
-						SELECT
-							mitarbeiter_uid, fixangestellt
-						FROM
-							public.tbl_mitarbeiter
-							JOIN public.tbl_benutzer ON(tbl_benutzer.uid=tbl_mitarbeiter.mitarbeiter_uid)
-						WHERE
-							person_id=?
-						ORDER BY
-							tbl_mitarbeiter.insertamum DESC NULLS LAST
-						LIMIT 1";
-
-					$result = $this->execQuery($qry, $params);
-
-					if (hasData($result))
-					{
-						foreach (getData($result) as $ma)
-						{
-							if (!$ma->fixangestellt)
-							{
-								$stundensatzRes = $this->getStundensatzByDatum(
-									$ma->mitarbeiter_uid, $studiensemester->start, $studiensemester->ende, 'lehre'
-								);
-
-								if (hasData($stundensatzRes))
-									$stundensatz = getData($stundensatzRes)[0]->stundensatz;
-								else
-									$stundensatz = '0.00';
-							}
-						}
-					}
-					else
-					{
-						$stundensatz = '0.00';
-					}
-
-				}
-				else
-				{
-					$params = [$person_id, $studiensemester->ende, $studiensemester->start];
-					$qry = "SELECT ss.stundensatz
-							FROM hr.tbl_stundensatz ss
-								JOIN public.tbl_mitarbeiter ON ss.uid = tbl_mitarbeiter.mitarbeiter_uid
-								JOIN public.tbl_benutzer ON(tbl_benutzer.uid=tbl_mitarbeiter.mitarbeiter_uid)
-							WHERE person_id=?
-								AND stundensatztyp = 'lehre'
-								AND gueltig_von <= ?
-								AND (gueltig_bis >= ? OR gueltig_bis IS NULL)
-							ORDER BY gueltig_bis DESC NULLS FIRST, gueltig_von DESC NULLS LAST LIMIT 1";
-
-					$result = $this->execQuery($qry, $params);
-
-					if (hasData($result))
-					{
-						$stundensatz = getData($result)[0]->stundensatz;
-					}
-					else
-					{
-						$stundensatz = $defaultStundensatz;
-					}
-				}
-			}
-		}
-
-		return $stundensatz;
-	}
-
 	public function getDefaultStundensatz($mitarbeiter_uid, $beginn, $ende = null, $typ = null)
 	{
 		$stundensatz_result = $this->getStundensatzByDatum($mitarbeiter_uid, $beginn, $ende, $typ);
@@ -149,4 +58,4 @@ class Stundensatz_model extends DB_Model
 		}
 		return $default_stundensatz;
 	}
-}
+}

application/models/vertragsbestandteil/Dienstverhaeltnis_model.php

@@ -254,16 +254,22 @@ EOSQL;
 	return $dvs;
     }
 
-	public function existsDienstverhaeltnis($mitarbeiter_uid, $start, $ende, $vertragsart_kurzbz)
+	public function existsDienstverhaeltnis($mitarbeiter_uid, $start, $ende = null, $vertragsart_kurzbz = null)
 	{
 		$this->addOrder('von', 'DESC');
 		$this->db->where('mitarbeiter_uid', $mitarbeiter_uid);
-		$this->db->where('vertragsart_kurzbz', $vertragsart_kurzbz);
+		if (!is_null($vertragsart_kurzbz))
+			$this->db->where('vertragsart_kurzbz', $this->escape($vertragsart_kurzbz));
+
 		$this->db->where('von <=', $ende);
-		$this->db->group_start();
-		$this->db->where('bis >=', $start);
-		$this->db->or_where('bis IS NULL', null, false);
-		$this->db->group_end();
+
+		if (!is_null($ende))
+		{
+			$this->db->group_start();
+			$this->db->where('bis >=', $start);
+			$this->db->or_where('bis IS NULL', null, false);
+			$this->db->group_end();
+		}
 
 		$this->addLimit(1);
 		return $this->load();

application/views/Cis/ProfilUpdate.php

@@ -2,14 +2,10 @@
 $includesArray = array(
     'title' => 'Profil Änderungen',
     'vue3' => true,
-	'primevue3' => true,
     'bootstrap5' => true,
     'fontawesome6'=> true,
     'axios027' => true,
     'tabulator5' => true,
-	'customJSs' => array(
-		'vendor/moment/luxonjs/luxon.min.js'
-	),
     'customJSModules' => array(
 	'public/js/apps/Cis/ProfilUpdateRequests.js'
     ),

application/views/Studentenverwaltung.php

@@ -22,8 +22,7 @@
 			'public/css/components/function.css'
 		],
 		'customJSs' => [
-			'vendor/vuejs/vuedatepicker_js/vue-datepicker.iife.js',
-			'vendor/moment/luxonjs/luxon.min.js'
+			'vendor/vuejs/vuedatepicker_js/vue-datepicker.iife.js'
 			#'vendor/npm-asset/primevue/tree/tree.min.js',
 			#'vendor/npm-asset/primevue/toast/toast.min.js'
 		],
@@ -54,8 +53,6 @@ $configArray = [
 			active-addons="<?= defined('ACTIVE_ADDONS') ? ACTIVE_ADDONS : ''; ?>"
 			stv-root="<?= site_url('Studentenverwaltung'); ?>"
 			cis-root="<?= CIS_ROOT; ?>"
-			avatar-url="<?= site_url('Cis/Pub/bild/person/' . getAuthPersonId()); ?>" 
-			logout-url="<?= site_url('Cis/Auth/logout'); ?>"
 			:permissions="<?= htmlspecialchars(json_encode($permissions)); ?>"
 			:config="<?=  htmlspecialchars(json_encode($configArray)); ?>"
 			>

application/views/system/infocenter/onboarding.php

@@ -1,47 +0,0 @@
-<?php
-	$this->load->view(
-		'templates/FHC-Header',
-		array(
-			'title' => 'Info Center',
-			'jquery3' => true,
-			'jqueryui1' => true,
-			'jquerycheckboxes1' => true,
-			'bootstrap3' => true,
-			'fontawesome4' => true,
-			'sbadmintemplate3' => true,
-			'tablesorter2' => true,
-			'ajaxlib' => true,
-			'filterwidget' => true,
-			'navigationwidget' => true,
-			'dialoglib' => true,
-			'phrases' => array(
-				'person' => array('vorname', 'nachname'),
-				'ui' => array('bitteEintragWaehlen')
-			),
-			'customCSSs' => array('public/css/sbadmin2/tablesort_bootstrap.css', 'public/css/infocenter/infocenterPersonDataset.css'),
-			'customJSs' => array('public/js/bootstrapper.js', 'public/js/infocenter/rueckstellung.js', 'public/js/infocenter/infocenterPersonDataset.js')
-		)
-	);
-?>
-
-	<div id="wrapper">
-
-		<?php echo $this->widgetlib->widget('NavigationWidget'); ?>
-
-		<div id="page-wrapper">
-			<div class="container-fluid">
-				<div class="row">
-					<div class="col-lg-12">
-						<h3 class="page-header">
-							Electronic Onboarding
-						</h3>
-					</div>
-				</div>
-				<div>
-					<?php $this->load->view('system/infocenter/onboardingData.php'); ?>
-				</div>
-			</div>
-		</div>
-	</div>
-
-<?php $this->load->view('templates/FHC-Footer'); ?>

application/views/system/infocenter/onboardingData.php

@@ -1,116 +0,0 @@
-<?php
-
-	$APP = '\'infocenter\'';
-	$KENNZEICHEN = '\'eobRegistrierungsId\'';
-
-$query = '
-		SELECT
-			p.person_id AS "PersonId",
-			p.vorname AS "Vorname",
-			p.nachname AS "Nachname",
-			pl.zeitpunkt AS "LockDate",
-			pl.lockuser AS "LockUser",
-			rueck.datum_bis AS "HoldDate",
-			rueck.bezeichnung AS "Rueckstellgrund"
-		FROM public.tbl_person p
-			JOIN tbl_kennzeichen ON p.person_id = tbl_kennzeichen.person_id AND kennzeichentyp_kurzbz = '. $KENNZEICHEN .'
-			LEFT JOIN (
-					SELECT tpl.person_id,
-						   tpl.zeitpunkt,
-						   sp.nachname AS lockuser
-					  FROM system.tbl_person_lock tpl
-					  JOIN public.tbl_benutzer sb USING (uid)
-					  JOIN public.tbl_person sp ON sb.person_id = sp.person_id
-					 WHERE tpl.app = '.$APP.'
-				 ) pl ON p.person_id = pl.person_id
-			LEFT JOIN (
-				SELECT
-					tbl_rueckstellung.person_id,
-					tbl_rueckstellung.datum_bis,
-					tbl_rueckstellung.status_kurzbz,
-					array_to_json(bezeichnung_mehrsprachig::varchar[])->>0 as bezeichnung
-				FROM public.tbl_rueckstellung
-					JOIN public.tbl_rueckstellung_status USING(status_kurzbz)
-					JOIN public.tbl_person sp ON tbl_rueckstellung.person_id = sp.person_id
-				WHERE tbl_rueckstellung.rueckstellung_id =
-				(
-					SELECT srueck.rueckstellung_id
-					FROM public.tbl_rueckstellung srueck
-					WHERE srueck.person_id = tbl_rueckstellung.person_id
-						AND datum_bis >= NOW()
-					ORDER BY srueck.datum_bis DESC LIMIT 1
-				)
-			) rueck ON rueck.person_id = p.person_id
-		WHERE p.person_id NOT IN (SELECT person_id FROM public.tbl_prestudent)';
-
-	$filterWidgetArray = array(
-		'query' => $query,
-		'app' => InfoCenter::APP,
-		'datasetName' => 'onboarding',
-		'filter_id' => $this->input->get('filter_id'),
-		'requiredPermissions' => 'infocenter',
-		'datasetRepresentation' => 'tablesorter',
-		'checkboxes' => 'PersonId',
-		'additionalColumns' => array('Details'),
-		'columnsAliases' => array(
-			'PersonId',
-			ucfirst($this->p->t('person', 'vorname')) ,
-			ucfirst($this->p->t('person', 'nachname')),
-			ucfirst($this->p->t('global', 'sperrdatum')),
-			ucfirst($this->p->t('global', 'gesperrtVon')),
-			ucfirst($this->p->t('infocenter', 'rueckstelldatum')),
-			ucfirst($this->p->t('infocenter', 'rueckstellgrund')),
-		),
-
-		'formatRow' => function($datasetRaw) {
-			/* NOTE: Dont use $this here for PHP Version compatibility */
-			$datasetRaw->{'Details'} = sprintf(
-				'<a href="%s?person_id=%s&origin_page=%s&fhc_controller_id=%s&prev_filter_id=%s">Details</a>',
-				site_url('system/infocenter/InfoCenter/showDetails'),
-				$datasetRaw->{'PersonId'},
-				'onboarding',
-				(isset($_GET['fhc_controller_id']) ? $_GET['fhc_controller_id'] : ''),
-				(isset($_GET['filter_id']) ? $_GET['filter_id'] : '')
-			);
-
-			if ($datasetRaw->{'LockDate'} == null)
-			{
-				$datasetRaw->{'LockDate'} = '-';
-			}
-
-			if ($datasetRaw->{'LockUser'} == null)
-			{
-				$datasetRaw->{'LockUser'} = '-';
-			}
-
-			if ($datasetRaw->{'HoldDate'} == null)
-			{
-				$datasetRaw->{'HoldDate'} = '-';
-			}
-			else
-			{
-				$datasetRaw->{'HoldDate'} = date_format(date_create($datasetRaw->{'HoldDate'}), 'Y-m-d H:i');
-			}
-
-			if ($datasetRaw->{'Rueckstellgrund'} === null)
-			{
-				$datasetRaw->{'Rueckstellgrund'} = '-';
-			}
-
-			return $datasetRaw;
-		},
-
-		'markRow' => function($datasetRaw) {
-
-			if ($datasetRaw->LockDate != null)
-			{
-				return FilterWidget::DEFAULT_MARK_ROW_CLASS;
-			}
-		}
-
-
-
-	);
-
-	echo $this->widgetlib->widget('FilterWidget', $filterWidgetArray);
-?>

application/views/system/infocenter/stammdaten.php

@@ -106,7 +106,6 @@
 			<tbody>
 			<?php
 			$lastMailAdress = '';
-			$lastUnverifiedMailAdress = '';
 			foreach ($stammdaten->kontakte as $kontakt): ?>
 				<tr>
 				<?php if ($kontakt->kontakttyp === 'email'): ?>
@@ -120,16 +119,14 @@
 						<?php echo '<span class="kontakt '.$kontakt->kontakttyp.'" data-id="'. $kontakt->kontakt_id .'" data-value="' . $kontakt->kontakt .'">';?>
 						<?php if ($kontakt->kontakttyp === 'email'): ?>
 							<a href="mailto:<?php echo $kontakt->kontakt; ?>" target="_top">
-							<?php $lastMailAdress = $kontakt->kontakt; ?>
-						<?php elseif ($kontakt->kontakttyp === 'email_unverifiziert'): ?>
-							<?php $lastUnverifiedMailAdress = $kontakt->kontakt;
+							<?php $lastMailAdress = $kontakt->kontakt;
 							endif;
 							echo $kontakt->kontakt;
-						if ($kontakt->kontakttyp === 'email'):
+							if ($kontakt->kontakttyp === 'email'):
 							?>
 							</a>
-						<?php endif; ?>
-						<?php echo '</span>'?>
+							<?php endif; ?>
+					<?php echo '</span>'?>
 					</td>
 					<td><?php echo $kontakt->anmerkung; ?></td>
 				</tr>
@@ -143,9 +140,9 @@
 						<?php if (isset($adresse)): ?>
 							<div class="row adresse col-sm-12" data-id="<?php echo $adresse->adresse_id ?>">
 								<div class="float-left" data-value="<?php echo $adresse->strasse ?>" data-type="strasse"><?php echo $adresse->strasse ?></div>
-
+								
 								<div class="float-left" data-value="<?php echo $adresse->plz ?>" data-type="plz"><?php echo $adresse->plz ?></div>
-
+								
 								<div class="float-left" data-value="<?php echo $adresse->ort ?>" data-type="ort"><?php echo $adresse->ort ?></div>
 
 							<?php if (isset($adresse->nationkurztext)): ?>
@@ -185,8 +182,7 @@
 			</div>
 			<?php if (isset($stammdaten->zugangscode)): ?>
 				<div class="col-xs-6 text-right">
-					<a href="<?php echo CIS_ROOT.'addons/bewerbung/cis/registration.php?code='.html_escape($stammdaten->zugangscode)
-					.'&emailAdresse='.(isEmptyString($lastMailAdress)?$lastUnverifiedMailAdress:$lastMailAdress).'&keepEmailUnverified=true' ?>"
+					<a href="<?php echo CIS_ROOT.'addons/bewerbung/cis/registration.php?code='.html_escape($stammdaten->zugangscode).'&emailAdresse='.$lastMailAdress ?>"
 					   target='_blank'><i class="glyphicon glyphicon-new-window"></i>&nbsp;<?php echo  $this->p->t('infocenter','zugangBewerbung') ?></a>
 				</div>
 			<?php endif; ?>

cis/private/lehre/pruefung/pruefung.js.php

@@ -382,7 +382,7 @@ function writePruefungsTable(e, data, anmeldung)
 			}
 			else if(new Date() > minimumFrist)
 			{
-				button = "<p><a href='#' title='<?php echo $p->t('pruefung/anmeldenMoeglichBis'); ?> "+frist+"'><input style='width: 140px; background-color: green;' type='button' value='"+termin+" "+time+"' onclick='openDialog(\""+e.lehrveranstaltung[0].lehrveranstaltung_id+"\", \""+d.pruefungstermin_id+"\", \""+e.lehrveranstaltung[0].bezeichnung.replace("'", "&apos;")+"\", \""+d.von+"\", \""+d.bis+"\", \""+e.lehrveranstaltung[0].ects +"\");'></a></p>";
+				button = "<p><a href='#' title='<?php echo $p->t('pruefung/anmeldenMoeglichBis'); ?> "+frist+"'><input style='width: 140px; background-color: green;' type='button' value='"+termin+" "+time+"' onclick='openDialog(\""+e.lehrveranstaltung[0].lehrveranstaltung_id+"\", \""+d.pruefungstermin_id+"\", \""+e.lehrveranstaltung[0].bezeichnung.replace("'", "&apos;")+"\", \""+d.von+"\", \""+d.bis+"\");'></a></p>";
 			}
 		}
 		else
@@ -479,15 +479,13 @@ function showPruefungsDetails(prfId, lvId)
  * @param {type} lvBezeichnung Bezeichnung der Lehrveranstaltung
  * @param {type} terminVon Beginn der Prüfung
  * @param {type} terminBis Ende der Prüfung
- * @param {type} ects der LV
  * @returns {undefined}
  */
-function openDialog(lehrveranstaltung_id, termin_id, lvBezeichnung, terminVon, terminBis, ects)
+function openDialog(lehrveranstaltung_id, termin_id, lvBezeichnung, terminVon, terminBis)
 {
 	$("#lehrveranstaltungHidden").val(lehrveranstaltung_id);
 	$("#terminHidden").val(termin_id);
 	$("#lehrveranstaltung").html(lvBezeichnung);
-	$("#ectsangabe").val(ects);
 
 	$.ajax({
 		dataType: 'json',
@@ -584,12 +582,6 @@ function saveAnmeldung(lehrveranstaltung_id, termin_id)
 	if($('#prestudent_studiengang').length)
 		studiengang_kz =   $('#prestudent_studiengang option:selected').val();
 
-	var ects = null;
-	if ($('#ectsangabe').length)
-	{
-		ects = $('#ectsangabe').val();
-	}
-
 	$.ajax({
 		dataType: 'json',
 		url: "./pruefungsanmeldung.json.php",
@@ -601,8 +593,7 @@ function saveAnmeldung(lehrveranstaltung_id, termin_id)
 			bemerkung: bemerkungen,
 			uid: uid,
 			studienverpflichtung_id: studienverpflichtung_id,
-			studiengang_kz: studiengang_kz,
-			ects: ects
+			studiengang_kz: studiengang_kz
 		},
 		error: loadError,
 		success: function(data){
@@ -813,7 +804,6 @@ function writeAnmeldungen(data, showMessage = true)
 		var pruefung_id = data.result.anmeldungen[0].pruefung_id;
 		var lehrveranstaltung_id = data.result.anmeldungen[0].lehrveranstaltung_id;
 		var ort_kurzbz = data.result.ort_kurzbz;
-		var anderer_raum = data.result.anderer_raum;
 		var lv_bezeichnung = data.result.lv_bezeichnung;
 		var lv_lehrtyp = data.result.lv_lehrtyp;
 		var prf_termin = data.result.datum;
@@ -826,33 +816,24 @@ function writeAnmeldungen(data, showMessage = true)
 			count++;
 			var vorname = d.student.vorname !== "null" ? d.student.vorname : "";
 			var nachname = d.student.nachname !== "null" ? d.student.nachname : "";
-
-			let ects = "";
-			<?php if (defined('CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE') && (CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE === true)): ?>
-				ects = d.ects !== null ? "(" + d.ects + " ECTS) ": "";
-
-			<?php endif; ?>
-
 			switch(d.status_kurzbz)
 			{
 				case 'angemeldet':
-					liste += "<li class='ui-state-default' id='"+d.student.uid+"'><span class='ui-icon ui-icon-arrowthick-2-n-s'></span><a href='#' onclick='showKommentar(\""+vorname+"\",\""+nachname+"\", \""+d.pruefungsanmeldung_id+"\", \""+d.kommentar+"\", \""+terminId+"\", \""+lehrveranstaltung_id+"\");'>"+ects+vorname+" "+nachname+"</a>";
+					liste += "<li class='ui-state-default' id='"+d.student.uid+"'><span class='ui-icon ui-icon-arrowthick-2-n-s'></span><a href='#' onclick='showKommentar(\""+vorname+"\",\""+nachname+"\", \""+d.pruefungsanmeldung_id+"\", \""+d.kommentar+"\", \""+terminId+"\", \""+lehrveranstaltung_id+"\");'>"+vorname+" "+nachname+"</a>";
 					liste += "<div style='width: 3%; text-align: right;'>"+count+"</div><div style='text-align: center; width: 34%;'><input style='vertical-align: top; height: 24px;' type='button' value='<?php echo $p->t('pruefung/bestaetigen'); ?>' onclick='anmeldungBestaetigen(\""+d.pruefungsanmeldung_id+"\", \""+terminId+"\", \""+lehrveranstaltung_id+"\");'>";
 					liste += "<input style='vertical-align: top; height: 24px; background-color: #dd514c;' type='button' value='X' onclick='anmeldungLoeschen(\""+d.pruefungsanmeldung_id+"\", \""+terminId+"\", \""+lehrveranstaltung_id+"\");'></div>";
 					if(d.wuensche !== null)
 					{
-						let msg = $('<div>').text(d.wuensche).html();
-						liste += `<div class='anmerkungInfo'><a href='#' data-msg="${msg}" onclick="openKommentarDialog(this.dataset.msg)"><img style='width: 20px;' src='../../../../skin/images/button_lvinfo.png'></a></div>`;
+						liste += "<div class='anmerkungInfo'><a href='#' title='<?php echo $p->t('pruefung/anmerkungDesStudenten'); ?>"+d.wuensche+"'><img style='width: 20px;' src='../../../../skin/images/button_lvinfo.png'></a></div>";
 					}
 					liste += "</li>";
 					break;
 				case 'bestaetigt':
-					liste += "<li class='ui-state-default' id='"+d.student.uid+"'><span class='ui-icon ui-icon-arrowthick-2-n-s'></span><a href='#' onclick='showKommentar(\""+vorname+"\",\""+nachname+"\", \""+d.pruefungsanmeldung_id+"\", \""+d.kommentar+"\", \""+terminId+"\", \""+lehrveranstaltung_id+"\");'>"+ects+vorname+" "+nachname+"</a>";
+					liste += "<li class='ui-state-default' id='"+d.student.uid+"'><span class='ui-icon ui-icon-arrowthick-2-n-s'></span><a href='#' onclick='showKommentar(\""+vorname+"\",\""+nachname+"\", \""+d.pruefungsanmeldung_id+"\", \""+d.kommentar+"\", \""+terminId+"\", \""+lehrveranstaltung_id+"\");'>"+vorname+" "+nachname+"</a>";
 					liste += "<div style='width: 2%; text-align: right;'>"+count+"</div><div style='text-align: center; width: 20%;'><a href='#' title='<?php echo $p->t('pruefung/statusAenderungVon'); ?>: "+d.statusupdatevon+"'><?php echo $p->t('pruefung/bestaetigt'); ?></a></div>";
 					if(d.wuensche !== null)
 					{
-						let msg = $('<div>').text(d.wuensche).html();
-						liste += `<div class='anmerkungInfo'><a href='#' data-msg="${msg}" onclick="openKommentarDialog(this.dataset.msg)"><img style='width: 20px;' src='../../../../skin/images/button_lvinfo.png'></a></div>`;
+						liste += "<div class='anmerkungInfo'><a href='#' title='<?php echo $p->t('pruefung/anmerkungDesStudenten'); ?>"+d.wuensche+"'><img style='width: 20px;' src='../../../../skin/images/button_lvinfo.png'></a></div>";
 					}
 
 					break;
@@ -863,14 +844,13 @@ function writeAnmeldungen(data, showMessage = true)
 		});
 		liste += "</ul>";
 		$("#anmeldung_hinzufuegen").html("<input id='anmeldung_hinzufuegen_uid' type='text' placeholder='StudentIn-UID' /><input type='button' value='<?php echo $p->t('global/hinzufuegen'); ?>' onclick='saveAnmeldung(\""+lehrveranstaltung_id+"\",\""+terminId+"\");'/>");
-		$("#reihungSpeichernButton").html("<label for='emails'>E-Mail: <input type='email' id='emails' multiple /> <br /><br />" +
-			"<input type='button' value='<?php echo $p->t('pruefung/reihungSpeichern'); ?>' onclick='saveReihung(\""+terminId+"\", \""+lehrveranstaltung_id+"\");'><input type='button' value='<?php echo $p->t('pruefung/alleBestaetigen'); ?>' onclick='alleBestaetigen(\""+terminId+"\", \""+lehrveranstaltung_id+"\");'>");
+		$("#reihungSpeichernButton").html("<input type='button' value='<?php echo $p->t('pruefung/reihungSpeichern'); ?>' onclick='saveReihung(\""+terminId+"\", \""+lehrveranstaltung_id+"\");'><input type='button' value='<?php echo $p->t('pruefung/alleBestaetigen'); ?>' onclick='alleBestaetigen(\""+terminId+"\", \""+lehrveranstaltung_id+"\");'>");
 		$("#lvdaten").html(lv_bezeichnung+" ("+prf_termin+")");
 		$("#anmeldeDaten").html(liste);
 		$("#listeDrucken").html(listenLinks);
-		if(ort_kurzbz !== null || anderer_raum !== null)
+		if(ort_kurzbz !== null)
 		{
-			$("#raumLink").html("<span><?php echo $p->t('pruefung/pruefungsraum'); ?></span>"+ (ort_kurzbz ?? anderer_raum));
+			$("#raumLink").html("<span><?php echo $p->t('pruefung/pruefungsraum'); ?></span>"+ort_kurzbz);
 		}
 		else
 		{
@@ -903,17 +883,11 @@ function writeAnmeldungen(data, showMessage = true)
 function openRaumDialog(terminId, lehrveranstaltung_id)
 {
 	getRaeume(terminId);
-	$("#raum").html('<h2><?php echo $p->t('pruefung/pruefungsraum'); ?></h2><div id="raumInfos"><input onChange="changeStateOfRaumDropdown();" type="checkbox" /><span><?php echo $p->t('pruefung/imBuero'); ?></span><br /><span style="font-weight: bold;"><?php echo $p->t('pruefung/raum'); ?>: </span><select id="raeumeDropdown"></select><br /></div><input onChange="changeStateOfRaumInputs();" id="andererRaum" type="checkbox"/><span><?php echo $p->t('pruefung/andererRaum'); ?></span> <input type="text" id="andereRaumInput" placeholder="<?php echo $p->t('pruefung/andererRaum'); ?>"/><br />');
+	$("#raum").html('<h2><?php echo $p->t('pruefung/pruefungsraum'); ?></h2><input onChange="changeStateOfRaumDropdown();" type="checkbox" /><span><?php echo $p->t('pruefung/imBuero'); ?></span><br /><span style="font-weight: bold;"><?php echo $p->t('pruefung/raum'); ?>: </span><select id="raeumeDropdown"></select>');
 	$("#raumSpeichernButton").html("<input type='button' value='<?php echo $p->t('pruefung/raumSpeichern'); ?>' onclick='saveRaum(\""+terminId+"\", \""+lehrveranstaltung_id+"\");'/>");
 	$("#raumDialog").dialog("open");
 }
 
-function openKommentarDialog(text)
-{
-	$('#kommentarimDialog').text(text);
-	$('#kommentarDialog').dialog('open');
-}
-
 /**
  * speichert die Reihung der Studenten einer Prüfungsanmeldung
  * @param {type} terminId ID des Prüfungstermines
@@ -1037,30 +1011,6 @@ function anmeldungLoeschen(pruefungsanmeldung_id, termin_id, lehrveranstaltung_i
  */
 function alleBestaetigen(termin_id, lehrveranstaltung_id)
 {
-	const input = $('#emails').val();
-
-	let emails = '';
-	if (input)
-	{
-		emails = input.split(",").map(s => s.trim());
-		const re = /^([\w-+]+(?:\.[\w-+]+)*)@((?:[\w-]+\.)*\w[\w-]{0,66})\.([a-z]{2,63}(?:\.[a-z]{2})?)$/i;
-
-		let valid = true;
-		$.each(emails, function(index, email)
-		{
-			if (re.test(email) === false)
-			{
-				alert("<?php echo $p->t('pruefung/bitteEmailAngeben')?>");
-				valid = false;
-				return false;
-			}
-		});
-
-		if (!valid)
-			return false;
-
-	}
-
 	$.ajax({
 		dataType: 'json',
 		url: "./pruefungsanmeldung.json.php",
@@ -1068,8 +1018,7 @@ function alleBestaetigen(termin_id, lehrveranstaltung_id)
 		data: {
 			method: "alleBestaetigen",
 			termin_id: termin_id,
-			lehrveranstaltung_id: lehrveranstaltung_id,
-			emails: emails
+			lehrveranstaltung_id: lehrveranstaltung_id
 		},
 		error: loadError,
 		success: function(data){
@@ -1141,12 +1090,15 @@ function loadStudiengaenge()
 }
 
 /**
- * Lädt alle Prüfungen zu einem Studiensemester
- * @param {type} studiensemester Studiensemester
+ * Lädt alle Prüfungen zu einem Studiengang
+ * @param {type} studiengang_kz Studiengangskennzahl
  * @returns {undefined}
  */
-function loadPruefungStudiengang(studiensemester)
+function loadPruefungStudiengang(studiengang_kz, studiensemester)
 {
+	if(studiengang_kz === undefined)
+		studiengang_kz = $("#select_studiengang option:selected").val();
+
 	if(studiensemester === undefined)
 		studiensemester = $("#filter_studiensemester option:selected").val();
 
@@ -1155,7 +1107,8 @@ function loadPruefungStudiengang(studiensemester)
 		url: "./pruefungsanmeldung.json.php",
 		type: "POST",
 		data: {
-			method: "getPruefungenStudiensemester",
+			method: "getPruefungenStudiengang",
+			studiengang_kz: studiengang_kz,
 			studiensemester: studiensemester
 		},
 		error: loadError,
@@ -1165,61 +1118,25 @@ function loadPruefungStudiengang(studiensemester)
 				$("#pruefungenListe").empty();
 				if(data.result.length > 0)
 				{
-					$('#table4').show()
-					let rows = '';
-
-					data.result.forEach(function(e)
-					{
-						let termine = [];
-						if (e.pruefung) {
-							e.pruefung.forEach(p => {
-								if (p.termine) {
-									termine = termine.concat(p.termine);
-								}
+					var liste = "";
+					data.result.forEach(function(e){
+						liste += "<ul><li>"+e.bezeichnung+"<ul>";
+						try
+						{
+							e.pruefung[0].termine.forEach(function(d){
+								liste += "<li> <a onclick='showAnmeldungen(\""+d.pruefungstermin_id+"\", \""+e.lehrveranstaltung_id+"\");'>"+convertDateTime(d.von)+" "+convertDateTime(d.von, "time")+" - "+convertDateTime(d.bis, "time")+"</a></li>";
 							});
 						}
-
-						if (termine.length === 0)
+						catch(err)
 						{
-							rows += `
-								  <tr>
-									<td></td>
-									<td>${e.bezeichnung}</td>
-									<td colspan="5">Keine Termine</td>
-								  </tr>`;
-						}
-						else
-						{
-							termine.forEach(function(d) {
-								let vonDate = convertDateTime(d.von);
-								let vonTime = convertDateTime(d.von, 'time');
-								let bisTime = convertDateTime(d.bis, 'time');
-								let onClick = `showAnmeldungen(${d.pruefungstermin_id}, ${e.lehrveranstaltung_id})`;
-
-								rows += `
-									<tr>
-										<td><input type="checkbox"
-											class="termin-checkbox"
-											data-termin-id="${d.pruefungstermin_id}"
-											data-lv-id="${e.lehrveranstaltung_id}"
-											data-datum="${vonDate}"
-										/></td>
-										<td>${e.studiengang}</td>
-										<td>${e.bezeichnung}</td>
-										<td>${vonDate}</td>
-										<td>${vonTime}</td>
-										<td>${bisTime}</td>
-										<td><a onclick="${onClick}"><?php echo $p->t('pruefung/pruefungsbewertungAnmeldungen'); ?></a></td>
-									</tr>`;
-							});
+							var errmsg = err.message;
 						}
+						liste += "</ul></li></ul>";
 					});
-					$("#pruefungenListe").html(rows);
-					setTablesorter('table4')
+					$("#pruefungenListe").append(liste);
 				}
 				else
 				{
-					$('#table4').hide()
 					$("#pruefungenListe").html("<?php echo $p->t('pruefung/keinePruefungenVorhanden'); ?>");
 				}
 			}
@@ -1231,42 +1148,6 @@ function loadPruefungStudiengang(studiensemester)
 	});
 }
 
-function terminezusammenlegen(termine, lv_id)
-{
-	if(termine.length <= 1)
-		return;
-
-	$.ajax({
-		dataType: 'json',
-		url: "./pruefungsanmeldung.json.php",
-		type: "POST",
-		data: {
-			method: "terminezusammenlegen",
-			'termine[]': termine,
-			lv_id: lv_id
-		},
-		error: loadError,
-		success: function(data){
-			if(data.error === 'false')
-			{
-				loadPruefungStudiengang()
-				$("#anmeldung_hinzufuegen").empty();
-				$("#lvdaten").empty();
-				$("#anmeldeDaten").empty();
-				$("#reihungSpeichernButton").empty();
-				$("#kommentar").empty();
-				$("#kommentarSpeichernButton").empty();
-				$("#raumLink").empty();
-				$("#listeDrucken").empty();
-			}
-			else
-			{
-				messageBox("message", data.errormsg, "red", "highlight", 10000);
-			}
-		}
-	});
-}
-
 /**
  * Zeigt das Formularfeld zur Eingabe eines Kommentars in der Anmeldungsverwaltung an.
  * @param {String} vorname Vorname des Studenten
@@ -1360,7 +1241,6 @@ function loadStudiensemester()
 			data.result.forEach(function(d){
 				selectData += "<option "+((d.studiensemester_kurzbz === data.aktSem) ? "selected" : "")+" value='"+d.studiensemester_kurzbz+"'>"+d.studiensemester_kurzbz+"</option>";
 			});
-
 			$('#studiensemester').html(selectData);
 			loadPruefungsfenster();
 			loadLehrveranstaltungen();
@@ -1660,7 +1540,7 @@ function loadPruefungsDetails(prfId)
 			if(data.result.length === 0)
 			{
 				messageBox("message", "<?php echo $p->t('pruefung/keinePruefungsfensterGespeichert'); ?>", "red", "highlight", 10000);
-				$("#pruefungsfenster").html("<option value='null'><?php echo $p->t('pruefung/keinePruefungsfensterGespeichert'); ?></option>");
+				$("#pruefungsfenster").html("<option value='null'></option>");
 			}
 			else
 			{
@@ -2308,28 +2188,10 @@ function changeStateOfRaumDropdown()
 	}
 }
 
-function changeStateOfRaumInputs()
-{
-	if ($("#andererRaum").prop("checked") === true)
-	{
-		$("#raumInfos").hide();
-	}
-	else
-	{
-		$("#raumInfos").show();
-	}
-}
-
 function saveRaum(terminId, lehrveranstaltung_id)
 {
 	var ort_kurzbz;
-	let anderer_raum = '';
-	if ($("#andererRaum").prop("checked") === true && $('#andereRaumInput').val() !== '')
-	{
-		ort_kurzbz = "";
-		anderer_raum = $('#andereRaumInput').val();
-	}
-	else if($("#raum input[type=checkbox]").prop("checked") === true)
+	if($("#raum input[type=checkbox]").prop("checked") === true)
 	{
 		ort_kurzbz = "buero";
 	}
@@ -2344,8 +2206,7 @@ function saveRaum(terminId, lehrveranstaltung_id)
 		data: {
 			method: "saveRaum",
 			ort_kurzbz: ort_kurzbz,
-			terminId: terminId,
-			anderer_raum: anderer_raum
+			terminId: terminId
 		},
 		error: loadError
 	}).done(function(data){

cis/private/lehre/pruefung/pruefungsanmeldung.json.php

@@ -106,14 +106,9 @@ switch($method)
 	case 'getStudiengaenge':
 		$data = getStudiengaenge();
 		break;
-	case 'getPruefungenStudiensemester':
+	case 'getPruefungenStudiengang':
 		$studiensemester = filter_input(INPUT_POST,"studiensemester");
-		$data = getPruefungenStudiengangBySemester($studiensemester);
-		break;
-	case 'terminezusammenlegen':
-		$termine = filter_input(INPUT_POST, 'termine', FILTER_DEFAULT, FILTER_REQUIRE_ARRAY);
-		$lv_id = filter_input(INPUT_POST, 'lv_id');
-		$data = terminezusammenlegen($termine, $lv_id);
+		$data = getPruefungenStudiengang($uid, $studiensemester);
 		break;
 	case 'saveKommentar':
 		$data = saveKommentar();
@@ -125,8 +120,7 @@ switch($method)
 	case 'saveRaum':
 		$terminId = $_REQUEST["terminId"];
 		$ort_kurzbz = $_REQUEST["ort_kurzbz"];
-		$anderer_raum = $_REQUEST["anderer_raum"];
-		$data = saveRaum($terminId, $ort_kurzbz, $uid, $anderer_raum);
+		$data = saveRaum($terminId, $ort_kurzbz, $uid);
 		break;
 	case 'getLvKompatibel':
 		$lvid = filter_input(INPUT_POST, "lehrveranstaltung_id");
@@ -403,7 +397,6 @@ function saveAnmeldung($aktStudiensemester = null, $uid = null)
 	$lv_besucht = false;
 	$studienverpflichtung_id = filter_input(INPUT_POST, "studienverpflichtung_id");
 	$studiengang_kz = filter_input(INPUT_POST, "studiengang_kz");
-	$ects = filter_input(INPUT_POST, "ects");
 
 	//Defaulteinstellung für Anzahlprüfungsversuche (wird durch Addon "ktu" überschrieben)
 	$maxAnzahlVersuche = 0;
@@ -738,10 +731,6 @@ function saveAnmeldung($aktStudiensemester = null, $uid = null)
 					else
 						$anmeldung->anrechnung_id = $anrechnung->anrechnung_id;
 
-					if (defined('CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE') && (CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE === true))
-					{
-						$anmeldung->ects = $ects;
-					}
 					if($anmeldung->save(true))
 					{
 						$pruefung = new pruefungCis($termin->pruefung_id);
@@ -971,13 +960,9 @@ function alleBestaetigen($uid)
 	global $p;
 	$lehrveranstaltung_id = $_REQUEST["lehrveranstaltung_id"];
 	$pruefungstermin_id = $_REQUEST["termin_id"];
-	$emails = $_REQUEST["emails"];
 	$pruefungstermin = new pruefungstermin($pruefungstermin_id);
 	$pruefungsanmeldung = new pruefungsanmeldung();
 	$pranmeldungen = $pruefungsanmeldung->getAnmeldungenByTermin($pruefungstermin_id, $lehrveranstaltung_id);
-
-	$mail_benutzer = [];
-	$mail_inhalt = [];
 	foreach($pranmeldungen as $a)
 	{
 		$anmeldung = new pruefungsanmeldung($a->pruefungsanmeldung_id);
@@ -991,13 +976,6 @@ function alleBestaetigen($uid)
 				$ma = new mitarbeiter($uid);
 				$datum = new datum();
 				$ort = new ort($termin->ort_kurzbz);
-
-				$ortbezeichnung = $ort->bezeichnung;
-				if (is_null($termin->ort_kurzbz) && !is_null($termin->anderer_raum))
-				{
-					$ortbezeichnung = $termin->anderer_raum;
-				}
-
 				$pruefung = new pruefungCis($termin->pruefung_id);
 
 				$to = $anm->uid."@".DOMAIN;
@@ -1017,66 +995,17 @@ function alleBestaetigen($uid)
 				}
 				else
 					$html .= $p->t('pruefung/emailBodyTermin')." ".$datum->formatDatum($termin->von, "d.m.Y")." ".$p->t('pruefung/emailBodyUm')." ".$datum->formatDatum($termin->von, "H:i")."<br>";
-				$html .= $p->t('pruefung/anmeldungErfolgreich')." ".$ortbezeichnung."<br>";
+				$html .= $p->t('pruefung/anmeldungErfolgreich')." ".$ort->bezeichnung."<br>";
 				$html .= "<br>";
 				$html .= "<a href='".APP_ROOT."cis/private/lehre/pruefung/pruefungsanmeldung.php'>".$p->t('pruefung/emailBodyLinkZurAnmeldung')."</a><br>";
 				$html .= "<br>";
 
-				$mail_benutzer[] = [
-					'uid' => $anm->uid
-				];
-
-				if (empty($mail_inhalt))
-				{
-					$mail_inhalt = array(
-						'von' => $ma->vorname." ".$ma->nachname,
-						'lv' => $lv->bezeichnung,
-						'ort' => $ortbezeichnung,
-						'datum' => $datum->formatDatum($termin->von, "d.m.Y") . ' ' . $p->t('pruefung/emailBodyUm') . ' ' . (isset($von) ? $von : $datum->formatDatum($termin->von, "H:i")),
-						'dauer' => $pruefung->einzeln ? ($pruefung->pruefungsintervall . ' ' . $p->t('pruefung/emailBodyMinuten')): '');
-				}
-
 				$mail = new mail($to, $from, $subject,$p->t('pruefung/emailBodyBitteHtmlSicht'));
 				$mail->setHTMLContent($html);
 				$mail->send();
 			}
 		}
 	}
-
-	if (!empty($emails) && !empty($mail_inhalt))
-	{
-		foreach ($emails as $email)
-		{
-			$from = "noreply@".DOMAIN;
-			$subject = $p->t('pruefung/emailSubjectAnmeldungBestaetigung');
-			$html = $p->t('pruefung/sammelemailBody',array($mail_inhalt['lv'], $mail_inhalt['datum'], $mail_inhalt['von']));
-
-			if ($mail_inhalt['ort'])
-			{
-				$html .= $p->t('pruefung/sammelemailBody2',array($mail_inhalt['ort']));
-			}
-
-			$html .= "<br /><table border='1'>
-						<thead>
-							<tr>
-								<th>UID</th>
-							</tr>
-						</thead>
-						<tbody>";
-
-			foreach($mail_benutzer as $benutzer)
-			{
-				$html .= "<tr>
-							<td>" . htmlspecialchars($benutzer['uid']) . "</td>
-						</tr>";
-			}
-			$html .= "</tbody></table><br />";
-
-			$mail = new mail($email, $from, $subject, $p->t('pruefung/emailBodyBitteHtmlSicht'));
-			$mail->setHTMLContent($html);
-			$mail->send();
-		}
-	}
 	$data['result']=true;
 	$data['error']='false';
 	$data['errormsg']='';
@@ -1103,12 +1032,6 @@ function anmeldungBestaetigen($uid)
 	$ort = new ort($termin->ort_kurzbz);
 	$pruefung = new pruefungCis($termin->pruefung_id);
 
-	$ortbezeichnung = $ort->bezeichnung;
-	if (is_null($termin->ort_kurzbz) && !is_null($termin->anderer_raum))
-	{
-		$ortbezeichnung = $termin->anderer_raum;
-	}
-
 	$to = $anmeldung->uid."@".DOMAIN;
 	$from = "noreply@".DOMAIN;
 	$subject = $p->t('pruefung/emailSubjectAnmeldungBestaetigung');
@@ -1126,7 +1049,7 @@ function anmeldungBestaetigen($uid)
 	}
 	else
 		$html .= $p->t('pruefung/emailBodyTermin')." ".$datum->formatDatum($termin->von, "d.m.Y")." ".$p->t('pruefung/emailBodyUm')." ".$datum->formatDatum($termin->von, "H:i")."<br>";
-	$html .= $p->t('pruefung/anmeldungErfolgreich')." ".$ortbezeichnung."<br>";
+	$html .= $p->t('pruefung/anmeldungErfolgreich')." ".$ort->bezeichnung."<br>";
 	$html .= "<br>";
 	$html .= "<a href='".APP_ROOT."cis/private/lehre/pruefung/pruefungsanmeldung.php'>".$p->t('pruefung/emailBodyLinkZurAnmeldung')."</a><br>";
 	$html .= "<br>";
@@ -1243,258 +1166,6 @@ function getPruefungenStudiengang($uid, $aktStudiensemester)
 	return $data;
 }
 
-function getPruefungenStudiengangBySemester($aktStudiensemester)
-{
-	$result = array();
-	$pruefungen = new pruefungCis();
-	$pruefungen->getPruefungByStudiensemester($aktStudiensemester);
-
-	if(!empty($pruefungen->lehrveranstaltungen))
-	{
-		$lehrveranstaltungen = [];
-		foreach ($pruefungen->lehrveranstaltungen as $prf)
-		{
-			$pruefung = new pruefungCis();
-			$pruefung->load($prf->pruefung_id);
-
-			if ($pruefung->storniert)
-				continue;
-
-			$pruefung->getTermineByPruefung();
-
-			$lvid = $prf->lehrveranstaltung_id;
-
-			if (!isset($lehrveranstaltungen[$lvid]))
-			{
-				$lv = new stdClass();
-				$lehrveranstaltung = new lehrveranstaltung();
-				$lehrveranstaltung->load($lvid);
-
-				$studiengang = new studiengang();
-				$studiengang->load($lehrveranstaltung->studiengang_kz);
-
-				$lv->bezeichnung = $lehrveranstaltung->bezeichnung;
-				$lv->lehrveranstaltung_id = $lvid;
-				$lv->studiengang = $studiengang->kuerzel;
-				$lv->pruefung = [];
-				$lehrveranstaltungen[$lvid] = $lv;
-			}
-
-			$lehrveranstaltungen[$lvid]->pruefung[] = $pruefung;
-		}
-		$result = array_values($lehrveranstaltungen);
-	}
-	$data['result']=$result;
-	$data['error']='false';
-	$data['errormsg']='';
-	return $data;
-}
-
-function terminezusammenlegen($termine, $lv_id)
-{
-	$result = array();
-	$alle_termine = array();
-	$error = false;
-	$terminkollision = defined('CIS_PRUEFUNGSANMELDUNG_ERLAUBE_TERMINKOLLISION') ? CIS_PRUEFUNGSANMELDUNG_ERLAUBE_TERMINKOLLISION : false;
-	foreach($termine as $termin)
-	{
-		$pruefungstermin = new pruefungstermin();
-		$pruefungstermin->load($termin);
-		$pruefung = new pruefungCis();
-		$pruefung->load($pruefungstermin->pruefung_id);
-		$pruefung->getLehrveranstaltungenByPruefung();
-
-		$lehrveranstaltungen = array_column($pruefung->lehrveranstaltungen, 'lehrveranstaltung_id');
-		if (!in_array($lv_id, $lehrveranstaltungen))
-			continue;
-
-		$pruefung->lehrveranstaltung_id = $lv_id;
-		$pruefung->termin = $pruefungstermin;
-		$alle_termine[] = $pruefung;
-	}
-
-
-	if (count($alle_termine) >= 1)
-	{
-		usort($alle_termine, function($a, $b) {
-			return strcmp($a->termin->von, $b->termin->von);
-		});
-
-		$first_termin = $alle_termine[0];
-
-		$first_mitarbeiter = $first_termin->mitarbeiter_uid;
-		$first_date = date('Y-m-d', strtotime($first_termin->termin->von));
-		$first_studiensemester = $first_termin->studiensemester_kurzbz;
-		$first_sammelklausur = $first_termin->termin->sammelklausur;
-		$first_ort = $first_termin->termin->ort_kurzbz;
-		$first_raum = $first_termin->termin->anderer_raum;
-		$first_lv = $first_termin->lehrveranstaltung_id;
-		$first_titel = $first_termin->titel;
-
-		$max_von = strtotime($first_termin->termin->von);
-		$max_bis = strtotime($first_termin->termin->bis);
-		$teilnehmer_min = (int)$first_termin->termin->teilnehmer_min;
-		$teilnehmer_max = (int)$first_termin->termin->teilnehmer_max;
-
-
-		$prevEnd = $max_bis;
-
-		foreach ($alle_termine as $termin)
-		{
-			if (date('Y-m-d', strtotime($termin->termin->von)) !== $first_date)
-			{
-				$data['errormsg'] = 'Nicht der gleiche Tag!';
-				$error = true;
-			}
-
-			if ($termin->mitarbeiter_uid !== $first_mitarbeiter)
-			{
-				$data['errormsg'] = 'Unterschiedliche Lektoren!';
-				$error = true;
-			}
-
-			if ($termin->studiensemester_kurzbz !== $first_studiensemester)
-			{
-				$data['errormsg'] = 'Unterschiedliche Studiensemester!';
-				$error = true;
-			}
-
-			if ($termin->termin->sammelklausur !== $first_sammelklausur)
-			{
-				$data['errormsg'] = 'Sammelklausur unterschiedlich!';
-				$error = true;
-			}
-
-			if (!($termin->termin->ort_kurzbz === $first_ort || $first_termin->termin->anderer_raum == $first_raum))
-			{
-				$data['errormsg'] = 'Ort/Raum unterschiedlich!';
-				$error = true;
-			}
-
-			if ($termin->lehrveranstaltung_id !== $first_lv)
-			{
-				$data['errormsg'] = 'Lehrveranstaltungen unterscheiden sich!';
-				$error = true;
-			}
-
-
-			$start = strtotime($termin->termin->von);
-			$max_von = min($max_von, $start);
-			$max_bis = max($max_bis, strtotime($termin->termin->bis));
-			$teilnehmer_min = min($teilnehmer_min, (int)$termin->termin->teilnehmer_min);
-			$teilnehmer_max = max($teilnehmer_max, (int)$termin->termin->teilnehmer_max);
-
-			if (($start - $prevEnd > 0) && $first_ort)
-			{
-				$stunde = new stunde();
-
-				$gapStartStr = date('Y-m-d H:i:s', $prevEnd);
-				$gapEndStr = date('Y-m-d H:i:s', $start);
-
-				$gapStartArr = explode(' ', $gapStartStr);
-				$gapEndArr = explode(' ', $gapEndStr);
-
-				$stunden = $stunde->getStunden($gapStartArr[1], $gapEndArr[1]);
-
-				$reservierung = new reservierung();
-				$reserviert = false;
-
-				$reservierungs_stunden = $reservierung->getReservierungen($first_ort, $gapStartArr[0]);
-
-				$need_stunden = array_diff($stunden, $reservierungs_stunden);
-
-				foreach ($need_stunden as $h)
-				{
-					if ($reservierung->isReserviert($first_ort, $gapStartArr[0], $h))
-						$reserviert = true;
-				}
-
-				if (!$terminkollision && $reserviert && !$first_sammelklausur)
-				{
-					$error = true;
-					$data['errormsg'] = 'Kann nicht zusammengelegt werden, da der Raum reserviert ist';
-				}
-				else
-				{
-					$reservierung->studiengang_kz = "0";
-					$reservierung->ort_kurzbz = $first_ort;
-					$reservierung->uid = $first_mitarbeiter;
-					$reservierung->datum = $gapStartArr[0];
-					$reservierung->titel = $first_titel;
-					if (strlen($first_titel) > 10)
-					{
-						$reservierung->titel = "Prüfung";
-					}
-					$reservierung->beschreibung = "Prüfung";
-					$reservierung->insertamum = date('Y-m-d G:i:s');
-					$reservierung->insertvon = get_uid();
-					$reservierungError = false;
-
-					foreach ($need_stunden as $h)
-					{
-						$reservierung->stunde = $h;
-						if (!$reservierungError)
-						{
-							if (!$reservierung->save(true))
-							{
-								$error = true;
-								$data['errormsg'] = $reservierung->errormsg;
-								$reservierungError = true;
-							}
-						}
-					}
-				}
-			}
-			$prevEnd = strtotime($termin->termin->bis);
-		}
-
-		if (!$error)
-		{
-			$first_pruefungstermin =  new pruefungstermin();
-			$first_pruefungstermin->load($first_termin->termin->pruefungstermin_id);
-
-			$first_pruefungstermin->von = date('Y-m-d H:i:s', $max_von);
-			$first_pruefungstermin->bis = date('Y-m-d H:i:s', $max_bis);
-			$first_pruefungstermin->teilnehmer_min = $teilnehmer_min;
-			$first_pruefungstermin->teilnehmer_max = $teilnehmer_max;
-
-			$first_pruefungstermin->save();
-
-			$alle_termine = array_slice($alle_termine, 1);
-
-			foreach ($alle_termine as $termin)
-			{
-				$anmeldung_termin = new pruefungsanmeldung();
-				$anmeldungen_termine = $anmeldung_termin->getAnmeldungenByTermin($termin->termin->pruefungstermin_id);
-
-				if (count($anmeldungen_termine) === 0)
-				{
-					$first_pruefungstermin->delete($termin->termin->pruefungstermin_id);
-				}
-				$i = 0;
-				$anmeldungen_termine_count = count($anmeldungen_termine);
-				foreach ($anmeldungen_termine as $anmeldungtermin)
-				{
-					$anmeldung = new pruefungsanmeldung();
-					$anmeldung->load($anmeldungtermin->pruefungsanmeldung_id);
-					$old_pruefuengstermin_id = $anmeldung->pruefungstermin_id;
-					$anmeldung->pruefungstermin_id = $first_termin->termin->pruefungstermin_id;
-					if ($anmeldung->save(false) && ($i === $anmeldungen_termine_count - 1))
-					{
-						$first_pruefungstermin->delete($old_pruefuengstermin_id);
-					}
-					$i ++;
-				}
-			}
-		}
-	}
-
-	$data['result']= $result;
-	$data['error']= $error ? 'true' : 'false';
-	//$data['errormsg']='';
-	return $data;
-}
-
 /**
  *
  * @return typespeichert ein Kommentar zu einer Prüfungsanmeldung
@@ -1575,7 +1246,7 @@ function compareRaeume($a, $b)
 	return strcmp($a->ort_kurzbz, $b->ort_kurzbz);
 }
 
-function saveRaum($terminId, $ort_kurzbz, $uid, $anderer_raum = '')
+function saveRaum($terminId, $ort_kurzbz, $uid)
 {
 	$terminkollision = defined('CIS_PRUEFUNGSANMELDUNG_ERLAUBE_TERMINKOLLISION') ? CIS_PRUEFUNGSANMELDUNG_ERLAUBE_TERMINKOLLISION : false;
 	$pruefungstermin = new pruefungstermin($terminId);
@@ -1594,24 +1265,7 @@ function saveRaum($terminId, $ort_kurzbz, $uid, $anderer_raum = '')
 	{
 	$pruefung = new pruefungCis($pruefungstermin->pruefung_id);
 	$mitarbeiter = new mitarbeiter($pruefung->mitarbeiter_uid);
-
-	if ($ort_kurzbz === "" && $anderer_raum !== "")
-	{
-		$pruefungstermin->anderer_raum = $anderer_raum;
-
-		if($pruefungstermin->save(false))
-		{
-			$data['result']="reserviert";
-			$data['error']='false';
-			$data['errormsg']='';
-		}
-		else
-		{
-			$data['error']='true';
-			$data['errormsg']=$pruefungstermin->errormsg;
-		}
-	}
-	else if($ort_kurzbz === "buero")
+	if($ort_kurzbz === "buero")
 	{
 		$pruefungstermin->ort_kurzbz = $mitarbeiter->ort_kurzbz;
 		if($pruefungstermin->save(false))

cis/private/lehre/pruefung/pruefungsanmeldung.php

@@ -321,20 +321,6 @@ $studiensemester->getAll();
 				</td>
 			</tr>
 			<?php endif; ?>
-
-			<?php
-			if (defined('CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE')
-				&& CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE === true):
-			?>
-			<tr>
-				<td style="vertical-align: top; font-weight: bold;">
-					<?php echo $p->t('pruefung/ects'); ?>:
-				</td>
-				<td>
-					<input type="number" size="3" id="ectsangabe" placeholder="<?php echo $p->t('pruefung/ects'); ?>"/>
-				</td>
-			</tr>
-			<?php endif; ?>
 			<tr id="studiengang">
 			</tr>
 			<tr>

cis/private/lehre/pruefung/pruefungsanmeldungen_liste.php

@@ -235,18 +235,12 @@ $rechte->getBerechtigungen($uid);
 			<th><?php echo $p->t('global/datum'); ?></th>
 			<th><?php echo $p->t('benotungstool/note'); ?></th>
 			<th><?php echo $p->t('global/anmerkung'); ?></th>
-
-			<?php
-				if (defined('CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE') && (CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE === true)):
-			?>
-				<th><?php echo $p->t('pruefung/ects'); ?></th>
-			<?php endif; ?>
-
 			</tr>
 		</thead>
 		<tbody>
 			<?php
 			$count = 0;
+			/*@var $anmeldung pruefungsanmeldung */
 			foreach($anmeldungen as $anmeldung)
 			{
 				$student = new student($anmeldung->uid);
@@ -275,8 +269,6 @@ $rechte->getBerechtigungen($uid);
 				echo '<td>'.$date.'</td>';
 				echo '<td></td>';
 				echo '<td></td>';
-				if (defined('CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE') && (CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE === true))
-					echo '<td>'. $anmeldung->ects .'</td>';
 				echo '</tr>';
 			}
 			?>

cis/private/lehre/pruefung/pruefungsanmeldungen_liste_ohne_namen.php

@@ -233,11 +233,6 @@ $rechte->getBerechtigungen($uid);
 			<th><?php echo $p->t('global/datum'); ?></th>
 			<th><?php echo $p->t('benotungstool/note'); ?></th>
 			<th><?php echo $p->t('global/anmerkung'); ?></th>
-			<?php
-				if (defined('CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE') && (CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE === true)):
-			?>
-				<th><?php echo $p->t('pruefung/ects'); ?></th>
-			<?php endif; ?>
 			</tr>
 		</thead>
 		<tbody>
@@ -270,8 +265,6 @@ $rechte->getBerechtigungen($uid);
 				echo '<td>'.$date.'</td>';
 				echo '<td></td>';
 				echo '<td></td>';
-				if (defined('CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE') && (CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE === true))
-					echo '<td>'. $anmeldung->ects .'</td>';
 				echo '</tr>';
 			}
 			?>

cis/private/lehre/pruefung/pruefungsanmeldungen_verwalten.php

@@ -76,7 +76,7 @@ if (empty($pruefung->result) && !$rechte->isBerechtigt('lehre/pruefungsanmeldung
 		width: 850px;
 		padding: 1.8em 1.5em 1.8em 1em;
 		/*border-radius: 25px;*/
-		/*border: 1px solid #dddddd;*/
+		border: 1px solid #dddddd;
 		/*box-shadow: 0em 0em 2em 0.5em #888888 inset;*/
 		}
 
@@ -95,7 +95,7 @@ if (empty($pruefung->result) && !$rechte->isBerechtigt('lehre/pruefungsanmeldung
 		#prfWrapper {
 		position: absolute;
 		height: 70%;
-		width: 40%;
+		width: 300px;
 		top: 180px;
 		padding: 1.8em 1.5em 1.8em 1em;
 		/*border-radius: 25px;*/
@@ -117,9 +117,9 @@ if (empty($pruefung->result) && !$rechte->isBerechtigt('lehre/pruefungsanmeldung
 		#anmWrapper {
 		position: absolute;
 		/*top: 45px;*/
-		left: 45%;
+		left: 350px;
 		top: 180px;
-		width: 40%;
+		width: 500px;
 		height: 70%;
 		padding: 1.8em 1.5em 1.8em 1em;
 		/*border-radius: 25px;*/
@@ -228,6 +228,7 @@ if (empty($pruefung->result) && !$rechte->isBerechtigt('lehre/pruefungsanmeldung
 	<script>
 		$(document).ready(function()
 		{
+			loadStudiengaenge();
 			$("#filter_studiensemester").css("visibility","visible");
 
 			$("#raumDialog").dialog({
@@ -235,66 +236,17 @@ if (empty($pruefung->result) && !$rechte->isBerechtigt('lehre/pruefungsanmeldung
 				autoOpen: false,
 				width: "400px"
 			});
-
-			$("#kommentarDialog").dialog({
-				modal: true,
-				autoOpen: false,
-				width: "400px",
-				buttons: {
-					Ok: function() {
-						$(this).dialog('close');
-					}
-				}
-			});
-
-			$("#table4").tablesorter({
-				widgets: ["zebra"],
-				headers: {
-					0: { sorter: false },
-					3: { sorter: 'shortDate',
-						dateFormat: 'ddmmyyyy' },
-					4: { sorter: 'time' },
-					5: { sorter: 'time' }
-				}
-			});
-
-
-			$('#zusammenlegen').on('click', function() {
-				let ausgewaehlte_termine = $('.termin-checkbox:checked');
-
-				if (ausgewaehlte_termine.length === 0)
-					return;
-
-				let erster_termin = ausgewaehlte_termine.first();
-				let erstes_datum = erster_termin.data('datum');
-				let erste_lvid = erster_termin.data('lv-id');
-
-				let termine = [];
-				ausgewaehlte_termine.each(function() {{
-					let termin = $(this);
-					let datum = termin.data('datum');
-					let lv_id = termin.data('lv-id');
-
-					if (erstes_datum !== datum)
-						return alert("Die ausgewählten Termine liegen nicht am selben Tag und können daher nicht zusammengelegt werden.")
-					if (erste_lvid !== lv_id)
-						return alert("Bei den ausgewählten Terminen handelt es sich um unterschiedliche Lehrveranstaltungen, die daher nicht zusammengelegt werden können.")
-
-					termine.push(termin.data('termin-id'));
-				}})
-
-				if (termine.length > 0)
-				{
-					terminezusammenlegen(termine, erste_lvid);
-				}
-			})
-
-			loadPruefungStudiengang();
 		});
 	</script>
 	<h1><?php echo $p->t('pruefung/anmeldungenVerwalten'); ?></h1>
 	<div id='stgWrapper'>
+		<div id='studiengaenge'>
+		<div>
+			<h2><?php echo $p->t('global/studiengang'); ?></h2>
+			<div id='stgListe'>
 
+			</div>
+		</div>
 		<div>
 			<h2><?php echo $p->t('global/studiensemester'); ?></h2>
 			<?php
@@ -303,6 +255,7 @@ if (empty($pruefung->result) && !$rechte->isBerechtigt('lehre/pruefungsanmeldung
 			$studiensemester->getPlusMinus(null, 5);
 			foreach($studiensemester->studiensemester as $sem)
 			{
+				/*@var $sem studiensemester */
 				if ($aktuellesSemester == $sem->studiensemester_kurzbz)
 				{
 				echo '<option selected value="'.$sem->studiensemester_kurzbz.'">'.$sem->bezeichnung.'</option>';
@@ -320,21 +273,9 @@ if (empty($pruefung->result) && !$rechte->isBerechtigt('lehre/pruefungsanmeldung
 	<div id='prfWrapper'>
 		<div id='pruefungen'>
 		<h2><?php echo $p->t('pruefung/pruefungPruefungenTitle'); ?></h2>
-		<button id="zusammenlegen">Termine zusammenlegen</button>
-		<table id="table4" class="tablesorter" style="display:none">
-			<thead>
-				<tr>
-					<th></th>
-					<th><?php echo $p->t('global/studiengang'); ?></th>
-					<th><?php echo $p->t('global/lehrveranstaltung'); ?></th>
-					<th><?php echo $p->t('global/datum'); ?></th>
-					<th><?php echo $p->t('global/von'); ?></th>
-					<th><?php echo $p->t('global/bis'); ?></th>
-					<th><?php echo $p->t('pruefung/pruefungsbewertungAnmeldungen'); ?></th>
-				</tr>
-			</thead>
-			<tbody id="pruefungenListe"></tbody>
-		</table>
+		<ul id="pruefungenListe">
+
+		</ul>
 		</div>
 	</div>
 	<div id='anmWrapper'>
@@ -370,9 +311,6 @@ if (empty($pruefung->result) && !$rechte->isBerechtigt('lehre/pruefungsanmeldung
 			</div>
 		</div>
 		</div>
-		<div id="kommentarDialog" title="<?php echo $p->t('pruefung/anmerkungDesStudenten'); ?>" style="display:none;">
-			<div id="kommentarimDialog"></div>
-		</div>
 	</div>
 
 	<div id="message"></div>

cis/private/profile/studienplan.php

@@ -69,8 +69,6 @@ if(isset($_GET['getAnmeldung']))
 
 	$lehrveranstaltung_id=$_GET['lehrveranstaltung_id'];
 	$stsem = $_GET['stsem'];
-	$semester = $_GET['semester'];
-	$studienplan_id = $_GET['studienplan_id'];
 
 	echo $p->t('studienplan/LehrveranstalungWaehlen').'
 		<form action="'.$_SERVER['PHP_SELF'].'?uid='.$db->convert_html_chars($uid).'" method="POST">
@@ -85,10 +83,6 @@ if(isset($_GET['getAnmeldung']))
 	$datum = new datum();
 	$kompatibel[]=$lehrveranstaltung_id;
 	$kompatibel = array_unique($kompatibel);
-	$stsem_obj = new studiensemester();
-	$aktornext = $stsem_obj->getaktorNext();
-
-	$lvregel = new lvregel();
 	foreach($kompatibel as $lvid)
 	{
 		$lvangebot = new  lvangebot();
@@ -101,50 +95,19 @@ if(isset($_GET['getAnmeldung']))
 			$angebot = $lvangebot->result[0];
 			if($angebot->AnmeldungMoeglich())
 			{
-				$kompatible_lv = $lehrveranstaltung->getStudienplanLehrveranstaltung($lvid, $studienplan_id);
+				$anzahl++;
+				// LV wird angeboten und Anmeldefenster ist offen
 
-				$lvregelExists = false;
-				$abgeschlossen = false;
-				$semesterlock = false;
-				$regelerfuellt = true;
-
-				if ($kompatible_lv)
+				$bngruppe = new benutzergruppe();
+				if(!$bngruppe->load($uid, $lvangebot->result[0]->gruppe_kurzbz, $stsem))
 				{
-					$lvregelExists = $lvregel->exists($kompatible_lv);
-
-					if(!$lvregel->checkSemester($kompatible_lv, $semester))
-					{
-						$semesterlock=true;
-					}
-					else
-					{
-						if($stsem === $aktornext)
-						{
-							$result = $lvregel->isZugangsberechtigt($uid, $kompatible_lv, $stsem);
-							if((is_array($result)) && ($result[0] !== true))
-							{
-								$regelerfuellt=false;
-							}
-						}
-					}
+					// User ist noch nicht angemeldet
+					echo '<br><input type="radio" value="'.$lvid.'" name="lv"/>'.$lv->bezeichnung.' (Anmeldung bis '.$datum->formatDatum($angebot->anmeldefenster_ende,"d.m.Y").')';
 				}
-
-				if (!$semesterlock && $regelerfuellt)
+				else
 				{
-					$anzahl++;
-					// LV wird angeboten und Anmeldefenster ist offen
-
-					$bngruppe = new benutzergruppe();
-					if(!$bngruppe->load($uid, $lvangebot->result[0]->gruppe_kurzbz, $stsem))
-					{
-						// User ist noch nicht angemeldet
-						echo '<br><input type="radio" value="'.$lvid.'" name="lv"/>'.$lv->bezeichnung.' (Anmeldung bis '.$datum->formatDatum($angebot->anmeldefenster_ende,"d.m.Y").')';
-					}
-					else
-					{
-						// Bereits angemeldet
-						echo '<br><input type="radio" disabled="true" value="'.$lvid.'" name="lv" /><span class="ok">'.$lv->bezeichnung.'</span><img src="../../../skin/images/information.png" title="'.$p->t('studienplan/bereitsAngemeldet').'"/>';
-					}
+					// Bereits angemeldet
+					echo '<br><input type="radio" disabled="true" value="'.$lvid.'" name="lv" /><span class="ok">'.$lv->bezeichnung.'</span><img src="../../../skin/images/information.png" title="'.$p->t('studienplan/bereitsAngemeldet').'"/>';
 				}
 			}
 /*			else
@@ -207,9 +170,9 @@ echo '
 		$("#dialog").dialog({ autoOpen: false, width: "auto" });
 	});
 
-	function OpenAnmeldung(lehrveranstaltung_id, stsem, semester, studienplan_id)
+	function OpenAnmeldung(lehrveranstaltung_id, stsem)
 	{
-		$("#dialog").load("studienplan.php?getAnmeldung=true&lehrveranstaltung_id="+lehrveranstaltung_id+"&stsem="+stsem+"&semester="+semester+"&studienplan_id="+studienplan_id+"&uid='.$db->convert_html_chars($uid).'");
+		$("#dialog").load("studienplan.php?getAnmeldung=true&lehrveranstaltung_id="+lehrveranstaltung_id+"&stsem="+stsem+"&uid='.$db->convert_html_chars($uid).'");
 		$("#dialog").dialog("open");
 	}
 	</script>
@@ -396,7 +359,7 @@ drawTree($tree,0);
 
 function drawTree($tree, $depth)
 {
-	global $uid, $stsem_arr, $noten_arr, $lvangebot_arr, $aktornext, $studienplan_id;
+	global $uid, $stsem_arr, $noten_arr, $lvangebot_arr, $aktornext;
 	global $datum_obj, $db, $lv_arr, $p, $note_pruef_arr, $student;
 	global $anrechnung;
 
@@ -676,12 +639,12 @@ function drawTree($tree, $depth)
 						$tdclass[]='angebot';
 						if($angemeldet)
 						{
-							$tdinhalt.= '<a href="#" onclick="OpenAnmeldung(\''.$row_tree->lehrveranstaltung_id.'\',\''.$stsem.'\',\''.$semester.'\',\''.$studienplan_id.'\'); return false;"><img src="../../../skin/images/ja.png" title="'.$p->t('studienplan/legendeAngemeldet').'" /></a>';
+							$tdinhalt.= '<a href="#" onclick="OpenAnmeldung(\''.$row_tree->lehrveranstaltung_id.'\',\''.$stsem.'\'); return false;"><img src="../../../skin/images/ja.png" title="'.$p->t('studienplan/legendeAngemeldet').'" /></a>';
 						}
 						else
 						{
 							if($anmeldungmoeglich)
-								$tdinhalt.= '<a href="#" onclick="OpenAnmeldung(\''.$row_tree->lehrveranstaltung_id.'\',\''.$stsem.'\', \''.$semester.'\', \''.$studienplan_id.'\'); return false;"><img src="../../../skin/images/anmelden.png" title="'.$p->t('studienplan/anmelden').'" height="15px" /></a>';
+								$tdinhalt.= '<a href="#" onclick="OpenAnmeldung(\''.$row_tree->lehrveranstaltung_id.'\',\''.$stsem.'\'); return false;"><img src="../../../skin/images/anmelden.png" title="'.$p->t('studienplan/anmelden').'" height="15px" /></a>';
 							else
 								$tdinhalt.= '<span title="'.$anmeldeinformation.'">-</a>';
 

config/cis.config-default.inc.php

@@ -249,9 +249,6 @@ define('CIS_INFOSCREEN_NEWS_ANZEIGEN',false);
 //User, welcher für das Anlegen von Anrechnungen bei der Prüfungsanmeldung verwendet wird
 define('CIS_PRUEFUNGSANMELDUNG_USER','p.pruefungsanmeldung');
 
-//Gibt an, ob die Studierenden bei der Anmeldung zu einer Prüfung den Ausmas an ECTS angeben können
-define('CIS_PRUEFUNGSANMELDUNG_ECTS_ANGABE', false);
-
 // Anmeldefristen für Prüfungen in Tagen;
 // Wenn nicht definiert: 3
 //define('CIS_PRUEFUNGSANMELDUNG_FRIST',3);

config/global.config-default.inc.php

@@ -162,12 +162,6 @@ define('CIS_LV_LEKTORINNENZUTEILUNG_VERTRAGSPRUEFUNG_VON', '');
 // Legt fest, ob Vertragsdetails zum Projektauftrag im Reiter Projektarbeit angezeigt werden
 define('FAS_STUDIERENDE_PROJEKTARBEIT_VERTRAGSDETAILS_ANZEIGEN', false);
 
-// Legt default Stunden pro Projektarbeitsbetreuung für Bachelorarbeiten fest
-define('FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_BACHELOR', '5.0');
-
-// Legt default Stunden pro Projektarbeitsbetreuung für Masterarbeiten fest
-define('FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_MASTER', '5.0');
-
 // Anzeigeoptionen für LV-Plan Menü
 define('CIS_LVPLAN_EXPORT_ANZEIGEN',true);
 define('CIS_LVPLAN_PERSONENAUSWAHL_ANZEIGEN',true);

content/statistik/notenspiegel.php

@@ -62,11 +62,6 @@ if(!$rechte->isBerechtigt('student/noten',$studiengang_kz, 's'))
 $semester = isset($_GET['semester'])?$_GET['semester']:'';
 $typ = isset($_GET['typ'])?$_GET['typ']:'';
 
-if(isset($_GET['studiensemester']) && preg_match('/[WS]S[0-9]{4}/', $_GET['studiensemester']))
-{
-	$semester_aktuell = $_GET['studiensemester'];
-}
-
 if($semester=='')
 	die('Bitte ein Semester auswaehlen');
 	

content/statistik/notenspiegel_erweitert.php

@@ -64,11 +64,6 @@ if (!$rechte->isBerechtigt('student/noten', $studiengang_kz, 's'))
 $semester = isset($_GET['semester']) ? $_GET['semester'] : '';
 $typ = isset($_GET['typ']) ? $_GET['typ'] : '';
 
-if(isset($_GET['studiensemester']) && preg_match('/[WS]S[0-9]{4}/', $_GET['studiensemester']))
-{
-	$semester_aktuell = $_GET['studiensemester'];
-}
-
 if ($semester == '')
 	die('Bitte ein Semester auswaehlen');
 

content/student/studentprojektarbeit.js.php

@@ -1165,14 +1165,12 @@ function StudentProjektbetreuerDetailReset()
 
 	if(document.getElementById('student-projektarbeit-menulist-projekttyp').value=='Diplom')
 	{
-		document.getElementById('student-projektbetreuer-textbox-stunden').value=
-			<?php if (defined('FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_MASTER') && FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_MASTER) echo FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_MASTER; else echo '5'; ?>;
+		document.getElementById('student-projektbetreuer-textbox-stunden').value='5.0';
 		document.getElementById('student-projektbetreuer-menulist-betreuerart').value='Erstbegutachter';
 	}
 	else if(document.getElementById('student-projektarbeit-menulist-projekttyp').value=='Bachelor')
 	{
-		document.getElementById('student-projektbetreuer-textbox-stunden').value=
-			<?php if (defined('FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_BACHELOR') && FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_BACHELOR) echo FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_BACHELOR; else echo '4'; ?>;
+		document.getElementById('student-projektbetreuer-textbox-stunden').value='4.0';
 		document.getElementById('student-projektbetreuer-menulist-betreuerart').value='Begutachter';
 	}
 	else if(document.getElementById('student-projektarbeit-menulist-projekttyp').value=='Praktikum')

include/File/CSV.php

@@ -178,7 +178,7 @@ class File_CSV
             return $field;
         }
 
-        if ($quote && $field[0] == $quote && $field[strlen($field) - 1] == $quote) {
+        if ($quote && $field{0} == $quote && $field{strlen($field)-1} == $quote) {
             return substr($field, 1, -1);
         }
         return $field;
@@ -230,7 +230,7 @@ class File_CSV
                 } elseif ($c == "\n" || $c == "\r") {
                     $sub = ($prev == "\r") ? 2 : 1;
                     if ((strlen($buff) >= $sub) &&
-                        ($buff[strlen($buff) - $sub] == $quote))
+                        ($buff{strlen($buff) - $sub} == $quote))
                     {
                         $in_quote = false;
                     }
@@ -312,9 +312,9 @@ class File_CSV
             $last =& $fields[count($fields) - 1];
             // Fallback to read the line with readQuoted when guess
             // that the simple explode won't work right
-            if (($last[strlen($last) - 1] == "\n"
-                && $last[0] == $conf['quote']
-                && $last[strlen(rtrim($last)) - 1] != $conf['quote'])
+            if (($last{strlen($last) - 1} == "\n"
+                && $last{0} == $conf['quote']
+                && $last{strlen(rtrim($last)) - 1} != $conf['quote'])
                 ||
                 (count($fields) != $conf['fields'])
                 // XXX perhaps there is a separator inside a quoted field
@@ -511,4 +511,4 @@ class File_CSV
         return true;
     }
 }
-?>
+?>

include/File/Util.php

@@ -96,7 +96,7 @@ class File_Util
     {
         if (File_Util::isAbsolute($path)) {
             if (FILE_WIN32) {
-                return substr($path, $path[3] == '\\' ? 4 : 3);
+                return substr($path, $path{3} == '\\' ? 4 : 3);
             }
             return ltrim($path, '/');
         }
@@ -182,7 +182,7 @@ class File_Util
         if (FILE_WIN32) {
             return preg_match('/^[a-zA-Z]:(\\\|\/)/', $path);
         }
-        return ($path[0] == '/') || ($path[0] == '~');
+        return ($path{0} == '/') || ($path{0} == '~');
     } 
 
     /**
@@ -244,11 +244,11 @@ class File_Util
             } else {
                 $cwd   = getcwd();
                 $drive = substr($cwd, 0, 2);
-                if ($path[0] !== $separator[0]) {
+                if ($path{0} !== $separator{0}) {
                     $path  = substr($cwd, 3) . $separator . $path;
                 }
             }
-        } elseif ($path[0] !== $separator) {
+        } elseif ($path{0} !== $separator) {
             $path = getcwd() . $separator . $path;
         }
         
@@ -323,7 +323,7 @@ class File_Util
         
         $entries = array();
         for ($dir = dir($path); false !== $entry = $dir->read(); ) {
-            if ($list & FILE_LIST_DOTS || $entry[0] !== '.') {
+            if ($list & FILE_LIST_DOTS || $entry{0} !== '.') {
                 $isRef = ($entry === '.' || $entry === '..');
                 $isDir = $isRef || is_dir($path .'/'. $entry);
                 if (    ((!$isDir && $list & FILE_LIST_FILES)   ||

include/dokument.class.php

@@ -888,10 +888,9 @@ class dokument extends basis_db
 	 * Akzeptiert ein bestimmtes Dokument
 	 * @param char $dokument_kurzbz Bezeichner Dokument.
 	 * @param int $person_id Personenkennzeichen.
-	 * @param array $studiengang_typen einschränken nach Studiengang Typ.
 	 * @return boolean true wenn akzeptiert bzw geprüft ohne Akzeptieren, false wenn Fehler
 	 */
-	public function akzeptiereDokument($dokument_kurzbz, $person_id, $studiengang_typen = null)
+	public function akzeptiereDokument($dokument_kurzbz, $person_id)
 	{
 		$db = new basis_db();
 		$arrayDoksZuAkzeptieren = array();
@@ -903,6 +902,7 @@ class dokument extends basis_db
 					tbl_prestudent ps, tbl_studiengang sg
 				WHERE
 					ps.studiengang_kz = sg.studiengang_kz
+				AND sg.typ = 'm'
 				AND person_id = ".$this->db_add_param($person_id)."
 				AND not exists(
 					SELECT *
@@ -910,11 +910,6 @@ class dokument extends basis_db
 					where dok.prestudent_id = ps.prestudent_id
 					and dokument_kurzbz = ".$this->db_add_param($dokument_kurzbz).")";
 
-		if (isset($studiengang_typen) && is_array($studiengang_typen) && !empty($studiengang_typen))
-		{
-			$qry .= ' AND sg.typ IN ('. $db->db_implode4SQL($studiengang_typen).')';
-		}
-
 		//gibt ein Array von zu akzeptierenden Dokumenten zurück
 		if ($db->db_query($qry))
 		{
@@ -928,14 +923,11 @@ class dokument extends basis_db
 				}
 
 				//für alle prestudent_ids das Dokument akzeptieren
-				$qry = "INSERT INTO public.tbl_dokumentprestudent(dokument_kurzbz, prestudent_id, datum, insertamum) VALUES";
+				$qry = "INSERT INTO public.tbl_dokumentprestudent(dokument_kurzbz, prestudent_id) VALUES";
 
 				foreach ($arrayDoksZuAkzeptieren as $prestudent_id)
 				{
-					$qry .= "(".$this->db_add_param($dokument_kurzbz).
-						",".$this->db_add_param($prestudent_id, FHC_INTEGER).
-						",".$this->db_add_param(date('Y-m-d')).
-						",".$this->db_add_param(strftime('%Y-%m-%d %H:%M')). ")";
+					$qry .= "(".$this->db_add_param($dokument_kurzbz). ",". $prestudent_id. ")";
 
 					if (next($arrayDoksZuAkzeptieren) == true)
 					{

include/filter.class.php

@@ -240,7 +240,7 @@ class filter extends basis_db
 								{
 									//$value->value = preg_replace('/(.*?)selected=.selected./', '$1', $value->value);
 									//$value->value = preg_replace('/(.*?)\s*[selected=?selected?]/', '$1', $value->value);
-									//$value->value = preg_replace('/(.*?)\s*selected="selected"\s*/', '$[1]', $value->value);
+									//$value->value = preg_replace('/(.*?)\s*selected="selected"\s*/', '${1}', $value->value);
 									//$value->value = preg_replace('/^\s*selected=.*?selected.*?\s*/', ' ', $value->value);
 									//$value->value = str_replace('selected=', '', $value->value);
 

include/lehrveranstaltung.class.php

@@ -2861,33 +2861,5 @@ class lehrveranstaltung extends basis_db
 			return false;
 		}
 	}
-
-	public function getStudienplanLehrveranstaltung($lehrveranstaltung_id, $studienplan_id)
-	{
-		$qry = "SELECT studienplan_lehrveranstaltung_id
-				FROM lehre.tbl_lehrveranstaltung
-				JOIN lehre.tbl_studienplan_lehrveranstaltung USING(lehrveranstaltung_id)
-				WHERE lehrveranstaltung_id = ".$this->db_add_param($lehrveranstaltung_id)."
-					AND tbl_studienplan_lehrveranstaltung.studienplan_id = ".$this->db_add_param($studienplan_id);"";
-
-		if($result = $this->db_query($qry))
-		{
-			if($row = $this->db_fetch_object($result))
-			{
-				return $row->studienplan_lehrveranstaltung_id;
-			}
-			else
-			{
-				$this->errormsg = 'Fehler beim Ermitteln der studienplan_lehrveranstaltung_id';
-				return false;
-			}
-		}
-		else
-		{
-			$this->errormsg='Fehler bei Datenbankabfrage ' .$this->db_last_error();
-		}
-		return null;
-
-	}
 }
 ?>

include/pruefungCis.class.php

@@ -464,7 +464,6 @@ class pruefungCis extends basis_db
 		$obj->anmeldung_von= $row->anmeldung_von;
                 $obj->anmeldung_bis = $row->anmeldung_bis;
 		$obj->ort_kurzbz = $row->ort_kurzbz;
-		$obj->anderer_raum = $row->anderer_raum;
 		$obj->sammelklausur = $row->sammelklausur;
                 array_push($this->termine, $obj);
             }
@@ -647,37 +646,6 @@ class pruefungCis extends basis_db
         return false;
     }
 
-	public function getPruefungByStudiensemester($studiensemester_kurzbz)
-    {
-        if(empty($studiensemester_kurzbz))
-        {
-           $this->errormsg = "Kein Studiensemester übergeben.</br>";
-           return false;
-        }
-
-		$qry = 'SELECT * 
-				FROM campus.tbl_lehrveranstaltung_pruefung
-				JOIN lehre.tbl_lehrveranstaltung USING(lehrveranstaltung_id)
-				JOIN campus.tbl_pruefung USING (pruefung_id)
-				WHERE tbl_pruefung.studiensemester_kurzbz = ' . $this->db_add_param($studiensemester_kurzbz);
-
-        if($this->db_query($qry))
-        {
-            while($row = $this->db_fetch_object())
-            {
-                $obj = new stdClass();
-                $obj->lehrveranstaltung_pruefung_id = $row->lehrveranstaltung_pruefung_id;
-                $obj->lehrveranstaltung_id = $row->lehrveranstaltung_id;
-                $obj->pruefung_id = $row->pruefung_id;
-                $obj->storniert = $row->storniert;
-				$obj->bezeichnung = $row->bezeichnung;
-                array_push($this->lehrveranstaltungen, $obj);
-            }
-            return true;
-        }
-        return false;
-    }
-
     /**
      * Lädt alle Prüfung-Lehrveranstaltung Kombinationen
      * @return boolean true, wenn ok; false, im Fehlerfall

include/pruefungsanmeldung.class.php

@@ -39,7 +39,6 @@ class pruefungsanmeldung extends basis_db {
     public $statusupdatevon;		//varchar(32)
     public $statusupdateamum;		//timestamp
     public $anrechnung_id;		//integer
-    public $ects;		//integer
     public $pruefungstyp_kurzbz;		//varchar(32)
     public $insertamum; // timestamp
 
@@ -95,7 +94,7 @@ class pruefungsanmeldung extends basis_db {
 
         if($new)
         {
-            $qry = 'INSERT INTO campus.tbl_pruefungsanmeldung (uid, pruefungstermin_id, lehrveranstaltung_id, status_kurzbz, wuensche, reihung, kommentar, anrechnung_id, pruefungstyp_kurzbz, ects) VALUES ('
+            $qry = 'INSERT INTO campus.tbl_pruefungsanmeldung (uid, pruefungstermin_id, lehrveranstaltung_id, status_kurzbz, wuensche, reihung, kommentar, anrechnung_id, pruefungstyp_kurzbz) VALUES ('
                     . $this->db_add_param($this->uid).', '
                     . $this->db_add_param($this->pruefungstermin_id).', '
                     . $this->db_add_param($this->lehrveranstaltung_id).', '
@@ -104,8 +103,7 @@ class pruefungsanmeldung extends basis_db {
                     . $this->db_add_param($this->reihung).', '
                     . $this->db_add_param($this->kommentar).', '
 		    . $this->db_add_param($this->anrechnung_id).', '
-		    . $this->db_add_param($this->pruefungstyp_kurzbz).', '
-		    . $this->db_add_param($this->ects).');';
+		    . $this->db_add_param($this->pruefungstyp_kurzbz).');';
         }
         else
         {
@@ -118,8 +116,7 @@ class pruefungsanmeldung extends basis_db {
 		    . 'reihung='.$this->db_add_param($this->reihung).', '
 		    . 'kommentar='.$this->db_add_param($this->kommentar).', '
 		    . 'anrechnung_id='.$this->db_add_param($this->anrechnung_id).', '
-		    . 'pruefungstyp_kurzbz='.$this->db_add_param($this->pruefungstyp_kurzbz).', '
-		    . 'ects='.$this->db_add_param($this->ects)
+		    . 'pruefungstyp_kurzbz='.$this->db_add_param($this->pruefungstyp_kurzbz)
 		    . ' WHERE pruefungsanmeldung_id='.$this->db_add_param($this->pruefungsanmeldung_id).';';
         }
 
@@ -170,7 +167,6 @@ class pruefungsanmeldung extends basis_db {
 		$this->statusupdatevon = $row->statusupdatevon;
 		$this->anrechnung_id = $row->anrechnung_id;
 		$this->pruefungstyp_kurzbz = $row->pruefungstyp_kurzbz;
-		$this->ects = $row->ects;
         $this->insertamum = $row->insertamum;
             }
             return true;
@@ -225,7 +221,6 @@ class pruefungsanmeldung extends basis_db {
 				$anmeldung->statusupdatevon = $row->statusupdatevon;
 				$anmeldung->anrechnung_id = $row->anrechnung_id;
 				$anmeldung->pruefungstyp_kurzbz = $row->pruefungstyp_kurzbz;
-				$anmeldung->ects = $row->ects;
                 array_push($anmeldungen, $anmeldung);
             }
             return $anmeldungen;
@@ -285,7 +280,6 @@ class pruefungsanmeldung extends basis_db {
 		$anmeldung->statusupdatevon = $row->statusupdatevon;
 		$anmeldung->anrechnung_id = $row->anrechnung_id;
 		$anmeldung->pruefungstyp_kurzbz = $row->pruefungstyp_kurzbz;
-		$anmeldung->ects = $row->ects;
         $anmeldung->datum_anmeldung = $row->datum_anmeldung;
                 array_push($anmeldungen, $anmeldung);
             }

include/pruefungstermin.class.php

@@ -37,7 +37,6 @@ class pruefungstermin extends basis_db{
     public $anmeldung_von;	    //date
     public $anmeldung_bis;	    //date
     public $ort_kurzbz;		    //varchar(16)
-    public $anderer_raum;		    //text
     public $sammelklausur;		//boolean
     
     /**
@@ -94,7 +93,6 @@ class pruefungstermin extends basis_db{
 		$this->anmeldung_von= $row->anmeldung_von;
                 $this->anmeldung_bis = $row->anmeldung_bis;
 		$this->ort_kurzbz = $row->ort_kurzbz;
-		$this->anderer_raum = $row->anderer_raum;
 		$this->sammelklausur = $row->sammelklausur;
             }
             return true;
@@ -181,8 +179,7 @@ class pruefungstermin extends basis_db{
 		    . 'teilnehmer_min='.$this->db_add_param($this->teilnehmer_min).', '
 		    . 'anmeldung_von='.$this->db_add_param($this->anmeldung_von).', '
 		    . 'anmeldung_bis='.$this->db_add_param($this->anmeldung_bis).', '
-		    . 'ort_kurzbz='.$this->db_add_param($this->ort_kurzbz).', '
-		    . 'anderer_raum='.$this->db_add_param($this->anderer_raum).' '
+		    . 'ort_kurzbz='.$this->db_add_param($this->ort_kurzbz).' '
 		    . 'WHERE pruefungstermin_id='.$this->db_add_param($this->pruefungstermin_id).';';
 	}
 	
@@ -231,7 +228,6 @@ class pruefungstermin extends basis_db{
 		$obj->anmeldung_von= $row->anmeldung_von;
                 $obj->anmeldung_bis = $row->anmeldung_bis;
 		$obj->ort_kurzbz = $row->ort_kurzbz;
-		$obj->anderer_raum = $row->anderer_raum;
 		$obj->sammelklausur = $row->sammelklausur;
 		array_push($this->result, $obj);
 	    }
@@ -244,20 +240,4 @@ class pruefungstermin extends basis_db{
 	}
 	
     }
-
-	public function delete($pruefungstermin_id)
-	{
-		$qry = "DELETE FROM campus.tbl_pruefungstermin WHERE pruefungstermin_id=".$this->db_add_param($pruefungstermin_id).";";
-
-		if($this->db_query($qry))
-		{
-			return true;
-		}
-		else
-		{
-			$this->errormsg='Fehler beim Löschen des Eintrages';
-			return false;
-		}
-	}
-
 }

include/reservierung.class.php

@@ -322,37 +322,5 @@ class reservierung extends basis_db
 		}
 				
 	}
-
-	public function getReservierungen($ort_kurzbz, $datum)
-	{
-		$datum_obj = new Datum();
-		if(!$datum_obj->checkDatum($datum))
-		{
-			$this->errormsg='Datum hat ein ungueltiges Format';
-			return false;
-		}
-
-		$qry = "SELECT stunde FROM campus.tbl_reservierung 
-				WHERE 
-					ort_kurzbz=".$this->db_add_param($ort_kurzbz)." AND 
-					datum=".$this->db_add_param($datum);
-
-
-		if($this->db_query($qry))
-		{
-			$result = array();
-			while($row = $this->db_fetch_object())
-			{
-				$result[] = $row->stunde;
-			}
-		}
-		else
-		{
-			$this->errormsg = "Prüfungstypen konnten nicht geladen werden.";
-			return false;
-		}
-
-		return $result;
-	}
 }
 ?>

include/securimage/WavFile.php

@@ -1532,7 +1532,7 @@ class WavFile
         } else {
             // replace
             for ($i = 0; $i < $sampleBytes; ++$i) {
-                $this->_samples[$offset + $i] = $sampleBinary[$i];
+                $this->_samples{$offset + $i} = $sampleBinary{$i};
             }
         }
 

include/securimage/securimage.php

@@ -1435,7 +1435,7 @@ class Securimage
             $length = strlen($code['display']);
 
             for($i = 0; $i < $length; ++$i) {
-                $letter    = $code['display'][$i];
+                $letter    = $code['display']{$i};
                 $letters[] = $letter;
             }
         }

locale/de-AT/pruefung.php

@@ -57,7 +57,6 @@ $this->phrasen['pruefung/listeOhneNamenDrucken'] = 'Liste ohne Namen drucken';
 $this->phrasen['pruefung/pruefungsraum'] = 'Prüfungsraum: ';
 $this->phrasen['pruefung/pruefungsort'] = 'Prüfungsort ';
 $this->phrasen['pruefung/imBuero'] = ' im Büro';
-$this->phrasen['pruefung/andererRaum'] = 'anderer Raum';
 $this->phrasen['pruefung/raum'] = ' Raum';
 $this->phrasen['pruefung/raumSpeichern'] = ' Raum speichern';
 $this->phrasen['pruefung/reihunghErfolgreichGeaendert'] = 'Reihung erfolgreich geändert.';
@@ -78,7 +77,6 @@ $this->phrasen['pruefung/unbegrenzt'] = 'unbegrenzt';
 $this->phrasen['pruefung/bewertungenZu'] = 'Bewertungen zu';
 $this->phrasen['pruefung/keineAuswahl'] = 'Keine Auswahl';
 $this->phrasen['pruefung/alleBestaetigen'] = 'Alle bestätigen';
-$this->phrasen['pruefung/bitteEmailAngeben'] = 'Bitte geben Sie eine gültige E-Mail-Adresse ein.';
 
 // pruefungsbewertung
 $this->phrasen['pruefung/pruefungsbewertungTitle'] = 'Prüfungsbewertung';
@@ -97,7 +95,6 @@ $this->phrasen['pruefung/lvVonStudiengang'] = 'Lehrveranstaltungen von Studienga
 $this->phrasen['pruefung/lvAlle'] = 'Alle Lehrveranstaltungen';
 $this->phrasen['pruefung/anmeldungSpeichern'] = 'Anmeldung speichern';
 $this->phrasen['pruefung/studienverpflichtung'] = 'Studienverpflichtung';
-$this->phrasen['pruefung/ects'] = 'ECTS';
 
 // liste
 $this->phrasen['pruefung/anmeldungsliste'] = 'Anmeldungsliste';
@@ -142,15 +139,6 @@ $this->phrasen['pruefung/emailBodyOrt'] = 'Ort:';
 $this->phrasen['pruefung/emailBodyLinkZurAnmeldung'] = 'Link zur Anmeldung';
 $this->phrasen['pruefung/emailBodyBitteHtmlSicht'] = 'Bitte sehen Sie sich die Nachricht in HTML Sicht an, um den Link vollständig darzustellen.';
 
-
-// Sammelmail
-$this->phrasen['pruefung/sammelemailBody'] = 'Die Anmeldungen zur Prüfung %s am %s wurde von %s bestätigt. <br />';
-$this->phrasen['pruefung/sammelemailBody2'] = 'Ort: %s<br />';
-$this->phrasen['pruefung/sammelemailBodyBestaetigt'] = 'Bestätigt von';
-$this->phrasen['pruefung/sammelemailBodyPruefung'] = 'Prüfung';
-$this->phrasen['pruefung/sammelemailBodyTermin'] = 'Termin';
-$this->phrasen['pruefung/sammelemailBodyDauer'] = 'Dauer';
-
 $this->phrasen['pruefung/emailLektorSubjectAnmeldung'] = 'Anmeldung zur Prüfung';
 $this->phrasen['pruefung/emailLektorStudentIn'] = 'StudentIn';
 $this->phrasen['pruefung/emailLektorHatSichZurPruefung'] = 'hat sich zur Prüfung';

locale/en-US/pruefung.php

@@ -57,7 +57,6 @@ $this->phrasen['pruefung/listeOhneNamenDrucken'] = 'Liste ohne Namen drucken';
 $this->phrasen['pruefung/pruefungsraum'] = 'Prüfungsraum: ';
 $this->phrasen['pruefung/pruefungsort'] = 'Prüfungsort ';
 $this->phrasen['pruefung/imBuero'] = ' im Büro';
-$this->phrasen['pruefung/andererRaum'] = 'other Room';
 $this->phrasen['pruefung/raum'] = ' Raum';
 $this->phrasen['pruefung/raumSpeichern'] = ' Raum speichern';
 $this->phrasen['pruefung/reihunghErfolgreichGeaendert'] = 'Reihung erfolgreich geändert.';
@@ -78,7 +77,6 @@ $this->phrasen['pruefung/unbegrenzt'] = 'unlimited';
 $this->phrasen['pruefung/bewertungenZu'] = 'Bewertungen zu';
 $this->phrasen['pruefung/keineAuswahl'] = 'Keine Auswahl';
 $this->phrasen['pruefung/alleBestaetigen'] = 'Confirm all';
-$this->phrasen['pruefung/bitteEmailAngeben'] = 'Please enter a valid E-Mail Address.';
 
 // pruefungsbewertung
 $this->phrasen['pruefung/pruefungsbewertungTitle'] = 'Prüfungsbewertung';
@@ -141,14 +139,6 @@ $this->phrasen['pruefung/emailBodyOrt'] = 'Ort:';
 $this->phrasen['pruefung/emailBodyLinkZurAnmeldung'] = 'Link zur Anmeldung';
 $this->phrasen['pruefung/emailBodyBitteHtmlSicht'] = 'Bitte sehen Sie sich die Nachricht in HTML Sicht an, um den Link vollständig darzustellen.';
 
-// Sammelmail
-$this->phrasen['pruefung/sammelemailBody'] = 'The exam registrations for %s on %s have been confirmed by %s. <br />';
-$this->phrasen['pruefung/sammelemailBody2'] = 'Place: %s<br />';
-$this->phrasen['pruefung/sammelemailBodyBestaetigt'] = 'Confirmed by';
-$this->phrasen['pruefung/sammelemailBodyPruefung'] = 'Exam';
-$this->phrasen['pruefung/sammelemailBodyTermin'] = 'Exam date';
-$this->phrasen['pruefung/sammelemailBodyDauer'] = 'Duration';
-
 $this->phrasen['pruefung/emailLektorSubjectAnmeldung'] = 'Anmeldung zur Prüfung';
 $this->phrasen['pruefung/emailLektorStudentIn'] = 'StudentIn';
 $this->phrasen['pruefung/emailLektorHatSichZurPruefung'] = 'hat sich zur Prüfung';

public/css/Cis4/Cis.css

@@ -407,7 +407,6 @@ html {
   background-color: var(--fhc-background);
   border-color: var(--fhc-border);
   padding: var(--fhc-cis-main-py) var(--fhc-cis-main-px);
-  min-width: 0; /* fix flex-grow with tabulator exceeding width */
 }
 
 #cis-main .fa-arrow-up-right-from-square {
@@ -855,4 +854,4 @@ html {
 #cis-main .modal-footer {
 	background-color: var(--fhc-secondary);
 	
-}
+}

public/css/Studentenverwaltung.css

@@ -1,38 +1,14 @@
 @import './Fhc.css';
-@import './SvgIcons.css';
 @import './components/searchbar/searchbar.css';
 @import './components/verticalsplit.css';
 @import './components/FilterComponent.css';
 @import './components/Tabs.css';
 @import './components/Notiz.css';
 @import './components/Messages.css';
-@import './components/AppMenu.css';
 
 html {
   font-size: .875em;
 }
-html.fs_xx-small {
-	font-size: .5em;
-}
-html.fs_x-small {
-	font-size: .625em;
-}
-html.fs_small {
-	font-size: .75em;
-}
-html.fs_normal {
-  font-size: .875em;
-}
-html.fs_big {
-  font-size: 1em;
-}
-html.fs_huge {
-	font-size: 1.125em;
-}
-
-#appMenu {
-	width: 300px;
-}
 
 .navbar-dark .navbar-brand:focus {
 	box-shadow: 0 0 0 .25rem rgba(13,110,253,.25);
@@ -61,10 +37,8 @@ html.fs_huge {
 	flex: 1 1 auto;
 }
 
-#nav-user-btn img {
-	object-fit: contain;
-	height: 2.5rem;
-	width: 2.5rem;
+#sidebarMenu {
+	width: 0%;
 }
 
 .tabulator-row.disabled.tabulator-row-odd .tabulator-cell {
@@ -184,4 +158,4 @@ html.fs_huge {
 
 .tiny-90 div.tox.tox-tinymce {
 	height: 90% !important;
-}
+}

public/css/SvgIcons.css

@@ -1,28 +0,0 @@
-/* Themable Variables */
-:root {
-	--svg-icon-apps: var(--fhc-icon-apps, url('data:image/svg+xml,\
-		<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100">\
-			<circle cx="15" cy="15" r="15"/>\
-			<circle cx="15" cy="50" r="15"/>\
-			<circle cx="15" cy="85" r="15"/>\
-			<circle cx="50" cy="15" r="15"/>\
-			<circle cx="50" cy="50" r="15"/>\
-			<circle cx="50" cy="85" r="15"/>\
-			<circle cx="85" cy="15" r="15"/>\
-			<circle cx="85" cy="50" r="15"/>\
-			<circle cx="85" cy="85" r="15"/>\
-		</svg>'));
-}
-.svg-icon {
-	display: inline-block;
-	width: 1rem;
-	line-height: 1;
-	background-color: currentColor;
-}
-.svg-icon:before {
-	content: "\00a0";
-}
-.svg-icon.svg-icon-apps {
-	-webkit-mask-image: var(--svg-icon-apps);
-	mask-image: var(--svg-icon-apps);
-}

public/css/components/AppMenu.css

@@ -1,30 +0,0 @@
-.fhc-app-menu {
-	display: flex;
-	flex-direction: column;
-	padding-left: 0;
-	margin: calc(var(--bs-offcanvas-padding-y) * -1) calc(var(--bs-offcanvas-padding-x) * -1);
-}
-.fhc-app-menu li {
-	display: block;
-	border: var(--bs-border-width) solid var(--bs-border-color);
-}
-.fhc-app-menu li + li {
-	border-top-width: 0;
-}
-.fhc-app-menu li a {
-	display: block;
-	padding: .5rem 1rem;
-	text-decoration: none;
-}
-.fhc-app-menu li a.disabled {
-	--bs-link-opacity: .5;
-}
-.fhc-app-menu li a.active,
-.fhc-app-menu li a:hover {
-	--bs-link-color-rgb: var(--bs-link-hover-color-rgb);
-	background: var(--surface-hover);
-}
-.fhc-app-menu li a.disabled,
-.fhc-app-menu li a.active {
-	pointer-events: none;
-}

public/css/components/primevue.css

@@ -5690,32 +5690,3 @@
   outline: 0;
   box-shadow: 0 0 0 .25rem rgba(13,110,253,.25);
 }
-
-/* input-group */
-/* autocomplete */
-.input-group:not(.has-validation) > .dropdown-toggle:nth-last-child(n+3) > .p-autocomplete-input,
-.input-group:not(.has-validation) > .form-floating:not(:last-child) > .form-control > .p-autocomplete-input,
-.input-group:not(.has-validation) > .form-floating:not(:last-child) > .form-select > .p-autocomplete-input,
-.input-group:not(.has-validation) > :not(:last-child):not(.dropdown-toggle):not(.dropdown-menu):not(.form-floating) > .p-autocomplete-input,
-.input-group:not(.has-validation) > .dropdown-toggle:nth-last-child(n+3) > .p-autocomplete > .p-autocomplete-input,
-.input-group:not(.has-validation) > .form-floating:not(:last-child) > .form-control > .p-autocomplete > .p-autocomplete-input,
-.input-group:not(.has-validation) > .form-floating:not(:last-child) > .form-select > .p-autocomplete > .p-autocomplete-input,
-.input-group:not(.has-validation) > :not(:last-child):not(.dropdown-toggle):not(.dropdown-menu):not(.form-floating) > .p-autocomplete > .p-autocomplete-input {
-  border-top-right-radius: 0;
-  border-bottom-right-radius: 0;
-}
-.input-group > :not(:first-child):not(.dropdown-menu):not(.valid-tooltip):not(.valid-feedback):not(.invalid-tooltip):not(.invalid-feedback) > .p-autocomplete-input,
-.input-group > :not(:first-child):not(.dropdown-menu):not(.valid-tooltip):not(.valid-feedback):not(.invalid-tooltip):not(.invalid-feedback) > .p-autocomplete > .p-autocomplete-input {
-  margin-left: calc(var(--bs-border-width) * -1);
-  border-top-left-radius: 0;
-  border-bottom-left-radius: 0;
-}
-
-.p-inputtext.is-invalid:enabled:hover {
-  border-color: var(--bs-form-invalid-border-color);
-}
-.p-inputtext.is-invalid:enabled:focus,
-.was-validated .p-inputtext:invalid:focus {
-  border-color: var(--bs-form-invalid-border-color);
-  box-shadow: 0 0 0 .25rem rgba(var(--bs-danger-rgb),.25);
-}

public/css/tags.css

@@ -95,12 +95,6 @@
 
 .modificationdate {
 	font-style: italic;
-	font-size: 1em;
+	font-size: 0.7em;
 	text-align: left;
 }
-
-
-.copy-btn {
-	float: right;
-	margin-top: 3px;
-}

public/js/api/factory/messages/messages.js

@@ -62,10 +62,10 @@ export default {
 			url: 'api/frontend/v1/messages/messages/getUid/' + userParams.id + '/' + userParams.type_id
 		};
 	},
-	getDataVorlage(vorlage_kurzbz, studiengang_kz){
+	getVorlagentext(vorlage_kurzbz){
 		return {
 			method: 'get',
-			url: 'api/frontend/v1/messages/messages/getDataVorlage/' + vorlage_kurzbz + '/' + studiengang_kz
+			url: 'api/frontend/v1/messages/messages/getVorlagentext/' + vorlage_kurzbz
 		};
 	},
 	getNameOfDefaultRecipient(params){
@@ -106,11 +106,5 @@ export default {
 			method: 'post',
 			url: 'api/frontend/v1/messages/messages/deleteMessage/' + messageId
 		};
-	},
-	getStudiengang(userParams){
-		return {
-			method: 'get',
-			url: 'api/frontend/v1/messages/messages/getStudiengang/' + userParams.id + '/' + userParams.type_id
-		};
-	},
+	}
 }