Merge branch 'master' into bug-69092/Messages_API_getDataVorlage

application/config/Events.php

@@ -6,30 +6,30 @@ use CI3_Events as Events;
 Events::on('loadRenderers', function ($renderers) {
 	$fhc_core_renderers =& $renderers();
 	$fhc_core_renderers["lehreinheit"] = array(
-		'calendarEvent' => absoluteJsImportUrl('public/js/components/Cis/Renderer/Lehreinheit/calendarEvent.js'),
-		'modalTitle' => absoluteJsImportUrl('public/js/components/Cis/Renderer/Lehreinheit/modalTitle.js'),
-		'modalContent' => absoluteJsImportUrl('public/js/components/Cis/Renderer/Lehreinheit/modalContent.js'),
-		'calendarEventStyles' => APP_ROOT . 'public/css/Cis4/CoreCalendarEvents.css'
+		'calendarEvent' => APP_ROOT.'public/js/components/Cis/Renderer/Lehreinheit/calendarEvent.js',
+		'modalTitle' => APP_ROOT.'public/js/components/Cis/Renderer/Lehreinheit/modalTitle.js',
+		'modalContent' => APP_ROOT.'public/js/components/Cis/Renderer/Lehreinheit/modalContent.js',
+		'calendarEventStyles' => APP_ROOT.'public/css/Cis4/CoreCalendarEvents.css'
 	);
 });
 
 Events::on('loadRenderers', function ($renderers) {
 	$fhc_core_renderers =& $renderers();
 	$fhc_core_renderers["reservierung"] = array(
-		'calendarEvent' => absoluteJsImportUrl('public/js/components/Cis/Renderer/Reservierungen/calendarEvent.js'),
-		'modalTitle' => absoluteJsImportUrl('public/js/components/Cis/Renderer/Reservierungen/modalTitle.js'),
-		'modalContent' => absoluteJsImportUrl('public/js/components/Cis/Renderer/Reservierungen/modalContent.js'),
-		'calendarEventStyles' => APP_ROOT . 'public/css/Cis4/CoreCalendarEvents.css'
+		'calendarEvent' => APP_ROOT.'public/js/components/Cis/Renderer/Reservierungen/calendarEvent.js',
+		'modalTitle' => APP_ROOT.'public/js/components/Cis/Renderer/Reservierungen/modalTitle.js',
+		'modalContent' => APP_ROOT.'public/js/components/Cis/Renderer/Reservierungen/modalContent.js',
+		'calendarEventStyles' => APP_ROOT.'public/css/Cis4/CoreCalendarEvents.css'
 	);
 });
 
 Events::on('loadRenderers', function ($renderers) {
 	$fhc_core_renderers =& $renderers();
 	$fhc_core_renderers["ferien"] = array(
-		'calendarEvent' => absoluteJsImportUrl('public/js/components/Cis/Renderer/Feiertage/calendarEvent.js'),
-		'modalTitle' => absoluteJsImportUrl('public/js/components/Cis/Renderer/Feiertage/modalTitle.js'),
-		'modalContent' => absoluteJsImportUrl('public/js/components/Cis/Renderer/Feiertage/modalContent.js'),
-		'calendarEventStyles' => APP_ROOT . 'public/css/Cis4/CoreCalendarEvents.css'
+		'calendarEvent' => APP_ROOT.'public/js/components/Cis/Renderer/Feiertage/calendarEvent.js',
+		'modalTitle' => APP_ROOT.'public/js/components/Cis/Renderer/Feiertage/modalTitle.js',
+		'modalContent' => APP_ROOT.'public/js/components/Cis/Renderer/Feiertage/modalContent.js',
+		'calendarEventStyles' => APP_ROOT.'public/css/Cis4/CoreCalendarEvents.css'
 	);
 });
 

application/config/abgabe.php

@@ -1,43 +0,0 @@
-<?php
-
-
-if (!defined('BASEPATH')) exit('No direct script access allowed');
-
-$config['turnitin_link'] = 'https://technikum-wien.turnitin.com/sso/sp/redwood/saml/5IyfmBr2OcSIaWQTKlFCGj/start';
-
-$config['old_abgabe_beurteilung_link'] = 'https://moodle.technikum-wien.at/mod/page/view.php?id=1005052';
-
-$config['PAABGABE_EMAIL_JOB_INTERVAL'] = '1 day';
-// used as APP_ROOT.URL_STUDENTS -> cis4
-$config['URL_STUDENTS'] = 'cis.php/Cis/Abgabetool/Student';
-// used as APP_ROOT.URL_MITARBEITER -> old cis 
-$config['URL_MITARBEITER'] = 'index.ci.php/Cis/Abgabetool/Mitarbeiter';
-// used as APP_ROOT.URL_MITARBEITER -> old cis 
-$config['URL_ASSISTENZ'] = 'index.ci.php/Cis/Abgabetool/Assistenz';
-
-// lehre.tbl_paabgabetyp bezeichnung
-//$config['ALLOWED_ABGABETYPEN_BETREUER'] = ['Zwischenabgabe', 'Quality Gate 1', 'Quality Gate 2'];
-$config['ALLOWED_ABGABETYPEN_BETREUER'] = ['abstract','zwischen', 'qualgate1', 'qualgate2']; // tbl_paabgabetyp pk
-// paabgabetypen for which betreuer is benachrichtigt via sammelmail
-$config['RELEVANT_PAABGABETYPEN_SAMMELMAIL_BETREUER'] = ['qualgate1', 'qualgate2', 'end'];
-// paabgabetypen for which assistenz is benachrichtigt via sammelmail
-$config['RELEVANT_PAABGABETYPEN_SAMMELMAIL_ASSISTENZ'] = ['end'];
-// paabgabetypen for which student is benachrichtigt via sammelmail -> basically all of them but still defined for consistency
-$config['RELEVANT_PAABGABETYPEN_SAMMELMAIL_STUDENT'] = ['qualgate1', 'qualgate2', 'zwischen', 'note', 'abstract', 'end', 'enda'];
-//$config['ALLOWED_NOTEN_ABGABETOOL'] = ['Bestanden', 'Nicht bestanden'];
-$config['ALLOWED_NOTEN_ABGABETOOL'] = [10, 14]; // tbl_note pk
-// benotete projektarbeiten sperren weitere terminanlage & bearbeitung, diese noten sind ausnahmen dieser Regel
-// wie zB "Nicht beurteilt" & "Noch nicht eingetragen"
-$config['NONFINAL_NOTEN_ABGABETOOL'] = [9];
-$config['beurteilung_link_fallback'] = 'addons/fhtw/content/projektbeurteilung/projektbeurteilungDocumentExport.php?projektarbeit_id=?&betreuerart_kurzbz=?&person_id=?';
-
-$config['PROJEKTARBEITSBEURTEILUNG_MAIL_BASELINK_ERSTBEGUTACHTER'] = 'index.ci.php/extensions/FHC-Core-Projektarbeitsbeurteilung/ProjektarbeitsbeurteilungErstbegutachter';
-$config['PROJEKTARBEITSBEURTEILUNG_MAIL_BASELINK_ZWEITBEGUTACHTER'] = 'index.ci.php/extensions/FHC-Core-Projektarbeitsbeurteilung/ProjektarbeitsbeurteilungErstbegutachter';
-
-$config['SIGNATUR_CHECK_PAABGABETYPEN'] = ['end'];
-
-// to be used as "https://moodle.technikum-wien.at/course/view.php?idnumber=dl{$stg_kz}" for stg specific moodle routing
-$config['STG_MOODLE_LINK'] = 'https://moodle.technikum-wien.at/course/view.php?idnumber=dl';
-
-$config['ASSISTENZ_SAMMELMAIL_BUTTON_STUDENT'] = true;
-$config['ASSISTENZ_SAMMELMAIL_BUTTON_BETREUER'] = true;

application/config/cis.php

@@ -4,7 +4,7 @@ if (! defined('BASEPATH')) exit('No direct script access allowed');
 
 
 // CMS Content Id for CIS4 Menu Root
-$config['cis_menu_root_content_id'] = 11091;
+$config['cis_menu_root_content_id'] = 11087;
 // send Mails for ProfilUpdate
 $config['cis_send_profil_update_mails'] = true;
 // Vilesci CI BaseUrl

application/config/javascript.php

@@ -7,6 +7,3 @@ $config['use_vuejs_dev_version'] = false;
 $config['use_bundled_javascript'] = false;
 // systemerror_mailto use in FHC-Alert Plugin - if empty Link will not be rendered
 $config['systemerror_mailto'] = '';
-// use fhcomplete_build_version as path element after public (requires apache mod_rewrite)
-// see <fhc_base_dir>/public/.htaccess_sample for details
-$config['use_fhcomplete_build_version_in_path'] = false;

application/config/routes.php

@@ -65,13 +65,6 @@ $route['Cis/LvPlan/.*'] = 'Cis/LvPlan/index/$1';
 $route['Cis/MyLvPlan/.*'] = 'Cis/MyLvPlan/index/$1';
 $route['Cis/MyLv/.*'] = 'Cis/MyLv/index/$1';
 
-$route['Abgabetool/Assistenz'] = 'Cis/Abgabetool/Assistenz';
-$route['Abgabetool/Assistenz/(:any)'] = 'Cis/Abgabetool/Assistenz/$1';
-$route['Abgabetool/Mitarbeiter'] = 'Cis/Abgabetool/Mitarbeiter';
-$route['Abgabetool/Student'] = 'Cis/Abgabetool/Student';
-$route['Abgabetool/Student/(:any)'] = 'Cis/Abgabetool/Student/$1';
-$route['Abgabetool/Deadlines'] = 'Cis/Abgabetool/Deadlines';
-
 // Studierendenverwaltung List Routes
 $route['api/frontend/v1/stv/[sS]tudents/inout'] = 'api/frontend/v1/stv/Students/index';
 $route['api/frontend/v1/stv/[sS]tudents/([WS]S[0-9]{4})'] = 'api/frontend/v1/stv/Students/index';

application/config/stv.php

@@ -88,14 +88,9 @@ if (!defined('ZGV_DOKTOR_ANZEIGEN') || !ZGV_DOKTOR_ANZEIGEN) {
 	);
 }
 
-$config['tabs']['projektarbeit']['defaultProjektbetreuerStunden'] =
-	defined('FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_BACHELOR')
-	? FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_BACHELOR
-	: '0.0';
-$config['tabs']['projektarbeit']['defaultProjektbetreuerStundenDiplom'] =
-	defined('FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_MASTER')
-	? FAS_STUDIERENDE_PROJEKTARBEIT_DEFAULT_BETREUER_STUNDEN_MASTER
-	: '0.0';
+$config['tabs']['projektarbeit']['defaultProjektbetreuerStunden'] = '4.0';
+$config['tabs']['projektarbeit']['defaultProjektbetreuerStundenDiplom'] = '5.0';
+$config['tabs']['projektarbeit']['lvLektroinnenzuteilungFixangestelltStundensatz'] = true;
 $config['tabs']['projektarbeit']['defaultProjektbetreuerStundensatz'] = '80.0';
 
 $config['student_tab_order'] = [
@@ -124,7 +119,6 @@ $config['student_tab_order'] = [
 $config['students_tab_order'] = [
 	'banking',
 	'status',
-	'messages',
 	'groups',
 	'finalexam',
 	'combinePeople',

application/controllers/Cis/Abgabetool.php

@@ -14,10 +14,10 @@ class Abgabetool extends Auth_Controller
 	{
 		parent::__construct([
 			'index' => self::PERM_LOGGED,
-			'Mitarbeiter' => array('basis/abgabe_lektor:rw', 'basis/abgabe_assistenz:rw'),
-			'Assistenz' => array('basis/abgabe_assistenz:rw'),
-			'Student' =>  array('basis/abgabe_student:rw', 'basis/abgabe_lektor:rw', 'basis/abgabe_assistenz:rw'),
-			'Deadlines' => array('basis/abgabe_lektor:rw', 'basis/abgabe_assistenz:rw')
+			'getStudentProjektarbeitAbgabeFile' => self::PERM_LOGGED,
+			'Mitarbeiter' => self::PERM_LOGGED,
+			'Student' => self::PERM_LOGGED,
+			'Deadlines' => self::PERM_LOGGED
 		]);
 	}
 
@@ -29,69 +29,80 @@ class Abgabetool extends Auth_Controller
 	 */
 	public function index()
 	{
-		// TODO: routing from index based on berechtigung?
 
 		$viewData = array(
 			'uid'=>getAuthUID(),
 		);
 
-		if(defined('CIS4') && CIS4) {
-			$this->load->view('CisRouterView/CisRouterView.php', ['viewData' => $viewData, 'route' => 'Abgabetool']);
-		} else {
-			$this->load->view('Cis/Abgabetool.php', ['uid' => getAuthUID(), 'route' => 'Abgabetool']);
-		}
+		$this->load->view('CisRouterView/CisRouterView.php', ['viewData' => $viewData, 'route' => 'Abgabetool']);
 	}
 
-	public function Student($student_uid_prop = '')
+	public function Student()
 	{
+
 		$viewData = array(
 			'uid'=>getAuthUID(),
 		);
-		
-		if(defined('CIS4') && CIS4) {
-			$this->load->view('CisRouterView/CisRouterView.php', ['viewData' => $viewData, 'route' => 'AbgabetoolStudent']);
-		} else {
-			$this->load->view('Cis/Abgabetool.php', ['uid' => getAuthUID(), 'route' => 'AbgabetoolStudent', 'student_uid_prop' => $student_uid_prop]);
-		}
+
+		$this->load->view('CisRouterView/CisRouterView.php', ['viewData' => $viewData, 'route' => 'AbgabetoolStudent']);
 	}
 
 	public function Mitarbeiter()
 	{
+
 		$viewData = array(
 			'uid'=>getAuthUID(),
 		);
 
-		if(defined('CIS4') && CIS4) {
-			$this->load->view('CisRouterView/CisRouterView.php', ['viewData' => $viewData, 'route' => 'AbgabetoolMitarbeiter']);
-		} else {
-			$this->load->view('Cis/Abgabetool.php', ['uid' => getAuthUID(), 'route' => 'AbgabetoolMitarbeiter']);
-		}
+		$this->load->view('CisRouterView/CisRouterView.php', ['viewData' => $viewData, 'route' => 'AbgabetoolMitarbeiter']);
 	}
 
-	public function Assistenz($stg_kz_prop = '')
-	{
-		
-		$viewData = array(
-			'uid'=>getAuthUID(),
-		);
-
-		if(defined('CIS4') && CIS4) {
-			$this->load->view('CisRouterView/CisRouterView.php', ['viewData' => $viewData, 'route' => 'AbgabetoolAssistenz']);
-		} else {
-			$this->load->view('Cis/Abgabetool.php', ['uid' => getAuthUID(), 'route' => 'AbgabetoolAssistenz', 'stg_kz_prop' => $stg_kz_prop]);
-		}
-	}
-	
 	public function Deadlines()
 	{
+
 		$viewData = array(
 			'uid'=>getAuthUID(),
 		);
 
-		if(defined('CIS4') && CIS4) {
-			$this->load->view('CisRouterView/CisRouterView.php', ['viewData' => $viewData, 'route' => 'DeadlinesOverview']);
+		$this->load->view('CisRouterView/CisRouterView.php', ['viewData' => $viewData, 'route' => 'DeadlinesOverview']);
+	}
+
+
+	public function getStudentProjektarbeitAbgabeFile() 
+	{
+		$this->_ci =& get_instance();
+		$this->_ci->load->helper('download');
+		
+		$paabgabe_id = $this->_ci->input->get('paabgabe_id');
+		$student_uid = $this->_ci->input->get('student_uid');
+
+		if (!isset($paabgabe_id) || isEmptyString($paabgabe_id) || !isset($student_uid) || isEmptyString($student_uid))
+			$this->terminateWithJsonError($this->p->t('global', 'wrongParameters'), 'general');
+		
+		$this->_ci->load->model('education/Projektarbeit_model', 'ProjektarbeitModel');
+
+		$isZugeteilterBetreuer = count($this->_ci->ProjektarbeitModel->checkZuordnung($student_uid, getAuthUID())->retval) > 0;
+		
+		if(getAuthUID() == $student_uid || $isZugeteilterBetreuer) {
+			$file_path = PAABGABE_PATH.$paabgabe_id.'_'.$student_uid.'.pdf';
+			if(file_exists($file_path)) {
+				
+				header('Content-Description: File Transfer');
+				header('Content-Type: application/octet-stream');
+				header('Expires: 0');
+				header('Cache-Control: must-revalidate');
+				header('Pragma: public');
+				header('Content-Disposition: attachment; filename="'.basename($file_path).'"');
+				header('Content-Length: ' . filesize($file_path));
+
+				flush(); // send headers first just in case
+				readfile($file_path); // read file content to output buffer
+				
+			} else {
+				$this->terminateWithJsonError('File not found');
+			}
 		} else {
-			$this->load->view('Cis/Abgabetool.php', ['uid' => getAuthUID(), 'route' => 'DeadlinesOverview']);
+			$this->terminateWithJsonError('Keine Zuordnung!');
 		}
 	}
 }

application/controllers/NeueNachricht.php

@@ -20,18 +20,11 @@ class NeueNachricht extends Auth_Controller
 	 */
 	public function _remap()
 	{
-		$typeid = $this->input->post('typeid');
-		$ids = ($this->input->post('ids') && strpos($this->input->post('ids'), ',')) 
-			? explode(',', $this->input->post('ids'))
-			: $this->input->post('ids');
-
 		//now working
 		$this->load->view('Nachrichten', [
 			'permissions' => [
 				'assistenz_schreibrechte' => $this->permissionlib->isBerechtigt('assistenz','suid'),
-			],
-			'ids' => $ids,
-			'typeid' => $typeid
+			]
 		]);
 	}
 }

application/controllers/Studentenverwaltung.php

@@ -32,10 +32,6 @@ class Studentenverwaltung extends Auth_Controller
 				'student/keine_studstatuspruefung' => $this->permissionlib->isBerechtigt('student/keine_studstatuspruefung'),
 				'lehre/reihungstestAufsicht' => $this->permissionlib->isBerechtigt('lehre/reihungstestAufsicht'),
 				'system/change_outputformat' => $this->permissionlib->getOE_isEntitledFor('system/change_outputformat'),
-				'student/editBakkZgv' => $this->permissionlib->getSTG_isEntitledFor('student/editBakkZgv') ?: array(),
-				'student/editMakkZgv' => $this->permissionlib->getSTG_isEntitledFor('student/editMakkZgv') ?: array(),
-				'student/editDokZgv' => $this->permissionlib->getSTG_isEntitledFor('student/editDokZgv') ?: array(),
-				'student/editBismelden' => $this->permissionlib->isBerechtigt('student/editBismelden')
 			],
 			'variables' => [
 				'semester_aktuell' => $this->variablelib->getVar('semester_aktuell')

application/controllers/api/frontend/v1/Documents.php

@@ -442,10 +442,6 @@ class Documents extends FHCAPI_Controller
 			'betreuerart_kurzbz',
 			'studiensemester_kurzbz'
 		] as $key) {
-			if (in_array($xsl, array('Ausbildungsver', 'AusbVerEng')) && $key === 'uid')
-			{
-				continue;
-			}
 			$value = $this->input->post_get($key);
 			if ($value !== null)
 				$params .= '&' . $key . '=' . urlencode($value);

application/controllers/api/frontend/v1/Lehre.php

@@ -38,9 +38,34 @@ class Lehre extends FHCAPI_Controller
 		parent::__construct([
 			'lvStudentenMail' => self::PERM_LOGGED,
 			'LV' => self::PERM_LOGGED,
-			'Pruefungen' => self::PERM_LOGGED
+			'Pruefungen' => self::PERM_LOGGED,
+			'getStudentProjektarbeiten' => self::PERM_LOGGED, // TODO: abgabetool berechtigung?
+			'getStudentProjektabgaben' => self::PERM_LOGGED,
+			'postStudentProjektarbeitZwischenabgabe' => self::PERM_LOGGED,
+			'postStudentProjektarbeitEndupload' => self::PERM_LOGGED,
+			'getMitarbeiterProjektarbeiten' => self::PERM_LOGGED,
+			'postProjektarbeitAbgabe' => self::PERM_LOGGED,
+			'deleteProjektarbeitAbgabe' => self::PERM_LOGGED,
+			'postSerientermin' => self::PERM_LOGGED,
+			'fetchDeadlines' => self::PERM_LOGGED // TODO: mitarbeiter recht prüfen
 		]);
+
+		$this->load->library('PhrasesLib');
+
+		$this->loadPhrases(
+			array(
+				'global',
+				'ui',
+				'abgabetool'
+			)
+		);
+
+		$this->load->helper('hlp_sancho_helper');
 		
+		require_once(FHCPATH . 'include/studiengang.class.php');
+		require_once(FHCPATH . 'include/student.class.php');
+		require_once(FHCPATH . 'include/projektarbeit.class.php');
+		require_once(FHCPATH . 'include/projektbetreuer.class.php');
 	}
 
 	//------------------------------------------------------------------------------------------------------------------
@@ -100,5 +125,557 @@ class Lehre extends FHCAPI_Controller
 
 		$this->terminateWithSuccess($result);
 	}
+
+	/**
+	 * fetches all projektabgabetermine for a given projektarbeit_id used in cis4 student abgabetool
+	 */
+	public function getStudentProjektabgaben() {
+		$projektarbeit_id = $this->input->get("projektarbeit_id",TRUE);
+
+		// TODO: error messages
+		
+		if (!isset($projektarbeit_id) || isEmptyString($projektarbeit_id))
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+
+		$projektarbeit_obj = new projektarbeit();
+		if($projektarbeit_id==-1)
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+
+		if(!$projektarbeit_obj->load($projektarbeit_id))
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+
+		$paIsCurrent = $projektarbeit_obj->projektarbeitIsCurrent($projektarbeit_id);
+		
+		$this->load->model('education/Projektarbeit_model', 'ProjektarbeitModel');
+		$ret = $this->ProjektarbeitModel->getProjektarbeitAbgabetermine($projektarbeit_id);
+		
+		// TODO: fetch zweitbetreuer
+		
+		$this->terminateWithSuccess(array($ret, $paIsCurrent));
+	}
+
+	/**
+	 * fetches all projektarbeiten and betreuer for a given student_uid used in cis4 student abgabetool
+	 */
+	public function getStudentProjektarbeiten($uid)
+	{
+		$this->load->model('ressource/Mitarbeiter_model', 'MitarbeiterModel');
+		$this->load->model('education/Projektarbeit_model', 'ProjektarbeitModel');
+
+		if (!isset($uid) || isEmptyString($uid))
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+		
+		$isZugeteilterBetreuer = count($this->ProjektarbeitModel->checkZuordnung($uid, getAuthUID())->retval) > 0;
+		$this->addMeta('isZugeteilterBetreuer', $isZugeteilterBetreuer);
+		$isMitarbeiter = $this->MitarbeiterModel->isMitarbeiter(getAuthUID());
+		
+		if ($isMitarbeiter && $isZugeteilterBetreuer){
+			$projektarbeiten = $this->ProjektarbeitModel->getStudentProjektarbeitenWithBetreuer($uid);
+		} else {
+			$projektarbeiten = $this->ProjektarbeitModel->getStudentProjektarbeitenWithBetreuer(getAuthUID());
+		}
+
+		$this->terminateWithSuccess(array($projektarbeiten, DOMAIN, $uid));	
+	}
+	
+	
+
+	/**
+	 * projektarbeit - upload for zwischenabgaben in cis4 student abgabetool
+	 */
+	public function postStudentProjektarbeitZwischenabgabe() 
+	{
+
+		$projektarbeit_id = $_POST['projektarbeit_id'];
+		$paabgabe_id = $_POST['paabgabe_id'];
+		$student_uid = $_POST['student_uid'];
+		$bperson_id = $_POST['bperson_id'];
+		$paabgabetyp_kurzbz = $_POST['paabgabetyp_kurzbz'];
+
+		if (!isset($projektarbeit_id) || isEmptyString($projektarbeit_id)
+			|| !isset($paabgabe_id) || isEmptyString($paabgabe_id)
+			|| !isset($student_uid) || isEmptyString($student_uid)
+			|| !isset($paabgabetyp_kurzbz) || isEmptyString($paabgabetyp_kurzbz))
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+
+		if ((isset($_FILES) and isset($_FILES['file']) and ! $_FILES['file']['error'])) {
+			move_uploaded_file($_FILES['file']['tmp_name'], PAABGABE_PATH.$paabgabe_id.'_'.$student_uid.'.pdf');
+			
+			if(file_exists(PAABGABE_PATH.$paabgabe_id.'_'.$student_uid.'.pdf')) {
+
+				exec('chmod 640 "'.PAABGABE_PATH.$paabgabe_id.'_'.$student_uid.'.pdf'.'"');
+
+				$this->load->model('education/Paabgabe_model', 'PaabgabeModel');
+				$res = $this->PaabgabeModel->update($paabgabe_id, array(
+					'abgabedatum' => date('Y-m-d'),
+					'updatevon' => getAuthUID(),
+					'updateamum' => date('Y-m-d H:i:s')
+				));
+				
+				$this->sendUploadEmail($bperson_id, $projektarbeit_id, $paabgabetyp_kurzbz, $student_uid);
+				$this->terminateWithSuccess($res);
+			} else {
+				$this->terminateWithError('Error moving File');
+			}
+			
+		} else {
+			$this->terminateWithError('File missing');
+		}
+		
+	}
+
+	/**
+	 * upload für finale abgaben aka Endupload in cis4 student abgabetool
+	 */
+	public function postStudentProjektarbeitEndupload() 
+	{
+
+		$projektarbeit_id = $_POST['projektarbeit_id'];
+		$paabgabe_id = $_POST['paabgabe_id'];
+		$student_uid = $_POST['student_uid'];
+		$sprache = $_POST['sprache'];
+		$abstract = $_POST['abstract'];
+		$abstract_en = $_POST['abstract_en'];
+		$schlagwoerter = $_POST['schlagwoerter'];
+		$schlagwoerter_en = $_POST['schlagwoerter_en'];
+		$seitenanzahl = $_POST['seitenanzahl'];
+		$bperson_id = $_POST['bperson_id'];
+		$paabgabetyp_kurzbz = $_POST['paabgabetyp_kurzbz'];
+		
+		if (!isset($projektarbeit_id) || isEmptyString($projektarbeit_id)
+			|| !isset($paabgabe_id) || isEmptyString($paabgabe_id)
+			|| !isset($student_uid) || isEmptyString($student_uid)
+			|| !isset($paabgabetyp_kurzbz) || isEmptyString($paabgabetyp_kurzbz))
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+		
+		// TODO: maybe check for other params aswell?
+
+		if ((isset($_FILES) and isset($_FILES['file']) and ! $_FILES['file']['error'])) {
+			move_uploaded_file($_FILES['file']['tmp_name'], PAABGABE_PATH.$paabgabe_id.'_'.$student_uid.'.pdf');
+
+			if(file_exists(PAABGABE_PATH.$paabgabe_id.'_'.$student_uid.'.pdf')) {
+
+				// Loads Libraries
+				$this->load->library('SignatureLib');
+				
+				// Check if the document is signed
+				$signaturVorhanden = true;
+				$signList = SignatureLib::list(PAABGABE_PATH.$paabgabe_id.'_'.$student_uid.'.pdf');
+				if (is_array($signList) && count($signList) > 0)
+				{
+					// The document is signed
+					$uploadedDocumentSigned = 'The document is signed';
+				}
+				elseif ($signList === null)
+				{
+					$uploadedDocumentSigned = 'WARNING: signature server error';
+				}
+				else
+				{
+					$signaturVorhanden = false;
+					$uploadedDocumentSigned = 'No document signature found';
+				}
+				$this->addMeta('signaturInfo', $uploadedDocumentSigned);
+
+				if ($signaturVorhanden === false)
+				{
+					$this->signaturFehltEmail($student_uid);
+				}
+				
+				// TODO error handle get data has data the updates
+				// update projektarbeit cols
+				$this->load->model('education/Projektarbeit_model', 'ProjektarbeitModel');
+				$this->ProjektarbeitModel->updateProjektarbeit($projektarbeit_id,$sprache,$abstract,$abstract_en
+					,$schlagwoerter, $schlagwoerter_en, $seitenanzahl);
+
+				
+				// update paabgabe datum
+				$this->load->model('education/Paabgabe_model', 'PaabgabeModel');
+				$res = $this->PaabgabeModel->update($paabgabe_id, array(
+					'abgabedatum' => date('Y-m-d'),
+					'updatevon' => getAuthUID(),
+					'updateamum' => date('Y-m-d H:i:s')
+				));
+				
+				$this->sendUploadEmail($bperson_id, $projektarbeit_id, $paabgabetyp_kurzbz, $student_uid);
+
+				$this->terminateWithSuccess($res);
+			} else {
+				$this->terminateWithError('Error moving File');
+			}
+
+		} else {
+			$this->terminateWithError('File missing');
+		}
+		
+	}
+
+	private function signaturFehltEmail($student_uid) {
+		
+		
+		// Mail an Studiengang wenn keine Signatur gefunden wurde
+		$student = new student();
+		if(!$student->load($student_uid))
+			$this->terminateWithError($this->p->t('global','userNichtGefunden'), 'general');
+
+		$stg_obj = new studiengang();
+		if(!$stg_obj->load($student->studiengang_kz))
+			$this->terminateWithError($this->p->t('global','fehlerBeimLesenAusDatenbank'), 'general');
+
+		$subject = 'Abgabe ohne Signatur';
+		$tomail = $stg_obj->email;
+		$data = array(
+			'vorname' => $student->vorname,
+			'nachname' => $student->nachname,
+			'studiengang' => $stg_obj->bezeichnung
+		);
+
+		$mailres = sendSanchoMail(
+			'ParbeitsbeurteilungSiganturFehlt',
+			$data,
+			$tomail,
+			$subject,
+			'sancho_header_min_bw.jpg',
+			'sancho_footer_min_bw.jpg'
+		);
+	}
+	
+	private function sendUploadEmail($bperson_id, $projektarbeit_id, $paabgabetyp_kurzbz, $student_uid) {
+
+		$this->load->model('education/Projektarbeit_model', 'ProjektarbeitModel');
+		
+		$resBetr = $this->ProjektarbeitModel->getProjektbetreuerAnrede($bperson_id);
+
+		$projektarbeit_obj = new projektarbeit();
+
+		if(!$projektarbeit_obj->load($projektarbeit_id))
+			$this->terminateWithError('Ungueltiger Eintrag');
+
+		$num_rows_sem = $projektarbeit_obj->projektarbeitIsCurrent($projektarbeit_id);
+
+		if( null === $num_rows_sem || false === $num_rows_sem )
+		{
+			$this->terminateWithError($this->p->t('abgabetool','fehlerAktualitaetProjektarbeit'), 'general');
+		}
+		
+		foreach($resBetr->retval as $betreuerRow) {
+
+			// query student benutzer view for every betreuer row
+			$studentUser = $this->ProjektarbeitModel->getProjektarbeitBenutzer($student_uid)->retval[0];
+			
+			// TODO: hasdata, getData etc
+
+			// 1. Begutachter mail ohne Token
+			$mail_baselink = APP_ROOT."index.ci.php/extensions/FHC-Core-Projektarbeitsbeurteilung/ProjektarbeitsbeurteilungErstbegutachter";
+			$mail_fulllink = "$mail_baselink?projektarbeit_id=".$projektarbeit_id."&uid=".$studentUser->uid;
+			$projekttyp_kurzbz = $projektarbeit_obj->projekttyp_kurzbz;
+			$subject = $projektarbeit_obj->projekttyp_kurzbz == 'Diplom' ? 'Masterarbeitsbetreuung' : 'Bachelorarbeitsbetreuung';
+			$abgabetyp = $paabgabetyp_kurzbz == 'end' ? 'Endabgabe' : 'Zwischenabgabe';
+
+			$maildata = array();
+			$maildata['geehrt'] = "geehrte".($betreuerRow->anrede=="Herr"?"r":"");
+			$maildata['anrede'] = $betreuerRow->anrede;
+			$maildata['betreuer_voller_name'] = $betreuerRow->first;
+			$maildata['student_anrede'] = $studentUser->anrede;
+			$maildata['student_voller_name'] = trim($studentUser->titelpre." ".$studentUser->vorname." ".$studentUser->nachname." ".$studentUser->titelpost);
+			$maildata['abgabetyp'] = $abgabetyp;
+			$maildata['parbeituebersichtlink'] = "<p><a href='".APP_ROOT."cis/private/lehre/abgabe_lektor_frameset.html'>Zur Projektarbeitsübersicht</a></p>";
+			$maildata['bewertunglink'] = $num_rows_sem >= 1 && $paabgabetyp_kurzbz == 'end' ? "<p><a href='$mail_fulllink'>Zur Beurteilung der Arbeit</a></p>" : "";
+			$maildata['token'] = "";
+			
+			$mailres = sendSanchoMail(
+				'ParbeitsbeurteilungEndupload',
+				$maildata,
+				$betreuerRow->mitarbeiter_uid."@".DOMAIN,
+				$subject,
+				'sancho_header_min_bw.jpg',
+				'sancho_footer_min_bw.jpg',
+				get_uid()."@".DOMAIN);
+
+			if(!$mailres)
+			{
+				$this->terminateWithError($this->p->t('abgabetool', 'fehlerMailBegutachter'), 'general');
+			}
+
+			// 2. Begutachter mail, wenn Endabgabe, mit Token wenn extern
+			if ($paabgabetyp_kurzbz == 'end')
+			{
+				// Zweitbegutachter holen
+				$zweitbegutachter = new projektbetreuer();
+				$zweitbegutachterRes = $zweitbegutachter->getZweitbegutachterWithToken($bperson_id, $projektarbeit_id, $studentUser->uid);
+
+				if ($zweitbegutachterRes)
+				{
+					$zweitbegutachterResults = $zweitbegutachter->result;
+
+					foreach ($zweitbegutachterResults as $begutachter)
+					{
+						// token generieren, wenn noch nicht vorhanden und notwendig (wird in methode überprüft)
+						$tokenGenRes = $zweitbegutachter->generateZweitbegutachterToken($begutachter->person_id, $projektarbeit_id);
+
+						if (!$tokenGenRes)
+						{
+							$this->terminateWithError($this->p->t('abgabetool', 'fehlerMailZweitBegutachter'), 'general');
+						}
+						
+						// Zweitbegutachter (evtl. mit Token) holen
+						$zweitbegutachterMitToken = new projektbetreuer();
+						$begutachterMitTokenRes = $zweitbegutachterMitToken->getZweitbegutachterWithToken($bperson_id, $projektarbeit_id, $studentUser->uid, $begutachter->person_id);
+
+						if (!$begutachterMitTokenRes)
+						{
+							$this->terminateWithError($this->p->t('abgabetool', 'fehlerMailZweitBegutachter'), 'general');
+						}
+						
+						// Email an Zweitbegutachter senden
+						if (isset($zweitbegutachterMitToken->result[0]))
+						{
+							$begutachterMitToken = $zweitbegutachterMitToken->result[0];
+
+							$path = $begutachterMitToken->betreuerart_kurzbz == 'Zweitbegutachter' ? 'ProjektarbeitsbeurteilungZweitbegutachter' : 'ProjektarbeitsbeurteilungErstbegutachter';
+							$mail_baselink = APP_ROOT."index.ci.php/extensions/FHC-Core-Projektarbeitsbeurteilung/$path";
+							$mail_fulllink = "$mail_baselink?projektarbeit_id=".$projektarbeit_id."&uid=".$studentUser->uid;
+							$intern = isset($begutachterMitToken->uid);
+							$mail_link = $intern ? $mail_fulllink : $mail_baselink;
+
+							$zweitbetmaildata = array();
+							$zweitbetmaildata['geehrt'] = "geehrte" . ($begutachterMitToken->anrede == "Herr" ? "r" : "");
+							$zweitbetmaildata['anrede'] = $begutachterMitToken->anrede;
+							$zweitbetmaildata['betreuer_voller_name'] = $begutachterMitToken->voller_name;
+							$zweitbetmaildata['student_anrede'] = $maildata['student_anrede'];
+							$zweitbetmaildata['student_voller_name'] = $maildata['student_voller_name'];
+							$zweitbetmaildata['abgabetyp'] = $abgabetyp;
+							$zweitbetmaildata['parbeituebersichtlink'] = $intern ? $maildata['parbeituebersichtlink'] : "";
+							$zweitbetmaildata['bewertunglink'] = $num_rows_sem >= 1 ? "<p><a href='$mail_link'>Zur Beurteilung der Arbeit</a></p>" : "";
+							$zweitbetmaildata['token'] = $num_rows_sem >= 1 && isset($begutachterMitToken->zugangstoken) && !$intern ? "<p>Zugangstoken: " . $begutachterMitToken->zugangstoken . "</p>" : "";
+							
+							$mailres = sendSanchoMail(
+								'ParbeitsbeurteilungEndupload',
+								$zweitbetmaildata,
+								$begutachterMitToken->email,
+								$subject,
+								'sancho_header_min_bw.jpg',
+								'sancho_footer_min_bw.jpg',
+								get_uid()."@".DOMAIN
+							);
+
+							if (!$mailres)
+							{
+								$this->terminateWithError($this->p->t('abgabetool', 'fehlerMailBegutachter'), 'general');
+							}
+						}
+					}
+				}
+			}
+		}
+	}
+
+	public function getMitarbeiterProjektarbeiten() {
+		$this->load->model('education/Projektarbeit_model', 'ProjektarbeitModel');
+
+		$boolParamStr = $this->input->get('showall');
+		$trueStrings = ['true', '1'];
+		$falseStrings = ['false', '0'];
+
+		// Handle missing or invalid parameter
+		if ($boolParamStr === null) {
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+		}
+		$boolParamStrLower = strtolower($boolParamStr);
+
+		if (in_array($boolParamStrLower, $trueStrings, true)) {
+			$showAllBool = true;
+		} elseif (in_array($boolParamStrLower, $falseStrings, true)) {
+			$showAllBool = false;
+		} else {
+//			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+		}
+		
+		$projektarbeiten = $this->ProjektarbeitModel->getMitarbeiterProjektarbeiten(getAuthUID(), $showAllBool);
+		
+		$this->terminateWithSuccess(array($projektarbeiten, DOMAIN));
+	}
+	
+	public function postProjektarbeitAbgabe() {
+		$projektarbeit_id = $_POST['projektarbeit_id'];
+		$paabgabe_id = $_POST['paabgabe_id'];
+		$paabgabetyp_kurzbz = $_POST['paabgabetyp_kurzbz'];
+		$datum = $_POST['datum'];
+		$fixtermin = $_POST['fixtermin'];
+		$kurzbz = $_POST['kurzbz'];
+
+		if (!isset($projektarbeit_id) || isEmptyString($projektarbeit_id)
+			|| !isset($paabgabe_id) || isEmptyString($paabgabe_id)
+			|| !isset($datum) || isEmptyString($datum)
+			|| !isset($datum) || isEmptyString($datum)
+			|| !isset($paabgabetyp_kurzbz) || isEmptyString($paabgabetyp_kurzbz))
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+
+		$this->load->model('education/Paabgabe_model', 'PaabgabeModel');
+		
+		if($paabgabe_id == -1) {
+			$result = $this->PaabgabeModel->insert(
+				array(
+					'projektarbeit_id' => $projektarbeit_id,
+					'paabgabetyp_kurzbz' => $paabgabetyp_kurzbz,
+					'fixtermin' => $fixtermin,
+					'datum' => $datum,
+					'kurzbz' => $kurzbz,
+					'insertvon' => getAuthUID(),
+					'insertamum' => date('Y-m-d H:i:s')
+				)
+			);
+			
+			$this->terminateWithSuccess($result);
+		} else {
+			$result = $this->PaabgabeModel->update(
+				$paabgabe_id,
+				array(
+					'paabgabetyp_kurzbz' => $paabgabetyp_kurzbz,
+					'datum' => $datum,
+					'kurzbz' => $kurzbz,
+					'updatevon' => getAuthUID(),
+					'updateamum' => date('Y-m-d H:i:s')
+				)
+			);
+
+			$this->terminateWithSuccess($result);
+		}
+	}
+	
+	public function deleteProjektarbeitAbgabe() {
+		$paabgabe_id = $_POST['paabgabe_id'];
+		
+		if (!isset($paabgabe_id) || isEmptyString($paabgabe_id))
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+
+		$this->load->model('education/Paabgabe_model', 'PaabgabeModel');
+
+		$result = $this->PaabgabeModel->load($paabgabe_id);
+		$result = $this->getDataOrTerminateWithError($result);
+		
+		if(count($result) == 0) 
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+
+		// TODO: berechtigung?
+		if($result[0]->insertvon === getAuthUID()) {
+			$result = $this->PaabgabeModel->delete($paabgabe_id);
+			$result = $this->getDataOrTerminateWithError($result);
+			$this->terminateWithSuccess($result);
+		}
+
+		$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+	}
+
+	/**
+	 * endpoint for adding the same paabgabe for multiple projektarbeiten
+	 * can be slow for large n since it queries twice per projektarbeit_id
+	 */
+	public function postSerientermin() {
+		$projektarbeit_ids = $_POST['projektarbeit_ids'];
+		$datum = $_POST['datum'];
+		$paabgabetyp_kurzbz = $_POST['paabgabetyp_kurzbz'];
+		$bezeichnung = $_POST['bezeichnung'];
+		$kurzbz = $_POST['kurzbz'];
+
+		if (!isset($projektarbeit_ids) || !is_array($projektarbeit_ids) || empty($projektarbeit_ids)
+			|| !isset($datum) || isEmptyString($datum)
+			|| !isset($kurzbz) || isEmptyString($kurzbz)
+			|| !isset($bezeichnung) || isEmptyString($bezeichnung)
+			|| !isset($paabgabetyp_kurzbz) || isEmptyString($paabgabetyp_kurzbz))
+			$this->terminateWithError($this->p->t('global', 'wrongParameters'), 'general');
+		
+		// old script checks if there already are tbl_paabgabe entries with exact date, type & kurzbz
+		// for each termin - good to check that in principle but should not matter in this place. if necessary
+		// duplicate abgabetermine can be easily deleted manually, also via cronjob@night.
+		
+		// since this entry includes the kurzbz string match, it should have only ever mattered when there were
+		// multiple users entering the exact same set of (date, type, kurzbz) - which is a much more narrow case than the
+		// general "saveMultiple" function should handle
+		
+		// old script afterwards again queries if user is not the zweitbetreuer of any id - this is blocked in the ui
+		// and should never unintentionally happen
+		
+		// TODO: check berechtigung &/|| zuordnung?
+		
+		$this->load->model('education/Paabgabe_model', 'PaabgabeModel');
+		$this->load->model('education/Projektarbeit_model', 'ProjektarbeitModel');
+		
+		$res = [];
+		foreach ($projektarbeit_ids as $projektarbeit_id) {
+			
+			$result = $this->PaabgabeModel->insert(
+				array(
+					'projektarbeit_id' => $projektarbeit_id,
+					'paabgabetyp_kurzbz' => $paabgabetyp_kurzbz,
+					'fixtermin' => false,
+					'datum' => $datum,
+					'kurzbz' => $kurzbz,
+					'insertvon' => getAuthUID(),
+					'insertamum' => date('Y-m-d H:i:s')
+				)
+			);
+			
+			$data = $this->getDataOrTerminateWithError($result);
+			
+//			$res[] = $data;
+
+			// send mail to student
+			$result = $this->ProjektarbeitModel->getStudentInfoForProjektarbeitId($projektarbeit_id);
+			$data = $this->getDataOrTerminateWithError($result);
+
+//			$this->addMeta('emaildata'.$projektarbeit_id, $data);
+			
+			$datetime = new DateTime($datum);
+			$dateEmailFormatted = $datetime->format('d.m.Y');
+			
+			$anredeFillString = $data[0]->anrede=="Herr"?"r":"";
+			
+			$fullFormattedNameString = trim($data[0]->titelpre." ".$data[0]->vorname." ".$data[0]->nachname." ".$data[0]->titelpost);
+			$res[] = $fullFormattedNameString;
+			
+			// Prepare mail content
+			$body_fields = array(
+				'anrede' => $data[0]->anrede,
+				'anredeFillString' => $anredeFillString,
+				'datum' => $dateEmailFormatted,
+				'bezeichnung' => $bezeichnung,
+				'fullFormattedNameString' => $fullFormattedNameString,
+				'kurzbz' => $kurzbz
+			);
+
+			$email = $data[0]->uid."@".DOMAIN;
+			
+			sendSanchoMail(
+				'neuerAbgabetermin',
+				$body_fields,
+				$email,
+				$this->p->t('abgabetool', 'neuerTerminBachelorMasterbetreuung')
+			);
+		}
+		
+		$this->terminateWithSuccess($res);
+		
+	}
+	
+	public function fetchDeadlines() {
+		$person_id = $_POST['person_id'];
+		
+		if (!isset($person_id) || isEmptyString($person_id))
+			$person_id = getAuthPersonId();
+		
+		
+		if($person_id !== getAuthPersonId()) {
+			$this->load->library('PermissionLib');
+			$isAdmin = $this->permissionlib->isBerechtigt('admin');
+			if(!$isAdmin) $this->terminateWithError($this->p->t('ui', 'keineBerechtigung'), 'general');
+		}
+
+		$this->load->model('education/Paabgabe_model', 'PaabgabeModel');
+		$result = $this->PaabgabeModel->getDeadlines($person_id);
+		$data = $this->getDataOrTerminateWithError($result);
+
+		$this->terminateWithSuccess($data);
+	}
 }
 

application/controllers/api/frontend/v1/lv/Setup.php

@@ -47,22 +47,22 @@ class Setup extends FHCAPI_Controller
 	{
 		$tabs['details'] = array (
 			'title' =>  'Details',
-			'component' => absoluteJsImportUrl('public/js/components/LVVerwaltung/Tabs/Details.js'),
+			'component' => APP_ROOT . 'public/js/components/LVVerwaltung/Tabs/Details.js',
 			'config' => []
 		);
 		$tabs['gruppen'] = array (
 			'title' =>  'Gruppen',
-			'component' => absoluteJsImportUrl('public/js/components/LVVerwaltung/Tabs/Gruppen.js'),
+			'component' => APP_ROOT . 'public/js/components/LVVerwaltung/Tabs/Gruppen.js',
 			'config' => []
 		);
 		$tabs['lektor'] = array (
 			'title' =>  'LektorInnenzuteilung',
-			'component' => absoluteJsImportUrl('public/js/components/LVVerwaltung/Tabs/Lektor.js'),
+			'component' => APP_ROOT . 'public/js/components/LVVerwaltung/Tabs/Lektor.js',
 			'config' => []
 		);
 		$tabs['notiz'] = array (
 			'title' =>  'Notizen',
-			'component' => absoluteJsImportUrl('public/js/components/LVVerwaltung/Tabs/Notiz.js'),
+			'component' => APP_ROOT . 'public/js/components/LVVerwaltung/Tabs/Notiz.js',
 			'config' => []
 		);
 		$this->terminateWithSuccess($tabs);

application/controllers/api/frontend/v1/messages/Messages.php

@@ -1,5 +1,6 @@
 <?php
 
+
 if (!defined('BASEPATH')) exit('No direct script access allowed');
 
 class Messages extends FHCAPI_Controller
@@ -13,7 +14,6 @@ class Messages extends FHCAPI_Controller
 			'getMsgVarsPrestudent' => ['admin:r', 'assistenz:r'],
 			'getMsgVarsLoggedInUser' => ['admin:r', 'assistenz:r'],
 			'getNameOfDefaultRecipient' => ['admin:r', 'assistenz:r'],
-			'getNameOfDefaultRecipients' => ['admin:r', 'assistenz:r'],
 			'sendMessage' => ['admin:r', 'assistenz:r'],
 			'deleteMessage' => ['admin:r', 'assistenz:r'],
 			'getDataVorlage' => ['admin:r', 'assistenz:r'],
@@ -21,7 +21,8 @@ class Messages extends FHCAPI_Controller
 			'getReplyData' => ['admin:r', 'assistenz:r'],
 			'getPersonId' => ['admin:r', 'assistenz:r'],
 			'getUid' => ['admin:r', 'assistenz:r'],
-			'getUids' => ['admin:r', 'assistenz:r'],
+			'getStudiengang' => ['admin:r', 'assistenz:r'],
+
 		]);
 
 		//Load Models
@@ -38,7 +39,7 @@ class Messages extends FHCAPI_Controller
 
 		// Load language phrases
 		$this->loadPhrases([
-			'ui', 'messages'
+			'ui'
 		]);
 	}
 
@@ -85,66 +86,35 @@ class Messages extends FHCAPI_Controller
 		$this->terminateWithSuccess(array());
 	}
 
-	public function getDataVorlage($vorlage_kurzbz)
+	public function getDataVorlage($vorlage_kurzbz, $studiengang_kz)
 	{
-		$studiengang_kz = 0;
-		$this->load->model('system/Vorlagestudiengang_model', 'VorlagestudiengangModel');
-		$this->VorlagestudiengangModel->addOrder('version', 'DESC');
+		if(!$studiengang_kz)
+			$this->terminateWithSuccess(null);
 
-		$result = $this->VorlagestudiengangModel->loadWhere(
-			[
-				'vorlage_kurzbz' =>$vorlage_kurzbz,
-				'studiengang_kz' => $studiengang_kz
-			]);
+		$this->load->model('system/Vorlagestudiengang_model', 'VorlagestudiengangModel');
+
+		$result = $this->VorlagestudiengangModel->getCurrent($vorlage_kurzbz, $studiengang_kz);
 
 		$data = $this->getDataOrTerminateWithError($result);
-		$vorlage = current($data);
-		$this->terminateWithSuccess($vorlage);
+		$this->terminateWithSuccess(current($data));
 	}
 
-	public function getMessageVarsPerson($typeId)
+	public function getMessageVarsPerson($id, $typeId)
 	{
-		$ids = $this->input->post('ids');
-		$messageVarsPerson = [];
+		$person_id = ($typeId == 'mitarbeiter_uid') ? $this->_getPersonId($id, $typeId) : $id;
+		$result = $this->MessageModel->getMsgVarsDataByPersonId($person_id);
+		$data = $this->getDataOrTerminateWithError($result);
 
-		foreach ($ids as $id)
-		{
-			$person_id = ($typeId == 'mitarbeiter_uid') ? $this->_getPersonId($id, $typeId) : $id;
-			$result = $this->MessageModel->getMsgVarsDataByPersonId($person_id);
-			$data = $this->getDataOrTerminateWithError($result);
-			$messageVarsPerson[] = current($data);
-		}
-
-		$this->terminateWithSuccess($messageVarsPerson);
+		$this->terminateWithSuccess($data);
 	}
 
-	public function getMsgVarsPrestudent($typeId)
+	public function getMsgVarsPrestudent($id, $typeId)
 	{
-		$ids = $this->input->post('ids');
-		if(!is_array($ids)) {
-			$ids = array($ids);
-		}
-		$messageVarsPrestudent = [];
+		$prestudent_id = ($typeId == 'uid') ? $this->_getPrestudentIdFromUid($id) : $id;
+		$result = $this->MessageModel->getMsgVarsDataByPrestudentId($prestudent_id);
+		$data = $this->getDataOrTerminateWithError($result);
 
-		if($typeId == 'uid')
-		{
-			$prestudent_ids = [];
-			foreach ($ids as $id)
-			{
-				$prestudent_ids[] =  $this->_getPrestudentIdFromUid($id);
-			}
-		}
-		else
-			$prestudent_ids = $ids;
-
-		foreach ($prestudent_ids as $prestudent_id)
-		{
-			$result = $this->MessageModel->getMsgVarsDataByPrestudentId($prestudent_id);
-			$data = $this->getDataOrTerminateWithError($result);
-			$messageVarsPrestudent[] = current($data);
-		}
-
-		$this->terminateWithSuccess($messageVarsPrestudent);
+		$this->terminateWithSuccess($data);
 	}
 
 	public function getMsgVarsLoggedInUser()
@@ -155,45 +125,25 @@ class Messages extends FHCAPI_Controller
 		$this->terminateWithSuccess($data);
 	}
 
-	public function getNameOfDefaultRecipients($type_id)
+	public function getNameOfDefaultRecipient($id, $type_id)
 	{
-		$ids = $this->input->post('ids');
-		if(!is_array($ids)) {
-			$ids = array($ids);
-		}
-		$recipients = [];
-
-		if (empty($ids)) {
-
-			throw new InvalidArgumentException($this->p->t('ui', 'errorMissingOrInvalidParameters', ['parameter'=> 'Id(s)']), self::ERROR_TYPE_GENERAL);
-		}
+		$id = ($type_id != 'person_id') ? $this->_getPersonId($id, $type_id) : $id;
 
 		$this->load->model('person/Person_model', 'PersonModel');
-		if($type_id != 'person_id'){
-			foreach ($ids as $id)
-			{
-				$person_id =  $this->_getPersonId($id, $type_id);
-				$result = $this->PersonModel->load($person_id);
-				$data = $this->getDataOrTerminateWithError($result);
-				$name = current($data);
-				$recipients[$id] = $name->vorname . " " . $name->nachname;
-			}
-		}
-		else {
-			foreach ($ids as $id) {
-				$result = $this->PersonModel->load($id);
-				$data = $this->getDataOrTerminateWithError($result);
-				$name = current($data);
-				$recipients[$id] = $name->vorname . " " . $name->nachname;
-			}
-		}
 
-		$this->terminateWithSuccess($recipients);
+		$result = $this->PersonModel->load($id);
+		$data = $this->getDataOrTerminateWithError($result);
+		$name = current($data);
+
+		$this->terminateWithSuccess($name->vorname . " " . $name->nachname );
 	}
 
-	public function sendMessage($typeId)
+	public function sendMessage($recipient_id)
 	{
-		$resultReturn = [];
+		//has to be uid
+		//default setting
+		$receiversPersonId = $this->_getPersonId($recipient_id, 'uid');
+
 		$uid = getAuthUID();
 		$this->load->model('person/Benutzer_model', 'BenutzerModel');
 		$result = $this->BenutzerModel->loadWhere(
@@ -231,61 +181,47 @@ class Messages extends FHCAPI_Controller
 		$body = $this->input->post('body');
 		$relationmessage_id = $this->input->post('relationmessage_id');
 
-		if (isset($_POST['ids']))
+		$typeId = $this->input->post('type_id');
+		$id = $this->input->post('id');
+
+		if($typeId == 'uid')
 		{
-			$ids = json_decode($_POST['ids']);
-			unset($_POST['ids']);
-			foreach ($data as $k => $v) {
-				$_POST[$k] = $v;
-			}
-		}
+			$prestudent_id = $this-> _getPrestudentIdFromUid($id);
 
-		if (!is_array($ids)) {
-			$ids = [$ids];
+			//parseMessagetext for variables Prestudent
+			$result = $this->MessagesModel->parseMessageTextPrestudent($prestudent_id, $body);
+			$bodyParsed = $this->getDataOrTerminateWithError($result);
 		}
-
-		foreach ($ids as $id)
+		if($typeId == 'mitarbeiter_uid')
 		{
-			$receiversPersonId = $typeId == "person_id" ? $id : $this->_getPersonId($id, $typeId);
+			$person_id = $this->_getPersonId($id, $typeId);
 
-			if($typeId == 'uid')
-			{
-				$prestudent_id = $this-> _getPrestudentIdFromUid($id);
-
-				$result = $this->MessagesModel->parseMessageTextPrestudent($prestudent_id, $body);
-				$bodyParsed = $this->getDataOrTerminateWithError($result);
-			}
-			if($typeId == 'mitarbeiter_uid')
-			{
-				$person_id = $this->_getPersonId($id, $typeId);
-
-				$result = $this->MessagesModel->parseMessageTextPerson($person_id, $body);
-				$bodyParsed = $this->getDataOrTerminateWithError($result);
-			}
-			elseif($typeId == 'person_id')
-			{
-				$result = $this->MessagesModel->parseMessageTextPerson($id, $body);
-				$bodyParsed = $this->getDataOrTerminateWithError($result);
-			}
-			elseif($typeId == 'prestudent_id')
-			{
-				$result = $this->MessagesModel->parseMessageTextPrestudent($id, $body);
-				$bodyParsed = $this->getDataOrTerminateWithError($result);
-			}
-			else
-			{
-				$this->terminateWithError($this->p->t('messages', 'error_missingLogic', ['type'=> $typeId]), self::ERROR_TYPE_GENERAL);
-			}
-
-			$result =$this->messagelib->sendMessageUser($receiversPersonId, $subject, $bodyParsed, $benutzer->person_id, null, $relationmessage_id);
-			$data = $this->getDataOrTerminateWithError($result);
-			$resultReturn[] = current($data);
+			$result = $this->MessagesModel->parseMessageTextPerson($person_id, $body);
+			$bodyParsed = $this->getDataOrTerminateWithError($result);
+			$this->terminateWithError($bodyParsed, self::ERROR_TYPE_GENERAL);
 
 		}
-		$this->terminateWithSuccess($resultReturn);
+		elseif($typeId == 'person_id')
+		{
+			$result = $this->MessagesModel->parseMessageTextPerson($id, $body);
+			$bodyParsed = $this->getDataOrTerminateWithError($result);
+		}
+		elseif($typeId == 'prestudent_id')
+		{
+			$result = $this->MessagesModel->parseMessageTextPrestudent($id, $body);
+			$bodyParsed = $this->getDataOrTerminateWithError($result);
+		}
+		else
+		{
+			$this->terminateWithError("type_id " . $typeId . " not valid", self::ERROR_TYPE_GENERAL);
+		}
+
+		$result = $this->messagelib->sendMessageUser($receiversPersonId, $subject, $bodyParsed, $benutzer->person_id, null, $relationmessage_id);
+
+		$this->terminateWithSuccess($result);
 	}
 
-	public function getPreviewText($type_id)
+	public function getPreviewText($id, $type_id)
 	{
 		if (isset($_POST['data']))
 		{
@@ -293,60 +229,39 @@ class Messages extends FHCAPI_Controller
 			unset($_POST['data']);
 		}
 		else
-			$this->terminateWithError($this->p->t('messages', 'errorMissingOrInvalidParameters', ['parameter'=> "Textbody"]), self::ERROR_TYPE_GENERAL);
+			$this->terminateWithError("Textbody missing ", self::ERROR_TYPE_GENERAL);
 
-		if (isset($_POST['ids']))
+		switch($type_id)
 		{
-			$ids = json_decode($_POST['ids']);
-			if(!is_array($ids))
-			{
-				$ids = array($ids);
-			}
-			unset($_POST['ids']);
+			case 'uid':
+				$prestudent_id = $this->_getPrestudentIdFromUid($id);
+				$result = $this->MessagesModel->parseMessageTextPrestudent($prestudent_id, $data);
+				break;
+			case 'prestudent_id':
+				$result = $this->MessagesModel->parseMessageTextPrestudent($id, $data);
+				break;
+			case 'person_id':
+				$result = $this->MessagesModel->parseMessageTextPerson($id, $data);
+				break;
+			case 'mitarbeiter_uid':
+				{
+					$person_id = $this->_getPersonId($id, $type_id);
+					$result = $this->MessagesModel->parseMessageTextPerson($person_id, $data);
+				}
+				break;
+			default:
+				$this->terminateWithError("MESSAGES::getPreviewText logic for type_id " . $type_id . " not defined yet", self::ERROR_TYPE_GENERAL);
+				break;
 		}
-		else
-			$this->terminateWithError($this->p->t('ui', 'errorMissingOrInvalidParameters', ['parameter'=> 'Id(s)']), self::ERROR_TYPE_GENERAL);
 
-		$bodyParsed = [];
-
-		foreach ($ids as $id)
-		{
-			switch($type_id)
-			{
-				case 'uid':
-					$prestudent_id = $this->_getPrestudentIdFromUid($id);
-					$result = $this->MessagesModel->parseMessageTextPrestudent($prestudent_id, $data);
-					$bodyParsed[$id] = $this->getDataOrTerminateWithError($result);
-					break;
-				case 'prestudent_id':
-					$result = $this->MessagesModel->parseMessageTextPrestudent($id, $data);
-					$bodyParsed[$id] = $this->getDataOrTerminateWithError($result);
-					break;
-				case 'person_id':
-					$result = $this->MessagesModel->parseMessageTextPerson($id, $data);
-					$bodyParsed[$id] = $this->getDataOrTerminateWithError($result);
-					break;
-				case 'mitarbeiter_uid':
-					{
-						$person_id = $this->_getPersonId($id, $type_id);
-						$result = $this->MessagesModel->parseMessageTextPerson($person_id, $data);
-						$bodyParsed[$id] = $this->getDataOrTerminateWithError($result);
-					}
-					break;
-				default:
-					$this->terminateWithError($this->p->t('messages', 'error_missingLogic', ['type'=> $type_id]), self::ERROR_TYPE_GENERAL);
-					break;
-			}
-		}
+		$bodyParsed = $this->getDataOrTerminateWithError($result);
 
 		$this->terminateWithSuccess($bodyParsed);
 	}
 
 	public function getReplyData($messageId)
 	{
-		if (!is_numeric($messageId)) {
-			$this->terminateWithError($this->p->t('ui', 'error_valueNotNumeric', ['value'=> 'Message ID']), self::ERROR_TYPE_GENERAL);
-		}
+		//TODO(Manu) validation of messageId: if number
 
 		$this->MessageModel->addSelect('public.tbl_msg_message.*');
 		$this->MessageModel->addSelect('r.*');
@@ -369,6 +284,7 @@ class Messages extends FHCAPI_Controller
 		$replyBody = $this->_getReplyBody($body, $dataMessage[0]->nachname, $dataMessage[0]->vorname, $dataMessage[0]->insertamum);
 
 		$dataMessage[0]->replyBody = $replyBody;
+		$dataMessage[0]->rest = "Help Manu";
 		$dataMessage[0]->replySubject = $prefix . $subject;
 
 		$this->terminateWithSuccess($dataMessage);
@@ -416,11 +332,6 @@ class Messages extends FHCAPI_Controller
 				['prestudent_id' => $id]
 			);
 		}
-		else
-		{
-			$this->terminateWithError($this->p->t('messages', 'error_missingLogic', ['type'=> $typeId]), self::ERROR_TYPE_GENERAL);
-		}
-
 
 		$data = $this->getDataOrTerminateWithError($result);
 		$person = current($data);
@@ -428,11 +339,8 @@ class Messages extends FHCAPI_Controller
 		$this->terminateWithSuccess($person->person_id);
 	}
 
-	public function getUids($typeId)
+	public function getUid($id, $typeId)
 	{
-		$ids = $this->input->post('ids');
-		$benutzerIds = [];
-
 		if (!$typeId)
 		{
 			$this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Type ID']), self::ERROR_TYPE_GENERAL);
@@ -440,50 +348,54 @@ class Messages extends FHCAPI_Controller
 		elseif ($typeId == 'person_id')
 		{
 			$this->load->model('person/Benutzer_model', 'BenutzerModel');
-			foreach ($ids as $id)
-			{
-				$result = $this->BenutzerModel->loadWhere(
-					['person_id' => $id]
-				);
-				$data = $this->getDataOrTerminateWithError($result);
-				$benutzer = current($data);
-
-				$benutzerIds[$id] = $benutzer->uid;
-			}
+			$result = $this->BenutzerModel->loadWhere(
+				['person_id' => $id]
+			);
 		}
 		elseif($typeId == 'prestudent_id')
 		{
 			$this->load->model('crm/Prestudent_model', 'PrestudentModel');
-			foreach ($ids as $id)
-			{
-				$result = $this->PrestudentModel->loadWhere(
-					['prestudent_id' => $id]
-				);
+			$result = $this->PrestudentModel->loadWhere(
+				['prestudent_id' => $id]
+			);
 
-				$data = $this->getDataOrTerminateWithError($result);
-				$person = current($data);
-				$person_id = $person->person_id;
+			$data = $this->getDataOrTerminateWithError($result);
+			$person = current($data);
+			$person_id = $person->person_id;
 
-				$this->load->model('person/Benutzer_model', 'BenutzerModel');
-				$result = $this->BenutzerModel->loadWhere(
-					['person_id' => $person_id]
-				);
-				$data = $this->getDataOrTerminateWithError($result);
-				$benutzer = current($data);
-
-				$benutzerIds[$id] = $benutzer->uid;
-			}
+			$this->load->model('person/Benutzer_model', 'BenutzerModel');
+			$result = $this->BenutzerModel->loadWhere(
+				['person_id' => $person_id]
+			);
 		}
 		elseif($typeId == 'uid' || $typeId == 'mitarbeiter_uid')
 		{
-			$this->terminateWithSuccess($ids);
+			$this->terminateWithSuccess($id);
 		}
 		else
 		{
-			$this->terminateWithError($this->p->t('messages', 'error_missingLogic', ['type'=> $typeId]), self::ERROR_TYPE_GENERAL);
+			$this->terminateWithError("MESSAGES::getUID logic for type_id " . $typeId . " not defined yet", self::ERROR_TYPE_GENERAL);
 		}
 
-		$this->terminateWithSuccess($benutzerIds);
+		$data = $this->getDataOrTerminateWithError($result);
+		$benutzer = current($data);
+
+		$this->terminateWithSuccess($benutzer->uid);
+	}
+
+	public function getStudiengang($id, $typeId)
+	{
+		if($typeId!= "prestudent_id" && $typeId!="uid" )
+			$this->terminateWithSuccess(null);
+
+		$prestudent_id = ($typeId == 'uid') ? $this->_getPrestudentIdFromUid($id) : $id;
+
+		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
+		$result = $this->PrestudentModel->load($prestudent_id);
+		$data = $this->getDataOrTerminateWithError($result);
+		$studiengang_kz = current($data)->studiengang_kz;
+
+		return $this->terminateWithSuccess($studiengang_kz);
 	}
 
 	private function _getPersonId($id, $typeId)
@@ -502,16 +414,11 @@ class Messages extends FHCAPI_Controller
 				['prestudent_id' => $id]
 			);
 		}
-		else
-		{
-			$this->terminateWithError($this->p->t('messages', 'error_missingLogic', ['type'=> $typeId]), self::ERROR_TYPE_GENERAL);
-		}
-
 
 		$data = $this->getDataOrTerminateWithError($result);
 		if (count($data) < 1)
 		{
-			$this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Person ID']), self::ERROR_TYPE_GENERAL);
+			$this->terminateWithError('Error: Messages API no person_id found.');
 		}
 		$person = current($data);
 
@@ -528,7 +435,7 @@ class Messages extends FHCAPI_Controller
 		$data = $this->getDataOrTerminateWithError($result);
 		if (count($data) < 1)
 		{
-			$this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Prestudent ID']), self::ERROR_TYPE_GENERAL);
+			$this->terminateWithError('Error: Messages API no prestudent_id found.');
 		}
 		$student = current($data);
 

application/controllers/api/frontend/v1/organisation/Studienplan.php

@@ -1,69 +0,0 @@
-<?php
-/**
- * FH-Complete
- *
- * @package        FHC-API
- * @author        FHC-Team
- * @copyright    Copyright (c) 2016, fhcomplete.org
- * @license        GPLv3
- * @link        http://fhcomplete.org
- * @since        Version 1.0
- * @filesource
- */
-// ------------------------------------------------------------------------
-
-if (! defined('BASEPATH')) exit('No direct script access allowed');
-
-class Studienplan extends FHCAPI_Controller
-{
-	public function __construct()
-	{
-		// TODO(chris): access!
-		parent::__construct([
-			'getBySemester' => self::PERM_LOGGED
-		]);
-	}
-
-	public function getBySemester()
-	{
-		$this->load->model('organisation/Studienplan_model', 'StudienplanModel');
-
-		$studiengang_kz = $this->input->get('studiengang_kz');
-		$studiensemester_kurzbz = $this->input->get('studiensemester_kurzbz');
-		$ausbildungssemester = $this->input->get('ausbildungssemester') ?: null;
-		$orgform_kurzbz = $this->input->get('orgform_kurzbz') ?: null;
-
-		if (!$studiengang_kz || !is_numeric($studiengang_kz))
-			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Studiengangskennzahl']), self::ERROR_TYPE_GENERAL);
-
-		if (!$studiensemester_kurzbz)
-			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Studiensemester']), self::ERROR_TYPE_GENERAL);
-
-		if (isset($ausbildungssemester) && !is_numeric($ausbildungssemester))
-			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Ausbildungssemester']), self::ERROR_TYPE_GENERAL);
-
-
-		//~ $this->load->library('form_validation');
-		
-		//~ $this->form_validation->set_rules('studiengang_kz', 'StudiengangKz', 'required|numeric');
-		//~ $this->form_validation->set_rules('studiensemester_kurzbz', 'StudiensemesterKurbz', 'required');
-		//~ $this->form_validation->set_rules('ausbildungssemester', 'Ausbildungssemester', 'numeric');
-
-		//~ if (!$this->form_validation->run())
-		//~ {
-			//~ $this->addMeta('fail2', 'fail2');
-			//~ return $this->terminateWithValidationErrors($this->form_validation->error_array());
-		//~ }
-
-
-		$this->addMeta('stg_kz', $studiengang_kz);
-		$this->addMeta('sem', $studiensemester_kurzbz);
-		$this->addMeta('sem2', $ausbildungssemester);
-		$this->addMeta('org', $orgform_kurzbz);
-
-		$result = $this->StudienplanModel->getStudienplaeneBySemester($studiengang_kz, $studiensemester_kurzbz, $ausbildungssemester, $orgform_kurzbz);
-		if (isError($result)) $this->terminateWithError(getError($result), self::ERROR_TYPE_DB);
-
-		$this->terminateWithSuccess(hasData($result) ? getData($result) : []);
-	}
-}

application/controllers/api/frontend/v1/organisation/Studiensemester.php

@@ -25,8 +25,7 @@ class Studiensemester extends FHCAPI_Controller
 			array(
 				'getAll' => self::PERM_LOGGED,
 				'getAktNext' => self::PERM_LOGGED,
-				'getStudienjahrByStudiensemester' => self::PERM_LOGGED,
-				'getAllStudiensemesterAndAktOrNext' => self::PERM_LOGGED
+				'getStudienjahrByStudiensemester' => self::PERM_LOGGED
 			)
 		);
 		// Load model StudiensemesterModel
@@ -153,17 +152,4 @@ class Studiensemester extends FHCAPI_Controller
 
 		$this->terminateWithSuccess((getData(success($studienjahrObj))));
 	}
-
-	public function getAllStudiensemesterAndAktOrNext() {
-		$this->load->model('organisation/Studiensemester_model', 'StudiensemesterModel');
-
-		$this->StudiensemesterModel->addOrder("start", "DESC");
-		$result = $this->StudiensemesterModel->getAktOrNextSemester();
-		$aktuell = getData($result)[0];
-		$this->StudiensemesterModel->addSelect('*');
-		$result = $this->StudiensemesterModel->load();
-		$studiensemester = getData($result);
-		
-		$this->terminateWithSuccess(array($studiensemester, $aktuell));
-	}
 }

application/controllers/api/frontend/v1/stv/Config.php

@@ -331,10 +331,7 @@ class Config extends FHCAPI_Controller
 		];
 		$result['status'] = [
 			'title' => 'Status',
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/MultiStatus.js'),
-			'config' => [
-				'showStatusVorruecken' => defined('STATUS_VORRUECKEN_ANZEIGEN') ? STATUS_VORRUECKEN_ANZEIGEN : true,
-			]
+			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/MultiStatus.js')
 		];
 		$result['documents'] = [
 			'title' => $this->p->t('stv', 'tab_documents'),
@@ -365,6 +362,7 @@ class Config extends FHCAPI_Controller
 		$result['messages'] = [
 			'title' => $this->p->t('stv', 'tab_messages'),
 			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Messages.js'),
+			'showOnlyWithUid' => true
 		];
 
 		$result['grades'] = [
@@ -504,7 +502,7 @@ class Config extends FHCAPI_Controller
 		{
 			$result['combinePeople'] = [
 				'title' => $this->p->t('stv', 'tab_combine_people'),
-				'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/CombinePeople.js'),
+				'component' => './Stv/Studentenverwaltung/Details/CombinePeople.js',
 				'config' => $config['combinePeople']
 			];
 		}
@@ -514,11 +512,6 @@ class Config extends FHCAPI_Controller
 			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Kontaktieren.js'),
 		];
 
-		$result['messages'] = [
-			'title' => $this->p->t('stv', 'tab_messages'),
-			'component' => absoluteJsImportUrl('public/js/components/Stv/Studentenverwaltung/Details/Messages.js'),
-		];
-
 		Events::trigger('stv_conf_students', function & () use (&$result) {
 			return $result;
 		});

application/controllers/api/frontend/v1/stv/Dokumente.php

@@ -590,14 +590,14 @@ class Dokumente extends FHCAPI_Controller
 
 		$documents = [
 			buildDropdownEntryPrintArray("accountinfo", "Accountinfoblatt", "xml=accountinfoblatt.xml.php&xsl=AccountInfo&output=pdf", $uid, 10, null),
-			buildDropdownEntryPrintArray("ausbildungsvertrag", "Ausbildungsvertrag", "xml=ausbildungsvertrag.xml.php&xsl=Ausbildungsver&output=pdf&prestudent_id=$prestudent_id", null,20, null),
-			buildDropdownEntryPrintArray("ausbildungsvertrag_en", "Ausbildungsvertrag Zweisprachig", "xml=ausbildungsvertrag.xml.php&xsl=AusbVerEng&output=pdf&prestudent_id=$prestudent_id", null,21, null),
+			buildDropdownEntryPrintArray("ausbildungsvertrag", "Ausbildungsvertrag", "xml=ausbildungsvertrag.xml.php&xsl=Ausbildungsver&output=pdf", $uid, 20, null),
+			buildDropdownEntryPrintArray("ausbildungsvertrag_en", "Ausbildungsvertrag Zweisprachig", "xml=ausbildungsvertrag.xml.php&xsl=AusbVerEng&output=pdf", $uid, 21, null),
 
 			buildDropdownEntryPrintArray("bescheid", "Bescheid (nur Voransicht)", "xml=abschlusspruefung.rdf.php&xsl_stg_kz=$studiengang_kz&xsl=Bescheid&output=pdf", $uid, 25, null),
 			buildDropdownEntryPrintArray("diplomasupp", "Diploma Supplement (nur Voransicht)", "xml=diplomasupplement.xml.php&xsl_stg_kz=$studiengang_kz&xsl=DiplSupplement&output=pdf", $uid, 26, null),
 
-			buildDropdownEntryPrintArray("studienbestaetigung", "Studienbestätigung", "xml=student.rdf.php&xsl=Inskription&output=pdf&ss=$studiensemester_kurzbz&xsl_stg_kz=$studiengang_kz", $uid, 50, null),
-			buildDropdownEntryPrintArray("studienbestaetigung_en", "Studienbestätigung Englisch", "xml=student.rdf.php&xsl=InskriptionEng&output=pdf&ss=$studiensemester_kurzbz&xsl_stg_kz=$studiengang_kz", $uid, 51, null),
+			buildDropdownEntryPrintArray("studienbestaetigung", "Studienbestätigung", "xml=student.rdf.php&xsl=Inskription&output=pdf", $uid, 50, null),
+			buildDropdownEntryPrintArray("studienbestaetigung_en", "Studienbestätigung Englisch", "xml=student.rdf.php&xsl=InskriptionEng&output=pdf", $uid, 51, null),
 			buildDropdownEntryPrintArray("zutrittskarte", "Zutrittskarte", "xsl=ZutrittskarteStud&output=pdf&data=$uid", $uid,200, "zutrittskarte.php"),
 			buildDropdownEntryPrintArray("studienblatt", "Studienblatt", "xml=studienblatt.xml.php&xsl=Studienblatt&output=pdf&ss=$studiensemester_kurzbz", $uid, 60, null),
 			buildDropdownEntryPrintArray("studienblatt_eng", "Studienblatt Englisch", "xml=studienblatt.xml.php&xsl=StudienblattEng&output=pdf&ss=$studiensemester_kurzbz", $uid, 61, null),
@@ -686,8 +686,8 @@ class Dokumente extends FHCAPI_Controller
 			buildDropdownEntryPrintArray("accountinfo", "Accountinfoblatt", "xml=accountinfoblatt.xml.php&xsl=AccountInfo&output=pdf", $uidString, 10, null),
 			buildDropdownEntryPrintArray("ausbildungsvertrag", "Ausbildungsvertrag", "xml=ausbildungsvertrag.xml.php&xsl=Ausbildungsver&output=pdf", $uidString, 20, null),
 			buildDropdownEntryPrintArray("ausbildungsvertrag_en", "Ausbildungsvertrag Englisch", "xml=ausbildungsvertrag.xml.php&xsl=AusbVerEng&output=pdf", $uidString, 21, null),
-			buildDropdownEntryPrintArray("studienbestaetigung", "Studienbestätigung", "xml=student.rdf.php&xsl=Inskription&output=pdf&ss=$studiensemester_kurzbz&xsl_stg_kz=$studiengang_kz", $uidString, 50, null),
-			buildDropdownEntryPrintArray("studienbestaetigung_en", "Studienbestätigung Englisch", "xml=student.rdf.php&xsl=InskriptionEng&output=pdf&ss=$studiensemester_kurzbz&xsl_stg_kz=$studiengang_kz", $uidString, 51, null),
+			buildDropdownEntryPrintArray("studienbestaetigung", "Studienbestätigung", "xml=student.rdf.php&xsl=Inskription&output=pdf", $uidString, 50, null),
+			buildDropdownEntryPrintArray("studienbestaetigung_en", "Studienbestätigung Englisch", "xml=student.rdf.php&xsl=InskriptionEng&output=pdf", $uidString, 51, null),
 			buildDropdownEntryPrintArray("zutrittskarte", "Zutrittskarte", "xsl=ZutrittskarteStud&output=pdf&data=$uidString", $uidString,200, "zutrittskarte.php"),
 			buildDropdownEntryPrintArray("studienblatt", "Studienblatt", "xml=studienblatt.xml.php&xsl=Studienblatt&output=pdf&ss=$studiensemester_kurzbz", $uidString, 60, null),
 			buildDropdownEntryPrintArray("studienblatt_eng", "Studienblatt Englisch", "xml=studienblatt.xml.php&xsl=StudienblattEng&output=pdf&ss=$studiensemester_kurzbz", $uidString, 61, null),

application/controllers/api/frontend/v1/stv/Grades.php

@@ -60,8 +60,7 @@ class Grades extends FHCAPI_Controller
 	{
 		$this->load->model('codex/Note_model', 'NoteModel');
 
-		$this->NoteModel->addOrder('notenwert', 'ASC');
-		$this->NoteModel->addOrder('bezeichnung', 'ASC');
+		$this->NoteModel->addOrder('note');
 		
 		$result = $this->NoteModel->load();
 

application/controllers/api/frontend/v1/stv/Konto.php

@@ -239,7 +239,7 @@ class Konto extends FHCAPI_Controller
 				$data[$field] = $this->input->post($field);
 
 		if (defined('FAS_BUCHUNGSTYP_FIXE_KOSTENSTELLE') && isset(unserialize(FAS_BUCHUNGSTYP_FIXE_KOSTENSTELLE)[$data['buchungstyp_kurzbz']])) {
-			$data['studiengang_kz'] = unserialize(FAS_BUCHUNGSTYP_FIXE_KOSTENSTELLE)[$data['buchungstyp_kurzbz']];
+			$data['kostenstelle'] = unserialize(FAS_BUCHUNGSTYP_FIXE_KOSTENSTELLE)[$data['buchungstyp_kurzbz']];
 		}
 
 		$result = [];

application/controllers/api/frontend/v1/stv/Prestudent.php

@@ -43,7 +43,7 @@ class Prestudent extends FHCAPI_Controller
 
 		// Load language phrases
 		$this->loadPhrases([
-			'ui', 'studierendenantrag', 'lehre', 'global'
+			'ui', 'studierendenantrag', 'lehre'
 		]);
 	}
 
@@ -98,9 +98,11 @@ class Prestudent extends FHCAPI_Controller
 			'person_id',
 			'berufstaetigkeit_code',
 			'ausbildungcode',
+			'zgv_code',
 			'zgvort',
 			'zgvdatum',
 			'zgvnation',
+			'zgvmas_code',
 			'zgvmaort',
 			'zgvmadatum',
 			'zgvmanation',
@@ -108,6 +110,7 @@ class Prestudent extends FHCAPI_Controller
 			'bismelden',
 			'anmerkung',
 			'dual',
+			'zgvdoktor_code',
 			'zgvdoktorort',
 			'zgvdoktordatum',
 			'zgvdoktornation',
@@ -122,57 +125,6 @@ class Prestudent extends FHCAPI_Controller
 			'standort_code'
 		];
 
-		// add zgv code fields only if user has permission
-		$this->load->library('PermissionLib');
-		$prestudentres = $this->PrestudentModel->load($prestudent_id);
-		if(!hasData($prestudentres))
-		{
-			$this->terminateWithError($this->p->t('ui', 'error_fieldNotFound', ['field' => 'Prestudent ' . $prestudent_id]));
-		}
-		$prestudent = (getData($prestudentres))[0];
-		$bakkZgvStg = $this->permissionlib->getSTG_isEntitledFor('student/editBakkZgv') ?: array();
-		$makkZgvStg = $this->permissionlib->getSTG_isEntitledFor('student/editMakkZgv') ?: array();
-		$dokZgvStg = $this->permissionlib->getSTG_isEntitledFor('student/editDokZgv') ?: array();
-
-		if(in_array($prestudent->studiengang_kz, $bakkZgvStg)) 
-		{
-			$array_allowed_props_prestudent[] = 'zgv_code';
-		}
-		else if(!is_null($this->input->post('zgv_code')))
-		{
-			$this->terminateWithError(
-				$this->p->t('global', 'zgv')
-				. ' - ' .
-				$this->p->t('ui', 'error_keineBerechtigungStg')
-			);
-		}
-
-		if(in_array($prestudent->studiengang_kz, $makkZgvStg))
-		{
-			$array_allowed_props_prestudent[] = 'zgvmas_code';
-		}
-		else if(!is_null($this->input->post('zgvmas_code')))
-		{
-			$this->terminateWithError(
-				$this->p->t('lehre', 'zgvMaster')
-				. ' - ' .
-				$this->p->t('ui', 'error_keineBerechtigungStg')
-			);
-		}
-
-		if(in_array($prestudent->studiengang_kz, $dokZgvStg))
-		{
-			$array_allowed_props_prestudent[] = 'zgvdoktor_code';
-		}
-		else if(!is_null($this->input->post('zgvdoktor_code')))
-		{
-			$this->terminateWithError(
-				$this->p->t('lehre', 'zgvDoktor')
-				. ' - ' .
-				$this->p->t('ui', 'error_keineBerechtigungStg')
-			);
-		}
-
 		// add UDFs
 		$result = $this->udflib->getDefinitionForModel($this->PrestudentModel);
 

application/controllers/api/frontend/v1/stv/Projektarbeit.php

@@ -17,8 +17,7 @@ class Projektarbeit extends FHCAPI_Controller
 			'getTypenProjektarbeit' => ['admin:r', 'assistenz:r'],
 			'getFirmen' => ['admin:r', 'assistenz:r'],
 			'getLehrveranstaltungen' => ['admin:r', 'assistenz:r'],
-			'getNoten' => ['admin:r', 'assistenz:r'],
-			'getStudiensemester' => ['admin:r', 'assistenz:r']
+			'getNoten' => ['admin:r', 'assistenz:r']
 		]);
 
 		// Load Libraries
@@ -41,15 +40,11 @@ class Projektarbeit extends FHCAPI_Controller
 		$this->load->model('ressource/Mitarbeiter_model', 'MitarbeiterModel');
 		$this->load->model('education/Note_model', 'NoteModel');
 		$this->load->model('education/Projektbetreuer_model', 'BetreuerModel');
-		$this->load->model('organisation/Studiensemester_model', 'StudiensemesterModel');
 
 		// load libraries
 		$this->load->library('PermissionLib');
 	}
 
-	/**
-	 * Get projekt works for a uid.
-	 */
 	public function getProjektarbeit()
 	{
 		$student_uid = $this->input->get('uid');
@@ -58,7 +53,10 @@ class Projektarbeit extends FHCAPI_Controller
 
 		$result = $this->ProjektarbeitModel->getProjektarbeit($student_uid);
 
-		if (isError($result)) $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
+		if (isError($result))
+		{
+			$this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
+		}
 
 		if (!hasData($result)) $this->terminateWithSuccess([]);
 
@@ -81,9 +79,6 @@ class Projektarbeit extends FHCAPI_Controller
 		$this->terminateWithSuccess($projektarbeiten);
 	}
 
-	/**
-	 * Load a single Projektarbeit by id.
-	 */
 	public function loadProjektarbeit()
 	{
 		$projektarbeit_id = $this->input->get('projektarbeit_id');
@@ -106,9 +101,6 @@ class Projektarbeit extends FHCAPI_Controller
 		$this->terminateWithSuccess(current($data));
 	}
 
-	/**
-	 * Inwert a Projektarbeit.
-	 */
 	public function insertProjektarbeit()
 	{
 		$student_uid = $this->input->post('uid');
@@ -136,9 +128,6 @@ class Projektarbeit extends FHCAPI_Controller
 		$this->terminateWithSuccess($data);
 	}
 
-	/**
-	 * Update a Projektarbeit by ID.
-	 */
 	public function updateProjektarbeit()
 	{
 		$projektarbeit_id = $this->input->post('projektarbeit_id');
@@ -168,9 +157,6 @@ class Projektarbeit extends FHCAPI_Controller
 		$this->terminateWithSuccess($data);
 	}
 
-	/**
-	 * Delete Projektarbeit by ID after validation.
-	 */
 	public function deleteProjektarbeit()
 	{
 		$projektarbeit_id = $this->input->post('projektarbeit_id');
@@ -199,9 +185,6 @@ class Projektarbeit extends FHCAPI_Controller
 		return $this->terminateWithSuccess(current(getData($result)) ? : null);
 	}
 
-	/**
-	 * Get all active projekt work types.
-	 */
 	public function getTypenProjektarbeit()
 	{
 		$result = $this->ProjekttypModel->loadWhere(['aktiv' => true]);
@@ -211,9 +194,6 @@ class Projektarbeit extends FHCAPI_Controller
 		return $this->terminateWithSuccess(hasData($result) ? getData($result) : []);
 	}
 
-	/**
-	 * Gets companies by search string.
-	 */
 	public function getFirmen()
 	{
 		$searchString = $this->input->get('searchString');
@@ -228,9 +208,6 @@ class Projektarbeit extends FHCAPI_Controller
 		return $this->terminateWithSuccess(hasData($result) ? getData($result) : []);
 	}
 
-	/**
-	 * Get Lehrveranstaltungen by params, incling lehreinheiten for a specific Studiensemester..
-	 */
 	public function getLehrveranstaltungen()
 	{
 		$student_uid = $this->input->get('student_uid');
@@ -241,7 +218,6 @@ class Projektarbeit extends FHCAPI_Controller
 		if (!isset($student_uid)) $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Student UID']), self::ERROR_TYPE_GENERAL);
 		if (!isset($studiensemester_kurzbz)) $this->terminateWithError('Studiensemster missing', self::ERROR_TYPE_GENERAL);
 
-		// get Lvs
 		$lvsResult = $this->LehrveranstaltungModel->getLvsForProjektarbeit($student_uid, $studiengang_kz, $additional_lehrveranstaltung_id);
 
 		if (isError($lvsResult)) return $this->terminateWithError($lvsResult, self::ERROR_TYPE_GENERAL);
@@ -250,7 +226,6 @@ class Projektarbeit extends FHCAPI_Controller
 
 		foreach ($lvs as $lv)
 		{
-			// add Lehreinheiten for each Lv for the semester
 			$lehreinheiten = $this->LehreinheitModel->getLesForLv(
 				$lv->lehrveranstaltung_id, $studiensemester_kurzbz
 			);
@@ -275,14 +250,8 @@ class Projektarbeit extends FHCAPI_Controller
 		return $this->terminateWithSuccess($lvs);
 	}
 
-	/**
-	 * Get all noten.
-	 */
 	public function getNoten()
 	{
-		$this->NoteModel->addOrder('notenwert', 'ASC');
-		$this->NoteModel->addOrder('bezeichnung', 'ASC');
-
 		$result = $this->NoteModel->load();
 
 		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
@@ -291,22 +260,9 @@ class Projektarbeit extends FHCAPI_Controller
 	}
 
 	/**
-	 * Get all Studiensemester, sorted.
-	 */
-	public function getStudiensemester()
-	{
-		$this->StudiensemesterModel->addOrder('start', 'DESC');
-		$result = $this->StudiensemesterModel->load();
-
-		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
-
-		return $this->terminateWithSuccess(hasData($result) ? getData($result) : []);
-	}
-
-	/**
-	 * Validate Projektarbeit data.
-	 * @param formData
-	 * @return bool true if data valid
+	 *
+	 * @param
+	 * @return object success or error
 	 */
 	private function _validate($formData)
 	{
@@ -337,9 +293,9 @@ class Projektarbeit extends FHCAPI_Controller
 	}
 
 	/**
-	 * Extract Projektarbeit data from passed form data.
-	 * @param formData
-	 * @return array
+	 * 
+	 * @param
+	 * @return object success or error
 	 */
 	private function _getProjektarbeitArr($formData)
 	{
@@ -361,9 +317,9 @@ class Projektarbeit extends FHCAPI_Controller
 	}
 
 	/**
-	 * Check if deletion of a Projektarbeit is possible.
-	 * @param $projektarbeit_id
-	 * @return object success if deletion possible, error otherwise.
+	 *
+	 * @param
+	 * @return object success or error
 	 */
 	private function _validateDelete($projektarbeit_id)
 	{
@@ -384,11 +340,6 @@ class Projektarbeit extends FHCAPI_Controller
 		return success();
 	}
 
-	/**
-	 * Checks permissions for a student.
-	 * @param $student_uid
-	 * @return bool true if authorized
-	 */
 	private function _hasBerechtigungForStudent($student_uid)
 	{
 		if (!$student_uid)

application/controllers/api/frontend/v1/stv/Projektbetreuer.php

@@ -3,7 +3,7 @@
 if (! defined('BASEPATH')) exit('No direct script access allowed');
 
 use \DateTime as DateTime;
-use \CI3_Events as Events;
+use CI3_Events as Events;
 
 class Projektbetreuer extends FHCAPI_Controller
 {
@@ -43,9 +43,6 @@ class Projektbetreuer extends FHCAPI_Controller
 		$this->load->library('PermissionLib');
 	}
 
-	/**
-	 * Gets Projektbetreuer data for a Projektarbeit.
-	 */
 	public function getProjektbetreuer()
 	{
 		$projektarbeit_id = $this->input->get('projektarbeit_id');
@@ -53,30 +50,21 @@ class Projektbetreuer extends FHCAPI_Controller
 		if (!isset($projektarbeit_id))
 			$this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Projektarbeit ID']), self::ERROR_TYPE_GENERAL);
 
-		$qry = "
-			SELECT * FROM (
-				SELECT
-					projektarbeit_id, person_id, nachname, vorname, note, punkte, round(stunden, 1) AS stunden,
-					stundensatz, betreuerart_kurzbz, vertrag_id, titelpre, titelpost,
-					CASE
-						WHEN EXISTS
-							(SELECT 1 FROM public.tbl_benutzer JOIN public.tbl_mitarbeiter ON(uid=mitarbeiter_uid) WHERE person_id=pers.person_id)
-						THEN 'Mitarbeiter'
-						WHEN EXISTS
-							(SELECT 1 FROM public.tbl_benutzer JOIN public.tbl_student ON(uid=student_uid) WHERE person_id=pers.person_id)
-						THEN 'Student'
-						ELSE 'Person'
-					END AS status
-				FROM
-					lehre.tbl_projektbetreuer
-					JOIN public.tbl_person pers USING (person_id)
-				WHERE
-					projektarbeit_id = ?
-			) betreuer
-			ORDER BY
-				CASE WHEN status = 'Mitarbeiter' THEN 0 WHEN status = 'Person' THEN 1 ELSE 2 END";
-
-		$result = $this->ProjektbetreuerModel->execReadOnlyQuery($qry, [$projektarbeit_id]);
+		$this->ProjektbetreuerModel->addSelect(
+			'projektarbeit_id, person_id, nachname, vorname, note, punkte, round(stunden, 1) AS stunden,
+			stundensatz, betreuerart_kurzbz, vertrag_id, titelpre, titelpost'
+		);
+		$this->ProjektbetreuerModel->addSelect("CASE
+				WHEN EXISTS
+					(SELECT 1 FROM public.tbl_benutzer JOIN public.tbl_mitarbeiter ON(uid=mitarbeiter_uid) WHERE person_id=pers.person_id)
+				THEN 'Mitarbeiter'
+				WHEN EXISTS
+					(SELECT 1 FROM public.tbl_benutzer JOIN public.tbl_student ON(uid=student_uid) WHERE person_id=pers.person_id)
+				THEN 'Student'
+				ELSE 'Person'
+			END AS status");
+		$this->ProjektbetreuerModel->addJoin('public.tbl_person pers', 'person_id');
+		$result = $this->ProjektbetreuerModel->loadWhere(['projektarbeit_id' => $projektarbeit_id]);
 
 		if (isError($result)) $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
 
@@ -98,7 +86,6 @@ class Projektbetreuer extends FHCAPI_Controller
 			//~ }
 		//~ }
 
-		// add thesis download link (from external extension)
 		foreach ($projektbetreuer as $pb)
 		{
 			$downloadLink = null;
@@ -117,9 +104,6 @@ class Projektbetreuer extends FHCAPI_Controller
 		$this->terminateWithSuccess($this->_addFullNameToBetreuer($projektbetreuer));
 	}
 
-	/**
-	 * Saves (adds or updates) a single Projektbetreuer for a Projektarbeit.
-	 */
 	public function saveProjektbetreuer()
 	{
 		$projektarbeit_id = $this->input->post('projektarbeit_id');
@@ -134,36 +118,14 @@ class Projektbetreuer extends FHCAPI_Controller
 
 		if ($this->_validate($projektbetreuer) == false) $this->terminateWithValidationErrors($this->form_validation->error_array());
 
-		// check if assessor has already been assigned
-		if (isset($projektbetreuer['person_id']))
-		{
-			$this->ProjektbetreuerModel->addSelect('1');
-			$betreuerRes = $this->ProjektbetreuerModel->loadWhere(
-				[
-					'person_id' => $projektbetreuer['person_id'],
-					'projektarbeit_id' => $projektbetreuer['projektarbeit_id'],
-					'betreuerart_kurzbz' => $projektbetreuer['betreuerart_kurzbz']
-				]
-			);
-
-			if (hasData($betreuerRes)
-				&& (!isset($projektbetreuer['person_id_old']) || $projektbetreuer['person_id'] != $projektbetreuer['person_id_old'])) {
-				return $this->terminateWithError($this->p->t('projektarbeit', 'betreuerZugewiesen'), self::ERROR_TYPE_GENERAL);
-			}
-		}
-
 		$result = null;
 
-		$stunden = isset($projektbetreuer['stunden']) && !isEmptyString($projektbetreuer['stunden']) ? $projektbetreuer['stunden'] : null;
-		$stundensatz =
-			isset($projektbetreuer['stundensatz']) && !isEmptyString($projektbetreuer['stundensatz']) ? $projektbetreuer['stundensatz'] : null;
-
 		$betreuer = [
 			'projektarbeit_id' => $projektarbeit_id,
 			'person_id' => $projektbetreuer['person_id'],
 			'note' => $projektbetreuer['note'],
-			'stunden' => $stunden,
-			'stundensatz' => $stundensatz,
+			'stunden' => $projektbetreuer['stunden'],
+			'stundensatz' => $projektbetreuer['stundensatz'],
 			'betreuerart_kurzbz' => $projektbetreuer['betreuerart_kurzbz']
 		];
 
@@ -190,9 +152,6 @@ class Projektbetreuer extends FHCAPI_Controller
 		$this->terminateWithSuccess(hasData($result) ? getData($result) : []);
 	}
 
-	/**
-	 * Delete a Projektbetreuer assignment to a Projektarbeit.
-	 */
 	public function deleteProjektbetreuer()
 	{
 		$projektarbeit_id = $this->input->post('projektarbeit_id');
@@ -200,44 +159,21 @@ class Projektbetreuer extends FHCAPI_Controller
 		$betreuerart_kurzbz = $this->input->post('betreuerart_kurzbz');
 
 		if (!isset($projektarbeit_id) || !is_numeric($projektarbeit_id))
-		{
-			return $this->terminateWithError(
-				$this->p->t('ui', 'error_missingId', ['id'=> $this->p->t('projektarbeit', 'projektarbeit').' ID'], self::ERROR_TYPE_GENERAL)
-			);
-		}
+			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> $this->p->t('projektarbeit', 'projektarbeit').' ID'], self::ERROR_TYPE_GENERAL));
 
 		if (!isset($person_id) || !is_numeric($person_id))
 			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> 'Person ID'], self::ERROR_TYPE_GENERAL));
 
 		if (!isset($betreuerart_kurzbz))
-		{
-			return $this->terminateWithError(
-				$this->p->t('ui', 'error_missingId', ['id'=> $this->p->t('projektarbeit', 'betreuerart')], self::ERROR_TYPE_GENERAL)
-			);
-		}
+			return $this->terminateWithError($this->p->t('ui', 'error_missingId', ['id'=> $this->p->t('projektarbeit', 'betreuerart')], self::ERROR_TYPE_GENERAL));
 
-		// check permission
 		if (!$this->ProjektarbeitModel->hasBerechtigungForProjektarbeit($projektarbeit_id))
 			return $this->_outputAuthError([$this->router->method => ['admin:rw', 'assistenz:rw']]);
 
-		$validate = $this->_validateDelete($projektarbeit_id, $person_id, $betreuerart_kurzbz);
+		$validate = $this->_validateDelete($projektarbeit_id, $person_id);
 
 		if (isError($validate)) return $this->terminateWithError(getError($validate), self::ERROR_TYPE_GENERAL);
 
-		// check if there is a Projektarbeitsbeurteilung - if yes, it is handled (possibly deleted) by external extension.
-		$beurteilungDeleteSuccess = true;
-
-		Events::trigger(
-			'projektarbeitsbeurteilung_delete',
-			$projektarbeit_id,
-			function ($value) use (&$beurteilungDeleteSuccess) {
-				$beurteilungDeleteSuccess = $value;
-			}
-		);
-
-		// if there is still a Beurteilung, Projektarbeit cannot be deleted - return with error
-		if (!$beurteilungDeleteSuccess) return $this->terminateWithError($this->p->t('projektarbeit', 'error_paarbeitHatBeurteilung'));
-
 		$result = $this->ProjektbetreuerModel->delete(
 			['projektarbeit_id' => $projektarbeit_id, 'person_id' => $person_id, 'betreuerart_kurzbz' => $betreuerart_kurzbz]
 		);
@@ -249,12 +185,9 @@ class Projektbetreuer extends FHCAPI_Controller
 			$this->outputJson($result);
 		}
 
-		return $this->terminateWithSuccess(getData($result));
+		return $this->terminateWithSuccess(current(getData($result)) ? : null);
 	}
 
-	/**
-	 * Get all active Betreuerarten.
-	 */
 	public function getBetreuerarten()
 	{
 		$result = $this->BetreuerartModel->loadWhere(['aktiv' => true]);
@@ -264,9 +197,6 @@ class Projektbetreuer extends FHCAPI_Controller
 		return $this->terminateWithSuccess(hasData($result) ? getData($result) : []);
 	}
 
-	/**
-	 * Get all Noten.
-	 */
 	public function getNoten()
 	{
 		$result = $this->NoteModel->load();
@@ -276,9 +206,6 @@ class Projektbetreuer extends FHCAPI_Controller
 		return $this->terminateWithSuccess(hasData($result) ? getData($result) : []);
 	}
 
-	/**
-	 * Get default Stundensätze for an employee in a semester.
-	 */
 	public function getDefaultStundensaetze()
 	{
 		$person_id = $this->input->get('person_id');
@@ -289,9 +216,6 @@ class Projektbetreuer extends FHCAPI_Controller
 		return $this->terminateWithSuccess($result);
 	}
 
-	/**
-	 * Get all Projektbetreuer by search string.
-	 */
 	public function getProjektbetreuerBySearchQuery()
 	{
 		$searchString = $this->input->get('searchString');
@@ -303,23 +227,9 @@ class Projektbetreuer extends FHCAPI_Controller
 
 		if (isError($result)) return $this->terminateWithError(getError($result), self::ERROR_TYPE_GENERAL);
 
-		if (!hasData($result)) $this->terminateWithSuccess([]);
-
-		$persons = $this->_addFullNameToBetreuer(getData($result));
-
-		// sort persons by type (employees first)
-		usort($persons, function ($a, $b) {
-			$statusRanks = ['Mitarbeiter' => 0, 'Person' => 1, 'Student' => 2];
-			return (isset($statusRanks[$a->status]) ? $statusRanks[$a->status] : count($statusRanks) + 1)
-				- (isset($statusRanks[$b->status]) ? $statusRanks[$b->status] : count($statusRanks) + 1);
-		});
-
-		return $this->terminateWithSuccess($persons);
+		return $this->terminateWithSuccess(hasData($result) ? $this->_addFullNameToBetreuer(getData($result)) : []);
 	}
 
-	/**
-	 * Get person info by Id.
-	 */
 	public function getPerson()
 	{
 		$person_id = $this->input->get('person_id');
@@ -345,7 +255,9 @@ class Projektbetreuer extends FHCAPI_Controller
 	}
 
 	/**
-	 * Validate list of Projektbetreuer.
+	 *
+	 * @param
+	 * @return object success or error
 	 */
 	public function validateProjektbetreuer()
 	{
@@ -365,9 +277,9 @@ class Projektbetreuer extends FHCAPI_Controller
 	}
 
 	/**
-	 * Validation funciton for checking Projektbetreuer input.
-	 * @param $formData Betreuer data
-	 * @return bool true when data is valid
+	 *
+	 * @param
+	 * @return object success or error
 	 */
 	private function _validate($formData)
 	{
@@ -394,32 +306,26 @@ class Projektbetreuer extends FHCAPI_Controller
 	}
 
 	/**
-	 * Check possibility of deletion of a Projektbetreuer.
-	 * @param projektarbeit_id
-	 * @param person_id
-	 * @param betreuerart_kurzbz
-	 * @return object success when delete possible, error otherwise
+	 *
+	 * @param
+	 * @return object success or error
 	 */
-	private function _validateDelete($projektarbeit_id, $person_id, $betreuerart_kurzbz)
+	private function _validateDelete($projektarbeit_id, $person_id)
 	{
-		// check if contract exists
 		$this->ProjektbetreuerModel->addSelect('vertrag_id');
-		$result = $this->ProjektbetreuerModel->loadWhere(
-			['projektarbeit_id' => $projektarbeit_id, 'person_id' => $person_id, 'betreuerart_kurzbz' => $betreuerart_kurzbz]
-		);
+		$result = $this->ProjektbetreuerModel->loadWhere(['projektarbeit_id' => $projektarbeit_id, 'person_id' => $person_id]);
 
 		if (isError($result)) return $result;
 
-		// if contract exists, no deletion is possible
 		if (hasData($result) && getData($result)[0]->vertrag_id != null) return error($this->p->t('projektarbeit', 'error_betreuerHatVertrag'));
 
 		return success();
 	}
 
 	/**
-	 * Add full name to array with Betreuer.
-	 * @param $betreuerArr
-	 * @return array including Betreuer with their full names
+	 *
+	 * @param
+	 * @return object success or error
 	 */
 	private function _addFullNameToBetreuer($betreuerArr)
 	{

application/controllers/api/frontend/v1/stv/Status.php

@@ -636,7 +636,7 @@ class Status extends FHCAPI_Controller
 
 		$this->load->library('PrestudentLib');
 
-		$resFirstStudent = $this->prestudentlib->setFirstStudent(
+		$this->prestudentlib->setFirstStudent(
 			$prestudent_id,
 			$lastAufgenommener->studiensemester_kurzbz,
 			$lastAufgenommener->ausbildungssemester,
@@ -645,8 +645,9 @@ class Status extends FHCAPI_Controller
 			$this->input->post('statusgrund_id')
 		);
 
-		$this->db->trans_complete();
-		$this->getDataOrTerminateWithError($resFirstStudent);
+		$this->getDataOrTerminateWithError($result);
+
+		$this->db->trans_commit();
 
 		return $this->outputJsonSuccess(true);
 	}
@@ -1077,24 +1078,6 @@ class Status extends FHCAPI_Controller
 		$this->terminateWithSuccess(true);
 	}
 
-	protected function checkForCriticalChangesBis($oldstatus)
-	{
-		$changedFields = array();
-		$allowedFields = array('anmerkung', 'statusgrund_id');
-		$oldstatus_array = get_object_vars($oldstatus);
-		foreach($oldstatus_array as $key => $oldValue)
-		{
-			$newValue = $this->input->post($key);
-			if( $newValue !== $oldValue )
-			{
-				$changedFields[] = $key;
-			}
-		}
-		$criticalFieldsChanged = array_diff($changedFields, $allowedFields);
-		$hasCriticalChangesBis = count($criticalFieldsChanged) > 0 ? true : false;
-		return $hasCriticalChangesBis;
-	}
-
 	/**
 	 * Updates a status entry
 	 *
@@ -1119,7 +1102,6 @@ class Status extends FHCAPI_Controller
 
 		$oldstatus = current($oldstatus);
 
-		$hasCriticalChangesBis = $this->checkForCriticalChangesBis($oldstatus);
 
 		$isBerechtigtNoStudstatusCheck =  $this->permissionlib->isBerechtigt('student/keine_studstatuspruefung');
 		$isBerechtigtBasisPrestudentstatus = $this->permissionlib->isBerechtigt('basis/prestudentstatus');
@@ -1130,6 +1112,7 @@ class Status extends FHCAPI_Controller
 		$ausbildungssemester = $this->input->post('ausbildungssemester') ?: $oldstatus->ausbildungssemester;
 		$datum = $this->input->post('datum') ?: $oldstatus->datum;
 
+
 		//Form Validation
 		$this->load->library('form_validation');
 
@@ -1152,15 +1135,9 @@ class Status extends FHCAPI_Controller
 			$this->p->t('global', 'datum'),
 			[
 				'is_valid_date',
-				['meldestichtag_not_exceeded', function ($value) use ($isBerechtigtNoStudstatusCheck, $hasCriticalChangesBis){
+				['meldestichtag_not_exceeded', function ($value) use ($isBerechtigtNoStudstatusCheck) {
 					if ($isBerechtigtNoStudstatusCheck)
-					{
-						return true; // Skip if access right says so*/
-					}
-					if (!$hasCriticalChangesBis) {
-						return true; // Skip if no critical changes were made
-					}
-
+						return true; // Skip if access right says so
 					if (!$value)
 						return true; // Error will be handled by the required statement above
 
@@ -1364,7 +1341,6 @@ class Status extends FHCAPI_Controller
 			'updateamum' => date('c'),
 			'updatevon' => $authUID
 		];
-		$nullableFields = ['statusgrund_id', 'anmerkung', 'rt_stufe'];
 		foreach ([
 					'orgform_kurzbz',
 					'anmerkung',
@@ -1373,17 +1349,8 @@ class Status extends FHCAPI_Controller
 					'rt_stufe',
 					'statusgrund_id'
 				] as $key)
-		{
-			if (in_array($key, $nullableFields))
-			{
-				$updateData[$key] = ($this->input->post($key) === '') ? null : $this->input->post($key);
-			}
-			else if ($this->input->post($key))
-			{
+			if ($this->input->post($key))
 				$updateData[$key] = $this->input->post($key);
-			}
-		}
-
 
 		if ($this->input->post('bestaetigtam')) {
 			$updateData['bestaetigtam'] = $this->input->post('bestaetigtam');

application/controllers/api/frontend/v1/stv/Student.php

@@ -37,7 +37,7 @@ class Student extends FHCAPI_Controller
 			'get' => ['admin:r', 'assistenz:r'],
 			'save' => ['admin:rw', 'assistenz:rw'],
 			'saveStudent' => ['admin:rw', 'assistenz:rw'],
-			'getPerson' => ['admin:rw', 'assistenz:rw'],
+			'check' => ['admin:rw', 'assistenz:rw'],
 			'add' => ['admin:rw', 'assistenz:rw'] // TODO(chris): extra permissions
 		]);
 
@@ -136,9 +136,14 @@ class Student extends FHCAPI_Controller
 			);
 		}
 		$this->PrestudentModel->addSelect(
-			"public.get_rolle_prestudent(public.tbl_prestudent.prestudent_id, "
-				. $this->PrestudentModel->escape($studiensemester_kurzbz)
-				. ")  AS statusofsemester"
+			"(
+				SELECT status_kurzbz
+				FROM public.tbl_prestudentstatus pss
+				WHERE pss.prestudent_id = public.tbl_prestudent.prestudent_id
+				  AND pss.studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
+				ORDER BY GREATEST(pss.datum, '0001-01-01') DESC
+				LIMIT 1
+				) AS statusofsemester"
 		);
 
 		$this->PrestudentModel->addJoin('public.tbl_student s', 'prestudent_id', 'LEFT');
@@ -154,9 +159,9 @@ class Student extends FHCAPI_Controller
 										'LEFT');*/
 
 		$result = $this->PrestudentModel->loadWhere(['tbl_prestudent.prestudent_id' => $prestudent_id]);
-
+		
 		$student = $this->getDataOrTerminateWithError($result);
-
+		
 		if (!$student)
 			return show_404();
 
@@ -216,7 +221,7 @@ class Student extends FHCAPI_Controller
 		]);
 
 		$this->load->library('UDFLib');
-
+		
 		$result = $this->udflib->getCiValidations($this->PersonModel, $this->input->post());
 
 		$udf_field_validations = $this->getDataOrTerminateWithError($result);
@@ -227,7 +232,7 @@ class Student extends FHCAPI_Controller
 			$this->terminateWithValidationErrors($this->form_validation->error_array());
 
 		$result = $this->StudentModel->loadWhere(['prestudent_id' => $prestudent_id]);
-
+		
 		$student = $this->getDataOrTerminateWithError($result);
 
 		$uid = $student ? current($student)->student_uid : null;
@@ -240,6 +245,7 @@ class Student extends FHCAPI_Controller
 
 		$person_id = $person ? current($person)->person_id : null;
 
+		
 		$array_allowed_props_lehrverband = ['verband', 'semester', 'gruppe'];
 		$update_lehrverband = array();
 		foreach ($array_allowed_props_lehrverband as $prop) {
@@ -299,7 +305,7 @@ class Student extends FHCAPI_Controller
 		}
 
 		$array_allowed_props_student = ['matrikelnr'];
-		if($this->isLaufendesSemester($studiensemester_kurzbz))
+		if($this->isLaufendesSemester($studiensemester_kurzbz)) 
 		{
 			$array_allowed_props_student = ['matrikelnr', 'verband', 'semester', 'gruppe'];
 		}
@@ -316,10 +322,6 @@ class Student extends FHCAPI_Controller
 		foreach ($array_allowed_props_benutzer as $prop) {
 			$val = $this->input->post($prop);
 			if ($val !== null) {
-				if($prop === 'alias' && $val === '')
-				{
-					$val = null;
-				}
 				$update_benutzer[$prop] = $val;
 			}
 		}
@@ -460,7 +462,7 @@ class Student extends FHCAPI_Controller
 		return $this->save($student->prestudent_id, $studiensemester_kurzbz);
 	}
 
-	public function getPerson()
+	public function check()
 	{
 		$this->load->library('form_validation');
 
@@ -478,55 +480,21 @@ class Student extends FHCAPI_Controller
 
 		$this->load->model('person/Person_model', 'PersonModel');
 
-		$this->PersonModel->addSelect(
-			'person_id, vorname, nachname, vornamen, wahlname, gebdatum, staatsbuergerschaft, geburtsnation, sprache, anrede,
-			titelpost, titelpre, gebort, gebzeit, homepage, geschlecht, matr_nr,
-			aktiv, unruly, tbl_geschlecht.bezeichnung_mehrsprachig AS geschlecht_bezeichnung'
-		);
-		$this->PersonModel->addJoin('public.tbl_geschlecht', 'geschlecht');
-
 		if ($gebdatum)
 			$this->PersonModel->db->where('gebdatum', (new DateTime($gebdatum))->format('Y-m-d'));
 		if ($vorname && $nachname) {
 			$this->PersonModel->db->or_group_start();
-			$this->PersonModel->db->where('LOWER(nachname)', 'LOWER(' . $this->PersonModel->db->escape(trim($nachname)) . ')', false);
-			$this->PersonModel->db->where('LOWER(vorname)', 'LOWER(' . $this->PersonModel->db->escape(trim($vorname)) . ')', false);
+			$this->PersonModel->db->where('LOWER(nachname)', 'LOWER(' . $this->PersonModel->db->escape($nachname) . ')', false);
+			$this->PersonModel->db->where('LOWER(vorname)', 'LOWER(' . $this->PersonModel->db->escape($vorname) . ')', false);
 			$this->PersonModel->db->group_end();
 		} elseif ($nachname) {
-			$this->PersonModel->db->or_where('LOWER(nachname)', 'LOWER(' . $this->PersonModel->escape(trim($nachname)) . ')', false);
+			$this->PersonModel->db->or_where('LOWER(nachname)', 'LOWER(' . $this->PersonModel->escape($nachname) . ')', false);
 		}
 
 		$result = $this->PersonModel->load();
 
 		$data = $this->getDataOrTerminateWithError($result);
 
-		$this->load->model('person/Adresse_model', 'AdresseModel');
-		$this->load->model('crm/Prestudentstatus_model', 'PrestudentstatusModel');
-
-		foreach ($data as $person)
-		{
-			// get adresses
-			$langIdx = $this->_getLanguageIndex() - 1;
-			$person->geschlecht_bezeichnung = isset($person->geschlecht_bezeichnung[$langIdx]) ? $person->geschlecht_bezeichnung[$langIdx] : '';
-
-			// get Adresse
-			$this->AdresseModel->addOrder('heimatadresse', 'DESC');
-			$this->AdresseModel->addOrder('zustelladresse', 'DESC');
-			$this->AdresseModel->addOrder('adresse_id', 'DESC');
-			$result = $this->AdresseModel->loadWhere(['person_id' => $person->person_id]);
-
-			$adressen = $this->getDataOrTerminateWithError($result);
-
-			$person->adressen = $adressen;
-
-			// get status
-			$result = $this->PrestudentstatusModel->getLastStatusPerson($person->person_id);
-
-			$status = $this->getDataOrTerminateWithError($result);
-
-			$person->status = $status;
-		}
-
 		$this->terminateWithSuccess($data);
 	}
 
@@ -540,52 +508,71 @@ class Student extends FHCAPI_Controller
 			$_POST['ausbildungssemester'] = 0;
 		}
 
-		$this->_validate();
+		$this->load->library('form_validation');
 
-		$this->load->model('crm/Student_model', 'StudentModel');
+		$this->form_validation->set_rules('nachname', 'Nachname', 'callback_requiredIfNotPersonId', [
+			'requiredIfNotPersonId' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'nachname')])
+		]);
+		$this->form_validation->set_rules('geschlecht', 'Geschlecht', 'callback_requiredIfNotPersonId', [
+			'requiredIfNotPersonId' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'geschlecht')])
+		]);
+		$this->form_validation->set_rules('gebdatum', 'Geburtsdatum', ['isValidDate', function($value) { return isValidDate($value); }], [
+			'isValidDate' => $this->p->t('ui', 'error_invalid_date')
+		]);
+		$this->form_validation->set_rules('address[func]', 'Address', 'required|integer|less_than[2]|greater_than[-2]');
+		$this->form_validation->set_rules('address[plz]', 'PLZ', 'callback_requiredIfAddressFunc', [
+			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'plz')])
+		]);
+		$this->form_validation->set_rules('address[gemeinde]', 'Gemeinde', 'callback_requiredIfAddressFunc', [
+			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'gemeinde')])
+		]);
+		$this->form_validation->set_rules('address[ort]', 'Ort', 'callback_requiredIfAddressFunc', [
+			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'ort')])
+		]);
+		$this->form_validation->set_rules('address[address]', 'Adresse', 'callback_requiredIfAddressFunc', [
+			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'adresse')])
+		]);
+		$this->form_validation->set_rules('email', 'E-Mail', 'valid_email');
+		$this->form_validation->set_rules('studiengang_kz', 'Studiengang', 'callback_requiredIfStudentFunc', [
+			'requiredIfStudentFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'studiengang')])
+		]);
+		$this->form_validation->set_rules('studiensemester_kurzbz', 'Studiensemester', 'callback_requiredIfStudentFunc', [
+			'requiredIfStudentFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'studiensemester')])
+		]);
+		$this->form_validation->set_rules('ausbildungssemester', 'Ausbildungssemester', 'callback_requiredIfStudentFunc|integer|less_than[9]|greater_than[-1]', [
+			'requiredIfStudentFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'ausbildungssemester')])
+		]);
+		// TODO(chris): validate studienplan with studiengang, semester and orgform?
+		// TODO(chris): validate person_id, studiengang_kz, studiensemester_kurzbz, orgform_kurzbz, nation, gemeinde, ort, geschlecht?
+
+		if (!$this->form_validation->run())
+			$this->terminateWithValidationErrors($this->form_validation->error_array());
+
+		// TODO(chris): This should be in a library
 		$this->load->model('crm/Prestudent_model', 'PrestudentModel');
 		$this->load->model('crm/Prestudentstatus_model', 'PrestudentstatusModel');
-		$this->load->model('organisation/Lehrverband_model', 'LehrverbandModel');
-		$this->load->model('education/Studentlehrverband_model', 'StudentlehrverbandModel');
 
-		$this->load->library('PrestudentLib');
+		$this->db->trans_start();
 
-		$errors = [];
-		$person_id = null;
+		$result = $this->addInteressent();
 
-		$this->db->trans_begin();
+		$this->db->trans_complete();
 
-		$result = $this->_addPerson();
-		if (isError($result)) $errors[] = getError($result);
+		if ($this->db->trans_status() === FALSE)
+			$this->terminateWithError('TODO(chris): TEXT', self::ERROR_TYPE_GENERAL);
 
-		if (hasData($result))
-		{
-			$person_id = getData($result);
-			$result = $this->_addAdresse($person_id);
-			if (isError($result)) $errors[] = getError($result);
-			$result = $this->_addKontakt($person_id);
-			if (isError($result)) $errors[] = getError($result);
-			if (!$this->input->post('personOnly')) $result = $this->_addFirstPrestudentstatus($person_id);
-			if (isError($result)) $errors[] = getError($result);
-		}
+		$data = $this->getDataOrTerminateWithError($result);
 
-		if ($this->db->trans_status() === FALSE || !isEmptyArray($errors))
-		{
-			$this->db->trans_rollback();
-			$this->terminateWithError(isEmptyArray($errors) ? $this->p->t('stv', 'error_add_student') : $errors);
-		}
-		$this->db->trans_commit();
-
-		$this->terminateWithSuccess($person_id);
+		$this->terminateWithSuccess($data);
 	}
 
-	private function _addPerson()
+	protected function addInteressent()
 	{
 		// Person anlegen wenn nötig
 		$person_id = $this->input->post('person_id');
 		if (!$person_id) {
 			$this->load->model('person/Person_model', 'PersonModel');
-
+			
 			$data = [
 				'nachname' => $this->input->post('nachname'),
 				'insertamum' => date('c'),
@@ -608,25 +595,19 @@ class Student extends FHCAPI_Controller
 			if ($this->input->post('geschlecht'))
 				$data['geschlecht'] = $this->input->post('geschlecht');
 			if ($this->input->post('gebdatum'))
-				$data['gebdatum'] = (new DateTime($this->input->post('gebdatum')))->format('Y-m-d');
+				$data['gebdatum'] = (new DateTime($this->input->post('datum_obj')))->format('Y-m-d');
 			if ($this->input->post('geburtsnation'))
 				$data['geburtsnation'] = $this->input->post('geburtsnation');
 			if ($this->input->post('staatsbuergerschaft'))
 				$data['staatsbuergerschaft'] = $this->input->post('staatsbuergerschaft');
 
-			return $this->PersonModel->insert($data);
+			$result = $this->PersonModel->insert($data);
+			$person_id = $this->getDataOrTerminateWithError($result);
 		}
 
-		return success($person_id);
-	}
-
-	private function _addAdresse($person_id)
-	{
-		// Addresse anlegen?
-		$anlegen = $this->input->post('address[checked]');
-		if ($anlegen === true)
-		{
-			// Adresse laden
+		// Addresse anlegen
+		$anlegen = $this->input->post('address[func]');
+		if ($anlegen) {
 			$this->load->model('person/Adresse_model', 'AdresseModel');
 
 			$data = [
@@ -638,45 +619,52 @@ class Student extends FHCAPI_Controller
 				'typ' => 'h',
 				'zustelladresse' => true,
 			];
-
+			if ($anlegen < 0) { // Überschreiben
 				$this->AdresseModel->addSelect('adresse_id');
+				$this->AdresseModel->addJoin('public.tbl_adressentyp', 'typ = adressentyp_kurzbz');
+				$this->AdresseModel->addOrder('zustelladresse', 'DESC');
+				$this->AdresseModel->addOrder('sort');
 				$result = $this->AdresseModel->loadWhere([
 					'person_id' => $person_id
 				]);
+				$address = $this->getDataOrTerminateWithError($result);
+				if ($address) {
+					$address = current($address);
 
-				if (isError($result)) return $result;
-
-				// wenn neue Adresse, heimatadresse setzen
-				if (!hasData($result)) $data['heimatadresse'] = true;
+					$data['updateamum'] = date('c');
+					$data['updatevon'] = getAuthUID();
 
+					$result = $this->AdresseModel->update($address->adresse_id, $data);
+					$this->getDataOrTerminateWithError($result);
+				} else {
+					//Wenn keine Adrese vorhanden ist dann eine neue Anlegen
+					$anlegen = 1;
+					$data['heimatadresse'] = true;
+				}
+			}
+			if ($anlegen > 0) {
 				$data['person_id'] = $person_id;
 				$data['insertamum'] = date('c');
 				$data['insertvon'] = getAuthUID();
-
-				return $this->AdresseModel->insert($data);
+				if (!isset($data['heimatadresse']))
+					$data['heimatadresse'] = !$this->input->post('person_id');
+				
+				$result = $this->AdresseModel->insert($data);
+				$this->getDataOrTerminateWithError($result);
+			}
 		}
-
-		return success(null);
-	}
-
-	private function _addKontakt($person_id)
-	{
+		
 		// Kontaktdaten
 		$kontaktdaten = [];
-
-		foreach (['email', 'telefon', 'mobil'] as $k)
-		{
+		foreach (['email', 'telefon', 'mobil'] as $k) {
 			$v = $this->input->post($k);
 			if ($v)
 				$kontaktdaten[$k] = $v;
 		}
-
-		if (count($kontaktdaten))
-		{
+		if (count($kontaktdaten)) {
 			$this->load->model('person/Kontakt_model', 'KontaktModel');
 
-			foreach ($kontaktdaten as $typ => $kontakt)
-			{
+			foreach ($kontaktdaten as $typ => $kontakt) {
 				$data = [
 					'person_id' => $person_id,
 					'kontakttyp' => $typ,
@@ -686,70 +674,87 @@ class Student extends FHCAPI_Controller
 					'insertvon' => getAuthUID()
 				];
 				$result = $this->KontaktModel->insert($data);
-				if (isError($result)) return $result;
+				$this->getDataOrTerminateWithError($result);
 			}
 		}
-		return success(null);
-	}
 
-	private function _addFirstPrestudentstatus($person_id)
-	{
-		// Prestudent anlegen
+		$personOnly = $anlegen = $this->input->post('personOnly');
 
-		// Anmerkung with Ausbildungsart
-		$studiengang_kz = $this->input->post('studiengang_kz');
-		$studiensemester_kurzbz = $this->input->post('studiensemester_kurzbz');
-		$ausbildungsart = $this->input->post('ausbildungsart');
-		$anmerkung = $this->input->post('anmerkungen');
-		$foerderrelevant = null;
-		if ($ausbildungsart)
-			$anmerkung .= ' Ausbildungsart:' . $ausbildungsart;
-
-		// Incomings und ausserordentliche sind bei Meldung nicht förderrelevant
-		$incoming = $this->input->post('incoming');
-		if ($incoming || substr($studiengang_kz, 0, 1) == '9')
-			$foerderrelevant = false;
-
-		// Prestudent speichern
-		$result = $this->prestudentlib->setPrestudent(
-			$person_id,
-			$studiengang_kz,
-			$this->input->post('letzteausbildung'),
-			$anmerkung,
-			$foerderrelevant
-		);
-		if (isError($result)) return $result;
-		if (!hasData($result)) return error('Error when adding prestudent');
-
-		$prestudent_id = getData($result);
-
-		// wenn Incoming, Incoming Daten hinzufügen
-		if ($incoming)
-		{
-			$statusResult = $this->prestudentlib->setFirstIncoming(
-				$prestudent_id,
-				$studiengang_kz,
-				$studiensemester_kurzbz,
-				$this->input->post('orgform_kurzbz'),
-				$this->input->post('studienplan_id')
-			);
-		}
-		else
+		if (!$personOnly)
 		{
+			// Prestudent anlegen
+			$data = [
+				'aufmerksamdurch_kurzbz' => 'k.A.',
+				'person_id' => $person_id,
+				'studiengang_kz' => $this->input->post('studiengang_kz'),
+				'ausbildungcode' => $this->input->post('letzteausbildung'),
+				'anmerkung' => $this->input->post('anmerkungen'),
+				'reihungstestangetreten' => false,
+				'bismelden' => true
+			];
+			$ausbildungsart = $this->input->post('ausbildungsart');
+			if ($ausbildungsart)
+				$data['anmerkung'] .= ' Ausbildungsart:' . $ausbildungsart;
+			// Incomings und ausserordentliche sind bei Meldung nicht förderrelevant
+			$incoming = $this->input->post('incoming');
+			if ($incoming || substr($data['studiengang_kz'], 0, 1) == '9')
+				$data['foerderrelevant'] = false;
+			// Wenn die Person schon im System erfasst ist, dann die ZGV des Datensatzes uebernehmen
+			$this->PrestudentModel->addOrder('zgvmas_code');
+			$this->PrestudentModel->addOrder('zgv_code', 'DESC');
+			$this->PrestudentModel->addLimit(1);
+			$result = $this->PrestudentModel->loadWhere([
+				'person_id' => $person_id
+			]);
+			$prestudent = $this->getDataOrTerminateWithError($result);
+			if ($prestudent) {
+				$prestudent = current($prestudent);
+				if ($prestudent->zgv_code) {
+					$data['zgv_code'] = $prestudent->zgv_code;
+					$data['zgvort'] = $prestudent->zgvort;
+					$data['zgvdatum'] = $prestudent->zgvdatum;
+
+					$data['zgvmas_code'] = $prestudent->zgvmas_code;
+					$data['zgvmaort'] = $prestudent->zgvmaort;
+					$data['zgvmadatum'] = $prestudent->zgvmadatum;
+				}
+			}
+			// Prestudent speichern
+			$result = $this->PrestudentModel->insert($data);
+			$prestudent_id = $this->getDataOrTerminateWithError($result);
+
 			// Prestudent Rolle Anlegen
-			$statusResult = $this->prestudentlib->setFirstStatus(
-				$prestudent_id,
-				$this->PrestudentstatusModel::STATUS_INTERESSENT,
-				$studiensemester_kurzbz,
-				$this->input->post('ausbildungssemester'),
-				$this->input->post('orgform_kurzbz'),
-				$this->input->post('studienplan_id')
-			);
-		}
-		if (!hasData($statusResult)) return error('error when adding status');
-		if (isError($statusResult)) return $statusResult;
+			$data = [
+				'prestudent_id' => $prestudent_id,
+				'status_kurzbz' => $incoming ? 'Incoming' : 'Interessent',
+				'studiensemester_kurzbz' => $this->input->post('studiensemester_kurzbz'),
+				'ausbildungssemester' => $this->input->post('ausbildungssemester') ?: 0,
+				'orgform_kurzbz' => $this->input->post('orgform_kurzbz') ?: null,
+				'studienplan_id' => $this->input->post('studienplan_id') ?: null,
+				'datum' => date('Y-m-d'),
+				'insertamum' => date('c'),
+				'insertvon' => getAuthUID()
+			];
+			$result = $this->PrestudentstatusModel->insert($data);
+			$this->getDataOrTerminateWithError($result);
 
-		return success($prestudent_id);
+			if ($incoming) {
+				// TODO(chris): IMPLEMENT!
+				//Matrikelnummer und UID generieren
+				//Benutzerdatensatz anlegen
+				//Studentendatensatz anlegen
+				//StudentLehrverband anlegen
+			}
+		}
+		// TODO(chris): DEBUG
+		/*$result = $this->PrestudentModel->loadWhere([
+			'pestudent_id' => 1
+		]);
+		if (isError($result)) {
+			return $result;
+		}*/
+
+		return success($person_id);
 	}
 
 	public function requiredIfNotPersonId($value)
@@ -761,84 +766,20 @@ class Student extends FHCAPI_Controller
 	
 	public function requiredIfAddressFunc($value)
 	{
-		if (!isset($_POST['address']['checked']) || !$_POST['address']['checked'])
+		if (!$_POST['address']['func'] || $_POST['address']['func'] == 0)
 			return true;
 		return !!$value;
 	}
 
 	public function requiredIfStudentFunc($value)
 	{
-		if (isset($_POST['personOnly']) && $_POST['personOnly'])
+		if ($_POST['personOnly'])
 			return true;
 		return !!$value;
 	}
 
-	public function requiredIfStudentAndNotIncomingFunc($value)
+	public function isValidDate($value)
 	{
-		if ((isset($_POST['incoming']) && $_POST['incoming']) || $this->requiredIfStudentFunc($value))
-			return true;
-		return !!$value;
-	}
-
-	/**
-	 * Validates input data. Terminates with validation errors, if invalid.
-	 */
-	private function _validate()
-	{
-		$this->load->library('form_validation');
-
-		$this->form_validation->set_rules('nachname', 'Nachname', 'callback_requiredIfNotPersonId', [
-			'requiredIfNotPersonId' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'nachname')])
-		]);
-		$this->form_validation->set_rules('geschlecht', 'Geschlecht', 'callback_requiredIfNotPersonId', [
-			'requiredIfNotPersonId' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'geschlecht')])
-		]);
-		$this->form_validation->set_rules('gebdatum', 'Geburtsdatum', ['isValidDate', function($value) { return isValidDate($value); }], [
-			'isValidDate' => $this->p->t('ui', 'error_invalid_date')
-		]);
-		//$this->form_validation->set_rules('address[checked]', 'Address', 'required');
-		$this->form_validation->set_rules('address[plz]', 'PLZ', 'callback_requiredIfAddressFunc', [
-			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'plz')])
-		]);
-		$this->form_validation->set_rules('address[gemeinde]', 'Gemeinde', 'callback_requiredIfAddressFunc', [
-			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'gemeinde')])
-		]);
-		$this->form_validation->set_rules('address[ort]', 'Ort', 'callback_requiredIfAddressFunc', [
-			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'ort')])
-		]);
-		$this->form_validation->set_rules('address[address]', 'Adresse', 'callback_requiredIfAddressFunc', [
-			'requiredIfAddressFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('person', 'adresse')])
-		]);
-		$this->form_validation->set_rules('email', 'E-Mail', 'valid_email');
-		$this->form_validation->set_rules('studiengang_kz', 'Studiengang', 'callback_requiredIfStudentFunc', [
-			'requiredIfStudentFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'studiengang')])
-		]);
-		$this->form_validation->set_rules('studiensemester_kurzbz', 'Studiensemester', 'callback_requiredIfStudentFunc', [
-			'requiredIfStudentFunc' => $this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'studiensemester')])
-		]);
-		$this->form_validation->set_rules(
-			'ausbildungssemester',
-			'Ausbildungssemester',
-			'callback_requiredIfStudentAndNotIncomingFunc|integer|less_than[9]|greater_than[-1]',
-			[
-				'requiredIfStudentAndNotIncomingFunc' =>
-					$this->p->t('ui', 'error_fieldRequired', ['field' => $this->p->t('lehre', 'ausbildungssemester')]),
-			]
-		);
-		// TODO(chris): validate studienplan with studiengang, semester and orgform?
-		// TODO(chris): validate person_id, studiengang_kz, studiensemester_kurzbz, orgform_kurzbz, nation, gemeinde, ort, geschlecht?
-
-		if (!$this->form_validation->run())
-			$this->terminateWithValidationErrors($this->form_validation->error_array());
-	}
-
-	private function _getLanguageIndex()
-	{
-		$this->load->model('system/Sprache_model', 'SpracheModel');
-		$this->SpracheModel->addSelect('index');
-		$result = $this->SpracheModel->loadWhere(array('sprache' => getUserLanguage()));
-		$this->addMeta('lang', getUserLanguage());
-
-		return hasData($result) ? getData($result)[0]->index : 1;
+		return isValidDate($value);
 	}
 }

application/controllers/api/frontend/v1/stv/Students.php

@@ -801,9 +801,14 @@ class Students extends FHCAPI_Controller
 
 		//add status per semester
 		$this->PrestudentModel->addSelect(
-			"public.get_rolle_prestudent(public.tbl_prestudent.prestudent_id, "
-				. $this->PrestudentModel->escape($studiensemester_kurzbz)
-				. ")  AS statusofsemester"
+			"(
+				SELECT status_kurzbz
+				FROM public.tbl_prestudentstatus pss
+				WHERE pss.prestudent_id = public.tbl_prestudent.prestudent_id
+				  AND pss.studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
+				ORDER BY GREATEST(pss.datum, '0001-01-01') DESC
+				LIMIT 1
+				) AS statusofsemester"
 		);
 
 		$this->addSelectPrioRel();
@@ -892,9 +897,14 @@ class Students extends FHCAPI_Controller
 
 		//add status per semester
 		$this->PrestudentModel->addSelect(
-			"public.get_rolle_prestudent(public.tbl_prestudent.prestudent_id, "
-				. $this->PrestudentModel->escape($studiensemester_kurzbz)
-				. ")  AS statusofsemester"
+			"(
+				SELECT status_kurzbz
+				FROM public.tbl_prestudentstatus pss
+				WHERE pss.prestudent_id = public.tbl_prestudent.prestudent_id
+				  AND pss.studiensemester_kurzbz = " . $this->PrestudentModel->escape($studiensemester_kurzbz) . "
+				ORDER BY GREATEST(pss.datum, '0001-01-01') DESC
+				LIMIT 1
+				) AS statusofsemester"
 		);
 
 		$this->PrestudentModel->addSelect('UPPER(stg.typ || stg.kurzbz) AS studiengang');

application/controllers/api/frontend/v1/stv/Verband.php

@@ -215,7 +215,6 @@ class Verband extends FHCAPI_Controller
 					$this->StudienordnungModel->addDistinct();
 					$this->StudienordnungModel->addSelect("CONCAT(studiengang_kz, '/', p.orgform_kurzbz) AS link");
 					$this->StudienordnungModel->addSelect("p.orgform_kurzbz AS name");
-					$this->StudienordnungModel->addSelect("studiengang_kz AS stg_kz");
 
 					$this->StudienordnungModel->addJoin('lehre.tbl_studienplan p', 'studienordnung_id');
 

application/controllers/api/frontend/v1/stv/Vertrag.php

@@ -76,7 +76,9 @@ class Vertrag extends FHCAPI_Controller
 
 		if (isError($allOe)) $this->terminateWithError(getError($allOe), self::ERROR_TYPE_GENERAL);
 
-		$allOe = hasData($allOe) ? array_column(getData($allOe), 'oe_kurzbz') : [];
+		$allOe = hasData($allOe) ? getData($allOe) : [];
+
+		$this->addMeta('oe', $allOe);
 
 		// * then check if the user has permissions to cancel the corresponding lv-organisational units
 		if (!$this->permissionlib->isBerechtigtMultipleOe('admin', $allOe, 'suid') &&

application/controllers/dashboard/Widget.php

@@ -33,26 +33,19 @@ class Widget extends Auth_Controller
 			return $this->outputJsonSuccess([
 				"widget_id" => 0,
 				"widget_kurzbz" => "notfound",
-				"arguments" => [
+				"arguments" => json_encode([
 					"className" => 'alert-danger',
 					"title" => 'Widget Not Found',
 					"msg" => 'The widget with the id ' . $widget_id . ' could not be found'
-				],
-				"setup" => [
+				]),
+				"setup" => json_encode([
 					"name" => 'Widget Not Found',
-					"file" => absoluteJsImportUrl('public/js/components/DashboardWidget/Default.js'),
+					"file" => 'DashboardWidget/Default.js',
 					"width" => 1,
 					"height" => 1
-				]
+				])
 			]);
-
-		$widget = current(getData($widget));
-		$widget->arguments = json_decode($widget->arguments);
-		$tmpsetup = json_decode($widget->setup);
-		$tmpsetup->file = absoluteJsImportUrl($tmpsetup->file);
-		$widget->setup = $tmpsetup;
-
-		return $this->outputJsonSuccess($widget);
+		return $this->outputJsonSuccess(current(getData($widget)));
 	}
 	
 	public function getAll()
@@ -63,16 +56,7 @@ class Widget extends Auth_Controller
 		if (isError($result))
 			return $this->outputJsonError(getError($result));
 
-		$tmpwidgets = getData($result) ?: [];
-		$widgets = array_map(function($widget) {
-			$widget->arguments = json_decode($widget->arguments);
-			$tmpsetup = json_decode($widget->setup);
-			$tmpsetup->file = absoluteJsImportUrl($tmpsetup->file);
-			$widget->setup = $tmpsetup;
-			return $widget;
-		}, $tmpwidgets);
-
-		$this->outputJsonSuccess($widgets);
+		$this->outputJsonSuccess(getData($result) ?: []);
 	}
 	
 	public function getWidgetsForDashboard()
@@ -87,16 +71,7 @@ class Widget extends Auth_Controller
 			]);
 		}
 
-		$tmpwidgets = getData($result) ?: [];
-		$widgets = array_map(function($widget) {
-			$widget->arguments = json_decode($widget->arguments);
-			$tmpsetup = json_decode($widget->setup);
-			$tmpsetup->file = absoluteJsImportUrl($tmpsetup->file);
-			$widget->setup = $tmpsetup;
-			return $widget;
-		}, $tmpwidgets);
-
-		$this->outputJsonSuccess($widgets);
+		$this->outputJsonSuccess(getData($result) ?: []);
 	}
 	
 	public function setAllowed()

application/controllers/jobs/AbgabetoolJob.php

@@ -1,621 +0,0 @@
-<?php
-
-if (!defined('BASEPATH')) exit('No direct script access allowed');
-
-class AbgabetoolJob extends JOB_Controller
-{
-
-	/**
-	 * Constructor
-	 */
-	public function __construct()
-	{
-		parent::__construct();
-
-		$this->_ci =& get_instance();
-
-		$this->_ci->load->helper('hlp_sancho_helper');
-
-		$this->_ci->load->model('education/Projektarbeit_model', 'ProjektarbeitModel');
-		$this->_ci->load->model('education/Projektbetreuer_model', 'ProjektbetreuerModel');
-		$this->_ci->load->model('education/Paabgabe_model', 'PaabgabeModel');
-		$this->_ci->load->model('crm/Student_model', 'StudentModel');
-		$this->_ci->load->model('organisation/Studiengang_model', 'StudiengangModel');
-		$this->_ci->load->model('organisation/Organisationseinheit_model', 'OrganisationseinheitModel');
-
-		$this->_ci->load->config('abgabe');
-		$this->loadPhrases([
-			'abgabetool'
-		]);
-	}
-
-	public function notifyAssistenzAboutChangedAbgaben() {
-
-		$this->_ci->logInfo('Start job FHC-Core->notifyAssistenzAboutChangedAbgaben');
-
-		$interval = $this->_ci->config->item('PAABGABE_EMAIL_JOB_INTERVAL');
-		$relevantTypes = $this->_ci->config->item('RELEVANT_PAABGABETYPEN_SAMMELMAIL_ASSISTENZ');
-		// get all new or changed termine in interval
-		$result = $this->_ci->PaabgabeModel->findAbgabenNewOrUpdatedSince($interval, $relevantTypes);
-		
-		$retval = getData($result);
-
-		if(count($retval) == 0) {
-			$this->_ci->logInfo("Keine Emails an Assistenzen über neue oder veränderte Termine versandt");
-			return;
-		}
-
-		// group changed/new abgaben for projektarbeiten
-		$projektarbeiten = [];
-		foreach($retval as $newOrChangedAbgabe) {
-			// Check if the current item has a 'projektarbeit_id' field.
-			// Replace 'projektarbeit_id' with the actual key name if it's different.
-			if (isset($newOrChangedAbgabe->projektarbeit_id)) {
-				$projektarbeitId = $newOrChangedAbgabe->projektarbeit_id;
-
-				// If the 'projektarbeit_id' is not yet a key in $projektarbeiten, 
-				// initialize it as an empty array.
-				if (!isset($projektarbeiten[$projektarbeitId])) {
-					$projektarbeiten[$projektarbeitId] = [];
-				}
-
-				// Add the current row to the array associated with its 'projektarbeit_id'.
-				$projektarbeiten[$projektarbeitId][] = $newOrChangedAbgabe;
-			}
-		}
-
-		// for each projektarbeit fetch their assistenz and same them in their own dictionary to avoid too many mails
-		$assistenzMap = [];
-		// for each projektarbeit fetch their betreuer and save them in their own dictionary to avoid too many mails
-		$projektarbeitBetreuerMap = [];
-		forEach($projektarbeiten as $projektarbeit_id => $abgaben) {
-			
-			$assistenzResult = $this->_ci->OrganisationseinheitModel->getAssistenzForOE($abgaben[0]->stg_oe_kurzbz);
-
-			forEach($assistenzResult->retval as $assistenzRow) {
-				if (!isset($assistenzMap[$assistenzRow->person_id])) {
-					$assistenzMap[$assistenzRow->person_id] = [];
-				}
-
-				// Add the current $assistenzRow to the $assistenzMap as an array associated with its projektarbeit_id.
-				$assistenzMap[$assistenzRow->person_id][] = [$projektarbeit_id, $assistenzRow];
-			}
-
-			$betreuerResult = $this->_ci->ProjektbetreuerModel->getAllBetreuerOfProjektarbeit($projektarbeit_id);
-
-			forEach($betreuerResult->retval as $betreuerRow) {
-				if (!isset($projektarbeitBetreuerMap[$projektarbeit_id])) {
-					$projektarbeitBetreuerMap[$projektarbeit_id] = [];
-				}
-
-				// Add the current betreuerRow to the betreuerMap as an array associated with its projektarbeit_id.
-				$projektarbeitBetreuerMap[$projektarbeit_id][] = $betreuerRow;
-			}
-		}
-
-		$count = 0;
-		foreach($assistenzMap as $assistenz_person_id => $tupelArr) {
-
-			$abgabenString = '<div style="font-family: Arial, sans-serif; color: #333;">';
-
-			foreach($tupelArr as $tupel) {
-				$projektarbeit_id = $tupel[0];
-				$assistenzRow = $tupel[1];
-
-				$betreuerArray = $projektarbeitBetreuerMap[$projektarbeit_id] ?? [];
-				$changedAbgaben = $projektarbeiten[$projektarbeit_id];
-
-				$relevantAbgaben = array_values(array_filter($changedAbgaben, function($abgabetermin) use ($assistenzRow) {
-					if($abgabetermin->updatevon == null && $abgabetermin->insertvon != $assistenzRow->uid) {
-						return $abgabetermin;
-					} else if($abgabetermin->updatevon != null && $abgabetermin->updatevon != $assistenzRow->uid) {
-						return $abgabetermin;
-					}
-				}));
-
-				if(count($relevantAbgaben) == 0) {
-					continue;
-				}
-
-				// Format the Student Name
-				$s = $relevantAbgaben[0];
-				$nameParts = [];
-				if (!empty($s->titelpre)) $nameParts[] = $s->titelpre;
-				$nameParts[] = $s->vorname;
-				$nameParts[] = $s->nachname;
-				if (!empty($s->titelpost)) $nameParts[] = $s->titelpost;
-				$studentFullName = implode(' ', $nameParts);
-
-				// Format the Supervisors string
-				$betreuerStrings = [];
-				foreach($betreuerArray as $b) {
-					$bNameParts = [];
-					if (!empty($b->titelpre)) $bNameParts[] = $b->titelpre;
-					$bNameParts[] = $b->vorname;
-					$bNameParts[] = $b->nachname;
-					if (!empty($b->titelpost)) $bNameParts[] = $b->titelpost;
-
-					$bFullName = implode(' ', $bNameParts);
-					$betreuerStrings[] = "{$bFullName} ({$b->betreuerart_kurzbz})";
-				}
-				$allBetreuerFormatted = implode(', ', $betreuerStrings);
-
-				$projektarbeit_titel = $s->titel ?? 'Kein Titel vergeben';
-
-				// Project Header Section
-				$abgabenString .= "
-				<div style='margin-top: 25px; padding: 12px; background-color: #f8f9fa; border-left: 4px solid #007bff; border-bottom: 1px solid #eee;'>
-					<strong style='font-size: 16px; color: #0056b3;'>Projekt: {$projektarbeit_titel}</strong><br/>
-					<div style='margin-top: 5px; font-size: 14px;'>
-						<strong>Studierende/r:</strong> {$studentFullName}
-					</div>
-					<div style='margin-top: 3px; font-size: 14px;'>
-						<strong>Betreuer:</strong> {$allBetreuerFormatted}
-					</div>
-					<span style='color: #666; font-size: 12px;'>
-						ID: {$projektarbeit_id} | Stg: {$s->stgtyp}{$s->stgkz} ({$s->studiensemester_kurzbz})
-					</span>
-				</div>";
-
-				// Start Table
-				$abgabenString .= '
-				<table style="width: 100%; border-collapse: collapse; margin-bottom: 25px;">
-					<thead>
-						<tr style="background-color: #eee; text-align: left;">
-							<th style="padding: 10px; border: 1px solid #ddd; font-size: 13px; width: 20%;">Zieldatum</th>
-							<th style="padding: 10px; border: 1px solid #ddd; font-size: 13px;">Bezeichnung</th>
-						</tr>
-					</thead>
-					<tbody>';
-
-				foreach ($relevantAbgaben as $abgabe) {
-					$dateEmailFormatted = (new DateTime($abgabe->datum))->format('d.m.Y');
-					$abgabedatumFormatted = (new DateTime($abgabe->abgabedatum))->format('d.m.Y');
-					$kurzbzLine = !empty($abgabe->kurzbz) ? "<br/><small style='color: #777; font-style: italic;'>{$abgabe->kurzbz}</small>" : "";
-
-					$abgabenString .= "
-					<tr>
-						<td style='padding: 10px; border: 1px solid #ddd; font-size: 13px; vertical-align: top;'>{$dateEmailFormatted}</td>
-						<td style='padding: 10px; border: 1px solid #ddd; font-size: 13px;'>
-							<strong>{$abgabe->bezeichnung}</strong>{$kurzbzLine}
-						</td>
-					</tr>";
-				}
-
-				$abgabenString .= '</tbody></table>';
-			}
-
-			$abgabenString .= '</div>';
-
-			// done with building the change list, now send it
-			$assistenzRow = $tupelArr[0][1];
-			$anrede = $assistenzRow->anrede;
-			$anredeFillString = $assistenzRow->anrede == "Herr" ? "r" : "";
-			$fullFormattedNameString = $assistenzRow->first;
-			
-			
-
-			$path = $this->_ci->config->item('URL_ASSISTENZ');
-			$url = CIS_ROOT.$path;
-
-			$body_fields = array(
-				'anrede' => $anrede,
-				'anredeFillString' => $anredeFillString,
-				'fullFormattedNameString' => $fullFormattedNameString,
-				'abgabenString' => $abgabenString,
-				'linkAbgabetool' => $url
-			);
-
-			$email = $assistenzRow->uid."@".DOMAIN;
-			
-			// send email with bundled info
-			sendSanchoMail(
-				'PAAChangesAssSM',
-				$body_fields,
-				$email,
-				$this->p->t('abgabetool', 'changedAbgabeterminev2')
-			);
-
-			$count++;
-		}
-
-		$this->_ci->logInfo($count . " Emails erfolgreich versandt");
-		$this->_ci->logInfo('End job FHC-Core->notifyAssistenzAboutChangedAbgaben');
-	}
-
-	public function notifyBetreuerAboutChangedAbgaben() {
-		
-		$this->_ci->logInfo('Start job FHC-Core->notifyBetreuerAboutChangedAbgaben');
-
-		$interval = $this->_ci->config->item('PAABGABE_EMAIL_JOB_INTERVAL');
-
-		$relevantTypes = $this->_ci->config->item('RELEVANT_PAABGABETYPEN_SAMMELMAIL_BETREUER');
-
-		// get all new or changed termine in interval
-		$result = $this->_ci->PaabgabeModel->findAbgabenNewOrUpdatedSince($interval, $relevantTypes);
-		$retval = getData($result);
-
-		if(count($retval) == 0) {
-			$this->_ci->logInfo("Keine Emails an Betreuer über neue oder veränderte Termine versandt");
-			return;
-		}
-		
-		// group changed/new abgaben for projektarbeiten
-		$projektarbeiten = [];
-		foreach($retval as $newOrChangedAbgabe) {
-			// Check if the current item has a 'projektarbeit_id' field.
-			// Replace 'projektarbeit_id' with the actual key name if it's different.
-			if (isset($newOrChangedAbgabe->projektarbeit_id)) {
-				$projektarbeitId = $newOrChangedAbgabe->projektarbeit_id;
-
-				// If the 'projektarbeit_id' is not yet a key in $projektarbeiten, 
-				// initialize it as an empty array.
-				if (!isset($projektarbeiten[$projektarbeitId])) {
-					$projektarbeiten[$projektarbeitId] = [];
-				}
-
-				// Add the current row to the array associated with its 'projektarbeit_id'.
-				$projektarbeiten[$projektarbeitId][] = $newOrChangedAbgabe;
-			}
-		}
-
-		// for each projektarbeit fetch their betreuer and save them in their own dictionary to avoid too many mails
-		$betreuerMap = [];
-		forEach($projektarbeiten as $projektarbeit_id => $abgaben) {
-			$betreuerResult = $this->_ci->ProjektbetreuerModel->getAllBetreuerOfProjektarbeit($projektarbeit_id);
-			
-			forEach($betreuerResult->retval as $betreuerRow) {
-				if (!isset($betreuerMap[$betreuerRow->person_id])) {
-					$betreuerMap[$betreuerRow->person_id] = [];
-				}
-				
-				// Add the current betreuerRow to the betreuerMap as an array associated with its projektarbeit_id.
-				$betreuerMap[$betreuerRow->person_id][] = [$projektarbeit_id, $betreuerRow];
-			}
-		}
-
-		$count = 0;
-		// now iterate over the betreuerMap and build 1 email about all projektarbeiten and their new/changed termine
-		// $tupel = [$projektarbeit_id, $betreuerRow], each betreuer has 0..n [projektarbeit_id, changedAbgaben] tupel
-		forEach($betreuerMap as $betreuer_person_id => $tupelArr) {
-
-			// start the container
-			$abgabenString = '<div style="font-family: Arial, sans-serif; color: #333;">';
-
-			$result = $this->_ci->ProjektarbeitModel->getProjektbetreuerAnrede($betreuer_person_id);
-			$data = getData($result)[0];
-
-			$anrede = $data->anrede;
-			$anredeFillString = $data->anrede == "Herr" ? "r" : "";
-			$fullFormattedNameString = $data->first;
-
-			forEach($tupelArr as $tupel) {
-				$projektarbeit_id = $tupel[0];
-				$betreuerRow = $tupel[1];
-
-				$changedAbgaben = $projektarbeiten[$projektarbeit_id];
-
-				$relevantAbgaben = array_values(array_filter($changedAbgaben, function($abgabetermin) use ($betreuerRow) {
-					if($abgabetermin->updatevon == null && $abgabetermin->insertvon != $betreuerRow->uid) {
-						return $abgabetermin;
-					} else if($abgabetermin->updatevon != null && $abgabetermin->updatevon != $betreuerRow->uid) {
-						return $abgabetermin;
-					}
-				}));
-
-				if(count($relevantAbgaben) == 0) {
-					continue;
-				}
-
-				// format the Student Name
-				$s = $relevantAbgaben[0];
-				$nameParts = [];
-				if (!empty($s->titelpre)) $nameParts[] = $s->titelpre;
-				$nameParts[] = $s->vorname;
-				$nameParts[] = $s->nachname;
-				if (!empty($s->titelpost)) $nameParts[] = $s->titelpost;
-				$studentFullName = implode(' ', $nameParts);
-
-				$projektarbeit_titel = $s->titel ?? 'Kein Titel vergeben';
-
-				// project header section
-				$abgabenString .= "
-					<div style='margin-top: 25px; padding: 12px; background-color: #f8f9fa; border-left: 4px solid #007bff; border-bottom: 1px solid #eee;'>
-						<strong style='font-size: 16px; color: #0056b3;'>Projekt: {$projektarbeit_titel}</strong><br/>
-						<div style='margin-top: 5px; font-size: 14px;'>
-							<strong>Studierende/r:</strong> {$studentFullName}
-						</div>
-						<span style='color: #666; font-size: 12px;'>
-							ID: {$projektarbeit_id} | Rolle: {$betreuerRow->betreuerart_kurzbz} | 
-							Stg: {$s->stgtyp}{$s->stgkz} ({$s->studiensemester_kurzbz})
-						</span>
-					</div>";
-
-				// start table
-				$abgabenString .= '
-					<table style="width: 100%; border-collapse: collapse; margin-bottom: 25px;">
-						<thead>
-							<tr style="background-color: #eee; text-align: left;">
-								<th style="padding: 10px; border: 1px solid #ddd; font-size: 13px; width: 20%;">Zieldatum</th>
-								<th style="padding: 10px; border: 1px solid #ddd; font-size: 13px;">Bezeichnung</th>
-							</tr>
-						</thead>
-						<tbody>';
-
-				foreach ($relevantAbgaben as $abgabe) {
-					$dateEmailFormatted = (new DateTime($abgabe->datum))->format('d.m.Y');
-					$abgabedatumFormatted = (new DateTime($abgabe->abgabedatum))->format('d.m.Y');
-					$kurzbzLine = !empty($abgabe->kurzbz) ? "<br/><small style='color: #777; font-style: italic;'>{$abgabe->kurzbz}</small>" : "";
-
-					$abgabenString .= "
-						<tr>
-							<td style='padding: 10px; border: 1px solid #ddd; font-size: 13px; vertical-align: top;'>{$dateEmailFormatted}</td>
-							<td style='padding: 10px; border: 1px solid #ddd; font-size: 13px;'>
-								<strong>{$abgabe->bezeichnung}</strong>{$kurzbzLine}
-							</td>
-						</tr>";
-				}
-
-				$abgabenString .= '</tbody></table>';
-			}
-			
-			// close container
-			$abgabenString .= '</div>'; 
-
-			// done with building the change list, now send it
-			$betreuerRow = $tupelArr[0][1];
-			
-			$path = $this->_ci->config->item('URL_MITARBEITER');
-			$url = CIS_ROOT.$path;
-
-			$body_fields = array(
-				'anrede' => $anrede,
-				'anredeFillString' => $anredeFillString,
-				'fullFormattedNameString' => $fullFormattedNameString,
-				'abgabenString' => $abgabenString,
-				'linkAbgabetool' => $url
-			);
-			
-			$email = $betreuerRow->uid ? $betreuerRow->uid."@".DOMAIN : $betreuerRow->private_email;
-			
-			// send email with bundled info
-			sendSanchoMail(
-				'PAAChangesBetSM',
-				$body_fields,
-				$email,
-				$this->p->t('abgabetool', 'changedAbgabeterminev2')
-			);
-			
-			$count++;
-		}
-
-		$this->_ci->logInfo($count . " Emails erfolgreich versandt");
-		$this->_ci->logInfo('End job FHC-Core->notifyBetreuerAboutChangedAbgaben');
-	}
-
-	public function notifyBetreuerMail() {
-		// send all new projektarbeit abgabe UPLOADS since the last job run to the related betreuer
-		// this job gathers all new or changed file uploads via field 'abgabedatum', enduploads still
-		// send an email directly after happening since they are kind of important
-
-		$this->_ci->logInfo('Start job FHC-Core->notifyBetreuerMail');
-
-		// dont filter for relevant types since this mail should gather all UPLOAD info
-		
-		$interval = $this->_ci->config->item('PAABGABE_EMAIL_JOB_INTERVAL');
-
-		$result = $this->_ci->PaabgabeModel->findAbgabenNewOrUpdatedSinceByAbgabedatum($interval);
-		$retval = getData($result);
-
-		// retval are paabgaben joined with projektarbeit and betreuer
-		if(count($retval) == 0) {
-			$this->logInfo("Keine Emails über neue Paabgaben an Betreuer versandt");
-			return;
-		}
-
-		// group contents per betreuer person_id
-		$betreuer_uids = [];
-		forEach($retval as $paabgabe) {
-			if(!isset($betreuer_uids[$paabgabe->person_id])) {
-				$betreuer_uids[$paabgabe->person_id] = [];
-			}
-
-			$betreuer_uids[$paabgabe->person_id][] = $paabgabe;
-		}
-
-		$count = 0;
-		forEach ($betreuer_uids as $person_id => $abgaben) {
-			// $person_id is from betreuer
-
-			$result = $this->_ci->ProjektarbeitModel->getProjektbetreuerAnrede($person_id);
-			$data = getData($result)[0];
-
-			$anrede = $data->anrede;
-			$anredeFillString = $data->anrede == "Herr" ? "r" : "";
-			$fullFormattedNameString = $data->first;
-
-			// sorting $abgaben array by datum
-			usort($abgaben, function ($a, $b) {
-				return strtotime($a->datum) <=> strtotime($b->datum);
-			});
-
-			$projektarbeit_titel = $abgaben[0]->titel;
-
-			// initialize the table and headers
-			$abgabenString = '
-			<table style="width: 100%; border-collapse: collapse; font-family: Arial, sans-serif; color: #333; margin-top: 15px; margin-bottom: 15px;">
-				<thead>
-					<tr style="background-color: #f2f2f2; text-align: left;">
-						<th style="padding: 10px; border: 1px solid #ddd; font-size: 13px; width: 15%;">Zieldatum</th>
-						<th style="padding: 10px; border: 1px solid #ddd; font-size: 13px; width: 25%;">Studierende/r</th>
-						<th style="padding: 10px; border: 1px solid #ddd; font-size: 13px;">Bezeichnung</th>
-						<th style="padding: 10px; border: 1px solid #ddd; font-size: 13px; width: 15%;">Abgabedatum</th>
-					</tr>
-				</thead>
-				<tbody>';
-			
-			foreach ($abgaben as $abgabe) {
-				// format the student name
-				$nameParts = [];
-				if (!empty($abgabe->titelpre)) $nameParts[] = $abgabe->titelpre;
-				$nameParts[] = $abgabe->vorname;
-				$nameParts[] = $abgabe->nachname;
-				if (!empty($abgabe->titelpost)) $nameParts[] = $abgabe->titelpost;
-				$studentFullName = implode(' ', $nameParts);
-
-				// format dates inline
-				$dateEmailFormatted = (new DateTime($abgabe->datum))->format('d.m.Y');
-				$abgabedatumFormatted = (new DateTime($abgabe->abgabedatum))->format('d.m.Y');
-
-				// handle the optional Kurzbezeichnung
-				$kurzbzLine = !empty($abgabe->kurzbz) ? "<br/><small style='color: #666; font-style: italic;'>{$abgabe->kurzbz}</small>" : "";
-
-				$abgabenString .= "
-				<tr>
-					<td style='padding: 10px; border: 1px solid #ddd; font-size: 13px; vertical-align: top;'>{$dateEmailFormatted}</td>
-					<td style='padding: 10px; border: 1px solid #ddd; font-size: 13px; vertical-align: top;'>{$studentFullName}</td>
-					<td style='padding: 10px; border: 1px solid #ddd; font-size: 13px;'>
-						<strong>{$abgabe->bezeichnung}</strong>{$kurzbzLine}
-					</td>
-					<td style='padding: 10px; border: 1px solid #ddd; font-size: 13px; vertical-align: top;'>{$abgabedatumFormatted}</td>
-				</tr>";
-			}
-
-			$abgabenString .= '</tbody></table>';
-
-			$path = $this->_ci->config->item('URL_MITARBEITER');
-			$url = CIS_ROOT.$path;
-
-			$body_fields = array(
-				'anrede' => $anrede,
-				'anredeFillString' => $anredeFillString,
-				'fullFormattedNameString' => $fullFormattedNameString,
-				'paTitel' => $projektarbeit_titel,
-				'abgabenString' => $abgabenString,
-				'linkAbgabetool' => $url
-			);
-
-			$result = $this->_ci->ProjektbetreuerModel->getBetreuerOfProjektarbeit($abgaben[0]->projektarbeit_id, $abgaben[0]->betreuerart_kurzbz);
-			$data = getData($result)[0];
-
-			$email = $data->uid ? $data->uid."@".DOMAIN : $data->private_email;
-
-			// send email with bundled info
-			sendSanchoMail(
-				'PaabgabeUpdatesBetSM',
-				$body_fields,
-				$email,
-				$this->p->t('abgabetool', 'changedAbgabeterminev2')
-			);
-
-			$count++;
-		}
-
-		$this->_ci->logInfo($count . " Emails erfolgreich versandt");
-		$this->_ci->logInfo('End job FHC-Core->notifyBetreuerMail');
-	}
-
-	public function notifyStudentMail()
-	{
-		// send all new projektarbeit abgabe since the last job run to the related student
-
-		$this->_ci->logInfo('Start job FHC-Core->notifyStudentMail');
-
-		$interval = $this->_ci->config->item('PAABGABE_EMAIL_JOB_INTERVAL');
-
-		$relevantTypes = $this->_ci->config->item('RELEVANT_PAABGABETYPEN_SAMMELMAIL_STUDENT');
-
-		$result = $this->_ci->PaabgabeModel->findAbgabenNewOrUpdatedSince($interval, $relevantTypes);
-		$retval = getData($result);
-
-		if(count($retval) == 0) {
-			$this->_ci->logInfo("Keine Emails an Studenten versandt");
-			return;
-		}
-		
-		// group results per projektarbeit/student_uid
-		$student_uids = [];
-		forEach($retval as $paabgabe) {
-			if(!isset($student_uids[$paabgabe->student_uid])) {
-				$student_uids[$paabgabe->student_uid] = [];
-			}
-
-			$student_uids[$paabgabe->student_uid][] = $paabgabe;
-		}
-
-		$count = 0;
-		foreach ($student_uids as $uid => $abgaben) {
-			// $uid is the student's UID
-			$result = $this->_ci->StudentModel->getEmailAnredeForStudentUID($uid);
-			$data = getData($result)[0];
-
-			// $abgabe is the array of paabgabe objects
-			$anredeFillString = $data->anrede=="Herr"?"r":"";
-			$fullFormattedNameString = trim($data->titelpre." ".$data->vorname." ".$data->vornamen." ".$data->nachname." ".$data->titelpost);
-
-			// https://www.php.net/manual/en/migration70.new-features.php#migration70.new-features.spaceship-op
-			// php has spaceships 🚀🚀🚀🚀🚀
-			usort($abgaben, function($a, $b) {
-				return strtotime($a->datum) <=> strtotime($b->datum);
-			});
-
-			$projektarbeit_titel = $abgaben[0]->titel;
-			
-			// initialize the table and headers
-			$abgabenString = '
-			<table style="width: 100%; border-collapse: collapse; font-family: Arial, sans-serif; color: #333; margin-top: 15px; margin-bottom: 15px;">
-				<thead>
-					<tr style="background-color: #f2f2f2; text-align: left;">
-						<th style="padding: 10px; border: 1px solid #ddd; font-size: 13px; width: 25%;">Zieldatum</th>
-						<th style="padding: 10px; border: 1px solid #ddd; font-size: 13px;">Bezeichnung / Hinweis</th>
-					</tr>
-				</thead>
-				<tbody>';
-
-			foreach ($abgaben as $abgabe) {
-				$dateEmailFormatted = (new DateTime($abgabe->datum))->format('d.m.Y');
-
-				// handle the optional Kurzbezeichnung
-				$kurzbzLine = !empty($abgabe->kurzbz) ? "<br/><small style='color: #666; font-style: italic;'>{$abgabe->kurzbz}</small>" : "";
-
-				$abgabenString .= "
-				<tr>
-					<td style='padding: 10px; border: 1px solid #ddd; font-size: 13px; vertical-align: top;'>
-						{$dateEmailFormatted}
-					</td>
-					<td style='padding: 10px; border: 1px solid #ddd; font-size: 13px;'>
-						<strong>{$abgabe->bezeichnung}</strong>{$kurzbzLine}
-					</td>
-				</tr>";
-			}
-
-			$abgabenString .= '</tbody></table>';
-			
-			$route =  $this->_ci->config->item('URL_STUDENTS');
-			$url = CIS_ROOT.$route;
-
-			$body_fields = array(
-				'anrede' => $data->anrede,
-				'anredeFillString' => $anredeFillString,
-				'fullFormattedNameString' => $fullFormattedNameString,
-				'paTitel' => $projektarbeit_titel,
-				'abgabenString' => $abgabenString,
-				'linkAbgabetool' => $url
-			);
-
-			// send email with bundled info
-			sendSanchoMail(
-				'PaabgabeUpdatesSammelmail',
-				$body_fields,
-				$uid.'@'.DOMAIN,
-				$this->p->t('abgabetool', 'changedAbgabeterminev2')
-			);
-
-			$count++;
-			
-		}
-
-		$this->_ci->logInfo($count . " Emails erfolgreich versandt");
-		$this->_ci->logInfo('End job FHC-Core->notifyStudentMail');
-	}
-}

application/controllers/jobs/AntragJob.php

@@ -200,14 +200,13 @@ class AntragJob extends JOB_Controller
 	}
 
 	/**
-	 * Send reminder to Assistant and to Student for Wiedereinstieg Unterbrecher
+	 * Send reminder to Assistant for Wiedereinstieg Unterbrecher
 	 *
 	 */
 	public function sendReminderWiedereinstieg()
 	{
 		$now = new DateTime();
 		$modifier = $this->config->item('unterbrechung_job_remind_wiedereinstieg_date_modifier');
-
 		if (!$modifier)
 			return $this->logError('Konnte Job nicht starten: Config "unterbrechung_job_remind_wiedereinstieg_date_modifiers" nicht gesetzt');
 
@@ -231,7 +230,6 @@ class AntragJob extends JOB_Controller
 
 		$antraege = getData($result) ?: [];
 		$count = 0;
-		$countReminderStudent = 0;
 		foreach ($antraege as $antrag)
 		{
 			$res = $this->StudierendenantragModel->getStgAndSem($antrag->studierendenantrag_id);
@@ -259,92 +257,10 @@ class AntragJob extends JOB_Controller
 				$data['UID'] = $student->student_uid;
 			}
 
-			//Data für Email Student
-			$result = $this->PrestudentModel->load($antrag->prestudent_id);
-			$dataPrestudent = current(getData($result));
-			$person_id = $dataPrestudent->person_id;
-
-			$this->KontaktModel->addSelect('kontakt');
-
-			$result = $this->KontaktModel->loadWhere([
-				'person_id'=> $person_id,
-				'zustellung' => true,
-				'kontakttyp' => 'email'
-			]);
-
-			$email_student_privat = null;
-			$dataKontakt = getData($result);
-			if ($dataKontakt) {
-				$stud_private_zustell_emails = array_map(function($kontakt) {
-					return $kontakt->kontakt;
-				}, $dataKontakt);
-				$email_student_privat = implode(', ', $stud_private_zustell_emails);
-			}
-
-			$email_student_FH = $this->StudentModel->getEmailFH($this->StudentModel->getUID($antrag->prestudent_id));
-
-			//studiensemester
-			$result = $this->StudiensemesterModel->getByDate($datum->format('Y-m-d'));
-			if (hasData($result)) {
-				$dataSem = current(getData($result));
-			}
-
-			$studiensemester = $dataSem->studiensemester_kurzbz;
-			$studsemShort = substr($studiensemester, 0, 2);
-
-			if($studsemShort == "SS")
-			{
-				$data['studSemShort_Eng'] = "summer semester";
-				$data['meldenBis'] = "15.1.";
-				$data['meldenBis_Eng'] = "January 15";
-			}
-			elseif ($studsemShort == "WS") {
-				$data['studSemShort_Eng'] = "winter semester";
-				$data['meldenBis'] = "1.8.";
-				$data['meldenBis_Eng'] = "August 1";
-			}
-			else
-			{
-				$studsemShort = "SS/WS";
-				$data['studSemShort_Eng'] = "summer/winter semester";
-				$data['meldenBis'] = "15.1. (bei Einstieg ins SS) / 1.8. (bei Einstieg ins WS)";
-				$data['meldenBis_Eng'] = "January 15 (for sommer semester enrollment) / August 1 (for winter semester enrollment)";
-			}
-
-			$data['studSemShort'] = $studsemShort;
-
-			// NOTE(chris): Sancho mail Assistant
-			$sancho_assistant_sent = sendSanchoMail('Sancho_Mail_Antrag_U_Reminder', $data, $antrag->email, 'Reminder: Unterbrechung Wiedereinstieg');
-			if($sancho_assistant_sent)
+			// NOTE(chris): Sancho mail
+			if(sendSanchoMail('Sancho_Mail_Antrag_U_Reminder', $data, $antrag->email, 'Reminder: Unterbrechung Wiedereinstieg'))
 			{
 				$count++;
-			}
-			else
-			{
-				$this->logError('Error: failed to send Assistant Reminder studierendenantrag_id: ' . $antrag->studierendenantrag_id);
-			}
-			//Mail to Student
-			$sancho_student_sent = sendSanchoMail(
-				'Sancho_Mail_Antrag_U_Remind_Stud',
-				$data,
-				$email_student_FH,
-				'Reminder: Unterbrechung Wiedereinstieg',
-				'',
-				'',
-				'',
-				$email_student_privat);
-
-			if($sancho_student_sent)
-			{
-				$countReminderStudent++;
-			}
-			else
-			{
-				$this->logError('Error: failed to send Student Reminder studierendenantrag_id: ' . $antrag->studierendenantrag_id);
-			}
-
-			if($sancho_assistant_sent && $sancho_student_sent)
-			{
 				$this->StudierendenantragstatusModel->insert([
 					'studierendenantrag_id' => $antrag->studierendenantrag_id,
 					'studierendenantrag_statustyp_kurzbz' => Studierendenantragstatus_model::STATUS_REMINDERSENT,
@@ -352,7 +268,7 @@ class AntragJob extends JOB_Controller
 				]);
 			}
 		}
-		$this->logInfo($count . ' Reminder an Assistenz und ' . $countReminderStudent . ' Reminder an Student gesendet  - Ende Job sendReminderWiedereinstieg');
+		$this->logInfo($count . ' Reminder gesendet - Ende Job sendReminderWiedereinstieg');
 	}
 
 	/**

application/core/FHCAPI_Controller.php

@@ -266,7 +266,7 @@ class FHCAPI_Controller extends Auth_Controller
 	}
 
 	// ---------------------------------------------------------------
-	// Security Begin
+	// Security
 	// ---------------------------------------------------------------
 
 	/**
@@ -287,31 +287,4 @@ class FHCAPI_Controller extends Auth_Controller
 			'required_permissions' => $this->_rpsToString($requiredPermissions, $this->router->method)
 		], self::ERROR_TYPE_AUTH);
 	}
-
-	// ---------------------------------------------------------------
-	// Security End
-	// ---------------------------------------------------------------
-
-	/**
-	 * Checks the client's total request size (Content-Length) against the minimum
-	 * effective PHP limit (min of upload_max_filesize, post_max_size, memory_limit).
-	 * This preempts failures that result in vague "missing parameters" errors on large files.
-	 *
-	 * @return void
-	 */
-	protected function checkUploadSize() {
-		// this number represents bytes
-		$content_length_bytes = (int)$this->input->server('CONTENT_LENGTH');
-		$content_length = $content_length_bytes / 1000000;
-		
-		//get max serverside size upload -> this comes in megabytes
-		$max_upload = (int)(ini_get('upload_max_filesize'));
-		$max_post = (int)(ini_get('post_max_size'));
-		$memory_limit = (int)(ini_get('memory_limit'));
-		$max_upload_mb = min($max_upload, $max_post, $memory_limit);    // smallest of 3 config values
-		
-		if($content_length >= $max_upload_mb) {
-			$this->terminateWithError($this->p->t('global', 'filesizeExceeded'), 'general');
-		}
-	}
 }

application/helpers/hlp_header_helper.php

@@ -185,15 +185,7 @@ function generateJSModulesInclude($JSModules)
 
 		for ($tmpJSsCounter = 0; $tmpJSsCounter < count($tmpJSs); $tmpJSsCounter++)
 		{
-			if($ci->config->item('use_fhcomplete_build_version_in_path'))
-			{
-				$relurl = preg_replace('#public/#', 'public/' . $ci->config->item('fhcomplete_build_version') . '/', $tmpJSs[$tmpJSsCounter]);
-				$toPrint = sprintf($jsInclude, base_url($relurl)).PHP_EOL;
-			}
-			else
-			{
-				$toPrint = sprintf($jsInclude, base_url($tmpJSs[$tmpJSsCounter].$cachetoken)).PHP_EOL;
-			}
+			$toPrint = sprintf($jsInclude, base_url($tmpJSs[$tmpJSsCounter].$cachetoken)).PHP_EOL;
 
 			if ($tmpJSsCounter > 0) $toPrint = "\t\t".$toPrint;
 
@@ -258,14 +250,6 @@ function generateSkipLink($skipID)
 function absoluteJsImportUrl($relurl)
 {
 	$ci =& get_instance();
-	$ci->load->config('javascript');
-	if($ci->config->item('use_fhcomplete_build_version_in_path'))
-	{
-		$url = base_url(preg_replace('#^public/#', 'public/' . $ci->config->item('fhcomplete_build_version') . '/', $relurl));
-	}
-	else
-	{
-		$url = base_url($relurl) . '?'. $ci->config->item('fhcomplete_build_version');
-	}
+	$url = base_url($relurl) . '?'. $ci->config->item('fhcomplete_build_version');
 	return $url;
-}
+}

application/libraries/PrestudentLib.php

@@ -35,90 +35,6 @@ class PrestudentLib
 		$this->_ci->load->model('organisation/Studiengang_model', 'StudiengangModel');
 	}
 
-	/**
-	 * Sets initial prestudent entry, no status yet.
-	 * @return object success or error
-	 */
-	public function setPrestudent(
-		$person_id,
-		$studiengang_kz,
-		$ausbildungscode,
-		$anmerkung,
-		$foerderrelevant
-	)
-	{
-		// Prestudent anlegen
-		$data = [
-			'aufmerksamdurch_kurzbz' => 'k.A.',
-			'person_id' => $person_id,
-			'studiengang_kz' => $studiengang_kz,
-			'ausbildungcode' => $ausbildungscode,
-			'anmerkung' => $anmerkung,
-			'reihungstestangetreten' => false,
-			'bismelden' => true,
-			'foerderrelevant' => $foerderrelevant,
-			'insertamum' => date('c'),
-			'insertvon' => getAuthUID()
-		];
-
-		// Wenn die Person schon im System erfasst ist, dann die ZGV des Datensatzes uebernehmen
-		$this->_ci->PrestudentModel->addSelect('public.tbl_prestudent.*, public.tbl_person.vorname, public.tbl_person.nachname');
-		$this->_ci->PrestudentModel->addJoin('public.tbl_person', 'person_id');
-		$this->_ci->PrestudentModel->addOrder('zgvmas_code');
-		$this->_ci->PrestudentModel->addOrder('zgv_code', 'DESC');
-		$this->_ci->PrestudentModel->addLimit(1);
-		$result = $this->_ci->PrestudentModel->loadWhere([
-			'person_id' => $person_id,
-			'zgv_code IS NOT NULL' => null
-		]);
-
-		if (isError($result)) return $result;
-
-		if (hasData($result)) {
-			$prestudent = getData($result)[0];
-			if ($prestudent->zgv_code) {
-				$data['zgv_code'] = $prestudent->zgv_code;
-				$data['zgvort'] = $prestudent->zgvort;
-				$data['zgvdatum'] = $prestudent->zgvdatum;
-
-				$data['zgvmas_code'] = $prestudent->zgvmas_code;
-				$data['zgvmaort'] = $prestudent->zgvmaort;
-				$data['zgvmadatum'] = $prestudent->zgvmadatum;
-			}
-		}
-		// Prestudent speichern
-		return $this->_ci->PrestudentModel->insert($data);
-	}
-
-	/**
-	 * Sets first status of a prestudent.!
-	 * @return object success or error
-	 */
-	public function setFirstStatus(
-		$prestudent_id,
-		$status_kurzbz,
-		$studiensemester_kurzbz,
-		$ausbildungssemester = null,
-		$orgform_kurzbz = null,
-		$studienplan_id = null
-	)
-	{
-		// Prestudent Rolle Anlegen
-		$data = [
-			'prestudent_id' => $prestudent_id,
-			'status_kurzbz' => $status_kurzbz,
-			'studiensemester_kurzbz' => $studiensemester_kurzbz,
-			'ausbildungssemester' => $ausbildungssemester ?: 0,
-			'orgform_kurzbz' => $orgform_kurzbz ?: null,
-			'studienplan_id' => $studienplan_id ?: null,
-			'datum' => date('Y-m-d'),
-			'insertamum' => date('c'),
-			'insertvon' => getAuthUID()
-		];
-
-		return  $this->_ci->PrestudentstatusModel->insert($data);
-	}
-
 	public function setAbbrecher(
 		$prestudent_id,
 		$studiensemester_kurzbz,
@@ -687,6 +603,9 @@ class PrestudentLib
 		$now = date('c');
 		$today = date('Y-m-d');
 
+		$jahr = mb_substr($studiensemester_kurzbz, 4, 2);
+
+
 		// Genererate Personenkennzeichen
 		$personenkennzeichen = $this->_ci->StudentModel->generateMatrikelnummer2(
 			$student_data->studiengang_kz,
@@ -696,9 +615,8 @@ class PrestudentLib
 		if (isError($personenkennzeichen))
 			return $personenkennzeichen;
 		$personenkennzeichen = getData($personenkennzeichen);
-
-		$jahr = mb_substr($personenkennzeichen, 0, 2);
-
+		
+		
 		// Generate UID
 		$uid = $this->_ci->StudentModel->generateUID(
 			$student_data->kurzbz,
@@ -723,7 +641,7 @@ class PrestudentLib
 
 
 		// Generate Alias
-		$alias = null;
+		$alias = '';
 		if (!defined('GENERATE_ALIAS_STUDENT')
 			|| GENERATE_ALIAS_STUDENT === true
 		) {
@@ -971,155 +889,6 @@ class PrestudentLib
 		);
 	}
 
-	/**
-	 * Creates an incoming, saves necessary data for an incoming. 
-	 * @param $prestudent_id existing prestudent, for which incoming entry is created
-	 * @param $studiengang_kz Studiengang assigned to incoming
-	 * @param $studiensemester_kurzbz start semester for incoming
-	 * @return object success if incoming successfully saved, or error
-	 */
-	public function setFirstIncoming($prestudent_id, $studiengang_kz, $studiensemester_kurzbz, $orgform_kurzbz, $studienplan_id)
-	{
-		// Verband and Ausbildungssemester for incoming
-		$authUID = getAuthUID();
-		$incomingVerband = 'I';
-		$incomingAusbildungssemester = '0';
-
-		// get prestudent
-		$this->_ci->PrestudentModel->addJoin('public.tbl_person p', 'person_id');
-		$this->_ci->PrestudentModel->addJoin('public.tbl_studiengang stg', 'studiengang_kz');
-		$result = $this->_ci->PrestudentModel->load($prestudent_id);
-
-		if (isError($result)) return $result;
-		if (!hasData($result)) return error('No prestudent');
-
-		$student_data = getData($result)[0];
-
-		$result = $this->setFirstStatus(
-			$prestudent_id,
-			$this->_ci->PrestudentstatusModel::STATUS_INCOMING,
-			$studiensemester_kurzbz,
-			$incomingAusbildungssemester,
-			$orgform_kurzbz,
-			$studienplan_id
-		);
-		if (isError($result)) return $result;
-		if (!hasData($result)) return error('Error when adding prestudentstatus');
-
-		// generate Personenkennzeichen
-		$result = $this->_ci->StudentModel->generateMatrikelnummer2($studiengang_kz, $studiensemester_kurzbz);
-		if (isError($result)) return $result;
-		if (!hasData($result)) return error('No personenkennzeichen could be generated');
-
-		$personenkennzeichen = getData($result);
-
-		$jahr = mb_substr($personenkennzeichen, 0, 2);
-		$stg = mb_substr($personenkennzeichen, 3, 4);
-
-		$nachname_clean = mb_strtolower(sanitizeProblemChars($student_data->nachname));
-		$vorname_clean = mb_strtolower(sanitizeProblemChars($student_data->vorname));
-		$nachname_clean = str_replace(' ','_', $nachname_clean);
-		$vorname_clean = str_replace(' ','_', $vorname_clean);
-
-		// get Studiengang data
-		$result = $this->_ci->StudiengangModel->load(ltrim($stg, '0'));
-		if (isError($result)) return $result;
-		if (!hasData($result)) return error('No Studiengang');
-
-		$stgObj = getData($result)[0];
-
-		// gernerate uid
-		$result = $this->_ci->StudentModel->generateUID($stgObj->kurzbz, $jahr, $stgObj->typ, $personenkennzeichen, $vorname_clean, $nachname_clean);
-		if (isError($result)) return $result;
-		if (!hasData($result)) return error("UID could not be generated");
-		$uid = getData($result);
-
-		//Benutzerdatensatz anlegen
-		$benutzer = [
-			'uid' => $uid,
-			'person_id' => $student_data->person_id,
-			'aktiv' => true,
-			'aktivierungscode' => $this->_ci->BenutzerModel->generateActivationkey()
-		];
-
-		// Generate Alias
-		$alias = '';
-		if (!defined('GENERATE_ALIAS_STUDENT') || GENERATE_ALIAS_STUDENT === true)
-		{
-			$result = $this->_ci->BenutzerModel->generateAliasFromName($student_data->vorname, $student_data->nachname);
-			if (isError($result))
-				return $result;
-			$alias = getData($result);
-		}
-
-		$benutzer['alias'] = $alias;
-		$benutzer['insertamum'] = date('Y-m-d H:i:s');
-		$benutzer['insertvon'] = $authUID;
-
-		$result = $this->_ci->BenutzerModel->insert($benutzer);
-
-		if (isError($result)) return $result;
-
-		// Studentendatensatz anlegen
-		$student = [
-			'student_uid' => $uid,
-			'matrikelnr' => $personenkennzeichen,
-			'prestudent_id' => $prestudent_id,
-			'studiengang_kz' => $studiengang_kz,
-			'semester' => $incomingAusbildungssemester,
-			'verband' => $incomingVerband,
-			'gruppe' => ' '
-		];
-
-		$result = $this->_ci->LehrverbandModel->loadWhere([
-				'studiengang_kz' => $student['studiengang_kz'],
-				'semester' => $student['semester'],
-				'verband' => $student['verband'],
-				'gruppe' => $student['gruppe']
-			]);
-
-		if (isError($result)) return $result;
-
-		if (!hasData($result))
-		{
-			// Add Lehrverband if it does not exist
-			$result = $this->_ci->LehrverbandModel->insert([
-				'studiengang_kz' => $student_data->studiengang_kz,
-				'semester' => $student['semester'],
-				'verband' => $student['verband'],
-				'gruppe' => $student['gruppe'],
-				'bezeichnung' => 'Incoming',
-				'aktiv' => true
-			]);
-
-			if (isError($result)) return $result;
-		}
-
-		// add student
-		$student['insertamum'] = date('Y-m-d H:i:s');
-		$student['insertvon'] = $authUID;
-
-		$result = $this->_ci->StudentModel->insert($student);
-		if (isError($result)) return $result;
-
-		// Add Studentlehrverband
-		$result = $this->_ci->StudentlehrverbandModel->insert([
-			'student_uid' => $uid,
-			'studiensemester_kurzbz' => $studiensemester_kurzbz,
-			'studiengang_kz' => $student_data->studiengang_kz,
-			'semester' => $incomingAusbildungssemester,
-			'verband' => $incomingVerband,
-			'gruppe' => ' ',
-			'insertamum' => date('Y-m-d H:i:s'),
-			'insertvon' => $authUID
-		]);
-
-		if (isError($result))
-			return $result;
-
-		return success($prestudent_id);
-	}
-
 	protected function setBasic($authUID, $now, $status_kurzbz, $prestudent_id, $studiensemester_kurzbz, $ausbildungssemester, $statusgrund_id = null)
 	{
 		$result = $this->_ci->PrestudentstatusModel->getLastStatus($prestudent_id);

application/models/crm/Prestudentstatus_model.php

@@ -290,11 +290,7 @@ class Prestudentstatus_model extends DB_Model
 	 */
 	public function getLastStatusPerson($person_id, $studiensemester_kurzbz = null)
 	{
-		$query = 'SELECT p.*, ps.*, s.*,
-					stg.kurzbz AS studiengang_kurzbz, stg.kurzbzlang AS studiengang_kurzbzlang,
-					UPPER(typ::varchar(1) || kurzbz) AS studiengang_kuerzel,
-					stg.typ AS studiengang_typ, stg.bezeichnung AS studiengang_bezeichnung, stg.english AS studiengang_bezeichnung_english,
-					stg.orgform_kurzbz AS studiengang_orgform
+		$query = 'SELECT *
 					FROM public.tbl_prestudent p
 					JOIN (
 							SELECT DISTINCT ON(prestudent_id) *
@@ -302,8 +298,7 @@ class Prestudentstatus_model extends DB_Model
 							 WHERE prestudent_id IN (SELECT prestudent_id FROM public.tbl_prestudent WHERE person_id = ?)
 						  ORDER BY prestudent_id, datum desc, insertamum desc
 						) ps USING(prestudent_id)
-					JOIN public.tbl_status s USING(status_kurzbz)
-					JOIN public.tbl_studiengang stg USING (studiengang_kz)';
+					JOIN public.tbl_status USING(status_kurzbz)';
 
 		$parametersArray = array($person_id);
 

application/models/crm/Student_model.php

@@ -27,7 +27,7 @@ class Student_model extends DB_Model
         $this->addSelect('1');
 
         $result = $this->loadWhere(array('student_uid' => $uid));
-
+        
 
         if(hasData($result))
         {
@@ -169,7 +169,7 @@ class Student_model extends DB_Model
 
 		$max = 0;
 		if ($matrikelnrres && hasData($matrikelnrres)) {
-			$max = mb_substr(trim(getData($matrikelnrres)[0]->matrikelnr), -3);
+			$max = mb_substr($matrikelnrres->retval[0]->matrikelnr, 7);
 			if (!is_numeric($max)) {
 				$max = (int)$max;
 			}
@@ -279,12 +279,4 @@ class Student_model extends DB_Model
 	{
 		return $student_uid . '@' . DOMAIN;
 	}
-	
-	public function getEmailAnredeForStudentUID($student_uid) {
-		$qry = "SELECT anrede, titelpre, vorname, vornamen, nachname, titelpost
-				FROM campus.vw_student 
-				WHERE uid = ?";
-
-		return $this->execReadOnlyQuery($qry, array($student_uid));
-	}
 }

application/models/education/Lehrveranstaltung_model.php

@@ -316,8 +316,8 @@ class Lehrveranstaltung_model extends DB_Model
 			(SELECT status_kurzbz FROM public.tbl_prestudentstatus WHERE prestudent_id=tbl_student.prestudent_id ORDER BY datum DESC, insertamum DESC, ext_id DESC LIMIT 1) as status,
 			tbl_bisio.bisio_id, tbl_bisio.von, tbl_bisio.bis, tbl_student.studiengang_kz AS stg_kz_student,
 			tbl_zeugnisnote.note, tbl_mitarbeiter.mitarbeiter_uid, tbl_person.matr_nr, tbl_benutzer.uid,
-			UPPER(tbl_studiengang.typ::varchar(1) || tbl_studiengang.kurzbz) as kuerzel, tbl_studiengang.orgform_kurzbz, vw_student_lehrveranstaltung.semester, vw_student_lehrveranstaltung.studiensemester_kurzbz, vw_student_lehrveranstaltung.bezeichnung,
-			tbl_student.prestudent_id
+			UPPER(tbl_studiengang.typ::varchar(1) || tbl_studiengang.kurzbz) as kuerzel, tbl_studiengang.orgform_kurzbz, vw_student_lehrveranstaltung.semester, vw_student_lehrveranstaltung.studiensemester_kurzbz, vw_student_lehrveranstaltung.bezeichnung
+
 		FROM
 			campus.vw_student_lehrveranstaltung
 			JOIN public.tbl_benutzer USING(uid)
@@ -386,37 +386,6 @@ class Lehrveranstaltung_model extends DB_Model
 
 		return $this->execQuery($query, array($lehrveranstaltung_id, $studiensemester_kurzbz));
 	}
-
-	/**
-	 * Get LV-Leitung of given Lehrveranstaltung ID and Studiensemester.
-	 *
-	 * @param $lehrveranstaltung_id
-	 * @param $studiensemester
-	 * @return array|stdClass|null
-	 */
-	public function getLvLeitung($lehrveranstaltung_id, $studiensemester)
-	{
-		$params = [$lehrveranstaltung_id, $studiensemester];
-
-		$qry = "
-			SELECT
-				vorname, nachname, mitarbeiter_uid, lehrfunktion_kurzbz
-			FROM
-				lehre.tbl_lehreinheit
-				JOIN lehre.tbl_lehreinheitmitarbeiter lema USING (lehreinheit_id)
-				JOIN public.tbl_benutzer b ON b.uid = lema.mitarbeiter_uid
-				JOIN public.tbl_person p using (person_id) 
-			WHERE
-				tbl_lehreinheit.lehrveranstaltung_id= ?
-				AND tbl_lehreinheit.studiensemester_kurzbz = ?
-				AND lehrfunktion_kurzbz = 'LV-Leitung'
-            ORDER BY 
-                lema.insertamum DESC
-			LIMIT 1
-		";
-
-		return $this->execQuery($qry, $params);
-	}
 	/**
 	 * Gets all Leiter of Lehrveranstaltungsorganisationseinheit
 	 * @param $lehrveranstaltung_id

application/models/education/Note_model.php

@@ -11,12 +11,4 @@ class Note_model extends DB_Model
 		$this->dbTable = 'lehre.tbl_note';
 		$this->pk = 'note';
 	}
-
-	public function getAllActive() {
-		$qry ="SELECT *
-			FROM lehre.tbl_note
-			WHERE aktiv = true";
-
-		return $this->execReadOnlyQuery($qry);
-	}
 }

application/models/education/Paabgabe_model.php

@@ -60,58 +60,5 @@ class Paabgabe_model extends DB_Model
 
 		return $this->execReadOnlyQuery($qry, array($person_id));
 	}
-
-	public function findAbgabenNewOrUpdatedSince($interval, $relevantTypes)
-	{
-
-		$query = "SELECT projektarbeit_id, paabgabe_id, paabgabetyp_kurzbz, fixtermin, datum, campus.tbl_paabgabe.kurzbz, campus.tbl_paabgabetyp.bezeichnung, campus.tbl_paabgabe.abgabedatum,
-			   campus.tbl_paabgabe.insertvon, campus.tbl_paabgabe.insertamum, campus.tbl_paabgabe.updatevon, campus.tbl_paabgabe.updateamum,
-			   campus.tbl_paabgabe.note, upload_allowed, beurteilungsnotiz, student_uid, tbl_projektarbeit.note, lehre.tbl_projektarbeit.titel,
-			   UPPER(tbl_studiengang.typ) as stgtyp, UPPER(tbl_studiengang.kurzbz) as stgkz, public.tbl_studiengang.studiengang_kz,
-			   public.tbl_studiengang.oe_kurzbz as stg_oe_kurzbz, tbl_lehreinheit.studiensemester_kurzbz,
-			   public.tbl_person.anrede, public.tbl_person.titelpre, public.tbl_person.vorname, public.tbl_person.nachname, public.tbl_person.titelpost
-		FROM campus.tbl_paabgabe
-				 JOIN campus.tbl_paabgabetyp USING (paabgabetyp_kurzbz)
-				 JOIN lehre.tbl_projektarbeit USING (projektarbeit_id)
-				 JOIN lehre.tbl_lehreinheit using(lehreinheit_id)
-				 JOIN lehre.tbl_lehrveranstaltung using(lehrveranstaltung_id)
-				 JOIN public.tbl_studiengang on(lehre.tbl_lehrveranstaltung.studiengang_kz = public.tbl_studiengang.studiengang_kz)
-				 JOIN public.tbl_benutzer ON (public.tbl_benutzer.uid = student_uid)
-				 JOIN public.tbl_person USING (person_id)
-		
-		WHERE (campus.tbl_paabgabe.insertamum >= NOW() - INTERVAL ?
-		   OR campus.tbl_paabgabe.updateamum >= NOW() - INTERVAL ?)
-		   AND campus.tbl_paabgabe.paabgabetyp_kurzbz IN ?";
-
-		return $this->execQuery($query, [$interval, $interval, $relevantTypes]);
-	}
-
-	public function findAbgabenNewOrUpdatedSinceByAbgabedatum($interval) {
-
-		$query = "SELECT projektarbeit_id, paabgabe_id, paabgabetyp_kurzbz, fixtermin, datum, kurzbz, campus.tbl_paabgabetyp.bezeichnung, campus.tbl_paabgabe.abgabedatum,
-						campus.tbl_paabgabe.insertvon, campus.tbl_paabgabe.insertamum, campus.tbl_paabgabe.updatevon, campus.tbl_paabgabe.updateamum,
-						campus.tbl_paabgabe.note, upload_allowed, beurteilungsnotiz, student_uid, tbl_projektarbeit.note, lehre.tbl_projektarbeit.titel,
-						lehre.tbl_projektbetreuer.betreuerart_kurzbz, lehre.tbl_projektbetreuer.person_id,
-						public.tbl_person.anrede, public.tbl_person.titelpre, public.tbl_person.vorname, public.tbl_person.nachname, public.tbl_person.titelpost
-				
-				FROM campus.tbl_paabgabe 
-					JOIN campus.tbl_paabgabetyp USING (paabgabetyp_kurzbz)
-					JOIN lehre.tbl_projektarbeit USING (projektarbeit_id)
-					JOIN lehre.tbl_projektbetreuer USING (projektarbeit_id)
-					JOIN public.tbl_benutzer ON (public.tbl_benutzer.uid = student_uid)
-				 	JOIN public.tbl_person ON (public.tbl_benutzer.person_id = public.tbl_person.person_id)
-				
-				WHERE campus.tbl_paabgabe.abgabedatum IS NOT NULL 
-				AND campus.tbl_paabgabe.abgabedatum >= NOW() - INTERVAL ?
-				ORDER BY abgabedatum DESC
-	";
-
-		return $this->execQuery($query, [$interval]);
-	}
 	
-	public function loadByIDs($paabgabe_ids) {
-		$qry = "SELECT * FROM campus.tbl_paabgabe WHERE paabgabe_id IN ?";
-		
-		return $this->execReadOnlyQuery($qry, [$paabgabe_ids]);
-	}
 }

application/models/education/Paabgabetyp_model.php

@@ -11,10 +11,4 @@ class Paabgabetyp_model extends DB_Model
 		$this->dbTable = 'campus.tbl_paabgabetyp';
 		$this->pk = 'paabgabetyp_kurzbz';
 	}
-	
-	public function getAll() {
-		$qry = "SELECT * FROM campus.tbl_paabgabetyp ORDER BY bezeichnung";
-
-		return $this->execReadOnlyQuery($qry);
-	}
 }

application/models/education/Projektarbeit_model.php

@@ -24,28 +24,17 @@ class Projektarbeit_model extends DB_Model
 	public function getProjektarbeit($student_uid, $studiengang_kz = null, $studiensemester_kurzbz = null, $projekttyp = null, $final = null)
 	{
 		$qry = "SELECT
-					pa.*, tbl_projekttyp.bezeichnung,
+					tbl_projektarbeit.*, tbl_projekttyp.bezeichnung,
 					tbl_lehreinheit.studiensemester_kurzbz, tbl_lehrveranstaltung.lehrveranstaltung_id,
-					tbl_firma.name AS firma_name,
-					(
-						SELECT
-							STRING_AGG(trim(COALESCE(titelpre,'')||' '||COALESCE(vorname,'')||' '||COALESCE(nachname,'')||' '||COALESCE(titelpost,'')), ', ')
-						FROM
-							lehre.tbl_projektbetreuer
-							JOIN public.tbl_person USING (person_id)
-						WHERE
-							projektarbeit_id = pa.projektarbeit_id
-							AND student_uid = pa.student_uid
-						GROUP BY projektarbeit_id
-					) AS projektbetreuer
+					tbl_firma.name AS firma_name
 				FROM
-					lehre.tbl_projektarbeit pa
+					lehre.tbl_projektarbeit
 					JOIN lehre.tbl_projekttyp USING (projekttyp_kurzbz)
 					JOIN lehre.tbl_lehreinheit USING (lehreinheit_id)
 					JOIN lehre.tbl_lehrveranstaltung USING (lehrveranstaltung_id)
 					LEFT JOIN public.tbl_firma USING (firma_id)
 				WHERE
-					pa.student_uid = ?";
+					tbl_projektarbeit.student_uid = ?";
 
 		$params = array($student_uid);
 
@@ -64,16 +53,16 @@ class Projektarbeit_model extends DB_Model
 		if (isset($projekttyp))
 		{
 			if (is_array($projekttyp))
-				$qry .= ' AND pa.projekttyp_kurzbz IN ?';
+				$qry .= ' AND tbl_projektarbeit.projekttyp_kurzbz IN ?';
 			else
-				$qry .= ' AND pa.projekttyp_kurzbz=?';
+				$qry .= ' AND tbl_projektarbeit.projekttyp_kurzbz=?';
 
 			$params[] = $projekttyp;
 		}
 
 		if (isset($final))
 		{
-			$qry .= ' AND pa.final=?';
+			$qry .= ' AND tbl_projektarbeit.final=?';
 			$params[] = $final;
 		}
 
@@ -109,36 +98,36 @@ class Projektarbeit_model extends DB_Model
 	 */
 	public function getStudentProjektarbeitenWithBetreuer($studentUID)
 	{
-		$betreuerQuery = "SELECT * FROM (SELECT DISTINCT ON(projektarbeit_id)
+		$betreuerQuery = "
+		SELECT 
 			vorname as bvorname,
 			nachname as bnachname,
 			titelpre as btitelpre,
 			titelpost AS btitelpost,
+			titelpost AS btitelpost,
 			tbl_betreuerart.beschreibung AS betreuerart_beschreibung,
 		
-			(SELECT person_id
-			 FROM lehre.tbl_projektbetreuer
+			(SELECT person_id 
+			 FROM lehre.tbl_projektbetreuer 
 			 WHERE projektarbeit_id=tbl_projektarbeit.projektarbeit_id
-			   AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter') LIMIT 1) AS zweitbetreuer_person_id,
-			(SELECT betreuerart_kurzbz
-			 FROM lehre.tbl_projektbetreuer
+			 AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter') LIMIT 1) AS zweitbetreuer_person_id,
+			(SELECT betreuerart_kurzbz 
+			 FROM lehre.tbl_projektbetreuer 
 			 WHERE projektarbeit_id=tbl_projektarbeit.projektarbeit_id
-			   AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter') LIMIT 1) AS zweitbetreuer_betreuerart_kurzbz,
-			(SELECT tbl_betreuerart.beschreibung
-			 FROM lehre.tbl_projektbetreuer JOIN lehre.tbl_betreuerart USING(betreuerart_kurzbz)
+			AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter') LIMIT 1) AS zweitbetreuer_betreuerart_kurzbz,
+			(SELECT tbl_betreuerart.beschreibung 
+			 FROM lehre.tbl_projektbetreuer JOIN lehre.tbl_betreuerart USING(betreuerart_kurzbz) 
 			 WHERE projektarbeit_id=tbl_projektarbeit.projektarbeit_id
-			   AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter', 'Senatsmitglied') LIMIT 1) AS zweitbetreuer_betreuerart_beschreibung,
-		
+			 AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter', 'Senatsmitglied') LIMIT 1) AS zweitbetreuer_betreuerart_beschreibung,
+			
 			tbl_betreuerart.betreuerart_kurzbz,
 			person_id as bperson_id,
 			projektarbeit_id,
 			lehre.tbl_projekttyp.bezeichnung as projekttypbezeichnung,
-			lehre.tbl_projekttyp.projekttyp_kurzbz as projekttypkurzbz,
 			lehre.tbl_lehreinheit.studiensemester_kurzbz,
 			lehre.tbl_lehrveranstaltung.studiengang_kz,
 			public.tbl_studiengang.kurzbzlang,
-			lehre.tbl_projektarbeit.note as note,
-			lehre.tbl_note.bezeichnung as note_bezeichnung,
+			lehre.tbl_projektbetreuer.note as note,
 			public.tbl_mitarbeiter.mitarbeiter_uid,
 			lehre.tbl_projektarbeit.titel as titel,
 			lehre.tbl_projektarbeit.sprache as sprache,
@@ -147,8 +136,9 @@ class Projektarbeit_model extends DB_Model
 			lehre.tbl_projektarbeit.schlagwoerter as schlagwoerter,
 			lehre.tbl_projektarbeit.schlagwoerter_en as schlagwoerter_en,
 			lehre.tbl_projektarbeit.abstract as abstract,
-			lehre.tbl_projektarbeit.abstract_en as abstract_en,
-			lehre.tbl_projektarbeit.insertamum as insertamum,
+			lehre.tbl_projektarbeit.abstract_en as abstract_en, 
+			(SELECT abgeschicktvon FROM extension.tbl_projektarbeitsbeurteilung WHERE projektarbeit_id = tbl_projektarbeit.projektarbeit_id AND betreuer_person_id = tbl_projektbetreuer.person_id) AS babgeschickt,
+			(SELECT abgeschicktvon FROM extension.tbl_projektarbeitsbeurteilung WHERE projektarbeit_id = tbl_projektarbeit.projektarbeit_id AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter') LIMIT 1) AS zweitbetreuer_abgeschickt,
 			(SELECT datum FROM campus.tbl_paabgabe WHERE paabgabetyp_kurzbz = 'end' AND abgabedatum IS NOT NULL AND projektarbeit_id = tbl_projektarbeit.projektarbeit_id LIMIT 1) AS abgegeben
 		
 		FROM lehre.tbl_projektarbeit
@@ -157,17 +147,15 @@ class Projektarbeit_model extends DB_Model
 				 LEFT JOIN public.tbl_benutzer USING(person_id)
 				 LEFT JOIN lehre.tbl_projekttyp USING (projekttyp_kurzbz)
 				 LEFT JOIN lehre.tbl_betreuerart USING(betreuerart_kurzbz)
-				 LEFT JOIN lehre.tbl_lehreinheit USING(lehreinheit_id)
-				 LEFT JOIN lehre.tbl_lehrveranstaltung USING(lehrveranstaltung_id)
-				 LEFT JOIN public.tbl_mitarbeiter ON(public.tbl_mitarbeiter.mitarbeiter_uid = public.tbl_benutzer.uid)
-				 LEFT JOIN public.tbl_studiengang USING(studiengang_kz)
-				 LEFT JOIN lehre.tbl_note ON(lehre.tbl_projektarbeit.note = lehre.tbl_note.note)
-		WHERE
-			tbl_projektarbeit.student_uid = ? AND mitarbeiter_uid IS NOT NULL AND
+				LEFT JOIN lehre.tbl_lehreinheit USING(lehreinheit_id)
+				LEFT JOIN lehre.tbl_lehrveranstaltung USING(lehrveranstaltung_id)
+		LEFT JOIN public.tbl_mitarbeiter ON(public.tbl_mitarbeiter.mitarbeiter_uid = public.tbl_benutzer.uid)
+		LEFT JOIN public.tbl_studiengang USING(studiengang_kz)
+		WHERE 
+			tbl_projektarbeit.student_uid = ? AND
 			(projekttyp_kurzbz='Bachelor' OR projekttyp_kurzbz='Diplom')
-		  AND betreuerart_kurzbz IN ('Betreuer', 'Begutachter', 'Erstbegutachter', 'Senatsvorsitz')) as base
-		ORDER BY insertamum DESC";
-				
+  		AND betreuerart_kurzbz IN ('Betreuer', 'Begutachter', 'Erstbegutachter', 'Senatsvorsitz')";
+		
 		return $this->execReadOnlyQuery($betreuerQuery, array($studentUID));
 	}
 
@@ -180,12 +168,8 @@ class Projektarbeit_model extends DB_Model
 					campus.tbl_paabgabe.fixtermin,
 					campus.tbl_paabgabe.kurzbz,
 					campus.tbl_paabgabe.datum,
-					campus.tbl_paabgabe.note,
-					campus.tbl_paabgabe.upload_allowed,
-					campus.tbl_paabgabe.beurteilungsnotiz,
 					campus.tbl_paabgabetyp.paabgabetyp_kurzbz, 
 					campus.tbl_paabgabetyp.bezeichnung, 
-					campus.tbl_paabgabetyp.benotbar, 
 					campus.tbl_paabgabe.abgabedatum,
 					campus.tbl_paabgabe.insertvon
 				FROM campus.tbl_paabgabe JOIN campus.tbl_paabgabetyp USING(paabgabetyp_kurzbz)
@@ -195,76 +179,16 @@ class Projektarbeit_model extends DB_Model
 		return $this->execReadOnlyQuery($qry, array($projektarbeit_id));
 	}
 
-	public function getProjektarbeitenAbgabetermine($projektarbeiten_ids) {
-		$qry ="SELECT campus.tbl_paabgabe.paabgabe_id, 
-					campus.tbl_paabgabe.projektarbeit_id,
-					campus.tbl_paabgabe.fixtermin,
-					campus.tbl_paabgabe.kurzbz,
-					campus.tbl_paabgabe.datum,
-					campus.tbl_paabgabe.note,
-					campus.tbl_paabgabe.upload_allowed,
-					campus.tbl_paabgabe.beurteilungsnotiz,
-					campus.tbl_paabgabetyp.paabgabetyp_kurzbz, 
-					campus.tbl_paabgabetyp.bezeichnung, 
-					campus.tbl_paabgabe.abgabedatum,
-					campus.tbl_paabgabe.insertvon
-				FROM campus.tbl_paabgabe JOIN campus.tbl_paabgabetyp USING(paabgabetyp_kurzbz)
-				WHERE campus.tbl_paabgabe.projektarbeit_id IN ?
-				ORDER BY campus.tbl_paabgabe.datum";
-
-		return $this->execReadOnlyQuery($qry, array($projektarbeiten_ids));
-	}
-
 	public function getProjektbetreuerAnrede($bperson_id) {
-		$qry_betr="SELECT DISTINCT ON(public.tbl_person.person_id) trim(COALESCE(titelpre,'')||' '||COALESCE(vorname,'')||' '||COALESCE(nachname,'')||' '||COALESCE(titelpost,'')) as first, anrede
-			FROM public.tbl_person JOIN lehre.tbl_projektbetreuer ON(lehre.tbl_projektbetreuer.person_id=public.tbl_person.person_id)
-			WHERE public.tbl_person.person_id= ?";
+		$qry_betr="SELECT distinct trim(COALESCE(titelpre,'')||' '||COALESCE(vorname,'')||' '||COALESCE(nachname,'')||' '||COALESCE(titelpost,'')) as first,
+						public.tbl_mitarbeiter.mitarbeiter_uid, anrede
+						FROM public.tbl_person JOIN lehre.tbl_projektbetreuer ON(lehre.tbl_projektbetreuer.person_id=public.tbl_person.person_id)
+						JOIN public.tbl_benutzer ON(public.tbl_benutzer.person_id=public.tbl_person.person_id)
+						JOIN public.tbl_mitarbeiter ON(public.tbl_benutzer.uid=public.tbl_mitarbeiter.mitarbeiter_uid)
+						WHERE public.tbl_person.person_id= ?";
 
 		return $this->execReadOnlyQuery($qry_betr, [$bperson_id]);
-	}
-	
-	public function getProjektbetreuerEmail($projektarbeit_id) {
-		$qry = "SELECT (
-				   SELECT kontakt
-				   FROM public.tbl_kontakt
-				   WHERE kontakttyp = 'email'
-					 AND person_id = pers.person_id
-				   ORDER BY
-					   CASE WHEN zustellung THEN 0 ELSE 1 END,
-					   insertamum DESC NULLS LAST
-				   LIMIT 1
-			   ) AS private_email, mitarbeiter_uid as uid
-		FROM lehre.tbl_projektarbeit pa
-				 JOIN lehre.tbl_projektbetreuer USING (projektarbeit_id)
-				 JOIN public.tbl_person pers USING (person_id)
-				 LEFT JOIN public.tbl_benutzer ben USING (person_id)
-				 LEFT JOIN public.tbl_mitarbeiter ma ON ben.uid = ma.mitarbeiter_uid
-		WHERE (ben.aktiv OR ben.aktiv IS NULL)
-		  AND projektarbeit_id = ?";
 
-		return $this->execReadOnlyQuery($qry, [$projektarbeit_id]);
-	}
-	
-	public function getProjektbetreuerEmailByPersonID($person_id) {
-		$qry = "SELECT (
-				   SELECT kontakt
-				   FROM public.tbl_kontakt
-				   WHERE kontakttyp = 'email'
-					 AND person_id = pers.person_id
-				   ORDER BY
-					   CASE WHEN zustellung THEN 0 ELSE 1 END,
-					   insertamum DESC NULLS LAST
-				   LIMIT 1
-			   ) AS private_email, mitarbeiter_uid as uid
-		FROM lehre.tbl_projektarbeit pa
-				 JOIN lehre.tbl_projektbetreuer USING (projektarbeit_id)
-				 JOIN public.tbl_person pers USING (person_id)
-				 LEFT JOIN public.tbl_benutzer ben USING (person_id)
-				 LEFT JOIN public.tbl_mitarbeiter ma ON ben.uid = ma.mitarbeiter_uid
-		WHERE (ben.aktiv OR ben.aktiv IS NULL)
-		  AND person_id = ?";
-
-		return $this->execReadOnlyQuery($qry, [$person_id]);
 	}
 
 	public function getProjektarbeitBenutzer($uid) {
@@ -299,9 +223,9 @@ class Projektarbeit_model extends DB_Model
 					*
 				FROM
 					(SELECT tbl_person.vorname, tbl_person.nachname, tbl_studiengang.typ, tbl_studiengang.kurzbz,
-							tbl_projektarbeit.projekttyp_kurzbz, tbl_projekttyp.bezeichnung, tbl_projektarbeit.titel, tbl_projektarbeit.projektarbeit_id, tbl_projektarbeit.note,
-							tbl_projektbetreuer.person_id as betreuer_person_id, tbl_projektbetreuer.betreuerart_kurzbz, tbl_betreuerart.beschreibung AS betreuerart_beschreibung,
-							tbl_benutzer.uid, tbl_student.matrikelnr, tbl_lehreinheit.studiensemester_kurzbz, public.tbl_student.student_uid
+							tbl_projektarbeit.projekttyp_kurzbz, tbl_projekttyp.bezeichnung, tbl_projektarbeit.titel, tbl_projektarbeit.projektarbeit_id,
+							tbl_projektbetreuer.betreuerart_kurzbz, tbl_betreuerart.beschreibung AS betreuerart_beschreibung,
+							tbl_benutzer.uid, tbl_student.matrikelnr, tbl_lehreinheit.studiensemester_kurzbz
 					 FROM lehre.tbl_projektarbeit
 							  LEFT JOIN lehre.tbl_projektbetreuer using(projektarbeit_id)
 							  LEFT JOIN lehre.tbl_betreuerart using(betreuerart_kurzbz)
@@ -338,134 +262,7 @@ class Projektarbeit_model extends DB_Model
 		
 		return $this->execReadOnlyQuery($qry, array($projektarbeit_id));
 	}
-	
-	
-	public function getProjektarbeitenForStudiengang($studiengang_kz, $benotet) {
-		$new_qry = "SELECT DISTINCT ON(tmp.projektarbeit_id) *, campus.get_betreuer_details(tmp.zweitbetreuer_person_id) as zweitbetreuer_full_name, campus.get_betreuer_details(tmp.betreuer_person_id) as erstbetreuer_full_name
-       		FROM(
-			   SELECT
-				   DISTINCT ON(tbl_projektarbeit.projektarbeit_id)
-				   tbl_projektarbeit.projekttyp_kurzbz,
-				   tbl_projektarbeit.titel,
-				   tbl_projektarbeit.projektarbeit_id,
-				   tbl_studiengang.typ, tbl_studiengang.kurzbz,
-				   student_benutzer.uid as student_uid,
-				   student_person.vorname as student_vorname,
-				   student_person.nachname as student_nachname,
-				   tbl_student.matrikelnr, tbl_lehreinheit.studiensemester_kurzbz,
-				   betreuer_benutzer.uid as betreuer_benutzer_uid,
-				   betreuer_person.vorname as betreuer_vorname,
-				   betreuer_person.nachname as betreuer_nachname,
-				   lehre.tbl_projektbetreuer.betreuerart_kurzbz as betreuerart,
-				   lehre.tbl_projektbetreuer.person_id as betreuer_person_id,
-				   lehre.tbl_projektarbeit.sprache               as sprache,
-				   lehre.tbl_projektarbeit.seitenanzahl          as seitenanzahl,
-				   lehre.tbl_projektarbeit.kontrollschlagwoerter as kontrollschlagwoerter,
-				   lehre.tbl_projektarbeit.schlagwoerter         as schlagwoerter,
-				   lehre.tbl_projektarbeit.schlagwoerter_en      as schlagwoerter_en,
-				   lehre.tbl_projektarbeit.abstract              as abstract,
-				   lehre.tbl_projektarbeit.abstract_en           as abstract_en,
-				   lehre.tbl_projektarbeit.insertamum            as insertamum,
-				   lehre.tbl_projektarbeit.note					 as note,
-				   (
-					   SELECT orgform_kurzbz
-					   FROM tbl_prestudentstatus
-					   WHERE prestudent_id = (SELECT prestudent_id
-											  FROM tbl_student
-											  WHERE student_uid = student_benutzer.uid
-											  LIMIT 1)
-					   ORDER BY datum DESC, insertamum DESC, ext_id DESC
-					   LIMIT 1
-				   )
-					   as organisationsform,
-				   (
-					   SELECT person_id
-					   FROM lehre.tbl_projektbetreuer
-					   WHERE projektarbeit_id = tbl_projektarbeit.projektarbeit_id
-						 AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter', 'Senatsmitglied')
-					   LIMIT 1
-				   )
-					   AS zweitbetreuer_person_id,
-				   (
-					   SELECT betreuerart_kurzbz
-					   FROM lehre.tbl_projektbetreuer
-					   WHERE projektarbeit_id = tbl_projektarbeit.projektarbeit_id
-						 AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter', 'Senatsmitglied')
-					   LIMIT 1
-				   )
-					   AS zweitbetreuer_betreuerart_kurzbz,
-				   (
-					   SELECT tbl_betreuerart.beschreibung
-					   FROM lehre.tbl_projektbetreuer
-								JOIN lehre.tbl_betreuerart USING (betreuerart_kurzbz)
-					   WHERE projektarbeit_id = tbl_projektarbeit.projektarbeit_id
-						 AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter', 'Senatsmitglied')
-					   LIMIT 1
-				   )
-					   AS zweitbetreuer_betreuerart_beschreibung,
-				   (
-					   SELECT trim(COALESCE(titelpre, '') || ' ' || COALESCE(vorname, '') || ' ' || COALESCE(nachname, '') || ' ' ||
-								   COALESCE(titelpost, ''))
-					   FROM public.tbl_person
-								JOIN lehre.tbl_projektbetreuer ON (lehre.tbl_projektbetreuer.person_id = public.tbl_person.person_id)
-								LEFT JOIN public.tbl_benutzer ON (public.tbl_benutzer.person_id = public.tbl_person.person_id)
-								LEFT JOIN public.tbl_mitarbeiter ON (public.tbl_benutzer.uid = public.tbl_mitarbeiter.mitarbeiter_uid)
-					   WHERE projektarbeit_id = tbl_projektarbeit.projektarbeit_id
-						 AND betreuerart_kurzbz IN ('Zweitbetreuer', 'Zweitbegutachter', 'Senatsmitglied')
-					   LIMIT 1
-				   )
-					   as zweitbetreuer_full_name,
-			       (
-					   SELECT
-						   COALESCE(tbl_studienplan.orgform_kurzbz,
-									tbl_prestudentstatus.orgform_kurzbz, tbl_studiengang.orgform_kurzbz) as
-							   orgform
-					   FROM
-						   public.tbl_prestudent
-							   JOIN public.tbl_prestudentstatus USING(prestudent_id)
-							   JOIN public.tbl_studiensemester USING(studiensemester_kurzbz)
-							   JOIN public.tbl_studiengang USING(studiengang_kz)
-							   LEFT JOIN lehre.tbl_studienplan USING(studienplan_id)
-					   WHERE
-						   prestudent_id=tbl_student.prestudent_id
-					   ORDER BY tbl_prestudentstatus.datum DESC LIMIT 1
-				   ) as orgform,
-				   (SELECT status_kurzbz FROM public.tbl_prestudentstatus
-					WHERE prestudent_id=tbl_student.prestudent_id
-					ORDER BY datum DESC, insertamum DESC, ext_id DESC LIMIT 1) as studienstatus
-			   FROM lehre.tbl_projektarbeit
-						LEFT JOIN public.tbl_benutzer student_benutzer ON (student_benutzer.uid = lehre.tbl_projektarbeit.student_uid)
-						LEFT JOIN public.tbl_person student_person ON (student_benutzer.person_id = student_person.person_id)
-						LEFT JOIN public.tbl_student on(student_benutzer.uid = public.tbl_student.student_uid)
-						LEFT JOIN lehre.tbl_lehreinheit USING (lehreinheit_id)
-						LEFT JOIN lehre.tbl_lehrveranstaltung USING (lehrveranstaltung_id)
-						LEFT JOIN public.tbl_studiengang ON (public.tbl_student.studiengang_kz = public.tbl_studiengang.studiengang_kz)
-						LEFT JOIN lehre.tbl_projekttyp USING (projekttyp_kurzbz)
-						LEFT JOIN lehre.tbl_projektbetreuer USING (projektarbeit_id)
-						LEFT JOIN public.tbl_person betreuer_person ON (betreuer_person.person_id = lehre.tbl_projektbetreuer.person_id)
-						LEFT JOIN public.tbl_benutzer betreuer_benutzer ON (betreuer_person.person_id = betreuer_benutzer.person_id)
-			   WHERE (projekttyp_kurzbz = 'Bachelor' OR projekttyp_kurzbz = 'Diplom')
-				 AND student_benutzer.aktiv AND (
-				     lehre.tbl_projektbetreuer.betreuerart_kurzbz = 'Erstbegutachter' 
-				     OR lehre.tbl_projektbetreuer.betreuerart_kurzbz = 'Begutachter'
-				     OR lehre.tbl_projektbetreuer.betreuerart_kurzbz = 'Betreuer'
-				     OR lehre.tbl_projektbetreuer.betreuerart_kurzbz = 'Erstbetreuer'
-				     OR lehre.tbl_projektbetreuer.betreuerart_kurzbz = 'Senatsvorsitz'
-				     )
-				 AND public.tbl_studiengang.studiengang_kz = ?";
-		
-			     if($benotet == 0) {
-					 $new_qry .= " AND lehre.tbl_projektarbeit.note IS NULL ";
-				 } else if ($benotet == 1) {
-					 $new_qry .= " AND lehre.tbl_projektarbeit.note IS NOT NULL ";
-				 }
-				 
-			   $new_qry .= " ORDER BY tbl_projektarbeit.projektarbeit_id DESC, student_person.nachname ASC           
-		   ) as tmp";
-		
-		return $this->execReadOnlyQuery($new_qry, array($studiengang_kz));
-	}
-	
+
 	/**
 	 *
 	 * @param
@@ -491,17 +288,4 @@ class Projektarbeit_model extends DB_Model
 
 		return false;
 	}
-
-	public function getProjektarbeitByPaabgabeID($paabgabe_id) {
-		$qry = "SELECT
-					projektarbeit_id
-				FROM
-					campus.tbl_paabgabe
-					JOIN lehre.tbl_projektarbeit USING(projektarbeit_id)
-				WHERE
-					campus.tbl_paabgabe.paabgabe_id = ?;
-		";
-
-		return $this->execReadOnlyQuery($qry, [$paabgabe_id]);
-	}
 }

application/models/education/Projektbetreuer_model.php

@@ -232,41 +232,4 @@ class Projektbetreuer_model extends DB_Model
 
 		return $this->execQuery($qry, array($projektarbeit_id, $betreuer_person_id));
 	}
-
-	/**
-	 * Gets all Betreuer of a Projektarbeit.
-	 * Returns one row for each person.
-	 * @param int $projektarbeit_id
-	 * @return array success with number of Betreuer or error
-	 */
-	public function getAllBetreuerOfProjektarbeit($projektarbeit_id)
-	{
-		$qry = "SELECT DISTINCT ON (pers.person_id) pers.person_id, betreuerart_kurzbz, vorname, nachname,
-				trim(COALESCE(titelpre,'')||' '||COALESCE(vorname,'')||' '||COALESCE(nachname,'')||' '||COALESCE(titelpost,'')) as voller_name,
-				anrede, titelpre, titelpost, gebdatum, geschlecht, pa.projekttyp_kurzbz,
-				ben.uid, ben.alias, ma.personalnummer, mitarbeiter_uid, student_uid,
-				(
-					SELECT kontakt
-					FROM public.tbl_kontakt
-					WHERE kontakttyp = 'email'
-					AND person_id = pers.person_id
-					ORDER BY
-						CASE WHEN zustellung THEN 0 ELSE 1 END,
-						insertamum DESC NULLS LAST
-					LIMIT 1
-				) AS private_email
-				FROM lehre.tbl_projektarbeit pa
-				JOIN lehre.tbl_projektbetreuer USING (projektarbeit_id)
-				JOIN public.tbl_person pers USING (person_id)
-				LEFT JOIN public.tbl_benutzer ben USING (person_id)
-				LEFT JOIN public.tbl_mitarbeiter ma ON ben.uid = ma.mitarbeiter_uid
-				WHERE (ben.aktiv OR ben.aktiv IS NULL)
-				AND projektarbeit_id = ?
-				ORDER BY pers.person_id, CASE WHEN ma.mitarbeiter_uid IS NULL THEN 1 ELSE 0 END, /*Mitarbeiter account first*/
-						CASE WHEN ben.uid IS NULL THEN 1 ELSE 0 END, /*user with account first*/
-						ben.insertamum";
-
-		return $this->execQuery($qry, array($projektarbeit_id));
-	}
-
 }

application/models/organisation/Organisationseinheit_model.php

@@ -243,20 +243,4 @@ class Organisationseinheit_model extends DB_Model
 
 		return $this->execReadOnlyQuery($qry, array($oe_kurzbz));
 	}
-	
-	public function getAssistenzForOE($oe_kurzbz) {
-		$qry = "
-			SELECT person_id, uid, benutzerfunktion_id, funktion_kurzbz, oe_kurzbz, alias, 
-       			anrede, trim(COALESCE(titelpre,'')||' '||COALESCE(vorname,'')||' '||COALESCE(nachname,'')||' '||COALESCE(titelpost,'')) as first
-			FROM tbl_benutzerfunktion
-					 JOIN public.tbl_benutzer USING(uid)
-					 JOIN public.tbl_person USING(person_id)
-			WHERE funktion_kurzbz = 'ass'
-				AND oe_kurzbz = ?
-				AND (datum_bis IS NULL OR NOW() <= datum_bis)
-				AND public.tbl_benutzer.aktiv = true
-		";
-
-		return $this->execReadOnlyQuery($qry, array($oe_kurzbz));
-	}
 }

application/models/organisation/Studiengang_model.php

@@ -657,7 +657,37 @@ class Studiengang_model extends DB_Model
 		$this->load->model('person/Benutzerfunktion_model', 'BenutzerfunktionModel');
 		$this->load->model('person/Person_model', 'PersonModel');
 		$this->load->model('crm/Student_model', 'StudentModel');
+
+		$addEmailProperty= function(&$benutzerfunktionen){
+			if(count($benutzerfunktionen) && defined('DOMAIN'))
+			{
+				$benutzerfunktionen = array_map(function($benutzer)
+				{
+					$benutzer->email = $benutzer->alias."@".DOMAIN;
+					return $benutzer;
+				},$benutzerfunktionen) ;
+			}
+
+		};
+		$addFotoProperty= function(&$collection){
+			$collection = array_map(function($item){
+				$person_id = $this->PersonModel->getByUid($item->uid);
+				if(isError($person_id))
+					return error($person_id);
+				$person_id = current(getData($person_id))->person_id;
+				$this->PersonModel->addSelect('foto');
+				$foto = $this->PersonModel->loadWhere(array('person_id'=>$person_id));
+				if(isError($foto))
+					return error($foto);	
+				$foto = current(getData($foto))->foto;
+				$item->foto = $foto;
+				return $item;
+			},$collection);
+		};
 		
+
+		$this->load->model('crm/Student_model', 'StudentModel');
+
 		$student = $this->StudentModel->loadWhere(['student_uid' => getAuthUID()]);
 		if (isError($student))
 			return error($student);
@@ -682,7 +712,7 @@ class Studiengang_model extends DB_Model
 		$stg_ltg = array_values(array_filter($stg_ltg, function($stg_leitung){
 			return $stg_leitung->aktiv;
 		}));
-		$this->addFotoProperty($stg_ltg);
+		$addFotoProperty($stg_ltg);
 
 		$gf_ltg = $this->BenutzerfunktionModel->getBenutzerFunktionenDetailed('gLtg', $stg_obj->oe_kurzbz);
 		if (isError($gf_ltg))
@@ -691,8 +721,8 @@ class Studiengang_model extends DB_Model
 		$gf_ltg = array_values(array_filter($gf_ltg, function($gf_leitung){
 			return $gf_leitung->aktiv;
 		}));
-		$this->addEmailProperty($gf_ltg);
-		$this->addFotoProperty($gf_ltg);
+		$addEmailProperty($gf_ltg);
+		$addFotoProperty($gf_ltg);
 
 		$stv_ltg = $this->BenutzerfunktionModel->getBenutzerFunktionenDetailed('stvLtg', $stg_obj->oe_kurzbz);
 		if (isError($stv_ltg))
@@ -701,8 +731,8 @@ class Studiengang_model extends DB_Model
 		$stv_ltg = array_values(array_filter($stv_ltg, function($stv_leitung){
 			return $stv_leitung->aktiv;
 		}));
-		$this->addEmailProperty($stv_ltg);
-		$this->addFotoProperty($stv_ltg);
+		$addEmailProperty($stv_ltg);
+		$addFotoProperty($stv_ltg);
 
 		$ass = $this->BenutzerfunktionModel->getBenutzerFunktionenDetailed('ass', $stg_obj->oe_kurzbz);
 		if (isError($ass))
@@ -711,8 +741,8 @@ class Studiengang_model extends DB_Model
 		$ass = array_values(array_filter($ass, function($assistenz){
 			return $assistenz->aktiv;
 		}));
-		$this->addEmailProperty($ass);
-		$this->addFotoProperty($ass);
+		$addEmailProperty($ass);
+		$addFotoProperty($ass);
 
 		$hochschulvertr = $this->BenutzerfunktionModel->getBenutzerFunktionenDetailed('hsv');
 		if (isError($hochschulvertr))
@@ -721,7 +751,7 @@ class Studiengang_model extends DB_Model
 		$hochschulvertr = array_values(array_filter($hochschulvertr, function($hochschul_vertreter){
 			return $hochschul_vertreter->aktiv;
 		}));
-		$this->addEmailProperty($hochschulvertr);
+		$addEmailProperty($hochschulvertr);
 
 
 		$stdv = $this->BenutzerfunktionModel->getBenutzerFunktionenDetailed('stdv', $stg_obj->oe_kurzbz);
@@ -731,7 +761,7 @@ class Studiengang_model extends DB_Model
 		$stdv = array_values(array_filter($stdv, function($std_vertreter){
 			return $std_vertreter->aktiv;
 		}));
-		$this->addEmailProperty($stdv);
+		$addEmailProperty($stdv);
 
 
 		$jahrgangsvertr = $this->BenutzerfunktionModel->getBenutzerFunktionenDetailed('jgv', $stg_obj->oe_kurzbz, $semester);
@@ -741,7 +771,7 @@ class Studiengang_model extends DB_Model
 		$jahrgangsvertr = array_values(array_filter($jahrgangsvertr, function($jahrgang_vertreter){
 			return $jahrgang_vertreter->aktiv;
 		}));
-		$this->addEmailProperty($jahrgangsvertr);
+		$addEmailProperty($jahrgangsvertr);
 
 
 		$result_object = new stdClass();
@@ -771,141 +801,4 @@ class Studiengang_model extends DB_Model
 
 		return $this->execReadOnlyQuery($qry, array($studiengang_kz, $orgform_kurzbz, $studiensemester_kurzbz));
 	}
-
-	/**
-	 * Get active Studiengänge with Kuerzel by given Studiengang-Kennzahlen.
-	 * Helpful to easily get Studiengänge the user is entitled for.
-	 *
-	 * @param $studiengang_kz_arr
-	 * @param $studiensemester_kurzbz
-	 * @return array|stdClass|null	Returns one row per Studiengang. Not considering the Orgforms.
-	 */
-	public function getByStgs($studiengang_kz_arr, $studiensemester_kurzbz)
-	{
-		if (is_numeric($studiengang_kz_arr))
-		{
-			$studiengang_kz_arr = [$studiengang_kz_arr];
-		}
-
-		$qry = '
-			SELECT
-				DISTINCT stg.*, UPPER(typ::varchar(1) || kurzbz) AS kuerzel
-			FROM
-				public.tbl_studiengang stg
-				JOIN lehre.tbl_studienordnung sto USING(studiengang_kz)
-				JOIN lehre.tbl_studienplan stpl USING(studienordnung_id)
-				JOIN lehre.tbl_studienplan_semester stplsem USING(studienplan_id)
-			WHERE
-				stg.studiengang_kz IN ?
-				AND stplsem.studiensemester_kurzbz = ?
-			ORDER BY
-				stg.kurzbzlang
-		';
-
-		return $this->execQuery($qry, [$studiengang_kz_arr, $studiensemester_kurzbz]);
-	}
-
-	/**
-	 * Get OrgForms of given Studiengang and Studiensemester.
-	 *
-	 * @param $studiengang_kz
-	 * @param $studiensemester_kurzbz
-	 * @return array|stdClass|null
-	 */
-	public function getOrgformsByStg($studiengang_kz, $studiensemester_kurzbz)
-	{
-		$qry = '
-			SELECT
-				stpl.orgform_kurzbz
-			FROM
-				public.tbl_studiengang stg
-				JOIN lehre.tbl_studienordnung sto USING(studiengang_kz)
-				JOIN lehre.tbl_studienplan stpl USING(studienordnung_id)
-				JOIN lehre.tbl_studienplan_semester stplsem USING(studienplan_id)
-			WHERE
-				stg.studiengang_kz = ?
-				AND stg.aktiv = TRUE
-				AND stplsem.studiensemester_kurzbz = ?
-			GROUP BY
-				stpl.orgform_kurzbz
-			ORDER BY
-				CASE stpl.orgform_kurzbz
-					WHEN \'VZ\' THEN 1
-					WHEN \'BB\' THEN 2
-					WHEN \'DUA\' THEN 3
-					ELSE 4
-				END,
-				stpl.orgform_kurzbz; 
-		';
-
-		return $this->execQuery($qry, [$studiengang_kz, $studiensemester_kurzbz]);
-	}
-	
-	public function getStudiengaengeFiltered($allowed_stg) {
-		$query ="SELECT DISTINCT
-					public.tbl_studiengang.studiengang_kz,
-					public.tbl_studiengang.bezeichnung,
-					public.tbl_studiengang.kurzbzlang,
-					public.tbl_studiengang.orgform_kurzbz
-				FROM public.tbl_studiengang JOIN lehre.tbl_studienordnung USING(studiengang_kz)
-					JOIN lehre.tbl_studienplan USING(studienordnung_id)
-					JOIN lehre.tbl_studienplan_semester USING(studienplan_id)
-				WHERE public.tbl_studiengang.aktiv = true
-				
-				AND public.tbl_studiengang.studiengang_kz IN ?
-				ORDER BY public.tbl_studiengang.kurzbzlang";
-
-		return $this->execReadOnlyQuery($query, [$allowed_stg]);
-	}
-	
-	public function getAssistenzForStudiengangKZ($stg_kz) {
-		$this->load->model('person/Benutzerfunktion_model', 'BenutzerfunktionModel');
-		
-		$stg_obj = $this->load($stg_kz);
-		if(isError($stg_obj))
-			return error($stg_obj);
-		if(getData($stg_obj))
-		{
-			$stg_obj = current(getData($stg_obj));
-		}
-
-		$ass = $this->BenutzerfunktionModel->getBenutzerFunktionenDetailed('ass', $stg_obj->oe_kurzbz);
-		if (isError($ass))
-			return $ass;
-		$ass = getData($ass) ?: [];
-		$ass = array_values(array_filter($ass, function($assistenz){
-			return $assistenz->aktiv;
-		}));
-		
-		$this->addEmailProperty($ass);
-		
-		return success($ass);
-	}
-	
-	private function addEmailProperty(&$benutzerfunktionen) {
-		if(count($benutzerfunktionen) && defined('DOMAIN'))
-		{
-			$benutzerfunktionen = array_map(function($benutzer)
-			{
-				$benutzer->email = $benutzer->alias."@".DOMAIN;
-				return $benutzer;
-			},$benutzerfunktionen) ;
-		}
-	}
-	
-	private function addFotoProperty (&$collection) {
-		$collection = array_map(function($item){
-			$person_id = $this->PersonModel->getByUid($item->uid);
-			if(isError($person_id))
-				return error($person_id);
-			$person_id = current(getData($person_id))->person_id;
-			$this->PersonModel->addSelect('foto');
-			$foto = $this->PersonModel->loadWhere(array('person_id'=>$person_id));
-			if(isError($foto))
-				return error($foto);
-			$foto = current(getData($foto))->foto;
-			$item->foto = $foto;
-			return $item;
-		},$collection);
-	}
 }

application/models/person/Person_model.php

@@ -420,20 +420,4 @@ class Person_model extends DB_Model
 			return success($result);
 		}
 	}
-
-	public function loadAllStudentUIDSForPersonID($person_id) {
-		$qry = "SELECT
-			CONCAT(tp.vorname, ' ', tp.nachname) AS name,
-			ARRAY_AGG(DISTINCT b.uid ORDER BY b.uid) AS uids,
-			ARRAY_AGG(DISTINCT CONCAT(stg.typ, stg.kurzbz)) AS stg_oes,
-			s.semester
-		FROM public.tbl_student s
-				 JOIN public.tbl_benutzer b ON s.student_uid = b.uid
-				 JOIN public.tbl_person tp ON b.person_id = tp.person_id
-				 JOIN public.tbl_studiengang stg ON s.studiengang_kz = stg.studiengang_kz 
-		GROUP BY tp.vorname, tp.nachname, b.aktiv, b.person_id, s.semester
-		HAVING b.person_id = ? AND b.aktiv IS TRUE";
-		
-		return $this->execReadOnlyQuery($qry, [$person_id]);
-	}
 }

application/models/person/Profil_update_model.php

@@ -135,8 +135,7 @@ class Profil_update_model extends DB_Model
 				attachment_id,
 				UPPER(public.tbl_studiengang.typ || public.tbl_studiengang.kurzbz) AS studiengang,
 				COALESCE(of.orgform_kurzbz, public.tbl_studiengang.orgform_kurzbz) AS orgform,
-				NULL as oezuordnung,
-				tbl_student.semester
+				NULL as oezuordnung
 			FROM public.tbl_profil_update
 			JOIN public.tbl_profil_update_status ON public.tbl_profil_update_status.status_kurzbz = public.tbl_profil_update.status 
 			JOIN public.tbl_student ON public.tbl_student.student_uid=public.tbl_profil_update.uid

application/models/ressource/Stundenplan_model.php

@@ -470,12 +470,12 @@ class Stundenplan_model extends DB_Model
 				}
 				foreach($studentlehrverbaende[$sem_date] as $key=>$lehrverband)
 				{
-					$query .= "(((sp.studiengang_kz = ".$this->escape($lehrverband->studiengang_kz)." AND sp.semester = ".$this->escape($lehrverband->semester)." AND sp.verband = ".$this->escape($lehrverband->verband)." AND sp.gruppe = ".$this->escape($lehrverband->gruppe)." AND sp.datum BETWEEN ".$this->escape($sem_date_range->start)." AND ".$this->escape($sem_date_range->ende).")";
+					$query .= "((sp.studiengang_kz = ".$this->escape($lehrverband->studiengang_kz)." AND sp.semester = ".$this->escape($lehrverband->semester)." AND sp.verband = ".$this->escape($lehrverband->verband)." AND sp.gruppe = ".$this->escape($lehrverband->gruppe)." AND sp.datum BETWEEN ".$this->escape($sem_date_range->start)." AND ".$this->escape($sem_date_range->ende).")";
 					// Eintraege fuer den ganzen Verband
 					$query .= "OR (sp.studiengang_kz = ".$this->escape($lehrverband->studiengang_kz)." AND sp.semester = ".$this->escape($lehrverband->semester)." AND sp.verband = ".$this->escape($lehrverband->verband)." AND (sp.gruppe is null OR sp.gruppe='') AND sp.datum BETWEEN ".$this->escape($sem_date_range->start)." AND ".$this->escape($sem_date_range->ende).")";
 					// Eintraege fuer das ganze Semester
 					$query .= "OR (sp.studiengang_kz = ".$this->escape($lehrverband->studiengang_kz)." AND sp.semester = ".$this->escape($lehrverband->semester)." AND (sp.verband is null OR sp.verband='') AND sp.datum BETWEEN ".$this->escape($sem_date_range->start)
-						." AND ".$this->escape($sem_date_range->ende).")) AND gruppe_kurzbz is null)";
+						." AND ".$this->escape($sem_date_range->ende).")". $stringGroupLv. ")";
 
 					$query .="OR";
 				}
@@ -535,53 +535,4 @@ class Stundenplan_model extends DB_Model
 
 		return $this->execQuery($query, [$uid, $uid]);
 	}
-
-	/**
-	 * Get Stundenplantermine for given Lehreinheit.
-	 *
-	 * @param $lehreinheit_id
-	 * @return array|stdClass|null
-	 */
-	public function getTermineByLe($lehreinheit_id)
-	{
-		$qry = '
-			SELECT DISTINCT
-			    datum
-			FROM 
-		       	lehre.vw_stundenplan
-			WHERE 
-				lehreinheit_id = ?
-			ORDER BY 
-			    datum ASC
-		';
-
-		return $this->execQuery($qry, [$lehreinheit_id]);
-	}
-
-	/**
-	 * Get Stundenplantermine for given Lehrveranstaltung of given Studiensemester.
-	 *
-	 * @param $lehrveranstaltung_id
-	 * @param $studiensemester_kurzbz
-	 * @return array|stdClass|null
-	 */
-	public function getTermineByLv($lehrveranstaltung_id, $studiensemester_kurzbz)
-	{
-		$qry = '
-		  	SELECT DISTINCT
-				datum
-	   		FROM
-	   		    lehre.vw_stundenplan
-	  		WHERE 
-	  		    lehreinheit_id IN (
-					SELECT lehreinheit_id
-					FROM lehre.tbl_lehreinheit 
-					WHERE lehrveranstaltung_id = ?
-					AND studiensemester_kurzbz = ?
-				)    
-	   		ORDER BY datum ASC
-		';
-
-		return $this->execQuery($qry, [$lehrveranstaltung_id, $studiensemester_kurzbz]);
-	}
 }

application/models/ressource/Stundensatz_model.php

@@ -47,6 +47,7 @@ class Stundensatz_model extends DB_Model
 	{
 		$this->load->config('stv');
 
+		$useFixangestelltStundensatz = $this->config->item('tabs')['projektarbeit']['lvLektroinnenzuteilungFixangestelltStundensatz'];
 		$defaultStundensatz = $this->config->item('tabs')['projektarbeit']['defaultProjektbetreuerStundensatz'];
 
 		$stundensatz = '';
@@ -62,7 +63,7 @@ class Stundensatz_model extends DB_Model
 			{
 				$studiensemester = getData($result)[0];
 
-				if (defined('FAS_LV_LEKTORINNENZUTEILUNG_FIXANGESTELLT_STUNDENSATZ') && !FAS_LV_LEKTORINNENZUTEILUNG_FIXANGESTELLT_STUNDENSATZ)
+				if (isset($useFixangestelltStundensatz) && !$useFixangestelltStundensatz)
 				{
 					// load Mitarbeiter
 					$params = [$person_id];
@@ -82,30 +83,19 @@ class Stundensatz_model extends DB_Model
 
 					if (hasData($result))
 					{
-						$ma = getData($result)[0];
-
-						$this->load->model('vertragsbestandteil/Dienstverhaeltnis_model','DienstverhaeltnisModel');
-						$echterdv_result = $this->DienstverhaeltnisModel->existsDienstverhaeltnis(
-							$ma->mitarbeiter_uid,
-							$studiensemester->start,
-							$studiensemester->ende,
-							'echterdv'
-						);
-
-						if (hasData($echterdv_result))
+						foreach (getData($result) as $ma)
 						{
-							$stundensatz = null;
-						}
-						else
-						{
-							$stundensatzRes = $this->getStundensatzByDatum(
-								$ma->mitarbeiter_uid, $studiensemester->start, $studiensemester->ende, 'lehre'
-							);
+							if (!$ma->fixangestellt)
+							{
+								$stundensatzRes = $this->getStundensatzByDatum(
+									$ma->mitarbeiter_uid, $studiensemester->start, $studiensemester->ende, 'lehre'
+								);
 
-							if (hasData($stundensatzRes))
-								$stundensatz = getData($stundensatzRes)[0]->stundensatz;
-							else
-								$stundensatz = '0.00';
+								if (hasData($stundensatzRes))
+									$stundensatz = getData($stundensatzRes)[0]->stundensatz;
+								else
+									$stundensatz = '0.00';
+							}
 						}
 					}
 					else

application/models/system/Message_model.php

@@ -242,89 +242,74 @@ class Message_model extends DB_Model
 	 */
 	public function getMessagesForTable($person_id, $offset, $limit)
 	{
-		$sql = <<<EOSQL
-			with filtered_messages as (
-				select
-					m.message_id, m.person_id as sender_id, mr.person_id as recipient_id
-				from
-					public.tbl_msg_message m
-				join
-					public.tbl_msg_recipient mr on mr.message_id = m.message_id
-				where
-					m.person_id = ?
-				group by
-					m.message_id, m.person_id, mr.person_id
-
-				union all
-
-				select
-					m.message_id, m.person_id as sender_id, mr.person_id as recipient_id
-				from
-					public.tbl_msg_message m
-				join
-					public.tbl_msg_recipient mr on mr.message_id = m.message_id
-				where
-					mr.person_id = ?
-				group by
-					m.message_id, m.person_id, mr.person_id
-
-			), lastmsgstatus as (
-				select
-					ms.*
-				from (
-						select
-							s.message_id, s.person_id, MAX(s.insertamum) as lastinserted
-						from
-							public.tbl_msg_status s
-						group by
-							s.message_id, s.person_id
-					) ls
-				join
-					public.tbl_msg_status ms on ms.message_id = ls.message_id and ms.person_id = ls.person_id and ms.insertamum = ls.lastinserted
-			)
-
-			select
-				(select count(*) from filtered_messages) as total_msgs,
+		$sql_base = "
+			SELECT
 				m.message_id AS message_id,
 				m.subject AS subject,
 				m.body AS body,
 				m.insertamum AS insertamum,
 				m.relationmessage_id AS relationmessage_id,
-				(COALESCE(ps.titelpre,'') || ' ' || COALESCE(ps.vorname,'') || ' ' || COALESCE(ps.nachname,'') || ' ' || COALESCE(ps.titelpost,'')) as sender,
-				(COALESCE(pr.titelpre,'') || ' ' || COALESCE(pr.vorname,'') || ' ' || COALESCE(pr.nachname,'') || ' ' || COALESCE(pr.titelpost,'')) as recipient,
-				fm.sender_id,
-				fm.recipient_id,
-				ms.status,
-				ms.insertamum as statusdatum
-			from
-				filtered_messages fm
-			join
-				public.tbl_msg_message m on fm.message_id = m.message_id
-			join
-				lastmsgstatus ms on fm.message_id = ms.message_id and fm.recipient_id = ms.person_id
-			left join
-				public.tbl_person ps on ps.person_id = fm.sender_id
-			left join
-				public.tbl_person pr on pr.person_id = fm.recipient_id
-			order by
-				m.insertamum DESC
-			limit ?
-			offset ?;
-EOSQL;
+				(SELECT COALESCE(titelpre,'') || ' ' || COALESCE(vorname,'') || ' ' || COALESCE(nachname,'') || ' ' || COALESCE(titelpost,'') FROM public.tbl_person WHERE person_id = m.person_id) as sender,
+				(SELECT COALESCE(titelpre,'') || ' ' || COALESCE(vorname,'') || ' ' || COALESCE(nachname,'') || ' ' || COALESCE(titelpost,'') FROM public.tbl_person WHERE person_id = r.person_id) as recipient,
+				m.person_id as sender_id,
+				r.person_id as recipient_id,
+				MAX(ss.status) as status,
+				MAX(ss.insertamum) as statusdatum
+			FROM public.tbl_msg_message m
+				 JOIN public.tbl_msg_recipient r USING(message_id)
+				 JOIN public.tbl_msg_status ss ON(r.message_id = ss.message_id AND ss.person_id = r.person_id)
+			WHERE m.person_id = ?
+			GROUP BY m.message_id, m.subject, m.body, m.insertamum, m.relationmessage_id, sender, recipient, sender_id, recipient_id
+			UNION ALL
+			SELECT
+				m.message_id AS message_id,
+				m.subject AS subject,
+				m.body AS body,
+				m.insertamum AS insertamum,
+				m.relationmessage_id AS relationmessage_id,
+				(SELECT COALESCE(titelpre,'') || ' ' || COALESCE(vorname,'') || ' ' || COALESCE(nachname,'') || ' ' || COALESCE(titelpost,'') FROM public.tbl_person WHERE person_id = m.person_id) as sender,
+				(SELECT COALESCE(titelpre,'') || ' ' || COALESCE(vorname,'') || ' ' || COALESCE(nachname,'') || ' ' || COALESCE(titelpost,'') FROM public.tbl_person WHERE person_id = r.person_id) as recipient,
+				m.person_id as sender_id,
+				r.person_id as recipient_id,
+				MAX(ss.status) as status,
+				MAX(ss.insertamum) as statusdatum
+			FROM public.tbl_msg_recipient r
+				 JOIN public.tbl_msg_status ss USING(message_id, person_id)
+				 JOIN public.tbl_msg_message m USING(message_id)
+			WHERE r.person_id = ?
+			GROUP BY m.message_id, m.subject, m.body, m.insertamum, m.relationmessage_id, sender, recipient, sender_id, recipient_id
+				 ";
+		$sql = "
+			SELECT COUNT(*) AS count FROM (
+				" . $sql_base . "
+			) a
+				 ";
+
+		$parametersArray = array($person_id, $person_id);
+
+		$count = $this->execQuery($sql, $parametersArray);
+
+		if (isError($count))
+			return $count;
+
+		$count = ceil(current(getData($count))->count/$limit);
+		$sql = "
+			SELECT * FROM (
+				" . $sql_base . "
+			) a
+			ORDER BY insertamum DESC
+			LIMIT ?
+			OFFSET ?
+				 ";
 
 		$parametersArray = array($person_id, $person_id, $limit, $offset);
 
-		$count = 0;
 		$data = $this->execQuery($sql, $parametersArray);
 
 		if (isError($data))
 			return $data;
 
 		$data = getData($data);
-		if($data)
-		{
-			$count = ceil($data[0]->total_msgs / $limit);
-		}
 
 		return success(['data' => $data, 'count' => $count]);
 	}

application/models/vertragsbestandteil/Gehaltsbestandteil_model.php

@@ -286,13 +286,7 @@ EOSQL;
 			foreach( $rows as $row ) {
 				$tmpgb = new Gehaltsbestandteil();
 				$tmpgb->hydrateByStdClass($row, true);
-
-				if ($row->betrag_valorisiert != null && $row->valorisierungsdatum != null 
-					&& $row->valorisierungsdatum == $row->von) {
-					// neuer Gehaltsbestandteil mit Valorisierungsdatum aber auch valorisiert
-					$tmpgb->setGrundbetrag($row->betrag_valorisiert);
-				}
-
+				
 				// prevent duplication (caused by the join with historic values)
 				if (!isset($lastRecords[(string)$row->gehaltsbestandteil_id])) {
 					$gehaltsbestandteile[] = $tmpgb;

application/views/Cis/Abgabetool.php

@@ -1,47 +0,0 @@
-<?php
-
-$includesArray = array(
-	'title' => 'Cis4',
-	'axios027' => true,
-	'bootstrap5' => true,
-	'fontawesome6' => true,
-	'tabulator5' => true, // TODO: upgrade to 6 when available
-	'vue3' => true,
-	'primevue3' => true,
-	'skipID' => '#fhccontent',
-	'vuedatepicker11' => true,
-	'customCSSs' => array(
-		'public/css/components/verticalsplit.css',
-		'public/css/components/FilterComponent.css',
-		'public/css/components/FormUnderline.css',
-		'public/css/theme/default.css',
-		'public/css/components/abgabetool/abgabe.css'
-	),
-	'customJSs' => array(
-		'vendor/npm-asset/primevue/accordion/accordion.min.js',
-		'vendor/npm-asset/primevue/accordiontab/accordiontab.min.js',
-		'vendor/npm-asset/primevue/checkbox/checkbox.min.js',
-		'vendor/npm-asset/primevue/inputnumber/inputnumber.min.js',
-		'vendor/npm-asset/primevue/speeddial/speeddial.min.js',
-		'vendor/npm-asset/primevue/textarea/textarea.min.js',
-		'vendor/npm-asset/primevue/timeline/timeline.min.js',
-		'vendor/npm-asset/primevue/inplace/inplace.min.js',
-		'vendor/npm-asset/primevue/message/message.min.js',
-		'vendor/npm-asset/primevue/tieredmenu/tieredmenu.js',
-		'vendor/moment/luxonjs/luxon.min.js'
-	),
-	'customJSModules' => array(
-		'public/js/apps/Abgabetool/Abgabetool.js',
-	),
-
-);
-
-$this->load->view('templates/FHC-Header', $includesArray);
-?>
-<div id="abgabetoolroot" class="h-100" style="max-width: 95%;" route=<?php echo json_encode($route) ?> 
-	uid=<?php echo $uid ?> 
-	 student_uid_prop="<?php echo $student_uid_prop ?? '' ?>"
-	stg_kz_prop="<?php echo $stg_kz_prop ?? '' ?>"
-	>
-</div>
-<?php $this->load->view('templates/FHC-Footer', $includesArray); ?>

application/views/CisRouterView/CisRouterView.php

@@ -21,25 +21,19 @@ $includesArray = array(
 		'public/css/components/FilterComponent.css',
 		'public/css/components/Profil.css',
 		'public/css/components/FormUnderline.css',
-		'public/css/components/abgabetool/abgabe.css',
 		'public/css/Cis4/Cms.css',
 		'public/css/Cis4/Studium.css',
 	),
 	'customJSs' => array(
 		'vendor/npm-asset/primevue/accordion/accordion.min.js',
 		'vendor/npm-asset/primevue/accordiontab/accordiontab.min.js',
-		'vendor/npm-asset/primevue/checkbox/checkbox.min.js',
 		'vendor/npm-asset/primevue/inputnumber/inputnumber.min.js',
-		'vendor/npm-asset/primevue/speeddial/speeddial.min.js',
 		'vendor/npm-asset/primevue/textarea/textarea.min.js',
-		'vendor/npm-asset/primevue/timeline/timeline.min.js',
-		'vendor/npm-asset/primevue/inplace/inplace.min.js',
-		'vendor/npm-asset/primevue/message/message.min.js',
-		'vendor/npm-asset/primevue/tieredmenu/tieredmenu.js',
+		'vendor/npm-asset/primevue/checkbox/checkbox.min.js',
 		'vendor/moment/luxonjs/luxon.min.js'
 	),
 	'customJSModules' => array(
-		'public/js/apps/Dashboard/Fhc.js',
+		'public/js/apps/Dashboard/Fhc.js'
 	),
 
 );

application/views/Nachrichten.php

@@ -40,10 +40,6 @@ $configArray = [
 		cis-root="<?= CIS_ROOT; ?>"
 		:permissions="<?= htmlspecialchars(json_encode($permissions)); ?>"
 		:config="<?=  htmlspecialchars(json_encode($configArray)); ?>"
-<?php if($ids !== null && $typeid !== null) { ?>
-		:id ="<?= htmlspecialchars(json_encode($ids)); ?>"
-		type-id ="<?= htmlspecialchars($typeid); ?>"
-<?php } ?>
 	>
 	</router-view>
 </div>

application/views/templates/CISVUE-Header.php

@@ -36,4 +36,4 @@ $this->load->view('templates/FHC-Header', $includesArray);
 		></cis-menu>
 </header>
 
-<main id="cis-main" class="flex-grow-1 p-4 pt-2" style="min-width: 0;">
+<main id="cis-main" class="flex-grow-1 p-4 pt-2">

cis/public/testtool_test/testseite.php

@@ -86,88 +86,67 @@ echo '<?xml version="1.0" encoding="ISO-8859-1" ?>';
 					<h3>Formel / Formula</h3>
 					<div style="font-size: large; padding-top: 15px">
 						<math xmlns="http://www.w3.org/1998/Math/MathML">
-						  <mrow>
-						    <mfrac>
-						      <mn>5</mn>
-						      <mn>3</mn>
-						    </mfrac>
-						    <mo>+</mo>
-						    <mfrac>
-						      <mn>7</mn>
-						      <mn>6</mn>
-						    </mfrac>
-						    <mo>=</mo>
-						    <mfrac>
-						      <mn>10</mn>
-						      <mn>6</mn>
-						    </mfrac>
-						    <mo>+</mo>
-						    <mfrac>
-						      <mn>7</mn>
-						      <mn>6</mn>
-						    </mfrac>
-						    <mo>=</mo>
-						    <mfrac>
-						      <mn>17</mn>
-						      <mn>6</mn>
-						    </mfrac>
-						  </mrow>
+							<mfrac>
+								<mn> 5 </mn>
+								<mn> 3 </mn>
+							</mfrac>
+
+							<mo> + </mo>
+							<mfrac>
+								<mn> 7 </mn>
+								<mn> 6 </mn>
+							</mfrac>
+							<mo> = </mo>
+
+							<mfrac>
+								<mn> 10 </mn>
+								<mn> 6 </mn>
+							</mfrac>
+							<mo> + </mo>
+							<mfrac>
+
+								<mn> 7 </mn>
+								<mn> 6 </mn>
+							</mfrac>
+							<mo> = </mo>
+							<mfrac>
+								<mn> 17 </mn>
+
+								<mn> 6 </mn>
+							</mfrac>
 						</math><br/><br/>
 						<math xmlns="http://www.w3.org/1998/Math/MathML">
-						  <mrow>
-						    <munderover>
-						      <mo>&sum;</mo>
-						      <mrow>
-						        <mi>k</mi>
-						        <mo>=</mo>
-						        <mn>1</mn>
-						      </mrow>
-						      <mn>5</mn>
-						    </munderover>
-						    <mrow>
-						      <msup>
-						        <mrow>
-						          <mo>(</mo>
-						          <mo>-</mo>
-						          <mn>1</mn>
-						          <mo>)</mo>
-						        </mrow>
-						        <mrow>
-						          <mi>k</mi>
-						          <mo>+</mo>
-						          <mn>1</mn>
-						        </mrow>
-						      </msup>
-						      <mfrac>
-						        <mrow>
-						          <msup>
-						            <mi>x</mi>
-						            <mrow>
-						              <mn>2</mn>
-						              <mi>k</mi>
-						              <mo>+</mo>
-						              <mn>1</mn>
-						            </mrow>
-						          </msup>
-						        </mrow>
-						        <mrow>
-						          <mo>(</mo>
-						          <mn>2</mn>
-						          <mi>k</mi>
-						          <mo>+</mo>
-						          <mn>1</mn>
-						          <mo>)</mo>
-						          <mo>!</mo>
-						        </mrow>
-						      </mfrac>
-						    </mrow>
-						  </mrow>
+							<mrow>
+								<munderover>
+									<mo movablelimits="false">&sum;</mo>
+									<mn><mi>k</mi>=1</mn>
+									<mn>5</mn>
+								</munderover>
+								<mrow>
+									<msup>
+										<mo>(-1)</mo>
+										<mn><mi>k</mi>+1</mn>
+									</msup>
+								</mrow>
+								<mfrac>
+									<mrow>
+										<msup>
+											<mi>x</mi>
+											<mn>2<mi>k</mi> + 1</mn>
+										</msup>
+									</mrow>
+									<mrow>
+										<mo>(2<mi>k</mi>+1)!</mo>
+									</mrow>
+								</mfrac>
+							</mrow>
+
 						</math>
 					</div>
 				</div>
 				<div class="col-sm-6">
 					<h3>Bild / Picture</h3>
-					<img alt="Beispielbild" src="MathML_Beispiel.png" height="140" style="border: 1px solid black">
+					<img alt="Beispielbild" src="MathML_Beispiel.jpg" border="1" height="154" width="233"></img>
 				</div>
 			</div>
 		</div>

cis/testtool/admin/index.php

@@ -1172,8 +1172,8 @@ if ($frage_id != '')
 	echo "</td></tr>";
 	//Vorschau fuer das Text-Feld
 	echo "<tr><td style='width: 50%'>Vorschau:<br />
-			<div id='vorschau_frage' style='border: 1px solid black; padding: 5px' align='center'>$frage->text</div></td>
-			<td style='width: 50%'>Derzeit:<br /><div id='aktuell' style='border: 1px solid black; padding: 5px' align='center'>$frage->text</div>
+			<div id='vorschau_frage' style='border: 1px solid black' align='center'>$frage->text</div></td>
+			<td style='width: 50%'>Derzeit:<br /><div id='aktuell' style='border: 1px solid black' align='center'>$frage->text</div>
 			</td></tr>";
 	echo "</table>";
 	echo '</td><td style="border-left: 1px solid black" valign="top">';
@@ -1280,8 +1280,8 @@ if ($frage_id != '')
 	echo "/></td></tr>";
 	echo "<tr><td colspan='2' align='right'><input type='submit' name='submitvorschlag' value='Speichern' />".($vorschlag_id != ''?"<input type='button' value='Abbrechen' onclick=\"document.location.href='$PHP_SELF?gebiet_id=$gebiet_id&amp;stg_kz=$stg_kz&amp;nummer=$nummer&amp;frage_id=$frage->frage_id'\" />":'')."</td></tr>";
 	//Vorschau fuer das Text-Feld
-	echo "<tr><td colspan='2'>Vorschau:<br /><div id='vorschau_vorschlag' style='border: 1px solid black; padding: 5px' align='center'>$vorschlag->text</div>
-			Derzeit:<br /><div id='aktuellvorschlag' style='border: 1px solid black; padding: 5px' align='center'>$vorschlag->text</div></td></tr>";
+	echo "<tr><td colspan='2'>Vorschau:<br /><div id='vorschau_vorschlag' style='border: 1px solid black' align='center'>$vorschlag->text</div>
+			Derzeit:<br /><div id='aktuellvorschlag' style='border: 1px solid black' align='center'>$vorschlag->text</div></td></tr>";
 	echo "</table>";
 	echo "</form>";
 	echo '</td></tr></table>';

cis/testtool/externeueberwachung.js

@@ -1,15 +0,0 @@
-(function () {
-	function sendMessage() {
-		let frame = window.frames['content'];
-		if (frame)
-			frame.postMessage({ type: "proctoringReady" });
-	}
-
-	window.addEventListener("message", function (e)
-	{
-		if (e.data.indexOf("proctoringReady_") === 0)
-		{
-			sendMessage();
-		}
-	});
-})();

cis/testtool/frage.css

@@ -1,30 +0,0 @@
-.proctoring-blocker
-{
-	position: fixed;
-	inset: 0;
-	z-index: 99999;
-	backdrop-filter: blur(6px);
-	pointer-events: all;
-	user-select: none;
-}
-
-.proctoring-blocker.hidden
-{
-	display: none !important;
-}
-
-.proctoring-text
-{
-	position: absolute;
-	top: 50%;
-	left: 50%;
-	transform: translate(-50%, -50%);
-	color: #fff;
-	font-size: 16px;
-	font-family: sans-serif;
-}
-
-.proctoring-blur-fallback
-{
-	filter: blur(6px);
-}

cis/testtool/frage.php

@@ -45,7 +45,7 @@ if (!$db = new basis_db())
 $PHP_SELF=$_SERVER["PHP_SELF"];
 
 // Start session
-require_once './session_init.php';
+session_start();
 
 // If language is changed by language select menu, reset language variables
 if (isset($_GET['sprache_user']) && !empty($_GET['sprache_user']))
@@ -182,12 +182,6 @@ echo '
 if(!isset($_SESSION['pruefling_id']))
 	die($p->t('testtool/bitteZuerstAnmelden'));
 
-if (!empty($_SESSION['externe_ueberwachung']) && isset($_SESSION['externe_ueberwachung_verified'])): ?>
-	<link href="frage.css" rel="stylesheet" type="text/css" />
-	<script type="text/javascript" src="frage_externe_ueberwachung.js"></script>
-	<div id="proctoringBlocker" class="proctoring-blocker hidden"></div>
-<?php endif;
-
 $pruefling = new pruefling();
 $pruefling->load($_SESSION['pruefling_id']);
 
@@ -581,14 +575,14 @@ if($frage->frage_id!='')
 			else
 				$value=$p->t('testtool/blaettern').' &gt;&gt;';
 
-			echo "<a href='$PHP_SELF?gebiet_id=$gebiet_id&amp;frage_id=$nextfrage' class='Item' style='padding-left: 5px'>$value</a>";
+			echo " <a href='$PHP_SELF?gebiet_id=$gebiet_id&amp;frage_id=$nextfrage' class='Item'>$value</a>";
 		}
 		else
 		{
 			if(!$demo)
 			{
 				//Wenns der letzte Eintrag ist, wieder zum ersten springen
-				echo "<a href='$PHP_SELF?gebiet_id=$gebiet_id' class='Item' style='padding-left: 5px'>".$p->t('testtool/blaettern')." &gt;&gt;</a>";
+				echo " <a href='$PHP_SELF?gebiet_id=$gebiet_id' class='Item'>".$p->t('testtool/blaettern')." &gt;&gt;</a>";
 			}
 		}
 	}

cis/testtool/frage_externe_ueberwachung.js

@@ -1,53 +0,0 @@
-(function () {
-	let ok = false;
-	let blocker;
-
-	function showBlocker() {
-		blocker = document.getElementById("proctoringBlocker");
-
-		if (!blocker)
-		{
-			blocker = document.createElement("div");
-			blocker.id = "proctoringBlocker";
-			blocker.className = "proctoring-blocker";
-			blocker.innerHTML = '<div class="proctoring-text">Loading...</div>';
-			document.body.appendChild(blocker);
-		}
-		document.documentElement.classList.add("proctoring-blur-fallback");
-	}
-
-	function block() {
-		showBlocker();
-		blocker.classList.remove("hidden");
-	}
-
-	function unblock() {
-		document.documentElement.classList.remove("proctoring-blur-fallback");
-		if (!blocker) return;
-		blocker.classList.add("hidden");
-	}
-
-	const blockTimer = setTimeout(function () {
-		if (!ok)
-			block();
-	}, 1500);
-
-	window.addEventListener("message", function (e) {
-		const data = e.data || {};
-
-		if (data.type === "proctoringReady")
-		{
-			ok = true;
-			clearTimeout(blockTimer);
-			unblock();
-		}
-	});
-
-	setTimeout(function () {
-		if (!ok) {
-			top.location.href = "resetconnection.php";
-		}
-	}, 3000);
-})();
-
-

cis/testtool/index.php

@@ -1,79 +1,16 @@
 <?php
 $contentpage = 'login.php';
 
-require_once './session_init.php';
-
 if(isset($_GET['prestudent']) && is_numeric($_GET['prestudent']))
 {
 	$contentpage = 'login.php?prestudent='.$_GET['prestudent'];
 }
-
-if ((isset($_SESSION['externe_ueberwachung']) && $_SESSION['externe_ueberwachung'] === true) &&
-	isset($_SESSION['externe_ueberwachung_verified']) && $_SESSION['externe_ueberwachung_verified'] === false)
-{
-	header("Location: resetconnection.php");
-	exit;
-}
 ?><!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN" "http://www.w3.org/TR/html4/frameset.dtd">
 <html>
 <head>
 	<title>TestTool - FH Technikum Wien</title>
 	<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
 	<link href="../../skin/style.css.php" rel="stylesheet" type="text/css">
-	<?php
-	if (!empty($_SESSION['externe_ueberwachung'])) : ?>
-	<script type="text/javascript" src="externeueberwachung.js"></script>
-	<script>
-		function loadInContent(url)
-		{
-			if (url.includes('logout=true'))
-			{
-				return doLogout(url);
-			}
-
-			let frame = document.getElementById('content_testtool');
-			if (frame)
-			{
-				frame.src = url;
-			}
-		}
-
-		function doLogout(url)
-		{
-			fetch(url)
-			let topbarFrame = window.frames['topbar'];
-			let menuFrame = window.frames['menu'];
-			let contentFrame = window.frames['content'];
-
-			if (contentFrame)
-				contentFrame.location.href = 'logout.html';
-
-			if (menuFrame)
-				menuFrame.location.href = menuFrame.location.pathname;
-
-			if (topbarFrame)
-				topbarFrame.location.href = topbarFrame.location.pathname;
-			return false;
-		}
-
-		function changeSprache(content_params, sprache)
-		{
-			let topbarFrame = window.frames['topbar'];
-			let menuFrame = window.frames['menu'];
-			let contentFrame = window.frames['content'];
-
-			if (topbarFrame)
-				topbarFrame.location.href = topbarFrame.location.pathname + '?sprache_user=' + sprache;
-
-			if (menuFrame)
-				menuFrame.location.href = menuFrame.location.pathname + '?sprache_user=' + sprache;
-
-			if (contentFrame)
-				contentFrame.location.href = contentFrame.location.pathname + '?' + content_params;
-		}
-
-	</script>
-	<?php endif; ?>
 </head>
 
 <frameset rows="13%,*" cols="*" frameborder="NO" border="0" framespacing="0">
@@ -89,4 +26,3 @@ if ((isset($_SESSION['externe_ueberwachung']) && $_SESSION['externe_ueberwachung
 	</noframes>
 </frameset>
 </html>
-

cis/testtool/login.php

@@ -40,7 +40,8 @@ if (!$db = new basis_db())
 	die('Fehler beim Oeffnen der Datenbankverbindung');
 
 // Start session
-require_once './session_init.php';
+session_start();
+
 // Logout (triggered by logout button in menu.php)
 if (isset($_GET['logout']) && $_GET['logout'] == true)
 {
@@ -172,12 +173,6 @@ if (isset($_REQUEST['prestudent']))
 						else
 							$reload_menu = true;
 					}
-
-					if ($rt->externe_ueberwachung && defined('TESTTOOL_EXTERNE_UEBERWACHUNG_ALLOWED') && TESTTOOL_EXTERNE_UEBERWACHUNG_ALLOWED)
-					{
-						$_SESSION['externe_ueberwachung'] = true;
-						$_SESSION['externe_ueberwachung_verified'] = false;
-					}
 				}
 
 				$pruefling = new pruefling();
@@ -340,26 +335,11 @@ else
 	}
 }
 
-if (
-	(
-		isset($_SESSION['prestudent_id']) && !isset($_SESSION['pruefling_id']) &&
-		!isset($_SESSION['confirmation_needed']) && !isset($_SESSION['confirmed_code']) &&
-		!isset($_SESSION['externe_ueberwachung']) && !isset($_SESSION['externe_ueberwachung_verified'])
-	)
-	||
-	(
-		isset($_SESSION['confirmation_needed']) && $_SESSION['confirmation_needed'] === true &&
-		isset($_SESSION['confirmed_code']) && $_SESSION['confirmed_code'] === true &&
-		isset($_SESSION['prestudent_id']) && !isset($_SESSION['pruefling_id'])
-	)
-	||
-	(
-		isset($_SESSION['externe_ueberwachung']) && $_SESSION['externe_ueberwachung'] === true &&
-		isset($_SESSION['externe_ueberwachung_verified']) && $_SESSION['externe_ueberwachung_verified'] === true &&
-		isset($_SESSION['prestudent_id']) && !isset($_SESSION['pruefling_id'])
-	)
-
-)
+if ((isset($_SESSION['prestudent_id']) && !isset($_SESSION['pruefling_id']) &&
+	!isset($_SESSION['confirmation_needed']) && !isset($_SESSION['confirmed_code'])) ||
+	(isset($_SESSION['confirmation_needed']) && $_SESSION['confirmation_needed'] === true &&
+	isset($_SESSION['confirmed_code']) && $_SESSION['confirmed_code'] === true &&
+	isset($_SESSION['prestudent_id']) && !isset($_SESSION['pruefling_id'])))
 {
 	$pruefling = new pruefling();
 
@@ -467,6 +447,14 @@ if (isset($_POST['save']) && isset($_SESSION['prestudent_id']))
 		{
 			e.preventDefault();
 		});
+		// If Browser is any other than Mozilla Firefox and the test includes any MathML,
+		// show message to use Mozilla Firefox
+		var ua = navigator.userAgent;
+		if ((ua.indexOf("Firefox") > -1) == false)
+		{
+			$("#alertmsgdiv").html("<div class='alert alert-danger'>BITTE VERWENDEN SIE DEN MOZILLA FIREFOX BROWSER!<br>(Manche Prüfungsfragen werden sonst nicht korrekt dargestellt.<br><br>PLEASE USE MOZILLA FIREFOX BROWSER!<br>(Otherwise some exam items will not be displayed correctly</div>");
+			//alert('BITTE VERWENDEN SIE DEN MOZILLA FIREFOX BROWSER!\n(Manche Prüfungsfragen werden sonst nicht korrekt dargestellt.\n\nPLEASE USE MOZILLA FIREFOX BROWSER!\n(Ohterwise some exam items will not be displayed correctly.)');
+		}
 	});
 	</script>
 <?php
@@ -480,13 +468,7 @@ if (isset($_POST['save']) && isset($_SESSION['prestudent_id']))
 
 <?php
 
-if ((isset($_SESSION['externe_ueberwachung']) && $_SESSION['externe_ueberwachung'] === true) &&
-	isset($_SESSION['externe_ueberwachung_verified']) && $_SESSION['externe_ueberwachung_verified'] === false)
-{
-	echo "<script> top.location.href = 'resetconnection.php';</script>";
-	exit;
-}
-else if (isset($_SESSION['confirmation_needed']) && $_SESSION['confirmation_needed'] === true &&
+if (isset($_SESSION['confirmation_needed']) && $_SESSION['confirmation_needed'] === true &&
 	isset($_SESSION['confirmed_code']) && $_SESSION['confirmed_code'] === false)
 {
 	echo '
@@ -678,11 +660,10 @@ elseif (isset($prestudent_id))
 	else
 	{
 		// Letzten Status für des Prestudenten einholen
-		$ps_master = new Prestudent($prestudent_id);
+		$ps_master = new Prestudent();
 		$ps_master->getLastStatus($prestudent_id);
 		$sto = new Studienordnung();
 		$sto->getStudienordnungFromStudienplan($ps_master->studienplan_id);
-		$stg = new Studiengang($ps_master->studiengang_kz);
 		// Name des Studiengangs aus Studienordnung laden, ansonsten Fallback auf Studiengang
 		$stg_name = $sto->studiengangbezeichnung;
 		$stg_name_eng = $sto->studiengangbezeichnung_englisch;
@@ -745,7 +726,7 @@ else // LOGIN Site (vor Login)
 			echo '<script>
 				function changeconfirmation()
 				{
-					document.getElementById("confirmationSubmit").disabled = !document.getElementById("confirmationCheckbox").checked || !document.getElementById("dsgvoconfirm").checked || !document.getElementById("procotoringconfirm").checked;
+					document.getElementById("confirmationSubmit").disabled = !document.getElementById("confirmationCheckbox").checked;
 				}
 				</script>';
 			echo '<div class="row text-center">
@@ -755,12 +736,6 @@ else // LOGIN Site (vor Login)
 			<input id="confirmationCheckbox" type="checkbox" name="confirmation" onclick="changeconfirmation()" />
 			'.$p->t('testtool/confirmationText').'
 			<br><br>
-			<input id="dsgvoconfirm" type="checkbox" name="confirmation" onclick="changeconfirmation()" />
-			'.$p->t('testtool/dsgvoConfirmText').'
-			<br><br>
-			<input id="procotoringconfirm" type="checkbox" name="confirmation" onclick="changeconfirmation()" />
-			'.$p->t('testtool/procotoringConfirmText').'
-			<br><br>
 			<button id="confirmationSubmit" type="submit" class="btn btn-primary" disabled/>
 				'.$p->t('testtool/start').'
 			</button>

cis/testtool/menu.php

@@ -34,7 +34,7 @@ if (!$db = new basis_db())
 	die('Fehler beim Oeffnen der Datenbankverbindung');
 
 // Start session
-require_once './session_init.php';
+session_start();
 
 // If language is changed by language select menu, reset language and session variables
 if(isset($_GET['sprache_user']) && !empty($_GET['sprache_user']))
@@ -61,12 +61,8 @@ $p = new phrasen($sprache_user);
 <?php
 $gebiet_hasMathML = false; // true, wenn irgendein Gebiet eine/n Frage/Vorschlag im MathML-Format enthält
 $invalid_gebiete = false;
-if ((isset($_SESSION['externe_ueberwachung']) && $_SESSION['externe_ueberwachung'] === true) &&
-	isset($_SESSION['externe_ueberwachung_verified']) && $_SESSION['externe_ueberwachung_verified'] === false)
-{
-	exit;
-}
-else if (isset($_SESSION['pruefling_id']))
+
+if (isset($_SESSION['pruefling_id']))
 {
 	//content_id fuer Einfuehrung auslesen
 	$qry = "SELECT content_id FROM testtool.tbl_ablauf_vorgaben WHERE studiengang_kz=".$db->db_add_param($_SESSION['studiengang_kz'])." LIMIT 1";
@@ -77,7 +73,7 @@ else if (isset($_SESSION['pruefling_id']))
 
 // Link zur Startseite
 	echo '<tr><td class="ItemTesttool" style="margin-left: 20px;" nowrap>
-			<a class="ItemTesttool navButton" href="login.php" onclick="return loadContent(this.href);">'.$p->t('testtool/startseite').'</a>
+			<a class="ItemTesttool navButton" href="login.php" target="content">'.$p->t('testtool/startseite').'</a>
 		</td></tr>';
 
 // Link zur Einleitung
@@ -87,7 +83,7 @@ else if (isset($_SESSION['pruefling_id']))
 		{
 			echo '
 				<tr id="tr-einleitung"><td class="ItemTesttool" style="margin-left: 20px;" nowrap>
-					<a class="ItemTesttool navButton" href="../../cms/content.php?content_id='.$content_id->content_id.'&sprache='.$sprache_user.'" onclick="return loadContent(this.href);">'.$p->t('testtool/einleitung').'</a>
+					<a class="ItemTesttool navButton" href="../../cms/content.php?content_id='.$content_id->content_id.'&sprache='.$sprache_user.'" target="content">'.$p->t('testtool/einleitung').'</a>
 				</td></tr>
 			';
 		}
@@ -383,13 +379,10 @@ else if (isset($_SESSION['pruefling_id']))
 				}
 			}
 
-
 			echo '<tr>
 					<!--<td width="10" class="ItemTesttoolLeft" nowrap>&nbsp;</td>-->
-
 						<td class="'.$class.'">
-								<a class="'.$class.'" href="frage.php?gebiet_id='.$row->gebiet_id.'" onclick="return loadContent(this.href);"  style="'.$style.'">'.$gebietbezeichnung.'</a>
-								
+							<a class="'.$class.'" href="frage.php?gebiet_id='.$row->gebiet_id.'" onclick="document.location.reload()" target="content" style="'.$style.'">'.$gebietbezeichnung.'</a>
 						</td>
 					<!--<td width="10" class="ItemTesttoolRight" nowrap>&nbsp;</td>-->
 					</tr>';
@@ -408,7 +401,7 @@ else if (isset($_SESSION['pruefling_id']))
 	// Link zum Logout
 
 	echo '<tr><td class="ItemTesttool" style="margin-left: 20px;" nowrap>
-			<a class="ItemTesttool navButton" href="login.php?logout=true" onclick="return loadContent(this.href);">Logout</a>
+			<a class="ItemTesttool navButton" href="login.php?logout=true" target="content">Logout</a>
 		</td></tr>';
 
 	echo '</td></tr></table>';
@@ -432,6 +425,28 @@ else
 			e.preventDefault();
 		});
 	});
+    // Get users Browser
+    var ua = navigator.userAgent;
+
+    // If Browser is any other than Mozilla Firefox and the test includes any MathML,
+    // show message to use Mozilla Firefox
+    if ((ua.indexOf("Firefox") > -1) == false)
+    {
+        let hasMathML = "<?php echo (isset($gebiet_hasMathML)?$gebiet_hasMathML:''); ?>";
+        let userLang = "<?php echo $sprache_user; ?>";
+        if (hasMathML == true)
+        {
+            if (userLang == 'German')
+            {
+                alert('BITTE VERWENDEN SIE DEN MOZILLA FIREFOX BROWSER!\n(Manche Prüfungsfragen werden sonst nicht korrekt dargestellt.)');
+            }
+            else if(userLang == 'English')
+            {
+                alert('PLEASE USE MOZILLA FIREFOX BROWSER!\n(Ohterwise some exam items will not be displayed correctly.)');
+            }
+        }
+    }
+
     // Error massage if check_gebiet function returns false
     $(function() {
         var invalid_gebiete = "<?php echo (isset($invalid_gebiete)?$invalid_gebiete:''); ?>";
@@ -446,22 +461,5 @@ else
                 '</td></tr>');
         }
     });
-
-	function loadContent(url)
-	{
-		if (parent && typeof parent.loadInContent === 'function')
-		{
-			parent.loadInContent(url);
-			return false;
-		}
-
-		let frame = parent?.frames?.["content"];
-		if (frame)
-		{
-			frame.location.href = url;
-			return false;
-		}
-	}
-
 </script>
 </html>

cis/testtool/resetconnection.php

@@ -1,18 +0,0 @@
-<?php
-
-
-require_once './session_init.php';
-
-require_once('../../config/cis.config.inc.php');
-require_once('../../config/global.config.inc.php');
-require_once '../../include/externe_ueberwachung.class.php';
-if (!$db = new basis_db())
-	die('Fehler beim Oeffnen der Datenbankverbindung');
-if ((defined('TESTTOOL_EXTERNE_UEBERWACHUNG_ALLOWED') && TESTTOOL_EXTERNE_UEBERWACHUNG_ALLOWED) && isset($_SESSION['externe_ueberwachung']) && $_SESSION['externe_ueberwachung'] === true)
-{
-	$ueberwachung = new externeUeberwachung();
-	$url = $ueberwachung->start($_SESSION['prestudent_id'], $_SESSION['reihungstestID'], $_SESSION['sprache']);
-	$urlSafe = htmlspecialchars($url, ENT_QUOTES);
-	header("Location: $urlSafe");
-	$_SESSION['externe_ueberwachung_verified'] = true;
-}

cis/testtool/session_init.php

@@ -1,11 +0,0 @@
-<?php
-if (session_status() === PHP_SESSION_NONE) {
-	session_set_cookie_params(
-		0,
-		'/; samesite=None',
-		'',
-		true,
-		true
-	);
-	session_start();
-}

cis/testtool/topbar.php

@@ -67,17 +67,9 @@ function changeSprache(sprache)
     content_params.set('sprache_user', sprache); // add or replace sprache_user
 
     // Pass GET-param sprache_user to topbar.php, menu.php and content (login.php or frage.php) and refresh the frames.
-	if (parent && typeof parent.changeSprache === 'function')
-	{
-		parent.changeSprache(content_params, sprache);
-		return false;
-	}
-	else
-	{
-		location.href = location.pathname + '?sprache_user=' + sprache; // refreshes topbar.php
-		parent.menu.location.href = parent.menu.location.pathname + '?sprache_user=' + sprache; // refreshes menu.php
-		parent.content.location.href = parent.content.location.pathname + '?' + content_params; // refreshes login.php or frage.php
-	}
+    location.href = location.pathname + '?sprache_user=' + sprache; // refreshes topbar.php
+    parent.menu.location.href = parent.menu.location.pathname + '?sprache_user=' + sprache; // refreshes menu.php
+    parent.content.location.href = parent.content.location.pathname + '?' + content_params; // refreshes login.php or frage.php
 }
 
 	$(document).on("keydown", function (e) {

composer.json

@@ -456,7 +456,6 @@
 		"fortawesome/font-awesome4": "4.7.*",
 		"fortawesome/font-awesome6": "6.1.*",
 		"fzaninotto/faker": "1.*",
-		"firebase/php-jwt": "^6.0",
 
 		"highcharts/highcharts-dist": "^7.1.2",
 

composer.lock

@@ -4,7 +4,7 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
         "This file is @generated automatically"
     ],
-    "content-hash": "f4f0af4586f46f97d8b6092c1ac0fb3a",
+    "content-hash": "1de37a74ba51a66057eb2712b21340c8",
     "packages": [
         {
             "name": "afarkas/html5shiv",
@@ -882,63 +882,6 @@
             },
             "type": "library"
         },
-        {
-            "name": "firebase/php-jwt",
-            "version": "v6.0.0",
-            "source": {
-                "type": "git",
-                "url": "https://github.com/firebase/php-jwt.git",
-                "reference": "0541cba75ab108ef901985e68055a92646c73534"
-            },
-            "dist": {
-                "type": "zip",
-                "url": "https://api.github.com/repos/firebase/php-jwt/zipball/0541cba75ab108ef901985e68055a92646c73534",
-                "reference": "0541cba75ab108ef901985e68055a92646c73534",
-                "shasum": ""
-            },
-            "require": {
-                "php": ">=5.3.0"
-            },
-            "require-dev": {
-                "phpunit/phpunit": ">=4.8 <=9"
-            },
-            "suggest": {
-                "paragonie/sodium_compat": "Support EdDSA (Ed25519) signatures when libsodium is not present"
-            },
-            "type": "library",
-            "autoload": {
-                "psr-4": {
-                    "Firebase\\JWT\\": "src"
-                }
-            },
-            "notification-url": "https://packagist.org/downloads/",
-            "license": [
-                "BSD-3-Clause"
-            ],
-            "authors": [
-                {
-                    "name": "Neuman Vong",
-                    "email": "neuman+pear@twilio.com",
-                    "role": "Developer"
-                },
-                {
-                    "name": "Anant Narayanan",
-                    "email": "anant@php.net",
-                    "role": "Developer"
-                }
-            ],
-            "description": "A simple library to encode and decode JSON Web Tokens (JWT) in PHP. Should conform to the current spec.",
-            "homepage": "https://github.com/firebase/php-jwt",
-            "keywords": [
-                "jwt",
-                "php"
-            ],
-            "support": {
-                "issues": "https://github.com/firebase/php-jwt/issues",
-                "source": "https://github.com/firebase/php-jwt/tree/v6.0.0"
-            },
-            "time": "2022-01-24T15:18:34+00:00"
-        },
         {
             "name": "fortawesome/font-awesome4",
             "version": "4.7.0",

config/cis.config-default.inc.php

@@ -301,17 +301,4 @@ define ('DEFAULT_ECHTER_DIENSTVERTRAG',[103,111]);
 
 // Weiterleiten zu CIS neu (wenn Rechte vorhanden)
 define('CIS_REDIRECT_TO_CIS4', false);
-
-//Externe Ueberwachung
-define('EXTERNE_UEBERWACHUNG_PROTOCOL_URL', 'https://example.com');
-define('EXTERNE_UEBERWACHUNG_SECRET_KEY', null);
-define('EXTERNE_UEBERWACHUNG_INTEGRATION_NAME', 'example');
-define('EXTERNE_UEBERWACHUNG_SESSION_URL', 'https://example.com');
-define('EXTERNE_UEBERWACHUNG_TRIAL_TEST', false);
-define('EXTERNE_UEBERWACHUNG_EXAM_PARAMS', []);
-define('EXTERNE_UEBERWACHUNG_EXAM_RULES', []);
-define('EXTERNE_UEBERWACHUNG_EXAM_SCORE', []);
-define('EXTERNE_UEBERWACHUNG_EXAM_WARNINGS', []);
-
-
 ?>

config/global.config-default.inc.php

@@ -28,15 +28,11 @@ define('CIS_LEHRVERANSTALTUNG_LEHRFACH_ANZEIGEN',false);
 define('CIS_LEHRVERANSTALTUNG_GESAMTNOTE_ANZEIGEN', true);
 define('CIS_LEHRVERANSTALTUNG_ANRECHNUNG_ANZEIGEN', true);
 define('CIS_LEHRVERANSTALTUNG_ANWESENHEIT_ANZEIGEN', true);
-define('CIS_LEHRVERANSTALTUNG_EVALUIERUNG_ANZEIGEN', true);
 
 // Wenn gesetzt, werden die Digitale Anwesenheit-Icons nur fuer diese Studiengaenge angezeigt, sonst für alle
 // define('CIS_LEHRVERANSTALTUNG_ANWESENHEIT_ANZEIGEN_STG', serialize(array('257')));
 // define('CIS_LEHRVERANSTALTUNG_ANWESENHEIT_ANZEIGEN_LVA', serialize(array('39455','39481','39480','41906','41905','41904','39459','39512','39454','39482','42230','42231','39458','41921','41922','39457','42896')));
 
-// Wenn gesetzt, werden die LV-Evaluierung-Icons nur für diese Studiengaenge angezeigt, sonst alle
-define('CIS_EVALUIERUNG_ANZEIGEN_STG', serialize((array('335', '585', '914', '298'))));	// BIW, MAI, BUB, MIO
-
 // Im CIS Menue Links bei Modulen anzeigen wenn Lehrauftrag
 define('CIS_LEHRVERANSTALTUNG_MODULE_LINK',true);
 
@@ -364,11 +360,4 @@ define('SANCHO_MAIL_HEADER_IMG', 'sancho_header_DEFAULT.jpg');
 
 // footer image for eigene Mails
 define('SANCHO_MAIL_FOOTER_IMG', 'sancho_footer_DEFAULT.jpg');
-
-// Gibt an, ob in der StudVW der Status vorgerueckt werden kann
-define('STATUS_VORRUECKEN_ANZEIGEN', true);
-
-//externe Ueberwachung im Testtool erlauben
-define('TESTTOOL_EXTERNE_UEBERWACHUNG_ALLOWED', false);
-
 ?>

include/anwesenheit.class.php

@@ -479,182 +479,91 @@ class anwesenheit extends basis_db
 	 */
 	public function loadAnwesenheitStudiensemester($studiensemester_kurzbz, $student_uid=null, $lehrveranstaltung_id=null)
 	{
-		$qry = "SELECT 
-					lehrveranstaltung_id, 
-					vorname, 
-					nachname, 
-					wahlname, 
-					student_uid AS uid, 
-					bezeichnung, 
-					gesamt AS gesamtstunden, 
-					anwesend, 
-					nichtanwesend, 
-					CASE WHEN gesamt = 0 THEN 100.00 ELSE trunc(100-(nichtanwesend/(gesamt))*100,2) END AS prozent
-
-				FROM(
-					SELECT 
-					vorname, 
-					nachname, 
-					wahlname, 
-					lehrveranstaltung_id, 
-					bezeichnung, 
-					student_uid, 
-					--COUNT(stundenplan_id) AS gesamts, 
-					COALESCE(anwesend.summe, 0) + COALESCE(nichtanwesend.summe, 0) AS gesamt,
-					COALESCE(anwesend.summe, 0) AS anwesend, 
-					COALESCE(nichtanwesend.summe, 0) AS nichtanwesend
-					
+		$qry = "SELECT
+					lehrveranstaltung_id, vorname, nachname, wahlname, student_uid as uid, bezeichnung,
+					gesamt as gesamtstunden, anwesend, nichtanwesend, trunc(100-(nichtanwesend/gesamt)*100,2) as prozent
+				FROM
+				(
+					SELECT
+						vorname, nachname, wahlname, lehrveranstaltung_id, bezeichnung, gruppe, student_uid,
+						count(stundenplan_id) as gesamt,
+						case when anwesend.summe is null then 0 else anwesend.summe end as anwesend,
+						case when nichtanwesend.summe is null then 0 else nichtanwesend.summe end as nichtanwesend
 					FROM
 					(
-						SELECT 
-							SUM(stundenplan_id) AS stundenplan_id, 
-							datum, 
-							stunde, 
-							lehrveranstaltung_id, 
-							bezeichnung, 
-							studiensemester_kurzbz, 
-							studiengang_kz
-
+						SELECT
+							sum(stundenplan_id) as stundenplan_id, datum, stunde, lehrveranstaltung_id,
+							bezeichnung, studiensemester_kurzbz, studiengang_kz,
+							TRIM(
+								CASE WHEN stp.gruppe_kurzbz is not null then stp.gruppe_kurzbz
+								else stp.semester||(case when verband is null then '' else stp.verband end)||(case when stp.gruppe is null then '' else stp.gruppe end) end) as gruppe
 						FROM
 							lehre.tbl_lehrveranstaltung lv
-						JOIN 
-							lehre.tbl_lehreinheit le USING (lehrveranstaltung_id)
-						JOIN
-							lehre.tbl_stundenplan stp USING (lehreinheit_id,studiengang_kz)
-
+							JOIN lehre.tbl_lehreinheit le using (lehrveranstaltung_id)
+							JOIN lehre.tbl_stundenplan stp using (lehreinheit_id,studiengang_kz)
 						WHERE
 							studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
-							AND (titel NOT LIKE '%Nebenprüfung%' OR titel IS NULL)
-						
-						GROUP BY 
-							datum, 
-							stunde, 
-							lehrveranstaltung_id, 
-							bezeichnung, 
-							studiensemester_kurzbz, 
-							studiengang_kz, 
-							stp.gruppe_kurzbz, 
-							stp.semester, 
-							stp.verband, 
-							stp.gruppe
+							AND (titel not like '%Nebenprüfung%' OR titel is null)
+
+						group by datum, stunde, lehrveranstaltung_id, bezeichnung, studiensemester_kurzbz, studiengang_kz, stp.gruppe_kurzbz, stp.semester, stp.verband, stp.gruppe
 					)x
 					JOIN (
-						SELECT
-							le.lehrveranstaltung_id,
-							slv.student_uid,
-							le.studiensemester_kurzbz,
-							st.prestudent_id
-
-						FROM 
-							public.tbl_studentlehrverband slv
-						JOIN 
-							lehre.tbl_lehreinheitgruppe leg 
-							  ON slv.studiengang_kz = leg.studiengang_kz 
-							  AND slv.semester = leg.semester
-							  AND (
-									NULLIF(btrim(leg.verband::text), '') IS NULL
-									OR NULLIF(btrim(slv.verband::text), '') = NULLIF(btrim(leg.verband::text), '')
-								   )
-							  AND (
-									NULLIF(btrim(leg.gruppe::text), '') IS NULL
-									OR NULLIF(btrim(slv.gruppe::text), '') = NULLIF(btrim(leg.gruppe::text), '')
-								   )
-						JOIN 
-							lehre.tbl_lehreinheit le USING (lehreinheit_id, studiensemester_kurzbz)
-						JOIN 
-							public.tbl_student st USING(student_uid)
-
-						WHERE 
-							leg.gruppe_kurzbz IS NULL
-							AND le.studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
-
-						GROUP BY
-							le.lehrveranstaltung_id,
-							slv.student_uid,
-							le.studiensemester_kurzbz,
-							st.prestudent_id
+						SELECT semester::text  as gruppe, public.tbl_studentlehrverband.studiensemester_kurzbz, student_uid, studiengang_kz
+						FROM
+							public.tbl_studentlehrverband
+						WHERE studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
 
 						UNION
 
+						SELECT  semester||verband  as gruppe, public.tbl_studentlehrverband.studiensemester_kurzbz, student_uid, studiengang_kz
+						FROM
+							public.tbl_studentlehrverband
+						WHERE
+							studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
+
+						UNION
+
+						SELECT  semester||verband||gruppe as gruppe, public.tbl_studentlehrverband.studiensemester_kurzbz, student_uid, studiengang_kz
+						FROM
+							public.tbl_studentlehrverband
+						WHERE
+							studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
+
+						UNION
+
+						SELECT gruppe_kurzbz as gruppe, public.tbl_benutzergruppe.studiensemester_kurzbz, uid as student_uid, studiengang_kz
+						FROM
+							public.tbl_benutzergruppe
+						JOIN
+							public.tbl_gruppe using (gruppe_kurzbz)
+						WHERE studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
+
+					)a using (gruppe, studiensemester_kurzbz, studiengang_kz)
+					JOIN public.tbl_benutzer b on b.uid = student_uid
+					JOIN public.tbl_person p using(person_id)
+					LEFT JOIN(
 						SELECT
-							le.lehrveranstaltung_id,
-							bg.uid AS student_uid,
-							bg.studiensemester_kurzbz,
-							st.prestudent_id
-
-						FROM 
-							public.tbl_benutzergruppe bg
-						JOIN 
-							lehre.tbl_lehreinheitgruppe leg USING (gruppe_kurzbz)
-						JOIN 
-							lehre.tbl_lehreinheit le USING(lehreinheit_id, studiensemester_kurzbz)
-						JOIN
-							public.tbl_student st ON bg.uid = st.student_uid
-					
-						WHERE 
-							bg.studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
-
-						GROUP BY
-							le.lehrveranstaltung_id,
-							bg.uid,
-							bg.studiensemester_kurzbz,
-							st.prestudent_id
-						
-					)a USING (lehrveranstaltung_id, studiensemester_kurzbz)
-					JOIN
-						public.tbl_benutzer b on b.uid = student_uid
-					JOIN 
-						public.tbl_person p using(person_id)
-					LEFT JOIN(
-						SELECT 
-							lehrveranstaltung_id, 
-							studiensemester_kurzbz, 
-							uid AS student_uid, 
-							SUM(einheiten) AS summe
-
+							lehrveranstaltung_id, studiensemester_kurzbz, uid as student_uid, sum(einheiten) as summe
 						FROM
 							campus.tbl_anwesenheit a
-						JOIN
-							lehre.tbl_lehreinheit le USING(lehreinheit_id)
-						JOIN
-							lehre.tbl_lehrveranstaltung lv USING (lehrveranstaltung_id)
-							
+							JOIN lehre.tbl_lehreinheit le using (lehreinheit_id)
+							JOIN lehre.tbl_lehrveranstaltung lv using (lehrveranstaltung_id)
 						WHERE
-							anwesend = true 
-							AND studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
-
+							anwesend = true AND studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
 						GROUP BY
-							lehrveranstaltung_id, 
-							bezeichnung, 
-							uid, 
-							studiensemester_kurzbz
-							
-					)anwesend USING(lehrveranstaltung_id, student_uid, studiensemester_kurzbz)
+							lehrveranstaltung_id, bezeichnung, uid, studiensemester_kurzbz
+					)anwesend using(lehrveranstaltung_id, student_uid, studiensemester_kurzbz)
 					LEFT JOIN(
-						SELECT 
-							lehrveranstaltung_id, 
-							studiensemester_kurzbz, 
-							uid AS student_uid, 
-							SUM(einheiten) AS summe
-
+						SELECT lehrveranstaltung_id, studiensemester_kurzbz, uid as student_uid, sum(einheiten) as summe
 						FROM
 							campus.tbl_anwesenheit a
-						JOIN
-							lehre.tbl_lehreinheit le USING (lehreinheit_id)
-						JOIN
-							lehre.tbl_lehrveranstaltung lv USING (lehrveranstaltung_id)
-							
+							JOIN lehre.tbl_lehreinheit le using (lehreinheit_id)
+							JOIN lehre.tbl_lehrveranstaltung lv using (lehrveranstaltung_id)
 						WHERE
-							anwesend = false 
-							AND studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
-
+							anwesend = false AND studiensemester_kurzbz = ".$this->db_add_param($studiensemester_kurzbz)."
 						GROUP BY
-							lehrveranstaltung_id, 
-							bezeichnung, 
-							uid, 
-							studiensemester_kurzbz
-					)nichtanwesend USING(lehrveranstaltung_id, student_uid, studiensemester_kurzbz)
-
+							lehrveranstaltung_id, bezeichnung, uid, studiensemester_kurzbz
+					)nichtanwesend using(lehrveranstaltung_id, student_uid, studiensemester_kurzbz)
 					WHERE
 						lehrveranstaltung_id > 0
 			";
@@ -664,15 +573,8 @@ class anwesenheit extends basis_db
 			if(!is_null($lehrveranstaltung_id))
 				$qry.="	AND lehrveranstaltung_id=".$this->db_add_param($lehrveranstaltung_id);
 
-			$qry.="	GROUP BY
-						vorname, 
-						nachname, 
-						wahlname, 
-						lehrveranstaltung_id, 
-						bezeichnung, 
-						student_uid, 
-						anwesend.summe, 
-						nichtanwesend.summe
+			$qry.="group by
+					vorname, nachname, wahlname, lehrveranstaltung_id, bezeichnung, gruppe, student_uid, anwesend.summe, nichtanwesend.summe
 				)m";
 
 			if($lehrveranstaltung_id != '')

include/externe_ueberwachung.class.php

@@ -1,221 +0,0 @@
-<?php
-
-require_once(dirname(__FILE__).'/basis_db.class.php');
-require_once(dirname(__FILE__).'/prestudent.class.php');
-require_once(dirname(__FILE__).'/person.class.php');
-require_once(dirname(__FILE__).'/reihungstest.class.php');
-
-require_once(dirname(__FILE__).'/../vendor/autoload.php');
-use Firebase\JWT\JWT;
-
-class externeUeberwachung extends basis_db
-{
-	public function __construct()
-	{
-		parent::__construct();
-	}
-
-	public function getStatusByPrestudent($prestudent_id)
-	{
-		$session_id = $this->getSessionByPrestudent($prestudent_id);
-		return $this->getSessionStatus($session_id);
-	}
-	public function start($prestudent_id, $reihungstest_id, $sprache)
-	{
-		$session_id = $this->getSessionByPrestudent($prestudent_id);
-
-		if (!$session_id)
-		{
-			$session_id = $this->createSession($prestudent_id);
-		}
-		else
-		{
-			$status = $this->getSessionStatus($session_id);
-
-			if (in_array($status, array('late_to_start', 'finished')))
-			{
-				$session_id = $this->createSession($prestudent_id);
-			}
-		}
-
-		$payload = $this->getPayload($session_id, $prestudent_id, $reihungstest_id, $sprache);
-		return $this->getStartUrl($payload);
-	}
-
-
-	private function createSession($prestudent_id)
-	{
-		if (is_null($prestudent_id))
-		{
-			$this->errormsg = 'Falsche Parameterübergabe';
-			return false;
-		}
-
-		$uuid = $this->genereateUUID();
-
-		$qry = "INSERT INTO testtool.tbl_externe_ueberwachung (prestudent_id, session_id)
-				VALUES (".
-			$this->db_add_param($prestudent_id).",".
-			$this->db_add_param($uuid).")";
-
-		if($this->db_query($qry))
-		{
-			return $uuid;
-		}
-		else
-		{
-			$this->errormsg = 'Fehler beim Speichern der Antwort';
-			return false;
-		}
-	}
-	public function getSessionByPrestudent($prestudent_id)
-	{
-		if (is_null($prestudent_id))
-		{
-			$this->errormsg = 'Falsche Parameterübergabe';
-			return false;
-		}
-
-		$qry = "SELECT session_id
-				FROM testtool.tbl_externe_ueberwachung
-				WHERE prestudent_id = ".$this->db_add_param($prestudent_id, FHC_INTEGER) . "
-				ORDER BY insertamum DESC
-				LIMIT 1";
-
-		if($result = $this->db_query($qry))
-		{
-			if ($row = $this->db_fetch_object($result))
-			{
-				return $row->session_id;
-			}
-			else
-			{
-				$this->errormsg = 'Daten konnten nicht geladen werden';
-				return false;
-			}
-		}
-		else
-		{
-			$this->errormsg = 'Fehler bei einer Abfrage';
-			return false;
-		}
-	}
-
-	public function getSessionStatus($session_id)
-	{
-		$payload = $this->getSessionPayload($session_id);
-		$jwt = $this->createToken($payload);
-
-		$url = $this->getSessionUrl($session_id);
-
-		$ch = curl_init($url);
-		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
-		curl_setopt($ch, CURLOPT_HTTPHEADER, [
-			"Authorization: JWT {$jwt}",
-			"Content-Type: application/json",
-		]);
-		curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'GET');
-
-		$response = curl_exec($ch);
-		$httpCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
-
-		curl_close($ch);
-
-		$data = json_decode($response, true);
-		return isset($data['status']) ? $data['status'] : false;
-	}
-
-	private function getSessionPayload($session_id)
-	{
-		return [
-			"session_id" => $session_id,
-			"iat" => time(),
-			"exp" => time() + 120,
-		];
-	}
-
-	private function getPayload($session_id, $prestudent_id, $reihungstest_id, $sprache)
-	{
-		$prestudent = new prestudent($prestudent_id);
-		$person = new Person($prestudent->person_id);
-
-		$reihungstest = new Reihungstest($reihungstest_id);
-
-		$datetime = new DateTime();
-		$today = $datetime->format('Y-m-d');
-
-		$payload = [
-			"userId" => $prestudent_id,
-			"lastName" => $person->nachname,
-			"firstName" => $person->vorname,
-			"language" => $sprache === 'German' ? 'de' : 'en',
-			"accountName" => "technikum_wien",
-			"accountId" => "technikum_wien",
-			"examId" => $reihungstest_id . '_' . $today,
-			"examName" => !is_null(trim($reihungstest->anmerkung)) ? ($reihungstest->anmerkung . '_' . $today) : ($reihungstest_id . '_' . $today),
-			"duration" => 1440,
-			"schedule" => false,
-			"trial" => EXTERNE_UEBERWACHUNG_TRIAL_TEST,
-			"proctoring" => "offline",
-			"startDate" => $reihungstest->datum . 'T00:00:00Z',
-			"endDate" => $reihungstest->datum . 'T23:59:59Z',
-			"sessionId" => $session_id,
-			"sessionUrl" => EXTERNE_UEBERWACHUNG_SESSION_URL
-		];
-
-		if (defined('EXTERNE_UEBERWACHUNG_EXAM_PARAMS'))
-		{
-			$payload = array_merge($payload, EXTERNE_UEBERWACHUNG_EXAM_PARAMS);
-		}
-
-		if (defined('EXTERNE_UEBERWACHUNG_EXAM_WARNINGS'))
-		{
-			$payload['visibleWarnings'] = EXTERNE_UEBERWACHUNG_EXAM_WARNINGS;
-		}
-
-		if (defined('EXTERNE_UEBERWACHUNG_EXAM_RULES'))
-		{
-			$payload['rules'] = EXTERNE_UEBERWACHUNG_EXAM_RULES;
-		}
-
-		if (defined('EXTERNE_UEBERWACHUNG_EXAM_SCORE'))
-		{
-			$payload['scoreConfig'] = EXTERNE_UEBERWACHUNG_EXAM_SCORE;
-		}
-
-		return $payload;
-	}
-
-	private function getSessionUrl($session_id)
-	{
-		return EXTERNE_UEBERWACHUNG_PROTOCOL_URL . "/api/v2/integration/simple/". EXTERNE_UEBERWACHUNG_INTEGRATION_NAME . "/sessions/". urlencode($session_id) ."/status/";
-	}
-
-	private function getStartUrl($payload)
-	{
-		$token = $this->createToken($payload);
-		$query = http_build_query(['token' => $token]);
-
-		return EXTERNE_UEBERWACHUNG_PROTOCOL_URL . '/integration/simple/'. EXTERNE_UEBERWACHUNG_INTEGRATION_NAME .'/start?' . $query;
-	}
-
-	private function createToken($payload)
-	{
-		return JWT::encode($payload, EXTERNE_UEBERWACHUNG_SECRET_KEY, 'HS256');
-	}
-
-	private function genereateUUID()
-	{
-		$data = openssl_random_pseudo_bytes(16);
-
-		$data[6] = chr(ord($data[6]) & 0x0f | 0x40);
-		$data[8] = chr(ord($data[8]) & 0x3f | 0x80);
-
-		return vsprintf('%s%s-%s-%s-%s-%s%s%s', str_split(bin2hex($data), 4));
-	}
-}
-
-?>
-
-
-

include/gebiet.class.php

@@ -345,7 +345,6 @@ class gebiet extends basis_db
 		}
 
 		//Pruefen ob jede Fragen mindestens 2 Vorschlaege hat
-		//Angepasst am 28.01.2026 auf ein Warning.
 		$qry = "SELECT frage_id, nummer FROM testtool.tbl_frage
 				WHERE (SELECT count(*) as anzahl FROM testtool.tbl_vorschlag WHERE frage_id=tbl_frage.frage_id)<2
 				AND gebiet_id=".$this->db_add_param($gebiet_id, FHC_INTEGER)." AND NOT demo;";
@@ -353,7 +352,7 @@ class gebiet extends basis_db
 		{
 			while($row = $this->db_fetch_object())
 			{
-				$this->warningmsg .= "Frage Nummer $row->nummer (ID: $row->frage_id) hat weniger als 2 Vorschlaege.\n";
+				$this->errormsg .= "Frage Nummer $row->nummer (ID: $row->frage_id) hat weniger als 2 Vorschlaege.\n";
 			}
 		}
 
@@ -449,52 +448,6 @@ class gebiet extends basis_db
 			}
 		}
 
-		//Pruefen ob es leere Fragen (ohne Text, Bild oder Audio) gibt
-		$qry = "SELECT
-					fr.frage_id,
-					fr.nummer,
-					fs.sprache
-				FROM
-					testtool.tbl_frage fr
-				JOIN testtool.tbl_frage_sprache fs
-						USING (frage_id)
-				WHERE
-					(fs.text IS NULL
-						OR fs.text = '')
-					AND fs.bild IS NULL
-					AND fs.audio IS NULL
-					AND demo = false
-					AND gebiet_id=".$this->db_add_param($gebiet_id, FHC_INTEGER)." 
-					AND EXISTS (
-					SELECT
-						1
-					FROM
-						testtool.tbl_frage fr2
-					JOIN testtool.tbl_frage_sprache fs2
-							USING (frage_id)
-					WHERE
-						fs2.sprache = fs.sprache
-						AND fr2.gebiet_id = fr.gebiet_id
-						AND fr2.frage_id != fr.frage_id
-						AND (
-							(fs2.text IS NOT NULL
-							AND fs2.text != '')
-						OR fs2.bild IS NOT NULL
-						OR fs2.audio IS NOT NULL
-							)
-						AND demo = false
-					)
-				ORDER BY
-					fs.sprache,
-					fr.nummer;";
-		if($this->db_query($qry))
-		{
-			while($row = $this->db_fetch_object())
-			{
-				$this->warningmsg .= "Frage Nummer $row->nummer (ID: $row->frage_id), Sprache $row->sprache hat keinen Text, Bild oder Audio.\n";
-			}
-		}
-
 		if($this->errormsg=='')
 			return true;
 		else

include/lehrveranstaltung.class.php

@@ -70,7 +70,6 @@ class lehrveranstaltung extends basis_db
 	public $farbe;
 	public $lehrauftrag=true;
 	public $lehrveranstaltung_template_id; // integer
-	public $evaluierung=true; // boolean
 
 
 	public $studienplan_lehrveranstaltung_id;
@@ -171,7 +170,6 @@ class lehrveranstaltung extends basis_db
 			$this->benotung = $this->db_parse_bool($row->benotung);
 			$this->lvinfo = $this->db_parse_bool($row->lvinfo);
 			$this->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-			$this->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 			// FIXME: LV-Bezeichnung richtig mehrsprachig machen
 			// Zwischenzeitlich 'Italian' zum bezeichnung_arr dazugegeben
@@ -246,7 +244,6 @@ class lehrveranstaltung extends basis_db
 			$lv_obj->benotung = $this->db_parse_bool($row->benotung);
 			$lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 			$lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-			$lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 			$lv_obj->bezeichnung_arr['German'] = $row->bezeichnung;
 			$lv_obj->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -397,7 +394,6 @@ class lehrveranstaltung extends basis_db
 			$lv_obj->benotung = $this->db_parse_bool($row->benotung);
 			$lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 			$lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-			$lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 			$lv_obj->bezeichnung_arr['German'] = $row->bezeichnung;
 			$lv_obj->bezeichnung_arr['Italian'] = $row->bezeichnung;
@@ -528,7 +524,6 @@ class lehrveranstaltung extends basis_db
 			$lv_obj->benotung = $this->db_parse_bool($row->benotung);
 			$lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 			$lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-			$lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 			$lv_obj->bezeichnung_arr['German'] = $row->bezeichnung;
 			$lv_obj->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -612,7 +607,6 @@ class lehrveranstaltung extends basis_db
 			$lv_obj->benotung = $this->db_parse_bool($row->benotung);
 			$lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 			$lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-			$lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 			$lv_obj->bezeichnung_arr['German'] = $row->bezeichnung;
 			$lv_obj->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -785,7 +779,7 @@ class lehrveranstaltung extends basis_db
 				insertvon, planfaktor, planlektoren, planpersonalkosten, plankostenprolektor, updateamum, updatevon, sort,
 				zeugnis, projektarbeit, sprache, koordinator, bezeichnung_english, orgform_kurzbz, incoming, lehrtyp_kurzbz, oe_kurzbz,
 				raumtyp_kurzbz, anzahlsemester, semesterwochen, lvnr, semester_alternativ, farbe, lehrveranstaltung_template_id,sws,lvs,alvs,lvps,las,benotung,lvinfo,
-				lehrauftrag, lehrmodus_kurzbz, evaluierung) VALUES ('.
+				lehrauftrag, lehrmodus_kurzbz) VALUES ('.
 					$this->db_add_param($this->studiengang_kz). ', '.
 					$this->db_add_param($this->bezeichnung). ', '.
 					$this->db_add_param($this->kurzbz). ', '.
@@ -830,8 +824,7 @@ class lehrveranstaltung extends basis_db
 					$this->db_add_param($this->benotung, FHC_BOOLEAN).','.
 					$this->db_add_param($this->lvinfo, FHC_BOOLEAN).','.
 					$this->db_add_param($this->lehrauftrag, FHC_BOOLEAN).','.
-					$this->db_add_param($this->lehrmodus_kurzbz).','.
-					$this->db_add_param($this->evaluierung, FHC_BOOLEAN)
+					$this->db_add_param($this->lehrmodus_kurzbz)
 					.');';
 		}
 		else
@@ -887,8 +880,7 @@ class lehrveranstaltung extends basis_db
 					'las = '.$this->db_add_param($this->las).', '.
 					'benotung = '.$this->db_add_param($this->benotung, FHC_BOOLEAN).', '.
 					'lvinfo = '.$this->db_add_param($this->lvinfo, FHC_BOOLEAN).', '.
-					'lehrauftrag = '.$this->db_add_param($this->lehrauftrag, FHC_BOOLEAN).', '.
-					'evaluierung = '.$this->db_add_param($this->evaluierung, FHC_BOOLEAN).' '.
+					'lehrauftrag = '.$this->db_add_param($this->lehrauftrag, FHC_BOOLEAN).' '.
 					'WHERE lehrveranstaltung_id = ' . $this->db_add_param($this->lehrveranstaltung_id, FHC_INTEGER, false) . ';';
 		}
 
@@ -999,7 +991,6 @@ class lehrveranstaltung extends basis_db
 				$lv_obj->benotung = $this->db_parse_bool($row->benotung);
 				$lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 				$lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-				$lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 				$lv_obj->bezeichnung_arr['German'] = $row->bezeichnung;
 				$lv_obj->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -1095,7 +1086,6 @@ class lehrveranstaltung extends basis_db
 				$l->benotung = $this->db_parse_bool($row->benotung);
 				$l->lvinfo = $this->db_parse_bool($row->lvinfo);
 				$l->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-				$l->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 				$l->bezeichnung_arr['German'] = $row->bezeichnung;
 				$l->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -1180,7 +1170,6 @@ class lehrveranstaltung extends basis_db
 			$lv_obj->benotung = $this->db_parse_bool($row->benotung);
 			$lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 			$lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-			$lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 			$lv_obj->bezeichnung_arr['German'] = $row->bezeichnung;
 			$lv_obj->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -1282,7 +1271,6 @@ class lehrveranstaltung extends basis_db
 				$obj->benotung = $this->db_parse_bool($row->benotung);
 				$obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 				$obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-				$obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 				$obj->bezeichnung_arr['German'] = $row->bezeichnung;
 				$obj->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -1408,7 +1396,6 @@ class lehrveranstaltung extends basis_db
 				$obj->lvinfo =$this->db_parse_bool( $lv->lvinfo);
 				$obj->zeugnis = $this->db_parse_bool($lv->zeugnis);
 				$obj->lehrauftrag = $this->db_parse_bool($lv->lehrauftrag);
-				$obj->evaluierung = $this->db_parse_bool($lv->evaluierung);
 
 				$values[] = $obj;
 
@@ -1435,7 +1422,6 @@ class lehrveranstaltung extends basis_db
 			$obj->lvinfo =$this->db_parse_bool( $this->lvinfo);
 			$obj->zeugnis = $this->db_parse_bool($this->zeugnis);
 			$obj->lehrauftrag = $this->db_parse_bool($this->lehrauftrag);
-			$obj->evaluierung = $this->db_parse_bool($this->evaluierung);
 
 			$values[] = $obj;
 		}
@@ -1490,7 +1476,6 @@ class lehrveranstaltung extends basis_db
 				$obj->export = $lv->export;
 				$obj->genehmigung = $lv->genehmigung;
 				$obj->lehrauftrag = $lv->lehrauftrag;
-				$obj->evaluierung = $lv->evaluierung;
 				$obj->lehre = $lv->lehre;
 				$obj->children = array();
 				if(count($lv->childs) > 0)
@@ -1522,7 +1507,6 @@ class lehrveranstaltung extends basis_db
 			$obj->zeugnis = $this->db_parse_bool($this->zeugnis);
 			$obj->curriculum = $this->db_parse_bool($this->curriculum);
 			$obj->lehrauftrag = $this->lehrauftrag;
-			$obj->evaluierung = $this->db_parse_bool($this->evaluierung);
 
 			$values[] = $obj;
 		}
@@ -1629,7 +1613,6 @@ class lehrveranstaltung extends basis_db
 				$lv_obj->benotung = $this->db_parse_bool($row->benotung);
 				$lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 				$lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-				$lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 				$lv_obj->bezeichnung_arr['German'] = $row->bezeichnung;
 				$lv_obj->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -1717,7 +1700,6 @@ class lehrveranstaltung extends basis_db
                 $lv_obj->benotung = $this->db_parse_bool($row->benotung);
                 $lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
                 $lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-                $lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
                 $lv_obj->bezeichnung_arr['German'] = $row->bezeichnung;
                 $lv_obj->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -1891,7 +1873,6 @@ class lehrveranstaltung extends basis_db
 			$lv_obj->benotung = $this->db_parse_bool($row->benotung);
 			$lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 			$lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-			$lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 			$lv_obj->bezeichnung_arr['German'] = $row->bezeichnung;
 			$lv_obj->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -2022,7 +2003,6 @@ class lehrveranstaltung extends basis_db
 				$lv_obj->benotung = $this->db_parse_bool($row->benotung);
 				$lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 				$lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-				$lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 				$lv_obj->studiengang_kurzbzlang = $row->studiengang_kurzbzlang;
 
@@ -2151,7 +2131,6 @@ class lehrveranstaltung extends basis_db
 				$lv_obj->benotung = $this->db_parse_bool($row->benotung);
 				$lv_obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 				$lv_obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-				$lv_obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 				$lv_obj->bezeichnung_arr['German'] = $row->bezeichnung;
 				$lv_obj->bezeichnung_arr['English'] = $row->bezeichnung_english;
@@ -2423,7 +2402,6 @@ class lehrveranstaltung extends basis_db
 				$obj->benotung = $this->db_parse_bool($row->benotung);
 				$obj->lvinfo = $this->db_parse_bool($row->lvinfo);
 				$obj->lehrauftrag = $this->db_parse_bool($row->lehrauftrag);
-				$obj->evaluierung = $this->db_parse_bool($row->evaluierung);
 
 				$obj->bezeichnung_arr['German'] = $row->bezeichnung;
 				$obj->bezeichnung_arr['English'] = $row->bezeichnung_english;

include/reihungstest.class.php

@@ -63,7 +63,6 @@ class reihungstest extends basis_db
 	
 	public $zugangs_ueberpruefung = false; //boolean
 	public $zugangscode; //smallint
-	public $externe_ueberwachung = false; //boolean
 
 
 	/**
@@ -120,7 +119,6 @@ class reihungstest extends basis_db
 				$this->aufnahmegruppe_kurzbz = $row->aufnahmegruppe_kurzbz;
 				$this->zugangs_ueberpruefung = $this->db_parse_bool($row->zugangs_ueberpruefung);
 				$this->zugangscode = $row->zugangscode;
-				$this->externe_ueberwachung = $this->db_parse_bool($row->externe_ueberwachung);
 
 				return true;
 			}
@@ -236,7 +234,7 @@ class reihungstest extends basis_db
 
 			$qry = 'BEGIN; INSERT INTO public.tbl_reihungstest (studiengang_kz, ort_kurzbz, anmerkung, datum, uhrzeit,
 				insertamum, insertvon, updateamum, updatevon, max_teilnehmer, oeffentlich, freigeschaltet,
-				studiensemester_kurzbz, stufe, anmeldefrist, aufnahmegruppe_kurzbz, zugangs_ueberpruefung, zugangscode, externe_ueberwachung) VALUES('.
+				studiensemester_kurzbz, stufe, anmeldefrist, aufnahmegruppe_kurzbz, zugangs_ueberpruefung, zugangscode) VALUES('.
 				$this->db_add_param($this->studiengang_kz, FHC_INTEGER).', '.
 				$this->db_add_param($this->ort_kurzbz).', '.
 				$this->db_add_param($this->anmerkung).', '.
@@ -252,8 +250,7 @@ class reihungstest extends basis_db
 				$this->db_add_param($this->anmeldefrist).','.
 				$this->db_add_param($this->aufnahmegruppe_kurzbz). ',' .
 				$this->db_add_param($this->zugangs_ueberpruefung, FHC_BOOLEAN).','.
-				$this->db_add_param($this->zugangscode) . ','.
-				$this->db_add_param($this->externe_ueberwachung, FHC_BOOLEAN) . ');';
+				$this->db_add_param($this->zugangscode) . ');';
 		}
 		else
 		{
@@ -273,8 +270,7 @@ class reihungstest extends basis_db
 				'anmeldefrist='.$this->db_add_param($this->anmeldefrist).', '.
 				'aufnahmegruppe_kurzbz='.$this->db_add_param($this->aufnahmegruppe_kurzbz).', '.
 				'zugangs_ueberpruefung='.$this->db_add_param($this->zugangs_ueberpruefung, FHC_BOOLEAN).', '.
-				'zugangscode='.$this->db_add_param($this->zugangscode).', '.
-				'externe_ueberwachung='.$this->db_add_param($this->externe_ueberwachung, FHC_BOOLEAN).' '.
+				'zugangscode='.$this->db_add_param($this->zugangscode).' '.
 				'WHERE reihungstest_id='.$this->db_add_param($this->reihungstest_id, FHC_INTEGER, false).';';
 		}
 

include/statistik.class.php

@@ -513,7 +513,6 @@ class statistik extends basis_db
 		$this->json=array();
 		$this->countRows=0;
 		set_time_limit(600);
-		$parseHtml = (strpos($this->preferences, 'parseHTML: true') !== false);
 
 		// In case a decryption function is used then perform password substitution
 		$this->sql = $this->replaceSQLDecryptionPassword($this->sql);
@@ -566,13 +565,7 @@ class statistik extends basis_db
 					for($spalte=0;$spalte<$anzahl_spalten;$spalte++)
 					{
 						$name = $this->db_field_name($this->data,$spalte);
-						if ($parseHtml) {
-							// HTML direkt rendern
-							$this->html .= '<td>'.($row->$name).'</td>';
-						} else {
-							// wie bisher escapen
-							$this->html .= '<td>'.$this->convert_html_chars($row->$name).'</td>';
-						}
+						$this->html.= '<td>'.$this->convert_html_chars($row->$name).'</td>';
 						// Umwandeln von Punkt in Komma bei Float-Werten
 						if (is_numeric($row->$name))
 						{

include/tw/cis_menu_lv.inc.php

@@ -500,27 +500,6 @@ if((!defined('CIS_LEHRVERANSTALTUNG_ANRECHNUNG_ANZEIGEN') || CIS_LEHRVERANSTALTU
 	);
 }
 
-// LV-Evaluierung NEU
-if(defined('CIS_LEHRVERANSTALTUNG_EVALUIERUNG_ANZEIGEN')
-	&& CIS_LEHRVERANSTALTUNG_EVALUIERUNG_ANZEIGEN
-	&& $angemeldet
-	&& (!defined('CIS_EVALUIERUNG_ANZEIGEN_STG') || in_array($lv->studiengang_kz, unserialize(CIS_EVALUIERUNG_ANZEIGEN_STG)))
-	&& ($rechte->isBerechtigt('extension/lvevaluierung_init')))
-{
-	$text='(Pilotphase)';
-
-	$link= APP_ROOT. 'index.ci.php/extensions/FHC-Core-Evaluierung/Initiierung?lehrveranstaltung_id='. urlencode($lv->lehrveranstaltung_id).'&studiensemester_kurzbz='.urlencode($angezeigtes_stsem);
-
-	$menu[]=array
-	(
-		'id'=>'extension_lvevaluierung_menu_initiierung',
-		'position'=>'140',
-		'name'=>$p->t('lvevaluierung/lvevaluierung'). ' - '. strtoupper($p->t('global/neu')),
-		'icon'=>'../../../skin/images/button_lvevaluierung.png',
-		'link'=> $link,
-		'text'=>$text
-	);
-}
 
 //************* Menuepunkte anzeigen ****************
 

locale/de-AT/testtool.php

@@ -53,10 +53,6 @@ $this->phrasen['testtool/fuerFolgendeStgAngemeldet']='Für folgende Studiengäng
 $this->phrasen['testtool/invalideGebiete']='Ein oder mehrere Fragengebiet/e inkorrekt!<br>Bitte melden Sie dies der Betreuungsperson.';
 $this->phrasen['testtool/confirmationText']='<b>Ich bestätige, den Online-Reihungstest persönlich, selbständig, ohne Hilfe einer zusätzlichen Person und ohne Hilfsmittel zu absolvieren.<br>
 											I confirm that I will complete the online placement test personally, independently, without the help of an additional person and without any aids.</b>';
-$this->phrasen['testtool/dsgvoConfirmText']='<b>Ich habe die <a href ="'. APP_ROOT. 'cms/dms.php?id=373121" target="_blank">Datenschutzerklärung</a> gelesen. <br />
-I have read the <a href ="'. APP_ROOT. 'cms/dms.php?id=374814" target="_blank">privacy policy</a>.</b>';
-$this->phrasen['testtool/procotoringConfirmText']='<b>Ich stimme der digitalen Beaufsichtigung beim Online-Reihungstest (Proctoring) zu. <br /> 
-I agree to the digital supervision of the online placement test (proctoring).</b>';
 $this->phrasen['testtool/loginNoetig']='Bitte beachten Sie, dass der Reihungstest erst <b>unmittelbar</b> vor Ihrem <b>Reihungstesttermin</b> von uns aktiviert wird.<br>
 										Please note that the test will be activated by us <b>immediately</b> before your <b>placement test date</b>.';
 $this->phrasen['testtool/start']='Reihungstest jetzt starten';

public/.htaccess_sample

@@ -1,9 +0,0 @@
-<IfModule mod_rewrite.c>
-    RewriteEngine On
-    RewriteCond %{REQUEST_FILENAME} !-f
-    RewriteCond %{REQUEST_FILENAME} !-d
-    RewriteRule ^[0-9]{10}/(.*)$ $1 [L]
-    RewriteCond %{REQUEST_URI} ^(.*?)/public/index.ci.php/
-    RewriteRule ^index.ci.php/(.*)$ %1/index.ci.php/$1 [R=303]
-</IfModule>
-

public/css/Cis4/Cis.css

@@ -407,6 +407,7 @@ html {
   background-color: var(--fhc-background);
   border-color: var(--fhc-border);
   padding: var(--fhc-cis-main-py) var(--fhc-cis-main-px);
+  min-width: 0; /* fix flex-grow with tabulator exceeding width */
 }
 
 #cis-main .fa-arrow-up-right-from-square {
@@ -855,9 +856,3 @@ html {
 	background-color: var(--fhc-secondary);
 	
 }
-
-.bordered-modal {
-	border: 1px solid rgba(0, 0, 0, 0.15);
-	border-radius: 0.5rem;
-	box-shadow: 0 4px 16px rgba(0, 0, 0, 0.25);
-}

public/css/components/abgabetool/abgabe.css

@@ -1,308 +0,0 @@
-/* Base Header */
-.verpasst-header {
-	background-color: var(--fhc-red-70);
-	font-weight: 600;
-	border-radius: 6px;
-	padding: 0px 0px 0px 34px;
-	transition: background-color 0.3s ease, box-shadow 0.3s ease, color 0.3s ease;
-	box-shadow: 0 1px 2px rgba(0,0,0,0.08);
-}
-
-/* Hover State */
-.verpasst-header:hover {
-	background-color: var(--fhc-red-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Active / Expanded State */
-.p-accordion-tab-active > .verpasst-header {
-	background-color: var(--fhc-red-50);
-	box-shadow: 0 2px 8px rgba(0,0,0,0.2);
-}
-
-/* Hover State Active*/
-.p-accordion-tab-active > .verpasst-header:hover {
-	background-color: var(--fhc-red-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Base Header */
-.abzugeben-header {
-	background-color: var(--fhc-yellow-70);
-	font-weight: 600;
-	border-radius: 6px;
-	padding: 0px 0px 0px 34px;
-	transition: background-color 0.3s ease, box-shadow 0.3s ease, color 0.3s ease;
-	box-shadow: 0 1px 2px rgba(0,0,0,0.08);
-}
-
-/* Hover State */
-.abzugeben-header:hover {
-	background-color: var(--fhc-yellow-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Active / Expanded State */
-.p-accordion-tab-active > .abzugeben-header {
-	background-color: var(--fhc-yellow-50);
-	box-shadow: 0 2px 8px rgba(0,0,0,0.2);
-}
-
-/* Hover State Active*/
-.p-accordion-tab-active > .abzugeben-header:hover {
-	background-color: var(--fhc-yellow-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Base Header */
-.beurteilungerforderlich-header {
-	background-color: var(--fhc-orange-70);
-	font-weight: 600;
-	border-radius: 6px;
-	padding: 0px 0px 0px 34px;
-	transition: background-color 0.3s ease, box-shadow 0.3s ease, color 0.3s ease;
-	box-shadow: 0 1px 2px rgba(0,0,0,0.08);
-}
-
-
-/* Hover State */
-.beurteilungerforderlich-header:hover {
-	background-color: var(--fhc-orange-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Active / Expanded State */
-.p-accordion-tab-active > .beurteilungerforderlich-header {
-	background-color: var(--fhc-orange-50);
-	box-shadow: 0 2px 8px rgba(0,0,0,0.2);
-}
-
-/* Hover State Active*/
-.p-accordion-tab-active > .beurteilungerforderlich-header:hover {
-	background-color: var(--fhc-orange-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Base Header */
-.verspaetet-header {
-	background-color: var(--fhc-pink-40);
-	font-weight: 600;
-	border-radius: 6px;
-	padding: 0px 0px 0px 34px;
-	transition: background-color 0.3s ease, box-shadow 0.3s ease, color 0.3s ease;
-	box-shadow: 0 1px 2px rgba(0,0,0,0.08);
-}
-
-/* Hover State */
-.verspaetet-header:hover {
-	background-color: var(--fhc-pink-20);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Active / Expanded State */
-.p-accordion-tab-active > .verspaetet-header {
-	background-color: var(--fhc-pink-30);
-	box-shadow: 0 2px 8px rgba(0,0,0,0.2);
-}
-
-/* Hover State Active*/
-.p-accordion-tab-active > .verspaetet-header:hover {
-	background-color: var(--fhc-pink-20);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Base Header */
-.abgegeben-header {
-	background-color: var(--fhc-green-70);
-	font-weight: 600;
-	border-radius: 6px;
-	padding: 0px 0px 0px 34px;
-	transition: background-color 0.3s ease, box-shadow 0.3s ease, color 0.3s ease;
-	box-shadow: 0 1px 2px rgba(0,0,0,0.08);
-}
-
-/* Hover State */
-.abgegeben-header:hover {
-	background-color: var(--fhc-green-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Active / Expanded State */
-.p-accordion-tab-active > .abgegeben-header {
-	background-color: var(--fhc-green-50);
-	box-shadow: 0 2px 8px rgba(0,0,0,0.2);
-}
-
-/* Hover State Active*/
-.p-accordion-tab-active > .abgegeben-header:hover {
-	background-color: var(--fhc-green-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-
-/* Base Header */
-.bestanden-header {
-	background-color: var(--fhc-green-70);
-	font-weight: 600;
-	border-radius: 6px;
-	padding: 0px 0px 0px 34px;
-	transition: background-color 0.3s ease, box-shadow 0.3s ease, color 0.3s ease;
-	box-shadow: 0 1px 2px rgba(0,0,0,0.08);
-}
-
-/* Hover State */
-.bestanden-header:hover {
-	background-color: var(--fhc-green-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Active / Expanded State */
-.p-accordion-tab-active > .bestanden-header {
-	background-color: var(--fhc-green-50);
-	box-shadow: 0 2px 8px rgba(0,0,0,0.2);
-}
-
-/* Hover State Active*/
-.p-accordion-tab-active > .bestanden-header:hover {
-	background-color: var(--fhc-green-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-
-/* Base Header */
-.nichtbestanden-header {
-	background-color: var(--fhc-red-70);
-	font-weight: 600;
-	border-radius: 6px;
-	padding: 0px 0px 0px 34px;
-	transition: background-color 0.3s ease, box-shadow 0.3s ease, color 0.3s ease;
-	box-shadow: 0 1px 2px rgba(0,0,0,0.08);
-}
-
-/* Hover State */
-.nichtbestanden-header:hover {
-	background-color: var(--fhc-red-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Active / Expanded State */
-.p-accordion-tab-active > .nichtbestanden-header {
-	background-color: var(--fhc-red-50);
-	box-shadow: 0 2px 8px rgba(0,0,0,0.2);
-}
-
-/* Hover State Active*/
-.p-accordion-tab-active > .nichtbestanden-header:hover {
-	background-color: var(--fhc-red-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-
-/* Base Header */
-.erledigt-header {
-	background-color: var(--fhc-red-70);
-	font-weight: 600;
-	border-radius: 6px;
-	padding: 0px 0px 0px 34px;
-	transition: background-color 0.3s ease, box-shadow 0.3s ease, color 0.3s ease;
-	box-shadow: 0 1px 2px rgba(0,0,0,0.08);
-}
-
-/* Hover State */
-.erledigt-header:hover {
-	background-color: var(--fhc-red-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Active / Expanded State */
-.p-accordion-tab-active > .erledigt-header {
-	background-color: var(--fhc-red-50);
-	box-shadow: 0 2px 8px rgba(0,0,0,0.2);
-}
-
-/* Hover State Active*/
-.p-accordion-tab-active > .erledigt-header:hover {
-	background-color: var(--fhc-red-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-
-/* Base Header */
-.standard-header {
-	background-color: var(--fhc-white-70);
-	font-weight: 600;
-	border-radius: 6px;
-	padding: 0px 0px 0px 34px;
-	transition: background-color 0.3s ease, box-shadow 0.3s ease, color 0.3s ease;
-	box-shadow: 0 1px 2px rgba(0,0,0,0.08);
-}
-
-/* Hover State */
-.standard-header:hover {
-	background-color: var(--fhc-white-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-/* Active / Expanded State */
-.p-accordion-tab-active > .standard-header {
-	background-color: var(--fhc-white-50);
-	box-shadow: 0 2px 8px rgba(0,0,0,0.2);
-}
-
-/* Hover State Active*/
-.p-accordion-tab-active > .standard-header:hover {
-	background-color: var(--fhc-white-60);
-	box-shadow: 0 2px 6px rgba(0,0,0,0.12);
-}
-
-#abgabetoolroot .modal-header{
-	background-color: var(--fhc-blue-primary);
-	color: var(--fhc-white-50);
-}
-
-#abgabetoolroot .modal-header .btn-close{
-	filter: invert(1);
-}
-
-#abgabetoolroot .modal-footer {
-	background-color: var(--fhc-white-20);
-
-}
-
-.bordered-modal {
-	border: 1px solid rgba(0, 0, 0, 0.15);
-	border-radius: 0.5rem;
-	box-shadow: 0 4px 16px rgba(0, 0, 0, 0.25);
-}
-
-.bordered-modal  .modal-body {
-	overflow-y: visible;
-}
-
-.p-accordion .p-accordion-header .p-accordion-header-link {
-	padding: 12px!important;
-}
-
-/* 1. Stick the Header */
-#abgabetable .tabulator-header .tabulator-col.sticky-col {
-	position: sticky;
-	left: 0;
-	z-index: 10; /* Must be higher than other headers */
-	background-color: #fff; /* Opaque background is required */
-	border-right: 2px solid #ddd; /* Optional: Separator line */
-}
-
-/* 2. Stick the Data Cells */
-#abgabetable .tabulator-tableholder .tabulator-row .tabulator-cell.sticky-col {
-	position: sticky;
-	left: 0;
-	z-index: 10; /* Ensure it floats above other cells */
-	background-color: #fff; /* Match your row background color */
-	border-right: 2px solid #ddd; /* Optional: Separator line */
-}
-
-/* 3. Fix for Hover Effects (Optional) */
-/* If you use hover rows, you need to ensure the sticky cell matches the hover color */
-#abgabetable .tabulator-row:hover .tabulator-cell.sticky-col {
-	background-color: #ccc; /* Match your existing hover color */
-}

public/css/tags.css

@@ -51,14 +51,6 @@
 	background-color: #6d4c41;
 }
 
-.tag_dark_grey {
-	background-color: #595959;
-}
-
-.tag_light_grey {
-	background-color: #9a9a9a;
-}
-
 .tag_blau {
 	background-color: #508498;
 }

public/css/theme/default.css

@@ -38,104 +38,15 @@
 	--fhc-blue-primary: #006095;
 	--fhc-blue-primary-highlight: #0086CB;
 
-	/* --- Green --- */
-	--fhc-green-5:  rgb(240, 250, 240);
-	--fhc-green-10: rgb(220, 245, 220);
-	--fhc-green-20: rgb(190, 235, 190);
-	--fhc-green-30: rgb(150, 220, 150);
-	--fhc-green-40: rgb(110, 200, 110);
-	--fhc-green-50: rgb(70, 170, 70);
-	--fhc-green-60: rgb(50, 145, 50);
-	--fhc-green-70: rgb(35, 120, 35);
-	--fhc-green-80: rgb(25, 95, 25);
-	--fhc-green-90: rgb(15, 70, 15);
+	--fhc-red-10: #842029;
+	--fhc-red-20: #800000;
 
-	/* --- Red --- */
-	--fhc-red-5:  rgb(255, 245, 246);
-	--fhc-red-10: rgb(255, 225, 228);
-	--fhc-red-20: rgb(250, 190, 195);
-	--fhc-red-30: rgb(240, 150, 160);
-	--fhc-red-40: rgb(225, 110, 120);
-	--fhc-red-50: rgb(200, 70, 85);
-	--fhc-red-60: rgb(170, 50, 65);
-	--fhc-red-70: rgb(140, 35, 50);
-	--fhc-red-80: rgb(110, 20, 35);
-	--fhc-red-90: rgb(85, 10, 25);
+	--fhc-green-10: #008000;
 
-	/* --- Yellow --- */
-	--fhc-yellow-5:  rgb(255, 255, 240);
-	--fhc-yellow-10: rgb(255, 250, 210);
-	--fhc-yellow-20: rgb(255, 240, 160);
-	--fhc-yellow-30: rgb(255, 225, 100);
-	--fhc-yellow-40: rgb(250, 210, 50);
-	--fhc-yellow-50: rgb(240, 190, 0);
-	--fhc-yellow-60: rgb(220, 165, 0);
-	--fhc-yellow-70: rgb(190, 135, 0);
-	--fhc-yellow-80: rgb(160, 105, 0);
-	--fhc-yellow-90: rgb(120, 75, 0);
-
-	/* --- Pink --- */
-	--fhc-pink-5:  rgb(255, 245, 250);
-	--fhc-pink-10: rgb(255, 225, 235);
-	--fhc-pink-20: rgb(250, 195, 215);
-	--fhc-pink-30: rgb(245, 160, 190);
-	--fhc-pink-40: rgb(235, 120, 160);
-	--fhc-pink-50: rgb(220, 80, 130);
-	--fhc-pink-60: rgb(190, 60, 110);
-	--fhc-pink-70: rgb(160, 40, 90);
-	--fhc-pink-80: rgb(130, 25, 70);
-	--fhc-pink-90: rgb(100, 15, 50);
-
-	/* --- Orange --- */
-	--fhc-orange-5:  rgb(255, 250, 240);
-	--fhc-orange-10: rgb(255, 235, 200);
-	--fhc-orange-20: rgb(255, 210, 140);
-	--fhc-orange-30: rgb(255, 185, 80);
-	--fhc-orange-40: rgb(255, 155, 40);
-	--fhc-orange-50: rgb(255, 128, 0);
-	--fhc-orange-60: rgb(230, 110, 0);
-	--fhc-orange-70: rgb(200, 90, 0);
-	--fhc-orange-80: rgb(170, 70, 0);
-	--fhc-orange-90: rgb(130, 50, 0);
-	
 	--fhc-beige-10: rgba(245, 233, 215, 0.5);
 	--fhc-beige-20: rgba(172, 153, 125, 0.5);
 
-	/* --- Purple --- */
-	--fhc-purple-5:  rgb(250, 245, 255);
-	--fhc-purple-10: rgb(240, 230, 255);
-	--fhc-purple-20: rgb(220, 200, 250);
-	--fhc-purple-30: rgb(190, 160, 245);
-	--fhc-purple-40: rgb(160, 120, 235);
-	--fhc-purple-50: rgb(130, 80, 220);
-	--fhc-purple-60: rgb(110, 60, 190);
-	--fhc-purple-70: rgb(90, 40, 160);
-	--fhc-purple-80: rgb(70, 25, 130);
-	--fhc-purple-90: rgb(50, 15, 100);
 
-	/* --- Teal --- */
-	--fhc-teal-5:  rgb(240, 252, 252);
-	--fhc-teal-10: rgb(220, 245, 245);
-	--fhc-teal-20: rgb(180, 235, 235);
-	--fhc-teal-30: rgb(130, 220, 220);
-	--fhc-teal-40: rgb(80, 200, 200);
-	--fhc-teal-50: rgb(30, 170, 170);
-	--fhc-teal-60: rgb(20, 140, 140);
-	--fhc-teal-70: rgb(15, 115, 115);
-	--fhc-teal-80: rgb(10, 90, 90);
-	--fhc-teal-90: rgb(5, 65, 65);
-
-	/* --- Indigo --- */
-	--fhc-indigo-5:  rgb(245, 247, 255);
-	--fhc-indigo-10: rgb(230, 235, 255);
-	--fhc-indigo-20: rgb(200, 210, 250);
-	--fhc-indigo-30: rgb(160, 175, 245);
-	--fhc-indigo-40: rgb(120, 140, 235);
-	--fhc-indigo-50: rgb(80, 100, 220);
-	--fhc-indigo-60: rgb(60, 80, 190);
-	--fhc-indigo-70: rgb(45, 60, 160);
-	--fhc-indigo-80: rgb(30, 40, 130);
-	--fhc-indigo-90: rgb(20, 25, 100);
 
 }
 

public/js/api/factory/abgabe.js

@@ -1,144 +0,0 @@
-export default {
-	getConfig() {
-		return {
-			method: 'get',
-			url: '/api/frontend/v1/Abgabe/getConfig'
-		};
-	},
-	getConfigStudent() {
-		return {
-			method: 'get',
-			url: '/api/frontend/v1/Abgabe/getConfigStudent'
-		};
-	},
-	getStudentProjektarbeiten(uid) {
-		return {
-			method: 'get',
-			url: '/api/frontend/v1/Abgabe/getStudentProjektarbeiten',
-			params: { uid }
-		};
-	},
-	getStudentProjektabgaben(detail) {
-		return {
-			method: 'get',
-			url: '/api/frontend/v1/Abgabe/getStudentProjektabgaben',
-			params: { projektarbeit_id: detail.projektarbeit_id, student_uid: detail.student_uid }
-		};
-	},
-	postStudentProjektarbeitEndupload(formData) {
-		return {
-			method: 'post',
-			url: '/api/frontend/v1/Abgabe/postStudentProjektarbeitEndupload',
-			params: formData,
-			config: {Headers: { "Content-Type": "multipart/form-data" }}
-		};
-	},
-	postStudentProjektarbeitZwischenabgabe(formData) {
-		return {
-			method: 'post',
-			url: '/api/frontend/v1/Abgabe/postStudentProjektarbeitZwischenabgabe',
-			params: formData,
-			config: {Headers: { "Content-Type": "multipart/form-data" }}
-		};
-	},
-	getMitarbeiterProjektarbeiten(all) {
-		return {
-			method: 'get',
-			url: '/api/frontend/v1/Abgabe/getMitarbeiterProjektarbeiten',
-			params: { showall: all }
-		};
-	},
-	postProjektarbeitAbgabe(termin) {
-		
-		let dateString = termin.datum
-		if(termin.datum instanceof Date) {
-			const year = termin.datum.getFullYear();
-			const month = String(termin.datum.getMonth() + 1).padStart(2, '0');
-			const day = String(termin.datum.getDate()).padStart(2, '0');
-
-			dateString = `${year}-${month}-${day}`
-		}
-		
-		return {
-			method: 'post',
-			url: '/api/frontend/v1/Abgabe/postProjektarbeitAbgabe',
-			params: { 
-				paabgabe_id: termin.paabgabe_id,
-				paabgabetyp_kurzbz: termin.bezeichnung.paabgabetyp_kurzbz,
-				datum: dateString,
-				note: termin.note_pk,
-				upload_allowed: !!termin.upload_allowed,
-				beurteilungsnotiz: termin.beurteilungsnotiz ?? '',
-				fixtermin: termin.fixtermin,
-				insertvon: termin.insertvon,
-				kurzbz: termin.kurzbz,
-				projektarbeit_id: termin.projektarbeit_id,
-				betreuer_person_id: termin.betreuer_person_id
-			}
-		};
-	},
-	deleteProjektarbeitAbgabe(paabgabe_id) {
-		return {
-			method: 'post',
-			url: '/api/frontend/v1/Abgabe/deleteProjektarbeitAbgabe',
-			params: { paabgabe_id }
-		};
-	},
-	postSerientermin(datum, paabgabetyp_kurzbz, bezeichnung, kurzbz, upload_allowed, projektarbeit_ids, fixtermin) {
-		return {
-			method: 'post',
-			url: '/api/frontend/v1/Abgabe/postSerientermin',
-			params: { datum, paabgabetyp_kurzbz, bezeichnung, kurzbz, upload_allowed, projektarbeit_ids, fixtermin }
-		};
-	},
-	fetchDeadlines(person_id) {
-		return {
-			method: 'post',
-			url: '/api/frontend/v1/Abgabe/fetchDeadlines',
-			params: { person_id }
-		};
-	},
-	getPaAbgabetypen() {
-		return {
-			method: 'get',
-			url: '/api/frontend/v1/Abgabe/getPaAbgabetypen'
-		};
-	},
-	//TODO: SWITCH TO NOTEN API ONCE NOTENTOOL IS IN MASTER TO AVOID DUPLICATE API
-	getNoten(){
-		return {
-			method: 'get',
-			url: '/api/frontend/v1/Abgabe/getNoten'
-		};
-	},
-	getProjektarbeitenForStudiengang(studiengang_kz, benotet = 0) {
-		return {
-			method: 'get',
-			url: '/api/frontend/v1/Abgabe/getProjektarbeitenForStudiengang',
-			params: { studiengang_kz, benotet }
-		};
-	},
-	// TODO: this could also very well be generic info api
-	getStudiengaenge() {
-		return {
-			method: 'get',
-			url: '/api/frontend/v1/Abgabe/getStudiengaenge'
-		};
-	},
-	postStudentProjektarbeitZusatzdaten(formData) {
-		return {
-			method: 'post',
-			url: '/api/frontend/v1/Abgabe/postStudentProjektarbeitZusatzdaten',
-			params: formData,
-			config: {Headers: { "Content-Type": "multipart/form-data" }}
-		};
-	},
-	getSignaturStatusForProjektarbeitAbgaben(paabgabe_ids, student_uid) {
-		return {
-			method: 'post',
-			url: '/api/frontend/v1/Abgabe/getSignaturStatusForProjektarbeitAbgaben',
-			params: {paabgabe_ids, student_uid},
-
-		};
-	}
-};

public/js/api/factory/messages/messages.js

@@ -38,18 +38,16 @@ export default {
 			url: 'api/frontend/v1/messages/messages/getMsgVarsLoggedInUser/'
 		};
 	},
-	getMessageVarsPerson(ids, type_id){
+	getMessageVarsPerson(userParams){
 		return {
 			method: 'post',
-			url: 'api/frontend/v1/messages/messages/getMessageVarsPerson/' + type_id,
-			params: {ids}
+			url: 'api/frontend/v1/messages/messages/getMessageVarsPerson/' + userParams.id + '/' + userParams.type_id
 		};
 	},
-	getMsgVarsPrestudent(ids, type_id){
+	getMsgVarsPrestudent(userParams){
 		return {
 			method: 'post',
-			url: 'api/frontend/v1/messages/messages/getMsgVarsPrestudent/' + type_id,
-			params: {ids}
+			url: 'api/frontend/v1/messages/messages/getMsgVarsPrestudent/' + userParams.id + '/' + userParams.type_id
 		};
 	},
 	getPersonId(params){
@@ -58,23 +56,28 @@ export default {
 			url: 'api/frontend/v1/messages/messages/getPersonId/' + params.id + '/' + params.type_id
 		};
 	},
-	getDataVorlage(vorlage_kurzbz){
+	getUid(userParams){
 		return {
 			method: 'get',
-			url: 'api/frontend/v1/messages/messages/getDataVorlage/' + vorlage_kurzbz
+			url: 'api/frontend/v1/messages/messages/getUid/' + userParams.id + '/' + userParams.type_id
 		};
 	},
-	getNameOfDefaultRecipients(ids, type_id){
+	getDataVorlage(vorlage_kurzbz, studiengang_kz){
 		return {
-			method: 'post',
-			url: 'api/frontend/v1/messages/messages/getNameOfDefaultRecipients/' + type_id,
-			params: {ids}
+			method: 'get',
+			url: 'api/frontend/v1/messages/messages/getDataVorlage/' + vorlage_kurzbz + '/' + studiengang_kz
 		};
 	},
-	getPreviewText(type_id, params){
+	getNameOfDefaultRecipient(params){
+		return {
+			method: 'get',
+			url: 'api/frontend/v1/messages/messages/getNameOfDefaultRecipient/' + params.id + '/' + params.type_id
+		};
+	},
+	getPreviewText(userParams, params){
 		return {
 			method: 'post',
-			url: 'api/frontend/v1/messages/messages/getPreviewText/' + type_id,
+			url: 'api/frontend/v1/messages/messages/getPreviewText/' + userParams.id + '/' + userParams.type_id,
 			params
 		};
 	},
@@ -84,10 +87,17 @@ export default {
 			url: 'api/frontend/v1/messages/messages/getReplyData/' + messageId
 		};
 	},
-	sendMessage(type_id, params) {
+	sendMessageFromModalContext(id, params) {
 		return {
 			method: 'post',
-			url: 'api/frontend/v1/messages/messages/sendMessage/' + type_id,
+			url: 'api/frontend/v1/messages/messages/sendMessage/' + id,
+			params
+		};
+	},
+	sendMessage(id, params) {
+		return {
+			method: 'post',
+			url: 'api/frontend/v1/messages/messages/sendMessage/' + id,
 			params
 		};
 	},
@@ -96,5 +106,11 @@ export default {
 			method: 'post',
 			url: 'api/frontend/v1/messages/messages/deleteMessage/' + messageId
 		};
-	}
+	},
+	getStudiengang(userParams){
+		return {
+			method: 'get',
+			url: 'api/frontend/v1/messages/messages/getStudiengang/' + userParams.id + '/' + userParams.type_id
+		};
+	},
 }

public/js/api/factory/studienplan.js

@@ -1,11 +0,0 @@
-export default {
-
-	getStudienplaeneBySemester(studiengang_kz, studiensemester_kurzbz, ausbildungssemester, orgform_kurzbz)
-	{
-		return {
-			method: 'get',
-			url: 'api/frontend/v1/organisation/studienplan/getBySemester',
-			params: { studiengang_kz, studiensemester_kurzbz, ausbildungssemester, orgform_kurzbz },
-		};
-	}
-}

public/js/api/factory/studiensemester.js

@@ -1,33 +0,0 @@
-/**
- * Copyright (C) 2025 fhcomplete.org
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <https://www.gnu.org/licenses/>.
- */
-
-export default {
-	getAllStudiensemesterAndAktOrNext() {
-		return {
-			method: 'get',
-			url: '/api/frontend/v1/organisation/Studiensemester/getAllStudiensemesterAndAktOrNext',
-		};
-	},
-	getAll(order = null, start = null)
-	{
-		return {
-			method: 'get',
-			url: 'api/frontend/v1/organisation/studiensemester/getAll',
-			params: { order, start }
-		};
-	}
-};

public/js/api/factory/stv/mobility.js

@@ -101,7 +101,7 @@ export default {
 	deleteMobilityPurpose(params) {
 		return {
 			method: 'post',
-			url: 'api/frontend/v1/stv/mobility/deleteMobilityPurpose/' + params.bisio_id,
+			url: 'api/frontend/v1/stv/mobility/deleteMobilityPurpose/',
 			params
 		};
 	},

public/js/api/factory/stv/projektarbeit.js

@@ -49,12 +49,6 @@ export default {
 			url: 'api/frontend/v1/stv/projektarbeit/getNoten'
 		};
 	},
-	getStudiensemester() {
-		return {
-			method: 'get',
-			url: 'api/frontend/v1/stv/projektarbeit/getStudiensemester'
-		};
-	},
 	loadProjektarbeit(projektarbeit_id) {
 		return {
 			method: 'get',

public/js/api/factory/stv/students.js

@@ -60,10 +60,10 @@ export default {
 			url: 'api/frontend/v1/stv/students/' + relative_path
 		};
 	},
-	getPerson(params) {
+	check(params) {
 		return {
 			method: 'post',
-			url: 'api/frontend/v1/stv/student/getPerson',
+			url: 'api/frontend/v1/stv/student/check',
 			params
 		};
 	},

public/js/api/lehre.js

@@ -18,5 +18,80 @@ export default {
 			`/api/frontend/v1/Lehre/Pruefungen/${lehrveranstaltung_id}`
 			, {}
 		);
+	},
+	getStudentProjektarbeiten(uid) {
+		return this.$fhcApi.get(
+			`/api/frontend/v1/Lehre/getStudentProjektarbeiten/${uid}`
+			, {}
+		);
+	},
+	getStudentProjektabgaben(detail) {
+		return this.$fhcApi.get(
+			`/api/frontend/v1/Lehre/getStudentProjektabgaben`
+			, {
+				projektarbeit_id: detail.projektarbeit_id,
+				student_uid: detail.student_uid
+			}
+		);
+	},
+	postStudentProjektarbeitEndupload(formData) {
+		const url = '/api/frontend/v1/Lehre/postStudentProjektarbeitEndupload';
+		const headers = {Headers: { "Content-Type": "multipart/form-data" }}
+		return this.$fhcApi.post(url, formData, headers)
+	},
+	postStudentProjektarbeitZwischenabgabe(formData) {
+		const url = '/api/frontend/v1/Lehre/postStudentProjektarbeitZwischenabgabe';
+		const headers = {Headers: { "Content-Type": "multipart/form-data" }}
+		return this.$fhcApi.post(url, formData, headers)
+	},
+	getStudentProjektarbeitAbgabeFile(paabgabe_id, student_uid) {
+		const url = `/Cis/Abgabetool/getStudentProjektarbeitAbgabeFile?paabgabe_id=${paabgabe_id}&student_uid=${student_uid}`;
+
+		window.location = FHC_JS_DATA_STORAGE_OBJECT.app_root + FHC_JS_DATA_STORAGE_OBJECT.ci_router + url
+	},
+	getMitarbeiterProjektarbeiten(uid, all) {
+		return this.$fhcApi.get(
+			`/api/frontend/v1/Lehre/getMitarbeiterProjektarbeiten?showall=${all}`
+			, {}
+		);
+	},
+	postProjektarbeitAbgabe(termin) {
+		const payload = {
+			paabgabe_id: termin.paabgabe_id,
+			paabgabetyp_kurzbz: termin.bezeichnung.paabgabetyp_kurzbz,
+			datum: termin.datum,
+			fixtermin: termin.fixtermin,
+			insertvon: termin.insertvon,
+			kurzbz: termin.kurzbz,
+			projektarbeit_id: termin.projektarbeit_id
+		}
+		const url = '/api/frontend/v1/Lehre/postProjektarbeitAbgabe';
+
+		return this.$fhcApi.post(url, payload, null)
+		
+	},
+	deleteProjektarbeitAbgabe(paabgabe_id) {
+		const payload = {
+			paabgabe_id
+		}
+		const url = '/api/frontend/v1/Lehre/deleteProjektarbeitAbgabe';
+
+		return this.$fhcApi.post(url, payload, null)
+	},
+	postSerientermin(datum, paabgabetyp_kurzbz, bezeichnung, kurzbz, projektarbeit_ids) {
+		const payload = {
+			datum, paabgabetyp_kurzbz, bezeichnung, kurzbz, projektarbeit_ids
+		}
+		const url = '/api/frontend/v1/Lehre/postSerientermin';
+
+		return this.$fhcApi.post(url, payload, null)
+	},
+	fetchDeadlines(person_id) {
+		const payload = {
+			person_id
+		}
+		const url = '/api/frontend/v1/Lehre/fetchDeadlines';
+
+		return this.$fhcApi.post(url, payload, null)
 	}
   }

public/js/apps/Abgabetool/Abgabetool.js

@@ -1,74 +0,0 @@
-import PluginsPhrasen from '../../plugins/Phrasen.js';
-import AbgabetoolStudent from "../../components/Cis/Abgabetool/AbgabetoolStudent.js";
-import AbgabetoolMitarbeiter from "../../components/Cis/Abgabetool/AbgabetoolMitarbeiter.js";
-import AbgabetoolAssistenz from "../../components/Cis/Abgabetool/AbgabetoolAssistenz.js";
-import DeadlineOverview from "../../components/Cis/Abgabetool/DeadlineOverview.js";
-import {capitalize} from "../../helpers/StringHelpers.js";
-
-const app = Vue.createApp({
-	name: 'AbgabetoolApp',
-	components: {
-		AbgabetoolStudent,
-		AbgabetoolMitarbeiter,
-		AbgabetoolAssistenz,
-		DeadlineOverview
-	},
-	data: function() {
-		return {
-			comp: null,
-			uid: null,
-			student_uid: null,
-			stg_kz: null
-		};
-	},
-	methods: {
-		
-	},
-	computed: {
-		viewData() {
-			return { uid: this.uid}
-		},
-		student_uid_computed() {
-			return this.student_uid ?? this.uid
-		},
-		stg_kz_computed() {
-			return this.stg_kz ?? null
-		}
-	},
-	created() {
-	},
-	mounted() {
-		
-		const root = document.getElementById('abgabetoolroot')
-		const route = root.getAttribute("route");
-		this.comp = route
-
-		const uid = root.getAttribute("uid");
-		this.uid = uid
-
-		const stg_kz = root.getAttribute("stg_kz_prop");
-		this.stg_kz = stg_kz
-
-		const student_uid = root.getAttribute("student_uid_prop");
-		this.student_uid = student_uid
-		
-	},
-	template: `
-		<template v-if="comp && uid">
-			<AbgabetoolStudent v-if="comp == 'AbgabetoolStudent'" :viewData="viewData" :student_uid_prop="student_uid_computed"></AbgabetoolStudent>
-			<AbgabetoolMitarbeiter v-if="comp == 'AbgabetoolMitarbeiter'" :viewData="viewData"></AbgabetoolMitarbeiter>
-			<AbgabetoolAssistenz v-if="comp == 'AbgabetoolAssistenz'" :viewData="viewData" :stg_kz_prop="stg_kz_computed"></AbgabetoolAssistenz>
-			<DeadlineOverview v-if="comp == 'DeadlinesOverview'" :viewData="viewData"></DeadlineOverview>
-		</template>
-	`
-});
-app.config.globalProperties.$capitalize = capitalize;
-app.use(primevue.config.default, {
-	zIndex: {
-		overlay: 9000,
-		tooltip: 8000
-	}
-})
-app.directive('tooltip', primevue.tooltip);
-app.use(PluginsPhrasen);
-app.mount('#abgabetoolroot');

public/js/apps/Dashboard/Fhc.js

@@ -14,7 +14,6 @@ import Info from "../../components/Cis/Mylv/Semester/Studiengang/Lv/Info.js";
 import RoomInformation, {DEFAULT_MODE_RAUMINFO} from "../../components/Cis/Mylv/RoomInformation.js";
 import AbgabetoolStudent from "../../components/Cis/Abgabetool/AbgabetoolStudent.js";
 import AbgabetoolMitarbeiter from "../../components/Cis/Abgabetool/AbgabetoolMitarbeiter.js";
-import AbgabetoolAssistenz from "../../components/Cis/Abgabetool/AbgabetoolAssistenz.js";
 import DeadlineOverview from "../../components/Cis/Abgabetool/DeadlineOverview.js";
 import Studium from "../../components/Cis/Studium/Studium.js";
 
@@ -57,12 +56,6 @@ const router = VueRouter.createRouter({
 			component: AbgabetoolMitarbeiter,
 			props: true
 		},
-		{
-			path: `/Cis/Abgabetool/Assistenz/:stg_kz_prop?`,
-			name: 'AbgabetoolAssistenz',
-			component: AbgabetoolAssistenz,
-			props: true
-		},
 		{
 			path: `/Cis/Abgabetool/Deadlines/:person_uid_prop?`,
 			name: 'DeadlineOverview',
@@ -235,16 +228,13 @@ const app = Vue.createApp({
 	components: {},
 	computed: {
 		isMobile() {
-			const smallScreen = window.matchMedia("(max-width: 767px)").matches;
-			const touchCapable = ("ontouchstart" in window) || navigator.maxTouchPoints > 0;
-			return smallScreen;// && touchCapable;
+			return /Mobi|Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(navigator.userAgent);
 		}	
 	},
 	provide() {
 		return { // provide injectable & watchable language property
 			language: Vue.computed(() => this.$p.user_language),
 			renderers: Vue.computed(() => this.renderers),
-			isMobile: this.isMobile
 		}	
 	},
 	methods: {
@@ -283,7 +273,6 @@ const app = Vue.createApp({
 		}
 	},
 	async created(){
-		
 		await this.$api
 			.call(ApiRenderers.loadRenderers())
 			.then(res => res.data)
@@ -324,7 +313,6 @@ const app = Vue.createApp({
 	},
 	mounted() {
 		document.addEventListener('click', this.handleClick);
-		
 	},
 	beforeUnmount() {
 		document.removeEventListener('click', this.handleClick);

public/js/apps/Nachrichten.js

@@ -1,15 +1,14 @@
 import NewMessage from "../components/Messages/Details/NewMessage/NewDiv.js";
 
-import Phrasen from "../plugins/Phrasen.js";
+import Phrasen from "../plugin/Phrasen.js";
 
 const ciPath = FHC_JS_DATA_STORAGE_OBJECT.app_root.replace(/(https:|)(^|\/\/)(.*?\/)/g, '') + FHC_JS_DATA_STORAGE_OBJECT.ci_router;
 
 const router = VueRouter.createRouter({
 	history: VueRouter.createWebHistory(),
 	routes: [
-		{ path: `/${ciPath}/NeueNachricht`, component: NewMessage, props: true },
-		{ path: `/${ciPath}/NeueNachricht/:id/:typeId`, component: NewMessage, props: true },
-		{ path: `/${ciPath}/NeueNachricht/:id/:typeId/:messageId`, component: NewMessage, props: true },
+		{ path: `/${ciPath}/NeueNachricht/:id/:typeId`, component: NewMessage },
+		{ path: `/${ciPath}/NeueNachricht/:id/:typeId/:messageId`, component: NewMessage },
 	]
 });
 

public/js/components/Bootstrap/Modal.js

@@ -46,8 +46,7 @@ export default {
 		"hiddenBsModal",
 		"hidePreventedBsModal",
 		"showBsModal",
-		"shownBsModal",
-		"toggleFullscreen"
+		"shownBsModal"
 	],
 	methods: {
 		dispose() {
@@ -67,7 +66,6 @@ export default {
 		},
 		toggleFullscreen() {
 			this.fullscreen = !this.fullscreen
-			this.$emit('toggleFullscreen')
 		}
 	},
 	mounted() {
@@ -137,16 +135,10 @@ export default {
 			<div class="modal-content">
 				<div v-if="$slots.title" class="modal-header" :class="headerClass">
 					<h5 class="modal-title"><slot name="title"/></h5>
-					<div class="d-flex align-items-center ms-auto gap-2">
-						<button 
-							type="button" 
-							class="btn mb-1" 
-							v-if="allowFullscreenExpand" 
-							@click="toggleFullscreen"
-							:aria-label="fullscreen ? 'Exit Fullscreen' : 'Enter Fullscreen'"
-						>
-							<i v-if="!fullscreen" class="fa-solid fa-expand"></i>
-							<i v-else class="fa-solid fa-compress"></i>
+					<div class="d-flex align-items-center ms-auto">
+						<button type="button" class="btn ms-auto" style="filter: invert(1)" v-if="allowFullscreenExpand" @click="toggleFullscreen">
+						  <i v-if="!fullscreen" class="fa-solid fa-expand"></i>
+						  <i v-else class="fa-solid fa-compress"></i>
 						</button>
 						<button v-if="!noCloseBtn" type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
 					</div>

public/js/components/Bootstrap/Offcanvas.js

@@ -1,151 +0,0 @@
-export default {
-	name: 'BootstrapOffcanvas',
-	data: () => ({
-		offcanvas: null
-	}),
-	props: {
-		backdrop: {
-			type: [Boolean, String],
-			default: true,
-			validator(value) {
-				return ['static', true, false].includes(value);
-			}
-		},
-		keyboard: {
-			type: Boolean,
-			default: true
-		},
-		scroll: {
-			type: Boolean,
-			default: false
-		},
-		placement: {
-			type: String,
-			default: 'start', // start | end | top | bottom
-			validator(value) {
-				return ['start', 'end', 'top', 'bottom'].includes(value);
-			}
-		},
-		noCloseBtn: Boolean,
-		headerClass: {
-			type: [String, Array, Object],
-			default: ''
-		},
-		bodyClass: {
-			type: [String, Array, Object],
-			default: 'p-4'
-		},
-		footerClass: {
-			type: [String, Array, Object],
-			default: ''
-		},
-		dialogClass: [String, Array, Object]
-	},
-	emits: [
-		"hideBsOffcanvas",
-		"hiddenBsOffcanvas",
-		"hidePreventedBsOffcanvas",
-		"showBsOffcanvas",
-		"shownBsOffcanvas"
-	],
-	methods: {
-		dispose() {
-			return this.offcanvas?.dispose();
-		},
-		hide() {
-			return this.offcanvas?.hide();
-		},
-		show(relatedTarget) {
-			return this.offcanvas?.show(relatedTarget);
-		},
-		toggle() {
-			return this.offcanvas?.toggle();
-		},
-		popup(body, options, title, footer) {
-			const BsOffcanvas = this,
-				slots = {};
-
-			if (body !== undefined)
-				slots.default = () => body;
-			if (title !== undefined)
-				slots.title = () => title;
-			if (footer !== undefined)
-				slots.footer = () => footer;
-
-			let includedPrimevue = false;
-			if (typeof primevue !== 'undefined')
-				includedPrimevue = true;
-
-			return new Promise((resolve, reject) => {
-				const instance = Vue.createApp({
-					name: 'OffcanvasTmpApp',
-					setup() {
-						return () =>
-							Vue.h(BsOffcanvas, {
-								class: 'offcanvas-wrapper',
-								ref: 'offcanvas',
-								...options
-							}, slots);
-					},
-					mounted() {
-						this.$refs.offcanvas.show();
-					},
-					beforeUnmount() {
-						if (this.$refs.offcanvas)
-							this.$refs.offcanvas.result !== false ? resolve(this.$refs.offcanvas.result) : reject();
-					},
-					unmounted() {
-						wrapper.parentElement.removeChild(wrapper);
-					}
-				});
-				const wrapper = document.createElement('div');
-
-				if (includedPrimevue) {
-					instance.use(primevue.config.default, { zIndex: { overlay: 9999 } });
-				}
-
-				import('../../plugins/Phrasen.js').then((Phrasen) => {
-					instance.use(Phrasen.default);
-					instance.mount(wrapper);
-					document.body.appendChild(wrapper);
-				});
-			});
-		}
-	},
-	mounted() {
-		if (this.$refs.offcanvas) {
-			this.offcanvas = new bootstrap.Offcanvas(this.$refs.offcanvas, {
-				backdrop: this.backdrop,
-				keyboard: this.keyboard,
-				scroll: this.scroll
-			});
-		}
-	},
-	template: `
-		<div ref="offcanvas"
-			class="bootstrap-offcanvas offcanvas"
-			:class="['offcanvas-' + placement, dialogClass]"
-			tabindex="-1"
-			@[\`hide.bs.offcanvas\`]="$emit('hideBsOffcanvas')"
-			@[\`hidden.bs.offcanvas\`]="$emit('hiddenBsOffcanvas')"
-			@[\`hidePrevented.bs.offcanvas\`]="$emit('hidePreventedBsOffcanvas')"
-			@[\`show.bs.offcanvas\`]="$emit('showBsOffcanvas')"
-			@[\`shown.bs.offcanvas\`]="$emit('shownBsOffcanvas')"
-		>
-			<div class="offcanvas-header" :class="headerClass" v-if="$slots.title">
-				<h5 class="offcanvas-title">
-					<slot name="title"></slot>
-				</h5>
-				<button v-if="!noCloseBtn" type="button" class="btn-close text-reset" data-bs-dismiss="offcanvas" aria-label="Close"></button>
-			</div>
-
-			<div class="offcanvas-body" :class="bodyClass">
-				<slot></slot>
-			</div>
-
-			<div v-if="$slots.footer" class="offcanvas-footer" :class="footerClass">
-				<slot name="footer"></slot>
-			</div>
-		</div>
-	`
-}

public/js/components/Chart/FhcChart.js

@@ -8,6 +8,12 @@ export const FhcChart = {
 	},
 	template: `
 	<div style="width:100%;height:100%;overflow:auto">
+		<div role="group" aria-label="Chart Modus">
+			<Button :class="(chartOptions.chart.type === 'pie' ? 'active ' : '') + 'btn btn-outline-secondary'" style="width: 48px;" @click="chartOptions.chart.type='pie'"><i class="fa-solid fa-chart-pie"></i></Button>
+			<Button :class="(chartOptions.chart.type === 'bar' ? 'active ' : '') + 'btn btn-outline-secondary'" style="width: 48px;" @click="chartOptions.chart.type='bar'"><i class="fa-solid fa-chart-bar"></i></Button>
+			<Button :class="(chartOptions.chart.type === 'column' ? 'active ' : '') + 'btn btn-outline-secondary'" style="width: 48px;" @click="chartOptions.chart.type='column'"><i class="fa-solid fa-chart-simple"></i></Button>
+			<Button :class="(chartOptions.chart.type === 'line' ? 'active ' : '') + 'btn btn-outline-secondary'" style="width: 48px;" @click="chartOptions.chart.type='line'"><i class="fa-solid fa-chart-line"></i></Button>
+		</div>
 		<figure>
 			<highcharts class="chart" :options="chartOptions"></highcharts>
 		</figure>

public/js/components/Cis/Abgabetool/AbgabeStudentDetail.js

@@ -1,9 +1,8 @@
 import Upload from '../../../components/Form/Upload/Dms.js';
 import BsModal from '../../Bootstrap/Modal.js';
 import VueDatePicker from '../../vueDatepicker.js.php';
-import ApiAbgabe from '../../../api/factory/abgabe.js'
-import FhcOverlay from "../../Overlay/FhcOverlay.js";
 
+const today = new Date()
 export const AbgabeStudentDetail = {
 	name: "AbgabeStudentDetail",
 	components: {
@@ -13,14 +12,8 @@ export const AbgabeStudentDetail = {
 		Checkbox: primevue.checkbox,
 		Dropdown: primevue.dropdown,
 		Textarea: primevue.textarea,
-		Accordion: primevue.accordion,
-		AccordionTab: primevue.accordiontab,
-		Message: primevue.message,
-		Inplace: primevue.inplace,
-		VueDatePicker,
-		FhcOverlay
+		VueDatePicker
 	},
-	inject: ['notenOptions', 'isMobile', 'isViewMode', 'moodle_link'],
 	props: {
 		projektarbeit: {
 			type: Object,
@@ -33,7 +26,6 @@ export const AbgabeStudentDetail = {
 	},
 	data() {
 		return {
-			loading: false,
 			eidAkzeptiert: false,
 			enduploadTermin: null,
 			allActiveLanguages: FHC_JS_DATA_STORAGE_OBJECT.server_languages,
@@ -49,40 +41,16 @@ export const AbgabeStudentDetail = {
 		}
 	},
 	methods: {
-		getNoteBezeichnung(termin){
-			const noteOpt = this.notenOptions.find(opt => opt.note == termin.note)
-			
-			if(noteOpt?.bezeichnung) {
-				return noteOpt?.positiv ? this.$capitalize(this.$p.t('abgabetool/c4positivBenotet')) + ' ✅' : this.$capitalize(this.$p.t('abgabetool/c4negativBenotet')) + ' ❌'
-			} else if(noteOpt?.benotbar === true && !termin.note) {
-				return this.$capitalize(this.$p.t('abgabetool/c4notYetGraded'));
-			} else {
-				return ''
-			}
-		},
-		async validate(termin, endupload = false) {
+		validate: function(termin) {
 			if(!termin.file.length) {
-				this.$fhcAlert.alertWarning(this.$capitalize(this.$p.t('global/warningChooseFile')));
+				this.$fhcAlert.alertWarning(this.$p.t('global/warningChooseFile'));
 				return false
 			}
-			
-			if(endupload) {
-				if(await this.$fhcAlert.confirm({
-					message: this.$p.t('abgabetool/confirmEnduploadSpeichern'),
-					acceptLabel: this.$capitalize(this.$p.t('abgabetool/c4AcceptAndProceed')),
-					acceptClass: 'p-button-primary',
-					rejectLabel: this.$capitalize(this.$p.t('abgabetool/c4Cancel')),
-					rejectClass: 'p-button-secondary'
-				}) === false) {
-					return false
-				}
-			}
-			
+
 			return true;
 		},
-		async triggerEndupload() {
-			
-			if (!await this.validate(this.enduploadTermin, true))
+		triggerEndupload() {
+			if (!this.validate(this.enduploadTermin))
 			{
 				return false;
 			}
@@ -95,6 +63,7 @@ export const AbgabeStudentDetail = {
 			formData.append('student_uid', this.projektarbeit.student_uid)
 			formData.append('bperson_id', this.projektarbeit.bperson_id)
 			
+			// TODO: validate/check for null etc.
 			formData.append('sprache', this.form['sprache'].sprache)
 			formData.append('abstract', this.form['abstract'])
 			formData.append('abstract_en', this.form['abstract_en'])
@@ -105,21 +74,15 @@ export const AbgabeStudentDetail = {
 			for (let i = 0; i < this.enduploadTermin.file.length; i++) {
 				formData.append('file', this.enduploadTermin.file[i]);
 			}
-			this.loading = true
-			this.$api.call(ApiAbgabe.postStudentProjektarbeitEndupload(formData))
+			this.$fhcApi.factory.lehre.postStudentProjektarbeitEndupload(formData)
 				.then(res => {
-					this.handleUploadRes(res, this.enduploadTermin)
-				}).finally(()=> {
-					this.loading = false
-			})
+					this.handleUploadRes(res)
+				})
 			
 			this.$refs.modalContainerEnduploadZusatzdaten.hide()
 		},
 		downloadAbgabe(termin) {
-			const url = `/api/frontend/v1/Abgabe/getStudentProjektarbeitAbgabeFile?paabgabe_id=${termin.paabgabe_id}&student_uid=${this.projektarbeit.student_uid}&projektarbeit_id=${this.projektarbeit.projektarbeit_id}`;
-
-			window.open(FHC_JS_DATA_STORAGE_OBJECT.app_root + FHC_JS_DATA_STORAGE_OBJECT.ci_router + url)
-			// this.$api.call(ApiAbgabe.getStudentProjektarbeitAbgabeFile(termin.paabgabe_id, this.projektarbeit.student_uid))
+			this.$fhcApi.factory.lehre.getStudentProjektarbeitAbgabeFile(termin.paabgabe_id, this.projektarbeit.student_uid)
 		},
 		formatDate(dateParam) {
 			const date = new Date(dateParam)
@@ -130,17 +93,16 @@ export const AbgabeStudentDetail = {
 			const day = padZero(date.getDate());
 			const year = date.getFullYear();
 
-			return `${day}.${month}.${year}`
+			return `${day}.${month}.${year}`;
 		},
-		async upload(termin) {
+		upload(termin) {
 
-			// only do this on endupload
-			if (! await this.validate(termin))
+			if (!this.validate(termin))
 			{
 				return false;
 			}
 			
-			if(termin.bezeichnung?.paabgabetyp_kurzbz === 'end') {
+			if(termin.bezeichnung === 'Endupload') {
 				// open endupload form modal for further inputs
 				this.enduploadTermin = termin
 				this.$refs.modalContainerEnduploadZusatzdaten.show()
@@ -155,401 +117,166 @@ export const AbgabeStudentDetail = {
 				for (let i = 0; i < termin.file.length; i++) {
 					formData.append('file', termin.file[i]);
 				}
-
-				this.loading = true
-				this.$api.call(ApiAbgabe.postStudentProjektarbeitZwischenabgabe(formData))
+				this.$fhcApi.factory.lehre.postStudentProjektarbeitZwischenabgabe(formData)
 					.then(res => {
-						this.handleUploadRes(res, termin)
-					}).finally(()=> {
-						this.loading = false
-				})
+						this.handleUploadRes(res)
+					})
 			}
 		},
-		handleUploadRes(res, termin) {
+		handleUploadRes(res) {
 			if(res.meta.status == "success") {
-				this.$fhcAlert.alertSuccess(this.$capitalize(this.$p.t('abgabetool/c4fileUploadSuccessv3')))
-
-				// update 'abgabedatum' for successful upload -> shows the pdf icon and date once set
-				termin.abgabedatum = new Date().toISOString().split('T')[0];
-				if(res?.data?.signatur !== undefined) {
-					termin.signatur = res.data.signatur
-				}
-				
+				this.$fhcAlert.alertSuccess('File erfolgreich hochgeladen')
 			} else {
-				this.$fhcAlert.alertError(this.$capitalize(this.$p.t('abgabetool/c4fileUploadErrorv3')))
+				this.$fhcAlert.alertError('File upload error')
 			}
 			
 			if(res.meta.signaturInfo) {
 				this.$fhcAlert.alertInfo(res.meta.signaturInfo)
 			}
+		},
+		dateDiffInDays(datum, today){
+			const oneDayMs = 1000 * 60 * 60 * 24
+			return Math.round((new Date(datum) - new Date(today)) / oneDayMs)
+		},
+		getDateStyle(termin, mode) {
+			const datum = new Date(termin.datum)
+			const abgabedatum = new Date(termin.abgabedatum)
 			
+			// todo: rework styling but keep the color pattern logic
+			// https://wiki.fhcomplete.info/doku.php?id=cis:abgabetool_fuer_studierende
+			let color = 'white'
+			let fontColor = 'black'
+			let icon = '';
+			if (termin.abgabedatum === null) {
+				if(datum < today) {
+					color = 'red'
+					fontColor = 'white'
+					icon = 'fa-triangle-exclamation'
+				} else if (datum > today && this.dateDiffInDays(datum, today) <= 12) {
+					color = 'yellow'
+					icon = 'fa-circle-exclamation'
+				}
+			} else if(abgabedatum > datum) {
+				color = 'pink' // aka "hellrot"
+				fontColor = 'white'
+				icon = 'fa-circle-question'
+			} else {
+				color = 'green'
+				icon = 'fa-square-check'
+			}
 			
+			//return `font-color: ${fontColor} ; background-color: ${color}; border-radius: 50%;`
+			if(  typeof mode !== 'undefined' || mode === 'icon') {
+				return icon;
+			} else {
+				return 'abgabe-zieldatum-border-' + color;
+			}
+		},
+		openBeurteilungLink(link) {
+			window.open(link, '_blank')
 		},
 		getOptionLabel(option) {
 			return option.sprache
-		},
-		getTerminNoteBezeichnung(termin) {
-			const noteOpt = this.notenOptions.find(opt => opt.note == termin.note)
-			return noteOpt ? noteOpt.bezeichnung : ''
-		},
+		}
 	},
 	watch: {
 		projektarbeit(newVal) {
 			// default select german if projektarbeit sprache was null
 			this.form.sprache = newVal.sprache ? this.allActiveLanguages.find(lang => lang.sprache == newVal.sprache) : this.allActiveLanguages.find(lang => lang.sprache == 'German')
-			this.form.abstract = newVal.abstract ?? ''
-			this.form.abstract_en = newVal.abstract_en ?? ''
-			this.form.schlagwoerter = newVal.schlagwoerter ?? ''
-			this.form.schlagwoerter_en = newVal.schlagwoerter_en ?? ''
-			this.form.kontrollschlagwoerter = newVal.kontrollschlagwoerter ?? ''
-			this.form.seitenanzahl = newVal.seitenanzahl ?? 1
-			
+			this.form.abstract = newVal.abstract
+			this.form.abstract_en = newVal.abstract_en
+			this.form.schlagwoerter = newVal.schlagwoerter
+			this.form.schlagwoerter_en = newVal.schlagwoerter_en
+			this.form.kontrollschlagwoerter = newVal.kontrollschlagwoerter
+			this.form.seitenanzahl = newVal.seitenanzahl
 		}
 	},
 	computed: {
-		getMoodleLink() {
-			return this.moodle_link + this.projektarbeit.studiengang_kz	
-		},
-		getMessagePtStyle() {
-			// adjust outer spacing and internal padding to appear similar to doenload button in size
-			return {
-				root: {
-					style: {
-						margin: '0px'
-					}
-				},
-				wrapper: {
-					style: {
-						padding: '6px'
-					}
-				}
-			}
-		},
 		getEid() {
-			return this.$capitalize(this.$p.t('abgabetool/c4eidesstattlicheErklaerung'))
-		},
-		allowedToSaveZusatzdaten() {
-			return this.form.schlagwoerter.length > 0 && this.form.schlagwoerter_en.length > 0 && this.form.abstract.length > 0 && this.form.abstract_en.length > 0 && this.form.seitenanzahl > 0
-		},
-		getAllowedToSendEndupload() {
-			return this.eidAkzeptiert && this.allowedToSaveZusatzdaten
-		},
-		qualityGateTerminAvailable() {
-			let qgatefound = false
-			this.projektarbeit?.abgabetermine.forEach(abgabe => {
-				if(abgabe.paabgabetyp_kurzbz == 'qualgate1'
-					|| abgabe.paabgabetyp_kurzbz == 'qualgate2') {
-					qgatefound = true
-				}
-			})
-			return qgatefound
-		},
-		getTooltipVerspaetet() {
-			return {
-				value: this.$capitalize(this.$p.t('abgabetool/c4tooltipVerspaetet')),
-				class: "custom-tooltip"
-			}
-		},
-		getTooltipVerpasst() {
-			return {
-				value: this.$capitalize(this.$p.t('abgabetool/c4tooltipVerpasst')),
-				class: "custom-tooltip"
-			}
-		},
-		getTooltipAbzugeben() {
-			return {
-				value: this.$capitalize(this.$p.t('abgabetool/c4tooltipAbzugeben')),
-				class: "custom-tooltip"
-			}
-		},
-		getTooltipStandard() {
-			return {
-				value: this.$capitalize(this.$p.t('abgabetool/c4tooltipStandardv2')),
-				class: "custom-tooltip"
-			}
-		},
-		getTooltipAbgegeben() {
-			return {
-				value: this.$capitalize(this.$p.t('abgabetool/c4tooltipAbgegeben')),
-				class: "custom-tooltip"
-			}
-		},
-		getTooltipFixtermin() {
-			return {
-				value: this.$capitalize(this.$p.t('abgabetool/c4tooltipFixtermin')),
-				class: "custom-tooltip"
-			}
-		},
-		getTooltipAbgabeDetected() {
-			return {
-				value: this.$capitalize(this.$p.t('abgabetool/c4tooltipAbgabeDetected')),
-				class: "custom-tooltip"
-			}
-		},
-		getTooltipNotAllowedToUpload() {
-			if(this.isViewMode) {
-				return {
-					value: this.$capitalize(this.$p.t('abgabetool/c4studentAbgabeNotAllowedInViewMode')),
-					class: "custom-tooltip"
-				}
-			} else {
-				return {
-					value: this.$capitalize(this.$p.t('abgabetool/c4studentAbgabeNotAllowedRegular')),
-					class: "custom-tooltip"
-				}
-			}
-		},
-		getTooltipBeurteilungerforderlich() {
-			return {
-				value: this.$capitalize(this.$p.t('abgabetool/c4tooltipBeurteilungerforderlich')),
-				class: "custom-tooltip"
-			}
-		},
-		getTooltipBestanden() {
-			return {
-				value: this.$p.t('abgabetool/c4tooltipBestanden'),
-				class: "custom-tooltip"
-			}
-		},
-		getTooltipNichtBestanden() {
-			return {
-				value: this.$p.t('abgabetool/c4tooltipNichtBestanden'),
-				class: "custom-tooltip"
-			}
+			return this.$p.t('abgabetool/c4eidesstattlicheErklaerung')
 		},
+		getEnduploadErlaubt() {
+			return !this.eidAkzeptiert
+		}
 	},
 	created() {
-		
+
 	},
 	mounted() {
 
 	},
 	template: `
-		<FhcOverlay :active="loading"></FhcOverlay>
-
 		<div v-if="projektarbeit">
 		
-			<h5>{{$capitalize( $p.t('abgabetool/c4abgabeStudentenbereich') )}}</h5>
+			<h5>{{$p.t('abgabetool/c4abgabeStudentenbereich')}}</h5>
 			<div class="row">
-				<div class="col-8">
-					<p> {{$capitalize( $p.t('person/student') ) }}: {{projektarbeit?.student}}</p>
-					<p> {{$capitalize( $p.t('abgabetool/c4titel') ) }}: {{projektarbeit?.titel}}</p>
-					<p> {{$capitalize( $p.t('abgabetool/c4betreuer') ) }}: {{projektarbeit ? $p.t('abgabetool/c4betrart' + projektarbeit.betreuerart_kurzbz) + ' ' + projektarbeit.betreuer : ''}}</p>
+				<p> {{projektarbeit?.betreuer}}</p>
+				<p> {{projektarbeit?.titel}}</p>
+			</div>
+			<div id="uploadWrapper">
+				<div class="row" style="margin-bottom: 12px;">
+					<div class="col-1 fw-bold text-center">{{$p.t('abgabetool/c4fixtermin')}}</div>
+					<div class="col-2 fw-bold">{{$p.t('abgabetool/c4zieldatum')}}</div>
+					<div class="col-2 fw-bold">{{$p.t('abgabetool/c4abgabetyp')}}</div>
+					<div class="col-3 fw-bold">{{$p.t('abgabetool/c4abgabekurzbz')}}</div>
+					<div class="col-1 fw-bold text-center">{{$p.t('abgabetool/c4abgabedatum')}}</div>
+					<div class="col-3 fw-bold">
+						{{$p.t('abgabetool/c4fileupload')}}
+					</div>
 				</div>
-				<div class="col-4">
-					<p>{{ $p.t('abgabetool/c4checkoutStgMoodleInfos') }} 
-						<a :href="getMoodleLink" target="_blank">Moodle</a>
-					</p>
+				<div class="row" v-for="termin in projektarbeit.abgabetermine">
+					<div class="col-1 d-flex justify-content-center align-items-start">
+						<i v-if="termin.fixtermin" class="fa-solid fa-2x fa-circle-check fhc-bullet-red"></i>
+						<i v-else="" class="fa-solid fa-2x fa-circle-xmark fhc-bullet-green"></i>
+<!--
+						<p class="fhc-bullet" :class="{ 'fhc-bullet-red': termin.fixtermin, 'fhc-bullet-green': !termin.fixtermin }"></p>
+-->
+					</div>
+					<div class="col-2 d-flex justify-content-start align-items-start">
+						<div class="position-relative" :class="getDateStyle(termin)">
+							<VueDatePicker
+								v-model="termin.datum"
+								:clearable="false"
+								:disabled="true"
+								:enable-time-picker="false"
+								:format="formatDate"
+								:text-input="true"
+								auto-apply>
+							</VueDatePicker>
+							<i class="position-absolute abgabe-zieldatum-overlay fa-solid fa-2x" :class="getDateStyle(termin, 'icon')"></i>
+						</div>
+					</div>
+					<div class="col-2 d-flex justify-content-start align-items-start">{{ termin.bezeichnung }}</div>
+					<div class="col-3 d-flex justify-content-start align-items-start">
+						<Textarea style="margin-bottom: 4px;" v-model="termin.kurzbz" rows="3" cols="45" :disabled="true"></Textarea>
+					</div>
+					<div class="col-1 d-flex flex-column justify-content-start align-items-center">
+						{{ termin.abgabedatum?.split("-").reverse().join(".") }}
+						<a v-if="termin?.abgabedatum" @click="downloadAbgabe(termin)" style="margin-left:4px; cursor: pointer;">
+							<i class="fa-solid fa-3x fa-file-pdf"></i>
+						</a>
+					</div>
+					<div class="col-3" v-if="!viewMode">
+						<div class="row">
+							<div class="col-8">
+								<Upload v-if="termin && termin.allowedToUpload" accept=".pdf" v-model="termin.file"></Upload>
+							</div>
+							<div class="col-4">
+								<button class="btn btn-primary border-0" @click="upload(termin)" :disabled="!termin.allowedToUpload">
+									Upload
+									<i style="margin-left: 8px" class="fa-solid fa-upload"></i>
+								</button>
+							</div>
+						</div>
+					</div>
 				</div>
 			</div>
-			
-			<Accordion :multiple="true">
-				<template v-for="termin in this.projektarbeit?.abgabetermine">
-					<AccordionTab :headerClass="termin.dateStyle + '-header'">
-						<template #header>
-							<div class="d-flex flex-nowrap align-items-center w-100">
-								<div class="flex-shrink-0 d-flex align-items-center justify-content-center" style="width: 36px; height: 36px; margin-left: -66px;">
-									<i v-if="termin.dateStyle == 'verspaetet'" v-tooltip.right="getTooltipVerspaetet" class="fa-solid fa-triangle-exclamation"></i>
-									<i v-else-if="termin.dateStyle == 'verpasst'" v-tooltip.right="getTooltipVerpasst" class="fa-solid fa-calendar-xmark"></i>
-									<i v-else-if="termin.dateStyle == 'abzugeben'" v-tooltip.right="getTooltipAbzugeben" class="fa-solid fa-hourglass-half"></i>
-									<i v-else-if="termin.dateStyle == 'standard'" v-tooltip.right="getTooltipStandard" class="fa-solid fa-clock"></i>
-									<i v-else-if="termin.dateStyle == 'abgegeben'" v-tooltip.right="getTooltipAbgegeben" class="fa-solid fa-paperclip"></i>
-									<i v-else-if="termin.dateStyle == 'beurteilungerforderlich'" v-tooltip.right="getTooltipBeurteilungerforderlich" class="fa-solid fa-list-check"></i>
-									<i v-else-if="termin.dateStyle == 'bestanden'" v-tooltip.right="getTooltipBestanden" class="fa-solid fa-check"></i>
-									<i v-else-if="termin.dateStyle == 'nichtbestanden'" v-tooltip.right="getTooltipNichtBestanden" class="fa-solid fa-circle-exclamation"></i>
-							
-								</div>
-								<div class="text-start px-2" style="min-width: 150px; max-width: 300px; margin-left: 40px">
-									<span>{{ termin ? $p.t('abgabetool/c4paatyp' + termin.paabgabetyp_kurzbz) : '' }}</span>
-								</div>
-								<div class="text-start px-2" style="min-width: 100px;">
-									<span>{{ formatDate(termin.datum) }}</span>
-								</div>
-								<div class="px-1">
-									<i v-if="termin?.fixtermin" v-tooltip.right="getTooltipFixtermin" class="fa-solid fa-lock"></i>
-									<i v-if="termin?.abgabedatum && isMobile" v-tooltip.right="getTooltipAbgabeDetected" class="fa-solid fa-file"></i>
-								</div>
-								<div v-if="termin?.abgabedatum && !isMobile" class="px-1">
-									<i v-tooltip.right="getTooltipAbgabeDetected" class="fa-solid fa-file"></i>
-								</div>
-								<div class="flex-grow-1 text-end pe-2">
-									<span class="fw-bold">{{getNoteBezeichnung(termin)}}</span>
-								</div>
-							</div>				
-						</template>
-						
-						<div v-if="isMobile" class="row mt-2 align-items-center">						
-							<Inplace
-								closable
-								:closeButtonProps="{
-									style: {
-										position: 'relative',
-										bottom: '100px',
-										left: '80%',
-										zIndex: 1
-									}
-								}"
-							>
-								<template #display>{{ $capitalize($p.t('abgabetool/c4tapForTooltipInfo'))}}</template>
-								<template #content>
-									<div class="col-auto">
-										<div class="row">
-											<div class="col-12 col-md-3 fw-bold align-content-center">{{ $capitalize($p.t('abgabetool/c4abgabeZeitstatus')) }}</div>
-											<div class="col-12 col-md-9">{{$p.t('abgabetool/c4tooltip' + $capitalize(termin?.dateStyle) )}}</div>
-										</div>
-										<div class="row">
-											<div class="col-12 col-md-3 fw-bold align-content-center">{{ $capitalize($p.t('abgabetool/c4fixterminv4')) }}</div>
-											<div class="col-12 col-md-9">{{!termin?.fixtermin}}</div>
-										</div>
-										<div class="row">
-											<div class="col-12 col-md-3 fw-bold align-content-center">{{ $capitalize($p.t('abgabetool/c4fileUploaded')) }}</div>
-											<div class="col-12 col-md-9">{{termin?.abgabedatum !== null}}</div>
-										</div>
-									</div>
-								</template>
-							</Inplace>
-
-						
-						</div>
-						
-						<div class="row mt-2">
-							<div class="col-12 col-md-3 align-content-center">
-								<div class="row fw-bold" style="margin-left: 2px">{{$capitalize( $p.t('abgabetool/c4zieldatum') )}}</div>
-								<div class="row fw-light" style="margin-left: 2px">{{$capitalize( $p.t('abgabetool/c4abgabeuntil2359') )}}</div>
-							</div>
-							<div class="col-12 col-md-9">
-								<VueDatePicker
-									v-model="termin.datum"
-									:clearable="false"
-									:disabled="true"
-									:enable-time-picker="false"
-									:format="formatDate"
-									:text-input="true"
-									auto-apply>
-								</VueDatePicker>
-							</div>
-						</div>
-						
-						<div class="row mt-2">
-							<div class="col-12 col-md-3 fw-bold align-content-center">{{$capitalize( $p.t('abgabetool/c4abgabetyp') )}}</div>
-							<div class="col-12 col-md-9">
-								{{ termin ? $p.t('abgabetool/c4paatyp' + termin.paabgabetyp_kurzbz) : '' }}
-							</div>
-						</div>
-						
-						<div class="row mt-2" v-if="termin.note">
-							<div class="col-12 col-md-3 fw-bold align-content-center">{{$capitalize( $p.t('abgabetool/c4note') )}}</div>
-							<div class="col-12 col-md-9">
-								<div class="col-auto d-flex justify-content-start align-items-start">
-									{{ getTerminNoteBezeichnung(termin) }}
-								</div>
-							</div>
-						</div>
-						
-						<div class="row mt-2" v-if="termin.paabgabetyp_kurzbz === 'qualgate1' || termin.paabgabetyp_kurzbz === 'qualgate2'">
-							<div class="col-12 col-md-3 fw-bold align-content-center">{{$capitalize( $p.t('abgabetool/c4notizQualGatev2') )}}</div>
-							<div class="col-12 col-md-9">
-								<Textarea style="margin-bottom: 4px;" v-model="termin.beurteilungsnotiz" rows="1" class="w-100" disabled></Textarea>
-							</div>
-						</div>
-						
-						<div v-if="termin.kurzbz && termin.kurzbz.length > 0" class="row mt-2">
-							<div class="col-12 col-md-3 fw-bold align-content-center">{{$capitalize( $p.t('abgabetool/c4abgabekurzbz') )}}</div>
-							<div class="col-12 col-md-9">
-								<Textarea style="margin-bottom: 4px;" v-model="termin.kurzbz" rows="1" class="w-100" :disabled="true"></Textarea>
-							</div>
-						</div>
-						
-						<div class="row mt-2" v-if="termin.upload_allowed">
-							<div class="col-12 col-md-3 fw-bold align-content-center">{{$capitalize( $p.t('abgabetool/c4abgabedatum') )}}</div>
-							<div class="col-12 col-md-9">
-							<template v-if="termin?.abgabedatum">
-								<div class="row">
-									<div style="width:100px; align-content: center;">
-										<h6>{{ termin.abgabedatum?.split("-").reverse().join(".") }}</h6>
-									</div>
-									
-									<div class="col-auto">
-										<button v-if="termin?.abgabedatum" @click="downloadAbgabe(termin)" class="btn btn-primary">
-											<a> {{$capitalize($p.t('abgabetool/c4downloadAbgabe') )}} <i class="fa fa-file-pdf" style="margin-left:4px; cursor: pointer;"></i></a>
-										</button>
-									</div>	
-									<template v-if="termin.paabgabetyp_kurzbz == 'end'">	
-										<div v-if="termin?.signatur !== undefined && termin?.signatur !== null" class="col-auto">
-											<Message v-if="termin?.signatur == true" severity="success" :closable="false" :pt="getMessagePtStyle"> {{ $p.t('abgabetool/c4signaturGefunden') }} </Message>
-											<Message v-else-if="termin?.signatur == false" severity="error" :closable="false" :pt="getMessagePtStyle"> {{ $p.t('abgabetool/c4keineSignatur') }} </Message>
-											<Message v-else-if="termin?.signatur == 'error'" severity="warn" :closable="false" :pt="getMessagePtStyle"> {{ $p.t('abgabetool/c4signaturServerError') }} </Message>
-										</div>
-<!--										<div v-else class="col-auto">-->
-<!--											<Message severity="info" :closable="false" :pt="getMessagePtStyle"> {{ $p.t('abgabetool/c4noFileFound') }} </Message>-->
-<!--										</div>-->
-									</template>
-								</div>					
-							</template>
-							<template v-else>
-								{{ $capitalize( $p.t('abgabetool/c4nochNichtsAbgegeben') )}}
-							</template>
-							</div>
-						</div>
-						
-						<div class="row mt-2" v-if="termin.upload_allowed">
-							<div class="col-12 col-md-3 fw-bold align-content-center">{{$capitalize( $p.t('abgabetool/c4fileupload') )}}</div>
-							<div class="col-12 col-md-9">
-								<div class="row" v-if="termin?.allowedToUpload">
-									<div class="col-12 col-sm-6 mb-2">
-										<Upload 
-											accept=".pdf" 
-											v-model="termin.file"
-										></Upload>
-									</div>
-									<div class="col-12 col-sm-6">
-										<button 
-											class="btn btn-primary border-0 w-100" 
-											@click="upload(termin)" 
-										>
-											{{$capitalize( $p.t('abgabetool/c4upload') )}}
-											<i class="fa-solid fa-upload"></i>
-										</button>
-									</div>
-								</div>
-								<div class="row" v-else-if="!termin?.allowedToUpload || isViewMode" v-tooltip.right="getTooltipNotAllowedToUpload">
-									<div class="col-12 col-sm-6 mb-2">
-										<Upload 
-											disabled
-											accept=".pdf" 
-											v-model="termin.file"
-										></Upload>
-									</div>
-									<div class="col-12 col-sm-6">
-										<button 
-											class="btn btn-primary border-0 w-100" 
-											@click="upload(termin)" 
-											disabled
-										>
-											{{$capitalize( $p.t('abgabetool/c4upload') )}}
-											<i class="fa-solid fa-upload"></i>
-										</button>
-									</div>
-								</div>
-							</div>
-						</div>
-					</AccordionTab>
-				</template>
-			</Accordion>
-			
-			<div v-if="projektarbeit?.abgabetermine.length == 0" style="display:flex; justify-content: center; align-content: center;">
-				<h5>{{ $capitalize( $p.t('abgabetool/c4keineAbgabetermineGefunden') )}}</h5>
-			</div>
-			
 		 </div>
 	 	
-	 	<bs-modal 
-	 		ref="modalContainerEnduploadZusatzdaten"
-	 		class="bootstrap-prompt"
-	 		dialogClass="bordered-modal modal-lg">
+	 	<bs-modal ref="modalContainerEnduploadZusatzdaten" class="bootstrap-prompt" dialogClass="modal-lg">
 			<template v-slot:title>
 				<div>
-					{{$capitalize( $p.t('abgabetool/c4enduploadZusatzdaten') )}}
+					{{$p.t('abgabetool/c4enduploadZusatzdaten')}}
 				</div>
 				<div class="row mb-3 align-items-start">
 					
@@ -558,13 +285,13 @@ export const AbgabeStudentDetail = {
 				</div>
 				<div class="row mb-3 align-items-start">
 					
-					<p class="ml-4 mr-4">{{$capitalize( $p.t('abgabetool/c4titel') )}}: {{ projektarbeit?.titel }}</p>
+					<p class="ml-4 mr-4">Titel: {{ projektarbeit?.titel }}</p>
 				
 				</div>
 			</template>
 			<template v-slot:default>
 				<div class="row mb-3 align-items-start">
-					<div class="row">{{$capitalize( $p.t('abgabetool/c4Sprache') )}}</div>
+					<div class="row">{{$p.t('abgabetool/c4Sprache')}}</div>
 					<div class="row">
 						<Dropdown 
 							:style="{'width': '100%'}"
@@ -585,37 +312,35 @@ export const AbgabeStudentDetail = {
 <!--				-->
 <!--				</div>-->
 				<div class="row mb-3 align-items-start">
-					<div class="row">{{$capitalize( $p.t('abgabetool/c4schlagwoerterGer') )}}</div>
+					<div class="row">{{$p.t('abgabetool/c4schlagwoerterGer')}}</div>
 					<div class="row">
-						<Textarea v-model="form.schlagwoerter" class="w-100"></Textarea>
+						<Textarea v-model="form.schlagwoerter"></Textarea>
 					</div>
 				</div>
 				
 				<div class="row mb-3 align-items-start">
-					<div class="row">{{$capitalize( $p.t('abgabetool/c4schlagwoerterEng') )}}</div>
+					<div class="row">{{$p.t('abgabetool/c4schlagwoerterEng')}}</div>
 					<div class="row">
-						<Textarea v-model="form.schlagwoerter_en" class="w-100"></Textarea>
+						<Textarea v-model="form.schlagwoerter_en"></Textarea>
 					</div>
 				</div>
 				
 				<div class="row mb-3 align-items-start">
-					<div class="row">{{$capitalize( $p.t('abgabetool/c4abstractGer') )}}</div>
+					<div class="row">{{$p.t('abgabetool/c4abstractGer')}}</div>
 					<div class="row">
-						<Textarea v-model="form.abstract" rows="10" maxlength="5000" class="w-100"></Textarea>
-						<p>{{ form.abstract?.length ? form.abstract.length : 0 }} / 5000 characters</p>
+						<Textarea v-model="form.abstract" rows="10"></Textarea>
 					</div>
 				</div>
 
 				<div class="row mb-3 align-items-start">
-					<div class="row">{{$capitalize( $p.t('abgabetool/c4abstractEng') )}}</div>
+					<div class="row">{{$p.t('abgabetool/c4abstractEng')}}</div>
 					<div class="row">
-						<Textarea v-model="form.abstract_en" rows="10" maxlength="5000" class="w-100"></Textarea>
-						<p>{{ form.abstract_en?.length ? form.abstract_en.length : 0 }} / 5000 characters</p>
+						<Textarea v-model="form.abstract_en" rows="10"></Textarea>
 					</div>				
 				</div>
 				
 				<div class="row mb-3 align-items-start">
-					<div class="row">{{$capitalize( $p.t('abgabetool/c4seitenanzahl') )}}</div>
+					<div class="row">{{$p.t('abgabetool/c4seitenanzahl')}}</div>
 					<div class="row">
 						<InputNumber 
 							v-model="form.seitenanzahl"
@@ -628,7 +353,7 @@ export const AbgabeStudentDetail = {
 					<div v-html="getEid"></div>
 					<div class="row">
 						<div class="col-9"></div>
-						<div class="col-2"><p>{{$capitalize( $p.t('abgabetool/c4gelesenUndAkzeptiert') )}}</p></div>
+						<div class="col-2"><p>{{ $p.t('abgabetool/c4gelesenUndAkzeptiert') }}</p></div>
 						<div class="col-1">
 							
 							<Checkbox 
@@ -643,8 +368,7 @@ export const AbgabeStudentDetail = {
 				
 			</template>
 			<template v-slot:footer>
-				<div v-show="!allowedToSaveZusatzdaten">{{ $p.t('abgabetool/c4zusatzdatenausfuellen') }}</div>
-				<button class="btn btn-primary" :disabled="!getAllowedToSendEndupload" @click="triggerEndupload">{{$capitalize( $p.t('ui/hochladen') )}}</button>
+				<button class="btn btn-primary" :disabled="getEnduploadErlaubt" @click="triggerEndupload">{{$p.t('ui/hochladen')}}</button>
 			</template>
 		</bs-modal>